osmocom-commitlog

osmocom-commitlog@lists.osmocom.org

7948 discussions

osmo-hlr.git branch master updated. 0.1.0-22-g63f68cc
by gitosis＠osmocom.org 19 Dec '17

19 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 63f68ccc4cdee6e8de2e4e63d456d4c340af5b51 (commit) from b5d77012d1d74bbb28b07a374c436045ed3e43ea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=63f68ccc4cdee6e8de2e4e63d456d4c… commit 63f68ccc4cdee6e8de2e4e63d456d4c340af5b51 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Tue Dec 19 15:50:54 2017 +0100 fix test_subscriber_errors.ctrl after libosmocore change libosmocore Ie35a02555b76913bb12734a76fc40fde7ffb244d "ctrl: on parse errors, return a detailed message to sender" the test_subscriber_errors.ctrl test fails. Adjust the expected error message. Change-Id: I3aee1507721cd073f72369150d0fb3cff0fdf66f ----------------------------------------------------------------------- Summary of changes: tests/test_subscriber_errors.ctrl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

libosmocore.git branch master updated. 0.10.2-71-gc0b0b623
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via c0b0b623053f16790d7d675812befe382ebdfd6e (commit) via f2e83ad40d231e87e2604ec4c97c810a8182e145 (commit) via 1b8b152e791df579035f7b7c8dd621938f7de3c0 (commit) via f2c10f108202c350a3c16f49156b11b0cd0dfa96 (commit) via 6769ad6e0aca58ccc037746885976ea4f85cb318 (commit) via 83aee83ec6a9d3d5e4f9251221c9639028d3da89 (commit) via d53d2169442fd43ed1538c3970c6e7cb6096f20a (commit) via 0ab6eca80a47706375c5d54d829c4dee6e1228fc (commit) via 9910bbc62d1c19a2cd75eeb1248c351b6a1e3f06 (commit) from aa84b71f0fe014156e90dde2f0c44694368dc034 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=c0b0b623053f16790d7d675812be… commit c0b0b623053f16790d7d675812befe382ebdfd6e Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 01:12:35 2017 +0100 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender as reply. Retain the previous "Command parser error" reply only in case ctrl_cmd_parse2() should return NULL, which shouldn't actually happen at all. Change-Id: Ie35a02555b76913bb12734a76fc40fde7ffb244d http://cgit.osmocom.org/libosmocore/commit/?id=f2e83ad40d231e87e2604ec4c97c… commit f2e83ad40d231e87e2604ec4c97c810a8182e145 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 01:05:25 2017 +0100 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end simply talloc_free() them and return NULL. A first step to report these errors to the ctrl command issuer is to not return NULL and instead return the cmd with type = CTRL_TYPE_ERROR. Add ctrl_cmd_parse2() to return such instead of NULL. To stay API compatible, provide ctrl_cmd_parse2() to return a cmd on errors. ctrl_cmd_parse() retains identical behavior but becomes just a simple wrapper around ctrl_cmd_parse2() which discards the cmd on error. No need really to deprecate ctrl_cmd_parse() yet; especially as long as compiler warnings might break jenkins builds. Change-Id: I5047c9f977d70b03eea77cbcfd2b96d43ea46880 http://cgit.osmocom.org/libosmocore/commit/?id=1b8b152e791df579035f7b7c8dd6… commit 1b8b152e791df579035f7b7c8dd621938f7de3c0 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Fri Dec 15 20:41:28 2017 +0100 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 http://cgit.osmocom.org/libosmocore/commit/?id=f2c10f108202c350a3c16f49156b… commit f2c10f108202c350a3c16f49156b11b0cd0dfa96 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 04:05:21 2017 +0100 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle() returns CTRL_CMD_HANDLED. CTRL_CMD_HANDLED is triggered by GET_REPLY / SET_REPLY parsing, as show by ctrl_test.c. With the memleak fixed, adjust expected test output and make a detected mem leak abort the test immediately. Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 http://cgit.osmocom.org/libosmocore/commit/?id=6769ad6e0aca58ccc03774688597… commit 6769ad6e0aca58ccc037746885976ea4f85cb318 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 04:01:54 2017 +0100 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042 http://cgit.osmocom.org/libosmocore/commit/?id=83aee83ec6a9d3d5e4f9251221c9… commit 83aee83ec6a9d3d5e4f9251221c9639028d3da89 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 05:38:37 2017 +0100 ctrl_test: expand to test message handling and detect mem leaks Subsequent patches that tighten CTRL input validation will make the results more interesting. Change-Id: Idd4cc7d193db1a7d761f72ed33ed46eea450a78f http://cgit.osmocom.org/libosmocore/commit/?id=d53d2169442fd43ed1538c3970c6… commit d53d2169442fd43ed1538c3970c6e7cb6096f20a Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 03:57:56 2017 +0100 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory leak in CTRL msgb handling by a unit test that needs this separation. Change-Id: Ie09e39db668b866eeb80399b82e7b04b8f5ad7c3 http://cgit.osmocom.org/libosmocore/commit/?id=0ab6eca80a47706375c5d54d829c… commit 0ab6eca80a47706375c5d54d829c4dee6e1228fc Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 01:03:37 2017 +0100 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b http://cgit.osmocom.org/libosmocore/commit/?id=9910bbc62d1c19a2cd75eeb1248c… commit 9910bbc62d1c19a2cd75eeb1248c351b6a1e3f06 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sat Dec 16 00:54:52 2017 +0100 utils: add osmo_escape_str() To report invalid characters in identifiers, it is desirable to escape any weird characters. Otherwise we might print stray newlines or control characters in the log output. ctrl_test.c already uses a print_escaped() function, which will be replaced by osmo_escape_str() in a subsequent patch. control_cmd.c will use osmo_escape_str() to log invalid identifiers. Change-Id: Ic685eb63dead3967d01aaa4f1e9899e5461ca49a ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/utils.h | 3 + include/osmocom/ctrl/control_cmd.h | 1 + include/osmocom/ctrl/control_if.h | 2 + src/ctrl/control_cmd.c | 18 ++- src/ctrl/control_if.c | 74 +++++++----- src/utils.c | 87 +++++++++++++ tests/ctrl/ctrl_test.c | 242 +++++++++++++++++++++++++------------ tests/ctrl/ctrl_test.ok | 167 ++++++++++++++++++------- tests/utils/utils_test.c | 48 ++++++++ tests/utils/utils_test.ok | 29 +++++ 10 files changed, 526 insertions(+), 145 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libosmocore.git branch master updated. 0.10.2-62-gaa84b71f
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

1 0

osmo-pcu.git branch master updated. 0.4.0-19-gea9968f
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via ea9968f6854cbfe79506efedc43a953a7c38cdd6 (commit) from ef784e4e9e09e9bdcc81b6223f26ef22e88cc3c7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=ea9968f6854cbfe79506efedc43a953… commit ea9968f6854cbfe79506efedc43a953a7c38cdd6 Author: Max <msuraev(a)sysmocom.de> Date: Mon Dec 18 22:52:52 2017 +0100 Fix tests after rate_ctr change Recent change lin libosmocore disallow registering rate_ctr with the same name and indexing multiple times. To accommodate to this check if rate counters arealready allocated (by static allocator of BTS singleton for example) and register rate counter with different index. This fixes the tests for now but eventually we'll remove the BTS singleton which will allow us to remove this hack. Change-Id: I7c552ce653b44ec3a31049641728926adc07361d Related: OS#2757 ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch master updated. 0.4.0-18-gef784e4
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via ef784e4e9e09e9bdcc81b6223f26ef22e88cc3c7 (commit) from 912131803bfbc275e2d9f11fbb0e4413d7b44630 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=ef784e4e9e09e9bdcc81b6223f26ef2… commit ef784e4e9e09e9bdcc81b6223f26ef22e88cc3c7 Author: Max <msuraev(a)sysmocom.de> Date: Fri Dec 15 15:19:28 2017 +0100 Remove unused includes and forward declarations Change-Id: I59da04edd1b8ff965bbfbe00ccae1f7c9b6e5301 ----------------------------------------------------------------------- Summary of changes: src/gprs_bssgp_pcu.cpp | 1 - src/gprs_debug.cpp | 9 --------- src/gprs_debug.h | 2 -- src/gprs_ms.h | 3 --- src/gprs_rlcmac.cpp | 1 - src/gprs_rlcmac.h | 1 - src/llc.cpp | 1 - src/llc.h | 1 - src/rlc.cpp | 1 - src/rlc.h | 1 - src/sba.h | 1 - src/tbf.h | 2 -- 12 files changed, 24 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

libosmocore.git branch master updated. 0.10.2-61-gd589f1dc
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

1 0

osmo-python-tests.git branch master updated. 1a5364696eaf66a382e6d451bc4255622d845a92
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 1a5364696eaf66a382e6d451bc4255622d845a92 (commit) from 6ccd0785d849e7a32e69c0216488a03308d68bc9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=1a5364696eaf66a… commit 1a5364696eaf66a382e6d451bc4255622d845a92 Author: Max <msuraev(a)sysmocom.de> Date: Mon Dec 18 10:58:12 2017 +0100 Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with installation anyway. Make sure that it fails if any errorsis encountered bymanually call compilation step. Change-Id: I2235e3fff21b7c09d3fba00ecdccca7f4515e071 Related: OS#2770 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-python-tests.git branch user/max/for_laforge deleted. 1a5364696eaf66a382e6d451bc4255622d845a92
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, user/max/for_laforge has been deleted was 1a5364696eaf66a382e6d451bc4255622d845a92 ----------------------------------------------------------------------- 1a5364696eaf66a382e6d451bc4255622d845a92 Explicitly check syntax in jenkins tests ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-python-tests.git branch master updated. 6ccd0785d849e7a32e69c0216488a03308d68bc9
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 6ccd0785d849e7a32e69c0216488a03308d68bc9 (commit) via 120075a6a5715337270cc964c2f154f9ae7b8471 (commit) from c35bb473e449ec8b0d6e6ab64196331e89efef95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: osmopy/__init__.py | 14 ++------------ osmopy/obscvty.py | 17 +++++++++-------- osmopy/osmoutil.py | 13 +++++++------ {osmopy => scripts}/osmo_ctrl.py | 14 +++++++------- {osmopy => scripts}/osmo_interact_common.py | 0 {osmopy => scripts}/osmo_interact_ctrl.py | 0 {osmopy => scripts}/osmo_interact_vty.py | 0 {osmopy => scripts}/osmo_verify_transcript_ctrl.py | 0 {osmopy => scripts}/osmo_verify_transcript_vty.py | 0 {osmopy => scripts}/osmodumpdoc.py | 0 {osmopy => scripts}/osmotestconfig.py | 0 {osmopy => scripts}/osmotestvty.py | 0 {osmopy => scripts}/soap.py | 0 {osmopy => scripts}/twisted_ipa.py | 0 setup.py | 18 ++++++++---------- 15 files changed, 33 insertions(+), 43 deletions(-) rename {osmopy => scripts}/osmo_ctrl.py (91%) rename {osmopy => scripts}/osmo_interact_common.py (100%) rename {osmopy => scripts}/osmo_interact_ctrl.py (100%) rename {osmopy => scripts}/osmo_interact_vty.py (100%) rename {osmopy => scripts}/osmo_verify_transcript_ctrl.py (100%) rename {osmopy => scripts}/osmo_verify_transcript_vty.py (100%) rename {osmopy => scripts}/osmodumpdoc.py (100%) rename {osmopy => scripts}/osmotestconfig.py (100%) rename {osmopy => scripts}/osmotestvty.py (100%) rename {osmopy => scripts}/soap.py (100%) rename {osmopy => scripts}/twisted_ipa.py (100%) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-python-tests.git branch user/max/for_laforge created. 1a5364696eaf66a382e6d451bc4255622d845a92
by gitosis＠osmocom.org 18 Dec '17

18 Dec '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, user/max/for_laforge has been created at 1a5364696eaf66a382e6d451bc4255622d845a92 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=1a5364696eaf66a… commit 1a5364696eaf66a382e6d451bc4255622d845a92 Author: Max <msuraev(a)sysmocom.de> Date: Mon Dec 18 10:58:12 2017 +0100 Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with installation anyway. Make sure that it fails if any errorsis encountered bymanually call compilation step. Change-Id: I2235e3fff21b7c09d3fba00ecdccca7f4515e071 Related: OS#2770 http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=6ccd0785d849e7a… commit 6ccd0785d849e7a32e69c0216488a03308d68bc9 Author: Max <msuraev(a)sysmocom.de> Date: Fri Dec 15 12:15:39 2017 +0100 Fix python3 compatibility Use print() function with proper import. Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=120075a6a571533… commit 120075a6a5715337270cc964c2f154f9ae7b8471 Author: Max <msuraev(a)sysmocom.de> Date: Fri Dec 15 12:13:59 2017 +0100 Move scripts to appropriate directory Having the scripts in the same directory with library code means that it'll be installed unconditionally regardless of version check in setup.py which makes it impossible to write separate tests for python 2 and 3. Fix this by moving the scripts into separate directory and adjusting init and setup files accordingly. This is necessary for implementing proper CI tests in follow-up patches. Change-Id: I30cdf0f85b2a60a235960911c9827f4129da40db ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog