This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via c0b0b623053f16790d7d675812befe382ebdfd6e (commit) via f2e83ad40d231e87e2604ec4c97c810a8182e145 (commit) via 1b8b152e791df579035f7b7c8dd621938f7de3c0 (commit) via f2c10f108202c350a3c16f49156b11b0cd0dfa96 (commit) via 6769ad6e0aca58ccc037746885976ea4f85cb318 (commit) via 83aee83ec6a9d3d5e4f9251221c9639028d3da89 (commit) via d53d2169442fd43ed1538c3970c6e7cb6096f20a (commit) via 0ab6eca80a47706375c5d54d829c4dee6e1228fc (commit) via 9910bbc62d1c19a2cd75eeb1248c351b6a1e3f06 (commit) from aa84b71f0fe014156e90dde2f0c44694368dc034 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=c0b0b623053f16790d7d675812bef... commit c0b0b623053f16790d7d675812befe382ebdfd6e Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 01:12:35 2017 +0100 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender as reply. Retain the previous "Command parser error" reply only in case ctrl_cmd_parse2() should return NULL, which shouldn't actually happen at all. Change-Id: Ie35a02555b76913bb12734a76fc40fde7ffb244d http://cgit.osmocom.org/libosmocore/commit/?id=f2e83ad40d231e87e2604ec4c97c8... commit f2e83ad40d231e87e2604ec4c97c810a8182e145 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 01:05:25 2017 +0100 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end simply talloc_free() them and return NULL. A first step to report these errors to the ctrl command issuer is to not return NULL and instead return the cmd with type = CTRL_TYPE_ERROR. Add ctrl_cmd_parse2() to return such instead of NULL. To stay API compatible, provide ctrl_cmd_parse2() to return a cmd on errors. ctrl_cmd_parse() retains identical behavior but becomes just a simple wrapper around ctrl_cmd_parse2() which discards the cmd on error. No need really to deprecate ctrl_cmd_parse() yet; especially as long as compiler warnings might break jenkins builds. Change-Id: I5047c9f977d70b03eea77cbcfd2b96d43ea46880 http://cgit.osmocom.org/libosmocore/commit/?id=1b8b152e791df579035f7b7c8dd62... commit 1b8b152e791df579035f7b7c8dd621938f7de3c0 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Fri Dec 15 20:41:28 2017 +0100 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 http://cgit.osmocom.org/libosmocore/commit/?id=f2c10f108202c350a3c16f49156b1... commit f2c10f108202c350a3c16f49156b11b0cd0dfa96 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 04:05:21 2017 +0100 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle() returns CTRL_CMD_HANDLED. CTRL_CMD_HANDLED is triggered by GET_REPLY / SET_REPLY parsing, as show by ctrl_test.c. With the memleak fixed, adjust expected test output and make a detected mem leak abort the test immediately. Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 http://cgit.osmocom.org/libosmocore/commit/?id=6769ad6e0aca58ccc037746885976... commit 6769ad6e0aca58ccc037746885976ea4f85cb318 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 04:01:54 2017 +0100 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042 http://cgit.osmocom.org/libosmocore/commit/?id=83aee83ec6a9d3d5e4f9251221c96... commit 83aee83ec6a9d3d5e4f9251221c9639028d3da89 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 05:38:37 2017 +0100 ctrl_test: expand to test message handling and detect mem leaks Subsequent patches that tighten CTRL input validation will make the results more interesting. Change-Id: Idd4cc7d193db1a7d761f72ed33ed46eea450a78f http://cgit.osmocom.org/libosmocore/commit/?id=d53d2169442fd43ed1538c3970c6e... commit d53d2169442fd43ed1538c3970c6e7cb6096f20a Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 03:57:56 2017 +0100 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory leak in CTRL msgb handling by a unit test that needs this separation. Change-Id: Ie09e39db668b866eeb80399b82e7b04b8f5ad7c3 http://cgit.osmocom.org/libosmocore/commit/?id=0ab6eca80a47706375c5d54d829c4... commit 0ab6eca80a47706375c5d54d829c4dee6e1228fc Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 01:03:37 2017 +0100 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b http://cgit.osmocom.org/libosmocore/commit/?id=9910bbc62d1c19a2cd75eeb1248c3... commit 9910bbc62d1c19a2cd75eeb1248c351b6a1e3f06 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Sat Dec 16 00:54:52 2017 +0100 utils: add osmo_escape_str() To report invalid characters in identifiers, it is desirable to escape any weird characters. Otherwise we might print stray newlines or control characters in the log output. ctrl_test.c already uses a print_escaped() function, which will be replaced by osmo_escape_str() in a subsequent patch. control_cmd.c will use osmo_escape_str() to log invalid identifiers. Change-Id: Ic685eb63dead3967d01aaa4f1e9899e5461ca49a ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/utils.h | 3 + include/osmocom/ctrl/control_cmd.h | 1 + include/osmocom/ctrl/control_if.h | 2 + src/ctrl/control_cmd.c | 18 ++- src/ctrl/control_if.c | 74 +++++++----- src/utils.c | 87 +++++++++++++ tests/ctrl/ctrl_test.c | 242 +++++++++++++++++++++++++------------ tests/ctrl/ctrl_test.ok | 167 ++++++++++++++++++------- tests/utils/utils_test.c | 48 ++++++++ tests/utils/utils_test.ok | 29 +++++ 10 files changed, 526 insertions(+), 145 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications