osmocom-commitlog

osmocom-commitlog@lists.osmocom.org

7948 discussions

openbsc.git branch max/nat updated. 0.15.0-199-g8313c0f
by gitosis＠osmocom.org 31 Mar '16

31 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, max/nat has been updated discards 641b1cc0d98edd2de5782ac209981b5090e0f975 (commit) via 8313c0fda14f085cb2666bf89e99cad67ad05511 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (641b1cc0d98edd2de5782ac209981b5090e0f975) \ N -- N -- N (8313c0fda14f085cb2666bf89e99cad67ad05511) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=8313c0fda14f085cb2666bf89e99cad6… commit 8313c0fda14f085cb2666bf89e99cad67ad05511 Author: Max <msuraev(a)sysmocom.de> Date: Tue Mar 29 17:06:32 2016 +0200 wip: reload config dynamically ----------------------------------------------------------------------- Summary of changes: openbsc/src/osmo-bsc_nat/bsc_nat.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch max/nat updated. 0.15.0-199-g641b1cc
by gitosis＠osmocom.org 30 Mar '16

30 Mar '16

1 0

osmo-iuh.git branch master updated. e5c5525baebac7e784f801f91fc12fca700a3c4e
by gitosis＠osmocom.org 30 Mar '16

30 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via e5c5525baebac7e784f801f91fc12fca700a3c4e (commit) via e25faa89662f069bd67e6cc37626fff59e05f1d6 (commit) via 3588810cb779274b5536263120be7796d41f69db (commit) via 5dbb7b2c3fb0eaf357acf23b302167778f8d150d (commit) via d4598fa45351f9bb038d0666e7ff280f3a12ff62 (commit) via 576f642eba7266108ac51537aafc0e13da36436a (commit) via 3da8608b6ad014fc74536dbb49019704fd425b8c (commit) from c04eb533e1bb1588bbe1ffaa1c197caf44a275ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: doc/{README.msc => README} | 0 src/Makefile.am | 5 +- src/hnbgw_cn.c | 12 ++-- src/sccp_helpers.c | 135 --------------------------------------------- src/sccp_helpers.h | 33 ----------- src/tests/hnb-test.c | 95 ++++++++++++++++++++++++------- 6 files changed, 84 insertions(+), 196 deletions(-) rename doc/{README.msc => README} (100%) delete mode 100644 src/sccp_helpers.c delete mode 100644 src/sccp_helpers.h hooks/post-receive -- Osmocom code for Iuh interface

1 0

osmo-iuh.git branch sysmocom/iu-cs updated. bb2bdfe1718295bcaf698fa80452bdeea4501721
by gitosis＠osmocom.org 30 Mar '16

30 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, sysmocom/iu-cs has been updated discards 428e074b9b396a77a4d319a857bb6af2b127861f (commit) discards 557808becd8289a36e5ed6e225da78b4fd1ea39f (commit) discards a8ea2cf29d3ea87b0cb46eae3b99fa23a1fb2b14 (commit) discards 9b0e769a7f2fe6efda717de3dda380926e073cf2 (commit) discards e90b54ace1600146bb2ffeccaa76b7b7622b456c (commit) discards e30c015feb490d8f8093e8286c7f1d0ee68fde74 (commit) via bb2bdfe1718295bcaf698fa80452bdeea4501721 (commit) via e5c5525baebac7e784f801f91fc12fca700a3c4e (commit) via e25faa89662f069bd67e6cc37626fff59e05f1d6 (commit) via 3588810cb779274b5536263120be7796d41f69db (commit) via 5dbb7b2c3fb0eaf357acf23b302167778f8d150d (commit) via d4598fa45351f9bb038d0666e7ff280f3a12ff62 (commit) via 576f642eba7266108ac51537aafc0e13da36436a (commit) via 3da8608b6ad014fc74536dbb49019704fd425b8c (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (428e074b9b396a77a4d319a857bb6af2b127861f) \ N -- N -- N (bb2bdfe1718295bcaf698fa80452bdeea4501721) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=bb2bdfe1718295bcaf698fa80452bde… commit bb2bdfe1718295bcaf698fa80452bdeea4501721 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Jan 14 12:52:53 2016 +0100 move dummy_cn to 127.0.0.2 (Iu-PS) because I'm testing Osmo-CSCN on 127.0.0.1 (Iu-CS) http://cgit.osmocom.org/osmo-iuh/commit/?id=e5c5525baebac7e784f801f91fc12fc… commit e5c5525baebac7e784f801f91fc12fca700a3c4e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Mar 29 17:16:30 2016 +0200 rename README.msc to README The .msc file ending is no good for shell globs like '*.msc' http://cgit.osmocom.org/osmo-iuh/commit/?id=e25faa89662f069bd67e6cc37626fff… commit e25faa89662f069bd67e6cc37626fff59e05f1d6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Mar 4 02:49:52 2016 +0100 hnb-test: print sent bytes http://cgit.osmocom.org/osmo-iuh/commit/?id=3588810cb779274b5536263120be779… commit 3588810cb779274b5536263120be7796d41f69db Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 9 01:39:56 2016 +0100 hnb-test: answer MM Authentication Request With hardcoded SRES matching the hardcoded auth tuple in openbsc's sysmocom/iu branch for testing. http://cgit.osmocom.org/osmo-iuh/commit/?id=5dbb7b2c3fb0eaf357acf23b3021677… commit 5dbb7b2c3fb0eaf357acf23b302167778f8d150d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 9 01:38:13 2016 +0100 hnb-test: print LU Reject http://cgit.osmocom.org/osmo-iuh/commit/?id=d4598fa45351f9bb038d0666e7ff280… commit d4598fa45351f9bb038d0666e7ff280f3a12ff62 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 9 01:37:40 2016 +0100 hnb-test: factor out MM header parsing http://cgit.osmocom.org/osmo-iuh/commit/?id=576f642eba7266108ac51537aafc0e1… commit 576f642eba7266108ac51537aafc0e13da36436a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 30 13:32:40 2016 +0200 use of sccp_helpers: apply osmo_ name prefix addition http://cgit.osmocom.org/osmo-iuh/commit/?id=3da8608b6ad014fc74536dbb4901970… commit 3da8608b6ad014fc74536dbb49019704fd425b8c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 30 12:36:15 2016 +0200 Move sccp_helpers.[hc] to libosmo-sigtran ----------------------------------------------------------------------- Summary of changes: src/Makefile.am | 5 +- src/hnbgw_cn.c | 12 +++-- src/sccp_helpers.c | 135 ----------------------------------------------------- src/sccp_helpers.h | 33 ------------- 4 files changed, 9 insertions(+), 176 deletions(-) delete mode 100644 src/sccp_helpers.c delete mode 100644 src/sccp_helpers.h hooks/post-receive -- Osmocom code for Iuh interface

1 0

libosmo-sccp.git branch sysmocom/iu updated. 0.0.6.3-54-g9694e93
by gitosis＠osmocom.org 30 Mar '16

30 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, sysmocom/iu has been updated via 9694e939f676433d6716ac0f5e6805ad8aa60e86 (commit) via 826075f24450bda206758096a672a6a44acf515d (commit) via 90bd3ce89579538de99b58c99ce30e2fdd3ae265 (commit) via 8f569002decb1c48baf4d727083996e408f7b532 (commit) via dbadcd6de5671e74257c55cba2a867ab2205adbf (commit) from e7520e38b9a77ab63c7cad13a1f1c88d715794f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=9694e939f676433d6716ac0f5e6… commit 9694e939f676433d6716ac0f5e6805ad8aa60e86 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 30 12:45:38 2016 +0200 cosmetic: add comments for GT, PC, SSN to help noobs finding their way http://cgit.osmocom.org/libosmo-sccp/commit/?id=826075f24450bda206758096a67… commit 826075f24450bda206758096a672a6a44acf515d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 30 12:44:21 2016 +0200 sccp_helpers: add convenience function for RANAP unitdata http://cgit.osmocom.org/libosmo-sccp/commit/?id=90bd3ce89579538de99b58c99ce… commit 90bd3ce89579538de99b58c99ce30e2fdd3ae265 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 30 12:43:04 2016 +0200 sccp_helpers: add osmo_ prefix to all functions http://cgit.osmocom.org/libosmo-sccp/commit/?id=8f569002decb1c48baf4d727083… commit 8f569002decb1c48baf4d727083996e408f7b532 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 30 13:39:04 2016 +0200 sccp_helpers: adjust .h include and copyright http://cgit.osmocom.org/libosmo-sccp/commit/?id=dbadcd6de5671e74257c55cba2a… commit dbadcd6de5671e74257c55cba2a867ab2205adbf Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 30 12:41:00 2016 +0200 Add sccp_helpers.[hc] moved from osmo-iuh, 1:1 at first Move here unchanged first, so we're able to see the modifications in diffs. Pending changes will follow in subsequent patches. ----------------------------------------------------------------------- Summary of changes: include/osmocom/sigtran/Makefile.am | 4 +- include/osmocom/sigtran/sccp_helpers.h | 39 +++++++++ include/osmocom/sigtran/sccp_sap.h | 6 +- src/Makefile.am | 2 +- src/sccp_helpers.c | 151 +++++++++++++++++++++++++++++++++ 5 files changed, 197 insertions(+), 5 deletions(-) create mode 100644 include/osmocom/sigtran/sccp_helpers.h create mode 100644 src/sccp_helpers.c hooks/post-receive -- SCCP Library

1 0

openbsc.git branch neels/cscn updated. 0.15.0-360-gafd051c
by gitosis＠osmocom.org 30 Mar '16

30 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/cscn has been updated via afd051c62a45bc645fe545a8245fb5fad893b06c (commit) from 6f7750b134e6efae4bab08006c2a8a483f942166 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=afd051c62a45bc645fe545a8245fb5fa… commit afd051c62a45bc645fe545a8245fb5fad893b06c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Mar 29 18:58:10 2016 +0200 wip: paging ----------------------------------------------------------------------- Summary of changes: openbsc/src/libiu/iu.c | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

osmo-iuh.git branch sysmocom/iu-cs updated. 428e074b9b396a77a4d319a857bb6af2b127861f
by gitosis＠osmocom.org 30 Mar '16

30 Mar '16

1 0

openbsc.git branch max/nat updated. 0.15.0-196-g83195f6
by gitosis＠osmocom.org 30 Mar '16

30 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, max/nat has been updated via 83195f6346651440a9987c5e747994cd4a1de459 (commit) from aef2acfe6abc774073486db6d22d0afcb1db0a15 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=83195f6346651440a9987c5e747994cd… commit 83195f6346651440a9987c5e747994cd4a1de459 Author: Max <msuraev(a)sysmocom.de> Date: Tue Mar 29 17:06:32 2016 +0200 wip: reload config dynamically ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/bsc_nat.h | 6 ++++ openbsc/src/osmo-bsc_nat/bsc_nat.c | 5 ++++ openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 51 ++++++++++++++++++++++++++++++++-- 3 files changed, 60 insertions(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch neels/auth_tests_wip updated. 0.15.0-201-g7b97f90
by gitosis＠osmocom.org 29 Mar '16

29 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/auth_tests_wip has been updated discards 7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652 (commit) discards 131b6f2ee5ad820fd0a3c715b26eacd71673d509 (commit) discards 95b8adbd5ea2010b24807cdc89895bbab0f6bf0e (commit) discards bd7dd6ba922bf87d9a2a5e8b8a499e0dce6f5b3d (commit) discards 1f2c4ba3cefeef9dede5fae19de88fa0f896574b (commit) discards 0bdd1fda17a36567ea9b1b3073adedea4c2f5780 (commit) discards 23b1bc36045c2bbdb3cb6ddab0e7ee87b2fcbfcc (commit) via 7b97f901f0894bcc75f696a4e67a8bb4f90a9541 (commit) via fbf5e6f94f67694f03142e51773d3e50b1746a9b (commit) via 9f81ebad8c2a618a87b1e521a839d54e22eecd73 (commit) via 41d661d2ea91df076b165be9fa5fcfe952f67130 (commit) via 4631b5185cfcae8435f35c0cd56b282609a0952e (commit) via a7732be36d264d0775da82e6c78ec0183314653a (commit) via 2c6d4883d6beca6b252676112fce884389ebb57e (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652) \ N -- N -- N (7b97f901f0894bcc75f696a4e67a8bb4f90a9541) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7b97f901f0894bcc75f696a4e67a8bb4… commit 7b97f901f0894bcc75f696a4e67a8bb4f90a9541 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 14:01:57 2016 +0100 Fix MM Auth: zero-initialize auth tuple before first use Make sure a new auth tuple is initialized after db_get_lastauthtuple_for_subscr() returns an error, i.e. if no tuple is present for the subscriber yet. Before this patch, the first key_seq depended on the typically uninitialized value that was present in auth tuple's key_seq upon calling auth_get_tuple_for_subscr(). The very first key_seq used for a new subscriber will now always be 0. Before, it used to be mostly 1 ("(0 + 1) % 7"), but depended on whether the key_seq was indeed initialized with 0, actually by random. http://cgit.osmocom.org/openbsc/commit/?id=fbf5e6f94f67694f03142e51773d3e50… commit fbf5e6f94f67694f03142e51773d3e50b1746a9b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 13:44:38 2016 +0100 Fix MM Auth: disallow key_seq mismatch In auth_get_tuple_for_subscr(), add missing condition to match incoming key_seq with stored key_seq, so that re-authentication is requested for mismatching key_seqs. Add test for this issue. http://cgit.osmocom.org/openbsc/commit/?id=9f81ebad8c2a618a87b1e521a839d54e… commit 9f81ebad8c2a618a87b1e521a839d54e22eecd73 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:41:08 2016 +0100 MM Auth: return AUTH_NOT_AVAIL instead of hardcoded zero AUTH_NOT_AVAIL == 0, so this is no functional change. http://cgit.osmocom.org/openbsc/commit/?id=41d661d2ea91df076b165be9fa5fcfe9… commit 41d661d2ea91df076b165be9fa5fcfe952f67130 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:39:47 2016 +0100 MM Auth: introduce AUTH_ERROR constant. Instead of using hardcoded -1 for errors, include -1 in the enum auth_action type; apply its use. In the mm_auth test, the string output changes from '(internal error)' to 'AUTH_ERROR', since now the proper enum value is used in auth_action_names[]. http://cgit.osmocom.org/openbsc/commit/?id=4631b5185cfcae8435f35c0cd56b2826… commit 4631b5185cfcae8435f35c0cd56b282609a0952e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 12:10:48 2016 +0100 MM Auth test: add test to re-use existing auth http://cgit.osmocom.org/openbsc/commit/?id=a7732be36d264d0775da82e6c78ec018… commit a7732be36d264d0775da82e6c78ec0183314653a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:26:09 2016 +0100 MM Auth test: add two tests for AUTH_THEN_CIPH Test two situations for AUTH_DO_AUTH_THEN_CIPH: - when no auth tuple is available - when the key sequence from LU is marked invalid Add convenience auth tuple comparison function using stringification. http://cgit.osmocom.org/openbsc/commit/?id=2c6d4883d6beca6b252676112fce8843… commit 2c6d4883d6beca6b252676112fce884389ebb57e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:21:00 2016 +0100 Add MM Auth test; add auth_action_str() function Add basic MM Authentication test setup, with fake DB access and RAND_bytes(). So far implement simple tests for IO error during DB access and missing auth entry. To print the auth action during tests, add struct auth_action_names and auth_action_str() inline function in auth.[hc]. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/auth.h | 17 ++++------------- openbsc/src/libmsc/auth.c | 9 +++++++++ 2 files changed, 13 insertions(+), 13 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch neels/auth_tests_wip updated. 0.15.0-201-g7d8ea8b
by gitosis＠osmocom.org 29 Mar '16

29 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/auth_tests_wip has been updated discards 20bbcd096de9156fcbfc61950cde46cd20236ec3 (commit) discards 48123874f7877de5e163f83593aa193c2fc6ad96 (commit) discards 36f9af92b0d94126efe38c9dfc786ea155516356 (commit) discards b4eda53768ebefbad6bfe5231e562b77f233fc2d (commit) discards 1a92af94a272e6f52508e84820f248069b9a6acc (commit) discards 51f510ab12e76ad07ccaf9ac42ab6309c96528fc (commit) via 7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652 (commit) via 131b6f2ee5ad820fd0a3c715b26eacd71673d509 (commit) via 95b8adbd5ea2010b24807cdc89895bbab0f6bf0e (commit) via bd7dd6ba922bf87d9a2a5e8b8a499e0dce6f5b3d (commit) via 1f2c4ba3cefeef9dede5fae19de88fa0f896574b (commit) via 0bdd1fda17a36567ea9b1b3073adedea4c2f5780 (commit) via 23b1bc36045c2bbdb3cb6ddab0e7ee87b2fcbfcc (commit) via 56ea30ff3f9f98a4903d060196b185ce124d7eaa (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (20bbcd096de9156fcbfc61950cde46cd20236ec3) \ N -- N -- N (7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7d8ea8bb5abad91c1d5aeb8d447fd92f… commit 7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 14:01:57 2016 +0100 Fix MM Auth: zero-initialize auth tuple before first use Make sure a new auth tuple is initialized after db_get_lastauthtuple_for_subscr() returns an error. In effect, the first key_seq used no longer depends on how the auth tuple was initialized before the call. Before this patch, the first key_seq depended on the value was present in auth tuple's key_seq. http://cgit.osmocom.org/openbsc/commit/?id=131b6f2ee5ad820fd0a3c715b26eacd7… commit 131b6f2ee5ad820fd0a3c715b26eacd71673d509 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 13:44:38 2016 +0100 Fix MM Auth: disallow key_seq mismatch In auth_get_tuple_for_subscr(), add missing condition to match incoming key_seq with stored key_seq, so that re-authentication is requested for mismatching key_seqs. Add test for this issue. http://cgit.osmocom.org/openbsc/commit/?id=95b8adbd5ea2010b24807cdc89895bba… commit 95b8adbd5ea2010b24807cdc89895bbab0f6bf0e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:41:08 2016 +0100 MM Auth: return AUTH_NOT_AVAIL instead of hardcoded zero AUTH_NOT_AVAIL == 0, so this is no functional change. http://cgit.osmocom.org/openbsc/commit/?id=bd7dd6ba922bf87d9a2a5e8b8a499e0d… commit bd7dd6ba922bf87d9a2a5e8b8a499e0dce6f5b3d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:39:47 2016 +0100 MM Auth: introduce AUTH_ERROR constant. Instead of using hardcoded -1 for errors, include -1 in the enum auth_action type; apply its use. In effect remove a compiler warning recently introduced in auth_action_str() about int value not represented in enum definition. In the mm_auth test, the string output changes from '(internal error)' to 'AUTH_ERROR'. http://cgit.osmocom.org/openbsc/commit/?id=1f2c4ba3cefeef9dede5fae19de88fa0… commit 1f2c4ba3cefeef9dede5fae19de88fa0f896574b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 12:10:48 2016 +0100 MM Auth test: add test to re-use existing auth http://cgit.osmocom.org/openbsc/commit/?id=0bdd1fda17a36567ea9b1b3073adedea… commit 0bdd1fda17a36567ea9b1b3073adedea4c2f5780 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:26:09 2016 +0100 MM Auth test: add two tests for AUTH_THEN_CIPH Test two situations for AUTH_DO_AUTH_THEN_CIPH: - when no auth tuple is available - when the key sequence from LU is marked invalid Add convenience auth tuple comparison function using stringification. http://cgit.osmocom.org/openbsc/commit/?id=23b1bc36045c2bbdb3cb6ddab0e7ee87… commit 23b1bc36045c2bbdb3cb6ddab0e7ee87b2fcbfcc Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:21:00 2016 +0100 Add MM Auth test; add auth_action_str() function Add basic MM Authentication test setup, with fake DB access and RAND_bytes(). So far implement simple tests for IO error during DB access and missing auth entry. To print the auth action during tests, implement auth_action_str() inline function. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/auth.h | 5 +- openbsc/src/libmsc/auth.c | 12 +++- openbsc/tests/mm_auth/mm_auth_test.c | 103 ++++++++++++++++++++++------------ openbsc/tests/mm_auth/mm_auth_test.ok | 18 +++++- 4 files changed, 98 insertions(+), 40 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog