This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via fe6c75d24a1751341bcee91cb45c7ac7f5d07da3 (commit)
via bd65b72f91f195dd9b6ea2df67d6d1b36b1e9864 (commit)
from cd1b08b14f6a68e53ad7308cb5cd318f262426b7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=fe6c75d24a1751341bcee91cb45c7ac…
commit fe6c75d24a1751341bcee91cb45c7ac7f5d07da3
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jun 24 18:42:00 2017 +0200
TRX: Remove global variables, move SETBSIC/SETTSC handling into phy_link
Whether or not we are talking to an OpenBTS (SETBSIC) or OsmoTRX
(SETTSC) transceiver is a property of the phy_link, and not a property
of the BTS. Also, we *really, really* should never use global
variables. I'm very happy this is being cleaned up, finally.
Change-Id: I51aeb17661dfd63ff347f7b2c0d7ffa383ec814c
http://cgit.osmocom.org/osmo-bts/commit/?id=bd65b72f91f195dd9b6ea2df67d6d1b…
commit bd65b72f91f195dd9b6ea2df67d6d1b36b1e9864
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Jun 23 18:57:28 2017 +0200
l1sap/osmo-bts-sysmo: Improve logging
Change-Id: I339db0e5f3fd5e44bac974f2447afc80388802af
-----------------------------------------------------------------------
Summary of changes:
include/osmo-bts/phy_link.h | 1 +
src/common/l1sap.c | 35 ++++++++++++-------
src/osmo-bts-trx/trx_if.c | 18 +++++-----
src/osmo-bts-trx/trx_if.h | 2 --
src/osmo-bts-trx/trx_vty.c | 83 ++++++++++++++++-----------------------------
5 files changed, 61 insertions(+), 78 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SCCP Library".
The branch, master has been updated
via 9d1a3f66457508e16dd2d1d33fe7bf5ed24b633b (commit)
via 2373f2778a135e4fc37ff5c741ac3293b18b8d87 (commit)
via e634a6f3251cf556ca8d1466b044775e44a48a79 (commit)
via 037d46abc181d5a763f2171a5e08154eb163fd0c (commit)
via 603e065f43a9b0a6d9d92584ba458fefee32b516 (commit)
via c881c4912709be005cbb3ffb02ba06f13c69d24b (commit)
via 775ac6f6b1c47066db58608f9497f0e4916bbcc4 (commit)
via a212398f7c39ab0e919e0c9efde8a1c8a37678bb (commit)
via b352ca030d8870930493f36e2b3702760ff4b44a (commit)
via b711e1450444c5882a8d9a941094183484fa47db (commit)
from 81a029a4e46bb7c62b2401ec055fe44c5b7568cd (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/sigtran/osmo_ss7.h | 12 +++++++--
include/osmocom/sigtran/sccp_sap.h | 14 +++++++++++
src/osmo_ss7.c | 22 ++++++++++------
src/osmo_ss7_vty.c | 11 ++++++--
src/sccp2sua.c | 2 +-
src/sccp_helpers.c | 51 +++++++++++++++++++++++++++++---------
src/sccp_internal.h | 1 -
src/sccp_sap.c | 47 +++++++++++++++++++++++++++++++++++
src/sccp_scoc.c | 6 ++---
src/sccp_scrc.c | 8 +++++-
src/sccp_user.c | 37 +++++++++++++--------------
src/sccp_vty.c | 2 +-
tests/xua/xua_test.ok | 12 ++++-----
13 files changed, 171 insertions(+), 54 deletions(-)
hooks/post-receive
--
SCCP Library
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via cd1b08b14f6a68e53ad7308cb5cd318f262426b7 (commit)
from bc56094cacd868cdb0336b215e4268bb69cab168 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=cd1b08b14f6a68e53ad7308cb5cd318…
commit cd1b08b14f6a68e53ad7308cb5cd318f262426b7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jun 24 18:44:30 2017 +0200
TRX: Remove bogus extern global variable declarations
Those global variable declarations for non-existing variables were
introduced in 8a8d73a691c709403be4adbe8f2a7150b4d5998a, let's remove
them again. The source / destination IP address is a parameter of the
phy_link, and not a global variable.
Related: OS#1848
Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186
-----------------------------------------------------------------------
Summary of changes:
src/osmo-bts-trx/trx_if.h | 2 --
1 file changed, 2 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 98849f7ddcbe8b094af5ee5efc30bd841ac12e04 (commit)
via 52d519220501c4d4c09dfa924e23badac8589614 (commit)
via f354a8e1c5633a43d7bca986e8de82d23610d2a9 (commit)
from 39181ac4a2b0686fb27b35d89af2dfee1d7c285d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=98849f7ddcbe8b094af5ee5efc30bd84…
commit 98849f7ddcbe8b094af5ee5efc30bd841ac12e04
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Aug 7 14:01:30 2017 +0100
libmsc: add support for SMPP delivery receipts
If the mobile phone requests a status report via SMS, send a DELIVER_SM
with esm_class = Delivery Receipt to ESME to indicate that the SMS has
been already delivered to its destination.
MS GSM 03.40 SMSC SMPP 3.4 ESME
| | |
| SMS-DELIVER | |
|<----------------------------| |
| GSM 04.11 RP-ACK | |
|---------------------------->| |
| | DELIVER-SM |
| | esm_class = Delivery Receipt |
| |------------------------------->|
| | DELIVER-SM-RESP |
| |<-------------------------------|
| | |
This patch implements "Appendix B. Delivery Receipt Format" as specified
in the SMPP 3.4 specs. This string is conveyed in the SMS message as
data, and it is only meaningful to the ESME, for logging purposes. The
"submit date" and "done date" are not yet set, and other fields are just
sent with dummy values, so they are left to be finished as future work.
The new SMPP TLV tag TLVID_user_message_reference is added to the SMPP
messages inconditionally now since this information is required by
delivery-reports to associate the status-report with the original SMS.
Change-Id: Ic1a9023074bfa938099377980b6aff9b262fab2a
http://cgit.osmocom.org/openbsc/commit/?id=52d519220501c4d4c09dfa924e23bada…
commit 52d519220501c4d4c09dfa924e23badac8589614
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Aug 7 14:01:28 2017 +0100
utils: smpp_mirror: reflect message reference TLV
Useful to test the delivery receipt support. This TLV contains the
GSM03.40 message reference.
Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
http://cgit.osmocom.org/openbsc/commit/?id=f354a8e1c5633a43d7bca986e8de82d2…
commit f354a8e1c5633a43d7bca986e8de82d23610d2a9
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Aug 7 14:01:25 2017 +0100
utils: smpp_mirror: temporarily munch SMPP delivery receipts
Just munch and log SMPP delivery receipts by now, don't mirror this, it
is going to break things in openbsc.
Follow up patch removes this and mirrors this SMPP message as a
SUBMIT_SM with esm_class = Delivery Acknowledgement.
Change-Id: I78e93bc4034679e238c8642ccf6a0e844b1d6d8b
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gsm_data.h | 1 +
openbsc/src/libmsc/gsm_04_11.c | 54 ++++++++++++++++++++++++++++++++++++++
openbsc/src/libmsc/smpp_openbsc.c | 21 ++++++++++++++-
openbsc/src/libmsc/smpp_smsc.h | 1 +
openbsc/src/utils/smpp_mirror.c | 32 +++++++++++++++++++++-
5 files changed, 107 insertions(+), 2 deletions(-)
hooks/post-receive
--
Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 39181ac4a2b0686fb27b35d89af2dfee1d7c285d (commit)
via 8e2a142856dc7e3e482762c738b22e19a0492f1f (commit)
from 53ad3ca521bacc9e0d8e0ff76f71cacb26201c27 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=39181ac4a2b0686fb27b35d89af2dfee…
commit 39181ac4a2b0686fb27b35d89af2dfee1d7c285d
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Aug 7 14:01:23 2017 +0100
utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM
To test delivery reports using this utility.
Change-Id: I0e477407531fdd4d906e53c9b5a48a79a239966f
http://cgit.osmocom.org/openbsc/commit/?id=8e2a142856dc7e3e482762c738b22e19…
commit 8e2a142856dc7e3e482762c738b22e19a0492f1f
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Aug 7 14:01:21 2017 +0100
libmsc: missing bit shift in status report flag when stored in sms object
So we just store 0 or 1 depending on what the mobile phone requests.
Change-Id: Idb7d5594219c0e458ccb561383a59604bc1a4201
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libmsc/gsm_04_11.c | 2 +-
openbsc/src/utils/smpp_mirror.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
hooks/post-receive
--
Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 53ad3ca521bacc9e0d8e0ff76f71cacb26201c27 (commit)
via 0a20d62972c6e3689ac1256fe60861699ae94583 (commit)
from f8b2d46dc00ff4da96c6932b6cfd5b792b36b209 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=53ad3ca521bacc9e0d8e0ff76f71cacb…
commit 53ad3ca521bacc9e0d8e0ff76f71cacb26201c27
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Aug 7 14:01:18 2017 +0100
libmsc: report status report request flag from SMPP SUBMIT_SM
Restore the sms status report request flag from SUBMIT_SM.
Change-Id: Iac05252253f8933a3875b4904599b7a225191a4b
http://cgit.osmocom.org/openbsc/commit/?id=0a20d62972c6e3689ac1256fe6086169…
commit 0a20d62972c6e3689ac1256fe60861699ae94583
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Aug 7 14:01:15 2017 +0100
libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM messages
Propagate the status report request field to the SMPP message through
the registered_delivery field, so the ESME knows that the mobile phone
is asking for explicit delivery acknowledgment is required. See SMPP 3.4
specs section 5.2.17.
Change-Id: I59af60fa89cd10ae973c5e122789e3e03e3728ee
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libmsc/smpp_openbsc.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
hooks/post-receive
--
Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom code for Iuh interface".
The branch, pre_release has been updated
discards 2627a983408cacb58b0a21ddcd6b737a2a72bdac (commit)
discards f4ed50c78263ac20cad27494e7b30636dcdc960f (commit)
via df0759f7e77e36ee4eeb369c6d12d8edb152db43 (commit)
via bf5ac2d568831839631c40b311f9a8e0bc94f6f4 (commit)
via 0dd2509fce388f17320c6605ce68b64280b374c2 (commit)
via 5e0292a6412a04eeed9e0aff3f56bd8d4f353346 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (2627a983408cacb58b0a21ddcd6b737a2a72bdac)
\
N -- N -- N (df0759f7e77e36ee4eeb369c6d12d8edb152db43)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-iuh/commit/?id=df0759f7e77e36ee4eeb369c6d12d8e…
commit df0759f7e77e36ee4eeb369c6d12d8edb152db43
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Sun Aug 6 21:52:02 2017 +0000
add /debian package support
Change-Id: I985805aea0e48fe70619de8b81206098e4e37613
http://cgit.osmocom.org/osmo-iuh/commit/?id=bf5ac2d568831839631c40b311f9a8e…
commit bf5ac2d568831839631c40b311f9a8e0bc94f6f4
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Jul 27 14:37:03 2017 +0200
apply ctx arg to osmo_ss7_vty_init_asp()
Depends: libosmo-sccp Id4e7f47979001f7856b0b3665c9e94982e75e490
Change-Id: Idccbdc669d740179153d0a73096745785bd2f5af
http://cgit.osmocom.org/osmo-iuh/commit/?id=0dd2509fce388f17320c6605ce68b64…
commit 0dd2509fce388f17320c6605ce68b64280b374c2
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Jul 31 13:13:24 2017 +0200
make point codes configurable by SCCP address book
In the vty config, use the SCCP address book to configure the local and remote
SCCP addresses. Add VTY commands to set the remote SCCP addresses by name,
derive the ss7 instance from these addresses:
cs7 instance 1
point-code 0.23.0
sccp-address msc
point-code 0.0.1
sccp-address sgsn
point-code 0.0.2
hnbgw
iucs
remote-addr msc
iups
remote-addr sgsn
Enforce that both IuCS and IuPS use the same ss7 instance. In the future, we
may add the feature to use two separate instances.
Depends: libosmo-sccp I75c67d289693f1c2a049ac61cf2b2097d6e5687d,
Ie1aedd7894acd69ddc887cd65a8a0df4b888838c,
I85b46269dbe7909e52873ace3f720f6292a4516c
Change-Id: I33a7ba11eb7c2d9a5dc74d10fb0cf04bf664477b
-----------------------------------------------------------------------
Summary of changes:
.gitreview | 3 ++
debian/changelog | 5 ++++
debian/compat | 1 +
debian/control | 60 ++++++++++++++++++++++++++++++++++++++++
debian/copyright | 51 ++++++++++++++++++++++++++++++++++
debian/libosmo-ranap-dev.install | 3 ++
debian/libosmo-ranap0.install | 1 +
debian/osmo-hnbgw.install | 2 ++
debian/rules | 18 ++++++++++++
debian/source/format | 1 +
src/hnbgw_cn.c | 2 +-
11 files changed, 146 insertions(+), 1 deletion(-)
create mode 100644 .gitreview
create mode 100644 debian/changelog
create mode 100644 debian/compat
create mode 100644 debian/control
create mode 100644 debian/copyright
create mode 100644 debian/libosmo-ranap-dev.install
create mode 100644 debian/libosmo-ranap0.install
create mode 100644 debian/osmo-hnbgw.install
create mode 100755 debian/rules
create mode 100644 debian/source/format
hooks/post-receive
--
Osmocom code for Iuh interface
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SCCP Library".
The branch, pre_release has been updated
discards ad2db7aedd625da964c6856056fcd16519dbc3b7 (commit)
discards fd63ccca545fdeebd2a621ac41fc5f5d9c1b2d80 (commit)
discards 75ed8def84103db9a3ae22d5ebce8d2cb84aacc8 (commit)
discards b75258e51a4efb6cff2f3e956b50fa020233c6c2 (commit)
discards 3c3f70a2457f437f07836280eaebe9f5c6a7514c (commit)
discards 02f7c45b69c9f2d71b34eef059a43929a831d65e (commit)
discards b35f6d1c1e81a3d4187915234ca332fc26a0858b (commit)
discards 06956848a3ec1b64c6bb3d71abde8db44440d80f (commit)
via 9d1a3f66457508e16dd2d1d33fe7bf5ed24b633b (commit)
via 2373f2778a135e4fc37ff5c741ac3293b18b8d87 (commit)
via e634a6f3251cf556ca8d1466b044775e44a48a79 (commit)
via 037d46abc181d5a763f2171a5e08154eb163fd0c (commit)
via 603e065f43a9b0a6d9d92584ba458fefee32b516 (commit)
via c881c4912709be005cbb3ffb02ba06f13c69d24b (commit)
via 775ac6f6b1c47066db58608f9497f0e4916bbcc4 (commit)
via a212398f7c39ab0e919e0c9efde8a1c8a37678bb (commit)
via b352ca030d8870930493f36e2b3702760ff4b44a (commit)
via b711e1450444c5882a8d9a941094183484fa47db (commit)
via 81a029a4e46bb7c62b2401ec055fe44c5b7568cd (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (ad2db7aedd625da964c6856056fcd16519dbc3b7)
\
N -- N -- N (9d1a3f66457508e16dd2d1d33fe7bf5ed24b633b)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmo-sccp/commit/?id=9d1a3f66457508e16dd2d1d33fe…
commit 9d1a3f66457508e16dd2d1d33fe7bf5ed24b633b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Jul 27 17:33:06 2017 +0200
cosmetic: ws in log
Change-Id: If5a56ec170d4e91ce070f6fa9c9cfe5bbc121186
http://cgit.osmocom.org/libosmo-sccp/commit/?id=2373f2778a135e4fc37ff5c741a…
commit 2373f2778a135e4fc37ff5c741ac3293b18b8d87
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Jul 26 18:15:47 2017 +0200
sccp_helpers: check buf len in append_to_buf()
Change-Id: I2e6d656871f952be8e719573fedf2154832841d7
http://cgit.osmocom.org/libosmo-sccp/commit/?id=e634a6f3251cf556ca8d1466b04…
commit e634a6f3251cf556ca8d1466b044775e44a48a79
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Jul 27 13:53:03 2017 +0200
sccp-addr vty: set RI to SSN_PC when setting a point-code
Change-Id: I75c67d289693f1c2a049ac61cf2b2097d6e5687d
http://cgit.osmocom.org/libosmo-sccp/commit/?id=037d46abc181d5a763f2171a5e0…
commit 037d46abc181d5a763f2171a5e08154eb163fd0c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Jul 27 15:22:06 2017 +0200
fix osmo_sccp_addr_dump(): actually print RI
Adjust xua_test accordingly.
Change-Id: I93e0aa706867e7b1de7f7a6071e3c8af89772af0
http://cgit.osmocom.org/libosmo-sccp/commit/?id=603e065f43a9b0a6d9d92584ba4…
commit 603e065f43a9b0a6d9d92584ba458fefee32b516
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Jul 26 18:07:53 2017 +0200
add osmo_sccp_addr_name() and three value_string[]s
osmo_sccp_addr_dump() just prints the raw values. In osmo_sccp_addr_name(), use
osmo_ss7_pointcode_print() and newly added RI, SSN and GT value_string[] to
print more human readable log output.
Change-Id: Ie1aedd7894acd69ddc887cd65a8a0df4b888838c
http://cgit.osmocom.org/libosmo-sccp/commit/?id=c881c4912709be005cbb3ffb02b…
commit c881c4912709be005cbb3ffb02ba06f13c69d24b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Jul 27 13:51:46 2017 +0200
introduce OSMO_SCCP_RI_NONE to indicate unset RI
Allows to automatically set an RI in future change
I75c67d289693f1c2a049ac61cf2b2097d6e5687d
"sccp-addr vty: set RI to SSN_PC when setting a point-code"
Change-Id: I6e2f31b023b08cba2f2ee8234e6108efcaca41c0
http://cgit.osmocom.org/libosmo-sccp/commit/?id=775ac6f6b1c47066db58608f949…
commit 775ac6f6b1c47066db58608f9497f0e4916bbcc4
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Jul 27 13:50:31 2017 +0200
constify ss7_instance arg of osmo_ss7_pointcode_print()
Change-Id: I8c6b7188d004033e75e9c41f4a65c418d13a79c5
http://cgit.osmocom.org/libosmo-sccp/commit/?id=a212398f7c39ab0e919e0c9efde…
commit a212398f7c39ab0e919e0c9efde8a1c8a37678bb
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Jul 26 17:31:53 2017 +0200
consistency: use OSMO_SS7_PC_INVALID for osmo_sccp_user
A previous patch added ss7_instance primary_pc validity checks by means of
OSMO_SS7_PC_INVALID. To be consistent, also adjust sccp_user accordingly.
(see I7f0f0c89b7335d9da24161bfac8234be214ca00c)
Remove the osmo_sccp_user's pc_valid field, replaced by pc=OSMO_SS7_PC_INVALID.
Adjust all code paths.
Simplify some log printing, using the fact that osmo_ss7_pointcode_print() now
outputs "(no PC)" for unset point codes.
Change-Id: I8684c9b559712072c772012890bbf7efa7c8eb35
http://cgit.osmocom.org/libosmo-sccp/commit/?id=b352ca030d8870930493f36e2b3…
commit b352ca030d8870930493f36e2b3702760ff4b44a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Jul 26 17:31:53 2017 +0200
ensure valid primary_pc in osmo_ss7_instance
Initialize osmo_ss7_instance.cfg.primary_pc = OSMO_SS7_PC_INVALID.
Adjust all code paths using primary_pc to ensure it is indeed valid.
Rationale:
It looks like we are going to use the primary point-code of an SS7 instance to
derive a local SCCP address, e.g. for osmo-bsc and osmo-hnbgw.
cs7-instance 1
point-code 1.2.3 ! sets osmo_ss7_instance.primary_pc = 1.2.3
sccp-address msc
point-code 0.0.1
routing-indicator PC
hnb
iucs
remote-addr msc ! derives cs7 instance 1 and local pc 1.2.3
If 'point-code 1.2.3' is omitted, this becomes '0.0.0' without the user
noticing, and this happens for each client that omits it. I would like to barf
when no local PC is set.
Change-Id: I7f0f0c89b7335d9da24161bfac8234be214ca00c
http://cgit.osmocom.org/libosmo-sccp/commit/?id=b711e1450444c5882a8d9a94109…
commit b711e1450444c5882a8d9a941094183484fa47db
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Jul 26 17:31:53 2017 +0200
add OSMO_SS7_PC_INVALID, add osmo_ss7_pc_is_valid()
Introduce OSMO_SS7_PC_INVALID to mark an unset point code.
Add static osmo_ss7_pc_is_valid() (name matches schema of
osmo_ss7_pc_is_local()).
In osmo_ss7_pointcode_print(), return "(no PC)" if !osmo_ss7_pc_is_valid(), for
convenient printing of any PC state.
Subsequent patches will use this for
osmo_ss7_instance (I7f0f0c89b7335d9da24161bfac8234be214ca00c)
as well as osmo_sccp_user (I8684c9b559712072c772012890bbf7efa7c8eb35).
Rationale:
Currently, in osmo_ss7_vty.c we had "if (inst->cfg.primary_pc)" suggesting 0 is
invalid, but in struct osmo_sccp_user we have flag pc_valid suggesting 0 is
indeed valid. All known point code formats are <= 24bit, so we can easily use
0xffffffff as indicator for an unset PC, which removes the need to remember to
set a second field for validity and keeps the structs nice and lean.
Change-Id: Ib5715bf03a4de7713a7a809dfd821c700255ba8c
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/sigtran/osmo_ss7.h | 9 ++++-
include/osmocom/sigtran/sccp_sap.h | 2 +
src/osmo_ss7.c | 16 ++++++--
src/osmo_ss7_vty.c | 5 +--
src/sccp_internal.h | 1 -
src/sccp_scoc.c | 12 ++----
src/sccp_scrc.c | 2 +-
src/sccp_user.c | 81 +++++++++++++++++++++++++++-----------
src/sccp_vty.c | 2 +-
tests/ss7/ss7_test.c | 1 -
10 files changed, 88 insertions(+), 43 deletions(-)
hooks/post-receive
--
SCCP Library
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, pmaier/aoip3 has been updated
via f4d0911666067a7d84da73e6defd749d71142651 (commit)
from 4cca03749c415f4c484e53bffb88d230dc878050 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=f4d0911666067a7d84da73e6defd749d…
commit f4d0911666067a7d84da73e6defd749d71142651
Author: Philipp Maier <pmaier(a)sysmocom.de>
Date: Wed Aug 9 13:48:18 2017 +0200
osmo-bsc: make use of osmo_sccp_addr_set_ssn()
libosmo-sccp offers a function to set the SSN. Make use of this
function instead of manipulating the struct directlry
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/osmo-bsc/osmo_bsc_vty.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
hooks/post-receive
--
Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, pmaier/aoip3 has been updated
via 4cca03749c415f4c484e53bffb88d230dc878050 (commit)
from e94d11925152eee995a89d5c5b03a4470693e8e6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=4cca03749c415f4c484e53bffb88d230…
commit 4cca03749c415f4c484e53bffb88d230dc878050
Author: Philipp Maier <pmaier(a)sysmocom.de>
Date: Wed Aug 9 13:37:27 2017 +0200
bsc/msc: fixup compiler issues
libosmo-sccp function osmo_ss7_vty_init_sg() now requires a talloc
context as parameter.
Note: It should not _asp() rather then _sg(). However, we can not
switch now, because then we will miss the vtx commands that
configure the default route. Since the default route is the only
valid route for application server processes, we need to fix this
in the simple client, so that this command is no longer needed,
when configuring the as. Also the VTX write functions of
libosmo-sccp need to be fixed first.
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/osmo-bsc/osmo_bsc_main.c | 4 +++-
openbsc/src/osmo-msc/msc_main.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
hooks/post-receive
--
Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)