osmocom-commitlog September 2017

osmocom-commitlog@lists.osmocom.org

1 participants
160 discussions

libosmocore.git branch neels/vty_indent_debug created. 0.9.6-389-gade800e1
by gitosis＠osmocom.org 20 Sep '17

20 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/vty_indent_debug has been created at ade800e1018bc8960559baef314e0266b3598769 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=ade800e1018bc8960559baef314e… commit ade800e1018bc8960559baef314e0266b3598769 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Tue Sep 12 04:06:50 2017 +0200 NOT FOR MERGE: vty indentation debug Change-Id: I48f2d7c34ea160a8ca36ab83f462ffd7e660065e http://cgit.osmocom.org/libosmocore/commit/?id=d0de6ab897249ac9a0a8f9bf46d3… commit d0de6ab897249ac9a0a8f9bf46d3508bea55d93e Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Tue Sep 19 23:54:01 2017 +0200 fix vty regression: empty parent node The recent exit-by-indent patch breaks a VTY case where a node is entered but directly followed by a sibling or ancestor without listing any child nodes. Regression introduced by I24cbb3f6de111f2d31110c3c484c066f1153aac9. An example is a common usage in osmo-bts, where 'phy N' / 'instance N' is a parent node that is commonly left empty: phy 0 instance 0 bts 0 band 1800 Before this patch, this case produces the error: There is no such command. Error occurred during reading the below line: bts 0 Fix indentation parsing logic in command.c to accomodate this case. Add a unit test for empty parent node. Change-Id: Ia0880a17ae55accb092ae8585cc3a1bec9986891 ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

gr-osmosdr.git branch plutokernel created. v0.1.4-99-g226e690
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU Radio block for interfacing with various radio hardware". The branch, plutokernel has been created at 226e690d105e1ab878a235cfd1384895a494ce4a (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gr-osmosdr/commit/?id=226e690d105e1ab878a235cfd1384… commit 226e690d105e1ab878a235cfd1384895a494ce4a Author: Hoernchen <la(a)tfc-server.de> Date: Sun Sep 17 22:47:45 2017 +0200 Add support for experimental plutosdr kernel driver ----------------------------------------------------------------------- hooks/post-receive -- GNU Radio block for interfacing with various radio hardware

1 0

rtl-sdr.git branch master updated. v0.5.3-18-gb04c2f9
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Repository for Realtek RTL2832U based SDR software". The branch, master has been updated via b04c2f9f035c5aede43d731e5d58e4725d2f8bb4 (commit) from 18bf26989c926a5db4fca29e7d859af42af1437c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/rtl-sdr/commit/?id=b04c2f9f035c5aede43d731e5d58e472… commit b04c2f9f035c5aede43d731e5d58e4725d2f8bb4 Author: Hoernchen <la(a)tfc-server.de> Date: Tue Sep 19 19:23:00 2017 +0200 fix for msvc14 ----------------------------------------------------------------------- Summary of changes: CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- Repository for Realtek RTL2832U based SDR software

1 0

osmo-python-tests.git branch neels/doc created. d2e793a58aceb19fea1d29b550894407331fea7f
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, neels/doc has been created at d2e793a58aceb19fea1d29b550894407331fea7f (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=d2e793a58aceb19… commit d2e793a58aceb19fea1d29b550894407331fea7f Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 16:00:21 2017 +0200 osmodumpdoc: print generated path Change-Id: Ie39316f0b51ee518b9dce8d5f98b53f748db573b http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=a784f2407b087e1… commit a784f2407b087e17ba4a6447e4f1b5cf6c524e22 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 16:02:55 2017 +0200 osmodumpdoc: print called commands and OSError messages Change-Id: Ib044cbb8a1b8e02cbe6852f785c75b5c7aae6174 http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=8e4806c5f20f082… commit 8e4806c5f20f082c911f5a95d88c5fdd2c26d58b Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 16:01:44 2017 +0200 osmodumpdoc: fix finding cfg when not calling from source tree When the binary has not been built in the source tree, it was impossible to call osmodumpdoc.py despite the -p <config-path> option. Look for config files in that config-path. Make sure a relative config-path is adjusted when changing to the workdir. Change-Id: I5427d354c289ec4602411c7059c8d80e2b451f7c ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

libosmocore.git branch neels/vty_ref created. 0.9.6-388-gf031158f
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/vty_ref has been created at f031158ff29a04fdd3fd9bcd419992a6b61a88ad (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=f031158ff29a04fdd3fd9bcd4199… commit f031158ff29a04fdd3fd9bcd419992a6b61a88ad Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 16:42:06 2017 +0200 vty: derive node name from prompt, use as XML ids The 'show online-help' produces XML output with <node id="..."> ids. We reference those from the osmo-gsm-manuals. Instead of numeric IDs coming from internal code, rather use a human-readable node ID. In order to obtain such while remaining backwards compatible, derive such a name from the command node's prompt by stripping non-alnum characters. If this is merged, we need to adjust the references in osmo-gsm-manuals.git. Change-Id: I8fa555570268b231c5e01727c661da92fad265de http://cgit.osmocom.org/libosmocore/commit/?id=e9db33b27081359c6c937b875546… commit e9db33b27081359c6c937b8755469af2c7806374 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 17:10:36 2017 +0200 vty: use internal node id for xml ids The 'show online-help' produces XML output with <node id="..."> ids. We reference those from the osmo-gsm-manuals, but until now, these ids fall out of sync when the amount of VTY nodes changes. Change these ids to use the internal node ID constant (as in enum bsc_vty_node) instead of a simple counter. If this is merged, we need to adjust the references in osmo-gsm-manuals.git. Change-Id: Ib07fb9d9106e19f5be6539493e82b5d5991f8bc2 ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

osmo-gsm-manuals.git branch neels/osmo-msc created. 2c3b99e62aa45ae4c3631155795246056a3dddb9
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, neels/osmo-msc has been created at 2c3b99e62aa45ae4c3631155795246056a3dddb9 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=2c3b99e62aa45ae4c363115… commit 2c3b99e62aa45ae4c3631155795246056a3dddb9 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 16:19:30 2017 +0200 add OsmoMSC manual Change-Id: I9ecff2837fbf5fdc19675a726f6d70c21eb178ee http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=260115932622ce5ae6120e3… commit 260115932622ce5ae6120e336ba076c4a76e26db Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 18:32:30 2017 +0200 OsmoNITB: update vty reference Change node IDs to use the names derived from the node prompt, in the process fix the node references to not place the vty_additions in the wrong places. Related: I8fa555570268b231c5e01727c661da92fad265de (libosmocore) Change-Id: I48edb65be94be56c4b57293d8edc1b30271acc12 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=cff1731b13b983bd13510e5… commit cff1731b13b983bd13510e56ec3bf657b4cd2740 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 16:23:18 2017 +0200 fix make deps: don't use the FORCE With the FORCE dependency in place, every 'make' invocation builds all from scratch all the time. Remove that to have intelligent re-build on edits. Change-Id: I9758e04162a480e28c7dc83475b514cf7fd25ec0 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=0e3e4c217add2744307b81d… commit 0e3e4c217add2744307b81d3e8c715c3ddc2c119 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Sep 18 16:22:11 2017 +0200 fix make deps: join hint_to_remove_draft_mode to build step Change-Id: Iecf8e18ce2f1dac61bf55019e1fec601b33abb95 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=60ccbe55c534c533779d816… commit 60ccbe55c534c533779d816187d838339cfdce86 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Tue Sep 19 02:32:00 2017 +0200 INSTALL.txt: add missing dep and vty ref howto Change-Id: I1068d665b91faf1faa1b295503fcdc33f4ac500a ----------------------------------------------------------------------- hooks/post-receive -- Manuals for Osmocom GSM components

1 0

libosmocore.git branch master updated. 0.9.6-387-g4a31ffa2
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 4a31ffa2f0097d96201f80305a0495c57552f0ad (commit) from a52d839343aea9b81c2463f52c3c3358778698f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=4a31ffa2f0097d96201f80305a04… commit 4a31ffa2f0097d96201f80305a0495c57552f0ad Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Sep 7 03:08:06 2017 +0200 VTY: implicit node exit by de-indenting, not parent lookup Note: This will break users' config files if they do not use consistent indenting. (see below for a definition of "consistent".) When reading VTY commands from a file, use indenting as means to implicitly exit child nodes. Do not look for commands in the parent node implicitly. The VTY so far implies 'exit' commands if a VTY line cannot be parsed on the current node, but succeeds on the parent node. That is the mechanism by which our VTY config files do not need 'exit' at the end of each child node. We've hit problems with this in the following scenarios, which will show improved user experience after this patch: *) When both a parent and its child node have commands with identical names: cs7 instace 0 point-code 1.2.3 sccp-address osmo-msc point-code 0.0.1 If I put the parent's command below the child, it is still interpreted in the context of the child node: cs7 instace 0 sccp-address osmo-msc point-code 0.0.1 point-code 1.2.3 Though the indenting lets me assume I am setting the cs7 instance's global PC to 1.2.3, I'm actually overwriting osmo-msc's PC with 1.2.3 and discarding the 0.0.1. *) When a software change moves a VTY command from a child to a parent. Say 'timezone' moved from 'bts' to 'network' level: network timezone 1 2 Say a user still has an old config file with 'timezone' on the child level: network bts 0 timezone 1 2 trx 0 The user would expect an error message that 'timezone' is invalid on the 'bts' level. Instead, the VTY finds the parent node's 'timezone', steps out of 'bts' to the 'network' level, and instead says that the 'trx' command does not exist. Format: Consistent means that two adjacent indenting lines have the exact same indenting characters for the common length: Weird mix if you ask me, but correct and consistent: ROOT <space>PARENT <space><tab><space>CHILD <space><tab><space><tab><tab>GRANDCHILD <space><tab><space><tab><tab>GRANDCHILD2 <space>SIBLING Inconsistent: ROOT <space>PARENT <tab><space>CHILD <space><space><tab>GRANDCHILD <space><tab><tab>GRANDCHILD2 <tab>SIBLING Also, when going back to a parent level, the exact same indenting must be used as before in that node: Incorrect: ROOT <tab>PARENT <tab><tab><tab>CHILD <tab><tab>SIBLING As not really intended side effect, it is also permitted to indent the entire file starting from the root level. We could guard against it but there's no harm: Correct and consistent: <tab>ROOT <tab><tab>PARENT <tab><tab><tab><tab>CHILD <tab><tab>SIBLING Implementation: Track parent nodes state: whenever a command enters a child node, push a parent node onto an llist to remember the exact indentation characters used for that level. As soon as the first line on a child node is parsed, remember this new indentation (which must have a longer strlen() than its parent level) to apply to all remaining child siblings and grandchildren. If the amount of spaces that indent a following VTY command are less than this expected indentation, call vty_go_parent() until it matches up. At any level, if the common length of indentation characters mismatch, abort parsing in error. Transitions to child node are spread across VTY implementations and are hard to change. But transitions to the parent node are all handled by vty_go_parent(). By popping a parent from the list of parents in vty_go_parent(), we can also detect that a command has changed the node without changing the parent, hence it must have stepped into a child node, and we can push a parent frame. The behavior on the interactive telnet VTY remains unchanged. Change-Id: I24cbb3f6de111f2d31110c3c484c066f1153aac9 ----------------------------------------------------------------------- Summary of changes: include/osmocom/vty/command.h | 2 + include/osmocom/vty/vty.h | 23 ++++ src/vty/command.c | 216 ++++++++++++++++++++++++++++++++----- src/vty/vty.c | 8 ++ tests/Makefile.am | 13 ++- tests/testsuite.at | 1 + tests/vty/fail_not_de-indented.cfg | 3 + tests/vty/fail_tabs_and_spaces.cfg | 4 + tests/vty/fail_too_much_indent.cfg | 3 + tests/vty/ok.cfg | 3 + tests/vty/ok_ignore_blank.cfg | 7 ++ tests/vty/ok_ignore_comment.cfg | 7 ++ tests/vty/ok_indented_root.cfg | 3 + tests/vty/ok_more_spaces.cfg | 4 + tests/vty/ok_tabs.cfg | 4 + tests/vty/ok_tabs_and_spaces.cfg | 4 + tests/vty/vty_test.c | 20 ++++ tests/vty/vty_test.ok | 20 ++++ 18 files changed, 320 insertions(+), 25 deletions(-) create mode 100644 tests/vty/fail_not_de-indented.cfg create mode 100644 tests/vty/fail_tabs_and_spaces.cfg create mode 100644 tests/vty/fail_too_much_indent.cfg create mode 100644 tests/vty/ok.cfg create mode 100644 tests/vty/ok_ignore_blank.cfg create mode 100644 tests/vty/ok_ignore_comment.cfg create mode 100644 tests/vty/ok_indented_root.cfg create mode 100644 tests/vty/ok_more_spaces.cfg create mode 100644 tests/vty/ok_tabs.cfg create mode 100644 tests/vty/ok_tabs_and_spaces.cfg hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libsmpp34.git branch master updated. 1.12-8-g6619771
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom fork of the Open SMPP 3.4 library". The branch, master has been updated via 66197717500693ba089e044817bfdf457dc34090 (commit) from c63971fab0d67bc52d7fd455529b844009aa8565 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libsmpp34/commit/?id=66197717500693ba089e044817bfdf… commit 66197717500693ba089e044817bfdf457dc34090 Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Sun Sep 17 17:05:54 2017 +0200 contrib: Enable -Werror by default Change-Id: I2a88cdcbf76ea28a30e82836030f894c2152d5ed ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom fork of the Open SMPP 3.4 library

1 0

libosmo-abis.git branch master updated. 0.4.0-2-g01543a1
by gitosis＠osmocom.org 19 Sep '17

19 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via 01543a1ea392fa98974ea2f99cafbc28e9966656 (commit) from d3292913ac99b4a57094ca19fd70571ec6914f48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=01543a1ea392fa98974ea2f99ca… commit 01543a1ea392fa98974ea2f99cafbc28e9966656 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Sep 14 04:32:19 2017 +0200 cosmetic: ipa.c: use msgb_dequeue(), drop local var Make ipa_server_conn_write() a lot simpler and shorter by using msgb_dequeue() and avoiding local pointer that was used only once. Change-Id: Id968e60d081a6d69de482a908ca3fe5e1044aaa3 ----------------------------------------------------------------------- Summary of changes: src/input/ipa.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) hooks/post-receive -- Osmocom A-bis protcol interface library

1 0

libosmo-netif.git branch master updated. 0.0.6-85-g5994198
by gitosis＠osmocom.org 18 Sep '17

18 Sep '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via 59941982083f7f0d6ab11f7bbb42c297a3fb8d69 (commit) from 14af167a5553519d8164f4a21556888535eeefeb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=59941982083f7f0d6ab11f7bbb… commit 59941982083f7f0d6ab11f7bbb42c297a3fb8d69 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Sep 12 12:44:53 2017 +0200 src: _snprintf() helper functions nul-terminate buffers, if possible This patch inconditionally initializes the buffer we get to nul-terminate it, whenever possible. It's a very simple solution to catch three overly corner cases: 1) snprintf() returns -1, very much unlikely in practise. 2) msg->len == 0: In such case, I would expect this function is never called with an empty message, but let's be safe in this case too. 3) If your buffer is empty, it doesn't nul-terminate the buffer. Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2 ----------------------------------------------------------------------- Summary of changes: src/osmux.c | 3 +++ src/rtp.c | 3 +++ 2 files changed, 6 insertions(+) hooks/post-receive -- Osmocom network interface library

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
16
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog September 2017