meta-telephony.git branch laforge/nightly updated. bf43319200e2fe123a9d84fc7af8f3e84c6265f6
by gitosis＠osmocom.org 08 Sep '17
by gitosis＠osmocom.org 08 Sep '17
08 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom layer for OpenEmbedded".
The branch, laforge/nightly has been updated
via bf43319200e2fe123a9d84fc7af8f3e84c6265f6 (commit)
from b58904accd730b8505320d62e0c198274b422d7f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/meta-telephony/commit/?id=bf43319200e2fe123a9d84fc7…
commit bf43319200e2fe123a9d84fc7af8f3e84c6265f6
Author: Pau Espin Pedrol <pespin(a)sysmocom.de>
Date: Wed Sep 6 12:09:52 2017 +0200
libosmo-abis: modify PV to match recent release
The upstream release commit is 7f17b8c45d094941292036143f3292a1d5789cf5.
This should fix current issue with 201705/nightly package feed:
$ opkg upgrade
Not selecting libosmo-abis 0.3.2+gitr0+d3292913ac as installing it would break existing dependencies.
$ opkg list_installed | grep libosmo-abis
libosmo-abis - 0.3.2+gitr2+d3292913ac-r2.18.1.0
See that gitr in repos is 0 while the previously installed one has
gitr2, which is higher. Explanations I can find for this:
- PR server was somehow reset?
- the value in gitr is calculated based on offset from latest tag. As
new release introduced new tag, gitr may have been reset.
In any case, updating PV to have the correct value should fix this
issue.
Change-Id: I9f27661d9e5241efe7725b7d1efcf4aef55e2efe
-----------------------------------------------------------------------
Summary of changes:
recipes-osmocom/libosmo-abis/libosmo-abis_git.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
Osmocom layer for OpenEmbedded
1
0
osmocom-bb.git branch master updated. osmocon_v0.0.0-1841-g903e2515
by gitosis＠osmocom.org 08 Sep '17
by gitosis＠osmocom.org 08 Sep '17
08 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Open Source GSM Base Band stack".
The branch, master has been updated
via 903e2515f5d92b152804ae4afbe67499d0a90d61 (commit)
from 281d9ac3818401ec0abe5268528e01c0a6e1a9d8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmocom-bb/commit/?id=903e2515f5d92b152804ae4afbe67…
commit 903e2515f5d92b152804ae4afbe67499d0a90d61
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Sep 7 12:23:16 2017 +0200
Add arbitrary config file location support
All other Osmocom projects use '-c' command line option to specify the
location of config file. Let's do the same with fallback to existing
implicit config file name logic.
Also print config file path and vty host on startup.
Change-Id: Idaac3ff8d1f8541e00c45290db948a67bb899311
-----------------------------------------------------------------------
Summary of changes:
src/host/layer23/src/mobile/app_mobile.c | 3 ++-
src/host/layer23/src/mobile/main.c | 24 ++++++++++++++----------
2 files changed, 16 insertions(+), 11 deletions(-)
hooks/post-receive
--
The Open Source GSM Base Band stack
1
0
openbsc.git branch users/daniel/ow-nat-msc-conns updated. 0.15.0-105-g606d70cd2
by gitosis＠osmocom.org 08 Sep '17
by gitosis＠osmocom.org 08 Sep '17
08 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, users/daniel/ow-nat-msc-conns has been updated
discards abd774005879d99188b1ef118d6ba0a20d22082f (commit)
discards d8429fbe1e6da857ad8ba6ada14c078ca18f3779 (commit)
via 606d70cd2630f2045a754a42b98416d84b60d793 (commit)
via e482de09ea595375a28b565f440726fe19bb4592 (commit)
via e47f67588a774bcb3bb1fa39972d3f705d167f18 (commit)
via 986e54a1982dd1bab71dc843ff0c4ae014f83965 (commit)
via b27944450392d5d3dda548a585406224acdf58d6 (commit)
via b55d939e126aac15a434c55d0689ae4dfaf0ecfa (commit)
via 1e641a1690fec1e2fc3319460583490f147fd74d (commit)
via 55a163abaf57812f4574c23dcee857ce8f05ddb2 (commit)
via 9bc66b806fa75e914b2bc958058391907d3860aa (commit)
via 2152d82dafd8c8b390de9a0e4bc8719bcd51273d (commit)
via 86a4589c0399721dd309614794df0791f337622f (commit)
via 1f7d6452560a73452e0ce6059adf933b6dfd5458 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (abd774005879d99188b1ef118d6ba0a20d22082f)
\
N -- N -- N (606d70cd2630f2045a754a42b98416d84b60d793)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=606d70cd2630f2045a754a42b98416d8…
commit 606d70cd2630f2045a754a42b98416d84b60d793
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 04:02:28 2017 +0200
osmo-bsc_nat: Add missing return code for VTY
Change-Id: I12b421e970317c604ac8cc2f3c94ff5fdbc3f048
http://cgit.osmocom.org/openbsc/commit/?id=e482de09ea595375a28b565f440726fe…
commit e482de09ea595375a28b565f440726fe19bb4592
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 04:01:42 2017 +0200
osmo-bsc_nat: Attempt to make bsc_mgcp_find_con aware of multiple MGCP
Change-Id: I508562d48e2a0733ea53fe7adaae828286f791a2
http://cgit.osmocom.org/openbsc/commit/?id=e47f67588a774bcb3bb1fa39972d3f70…
commit e47f67588a774bcb3bb1fa39972d3f705d167f18
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 04:00:55 2017 +0200
WIP: Add missing lines
Change-Id: I353502ed27fc1eb828169a4aaccaf04593eacdd8
http://cgit.osmocom.org/openbsc/commit/?id=986e54a1982dd1bab71dc843ff0c4ae0…
commit 986e54a1982dd1bab71dc843ff0c4ae014f83965
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 04:00:08 2017 +0200
osmo-bsc_nat: Handle multiple mgcp configs in SCCP conn
Change-Id: Ifb6efa8339b749ab588a5ea37f0b48bc8086ae46
http://cgit.osmocom.org/openbsc/commit/?id=b27944450392d5d3dda548a585406224…
commit b27944450392d5d3dda548a585406224acdf58d6
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 03:58:41 2017 +0200
osmo-bsc_nat: Handle multiple mgcp configs in MGCP NAT code
Change-Id: Icbf2951cfc550f75580e95a05804e479c59ec1df
http://cgit.osmocom.org/openbsc/commit/?id=b55d939e126aac15a434c55d0689ae4d…
commit b55d939e126aac15a434c55d0689ae4dfaf0ecfa
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 03:49:26 2017 +0200
osmo-bsc_nat: Modify nat init to work with multiple mgcp_configs
Change-Id: I53ac858952ee15f897160b3a32483c5c91b862f6
http://cgit.osmocom.org/openbsc/commit/?id=1e641a1690fec1e2fc3319460583490f…
commit 1e641a1690fec1e2fc3319460583490f147fd74d
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 03:38:50 2017 +0200
libmgcp: Allow to get the mgcp_config by number
Change-Id: I9567b168696bc43c8f74cf0da9a4c647e8bdd822
http://cgit.osmocom.org/openbsc/commit/?id=55a163abaf57812f4574c23dcee857ce…
commit 55a163abaf57812f4574c23dcee857ce8f05ddb2
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Fri Sep 8 03:37:58 2017 +0200
Add warnings in places missing support
Change-Id: Ic3de69792b2cd8e19cd140402bc1f5fbf9a00021
http://cgit.osmocom.org/openbsc/commit/?id=9bc66b806fa75e914b2bc95805839190…
commit 9bc66b806fa75e914b2bc958058391907d3860aa
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Thu Sep 7 16:35:01 2017 +0200
osmo-bsc_mgcp: Make it work with the changes supporting multiple MGCP
osmo-bsc_mgcp will still only use the first mgcp instance, but this
copes with the API changes in mgcp_parse_config.
Change-Id: I52ea74103acef374212e276dfa8122b00ca4562a
http://cgit.osmocom.org/openbsc/commit/?id=2152d82dafd8c8b390de9a0e4bc8719b…
commit 2152d82dafd8c8b390de9a0e4bc8719bcd51273d
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Thu Sep 7 16:32:27 2017 +0200
libmgcp: Make it possible to define more than one MGCP instance
Change-Id: I820839e46f56bdaaf6b05df434829c3eee21e5b9
http://cgit.osmocom.org/openbsc/commit/?id=86a4589c0399721dd309614794df0791…
commit 86a4589c0399721dd309614794df0791f337622f
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Thu Mar 2 17:26:32 2017 +0100
WIP
Change-Id: If40b0bd51773b1658f744063be418c024a781e11
http://cgit.osmocom.org/openbsc/commit/?id=1f7d6452560a73452e0ce6059adf933b…
commit 1f7d6452560a73452e0ce6059adf933b6dfd5458
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Tue Mar 21 12:25:14 2017 +0100
libfilter: Also handle detach indications
Change-Id: Iad4e2861f42d5275e2b3057ab2bc43ef43b61cfe
Ticket: SYS#3208
Sponsored-by: On-Waves ehf.
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/bsc_nat.h | 13 +-
openbsc/include/openbsc/bsc_nat_sccp.h | 2 +
openbsc/include/openbsc/mgcp.h | 5 +-
openbsc/src/libcommon/common_vty.c | 5 +-
openbsc/src/libmgcp/mgcp_vty.c | 566 ++++++++++++++++++++----------
openbsc/src/osmo-bsc_mgcp/mgcp_main.c | 25 +-
openbsc/src/osmo-bsc_nat/bsc_mgcp_utils.c | 245 +++++++------
openbsc/src/osmo-bsc_nat/bsc_nat.c | 18 +-
openbsc/src/osmo-bsc_nat/bsc_nat_utils.c | 4 +-
openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 17 +-
openbsc/tests/bsc-nat/bsc_nat_test.c | 8 +-
11 files changed, 583 insertions(+), 325 deletions(-)
hooks/post-receive
--
Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
1
0
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GSM Audio Pocket Knife".
The branch, fixeria/lib has been updated
discards 293384fd1b3d6c681d7f4862f98eb52977551e00 (commit)
discards aedbe9ad7a352b3fdd846aa6093b5cde29b0749b (commit)
discards d25004a98122d84039b8ce20932729189c8ae171 (commit)
discards 5f332917e1ce8fcaa67a8406e69df9a1e01b2b67 (commit)
discards 7d411284afeb9489a3fe0126396f094ad305c0f5 (commit)
discards 2b02f8ec27a15302f744bee4a3a0502233ff5e2e (commit)
discards f5d00d8516ba589ab4bf289f04e8685031bf5031 (commit)
discards aad0a4d3cb62da0714f7bd895dd637e34f067a09 (commit)
discards 67478b31790a5bde09e98247539df28e416fa875 (commit)
discards 7aaf2a49b44af4fba743486a30110d292836b3b8 (commit)
discards ce3aa9eec21eeb4b68caa31aac1a8936e33302bb (commit)
discards fe5c7d915ce3b7c5a913694d8e6305e43ab4c16e (commit)
discards f93b65356dc6d33e8e4611d0a0acb587a1439909 (commit)
via 27cc5fbbcb2b5649c9bca452e8a00335d9a278a7 (commit)
via 01edb56d7bb082ecc187254c2f0a54178dd9ff3f (commit)
via 8923276018b9a8d5ebafa2e18676fe6b8cef26a4 (commit)
via 3e8cfdea6a2e1da03b6601c96b87d2a5683c73c6 (commit)
via 0d177795d1ffe70d926281034116d73199265202 (commit)
via 3d5a901ffe24ab38a2050afca7a146d840a1f303 (commit)
via caeee8214084f8949e855780ce1cbfd42a514e78 (commit)
via 1e220b9f3c2a0d9a1a6ea39d0972a207a51168bd (commit)
via d02ada5c46a8938f5d9fd09e255dc6501937785d (commit)
via d8bdf47aaffb768c26b89511d1af7bce616543d2 (commit)
via 6e0fe0e103612e01817dba857f5077adeb87ea84 (commit)
via a3b4fb8be1bb9316443dedab0dcf9079328f13a6 (commit)
via cd2da365a81999db5a092b6bfb984d57b471883e (commit)
via 903f14cdf48faa61996b22b68361c511c920b3b9 (commit)
via 0d97f46b8757e0947304d88777706bd9a98a4c69 (commit)
via 6683ef0a17dda6eb50aaeede8805936c751ec4a5 (commit)
via f72d01558f16717d49380428310d1a269f8540c6 (commit)
via ea53827e34b3d223c053289f7ef39f3105712a18 (commit)
via 36e92c49c510711bd7e88beb2935a2a298def9fe (commit)
via 43f74129c6ed128de8235aed1ce7d0f285193206 (commit)
via f4650d455bde1cd7a489123db3ebfbf2dc860b8e (commit)
via 6028be8e8655d8eabc1929ff0753114814f5dacd (commit)
via 4922c8376713196d909cb7b6d204cb10664116c2 (commit)
via 617daf02012a4e4d1a104d52f2517ad81b72dd54 (commit)
via e7959b00f6f21f371b24cd1960b36aacd34bdeb7 (commit)
via e6986f70c5f609692c7067a758233e2d8327de6b (commit)
via a03ac4573a2c00a6b2937c42503b6c7206480662 (commit)
via 5fb1965cacb7a3aaf269dbb8e0238721a7d44c05 (commit)
via d5cfaa6a52d09551661f2cc8ef7ffc24f809960a (commit)
via 83aa99e7a9a1ff0d6949b4c71cd8817e2668b341 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (293384fd1b3d6c681d7f4862f98eb52977551e00)
\
N -- N -- N (27cc5fbbcb2b5649c9bca452e8a00335d9a278a7)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gapk/commit/?id=27cc5fbbcb2b5649c9bca452e8a00335d9a…
commit 27cc5fbbcb2b5649c9bca452e8a00335d9a278a7
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Fri Sep 8 00:05:02 2017 +0300
osmo-gapk: wait until sink finish processing
Previously the osmo-gapk application used to exit as soon as all
the frames are processed, no matter has the sink finished its
internal processing (e.g. ALSA playback).
http://cgit.osmocom.org/gapk/commit/?id=01edb56d7bb082ecc187254c2f0a54178dd…
commit 01edb56d7bb082ecc187254c2f0a54178dd9ff3f
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Fri Sep 8 00:02:20 2017 +0300
src/pq_alsa.c: implement processing state callback
Using the snd_pcm_avail_update() call from ALSA API it's possible
to know, how much samples are still to be processed.
http://cgit.osmocom.org/gapk/commit/?id=8923276018b9a8d5ebafa2e18676fe6b8ce…
commit 8923276018b9a8d5ebafa2e18676fe6b8cef26a4
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 7 18:42:49 2017 +0300
procqueue: add processing state callback
In some cases it's required to wait for some queue items
to finish processing. For example, the ALSA sink writes the
audio samples to the buffer in non-blocking mode, so as soon
as all of them will be written, a program may finish execution,
causing the playback abort.
To prevent that, this change extends the library's API, allowing
each queue item to have a processing state callback that returns
a positive integer if processing is not finished yet,
and 0 otherwise.
http://cgit.osmocom.org/gapk/commit/?id=3e8cfdea6a2e1da03b6601c96b87d2a5683…
commit 3e8cfdea6a2e1da03b6601c96b87d2a5683c73c6
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 7 17:51:35 2017 +0300
osmo-gapk: abort the processing queue on SIGINT
Instead of immediately shutting down the application, it is
better to try to break the processing queue first, and stop
the execution immediately if second SIGINT is received.
http://cgit.osmocom.org/gapk/commit/?id=0d177795d1ffe70d926281034116d731992…
commit 0d177795d1ffe70d926281034116d73199265202
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 7 17:39:24 2017 +0300
osmo-gapk: adjust application verbosity
This change allows user to enable advanced verbosity using the
'-v' command line option, which is disabled by default.
http://cgit.osmocom.org/gapk/commit/?id=3d5a901ffe24ab38a2050afca7a146d840a…
commit 3d5a901ffe24ab38a2050afca7a146d840a1f303
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 7 17:10:14 2017 +0300
osmo-gapk: use Osmocom logging framework
http://cgit.osmocom.org/gapk/commit/?id=caeee8214084f8949e855780ce1cbfd42a5…
commit caeee8214084f8949e855780ce1cbfd42a514e78
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 7 16:48:27 2017 +0300
osmo-gapk: drop useless printf calls
The printf() writes the text into stdout, which may be undesirable
in some use cases. Moreover, the printed information was redundant.
So, let's drop such calls.
http://cgit.osmocom.org/gapk/commit/?id=1e220b9f3c2a0d9a1a6ea39d0972a207a51…
commit 1e220b9f3c2a0d9a1a6ea39d0972a207a51168bd
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 7 16:36:56 2017 +0300
libosmogapk: use Osmocom logging framework
Since this change, the libosmogapk uses the Osmocom logging
framework. By default, logging is disabled and could be enabled
by the external applications calling the osmo_gapk_log_init()
with a desired log target as an argument.
http://cgit.osmocom.org/gapk/commit/?id=d02ada5c46a8938f5d9fd09e255dc650193…
commit d02ada5c46a8938f5d9fd09e255dc6501937785d
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 7 00:04:01 2017 +0300
osmo-gapk: use more convenient name for the source file
Since GAPK package contains a library and the representative
osmo-gapk application, the 'main.c' looks a bit confusing. Let's
use the common naming scheme.
http://cgit.osmocom.org/gapk/commit/?id=d8bdf47aaffb768c26b89511d1af7bce616…
commit d8bdf47aaffb768c26b89511d1af7bce616543d2
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Sep 6 23:53:30 2017 +0300
osmo-gapk: create a common shutdown function
Previously the code intended to shutdown the osmo-gapk application
was repeated two times. It's better to have a single function.
http://cgit.osmocom.org/gapk/commit/?id=6e0fe0e103612e01817dba857f5077adeb8…
commit 6e0fe0e103612e01817dba857f5077adeb87ea84
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Sep 6 23:42:19 2017 +0300
osmo-gapk: add an option to enable / disable benchmark
If the codec benchmarking is required in particular case, it
could be activated by a special command line option introduced
by this change.
http://cgit.osmocom.org/gapk/commit/?id=a3b4fb8be1bb9316443dedab0dcf9079328…
commit a3b4fb8be1bb9316443dedab0dcf9079328f13a6
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Fri Sep 1 16:19:40 2017 +0700
procqueue: use linuxlist to store queue items
The usage of linuxlist is more flexible than having a limited
array of pointers. This approach allows to have as much items
in a processing queue as required.
http://cgit.osmocom.org/gapk/commit/?id=cd2da365a81999db5a092b6bfb984d57b47…
commit cd2da365a81999db5a092b6bfb984d57b471883e
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Fri Sep 1 15:22:32 2017 +0700
procqueue: use uint8_t as output buffer type
http://cgit.osmocom.org/gapk/commit/?id=903f14cdf48faa61996b22b68361c511c92…
commit 903f14cdf48faa61996b22b68361c511c920b3b9
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Fri Sep 1 15:15:45 2017 +0700
procqueue: store output buffers inside queue items
An output buffer belongs to its queue item, so it will be more
correctly to store its pointer inside the osmo_gapk_pq_item.
http://cgit.osmocom.org/gapk/commit/?id=0d97f46b8757e0947304d88777706bd9a98…
commit 0d97f46b8757e0947304d88777706bd9a98a4c69
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Fri Sep 1 14:33:19 2017 +0700
procqueue: use unsigned int for I/O frame size fields
A frame size cannot be negative, so 'unsigned' is more
suitable for frame size fields.
http://cgit.osmocom.org/gapk/commit/?id=6683ef0a17dda6eb50aaeede8805936c751…
commit 6683ef0a17dda6eb50aaeede8805936c751ec4a5
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Aug 31 17:49:36 2017 +0700
Add the symbol export map for libosmogapk
http://cgit.osmocom.org/gapk/commit/?id=f72d01558f16717d49380428310d1a269f8…
commit f72d01558f16717d49380428310d1a269f8540c6
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Sep 4 04:18:06 2017 +0700
benchmark: add functions to get cycle and frame count
To simplify the benchrarking process via the library API, this
change introduces two new functions, which are intended to
provide total cycle and frame count.
http://cgit.osmocom.org/gapk/commit/?id=ea53827e34b3d223c053289f7ef39f31057…
commit ea53827e34b3d223c053289f7ef39f3105712a18
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Sep 4 03:33:48 2017 +0700
benchmark: allocate memory dynamically
Having statically allocated memory for benchmark data of every
codec causes high memory usage, especially if actual benchmarking
is not required for a particular use case. Instead of that, let's
provide an optional opportunity to enable benchmarking for a
particular codec by calling the osmo_gapk_bench_enable(). The
required amount of memory would be allocated, and then can be
freed by calling the osmo_gapk_bench_free() or manually.
http://cgit.osmocom.org/gapk/commit/?id=36e92c49c510711bd7e88beb2935a2a298d…
commit 36e92c49c510711bd7e88beb2935a2a298def9fe
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Sep 4 03:03:32 2017 +0700
benchmark: get rid of 'static inline' definition
The usage of a 'static inline' function definition in the 'bench.h'
is resulting in separate independent function definitions in each
translation unit from which the header is included. This is
increasing the size of compiled code unnecessarily.
http://cgit.osmocom.org/gapk/commit/?id=43f74129c6ed128de8235aed1ce7d0f2851…
commit 43f74129c6ed128de8235aed1ce7d0f285193206
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Sep 4 02:23:18 2017 +0700
benchmark: move benchmark impl to a private header
There is no need to expose the implementation details of both
BENCHMARK_START and BENCHMARK_STOP macros via public header.
This change moves them to a separate private header 'bench.h'.
http://cgit.osmocom.org/gapk/commit/?id=f4650d455bde1cd7a489123db3ebfbf2dc8…
commit f4650d455bde1cd7a489123db3ebfbf2dc860b8e
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Sep 4 00:42:38 2017 +0700
benchmark: move benchmark_dump() outside the library
The benchmark_dump() is only used by the osmo-gapk binary, and
is intended to prepare and print benchmarking results to stderr,
what is most likely unusable for the library users.
http://cgit.osmocom.org/gapk/commit/?id=6028be8e8655d8eabc1929ff0753114814f…
commit 6028be8e8655d8eabc1929ff0753114814f5dacd
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Aug 31 17:22:56 2017 +0700
Add an 'osmo_gapk' prefix to the exposed symbols
To avoid a naming conflict between libosmogapk and other projects
during linkage, all the exposed symbols should have an unique
prefix. Let's use 'osmo_gapk' for that.
http://cgit.osmocom.org/gapk/commit/?id=4922c8376713196d909cb7b6d204cb10664…
commit 4922c8376713196d909cb7b6d204cb10664116c2
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Aug 31 02:31:18 2017 +0700
procqueue: expose the processing queue struct definition
To be able to use processing queues from outside, the pq struct
should be shared in the corresponding header file.
http://cgit.osmocom.org/gapk/commit/?id=617daf02012a4e4d1a104d52f2517ad81b7…
commit 617daf02012a4e4d1a104d52f2517ad81b72dd54
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Aug 31 01:41:26 2017 +0700
Add a pkg-config manifest for libosmogapk
In order to make pkg-config 'see' the libosmogapk, a corresponding
package description is required. For more details, see:
https://autotools.io/pkgconfig/file-format.html
http://cgit.osmocom.org/gapk/commit/?id=e7959b00f6f21f371b24cd1960b36aacd34…
commit e7959b00f6f21f371b24cd1960b36aacd34bdeb7
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Aug 31 01:20:18 2017 +0700
Use '#pragma once' instead of include guard
The most compilers today do support the '#pragma once', which is
designed to cause the current source file to be included only once
in a single compilation. One has several advantages, including:
less code, avoidance of name clashes, and sometimes improvement
in compilation speed.
See: https://en.wikipedia.org/wiki/Pragma_once for details.
http://cgit.osmocom.org/gapk/commit/?id=e6986f70c5f609692c7067a758233e2d832…
commit e6986f70c5f609692c7067a758233e2d8327de6b
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Aug 30 20:26:02 2017 +0700
Install GAPK headers to '${includedir}/osmocom/gapk/'
To be able to use the library, external applications need to know,
which symbols are exposed. This information is provided by header
files, which are being installed to a system's ${includedir}
since this change.
http://cgit.osmocom.org/gapk/commit/?id=a03ac4573a2c00a6b2937c42503b6c72064…
commit a03ac4573a2c00a6b2937c42503b6c7206480662
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Aug 30 19:35:51 2017 +0700
Add an 'osmo' prefix to the 'gapk' binary
This is a common practice of all Osmocom executables
to have an 'osmo' prefix. Let's follow this here too.
http://cgit.osmocom.org/gapk/commit/?id=5fb1965cacb7a3aaf269dbb8e0238721a7d…
commit 5fb1965cacb7a3aaf269dbb8e0238721a7d44c05
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Aug 30 19:03:49 2017 +0700
Introduce a shared 'libosmogapk' library
The previous GAPK implementation was represented as a single
executable. So, all audio transcoding operations were available
only by calling the 'gapk' binary. This approach didn't allow
external applications to benefit from using GAPK API directly.
Since there are some projects (such as GR-GSM and OsmocomBB),
which are potential users of GAPK code base, it would be better
to have all transcoding functions within a shared library.
So, this change separates the common code into a shared library,
named 'libosmogapk', and links the 'gapk' binary against one.
Currently there are no shared headers, pkg-config manifest and
the export map, but they will be done latter.
-----------------------------------------------------------------------
Summary of changes:
configure.ac | 2 +-
include/Makefile.am | 7 +-
src/benchmark.c => include/osmocom/gapk/bench.h | 66 +++----
include/osmocom/gapk/benchmark.h | 38 ++--
include/osmocom/gapk/codecs.h | 7 -
src/codec_pcm.c => include/osmocom/gapk/common.h | 12 +-
include/osmocom/gapk/formats.h | 18 --
src/codec_pcm.c => include/osmocom/gapk/logging.h | 19 +-
include/osmocom/gapk/procqueue.h | 1 +
src/Makefile.am | 13 +-
src/{main.c => app_osmo_gapk.c} | 219 +++++++++++++++++-----
src/benchmark.c | 87 ++++++---
src/codec_amr.c | 3 +-
src/codec_efr.c | 3 +-
src/codec_fr.c | 3 +-
src/codec_hr.c | 3 +-
src/codec_pcm.c | 2 +-
src/codecs.c | 18 +-
src/fmt_amr.c | 2 +-
src/fmt_amr_opencore.c | 2 +-
src/fmt_gsm.c | 2 +-
src/fmt_hr_ref.c | 4 +-
src/fmt_racal.c | 6 +-
src/fmt_rawpcm.c | 2 +-
src/fmt_rtp_amr.c | 2 +-
src/fmt_rtp_efr.c | 2 +-
src/fmt_rtp_hr_etsi.c | 2 +-
src/fmt_rtp_hr_ietf.c | 2 +-
src/fmt_ti.c | 6 +-
src/formats.c | 50 +++--
src/libosmogapk.map | 32 +---
src/{codec_pcm.c => logging.c} | 18 +-
src/pq_alsa.c | 35 +++-
src/pq_codec.c | 4 +-
src/pq_file.c | 6 +-
src/pq_format.c | 13 +-
src/pq_rtp.c | 9 +-
src/procqueue.c | 7 +-
38 files changed, 447 insertions(+), 280 deletions(-)
copy src/benchmark.c => include/osmocom/gapk/bench.h (50%)
copy src/codec_pcm.c => include/osmocom/gapk/common.h (71%)
copy src/codec_pcm.c => include/osmocom/gapk/logging.h (72%)
rename src/{main.c => app_osmo_gapk.c} (69%)
copy src/{codec_pcm.c => logging.c} (71%)
hooks/post-receive
--
GSM Audio Pocket Knife
1
0
07 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 889ab16437297a2ce1885efde5e2efc4816851ff (commit)
from 03516d6dd2fe94e94879db285d0b3492f0734831 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=889ab16437297a2ce1885efde5e2…
commit 889ab16437297a2ce1885efde5e2efc4816851ff
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Thu Sep 7 20:41:12 2017 +0200
ipa: place comment "IPA Multiplex" on ipa allocated msgbs
libosmocore offers the ipa API as general IPA Multiplex, which is e.g. used for
GSUP in osmo-msc. Looking at talloc reports, it is confusing to see "Abis/IP"
as msgb comment, because osmo-msc does not have an Abis interface.
Rename to "IPA Multiplex" as a more general description.
Change-Id: I3714dd21707bec0c4bcd0871e6ee8ff32d56b125
-----------------------------------------------------------------------
Summary of changes:
src/gsm/ipa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
1
0
osmocom-bb.git branch laforge/lib-update created. osmocon_v0.0.0-2635-gde3f6080
by gitosis＠osmocom.org 07 Sep '17
by gitosis＠osmocom.org 07 Sep '17
07 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Open Source GSM Base Band stack".
The branch, laforge/lib-update has been created
at de3f6080aaf86c6ea0e59d0223934680d6fd1cc9 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmocom-bb/commit/?id=de3f6080aaf86c6ea0e59d0223934…
commit de3f6080aaf86c6ea0e59d0223934680d6fd1cc9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 19:15:37 2017 +0100
define 'fprintf(stderr,' as a wrapper around printf(
This is in preparation to work with a more recent version of
libosmocore, which wants to print to stderr in some cases.
http://cgit.osmocom.org/osmocom-bb/commit/?id=84ac308411474aa2e1f6bb063f1dd…
commit 84ac308411474aa2e1f6bb063f1dd0906e8f33b2
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 19:15:14 2017 +0100
Add an endian.h file as one step to build against later libosmocore
http://cgit.osmocom.org/osmocom-bb/commit/?id=9f5891269189590c7041565355e30…
commit 9f5891269189590c7041565355e30695455859b6
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 19:14:01 2017 +0100
Add libosmocore/build-target/include to include path
Some header files are auto-generated and are thus in the build
directory, not in the source directory. A cleaner way to handle this is
most likely to install libosmocore to some directory, but I don't want
to change the entire build process now.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f4d9df5531681d64d72890add7a81…
commit f4d9df5531681d64d72890add7a81942de9c1c22
Merge: 4b9bff0d 2f0b0c95
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 17:11:55 2017 +0100
Merge commit '2f0b0c955b4031a9dd95829322455cf883d40f53' into lib-update
http://cgit.osmocom.org/osmocom-bb/commit/?id=4b9bff0de15379c97b13ecf9040a1…
commit 4b9bff0de15379c97b13ecf9040a17c55fd71493
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 17:07:09 2017 +0100
fix various other compiler warnings
http://cgit.osmocom.org/osmocom-bb/commit/?id=708f18d0c2ba2f2e13d5ec2acfbf7…
commit 708f18d0c2ba2f2e13d5ec2acfbf7ef4eaaad278
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 16:59:32 2017 +0100
cfi_flash.c: Fix various format string compiler warnings
http://cgit.osmocom.org/osmocom-bb/commit/?id=96be35f4bb6e52b347dc6d46fe020…
commit 96be35f4bb6e52b347dc6d46fe020d1ce9a1fc3f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 16:55:53 2017 +0100
trf6151: Fix setting of uplink ARFCN
Somebody (me?) wrote exclamation marks instead of pipe symbols.
Found by a modern gcc:
rf/trf6151.c: In function 'trf6151_set_arfcn':
rf/trf6151.c:439:8: warning: comparison is always true due to limited
range of data type [-Wtype-limits]
arfcn != ~ARFCN_UPLINK;
^
rf/trf6151.c:439:2: warning: statement with no effect [-Wunused-value]
arfcn != ~ARFCN_UPLINK;
^
http://cgit.osmocom.org/osmocom-bb/commit/?id=f04442d75f661ad37c5d0c734b64a…
commit f04442d75f661ad37c5d0c734b64a34038ad4183
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 16:52:19 2017 +0100
Avoid redefining __{packed,aligned,unused,section}
It seems modern version of newlib define those themselves, so we should
avoid re-defining them. Removes tons of compiler warnings when
compiling against libnewlib 2.4.0
http://cgit.osmocom.org/osmocom-bb/commit/?id=4de980b32c09dc0697f8f84302b64…
commit 4de980b32c09dc0697f8f84302b646d48cdbef28
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jan 15 16:49:06 2017 +0100
WIP: Attempt to make linker scripts compatible with binutils 2.27
In binutils-2.27, one can no longer have linker sections with
overlapping VMA addresses. Let's try to work around this.
See https://osmocom.org/issues/1917 for more details.
http://cgit.osmocom.org/osmocom-bb/commit/?id=2f0b0c955b4031a9dd95829322455…
commit 2f0b0c955b4031a9dd95829322455cf883d40f53
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jan 12 16:47:13 2017 +0100
Fix compilation warnings: missing includes: gsm0411_utils.c, lapd_core.c, oap_test.c
Change-Id: Id524327b3f44e22e3aa44c5e8e4965b084cb326a
http://cgit.osmocom.org/osmocom-bb/commit/?id=c32bfd5824b99b9af14b66d17a58f…
commit c32bfd5824b99b9af14b66d17a58fdf9c3bddb45
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Jan 12 22:32:19 2017 +0100
gprs_ns_vty: guard against duplicate VTY elements
The TbfTest in osmo-pcu calls gprs_ns_vty_init() repeatedly, which aborts
because of duplicate VTY elements. Fix this by skipping the VTY init if
it already happened.
Change-Id: I05c7f25a4e873ae76b206819180b8b043b60103e
http://cgit.osmocom.org/osmocom-bb/commit/?id=1251afe2542417426ffe9a4aace26…
commit 1251afe2542417426ffe9a4aace2603f06eb15bd
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Jan 11 18:12:32 2017 +0100
Add abis_nm_fail_evt_vrep() function
It accept fixed number of arguments including va_list instead of variable
number of arguments in abis_nm_fail_evt_rep() - similar to vprintff() vs
printf().
Related: OS#1615
Change-Id: Ib293dec1c2de9b664584a8456c782ea7b6dd8555
http://cgit.osmocom.org/osmocom-bb/commit/?id=b632e03f6588636d3ea4f64215475…
commit b632e03f6588636d3ea4f642154754f0aca33988
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jan 9 12:49:18 2017 +0100
Remove obsolete .deb patch
Change-Id: Icbf911540fcc840833c5012363c2ba48fd71db52
Related: OS#1694
http://cgit.osmocom.org/osmocom-bb/commit/?id=87218edb9acedb0eb797c47357bac…
commit 87218edb9acedb0eb797c47357bac472eacd8c29
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jan 9 14:24:03 2017 +0100
LAPD: improve logging
Log error cause and state names in case of SABM errors.
Change-Id: I2c7fa276e03f8b14ba41cc1fb6e19d0aae77d127
http://cgit.osmocom.org/osmocom-bb/commit/?id=d02c8af6ccb73a18dba5d09112730…
commit d02c8af6ccb73a18dba5d09112730246d05c187d
Author: Jean-Francois Dionne <jf.dionne(a)nutaq.com>
Date: Tue Jan 10 10:23:56 2017 +0100
DTX: fix AMR SID-FIRST detection
Max's note: adjusted test output.
Change-Id: I46477c631bf86345cb757f31d7f2e2935b12adcc
Related: OS#1801
http://cgit.osmocom.org/osmocom-bb/commit/?id=85908a9c2f218b6665b8e90005b90…
commit 85908a9c2f218b6665b8e90005b900c74875e806
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Jan 10 17:49:23 2017 +0100
Add value strings for Probable Cause Type
Add string representation of Probable Cause Type from 3GPP TS 12.21 §
9.4.43.
Change-Id: I9fe14ed3b5398f59dd06a509e4d419e074cc20a7
Related: OS#1615
http://cgit.osmocom.org/osmocom-bb/commit/?id=ebcf02de6cb40bc035c2e94bd6929…
commit ebcf02de6cb40bc035c2e94bd6929ffa9a61ed78
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jan 7 13:27:54 2017 +0100
gsmtap: Add GSMTAP_TYPE_QC_DIAG
This adds a definition for wrapping Qualcomm DIAG frames into GSMTAP for
transporting them over an IP network.
Change-Id: I1b357b7d11a370685671c7b01e55f4f36dec2f25
http://cgit.osmocom.org/osmocom-bb/commit/?id=c0c84323455bf65ef8bb40888dd53…
commit c0c84323455bf65ef8bb40888dd537da1321d1e4
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Jan 4 16:13:04 2017 +0700
gitignore: ignore *.pyc files
Change-Id: I148584e1664b20741c0ade02cbda635c24268d2e
http://cgit.osmocom.org/osmocom-bb/commit/?id=341939142242fb3a8e3e6e153a582…
commit 341939142242fb3a8e3e6e153a582af5aff16889
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jan 7 11:49:55 2017 +0100
fsm: Add VTY introspection of osmo_fsm and their instances
Change-Id: I89212e4f149f019099115a85bab353c04170df90
http://cgit.osmocom.org/osmocom-bb/commit/?id=8808bb49a20e3e569b230b1b8acdf…
commit 8808bb49a20e3e569b230b1b8acdf6f74e1c6bd2
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jan 7 11:11:03 2017 +0100
Add osmo_fsm_find_by_name() and avoid registering FSM with same name
This addresses a FIXME in the fsm.c code: osmo_fsm_register() should
fail in case a FSM with the given name already exists.
Change-Id: I5fd882939859c79581eba70c14cbafd64560b583
http://cgit.osmocom.org/osmocom-bb/commit/?id=addeaa39b172b4114bffbbfdd3dd0…
commit addeaa39b172b4114bffbbfdd3dd09a029eb37b3
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jan 7 12:52:00 2017 +0100
vty: OSMO_ASSERT() if two identical commands are installed
When the caller installs two identical commands at a given VTY node, the
result is that neither of the two commands can ever be executed: The VTY
would always complain about "Ambiguous command.". Let's fail fast at
program start when two identical commands are intalled.
Change-Id: I85ff4640ebb3d8b75a6a9ab5d2f668edb5b7189e
http://cgit.osmocom.org/osmocom-bb/commit/?id=ecbcdf52ec7c165c7933346441c02…
commit ecbcdf52ec7c165c7933346441c02030833aba78
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jan 2 14:43:35 2017 +0100
Add OML Failure Event Report support
Add 3GPP TS 12.21 § 8.8.2 Failure Event Report function which pack given
vararg string and parameters into msgb.
Change-Id: I58c198d8ea588432c62520928b08f0b2a7035e93
Related: OS#1615
http://cgit.osmocom.org/osmocom-bb/commit/?id=07352fee098758431ae1434c47c05…
commit 07352fee098758431ae1434c47c054d94887a6d4
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jan 2 19:05:25 2017 +0100
Add event cause string descriptions
Add human-readable descriptions to event causes from 3GPP TS 12.21 §
9.4.43.
Change-Id: Id173c978616c98b7831fbafb5401064257f1cf73
Related: OS#1615
http://cgit.osmocom.org/osmocom-bb/commit/?id=848de8f1df561f4253f754ec3f241…
commit 848de8f1df561f4253f754ec3f2415e541071420
Author: Pravin Kumarvel <pmanohar(a)radisys.com>
Date: Fri Dec 2 15:13:03 2016 +0530
Add function to get uninterrupted bit run
Function bitvec_rl_curbit added to get number of uninterrupted
bits run in vector starting from the current bit till max number
of bits.
Test case is added to check bitvec_rl_curbit.
Change-Id: Iae153d3639ea6b891c1fc10d7801a435c9492e26
http://cgit.osmocom.org/osmocom-bb/commit/?id=592fcc97c004b7e3e84ed6960ea99…
commit 592fcc97c004b7e3e84ed6960ea9989157c94f75
Author: Minh-Quang Nguyen <minh-quang.nguyen(a)nutaq.com>
Date: Mon Jan 2 14:52:16 2017 +0100
Add cause enum for OML fail reports
Add 3GPP TS 12.21 §9.4.43 Probable Cause values of type 03 (Manufacturer
specific values).
Max's note: renamed to make it clear that values are vendor-specific.
Related: OS#1615
Change-Id: Ie9ba4b53fb19a151447aec9ea309284e20613585
http://cgit.osmocom.org/osmocom-bb/commit/?id=dbd3a92f70325b7a02d0a63792973…
commit dbd3a92f70325b7a02d0a637929732f297fb2612
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jan 2 14:10:30 2017 +0100
Add parsed TLV helpers from OsmoBTS
Add functions to copy and merge parsed TLV structures from OsmoBTS.
Change-Id: Ieaaaed19da9c069fe451faa53d24c5b84d7d5615
http://cgit.osmocom.org/osmocom-bb/commit/?id=0bee65c0d89f81a4b90aa3d484016…
commit 0bee65c0d89f81a4b90aa3d484016d9ba680dd46
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jan 2 13:42:24 2017 +0100
Add OML definitions from OsmoBTS
Change-Id: I9c3bc15662949654e7bba6aad5488c69ee7d0c45
Related: OS#1615
http://cgit.osmocom.org/osmocom-bb/commit/?id=edc8db21fa4fec3a87d7892d219ae…
commit edc8db21fa4fec3a87d7892d219ae26135858e9c
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Jan 4 19:55:51 2017 +0100
Remove direct logging
Drop perror() calls from GSMTAP code: it's application job to do the
proper logging - library code should not write to stdout/stderr
directly.
Change-Id: Ifa149e65d76c6e64fda2946725c16672233aff2e
http://cgit.osmocom.org/osmocom-bb/commit/?id=b1edd16e75dfe6af6949d495ac38b…
commit b1edd16e75dfe6af6949d495ac38b35ec029cc97
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Jan 4 16:09:19 2017 +0700
gitignore: ignore tests/oap/oap_test
Change-Id: Iccb8c46a721d5389058c5cf36621820bcd861b7b
http://cgit.osmocom.org/osmocom-bb/commit/?id=53e2672e1169883983cd3efba3ced…
commit 53e2672e1169883983cd3efba3ced2d644ad4ffa
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Jan 4 11:18:59 2017 +0100
lapd_test: avoid calling memcpy with NULL source
fixes
lapd/lapd_test.c:54:2: runtime error: null pointer passed as argument 2, which is declared to never be null
Change-Id: I7030729f4f4c867adecc7afc15bb5ca9beff0030
http://cgit.osmocom.org/osmocom-bb/commit/?id=6cfa56ba0c887d63c40efbab36954…
commit 6cfa56ba0c887d63c40efbab369541681f13fe21
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Jan 4 10:06:09 2017 +0100
gprs_cipher_core: Use typecase to avoid sanitizer error
This resolves
gprs_cipher_core.c:118:37: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
Change-Id: Ib1866595030ad9d11c886621ce69632462befa3a
http://cgit.osmocom.org/osmocom-bb/commit/?id=3faa0148054ae47924e20a3c3cae4…
commit 3faa0148054ae47924e20a3c3cae4cdf969ab695
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Dec 18 23:41:41 2016 +0100
fsm: term: get parent pointer as late as possible
During FSM instance termination, fetch the parent pointer every time just
before using it, in case the child termination or cleanup callback wish to
change anything about the parent, e.g. to prevent event dispatch.
This patch was created to try and fix a problem that was in the end solved
differently. There is no actual need or use case for this at the moment, but it
generally makes sense to get the parent pointer as late as possible.
Change-Id: I999d7f29ba10281d4005c5163130bb2d80148362
http://cgit.osmocom.org/osmocom-bb/commit/?id=15492bcb2653e0213caf0db6d44f0…
commit 15492bcb2653e0213caf0db6d44f09f4d05c9b4e
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Nov 10 17:10:42 2016 +0700
utils/conv_gen.py: separate code definitions
This change separates the convolutional code definitions from the code
generator logic, allowing us to make further changes in more specific
way. For example, adding some new codes, you change the conv_codes.py
only because such change isn't related to the generator.
Change-Id: I3428561251b7d7a180d1e9b6fcaad50bdbbc37fa
http://cgit.osmocom.org/osmocom-bb/commit/?id=6431adde78638db7dac0717f74de9…
commit 6431adde78638db7dac0717f74de92ef8b491d73
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Sat Oct 29 00:00:57 2016 +0700
utils/conv_gen.py: use shared tables if possible
This change introduces the memory usage optimization, mentioned
in d2d9760c08f35a231d32f0ebeb73b2927e5573b3. The aim is to make
code generator able to detect, whether the same tables are used
by several convolutional code definitions, and prevent one from
writing these tables multiple times.
For now, the detection process isn't fully automatic, so all
shared polynomials should be placed inside the 'shared_polys'
dictionary, for example:
shared_polys = {
"xcch" : [
( G0, 1 ),
( G1, 1 ),
],
"mcs" : [
( G4, 1 ),
( G7, 1 ),
( G5, 1 ),
],
}
Change-Id: I84760f5cdfdaece376b801d2e6cb2954ee875a3b
http://cgit.osmocom.org/osmocom-bb/commit/?id=c014f606d055bb0ab09b6b9128078…
commit c014f606d055bb0ab09b6b9128078cb7a4e06c4c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 23 04:26:39 2016 +0100
fsm: factor out osmo_fsm_inst_term_children() from osmo_fsm_inst_term()
osmo_fsm_inst_term() has code for safe child removal, publish that part as
osmo_fsm_inst_term_children(); also use from osmo_fsm_inst_term().
As with osmo_fsm_inst_term(), add osmo_fsm_inst_term_children() macro to pass
the caller's source file and line to new _osmo_fsm_inst_term_children().
Rationale: in openbsc's VLR, I want to discard child FSMs when certain events
are handled. I could keep a pointer to each one, or simply iterate all
children, making the code a lot simpler in some places.
(Unfortunately, the patch may be displayed subobtimally. This really only moves
the children-loop to a new function, replaces it with a call to
_osmo_fsm_inst_term_children(fi, OSMO_FSM_TERM_PARENT, NULL, file, line) and
drops two local iterator variables. No other code changes are made, even though
the diff may show large removal + addition chunks)
Change-Id: I8dac1206259cbd251660f793ad023aaa1dc705a2
http://cgit.osmocom.org/osmocom-bb/commit/?id=eeacf906dd961002dba7e53ec9144…
commit eeacf906dd961002dba7e53ec9144d08a2b2d0ee
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 23 01:00:13 2016 +0100
fsm: move LOGPFSMSRC and LOGPFSMLSRC to .h
LOGPFSM and LOGPFSML are in the header file, put the *SRC variants also there
so users of the osmo_fsm_inst API may conveniently create own functions that
log the caller's source file and line.
Very useful if many action functions call the same event dispatching function,
like foo_fsm_done(), and one needs to know which of the callers to debug.
Change-Id: I39447b1d15237b28f88d8c5f08d82c764679dc80
http://cgit.osmocom.org/osmocom-bb/commit/?id=c7155df3ecb0a4f583a7d0e0bedc8…
commit c7155df3ecb0a4f583a7d0e0bedc8cbb847a8fb4
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 23 04:24:51 2016 +0100
fsm: log calling file+line for error "event for NULL fi"
Change-Id: I1970773440865f1415004bcf0164603468acf90b
http://cgit.osmocom.org/osmocom-bb/commit/?id=b805cc19925b6815957ff47069688…
commit b805cc19925b6815957ff470696887bfd74f2639
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 23 04:23:18 2016 +0100
fsm: doc: add missing file, line args; fix ws + tweak on one line
Change-Id: I6af0d43ab0082e45df676c1d69b26310b59a8031
http://cgit.osmocom.org/osmocom-bb/commit/?id=cba8eb9b21afd26ce65ef5098f6a1…
commit cba8eb9b21afd26ce65ef5098f6a178bce800bb7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 23 04:32:09 2016 +0100
fsm_test.c: fix compiler warning: timer cb return type
Change-Id: Ifd7e85cd69b5e7e473000abc1ef7a56748aafc0e
http://cgit.osmocom.org/osmocom-bb/commit/?id=1514f34dcfed3a8c46678861c488f…
commit 1514f34dcfed3a8c46678861c488f7dbde856957
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Dec 24 17:59:36 2016 +0100
serial.c: file descriptor '0' is a valid value
if stdin/stdout/stderr are all closed by our environment, it may very
well be that opening a serial port returns fd == 0.
Change-Id: Ifd9670260883a35da0629369e0d49e467d5b4d72
http://cgit.osmocom.org/osmocom-bb/commit/?id=d2510459a8b5f4ae0ee3740dd36ca…
commit d2510459a8b5f4ae0ee3740dd36ca1c4abd290b6
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Dec 24 17:58:13 2016 +0100
serial.c: Fix fd leak in case of fcntl() error paths
Change-Id: I14f934957e1086b803f3a7b9b5e6d602380f0be2
Fixes: Coverity CID 158987
http://cgit.osmocom.org/osmocom-bb/commit/?id=c68ce3b9fe1314f8133eed1e7246f…
commit c68ce3b9fe1314f8133eed1e7246fdfee9295744
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 23 22:59:27 2016 +0100
serial.c: Some ports don't support TIOCMBIS for RTS/CTS control
So let's ignore the error we might get from this opreration.
Change-Id: I69dad90403355b6512c3bf4c7fd10dd1dd985f01
http://cgit.osmocom.org/osmocom-bb/commit/?id=1db37820aaa0e83cfc7f26270f5bb…
commit 1db37820aaa0e83cfc7f26270f5bb3a6d9a27189
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 23 22:49:39 2016 +0100
serial: Open devie in non-blocking mode and then switch to blocking
There are some serial ports that apparently block during the open in
some circumstances. We don't want that. We want to either open it
immediately, or fail fast.
Change-Id: I626b138574bc50f4f4b09c4d609f3623ff512dff
http://cgit.osmocom.org/osmocom-bb/commit/?id=a0f74f218bd5c805d1c190af54d80…
commit a0f74f218bd5c805d1c190af54d80ed781241148
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 23 22:16:08 2016 +0100
add CRC16-CCITT to libosmocore
Use the implementation from Linux lib/crc-ccitt.c (GPLv2)
Change-Id: I26bb54038f5ab36bbb34da7f5fb8ae6c0c0386a4
http://cgit.osmocom.org/osmocom-bb/commit/?id=5e5954db8b2f340a10877ebabc895…
commit 5e5954db8b2f340a10877ebabc895f27ad319231
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Dec 22 14:57:13 2016 +0100
Fix erroneously AGPL licensed file in libosmocore.
libosmocore itself is GPLv2-or-later. Only the test cases are permitted
to be AGPL licensed.
Change-Id: I62f2eed6305bfa11a64c6d633e08aabeaf9f0b10
http://cgit.osmocom.org/osmocom-bb/commit/?id=126def710563e1d4b5f16f354176a…
commit 126def710563e1d4b5f16f354176a2088d17e28c
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Dec 21 11:35:13 2016 +0100
Integrate Debian packaging changes
debian/control:
* restructure to make it easier to incorporate further changes
* update package descriptions
* move build-depends to a proper place
* update project URL
debian/rules:
* use proper hardening syntax
* strip linker option without explicit shell invocation
* remove useless comment
* add extra cleanup
debian/: package documentation separately
debian/docs: remove empty file
debian/coryright: update to match Debian format
Change-Id: Ia7654d34730e9f269831612bfba70a1338ce29d3
Related: OS#1694
http://cgit.osmocom.org/osmocom-bb/commit/?id=7309e19358240100e56f2d6af8af6…
commit 7309e19358240100e56f2d6af8af61a5bb5630da
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Dec 18 23:45:36 2016 +0100
fsm: log tweak: upon free, say 'Freeing instance'
Logging 'Release' is a bit ambiguous. At first I tought a subscriber
connection was being released, IMHO 'Freeing instance' better describes that
we are freeing an osmo_fsm_inst.
Change-Id: I5cf99707d2ba5620b2988f777fa39cc806ec0212
http://cgit.osmocom.org/osmocom-bb/commit/?id=b6d58e8cc0cbf4654efe986eb706f…
commit b6d58e8cc0cbf4654efe986eb706f8d3a91a6c76
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Dec 21 14:35:46 2016 +0100
doc: fix typo for osmo_hexparse
Change-Id: Ifc2b499792fda378c807c678b8e06630cb64d273
http://cgit.osmocom.org/osmocom-bb/commit/?id=18080960e1f85bb315d927d18e526…
commit 18080960e1f85bb315d927d18e52656973834813
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 16 13:43:54 2016 +0100
utils.h: add OSMO_STRINGIFY and OSMO_VALUE_STRING macros
OSMO_STRINGIFY particularly allows putting port numbers from a #define into VTY
doc strings, like:
#define FOO_PORT 2342
DEFUN(...,
"Foo UDP port (default: " OSMO_STRINGIFY(FOO_PORT) ")\n")
OSMO_VALUE_STRING creates value_string items with the string being exactly the
enum value's name. Replaces a similar macro def in fsm.c
Change-Id: I857af45ae602bb9a647ba26cf8b0d1b23403b54c
http://cgit.osmocom.org/osmocom-bb/commit/?id=4e72ee0d0f678ec91dee5ad33e879…
commit 4e72ee0d0f678ec91dee5ad33e8796b56e8c078d
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Dec 13 18:41:17 2016 +0100
Catch-up with git version tags
* update debian/changelog
* update TODO-RELEASE
* add comments to Makefile.am and TODO-RELEASE to simplify the process
in future
* add link to libtool docs to Makefile.am to simplify LIBVERSION
maintenance
Related: OS#1861
Change-Id: I22c257e357f597519120232d742d6a61289db021
http://cgit.osmocom.org/osmocom-bb/commit/?id=06ac9b40ed600cd36e1c0a158eb8f…
commit 06ac9b40ed600cd36e1c0a158eb8f2ca01b1941f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Dec 20 12:05:19 2016 +0100
fsm: term: safer iteration to remove all child FSMs
When terminating child FSMs, restart iteration after every child, to make
sure that we don't terminate a child twice. Terminating one child may emit
events that in turn terminates other children.
I created this patch because at first it looked like the cause of a bug,
which turned out not to be the case. So I have no actual use case of this
situation, but it does generally make sense to me, so submitting this.
Change-Id: I00990b47e42eeb43707a9a42abcd9df52fe5f483
http://cgit.osmocom.org/osmocom-bb/commit/?id=42b59c1bf080a5ae785f576ba749a…
commit 42b59c1bf080a5ae785f576ba749afdf3bde598d
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Dec 20 12:06:05 2016 +0100
fsm api doc: fix typo in doxygen marker '\breif'
Change-Id: I5c57e35b29d50cb409becada6b9b120ce5210ae0
http://cgit.osmocom.org/osmocom-bb/commit/?id=2ae5f186929a720b5604e2bd19ef5…
commit 2ae5f186929a720b5604e2bd19ef54606b37fb87
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Dec 15 02:26:03 2016 +0100
fsm: explicitly log removal from parent fsm
Since removing an FSM from its parent twice causes a segfault, it is very
interesting to see when that is attempted.
Removing could be made more robust, but logging is interesting for
investigating why an FSM is being removed twice in the first place (currently
the case in openbsc's vlr_lu_fsm).
Change-Id: Idec6b7aa5344f1e903c9d2aa2a3640cab0d70fb0
http://cgit.osmocom.org/osmocom-bb/commit/?id=5c5c78aacd4cd15e1147c2e5dbb4d…
commit 5c5c78aacd4cd15e1147c2e5dbb4dc9fca4da7e5
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Dec 14 18:35:47 2016 +0100
add value strings for enum osmo_fsm_term_cause and use for logging
Change-Id: Iaf63d3cadb0d46bf454e3314ebb439240cafd834
http://cgit.osmocom.org/osmocom-bb/commit/?id=a3953e0536a07b571fe3314d6e257…
commit a3953e0536a07b571fe3314d6e257db79b2dbe64
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Dec 14 18:34:30 2016 +0100
typo in comment for osmo_fsm_log_addr()
Change-Id: I6f683ed0c864a87bf1232994eb2deaf9b313a244
http://cgit.osmocom.org/osmocom-bb/commit/?id=725698a4f15b9403620951961984b…
commit 725698a4f15b9403620951961984b68ed4148992
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Dec 14 17:24:54 2016 +0100
fsm: log caller's source for events and state changes, not fsm.c lines
When looking at log output, it is not interesting to see that a state
transition's petty details are implemented in fsm.c. Rather log the *caller's*
source file and line that caused an event, state change and cascading events.
To that end, introduce LOGPSRC() absorbing the guts of LOGP(), to be able to
explicitly pass the source file and line information.
Prepend an underscore to the function names of osmo_fsm_inst_state_chg(),
osmo_fsm_inst_dispatch() and osmo_fsm_inst_term(), and add file and line
arguments to them. Provide the previous names as macros that insert the
caller's __BASE_FILE__ and __LINE__ constants for the new arguments. Hence no
calling code needs to be changed.
In fsm.c, add LOGPFSMSRC to call LOGPSRC, and add LOGPFSMLSRC, and use them in
above _osmo_fsm_inst_* functions.
In addition, in _osmo_fsm_inst_term(), pass the caller's source file and line
on to nested event dispatches, so showing where a cascade originated from.
Change-Id: Iae72aba7bbf99e19dd584ccabea5867210650dcd
http://cgit.osmocom.org/osmocom-bb/commit/?id=6a13e7f563e3983c51363704bd2a6…
commit 6a13e7f563e3983c51363704bd2a65e691bafc3e
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Dec 14 17:37:34 2016 +0100
fsm: add LOGPFSML to pass explicit logging level
Provide one central LOGPFSML to print FSM information, take the FSM logging
subsystem from the FSM instance but use an explicitly provided log level
instead of the FSM's default level.
Use to replace some, essentially, duplications of the LOGPFSM macro.
In effect, the fsm_test's expected error changes, since the previous code dup
for logging events used round braces to indicate the fi's state, while the
central macro uses curly braces.
Change-Id: If295fdabb3f31a0fd9490d1e0df57794c75ae547
http://cgit.osmocom.org/osmocom-bb/commit/?id=886d6fdec605e47ec19a3e37dd959…
commit 886d6fdec605e47ec19a3e37dd9596c525178a54
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 13:49:03 2016 +0100
fix logging: log_set_category_filter() for internal DL* logging cats
In log_set_category_filter(), passing a negative index lead to memory
corruption. Particularly dangerous since the internal logging categories have
negative values.
Fix: apply map_subsys() to interpret negative values as internal logging
categories.
As a side effect, out-of-bounds logging categories will be mapped to DLGLOBAL
instead of being dropped.
Fix the expectations in logging_test to match the fixed bug.
While at it also guard against a NULL logging target.
Change-Id: Ib0725b22bc39498c6b3970a61eb3339cf56d19f1
http://cgit.osmocom.org/osmocom-bb/commit/?id=a4842afc83334f97653e6cca6220b…
commit a4842afc83334f97653e6cca6220b19f53696509
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 14:11:31 2016 +0100
show bug in logging: log_set_category_filter on DL* categories
Add a check to logging_test.c to show a bug: passing an internal DL* category
constant to log_set_category_filter() results in a negative array index and
undefined behavior. A sanitize build should catch this.
The bug is confirmed by the fact that logging_test.err stays the same
(hopefully) although a logging output should appear from this patch. The test
could as well segfault or anything else, it's a bit of a gamble.
This bug will be fixed along with the expectation in a subsequent patch.
Change-Id: Ie2da77c642a84cafc0f528985930697ec167183b
http://cgit.osmocom.org/osmocom-bb/commit/?id=748022694c57ce7b9412469b8190c…
commit 748022694c57ce7b9412469b8190c7d232818a69
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 16:00:24 2016 +0100
fix logging: out-of-bounds check should end with user categories
To check category bounds, rather use num_cat_user, to redirect all semantically
unknown categories to DLGLOBAL.
Adjust logging_test expectations accordingly: "(d)" is now also shown.
Note: subsys is and needs to be signed, while num_cat* are unsigned. Thus for a
negative subsys, 'subsys >= num_cat_user' practically always yields true. Pay
close attention to signedness and check upper bound only for positive values.
Change-Id: I4a952b759f30d90fbfb81fedcfc56a8092ea18c1
http://cgit.osmocom.org/osmocom-bb/commit/?id=d1a145e5e782d07140422b85da9f5…
commit d1a145e5e782d07140422b85da9f55dd4b35a206
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 15:53:51 2016 +0100
show bug in logging: out-of-bounds check should end with user categories
In the background osmo_log_info array, the user's logging categories are
enhanced by the library internal ones. So far logging category range checking
only checked for the larger array bounds, although passing a logging category
>= num_cat_user is already semantically unknown and should redirect to
DLGLOBAL.
Add a check to logging_test.c to show that this isn't happening. Instead of
DLGLOBAL, a logging category that happens to be at that index is queried.
The bug is confirmed by logging_test.err only showing "(e)" and not "(d)":
"(e)" is shown because the first category after the user ones happens to be
DLGLOBAL. "(d)" is omitted since it hits a category that's not on debug level.
This bug will be fixed along with the expectation in a subsequent patch.
Change-Id: I397278714018ee9a0ae5101515f31ddddf79c2ec
http://cgit.osmocom.org/osmocom-bb/commit/?id=ca13574ba4eeb2c9e3ad865a570e6…
commit ca13574ba4eeb2c9e3ad865a570e6b5d3f05a3b6
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 14:18:54 2016 +0100
fix logging: also catch first out-of-bounds logging cat
In map_subsys(), fix the '>' condition to '>=' for array bounds checking.
Also make the bounds checking more strict: after both invocations of
subsys_lib2index(), re-check validity of the array index. If the final index is
still wrong, which should never happen, exit by assertion.
Change-Id: I7ca1a1d47724e40350f1c4dfebe90bad01c965f9
http://cgit.osmocom.org/osmocom-bb/commit/?id=a280b82f8ea9ef5fc1aa6e2357d27…
commit a280b82f8ea9ef5fc1aa6e2357d27d9d91219173
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 14:42:56 2016 +0100
show bug in logging: erratic redirection to DLGLOBAL for first invalid category
Add a check to logging_test.c to show a bug: when a logging category value that
is the first out-of-bounds value is passed to the logging system, the internal
map_subsys() fails to redirect to DLGLOBAL due to a flawed conditional. This
results in a too large array index and undefined behavior. A sanitize build
should catch this.
The bug is confirmed by the fact that logging_test.err stays the same
(hopefully) although a logging output should appear from this patch. The test
could as well segfault or anything else, it's a bit of a gamble.
This bug will be fixed along with the expectation in a subsequent patch.
Change-Id: I12bf38b6c1f85e2d7bf5a15f942dfe0beed41eba
http://cgit.osmocom.org/osmocom-bb/commit/?id=42240de04ce95e458b7b05cfa8357…
commit 42240de04ce95e458b7b05cfa8357dae40e90b35
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 15:13:56 2016 +0100
fix logging: redirection to DLGLOBAL for invalid categories
For out-of-bounds logging categories, redirect to the proper DLGLOBAL array
index instead of returning -1.
Adjust test expectation which shows that the bugs tested for are fixed.
Note: there are separate bounds checking problems, left for another patch.
Change-Id: I6ea9a59e005a22e0305454291714fdb9531c346b
http://cgit.osmocom.org/osmocom-bb/commit/?id=85b42c46184118db2aaa50e44e979…
commit 85b42c46184118db2aaa50e44e97966523dd0269
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 14:34:41 2016 +0100
show bug in logging: erratic redirection to DLGLOBAL for invalid categories
Add a check to logging_test.c to show a bug: when a logging category value that
is out-of-bounds is passed to the logging system, the internal map_subsys()
function should remap that to DLGLOBAL. But in fact DLGLOBAL is -1 and the
function fails to map this to a proper positive array index, directly returning
-1 instead. This results in a negative array index and undefined behavior. A
sanitize build should catch this.
The bug is confirmed by the fact that logging_test.err stays the same
(hopefully) although a logging output should appear from this patch. The test
could as well segfault or anything else, it's a bit of a gamble.
This bug will be fixed along with the expectation in a subsequent patch.
Note: osmo_log_info->num_cat + 0 is also out-of-bounds, but there is a separate
bug there, so leaving this for another patch.
Change-Id: I161b6550fa204a872bad1abefee1a6155393fafd
http://cgit.osmocom.org/osmocom-bb/commit/?id=9adf32fb60206065026e9c3ef7088…
commit 9adf32fb60206065026e9c3ef7088ef6bcc013be
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 12 14:22:59 2016 +0100
logging test: cosmetic: print target and don't print color
Prepares for upcoming modifications of the logging test to show and fix bugs in
the logging system.
Change-Id: I9461b987adf85d87469a6af55de5f1aa478f6ebb
http://cgit.osmocom.org/osmocom-bb/commit/?id=3cc757df1822114bf446dc2d5f6a9…
commit 3cc757df1822114bf446dc2d5f6a95da92321a25
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Dec 8 17:47:25 2016 +0100
doc: osmocom-authn-protocol.txt: fix numbering, mark unused sync msgs
Change-Id: Ic1ec5d00de406f9581377ef4b5547782a80f368a
http://cgit.osmocom.org/osmocom-bb/commit/?id=d981efa97603594080d90956eb9e0…
commit d981efa97603594080d90956eb9e08bce8f4c371
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Dec 8 17:50:03 2016 +0100
oap: add encode/decode unit test
Change-Id: I0e14099e2fc18e333a73d38bda059d53a8ca9944
http://cgit.osmocom.org/osmocom-bb/commit/?id=dd97950d26f0d5642bf4522219c1f…
commit dd97950d26f0d5642bf4522219c1f7e475de6454
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Dec 8 17:48:24 2016 +0100
gsm/oap: more robust: decode presence as clearly either 1 or 0
Prepares for the unit test, which can now simply check for encode/decode
identity.
Change-Id: I410ff120d868e8d55df9cb19ba6eefd99749cdf0
http://cgit.osmocom.org/osmocom-bb/commit/?id=c0f00072929b126b21ba7bdfa2c93…
commit c0f00072929b126b21ba7bdfa2c93327ba652d08
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Apr 27 18:32:35 2016 +0200
import oap message parsing / encoding from openbsc.git; AGPL->GPL
In the process, also:
* Change the license from AGPLv3 to GPLv2-or-later;
* correct spelling of 'sysmocom' to lowercase;
* add '2016' to the copyright;
* rename to osmo_*;
* add API docs;
* add logging category DLOAP: define id and add to internal_cat;
* redirect all oap.c logging to DLOAP.
A unit test will follow in a subsequent patch, since it needs a minor tweak for
decoding of boolean values.
The related openbsc change-id is I2f06aaa6eb54eafa860cfed8e72e41d82ff1c4cf.
Tweaked-by: Neels Hofmeyr
Change-Id: If5099e60681a215e798b6675f21813f26769c253
http://cgit.osmocom.org/osmocom-bb/commit/?id=9795cf1b126d5567dbd0a25b56e9b…
commit 9795cf1b126d5567dbd0a25b56e9ba75be9513c1
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sat Dec 10 17:01:06 2016 +0100
fix: DLGSUP logging category "unusable"
All DL* categories are typically negative, but DLGSUP isn't, and it's also not
in libosmocore's internal_cat array.
See: 3b6fb0880c3ab1e23a3d7d738d073b00c2a794c2
This means that a program using DLGSUP has to include DLGSUP in its own logging
cat array (typically not needed for DL* categories), which means for osmo-nitb
that DLGSUP (11) replaces DMGCP (also 11), and DMGCP becomes unusable.
Fix this: make DLGSUP -11 and include in internal_cat.
In gsup_test.c, no longer add DLGSUP to the logging categories array.
External follow-ups are otherwise needed only in osmo-hlr.git and some pending
patches for openbsc (Id3938267fa062e1a997d3704cd678874306f86ee).
Change-Id: Id974c7be158e4d60421a98110f5c807aefd31119
http://cgit.osmocom.org/osmocom-bb/commit/?id=fd9ec3bc7dee3037754005c9e44df…
commit fd9ec3bc7dee3037754005c9e44dfce7246a6659
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Dec 11 01:48:26 2016 +0100
Fix VTY: add missing doc for 'log gsmtap [HOSTNAME]'
Add missing doc string for the HOSTNAME arg.
Added in commit aa00f99be2e4cc64ede20d8c9548b83054696581, this breaks the VTY
tests for openbsc and hence breaks our jenkins build jobs.
Change-Id: I734b22c950242541322e902887bf779c14ba10fd
http://cgit.osmocom.org/osmocom-bb/commit/?id=aa00f99be2e4cc64ede20d8c9548b…
commit aa00f99be2e4cc64ede20d8c9548b83054696581
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 2 15:30:02 2016 +0100
Implement GSMTAP log target
This target wraps the to-be-logged string (With metadata) into a GSMTAP
packet and sends it to the configured destination address.
Change-Id: I9a7e72b8c9c6f6f2d76d1ea2332dcdee12394625
http://cgit.osmocom.org/osmocom-bb/commit/?id=a65e99331a9699a09d2661b595c17…
commit a65e99331a9699a09d2661b595c1723eea51873f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 2 13:54:36 2016 +0100
gsmtap: Add defintions for GSMTAP based remote logging
Often it is useful to have log statements from the osmocom programs
synchronized with protocol traces. So rather than having to open the
pcap file with GSMTAP or other protocol data side-by-side with the
textual log of one or more network elements, we simply pass the log
lines around as GSMTAP messages, which can then be displayed in-order
and interspersed with the protocol messages inside wireshark.
Change-Id: I33ab530e10ef0311b6f80b731e61894f20b4b3e7
http://cgit.osmocom.org/osmocom-bb/commit/?id=a24be85dc41885ee77072af9f079c…
commit a24be85dc41885ee77072af9f079c69c575061e9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 9 17:58:17 2016 +0100
Fix msgb_test on 64 bit architectures
truncating the unsigned long pointer msg->data to 'int' and then passin
git into msgb_resize_area() is unsafe as depending on the 32rd address
bit it will be eiether negative or positive. That will in turn change
the expected "Sub area is not fully contained in the msg data\n" error
message into "Negative sizes are not allowed\n" which is not what the
autotest case expects.
Change-Id: I87ce13c265704d4ba8724e7dc7ed874c1128e0fa
http://cgit.osmocom.org/osmocom-bb/commit/?id=665d48bf15602e8666b292dbe6688…
commit 665d48bf15602e8666b292dbe66881786af2ea95
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Nov 14 14:17:14 2016 +0100
cosmetic: gsup comments: write 'Generic' for the G in GSUP
The G used to mean GPRS, but the scope is larger now. To satisfy the curious
reader, give the G a name in gsup files' header comments. BTW, logging.h and
gsup_test.c already mentioned "Generic" before this.
Change-Id: I6ac5cf94c215e156ceff6a58da3d9e520ca942d9
http://cgit.osmocom.org/osmocom-bb/commit/?id=5f460dee3d9c0dca3221d80ca5a97…
commit 5f460dee3d9c0dca3221d80ca5a9701521e647c7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Dec 8 16:23:05 2016 +0100
license: gsup: libosmogsm requires GPL, not AGPL; say 'sysmocom'
The copyright in gsup.h differed from the one in gsup.c: gsup.c names the GNU
Affero GPL, gsup.h only the GNU GPL. Change both to GPL-v2-or-later.
In gsup.c/h's copyright notice, 'sysmocom' should be spelled lower case.
Change-Id: Ia5748c275501889b9086aef7d20ccb5c9edb8031
http://cgit.osmocom.org/osmocom-bb/commit/?id=dda5e7991c5dd55845a176848c6dc…
commit dda5e7991c5dd55845a176848c6dc98bc37cfe6c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 9 16:10:34 2016 +0100
doc: fsm timer_cb: explain return value
Change-Id: Ic6fbe95737862ed8b8de78058989c8b2ae330006
http://cgit.osmocom.org/osmocom-bb/commit/?id=0898a007bac173f0a61564914d54d…
commit 0898a007bac173f0a61564914d54d0496a851235
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 16 14:36:29 2016 +0100
contrib: add fsm-to-dot.py to draw osmo_fsm dotty graphs
Add a first version of a python script that tries to analyze .c source files to
draw graphs of osmo_fsm implementations. So far it uses quick-and-dirty
regexes.
Change-Id: I155f57a608d600f59aedfd27ef66eb9772c124e7
http://cgit.osmocom.org/osmocom-bb/commit/?id=c7f52c4c84d6a8898048738c4db92…
commit c7f52c4c84d6a8898048738c4db9266289c40b45
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Nov 12 21:25:21 2016 +0100
wqueue: Reject messges if queue is considered full
The write queue was always meant to not queue more than the
max_length messages but the implementation never rejected a
message.
Begin to log and enforce the queue size limit, add a testcase
to verify the code and initialize except_cb as part of a fix
for that new test case.
Real applications might now run into the queue limit and drop
messages where they just queued them before. It is unfortunate
but I still think it is good to implement the routine as it was
intended. We need to review osmo_wqueue_enqueue once more to
see that no msgb is leaked.
Change-Id: I1e6aef30f3e73d4bcf2967bc49f0783aa65395ae
http://cgit.osmocom.org/osmocom-bb/commit/?id=d7c0a373ff38b28a14fd7ee1cc6be…
commit d7c0a373ff38b28a14fd7ee1cc6be3cfbddbd850
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 2 13:52:59 2016 +0100
logging: Extend log_target with call-back for un-formatted log line
Some targets might not want to receive only an opaque, pre-formatted
string, but rather the unformatted arguments with metadata like
sub-system/level/file/line. We solve this by introducing a
log_target->output_raw() function pointer. If a target specifies this
function, it takes precedence over the regular log_target->output()
function.
Change-Id: I9dc9205d70dce9581458e7e9dc2d8a92991897bd
http://cgit.osmocom.org/osmocom-bb/commit/?id=909cbecbb9d3223b3b37284956460…
commit 909cbecbb9d3223b3b372849564600bb9be7fbda
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Dec 2 02:30:51 2016 +0100
Revert "gsm0408: add chreq_type for CHREQ_T_PDCH_ONE_PHASE and CHREQ_T_PDCH_TWO_PHASE"
This reverts commit c3c28528de78fd5d50c3a141c2176c0da5dd7075.
The reason is that this breaks a static assert in openbsc.
See https://lists.osmocom.org/pipermail/openbsc/2016-December/009906.html
Enlarging the ctype_by_chreq struct and breaks the static assert for
gsm_network->ctype_by_chreq's size:
../../../src/libbsc/gsm_04_08_utils.c:138:1: error: size of array ‘dummyassert_size’ is negative
osmo_static_assert(sizeof(ctype_by_chreq) ==
^
What this patch lacks is, in openbsc.git:
* adjustment of ctype_by_chreq[] according to the new additions in
libbsc/gsm_04_08_utils.c
* same for reason_by_chreq[], also in libbsc/gsm_04_08_utils.c
* enlarge ctype_by_chreq[] in gsm_network to 18, in openbsc/gsm_data.h.
Leaving it up to the original authors to follow up and commit a complete patch
series in one go.
http://cgit.osmocom.org/osmocom-bb/commit/?id=bc1d758299a1c9ac3f5902f6417cd…
commit bc1d758299a1c9ac3f5902f6417cdbcc1d5c1db4
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sat Nov 26 15:21:15 2016 +0100
gsm0480: add gsm0480_create_ussd_notify() and *_release_complete()
Add two functions to create USSD messages. Moves and generalizes code from
openbsc. Pending: use the new functions in openbsc.
It looks like _release_complete() should also set trans_id and direction flag;
but since this is moving code from openbsc that is apparently working, just
place a fixme comment and don't change the functionality.
Change-Id: Ia80e32c7105359915bfad3cc5621a1c09caf20f0
http://cgit.osmocom.org/osmocom-bb/commit/?id=25774b9839a9842affc6fef925166…
commit 25774b9839a9842affc6fef925166b3b9481b466
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sat Nov 26 15:21:05 2016 +0100
gsm0480: code dup: introduce and use gsm0480_l3hdr_push()
Add function gsm0480_l3hdr_push() to push a struct gsm48_hdr to the start of a
msgb. Use in gsm0480.c and gsm0411_utils.c. Further callers of the new function
will follow in openbsc as well as another libosmocore patch for ussd.
Change-Id: I54fce6053ab8362015686fe22dbcd38bf1366700
http://cgit.osmocom.org/osmocom-bb/commit/?id=c3c28528de78fd5d50c3a141c2176…
commit c3c28528de78fd5d50c3a141c2176c0da5dd7075
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Tue Nov 29 12:42:05 2016 +0100
gsm0408: add chreq_type for CHREQ_T_PDCH_ONE_PHASE and CHREQ_T_PDCH_TWO_PHASE
For BSC-located pcu the BSC must understand the PDCH chan request.
Change-Id: Ice44dcaaf798f93af3652a96c567f8e16a6cf784
http://cgit.osmocom.org/osmocom-bb/commit/?id=ec9bd5262847f8e697c1c43e14ba4…
commit ec9bd5262847f8e697c1c43e14ba48030a44672b
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Mon Nov 28 23:22:14 2016 +0100
timer: only call the callback if not NULL
Fix a crash in osmo-sgsn.
Change-Id: I04d58d9580708cc0f6d0f4aa17d3e9f2c6235c8e
http://cgit.osmocom.org/osmocom-bb/commit/?id=edf6fe75b72c10190057c65bdff46…
commit edf6fe75b72c10190057c65bdff467e5585ea6d7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 26 10:06:07 2016 +0100
ctrl_cmd_parse: Make coverity FORWARD_NULL happy
The 'strtok_r' function requires passing a NULL as the first parameter
on subsequent calls in order to ensure the code picks up where it left
off on a previous call. However, Coverity doesn't quite realize this
and points out that if a NULL was passed in as the third argument it
would result in a possible NULL deref because the strtok_r function will
assign the third argument to the first in the call is NULL.
Change-Id: I7a9d08d0d4eae76a5207d285e32a25d1b384a57f
Fixes: Coverity CID 135186
http://cgit.osmocom.org/osmocom-bb/commit/?id=aeecc48c45e539e0e176dd13d8642…
commit aeecc48c45e539e0e176dd13d86423e37ffbcee0
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 26 10:41:40 2016 +0100
Introduce osmo_strlcpy() function so we can stop using strncpy()
I'm aware of the existing criticism on stlrcpy(), but I think it is
still better than what we have now: stnrcpy(), sometimes with Coverity
warnings and sometimes with a manual setting of the termination byte.
The implementation follows the linux kernel strlcpy() which is claimed
to be BSD compatible.
We could of course link against libbsd on Linux instead, but I think
it's reasonably small and simple to provide our own implementation.
Future versions of libosmocore could use some autoconf magic and
preprocessor macros to use the system-provided strlcpy() if it exists.
Change-Id: Ifdc99b0e3b8631f1e771e58acaf9efb00a9cd493
http://cgit.osmocom.org/osmocom-bb/commit/?id=1fa78567e4e1963a28711b9b47111…
commit 1fa78567e4e1963a28711b9b47111b840b50cfdb
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 26 10:14:53 2016 +0100
osmo_gsup_encode(): Make coverity happy by invariant checking
gsm48_encode_bcd_number() can theoretically return a length in excess of
the size of the bcd_buf, but only in case an overly-long IMSI is passed
into the function (which would be illegal in the first place).
Change-Id: If3dc68ee13ff784b487bbc686b777cec9057d537
Fixes: Coverity CID 135216
http://cgit.osmocom.org/osmocom-bb/commit/?id=9533631e531671e7029bbe7bc2e26…
commit 9533631e531671e7029bbe7bc2e264d9080f56c7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 26 09:54:40 2016 +0100
osmo-sim-test.c: Fix rmsg check
we wanted to check for !rmsg, but used to check for !msg, missing error
returns from read_record_nr().
Change-Id: I79b6a94b1aa947c8329317b0626865c3cd4159c1
Fixes: Coverity CID 57672
http://cgit.osmocom.org/osmocom-bb/commit/?id=4a1cb09a40aaba7f412d1384b2a1a…
commit 4a1cb09a40aaba7f412d1384b2a1a06934310359
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 26 00:11:53 2016 +0100
telnet_interface: Handle osmo_fd_register() eror return code
Change-Id: I5bc1c2cbb04e363d868355b5ed866b4840f16c61
Fixes: Coverity 57637
http://cgit.osmocom.org/osmocom-bb/commit/?id=0fc315dd9ed35ab9d32b60cbcd225…
commit 0fc315dd9ed35ab9d32b60cbcd225f413b6a601e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 26 10:18:24 2016 +0100
osmo_sock_init(): Fix memory leak in error path
We forgot to call freeaddrinfo() in an error path.
Change-Id: Iccbd3beef4c4a70dc443131b909c45e650d8c6a2
Fixes: Coverity CID 135217
http://cgit.osmocom.org/osmocom-bb/commit/?id=9d862c89989e5841a2242ed0cde0e…
commit 9d862c89989e5841a2242ed0cde0e6fa0f4a6d2e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 26 00:10:07 2016 +0100
Fix unchecked return valueof osmo_fd_register()
Change-Id: Ib040a7f94eb1bbec8270b66fd4c2aedef9d5346a
Fixes: Coverity CID 57636
http://cgit.osmocom.org/osmocom-bb/commit/?id=96831049d926a6faf291a8ce29433…
commit 96831049d926a6faf291a8ce29433e7718369b58
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Nov 15 17:31:14 2016 +0100
build: make check: disable sim_test when built with --disable-pcsc
Numerous issues caused sim_test to be attempted even though libosmosim was not
built:
In configure.ac, the ENABLE_PCSC variable lacked an AC_SUBST() to be exported.
Furthermore in configure.ac, no value 'yes'/'no' was assigned to the
ENABLE_PCSC variable, only to the enable_pcsc value.
In testsuite.at, encapsulating the sim_test in 'if ENABLE_PCSC' seems to have
no effect, regardless (not even when using a variable that should be defined
accurately).
So fix with these steps, similarly to how we do it in openbsc:
In AC_ARG_ENABLE, directly use 'ENABLE_PCSC' to assign 'yes'/'no'.
Export the same using AC_SUBST().
Add tests/atlocal.in to translate ENABLE_PCSC to enable_sim_test (also add
atlocal to AC_OUTPUT and distclean).
Use enable_sim_test in testuite.at, as seen in openbsc: use AT_CHECK() to
indicate skipping the test if enable_sim_test isn't 'yes'.
Change-Id: I9e8740c7d2dfbd272e22fee85972ef3fda7184a8
http://cgit.osmocom.org/osmocom-bb/commit/?id=6e363e7e31761f47d06d4074670d8…
commit 6e363e7e31761f47d06d4074670d85693d03c038
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Nov 16 16:58:52 2016 +0100
gsm_08_58.h: Add more Ericsson specific RSL IE Identifiers
Change-Id: Ib43948da956f23609b1b0995ecac0c796cc7c629
http://cgit.osmocom.org/osmocom-bb/commit/?id=00b15390079630588de6a8c6092a1…
commit 00b15390079630588de6a8c6092a1df690d723db
Author: Philipp <pmaier(a)sysmocom.de>
Date: Mon Nov 14 12:34:15 2016 +0100
RSL: Add defines for ericsson systinfo SI13
Ericsson uses non standard information element tags when setting
up the SI13 system information configuration. This applies to
RSL_SYSTEM_INFO_13, which is normally 0x28, instead Ericsson
uses RSL_ERIC_SYSTEM_INFO_13, which is set to 0x0C. Furthermore,
Ericsson adds a propritary field called BCCH-Mapping, which is
tagged as 0xf2 (RSL_IE_ERIC_BCCH_MAPPING)
This patch addes these two information element tags in
gsm_08_58.h
Change-Id: Idc27352e286b9b8bbcbf0b31bdb676c3d13487a9
http://cgit.osmocom.org/osmocom-bb/commit/?id=9b4d065ba5b75d564845d6aeef659…
commit 9b4d065ba5b75d564845d6aeef6596ce5768b2a3
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Nov 15 19:21:23 2016 +0100
Extend IPA error logging
Output more information in case of IPA protocol errors to make debugging
easier.
Change-Id: I7632d6e679e076bfbec9abc12da4a46cc27ccea1
Related: SYS#3028
http://cgit.osmocom.org/osmocom-bb/commit/?id=55363a9f621566d82fc30408a6c65…
commit 55363a9f621566d82fc30408a6c657d9e81f5789
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Tue Nov 15 10:05:51 2016 +0100
vty: Skip printing non-initialized log categories
Without this patch the vty command show logging vty will cause a segfault if
not all elements of the log_categories array are defined.
Ticket: OW#3053
Sponsored-by: On-Waves ehf
Change-Id: Ieeba649c3bde6c9376d8e32b00b92beb37c08ef2
http://cgit.osmocom.org/osmocom-bb/commit/?id=8593f1f57a5140a34cd4f7063c2e7…
commit 8593f1f57a5140a34cd4f7063c2e7fcb54e1837b
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Nov 11 19:26:51 2016 +0100
msgb: add msgb_push_u{8,16,32}() functions
Those work analoguous to msgb_put_*() but pre-pend the given value
into the msg headroom, rather than appending it to the end.
Change-Id: I7de63e9d04c2d2b678f1f20eef37f9be2c4f5ec2
http://cgit.osmocom.org/osmocom-bb/commit/?id=6176b6e0924f2bd7d212472bcba9d…
commit 6176b6e0924f2bd7d212472bcba9dddf8ac32f51
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Nov 11 15:10:33 2016 +0100
bssgp_rx_paging(): Fix parsing of P-TMSI IE in Paging message
This was actually discovered by the following compiler warning in
gcc-6.2.0:
CC gprs_bssgp_bss.lo
gprs_bssgp_bss.c: In function ‘bssgp_rx_paging’:
gprs_bssgp_bss.c:544:2: warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
if (TLVP_PRESENT(&tp, BSSGP_IE_TMSI) &&
^~
gprs_bssgp_bss.c:548:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
*(pinfo->ptmsi) = ntohl(*(uint32_t *)
^
This is an actual bug. If we recevied a BSSGP Paging Request without
P-TMSI, we might crash or report some random memory as P-TMSI to the
caller in the output data structure.
Change-Id: Ib4f307827cd7cccc91c1415a6fb5428d7cf8416d
http://cgit.osmocom.org/osmocom-bb/commit/?id=c4193d30e82307b87a7a7bce3ea5e…
commit c4193d30e82307b87a7a7bce3ea5ed48f2f2f716
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Nov 11 15:21:52 2016 +0100
gan: Mark gan_pdisc_vals[] as public / non-static symbol
It is actually listed in libosmogsm.map, but still used to be a static
symbol. That couldn't have worked.
Change-Id: I6f3f04b683d906674ee7da9bab5762bb00cea916
http://cgit.osmocom.org/osmocom-bb/commit/?id=684cf322434e9cadd03773c2d120b…
commit 684cf322434e9cadd03773c2d120b9e29a1a1d48
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Nov 11 15:07:35 2016 +0100
bssgp_vty: Remove dead code and compiler warning
gprs_bssgp_vty.c:48:34: warning: ‘gprs_bssgp_timer_strs’ defined but not used [-Wunused-const-variable=]
static const struct value_string gprs_bssgp_timer_strs[] = {
^~~~~~~~~~~~~~~~~~~~~
Change-Id: Ia41ccb7b227c41996cdef51dc6779bfc5b5a8d48
http://cgit.osmocom.org/osmocom-bb/commit/?id=1554f80f5e271ed2ffb918127a234…
commit 1554f80f5e271ed2ffb918127a234a3804cedef4
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Nov 11 15:06:06 2016 +0100
statsd: Fix compiler warning (int32_t vs. int64_t)
Fixes the following compiler warning:
stats_statsd.c: In function ‘osmo_stats_reporter_create_statsd’: stats_statsd.c:54:18: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
srep->send_item = osmo_stats_reporter_statsd_send_item;
Change-Id: Id36914906e0982f6ac092a311210727de66b343a
http://cgit.osmocom.org/osmocom-bb/commit/?id=bf173a3df5dce2c875f057bcfbffc…
commit bf173a3df5dce2c875f057bcfbffcf4b8c642fe5
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Oct 29 21:36:02 2016 +0200
bitcomp: Remove the t4 decoding from libosmocore
As outlined by mail on the 13th of July the tree based approach to
decoding in the PCU is faster by order of magnitude. Instead of having a
slow implementation in the library and a quick one in the PCU, let's
only have a quick one in the PCU and at some point in the future move it
to libosmocore.
Execute the plan and remove t4_decode.
Change-Id: I021424444625a097560d086c217c81eac4a5ee44
http://cgit.osmocom.org/osmocom-bb/commit/?id=3de97e192688b75a24077bb707203…
commit 3de97e192688b75a24077bb7072030f4a4dc5ef3
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Nov 2 10:37:58 2016 +0100
Add logging and testing for FSM deallocation
osmo_fsm_inst_alloc() logs allocation but osmo_fsm_inst_free() is
silent. Fix this by adding log message for deallocation to make FSM
lifecycle tracking easier. Also make sure it's covered by test suite.
Change-Id: I7e5b55a1fff8e36cf61c7fb61d3e79c1f00e29d2
http://cgit.osmocom.org/osmocom-bb/commit/?id=e9e5f8e4e9aa3fdce06d144381d96…
commit e9e5f8e4e9aa3fdce06d144381d9621552476387
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Nov 7 14:49:13 2016 +0100
Add null-pointer check to osmo_amr_rtp_dec()
Check that RTP payload we're about to decode is not NULL and return
proper error code instead of segfaulting. Add corresponding test case.
Change-Id: Ib6cda9900a41ed16bbfbde9df3de9d38e0a7469b
http://cgit.osmocom.org/osmocom-bb/commit/?id=8b25a3f5c38a9297f9213cb6e70b7…
commit 8b25a3f5c38a9297f9213cb6e70b7599ba999fbe
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Nov 1 11:02:17 2016 +0100
Add osmo_fsm_unregister() to header
Previously function was defined but not exposed so there were a way to
register FSM but no way to unregister it.
Change-Id: I2e749d896009784b77d6d5952fcc38e1c131db2b
http://cgit.osmocom.org/osmocom-bb/commit/?id=f9c2c56c7d05dfdb076840a6c091d…
commit f9c2c56c7d05dfdb076840a6c091d6341db725d4
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Tue Nov 1 22:19:28 2016 +0700
utils/conv_gen.py: explicitly import reduce()
This change finally makes the script able to be executed
in Python 3 environment. Due to new Python 3 restrictions,
the reduce() should be imported explicitly.
Change-Id: Icbc81c29f1a226aeed2c1245a5d60809fe124005
http://cgit.osmocom.org/osmocom-bb/commit/?id=45ebc523c6b4825ab780a528fc87a…
commit 45ebc523c6b4825ab780a528fc87ab5c70bf867f
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Oct 27 02:19:37 2016 +0700
utils/conv_gen.py: don't mix print and write()
This is mostly a code style change, but it also
increases the compatibility with Python 3.
Change-Id: I5c8271d973f766aeb9cbcab30c4eddfdab54fcbb
http://cgit.osmocom.org/osmocom-bb/commit/?id=61281f4c4780ede1545e9e8499278…
commit 61281f4c4780ede1545e9e8499278789433d3d30
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Nov 1 10:49:31 2016 +0100
Fix typo in osmo_fsm_log_addr()
Previously function parameter was ignored, fsm_log_addr was always set
to false.
Change-Id: I74f06eab2dfa81dbb95e01f0b4b26448fd1b98f8
http://cgit.osmocom.org/osmocom-bb/commit/?id=72e43f02c3408ec85c259ee483ac7…
commit 72e43f02c3408ec85c259ee483ac75f01ecb6cad
Author: Philipp <pmaier(a)sysmocom.de>
Date: Thu Oct 27 13:35:20 2016 +0200
gsm0408: Completing GSM 04.08 RR message types
- Add missing message types to be up to date with the
latest specification release (3GPP TS 04.18)
- Add value strings to translate RR message type identifiers
into human readable strings. (see gsm48_rr_msg_name() in
gsm48.h
Change-Id: I3ceb070bf4dc8f5a071a5d43c6aa2d4e84c2dec6
http://cgit.osmocom.org/osmocom-bb/commit/?id=ada0042c587395ba1a8430504d761…
commit ada0042c587395ba1a8430504d761d532610ba5c
Author: Philipp <pmaier(a)sysmocom.de>
Date: Thu Oct 27 13:30:16 2016 +0200
COSMETIC: moving rr_cause_name() in gsm48.c
rr_cause_name() is located a far of from
value_string rr_cause_names[] while other value string
functions are located right below their related value
string definitions. This commit moves rr_cause_name()
below rr_cause_names[] as it should be
Change-Id: Ie6c03a6ea02c370d8733db5ba2a709610cd70ce7
http://cgit.osmocom.org/osmocom-bb/commit/?id=a6b5216ab4b7acfaa2b0b9d421fc7…
commit a6b5216ab4b7acfaa2b0b9d421fc72f6153fad59
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 8 22:06:07 2016 +0700
utils/conv_gen.py: add EDGE MCS 1-9 definitions
Change-Id: Ie1452342f524a8b60f2babc07398a1d9c9e06aa3
http://cgit.osmocom.org/osmocom-bb/commit/?id=84fc2ce210d57f2d59d2a5c1599d4…
commit 84fc2ce210d57f2d59d2a5c1599d45746c8ffeff
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Thu Sep 8 20:30:36 2016 +0700
utils/conv_gen.py: fix some typos
Change-Id: I3327b92715744af4ef61496ef0121555d9d24799
http://cgit.osmocom.org/osmocom-bb/commit/?id=f3d38c493722b4d3cb6bd5dbd9a30…
commit f3d38c493722b4d3cb6bd5dbd9a30d5681a7cdf2
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Sep 7 23:09:49 2016 +0700
utils/conv_gen.py: add RACH, SCH and TCH/AHS definitions
Change-Id: I0ea7151f4e8119a8798a9e129b951559e56b0d93
http://cgit.osmocom.org/osmocom-bb/commit/?id=c7a01d554e3ad3af205e70a29685c…
commit c7a01d554e3ad3af205e70a29685c3d32333bfdd
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Sep 7 23:03:05 2016 +0700
gsm/gsm0503.h: fix typo
Change-Id: I263d61111544eeb7227e1e0e8f2d14479eae2079
http://cgit.osmocom.org/osmocom-bb/commit/?id=6908fa783d85ef4391755757bf485…
commit 6908fa783d85ef4391755757bf4856a2d5ba860c
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Sep 7 22:34:53 2016 +0700
utils/conv_gen.py: improve output formatting
To keep the generated tables readable, line with should be limited.
So, now there are the following limitations:
- _print_term(): up to 12 numbers per line,
- _print_puncture(): up to 12 numbers per line,
- _print_x(): up to 4 blocks per line.
Change-Id: I95256c4ad402a3c088bdb6c5a5cda8b17c31881c
http://cgit.osmocom.org/osmocom-bb/commit/?id=d2d9760c08f35a231d32f0ebeb73b…
commit d2d9760c08f35a231d32f0ebeb73b2927e5573b3
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Sep 7 22:18:10 2016 +0700
utils/conv_gen.py: generate a single file
Instead of generating every convolutional code into a separate
file (such as conv_xcch_gen.c, conv_cs3_gen.c), it is better to
have a single file, containing all definitions, because as many
convolutional codes we add, as many entries we will have to add
into 'src/gsm/Makefile.am'. This approach increases readability
of the Makefile.am, and also makes us able to share some data
between some convolutional code definitions.
For example: xCCH, RACH, SCH, TCH/F, both CS2 and CS3 may use
the same *_state[][2] and *_output[][2] arrays within a single
file. This optimization is currently WIP.
Change-Id: Ib4e4ee5fdde38429e68e3b2fa50ec03a18f59daa
http://cgit.osmocom.org/osmocom-bb/commit/?id=694f72d148882987cc8e4ffd0c414…
commit 694f72d148882987cc8e4ffd0c4143d8099e09bf
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Oct 20 13:46:23 2016 +0200
Revert "Constify ctrl_cmd struct fields where appropriate"
This reverts commit ed9d6da5df98538adc70aa03cb569eb9505d04b6.
The commit is good as such, but it causes many compiler warnings in the OpenBSC
build. We want this to be re-applied as soon as we have patches ready that fix
the fallout in openbsc.git.
See also https://lists.osmocom.org/pipermail/openbsc/2016-October/009802.html
Related: OS#1829
Change-Id: I722ad60232a6ef5b4cb984b92c42851de26b3ccd
http://cgit.osmocom.org/osmocom-bb/commit/?id=eb604cf44f2182904e9e104c5d226…
commit eb604cf44f2182904e9e104c5d226d7391e54102
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Fri Oct 14 13:54:47 2016 +0200
vty/show asciidoc: counters: improve table headers
add [options=header] to every table header
vty/show asciidoc: rename reference field into "Reference"
vty/show asciidoc: capilize table header field names
Change-Id: Ie991f4db77a60afb86a2a0b35c137586527f6228
http://cgit.osmocom.org/osmocom-bb/commit/?id=e052dc285d094df565b2de2974e76…
commit e052dc285d094df565b2de2974e76d522fe15195
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Tue Oct 4 18:04:37 2016 +0200
vty/show asciidoc: add user readable description of the version
Change-Id: Ie0f1b3894361c58386da9defb225979fa0ee6a18
http://cgit.osmocom.org/osmocom-bb/commit/?id=27a35ed47c6eb70665c6c484dee64…
commit 27a35ed47c6eb70665c6c484dee64fa06649de10
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Tue Oct 4 17:13:58 2016 +0200
stats_statsd: use int64_t instead of int for value and delta.
The stats infrastructure use int64_t for values and delta. So the
statsd reporter get call with int64_t.
Change-Id: I33df86de60007a64fa853d6d3af9b609877a8fc6
http://cgit.osmocom.org/osmocom-bb/commit/?id=3e432e1912c0e531c55e1c6c75c75…
commit 3e432e1912c0e531c55e1c6c75c758b0fde9887e
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Tue Oct 4 11:24:02 2016 +0200
vty/osmo_counter: use name if description is NULL
`show stats` shows (null) for osmocom_counters when
description is null.
OpenBSC> show stats
Ungrouped counters:
(null): 4
Change-Id: I553b88a6fca688924b1f2b49e8cb17e90f057bb1
http://cgit.osmocom.org/osmocom-bb/commit/?id=a23817622b28cb1969a73ffd36da5…
commit a23817622b28cb1969a73ffd36da501eb29b9cd7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Sep 30 01:25:45 2016 +0200
configure: add --enable-sanitize, use in jenkins.sh
--enable-sanitize adds address sanitizer CFLAGS/CPPFLAGS to the entire build.
Also pass UBSAN_OPTIONS to the test suite run (only has effect during runtime).
Add this flag to jenkins.sh's configure step. To ensure that we get the
sanitize results, add 'make check' to jenkins to catch sanitize failures;
Keep 'make distcheck' without ASAN; it has its own configure which omits
--enable-sanitize. This way we test both with and without ASAN.
Change-Id: Idf7f46fa048608c2951f2473cb528f6c8dc2681d
http://cgit.osmocom.org/osmocom-bb/commit/?id=2b3c228416263eee6e261c3c589f1…
commit 2b3c228416263eee6e261c3c589f1a18e54d9a27
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Oct 12 15:27:42 2016 +0200
gsm/Makefile.am: use proper top_builddir/top_srcdir paths
This fixes the conv*gen.c targets when building in a different directory
than the source tree.
Notably, building in a different dir worked when the generated sources were
already present from a previous build inside the source directory.
Change-Id: I5a9b780ad4ba607ea39854dcf7207ed05f5447bc
http://cgit.osmocom.org/osmocom-bb/commit/?id=bc067eb0a20a7feadb5dbb3b4169c…
commit bc067eb0a20a7feadb5dbb3b4169cb8f9286a455
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Aug 4 11:07:08 2016 +0200
Add function to send TRAP over Control Interface
Change-Id: Ic0b8d88c4f5c4d42c3f8fb754f8eabf049c9e388
Related: OS#1646
http://cgit.osmocom.org/osmocom-bb/commit/?id=530736f3153da2cc6774ad0d070b8…
commit 530736f3153da2cc6774ad0d070b8c6fbf432a98
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Oct 7 00:43:57 2016 +0200
jenkins.sh: drop unecessary PATH, now in slave config
Change-Id: Ifaff3e5e13c920eb716a5609bfec2f96e10f17b0
http://cgit.osmocom.org/osmocom-bb/commit/?id=349784c72d9eaff7d1dc8b9640f2d…
commit 349784c72d9eaff7d1dc8b9640f2d8e53b31b7e5
Author: Philipp <pmaier(a)sysmocom.de>
Date: Mon Oct 10 15:03:23 2016 +0200
gsm0408: Adding 3g spcific RR message types
GSM 04.18, which is the successor of GSM 04.08, describes
additional RR 3g specific message types. This commit adds
four new message types related to paging and notifiction
See also 3GPP TS 04.18, section 10.4, table 10.4.1
Change-Id: I071cc9ecac342b5221fa0ec0b782b04b51b40e93
http://cgit.osmocom.org/osmocom-bb/commit/?id=a95ee5e6e192d274d5d2c03fbe47e…
commit a95ee5e6e192d274d5d2c03fbe47edbc62c38beb
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Oct 10 22:46:20 2016 +0200
fix USSD: SS message type mask should be 0x3f, not 0xbf
See 04.80[1], section 3.4: the highest two bits are used as counter or ignored
and do not contribute to the SS "Miscellaneous message group". Previous mask of
0xbf included the highest bit, fix to 0x3f.
Observed a value of 0xbb that should mean 0x3b="Register" during testing of 3G
USSD requests, which seem to be the first to send a nonzero highest bit to our
code. The erratic mask of 0xbf lead to an unhandled message type of 0xbb.
[1] 3GPP TS 24.080 version 7.2.0 Release 7 / ETSI TS 124 080 V7.2.0 (2006-09)
Change-Id: I299001a9e36c16f55622a0acd5d4a55ca49d0055
http://cgit.osmocom.org/osmocom-bb/commit/?id=ed9d6da5df98538adc70aa03cb569…
commit ed9d6da5df98538adc70aa03cb569eb9505d04b6
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Oct 11 15:20:28 2016 +0200
Constify ctrl_cmd struct fields where appropriate
Change-Id: I3f55c1d4b965d215dc9b16f4b284b7fea4bde9e9
http://cgit.osmocom.org/osmocom-bb/commit/?id=cbdfa65dbed69fc19ba195d2aa8ea…
commit cbdfa65dbed69fc19ba195d2aa8ead76f1434c5c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Sep 30 23:45:28 2016 +0200
build: be robust against install-sh files above the root dir
Explicitly set AC_CONFIG_AUX_DIR.
To reproduce the error avoided by this patch:
rm install-sh # in case it was already generated.
touch ../install-sh # yes, outside this source tree
autoreconf -fi
This will produce an error like
...
configure.ac:16: error: required file '../ltmain.sh' not found
configure.ac:5: installing '../missing'
src/Makefile.am: installing '../depcomp'
autoreconf: automake failed with exit status: 1
See also automake (vim `which automake`) and look for 'sub locate_aux_dir'.
Change-Id: If2afbe62e9ceeac8052c7b882ff92a548f3af0bf
http://cgit.osmocom.org/osmocom-bb/commit/?id=2bb65be159dfdabf664fec569b343…
commit 2bb65be159dfdabf664fec569b343320301701b0
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Sep 28 15:38:55 2016 +0200
Mark inline header function as static
Change-Id: Ib751f7467d54cbcae76f72448a38e30f2ecc63d4
http://cgit.osmocom.org/osmocom-bb/commit/?id=56155c16b91428c4838df1d6010cd…
commit 56155c16b91428c4838df1d6010cdb7acdb540ce
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Sep 21 23:37:37 2016 +0200
jenkins.sh: output all test logs when 'make check' failed
Assume that cat-testlogs.sh from osmo-ci is installed in $HOME/osmo-ci/scripts,
and call from jenkins.sh upon 'make check' failure.
Change-Id: I18a08e7ade1a53783d5a4171fe825f61b49457be
http://cgit.osmocom.org/osmocom-bb/commit/?id=9c0751fc60e6282b5f5ff791d53f6…
commit 9c0751fc60e6282b5f5ff791d53f6f862f1c9c79
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 02:41:46 2016 +0200
osmo_select_main(): drop useless call to osmo_timers_check()
osmo_timers_check() does nothing more than counting the active timers. It is of
no use to count them when not using the return value in any way.
Change-Id: I8d35ca90a4c16d6f1c7f9793d663e5479783efed
http://cgit.osmocom.org/osmocom-bb/commit/?id=74a8f0831dbcbe40694d19dcf1731…
commit 74a8f0831dbcbe40694d19dcf173185593f91be2
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Sep 27 13:51:51 2016 +0200
AMR: add function to check speech frames
Add convenience function osmo_amr_is_speech() to check if given AMR
frame is speech frame: non-speech frames often require special
processing.
Change-Id: Ifaab02a2f581acc302b367d34fd2fc28a4d1e2e3
http://cgit.osmocom.org/osmocom-bb/commit/?id=8a3409c4b7fefe4333b619498f2ca…
commit 8a3409c4b7fefe4333b619498f2cad0c7c3ae81c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Sep 16 02:37:24 2016 +0200
gsm0408_test: initialize msgb talloc ctx
Change-Id: Ib26214add1932e93651c248cc09fbc68339b4dce
http://cgit.osmocom.org/osmocom-bb/commit/?id=f45334be29016a36594aacc07c90e…
commit f45334be29016a36594aacc07c90e262e4994525
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Sep 16 00:15:56 2016 +0200
msgb: add msgb_talloc_ctx_init(), deprecate msgb_set_talloc_ctx()
So far each and every main() scope creates a msgb talloc context and either
passes it to msgb_set_talloc_ctx() or sets tall_msgb_ctx directly (by defining
it extern first).
Remove some code duplication: add one central function that creates the "msgb"
talloc context for all.
Most users of msgb employ a talloc_named_const(), but osmo-bts uses a
talloc_pool() instead. Offer both ways by means of the pool_size argument, and
for both ways make sure the context is called "msgb".
Suggest that msgb users should move to this new function: deprecate
msgb_set_talloc_ctx(). To be able to do so, include core/defs.h in msgb.h.
There's a tradeoff between hiding the msgb talloc context behind API that tries
to guess all use cases versus avoiding code dup. This patch opts against code
dup and boldly assumes that all future use is covered.
Also, the new function suggests to not access tall_msgb_ctx directly, which can
be considered a style improvement.
It seems that not all main scopes that use msgb actually initialize the msgb
ctx. As a fallback for these, explicitly initialize tall_msgb_ctx to NULL.
Change-Id: I747fbbf977c4d2c868c8dead64cfc5fd86eb8d4c
http://cgit.osmocom.org/osmocom-bb/commit/?id=8319a6799ffc9d4c5e7e094b96af3…
commit 8319a6799ffc9d4c5e7e094b96af30cbebf89f65
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Sep 21 18:30:01 2016 +0200
bitrev_test: don't omit last byte from test result check
The osmo_hexdump of the output in sh_chk() omitted the last byte of the
returned bytes from the osmo_nibble_shift_*() functions.
Determine the number of bytes from nibbles divided by two plus one for any odd
nibble number. Output this number of bytes of output data.
Memset the output buffer to get well-defined bytes for unwritten places.
Also assert that we have enough buffer length for all nibbles.
Change-Id: I011f42bca555caec0dfe8688ff1f28303fa04fad
http://cgit.osmocom.org/osmocom-bb/commit/?id=4fd6023b0383e7efa3b7b0211104a…
commit 4fd6023b0383e7efa3b7b0211104a86ff5d3d4f6
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Sep 20 16:33:50 2016 +0200
Fix ASAN failure in bitrev_test
Previously while testing osmo_nibble_shift_left_unal() following error was
triggered by AddressSanitizer upon offs == 12 and the last sh_chk line, i.e.
shift left of 12 nibbles from in2:
==3890== ERROR: AddressSanitizer: stack-buffer-overflow on address 0xbff5b5b6 at pc 0xb6186862 bp 0xbff5b4a8 sp 0xbff5b49c
READ of size 1 at 0xbff5b5b6 thread T0
#0 0xb6186861 (/home/msuraev/source/gsm/libosmocore/src/.libs/libosmocore.so.7.0.0+0xc861)
#1 0x8049d8b (/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x8049d8b)
#2 0x804a9d1 (/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x804a9d1)
#3 0xb5fe3af2 (/lib/i386-linux-gnu/libc-2.19.so+0x19af2)
#4 0x8048a30 (/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x8048a30)
Address 0xbff5b5b6 is located at offset 38 in frame <main> of T0's stack:
This frame has 3 object(s):
[32, 38) 'in2'
[96, 104) 'out'
[160, 168) 'in1'
The reason is incorrect range in test cycle. Fix it and adjust test
output accordingly.
Tweaked-by: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Fixes: OW#1589 ("undefined behavior in libosmocore triggered by tests")
Change-Id: I5eb3f600290c05b4ab9ac2450a28d616e6b415fd
http://cgit.osmocom.org/osmocom-bb/commit/?id=e31cf8057f65ec0d8d141eb8f64d5…
commit e31cf8057f65ec0d8d141eb8f64d5c0e61204f6c
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Sep 7 21:51:25 2016 +0700
utils/conv_gen.py: code style changes (line width, tabs, etc.)
Change-Id: I8550910b9f5c16efc6f15f23c7ee52122c588752
http://cgit.osmocom.org/osmocom-bb/commit/?id=ba34a2fd73e9803d7e13e90c4fd7e…
commit ba34a2fd73e9803d7e13e90c4fd7e803ce5dedaa
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri Sep 2 15:44:12 2016 +0200
gprs: Increase NS_ALLOC_SIZE to 3k
2k can be insufficient when responding with a STATUS message to a long LLC
packet because the original message is included in the STATUS.
Change-Id: I6f76751cfadf61e87ce4367a38907083e1c98562
Ticket: SYS#2967
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=38d232ee5d2ceb045d9ad6d3a23af…
commit 38d232ee5d2ceb045d9ad6d3a23afcb4972523f7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 19 14:17:30 2016 +0200
log CTRL bind address and port
Log 'CTRL at 1.2.3.4 5678' from ctrl_interface_setup*. All callers can now drop
any extra 'CTRL at 1.2.3.4 5678' logging.
Change-Id: If449d0514e3d0cc1b346d7452194d931aa090166
http://cgit.osmocom.org/osmocom-bb/commit/?id=55dc2edc89c1a85187ef8aafc09f7…
commit 55dc2edc89c1a85187ef8aafc09f7d922383231f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 19 14:10:25 2016 +0200
log telnet bind address and port
Log 'telnet at 1.2.3.4 5678' from telnet_init*. All callers can now drop any
extra 'VTY at 1.2.3.4 5678' logging.
Change-Id: I1da7b9076311d9458caea732fc0daace6533a3fd
http://cgit.osmocom.org/osmocom-bb/commit/?id=dbc68177926c7f04d42b418ee6dc5…
commit dbc68177926c7f04d42b418ee6dc559571f4d7f8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 04:21:50 2016 +0200
timer_test: set 8 as default steps, use the default in testsuite.at
Change-Id: I5070578e9fe2bdacaad000eaafb8dc5f549d6f3e
http://cgit.osmocom.org/osmocom-bb/commit/?id=d0858c2ae9cdd065d09c3a58e6040…
commit d0858c2ae9cdd065d09c3a58e60409b7af50111e
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 04:50:13 2016 +0200
timer_test: print more details to stdout to check
The test is now fully deterministic, so include all detail in stdout, to check
for.
Change-Id: Iecf6387f1d25253fcf1260777673853030c1d326
http://cgit.osmocom.org/osmocom-bb/commit/?id=255dac16a4a69e29be62bcc692dab…
commit 255dac16a4a69e29be62bcc692dabf9cd1a586b5
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 04:48:32 2016 +0200
timer_test: redirect some output from stderr to stdout
This way we can check the output in timer_test.ok.
Change-Id: Ia3bba1c650be3558d370e0f59d4ee7f36ef97506
http://cgit.osmocom.org/osmocom-bb/commit/?id=d73c1cc7c25d5e38d848f40598b17…
commit d73c1cc7c25d5e38d848f40598b17d84e77b6a5b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 05:20:53 2016 +0200
timer_test: remove all random elements
Change-Id: I9833031407e99f5d7a1144c26b68a7e320b2020d
http://cgit.osmocom.org/osmocom-bb/commit/?id=7b4d727ec5debc3d057686a0a3f0f…
commit 7b4d727ec5debc3d057686a0a3f0f5f14260a282
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 04:47:04 2016 +0200
timer_test: do not use real time: deterministic and faster
Use osmo_gettimeofday_override* to decouple the timer test from real time. No
longer call osmo_select_main(), since select() actually waits for real time.
This reduces the timer_test to the osmo_timer_* logic and excludes the real
time and osmo_timers_nearest() accuracy testing with actual waiting involved.
This may be seen as a loss, but is more fit for a test suite.
The main point here is to get deterministic results in jenkins, so that we
don't have to retrigger jobs based on timing failures; added bonus is that the
test runs much faster now.
Change-Id: Ic5649512df86dd17070daa2f314159eafaf8feb8
http://cgit.osmocom.org/osmocom-bb/commit/?id=8e2f7e87f4d854e697c40545326a1…
commit 8e2f7e87f4d854e697c40545326a16e50614dd5c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 03:58:13 2016 +0200
add osmo_gettimeofday as a shim around gettimeofday
This allows feeding a custom time for unit tests by overriding
osmo_gettimeofday.
Change-Id: Ic7a81a6eb51f27fe452962b91f2eae2070d87089
http://cgit.osmocom.org/osmocom-bb/commit/?id=13a8fb84f0d83f23e65daa528f2f3…
commit 13a8fb84f0d83f23e65daa528f2f392ec3b83a75
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 04:45:26 2016 +0200
timer_test: remove unused precision values and confusing log
Change-Id: I1570b7096c757d63d23e0950feeeb7230f8a5c9f
http://cgit.osmocom.org/osmocom-bb/commit/?id=9c9a04705ff431c1e10bf40f2e964…
commit 9c9a04705ff431c1e10bf40f2e964a43360441ac
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 04:23:34 2016 +0200
timer_test: also report early finishes, report timing on error
When a timer was late, show the timing details.
Also count whether timers fired early, for completeness' sake.
Change-Id: Id3942637d77a28b5092ffffcc3e6d9d67c2b8e68
http://cgit.osmocom.org/osmocom-bb/commit/?id=633a0e76a2fbb31ce6dd4dadb3531…
commit 633a0e76a2fbb31ce6dd4dadb35313aed3aa385c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 04:24:38 2016 +0200
fix timer_test: don't forget to set tv_usec on the stop time
The timer_test schedules timers and records the desired stop time. Also store
the usec value of the desired stop time, because scheduling at e.g. sec N usec
999999 but recording sec N usec 0, and then receiving a timer at sec N+1 usec 0
is only 1 usec late, but records as 1000000 usecs late. This might have been
the main cause of the timer test not working well on the osmocom build server.
Change-Id: I13bb60f7d341a397f95d13d9c63c40188b6cd5a0
http://cgit.osmocom.org/osmocom-bb/commit/?id=5b34f773e441b984d3bc98468fd01…
commit 5b34f773e441b984d3bc98468fd015eeb4131890
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 19 14:15:03 2016 +0200
remove unused local variable in get_rate_ctr()
Unused after 22886d9e320ecf734d2827d825a191b977f70d2c
"Fix retrieving rate_ctr over control interface"
Change-Id: Ib5411da80c4eb4f905a5ed87c60477eca2cdff42
http://cgit.osmocom.org/osmocom-bb/commit/?id=2e38d358b6cd450ecf51928f7ae19…
commit 2e38d358b6cd450ecf51928f7ae19e56fc6cbb97
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 19 14:10:59 2016 +0200
remove unused function get_rate_ctr_group()
Unused after 22886d9e320ecf734d2827d825a191b977f70d2c
"Fix retrieving rate_ctr over control interface"
Change-Id: I405367ef6ba5833957778a79dd398ce5ea29307e
http://cgit.osmocom.org/osmocom-bb/commit/?id=d95f01d204eeec5eaa8f300029cb8…
commit d95f01d204eeec5eaa8f300029cb8f9e92caeee1
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Sep 9 16:42:49 2016 +0200
build: tests: don't link system installed libosmogsm.
Add src/gsm/libosmogsm.la explicitly to some test linkages, because otherwise
the linker would pick the libosmogsm already installed on the system instead of
the one that was just built in the source tree.
I noticed because a libosmogsm needing some more symbols from libosmocodec was
still installed, while the patch that cause it was already removed. Thus I
caught all(?) test binaries that linked libosmogsm from $PREFIX.
Change-Id: Ie61d60e1506f16de20add70fd0f44ebfa7a00a75
http://cgit.osmocom.org/osmocom-bb/commit/?id=1a587bd782fe75f0739ed188abc23…
commit 1a587bd782fe75f0739ed188abc23604e32d4148
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 8 12:59:08 2016 +0200
fix GGSN Ctrl port to 4257
4253 used to collide with the sysmobts-mgr VTY port.
Note, openggsn does not actually have a Ctrl interface yet.
Change-Id: If0fa0e606dabd5bc89907a56ef18cdbbbdedb4b7
http://cgit.osmocom.org/osmocom-bb/commit/?id=56313c84c8e68541374ca744d8b7a…
commit 56313c84c8e68541374ca744d8b7a6eb470ecbde
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 8 12:58:25 2016 +0200
comment: */ports.h: link to wiki + manuals, indicate used ports
Change-Id: I6a7bf04e589ccfaea98f20900a9bfe9dd4808dce
http://cgit.osmocom.org/osmocom-bb/commit/?id=c69de3e25cb0fe651293e64a68ba3…
commit c69de3e25cb0fe651293e64a68ba35e936c50ff3
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Aug 12 16:18:56 2016 +0200
Add Marker to ph_tch_param
Extend struct ph_tch_param with Marker bit from RTP header to indicate
speech onset in case of DTX.
Change-Id: Ic664902630b9d335ff9abc7a9ca7249eaf80e05f
Related: OS#1750
http://cgit.osmocom.org/osmocom-bb/commit/?id=6320934e6a740c824f99769700937…
commit 6320934e6a740c824f99769700937ed0477c67b3
Author: Anatoly Orlov <anatolix(a)yandex.ru>
Date: Wed Aug 31 08:07:16 2016 +0200
libosmocodec link fix on MacOSX
Fixes the following bug:
CCLD libosmocodec.la
Undefined symbols for architecture x86_64:
"_bitvec_get_bit_pos", referenced from:
_osmo_fr_check_sid in gsm610.o
"_bitvec_get_uint", referenced from:
_osmo_hr_check_sid in gsm620.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libosmocodec.la] Error 1
Change-Id: Id7358b94e274b529a8da38a0b2ef8c892b6dd7a5
http://cgit.osmocom.org/osmocom-bb/commit/?id=418ca58085d81f7c5fd7a62554939…
commit 418ca58085d81f7c5fd7a625549399b3c03ee8e3
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Sep 9 02:03:43 2016 +0200
fix error msg: msgb_put(): say "msgb_put", not "msgb_push"
Change-Id: I72f31ebad693f98eb088a99b83aeb10cf9acc29e
http://cgit.osmocom.org/osmocom-bb/commit/?id=e65315fb373602082b9289020ccc1…
commit e65315fb373602082b9289020ccc17f0c4b79935
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Mon Aug 22 21:42:57 2016 +0200
core/counter: add osmo_counter_dec()
Change-Id: I030140a45afa295c3ebc4d3ccaffd437b984f515
http://cgit.osmocom.org/osmocom-bb/commit/?id=0318f6b6cae7a3f2d786a1caee519…
commit 0318f6b6cae7a3f2d786a1caee519241d81d6745
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Aug 29 13:18:56 2016 +0200
IuPS: add GMM Service Request related constants and value_str
Change-Id: Ie023fc78099932f95cc8f1b3a04fe25dfd14bc35
http://cgit.osmocom.org/osmocom-bb/commit/?id=b7f191febb639d917b5f4290c73cb…
commit b7f191febb639d917b5f4290c73cb1620d9cb2f4
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Aug 29 11:22:03 2016 +0200
fix printf format for commit 'osmo_sock_init(): include host and port in error messages'
Related: CID#143566
Change-Id: I75c542089749a0875d3d1913151fe838d7722ff2
http://cgit.osmocom.org/osmocom-bb/commit/?id=f0f07d9c9b3227b5233352418d658…
commit f0f07d9c9b3227b5233352418d658aba3584310b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Aug 22 13:34:23 2016 +0200
osmo_sock_init(): include host and port in error messages
For programs like osmo-hnbgw with numerous sockets, the message that some
unspecified connection was refused is not very helpful. Also output the host
and port where an error occured.
Instead of perror, use fprintf(stderr, ..., strerror()) to be able to include a
format string and print host and port as passed to osmo_sock_init().
Change-Id: I8d0343f51310699b78fcb83fd76fd93764acf3dc
http://cgit.osmocom.org/osmocom-bb/commit/?id=898e1d878e47298f97289e50f9b0c…
commit 898e1d878e47298f97289e50f9b0cca7ecdf2ed7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sat Aug 20 16:33:47 2016 +0200
vty: use VTY_BIND_ADDR_DEFAULT instead of "127.0.0.1"
Change-Id: Ice0688ac9847524cb546f6d41547090b6a3cb3d8
http://cgit.osmocom.org/osmocom-bb/commit/?id=fef2fa224a754df3f9792d1ddcd3a…
commit fef2fa224a754df3f9792d1ddcd3a6d9a73658b1
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Aug 8 15:38:35 2016 +0200
configure: check for pkg-config presence
On a fresh installation, I was puzzled by a configure.ac 'syntax error' for
PKG_CHECK_MODULES(TALLOC). It took me some time to figure out that merely
pkg-config was missing.
Add a check for pkg-config, which isn't as straightforward as I would wish,
so comment generously.
Change-Id: I2e7cdc37eb59f9947a45fbc5baddbaf71b655bc0
http://cgit.osmocom.org/osmocom-bb/commit/?id=d1dcda01f8c99e02a206c95d177ae…
commit d1dcda01f8c99e02a206c95d177aecd3dfb66e09
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Aug 2 17:18:51 2016 +0200
Add control interface port for GGSN
Change-Id: Ie7232189fe3265a8631fd3652b2c8c152cdee918
Related: OS#1646
http://cgit.osmocom.org/osmocom-bb/commit/?id=1a70223fa3fce4ad21fcb987f422b…
commit 1a70223fa3fce4ad21fcb987f422bcc040450cee
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Aug 8 13:10:52 2016 +0200
Add .mailmap file for mapping mail addresses in shortlog
Change-Id: Id6b42bb9ab10f46b76b26057c8228e5da480286d
http://cgit.osmocom.org/osmocom-bb/commit/?id=9a9739c6ab56f0ad202bf24e82a07…
commit 9a9739c6ab56f0ad202bf24e82a0702072c608f6
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jul 21 14:24:37 2016 +0200
Extend L1SAP with Measurements
We already have RSSI parameter in PH-DATA. Add other measurement
information (BER, BTO, Link Quality).
Change-Id: I2b127eb1856c4cd1bc46490a89592a595f1ee86b
Related: OS#1616
http://cgit.osmocom.org/osmocom-bb/commit/?id=460f9ef7da1db11b104fdfe635ebc…
commit 460f9ef7da1db11b104fdfe635ebcbd8a071f205
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Aug 1 00:38:36 2016 +0200
fsm: Make sure we call 'onenter' of new state, not old state
Change-Id: I1a0181c25d9debe935e86d97ddffc24675e56a5f
http://cgit.osmocom.org/osmocom-bb/commit/?id=f92e44c5399d8914aad58bd2c7400…
commit f92e44c5399d8914aad58bd2c74005b3640c5a9d
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Aug 1 00:24:19 2016 +0200
lapd_core: Fix crash in lapd_dl_flush_hist()
When lapd_dl_flush_hist() was called before we actually had started a
transmit history from lapd_dl_init(), we woul segfault before this
patch.
Change-Id: Ifa677c9b335dd2884b4f3e44699d901957a0500b
http://cgit.osmocom.org/osmocom-bb/commit/?id=881dcaf7aa262e3c14c104e49e65c…
commit 881dcaf7aa262e3c14c104e49e65cd2ee3bf93c3
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Jul 28 08:02:48 2016 +0200
Mark input string to osmo_talloc_replace_string() as const
This allows us to pass in strings that are 'const', which for the
source of a copy should be the normal/regular case anyway.
Change-Id: Icee6a5f88babd3a4e30bf0886f0f8d3b865d80ce
http://cgit.osmocom.org/osmocom-bb/commit/?id=9a5bbf36b543ff89c0ed148428d97…
commit 9a5bbf36b543ff89c0ed148428d97300880c5804
Author: Tom Tsou <tom.tsou(a)ettus.com>
Date: Thu Jul 14 15:13:45 2016 -0700
egprs: Add CPS tables from TS 04.60
Includes EGPRS coding and puncturing scheme (CPS) tables from 3GPP
TS 04.60. Currently osmo-bts-trx is the only user of CPS table
values, but this may change with gprsdecode and other utilities.
Change-Id: I09fe6514a0e2e51bb3206f8387633f7e0255345f
http://cgit.osmocom.org/osmocom-bb/commit/?id=1a96946875f807b84fbb255e8b4f8…
commit 1a96946875f807b84fbb255e8b4f8f4a31b9cecc
Author: bhargava <Bhargava.Abhyankar(a)radisys.com>
Date: Thu Jul 14 13:15:09 2016 +0530
Update structure in libosmocore for 11 bit RACH
Parameters are added to the structure ph_rach_ind_param to
differentiate the type of RACH received from Layer 1. This is to
further support the 11 bit RACH.
Change-Id: Ic4f0f2424a3af7599d986044be25ea4fcc0ca477
http://cgit.osmocom.org/osmocom-bb/commit/?id=da34bf01a340850b114e7136502c5…
commit da34bf01a340850b114e7136502c55e79bec68e1
Author: Max <msuraev(a)sysmocom.de>
Date: Sun Jul 17 16:37:56 2016 +0200
Add define for invalid TA
Add GSM48_TA_INVALID which is invalid Timing Advance value according to
3GPP TS 44.018 § 10.5.2.40.
Change-Id: I061760ccac656f39164562a7883f8ab522cd0911
Related: OS#1526
http://cgit.osmocom.org/osmocom-bb/commit/?id=47390764ddeb98109e39aa379d433…
commit 47390764ddeb98109e39aa379d433ddc064e058b
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Jul 18 23:54:01 2016 +0200
rsl: add rsl_act_type_name()
Change-Id: Ie90c76d8aef42d5e2c9be94f4b206d4994e305f8
http://cgit.osmocom.org/osmocom-bb/commit/?id=fd80f5a04239c2ab7b561401476dd…
commit fd80f5a04239c2ab7b561401476dd89f2861748b
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Thu Jul 14 03:21:05 2016 +0200
dyn TS: add definitions for dynamic TCH/F_TCH/H_PDCH
Add:
* GSM_PCHAN_TCH_F_TCH_H_PDCH
* NM_CHANC_OSMO_TCHFull_TCHHalf_PDCH
* RSL_CHAN_OSMO_PDCH
* RSL_ACT_OSMO_PDCH
Related: OS#1776
Change-Id: Ib1a8b11f37af4686d00ac88beba38557aa29edc2
http://cgit.osmocom.org/osmocom-bb/commit/?id=15b96ff70ca0c13bc5cbe6c79d858…
commit 15b96ff70ca0c13bc5cbe6c79d85854fee1568b1
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Jul 18 23:33:48 2016 +0200
gsm_08_58.h: introduce RSL_CHAN_NR_1 constant
Using the RSL_CHAN_* constants, we sometimes need to add 1 to the chan bits
to indicate e.g. the second TCH/H channel.
RSL_CHAN_NR_1 marks this lowest channel bit that needs to be added.
The name is analogous to RSL_CHAN_NR_MASK.
Change-Id: Iea06432039d1cd23cc6b5acec308bb829b596d47
http://cgit.osmocom.org/osmocom-bb/commit/?id=505adee93bad5c12e7435d09a191d…
commit 505adee93bad5c12e7435d09a191d9d6221d09b3
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Jul 13 16:55:43 2016 +0200
fix compiler warning: gsup.c: missing braces
osmo_auth_vector's first member is an array, so for a zero initializer, we
should add a second set of array braces.
Change-Id: Iace448caca8152e46244f26c3af250f2035c99eb
http://cgit.osmocom.org/osmocom-bb/commit/?id=511b448fe3a8522d645499b7d0b93…
commit 511b448fe3a8522d645499b7d0b93b5acb1b3776
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Jul 13 12:26:10 2016 +0200
bitvec: Force inlining of bitvec_set_bit_pos/bitvec_set_bit
The PCU is using bitvec_write_field a lot but on the
arm-poky-linux-gnueabi-gcc v4.8.1 the calls to set_bit and
set_bit_pos are not inlined. The inlined variant has been
a more quick for the PCU compressed bitmap decompression
testcase.
Used objdump -d to look at the bitvec_write_field before and
after the change. The branch to bitvec_set_bit is gone and a
inlined version has been used.
Change-Id: I0b6b90610f4c17f02e4efa064c3bf1ac2dccb22a
http://cgit.osmocom.org/osmocom-bb/commit/?id=edb57e7709c130a664fb2d9f807d9…
commit edb57e7709c130a664fb2d9f807d96d0e283c675
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jul 14 11:35:17 2016 +0200
Add function to check TA validity
Check if given Timing Advance is valid according to 3GPP TS 44.018 §
10.5.2.40.
Change-Id: I5cb6149d6e36fda8cb3f557e4d6d3a724da805a5
Related: OS#1545
http://cgit.osmocom.org/osmocom-bb/commit/?id=4a62dbbfa9260cd0c079f043b57f9…
commit 4a62dbbfa9260cd0c079f043b57f9adaedfad38e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Jul 12 17:45:34 2016 +0200
ussd: Decode interrogateSS that doesn't have test
Keith of Rhizomatica has an issue of a unrejected interrogateSS.
Start with just decoding the message and printing the empty test
and the code.
What is kind of missing is the classification between invoke,
returnResult and returnResultLast that we need to add in the
long run.
Change-Id: Iadfa156707a96f2a34f3948c7cc9a74435f17114
http://cgit.osmocom.org/osmocom-bb/commit/?id=9394dbd8e0ea010e8ee7af7729a27…
commit 9394dbd8e0ea010e8ee7af7729a27d6a68ff8256
Author: Tom Tsou <tom.tsou(a)ettus.com>
Date: Thu Jul 7 17:06:12 2016 -0700
Add EGPRS RLC/MAC headers from 3GPP TS 04.60
For shared use by osmo-pcu and osmo-bts-trx.
Change-Id: I500cdc87cd30faf36c8cd92d234642f809c8f2aa
http://cgit.osmocom.org/osmocom-bb/commit/?id=4f169500df996d0a7a804da77bae0…
commit 4f169500df996d0a7a804da77bae07b2ecd0d813
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jun 30 10:39:00 2016 +0200
Add GEA3 & GEA4 ciphers
Corresponding test code include both official test vectors from the
specs and data from over-the-air tests.
This obsoletes libosmo-crypt-a53 as it was last missing piece
unimplemented in libosmogsm.
Change-Id: I939e4f6b91b4a7c591ef3761fe2d46ed1c2fb2d3
Related: OS#1582
http://cgit.osmocom.org/osmocom-bb/commit/?id=02a66728856d6a111ef61eca2cc05…
commit 02a66728856d6a111ef61eca2cc052df052579a9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jul 10 15:13:51 2016 +0200
fsm: delete the timer when changing state
In osmo_fsm_inst_state_chg(), we need to stop any not-yet-expired timer
of the old state before transitioning into the new state.
Change-Id: I2558f9a7027a877ea8263785ed3c8d70d2513996
http://cgit.osmocom.org/osmocom-bb/commit/?id=f3239113db910962a4ccac2f93d68…
commit f3239113db910962a4ccac2f93d689a86450264f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jul 10 15:11:45 2016 +0200
fsm: talloc + copy the 'id' passed into a FSM
The 'id' is used to generate the human-readable name of the FSM.
However, when the FSM creates slave FSMs later, the caller-passed "ID"
mgiht long be gone again (e.g. it was on stack memory). So let's copy
the 'id' string to a chunk of dynamically-allocated memory at time of
FSM start to ensure we have it later when creating child FSMs.
Change-Id: Ib88a2c02c5c91f17b4ec1e9db57a06d6d66465fb
http://cgit.osmocom.org/osmocom-bb/commit/?id=673018fed99aab80c3ac23c95f568…
commit 673018fed99aab80c3ac23c95f568ff0bf272f60
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jul 10 15:09:43 2016 +0200
fsm: call 'onenter' as last step of a state change
This is useful to allow the user to terinate the fsm from the onenter()
callback.
Change-Id: Ia45a1f3279e702028250e10dc54b2d46a4039905
http://cgit.osmocom.org/osmocom-bb/commit/?id=f5f773f0130e1f61b84636f7aeb6e…
commit f5f773f0130e1f61b84636f7aeb6e17f5140fd25
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Jul 5 19:17:19 2016 +0200
Add strings with GPRS GMM messages
Change-Id: I48477b733e2da72f59349c00554dd3e080c9f445
Related: OS#1582
http://cgit.osmocom.org/osmocom-bb/commit/?id=fdca25dfb881871ffb4142bd1bcd8…
commit fdca25dfb881871ffb4142bd1bcd808c71e6c4e3
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Jul 5 16:06:28 2016 +0200
Add function to check GMM encryptability
Check if particular GMM message can be encrypted according to 3GPP TS
24.008 § 4.7.1.2
Related: OS#1582
Change-Id: I7ad0e03c2c738d174dd6bc3453f332eeb8da1e7d
http://cgit.osmocom.org/osmocom-bb/commit/?id=ae3b78076e580b6060cde2e4612b8…
commit ae3b78076e580b6060cde2e4612b8bcf459de832
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Jul 6 15:35:19 2016 +0200
gitignore tests/fsm/fsm_test
was added in 136e73764e7f58e52ffb13d01304fef30eb7d291
Change-Id: I0f344cc459626f71316f99341f79b5f0479ad82c
http://cgit.osmocom.org/osmocom-bb/commit/?id=92ce39f3d1aaf1a38fc9be367503d…
commit 92ce39f3d1aaf1a38fc9be367503d82adfca4555
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jul 7 13:00:43 2016 +0200
Add missing osmo_c4 export
Change-Id: Iaf53b31b4fa3860301054e970907ada061360b28
Related: OS#1741
http://cgit.osmocom.org/osmocom-bb/commit/?id=0ee90f861458a68be7d7ac6e7f253…
commit 0ee90f861458a68be7d7ac6e7f253c2be03ae049
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jul 3 20:45:21 2016 +0200
lapd_dl_flush_hist(): Don't flush a non-existant history
If lapd_dl_flush_hist() is called after lapd_dl_exit(), dl->tx_hist has
already been free'd and set to NULL. Check for this before attempting
to de-reference a NULL pointer.
This bug breaks OpenBSC with any E1 based BTSs using DAHDI.
Change-Id: I117ba3445fa5e8097e21c11c5a6337de6ba46c7d
Related: OS#1760
http://cgit.osmocom.org/osmocom-bb/commit/?id=dda9dffca9bda905bc33d59959232…
commit dda9dffca9bda905bc33d5995923277e861a80c2
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Jun 28 17:05:35 2016 +0200
Clarify GPRS algorithm
Add spec reference and set explicit values for enum representing
ciphering algorithm for GPRS encryption.
Change-Id: Ia9ee429b73a37d52599fce70778cfe87b767411c
Related: OS#1582
http://cgit.osmocom.org/osmocom-bb/commit/?id=c57e5daf224476c20d34653fdb11d…
commit c57e5daf224476c20d34653fdb11d67ed7da9fed
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jun 27 16:19:12 2016 +0200
Clarify GPRS ciphering direction
Add spec reference and set explicit values for enum representing
direction parameter for GPRS encryption.
Change-Id: Iaf1b13da2e889d55cc9dd7516710104dba48c992
Related: OS#1582
http://cgit.osmocom.org/osmocom-bb/commit/?id=eb59f241ec571c3bdfcd8b3fa25d8…
commit eb59f241ec571c3bdfcd8b3fa25d8687a1191f39
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jun 27 15:44:16 2016 +0200
tests: test actual support status for auth. algo
Check if library actually support Milenage, COMP128 v2 and v3 algorithms
instead of just printing enum values or nothing.
Change-Id: I2b98481f56a8381058d4b29db5e8a36eb193eee9
http://cgit.osmocom.org/osmocom-bb/commit/?id=a337b9c37a9ff561b9c6a2e7c4b2a…
commit a337b9c37a9ff561b9c6a2e7c4b2a65dfa3b0e7f
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jun 27 15:51:34 2016 +0200
Add function to check MS GEA capabilities
Add function which parses MS network capability IE value for bits
indicating support for particular version of GEA.
Change-Id: I785cef37dd272a2fab9b172f6e1392f865174e9a
Relates: OS#1582
http://cgit.osmocom.org/osmocom-bb/commit/?id=ceae1237528f91f44e226225207ac…
commit ceae1237528f91f44e226225207ac70a2cf842ec
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Jun 27 18:12:49 2016 +0200
Make C4 function globally available
This function perform 64 -> 128 bit key expansion which useful for
converting between UMTS CK and GSM Kc, A5/3 and A5/4, GEA3 and GEA4
keys.
Change-Id: I5a6c6deef6027cd6af144c9062d4c9166be26904
Related: OS#1582
http://cgit.osmocom.org/osmocom-bb/commit/?id=b897c4299329688bb0aba6e32cd10…
commit b897c4299329688bb0aba6e32cd10b361bda1dee
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Jun 28 14:03:21 2016 +0200
Add strings for GPRS ciphers
Change-Id: I050bda5fb50aad42fe2d72de39f8256b4fb12fb2
Related: OS#1582
http://cgit.osmocom.org/osmocom-bb/commit/?id=6797b3a808cdc9f2998e500269630…
commit 6797b3a808cdc9f2998e500269630c822ce9c189
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Jun 28 16:17:12 2016 +0200
gitignore: *-libtool for differing platforms
Change-Id: Ia8c011b53d4256305e70f78372a4aa0019b1131b
http://cgit.osmocom.org/osmocom-bb/commit/?id=14bf28a43de485aa7697059937897…
commit 14bf28a43de485aa76970599378971d27b2a23a7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Jun 27 15:19:10 2016 +0200
Mark input parameter to bitvec_set_bits() as 'const'
The input data is accessed in a read-only manner, so it should be marked
with the const qualifier.
Change-Id: I0d6b86289fa647594f3da1f1c0e0168685307a37
http://cgit.osmocom.org/osmocom-bb/commit/?id=f627c0f0afb280d30aa00da395560…
commit f627c0f0afb280d30aa00da395560db963aba462
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jun 18 10:36:25 2016 +0200
fsm: Introduce default time-out handling
If a FSM doesn't specify any timer_cb, simply terminate the FSM by
default on time-out. This is a reasonable default for most cases, and
avoids copy+pasting a one-line timer_cb function in every FSM.
Also, even if there is a timer_cb, let it have a return value to decide
if the core should terminate after return from timer_cb or not.
Change-Id: I0461a9593bfb729c82b7d1d1cf9f30b1079d0212
http://cgit.osmocom.org/osmocom-bb/commit/?id=d826f1771cdada9009db599a9cf38…
commit d826f1771cdada9009db599a9cf3882192bf0454
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jun 23 13:14:02 2016 +0200
Fix potential segfault in msg_dequeue
Change-Id: I06e9c5ba3e00c73a4e52d2583ce3492f236275ce
http://cgit.osmocom.org/osmocom-bb/commit/?id=e0a7d9e2c220e5544ee8982c78851…
commit e0a7d9e2c220e5544ee8982c78851ff40ac425bc
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Jun 17 17:58:52 2016 +0200
Add octet-aligned/unaligned shift functions
The actual code is from OsmoBTS' tch.c by Harald Welte. Add unit tests,
doxygen annotation and extra memory safety check. Those functions are
used in several BTS implementations but seems generic enough to be
generally useful.
Change-Id: I2b1901c4161e8035f059585901dca593b661556d
http://cgit.osmocom.org/osmocom-bb/commit/?id=136e73764e7f58e52ffb13d01304f…
commit 136e73764e7f58e52ffb13d01304fef30eb7d291
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 29 10:53:17 2016 +0900
Add Finite State Machine abstraction code
This code is supposed to formalize some of the state machine handling in
Osmocom code.
Change-Id: I0b0965a912598c1f6b84042a99fea9d522642466
Reviewed-on: https://gerrit.osmocom.org/163
Tested-by: Jenkins Builder
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=82f94ef50f592c8c89b848e91b7cb…
commit 82f94ef50f592c8c89b848e91b7cb84587ef8733
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu May 5 23:33:27 2016 +0200
Add UMTS AKA related MM/GMM message type and IE definitions
Change-Id: Id45ea2c631ee589a4df1f8213da6f7e7d1bf6616
Reviewed-on: https://gerrit.osmocom.org/305
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=bda26c09019310dd25a2e7671f362…
commit bda26c09019310dd25a2e7671f362cf2c26a3aff
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed May 11 09:13:08 2016 +0200
Add structures defining decoded TS 23.003 identities
Change-Id: I6423f8d75bb3e7aeca285854ab3232a087d62b57
Reviewed-on: https://gerrit.osmocom.org/304
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=de960cbc0cc6c02139d2a9be95421…
commit de960cbc0cc6c02139d2a9be954219420cc81650
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Jun 16 22:57:09 2016 +0200
gsup: Add OSMO_GSUP_MSGT_AUTH_FAIL_REPORT
The VLR must be able to notify the HLR of authentication failures.
Change-Id: I156cff76e092b3548b05534141b61887ee6be3f3
Reviewed-on: https://gerrit.osmocom.org/303
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=db78d2172b1d2ecdcbdc54d601a64…
commit db78d2172b1d2ecdcbdc54d601a6477b101ebfbc
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Jun 6 13:47:07 2016 +0200
gsup.c: Fix encoding of UMTS auth vectors
Encoding auth vectors worked fine for GSM authentication, but didn't
yet include the new IEs for UMTS authentication yet.
Change-Id: I7fa5ba1c950292bd0a9874b3102a27f221ce390d
Reviewed-on: https://gerrit.osmocom.org/302
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=f624c33ef2e394949c10453b327e2…
commit f624c33ef2e394949c10453b327e248aa27680e2
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Jun 15 11:35:16 2016 +0200
vty: Fix documentation of 'show asciidoc counters' VTY command
VTY documentations strings follow a certain structure, and we need to
follow that to make the interactive help work.
Change-Id: I0bb0bda68dbbf9995338ec555ff99d73a223162c
Reviewed-on: https://gerrit.osmocom.org/276
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=22886d9e320ecf734d2827d825a19…
commit 22886d9e320ecf734d2827d825a191b977f70d2c
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Jun 14 18:17:06 2016 +0200
Fix retrieving rate_ctr over control interface
Allow getting either particular
counter (e. g. rate_ctr.per_hour.e1inp.0.hdlc.abort) or entire rate
counter group for a given index (e. g. rate_ctr.per_hour.e1inp.0).
Change-Id: I2b0109536170f7b5388d3236df30b98f457aa98d
Fixes: OS#1730
Reviewed-on: https://gerrit.osmocom.org/274
Tested-by: Jenkins Builder
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=ad580ba7c400835fdff0226700dd0…
commit ad580ba7c400835fdff0226700dd02c7ffff32c6
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Mon May 16 16:01:45 2016 +0200
add vty call show asciidoc: generate a documentation for counters
For each counter group a ascii doc table is generated
containing all single counter with a reference to a section to
add additional information to the counter
Change-Id: Ia8af883167e5ee631059299b107ea83c8bbffdfb
Reviewed-on: https://gerrit.osmocom.org/70
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=0167e3f35535b1b19eab659659180…
commit 0167e3f35535b1b19eab659659180fa549da52b0
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Jun 6 18:10:38 2016 +0200
add rsl_or_ipac_msg_name() for both standard and ip.access msg types
Context: in osmo-bts, I want to look up an RSL message name in rsl_msgt_names
and fall back to rsl_ipac_msgt_names if not found, because the IPAC PDCH ACT
and DEACT messages are sent in a standard ABIS_RSL_MDISC_DED_CHAN.
Change-Id: Ic9ba721a1469cf51aed97ab0f44a7fe055c94b1f
Reviewed-on: https://gerrit.osmocom.org/231
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=8d6dcd9bca7ce9b0a29954126c720…
commit 8d6dcd9bca7ce9b0a29954126c72050f8e2e110c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Jun 6 18:05:23 2016 +0200
add get_value_string_or_null() to handle unknown items
Add get_value_string_or_null() to return NULL in case the given value is not
found in the list of strings, to be able to cleanly fall back to another list
of strings. Absorb the lookup loop from get_value_string().
Context: in osmo-bts, I want to look up an RSL message name in rsl_msgt_names
and fall back to rsl_ipac_msgt_names if not found, because the IPAC PDCH ACT
and DEACT messages are sent in a standard ABIS_RSL_MDISC_DED_CHAN.
In a subsequent commit, get_value_string_or_null() will be used by new
rsl_or_ipac_msg_name().
Change-Id: I1fa3907e28d528d2758bc3eae9d19e6c1168f5e5
Reviewed-on: https://gerrit.osmocom.org/230
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=8a3c83ed00104bdb326c160a36c8f…
commit 8a3c83ed00104bdb326c160a36c8f2b0625eeabd
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Jun 13 13:16:58 2016 +0200
api doc: get_value_string(): mention composition in static buffer
Change-Id: I93dad98711ef69f8a1e196efa029a842a1ff5bd6
Reviewed-on: https://gerrit.osmocom.org/229
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=6cf8eba4ecb560b50faf94c99c2bd…
commit 6cf8eba4ecb560b50faf94c99c2bd6008b97c731
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Jun 6 18:17:20 2016 +0200
gitignore: add gsup_test, tlv_test
Change-Id: Ied1cbc7a48bdbc3696e9d8657285071c377d6de5
Reviewed-on: https://gerrit.osmocom.org/207
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=4f511b67fd83b5767071604920ebc…
commit 4f511b67fd83b5767071604920ebc3bac025b751
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed May 18 19:36:42 2016 +0200
osmo-auc-gen: Print hex values without intermittent spaces
When generating some authentication vectors using the osmo-auc-gen
utility, it used to print values like this:
AUTN: f7 55 bc 47 de d0 00 00 f9 ed 4b 3f 6c 2a 97 6f
which is quite difficult to copy+paste on the terminal. Now it
generates the following format:
Change-Id: I2805615e0c2087ca632e0658b37a9e06929620b6
AUTN: f755bc47ded00000f9ed4b3f6c2a976f
Reviewed-on: https://gerrit.osmocom.org/164
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=ec8f192fec548dd87522946319d80…
commit ec8f192fec548dd87522946319d80e4f3bc4e35c
Author: Max <msuraev(a)sysmocom.de>
Date: Tue May 31 14:50:21 2016 +0200
Add functions to detect HR/FR SID frames
Add functions which check if given FR or HR frame (packed in RTP)
contains SID (SIlence Descriptor) and corresponding tests.
Related: OS#22
Change-Id: I4051e3c0d4fb9ee93d7e9e0ef4abaf9f18e227ca
Reviewed-on: https://gerrit.osmocom.org/160
Tested-by: Jenkins Builder
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=720ac4a4e1768cd928eb9d9265c04…
commit 720ac4a4e1768cd928eb9d9265c0417f6865bc1b
Author: Ruben Undheim <ruben.undheim(a)gmail.com>
Date: Fri May 27 22:03:59 2016 +0200
Patched structs for big-endian architectures
Change-Id: I29eafe481e112d18c624b1c83add0d53c354dbe4
Reviewed-on: https://gerrit.osmocom.org/124
Tested-by: Jenkins Builder
Reviewed-by: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=92db150488bdadf6577a4968feabd…
commit 92db150488bdadf6577a4968feabd5a3ab694c5e
Author: Max <msuraev(a)sysmocom.de>
Date: Wed May 25 18:13:51 2016 +0200
Add helper functions for AMR codec
* add functions to encode/decode various codec paramters from RTP payload with
AMR frame according to RFC 4867
* those functions are extended version based on code from osmo-bts'
amr.c by Andreas Eversberg
* add corresponding enum types and strings for logging
* add regression tests
It's useful both to replace manual parsing in osmo-bts with fuctions
covered by test suite and as a debugging helpers for issues related to
AMR.
Change-Id: Ia217679a07d3fbc970f435e20f6eac33d34bd597
Related: OS#1562
Reviewed-on: https://gerrit.osmocom.org/118
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=adef12a3497d14aafe677b77b468b…
commit adef12a3497d14aafe677b77b468b952f4c6b5d5
Author: Max <msuraev(a)sysmocom.de>
Date: Wed May 25 15:25:02 2016 +0200
Add strings with PH primitive names
It's useful debugging helper while troubleshooting L1-related issues.
Change-Id: Id7a6d478fd725c51f54ad746bdf9b9095579ff77
Reviewed-on: https://gerrit.osmocom.org/117
Tested-by: Jenkins Builder
Reviewed-by: Max <msuraev(a)sysmocom.de>
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=e4c294f79b8df9a2a36a630d97f8d…
commit e4c294f79b8df9a2a36a630d97f8dc7ed206c7d6
Author: Beshr Al Nahas <beshr.ns(a)gmail.com>
Date: Sat May 28 14:21:13 2016 +0200
Fixing build on Mac OSX
Fix minor syntax error
Change-Id: I67f9a1e41fa5b1da3a4b10fc76138e153b767241
Reviewed-on: https://gerrit.osmocom.org/125
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=029f5a1c0d30bbd605f62f0c535e9…
commit 029f5a1c0d30bbd605f62f0c535e920e8c37ca92
Author: Ruben Undheim <ruben.undheim(a)gmail.com>
Date: Wed Sep 16 19:02:35 2015 +0200
misc: Some spelling errors corrected
Change-Id: Ibfc239b84879556624ca6020ae6a63d102640c94
Reviewed-on: https://gerrit.osmocom.org/114
Tested-by: Jenkins Builder
Reviewed-by: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=45abec20dd66a7ebb762ad8942d1b…
commit 45abec20dd66a7ebb762ad8942d1ba818287ff63
Author: Holger Freyther <holger(a)freyther.de>
Date: Fri May 20 19:21:27 2016 +0000
Revert "gsm48: move to hex TMSI representation"
This is a "flag" day change. Old OpenBSC break with new libosmocore
because suddenly there is the 0x in front. I am afraid we need to
find a better solution here. I think we will need to create a
gsm48_mi_to_string variant that takes a mode parameter to enable the
TMSI mode and deprecate the old method.
Right now we should not break old versions of OpenBSC.
This reverts commit 78ad042f94afd5bf7de477ae634e9d2fdd9c9dc4.
Change-Id: I2f61e626f2f9088b492e1b643c3dcc9bce77d52b
Reviewed-on: https://gerrit.osmocom.org/86
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=cc3694b650e22598811b3e5eaf74e…
commit cc3694b650e22598811b3e5eaf74ef3dc0e4f7ab
Author: Arran Cudbard-Bell <a.cudbardb(a)freeradius.org>
Date: Wed May 18 16:02:19 2016 -0400
Fix build for OSX
Change-Id: I580a500edcf4812e570be586890abef746083a8c
Reviewed-on: https://gerrit.osmocom.org/74
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=78ad042f94afd5bf7de477ae634e9…
commit 78ad042f94afd5bf7de477ae634e9d2fdd9c9dc4
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Fri May 13 13:11:13 2016 +0600
gsm48: move to hex TMSI representation
Previously, we traditionally displayed a TMSI in its integer
representation, which is quite unusual in the telecom world.
A TMSI is normally printed as a series of 8 hex digits.
Review at https://gerrit.osmocom.org/57/
Change-Id: Ifd25365bfa3b4ee95b16979740c3229948ce17f2
Reviewed-on: https://gerrit.osmocom.org/57
Tested-by: Jenkins Builder
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=2da9e11258588367f288e6abfa9eb…
commit 2da9e11258588367f288e6abfa9ebcb50d11f456
Author: Alexander Couzens <lynxis(a)fe80.eu>
Date: Tue May 17 17:56:58 2016 +0200
add .gitreview
A gitreview file is required to use git review.
More information about git review
https://www.mediawiki.org/wiki/Gerrit/git-review
Change-Id: I95235dddf60670c38a5a7a726c2a77f09d03c303
Reviewed-on: https://gerrit.osmocom.org/69
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=ec012d09995f8336f917f5b1d22cd…
commit ec012d09995f8336f917f5b1d22cdb8bba9c03a9
Author: Arran Cudbard-Bell <a.cudbardb(a)freeradius.org>
Date: Wed May 18 16:02:53 2016 -0400
Ignore config.cache
Change-Id: Ida2294e490eb5eec515aa00742fb6cfc29b11b48
Reviewed-on: https://gerrit.osmocom.org/83
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=764b022fc69c4bb9816e12801186f…
commit 764b022fc69c4bb9816e12801186f8fa25f8dd72
Author: Max <msuraev(a)sysmocom.de>
Date: Wed May 11 17:33:17 2016 +0200
Add function to make Uplink Measurement
It assembles RSL Uplink Measurement IE according to 3GPP TS 08.58
§9.3.25. The function is based on lchan_build_rsl_ul_meas() from OsmoBTS
but optionally includes DTX information.
Change-Id: Ib37107bcc9909e5105ea711de42d3fb1db7e8d9e
Reviewed-on: https://gerrit.osmocom.org/44
Tested-by: Jenkins Builder
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=fe65fa7e36a400d362666e2c5bd0f…
commit fe65fa7e36a400d362666e2c5bd0f289d45aa56a
Author: Max <msuraev(a)sysmocom.de>
Date: Tue May 10 17:17:05 2016 +0200
Set DTX in Cell Options
* rename field of struct gsm48_cell_options to better match the spec
* add comments with spec references
* add function for setting DTX in cell options struct
* add necessary enum type
Change-Id: I5a8924f57669c951b2e51b663d95f1d360062a54
Reviewed-on: https://gerrit.osmocom.org/39
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
Tested-by: Jenkins Builder
http://cgit.osmocom.org/osmocom-bb/commit/?id=3d79240fb41270d58f9c33508e11f…
commit 3d79240fb41270d58f9c33508e11f0c215951cc9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue May 10 15:23:06 2016 +0200
logging: Use __BASE_FILE__ instead of __FILE__
Apparently __FILE__ expands to nasty '../../..' paths when BUILDDIR !=
SRCDIR. This in turn leads to ugly log lines like:
<0000> ../../../../osmo-bts/src/common/rsl.c:1642 (bts=0,trx=0,ts=0,ss=0) Handing RLL msg UNIT_DATA_IND from LAPDm to MEAS REP
Where we certainly wouldn't want the "../../../../osmo-bts" part.
Change-Id: If6d2de33c3b6bb2943954bbd81eff261dc279d58
Reviewed-on: https://gerrit.osmocom.org/38
Tested-by: Jenkins Builder
Reviewed-by: Harald Welte <laforge(a)gnumonks.org>
http://cgit.osmocom.org/osmocom-bb/commit/?id=d71257fdb6d3ba3cfb60a87f4e292…
commit d71257fdb6d3ba3cfb60a87f4e29226cce6976f5
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue May 10 13:00:05 2016 +0200
debian: Fix packaging by requiring python-minimal
We require the python2 binary to generate code. In Debian this
is provided by python-minimal. Add it to the build-depends to
fix building packages.
Change-Id: Iaa26f4331966d015b193d2ab1e34621b1e319ef1
Reviewed-on: https://gerrit.osmocom.org/37
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=c7bf8d0c8474534816d893d4b51f4…
commit c7bf8d0c8474534816d893d4b51f4844ccd71a86
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun May 8 22:23:40 2016 +0200
api doc: auth_core.c: add \returns, cosmetic
Add various missing \returns doxygen entries.
In osmo_auth_3g_from_2g(), also adjust two comment-closing instances to
match common style and add a period to end a sentence.
(The recent addition of osmo_auth_3g_from_2g() raised my attention, and I added
more return value docs while at it.)
Change-Id: Iea71eb666bc061acb6b14215f398bd38d17b3ad3
Reviewed-on: https://gerrit.osmocom.org/33
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger(a)freyther.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=7530d8242e528cd5ef5062192effd…
commit 7530d8242e528cd5ef5062192effde835ca48dfb
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Apr 25 19:09:24 2016 +0200
add doc/*.tag to .gitignore
http://cgit.osmocom.org/osmocom-bb/commit/?id=766da8687741340135b637aa59388…
commit 766da8687741340135b637aa593886b7345b8ddc
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri May 6 11:18:15 2016 +0200
GSUP: Add support for RAND in SendAuthInfo.req
In the autentication re-sync case, we need not only the AUTS from
the MS/UE, but also the RAND that we sent as part of the failed
authentication challenge.
http://cgit.osmocom.org/osmocom-bb/commit/?id=48dc1a5a64041e53e7cf7ae39758e…
commit 48dc1a5a64041e53e7cf7ae39758ed92aecbb6a3
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu May 5 18:46:42 2016 +0200
GSUP: Add OSMO_GSUP_CN_DOMAIN_IE to differentiate CS and PS plane
We're starting to use GSUP for circuit-switched (CS) plane, so we need
to differentiate the two planes somehow from each other.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3b6fb0880c3ab1e23a3d7d738d073…
commit 3b6fb0880c3ab1e23a3d7d738d073b00c2a794c2
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Apr 25 18:46:22 2016 +0200
import gprs_gsup_message.[ch] from openbsc as gsup.[ch]
Move those routines from OpenBSC to libosmogsm, so they can be
re-used from other programs. I think it was a mistake to add them only
inside the openbsc repository in the first place. We need to pay more
attention to this in the future.
http://cgit.osmocom.org/osmocom-bb/commit/?id=9709b2e6fd84cab48fc7844475518…
commit 9709b2e6fd84cab48fc7844475518f68f937bb01
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Apr 25 18:47:53 2016 +0200
Import osmo_{encode,decode}_big_endian() from openbsc
http://cgit.osmocom.org/osmocom-bb/commit/?id=fbd02fa8ccb27472412189febcc22…
commit fbd02fa8ccb27472412189febcc22f77d83ba0ac
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Apr 25 15:19:35 2016 +0200
tlv: Import osmo_shift_* and osmo_match_shift_* from openbsc
These routines have nothing to do with specifically the BSC, so import
them to the TLV parser we keep in libosmogsm.
http://cgit.osmocom.org/osmocom-bb/commit/?id=2d2e2cca0dc1d62addc9c9fcb3a59…
commit 2d2e2cca0dc1d62addc9c9fcb3a59f343fc3baf6
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Apr 25 12:11:20 2016 +0200
Update doxygen annotations in libosmocore
This adds and improves doxygen API descriptions all over libosmocore,
reducing the 'white spots' that don't have any documentation.
http://cgit.osmocom.org/osmocom-bb/commit/?id=0996c879255e4653740814112bf98…
commit 0996c879255e4653740814112bf98d0ddc93100c
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Apr 20 17:28:03 2016 +0200
add new header file for TS 23.003
http://cgit.osmocom.org/osmocom-bb/commit/?id=64f38c0410552e7c8ce1f12ceed8a…
commit 64f38c0410552e7c8ce1f12ceed8af0496d4ff01
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Apr 20 17:12:24 2016 +0200
import gsm_04_08_gprs.[ch] from openbsc.git
The definitions in this header file (and associated strings in the
c file) are generic about the GPRS Layer3 signalling protocols, and
thus should be part of the library.
http://cgit.osmocom.org/osmocom-bb/commit/?id=69e6c3c7cdaeabbe31f66fffe9606…
commit 69e6c3c7cdaeabbe31f66fffe9606cb6ee2ec8ee
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Apr 20 10:41:27 2016 +0200
Add log_fini() function to release all memory allocated by logging framework
This is e.g. quite useful to call at the end of test code, in order to
show that all memory allocated actually is released before exit().
http://cgit.osmocom.org/osmocom-bb/commit/?id=cd9cb90f452ed83a3df0bf9d136ae…
commit cd9cb90f452ed83a3df0bf9d136aea19186c7f7b
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Apr 20 10:39:00 2016 +0200
auth_core: Add osmo_auth_3g_from_2g() to compute CK+IK from Kc
This function performs the C5+C4 conversion to derive UMTS key
material from a 2G-only subscriber.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3a96d2837c2d5648692737ad5ddcc…
commit 3a96d2837c2d5648692737ad5ddcc3893e12e913
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Apr 29 21:24:48 2016 +0200
conv_gen: Use python2 to execute the script
The script does not work with python3:
$ python3 utils/conv_gen.py
File "utils/conv_gen.py", line 124
def _print_term(self, fi, num_states, pack = False):
Second there is no 'python' on FreeBSD and one needs to select
the major version to use.
GEN conv_cs3_gen.c
GEN conv_xcch_gen.c
GEN conv_cs2_gen.c
python: not found
python: not found
python: not found
By using python2 we solve both issues. On Debian python2 is located
inside the python-minimal package.
http://cgit.osmocom.org/osmocom-bb/commit/?id=eea18a6f29a04706877f4e888818a…
commit eea18a6f29a04706877f4e888818a826f0dcc93a
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Apr 29 15:18:35 2016 +0200
add two missing files (gsm0503.h / conv_gen.py) to previous commit
http://cgit.osmocom.org/osmocom-bb/commit/?id=84da22f96429f77276783d28622d0…
commit 84da22f96429f77276783d28622d0c6acb5c484d
Author: Max Suraev msuraev(a)sysmocom.de <laforge(a)gnumonks.org>
Date: Fri Apr 29 13:17:22 2016 +0200
Add code generator for convolutional codes
Add python utility to generate .c code with convolutional
encoder/decoder based on polynomial description of the code. If argument
given it'll be interpreted as intended output directory, otherwise
current working directory is used.
Codes for *CCH, CS2/3 and TCH/AFS are generated. Corresponding manual
implementations are removed from tests. This introduce build-time
dependency on python.
The main work for this patch was generously contributed by Sylvain
Munaut.
Fixes: OS#1629
http://cgit.osmocom.org/osmocom-bb/commit/?id=aa16d63c273204dc69108f7361d38…
commit aa16d63c273204dc69108f7361d38b751bfb69e4
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Apr 23 17:55:39 2016 +0200
milenage/aes: Address undefined behavior on bitshift
Extend the u8 to u32 before going to shift it.
Fixes:
milenage/aes-internal.c:799:4: runtime error: left shift of 128 by 24 places cannot be represented in type 'int'
#0 0x7f84e9fe86a2 in rijndaelKeySetupEnc (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/src/gsm/.libs/libosmogsm.so.5+0xfa6a2)
#1 0x7f84e9febad8 in aes_encrypt_init (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/src/gsm/.libs/libosmogsm.so.5+0xfdad8)
#2 0x7f84e9fe7d14 in aes_128_encrypt_block (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/src/gsm/.libs/libosmogsm.so.5+0xf9d14)
#3 0x7f84e9febe7d in milenage_f1 (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/src/gsm/.libs/libosmogsm.so.5+0xfde7d)
#4 0x7f84e9fee2ce in milenage_generate (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/src/gsm/.libs/libosmogsm.so.5+0x1002ce)
#5 0x7f84e9fe76d7 in milenage_gen_vec (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/src/gsm/.libs/libosmogsm.so.5+0xf96d7)
#6 0x7f84e9fe6c08 in osmo_auth_gen_vec (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/src/gsm/.libs/libosmogsm.so.5+0xf8c08)
#7 0x401441 in main (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/tests/auth/.libs/lt-milenage_test+0x401441)
#8 0x7f84e8e33a3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x20a3f)
#9 0x400e58 in _start (/home/builder/jenkins/workspace/Osmocom_Sanitizer/source/libosmocore/tests/auth/.libs/lt-milenage_test+0x400e58)
http://cgit.osmocom.org/osmocom-bb/commit/?id=7d004a1d69acc09707860334ccdfc…
commit 7d004a1d69acc09707860334ccdfcf71604206be
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Apr 24 20:56:55 2016 +0200
doxygen: Remove the tag file on uninstall as well
Hopefully last patch:
ERROR: files left in build directory after distclean:
./doc/libosmocore.tag
./doc/libosmovty.tag
./doc/libosmogsm.tag
./doc/libosmocodec.tag
Makefile:800: recipe for target 'distcleancheck' failed
http://cgit.osmocom.org/osmocom-bb/commit/?id=c63ed3f7c6e29720da3e0fed3c94a…
commit c63ed3f7c6e29720da3e0fed3c94a4569d8e6c71
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Apr 24 20:30:14 2016 +0200
doxygen: Next try to fix the uninstall handling
Use /* to remove the files
http://cgit.osmocom.org/osmocom-bb/commit/?id=faaf2528b11653c955d649341fe2e…
commit faaf2528b11653c955d649341fe2eebea6cfa128
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Apr 24 20:16:41 2016 +0200
doxygen: Try to uninstall the search files as well
Try to fix this by putting the search directory first as I don't
know how to pass -r to the RM command.
rm -f doc/{core,gsm,vty,codec}/{html,latex}/* doc/html.tar doc/{core,gsm,vty,codec}/doxygen_sqlite3.db
rm: cannot remove ‘doc/core/html/search’: Is a directory
rm: cannot remove ‘doc/gsm/html/search’: Is a directory
rm: cannot remove ‘doc/vty/html/search’: Is a directory
rm: cannot remove ‘doc/codec/html/search’: Is a directory
http://cgit.osmocom.org/osmocom-bb/commit/?id=936151bbffc6a06124dac7252a5bf…
commit 936151bbffc6a06124dac7252a5bf183f89581ea
Author: Max <msuraev(a)sysmocom.de>
Date: Sun Apr 24 12:01:03 2016 +0200
Add static lib to -dev .deb package
According to https://www.debian.org/doc/debian-policy/ch-sharedlibs.html
and http://packaging.ubuntu.com/html/libraries.html that's where it
belongs.
http://cgit.osmocom.org/osmocom-bb/commit/?id=610ef99e6d66cd36fbee712c744c4…
commit 610ef99e6d66cd36fbee712c744c4cc71f08844f
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Sun Apr 24 15:05:45 2016 +0200
Doxygen: enable tagfile generation and usage for cross-project references
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=c7c582a95f8a68e9516bb60132b38…
commit c7c582a95f8a68e9516bb60132b384c4087d55b3
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Sun Apr 24 15:05:44 2016 +0200
Doxygen: Enable client-based search engine
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=27e8036d418181e390809c8668d15…
commit 27e8036d418181e390809c8668d15a9ab425be59
Author: Max <msuraev(a)sysmocom.de>
Date: Sat Apr 23 19:37:58 2016 +0200
Fix unaligned access found by addr. sanitizer
gprs_bssgp.c:461:9: runtime error: load of misaligned address
0x62100001a66b for type 'uint32_t', which requires 4 byte alignment
gprs_ns.c:937:16: runtime error: load of misaligned address
0x61d00002a97f for type 'uint16_t', which requires 2 byte alignment
http://cgit.osmocom.org/osmocom-bb/commit/?id=8a5346ba2f7ed7b4e69d32397b99d…
commit 8a5346ba2f7ed7b4e69d32397b99d11c14694a2a
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Apr 22 19:28:09 2016 +0200
Add function for appending range1024 to bitvec
Add convenience function to append range1024 encoded data (see 3GPP TS
44.018 Annex J) to a given bitvec.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1f9d8183be276fa770b106d1e8f97…
commit 1f9d8183be276fa770b106d1e8f9719386a9515a
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Apr 21 17:12:40 2016 +0200
Deprecate comp128
Mark function as deprecated to discourage its usage: people should use
generic API in osmocom/crypt/auth.h
http://cgit.osmocom.org/osmocom-bb/commit/?id=fdb3d8ce7898801d5b18d446a17cc…
commit fdb3d8ce7898801d5b18d446a17ccc0f09451d4f
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Apr 21 16:51:04 2016 +0200
Deprecate osmo_a5_1 and osmo_a5_2
Mark the functions as deprecated to discourage their use: people should
use unified osmo_a5 which supports all the A5/1-4 ciphers.
http://cgit.osmocom.org/osmocom-bb/commit/?id=aead05da321e3accaffec471d547d…
commit aead05da321e3accaffec471d547d3a7174091b2
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Apr 21 15:57:52 2016 +0200
Improve code reuse
Use generic functions covered by testsuit for SQN calculations.
http://cgit.osmocom.org/osmocom-bb/commit/?id=bf990bb8fd5aa27c57416831311bc…
commit bf990bb8fd5aa27c57416831311bc4b2a9769bef
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Apr 21 14:46:30 2016 +0200
Update internal GPRS cipher API
Update internal API (for GPRS cipher implementors): make it compliant
with ETSI TS 155.22. External API left untouched.
http://cgit.osmocom.org/osmocom-bb/commit/?id=402b9b055538737838ce112a99a75…
commit 402b9b055538737838ce112a99a75401aa4f14c6
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Apr 21 14:58:30 2016 +0200
Addditional classmark check against A5/4 support
Add classmark check function according to GSM 04.08 Chapter 10.5.1.7
Fix interface to use unsigned for unsigned value.
http://cgit.osmocom.org/osmocom-bb/commit/?id=fbb8bfa514284f9744809afba51de…
commit fbb8bfa514284f9744809afba51dec716590090c
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Apr 15 16:04:04 2016 +0200
Add function to get osmo_earfcn bit size
This function returns the number of bits necessary to pack osmo_earfcn
into Repeated E-UTRAN Neighbour Cells IE (3GPP TS 44.018 Table
10.5.2.33b.1).
http://cgit.osmocom.org/osmocom-bb/commit/?id=da1b20cd4f7b13121434d32817886…
commit da1b20cd4f7b13121434d32817886d7803fd6052
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Apr 14 15:12:16 2016 +0200
logging.c: assert category_token allocation (CID #57871)
http://cgit.osmocom.org/osmocom-bb/commit/?id=700297528cb0894524b8d188ebd33…
commit 700297528cb0894524b8d188ebd3377af27c488d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Apr 13 18:50:41 2016 -0400
jenkins: Enable tracing and error handling in bash
Like jenkins we want to see what is actually being executed
and fail if a subcommand has failed.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d16321801d458909b8c5594060bbd…
commit d16321801d458909b8c5594060bbdf17456acae2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Apr 13 18:47:15 2016 -0400
jenkins: Add build script used by jenkins on our public CI
The actual script (removed unused and commented out handling) as
invoked by jenkins. This can be used to locally try to reproduce
the build.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d8fb14226f798c9daf948d374a982…
commit d8fb14226f798c9daf948d374a982583cd4ee202
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Apr 6 16:13:00 2016 +0200
Add ubit <-> sbit convertors
Move functions for conversion between soft and unpacked bits to main
library as they are generally useful.
http://cgit.osmocom.org/osmocom-bb/commit/?id=93bc64f99ddef02a39c03dfd0725b…
commit 93bc64f99ddef02a39c03dfd0725bb41dc93e287
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Apr 11 16:57:34 2016 +0200
gb: Add bssgp_pdu_str to libosmogb namespace
[hfreyther: To be used by osmo-pcu]
http://cgit.osmocom.org/osmocom-bb/commit/?id=b9bb0b02acdcd2b56e2821e454d73…
commit b9bb0b02acdcd2b56e2821e454d73affa044e199
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Apr 7 11:01:52 2016 +0200
Add missing docs for bssgp bvc reset vty command
Fixes the build failure with extended tests enabled.
http://cgit.osmocom.org/osmocom-bb/commit/?id=ea50732df21442c8d33806d30040d…
commit ea50732df21442c8d33806d30040d6d81f7aab90
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Mar 31 21:40:26 2016 +0200
Add vty command to explicitly reset given BVCI
It's useful for debugging and is similar to existing reset command for
nsvc.
http://cgit.osmocom.org/osmocom-bb/commit/?id=793a2907d553095d77d73e8bf7cc1…
commit 793a2907d553095d77d73e8bf7cc132667ee7240
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Mar 23 14:48:39 2016 +0100
vty: Make a reservation for the osmo-sip-connector
The osmo-sip-connector is a new application and is a MNCC to SIP
bridge. It is not implementing transcoding or RTP proxying at all.
http://cgit.osmocom.org/osmocom-bb/commit/?id=61f28880d5dc3f08689bef61a54fa…
commit 61f28880d5dc3f08689bef61a54fa2035928ffaa
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Mar 21 09:55:05 2016 +0100
select: Externalize fd_set filling and dispatch
To integrate with an external event loop (in this case glib) we
need to allow an application to get a filled out fd_set and then
dispatch it. osmo_fds and maxfds are static and I decided to keep
it that way and instead create two routines to fill the fdset and
then one to dispatch the result.
The public header file does not include sys/select.h and we can
compile the library without select, so I didn't want to require
having to include this file, and used void * for the parameter.
Mark the routines as inline to avoid a call from the select
function. I have confirmed that inlining has an effect on x86
using Debian's gcc-4.9.2-10 compiler
http://cgit.osmocom.org/osmocom-bb/commit/?id=fb348eeff25e8e66a4a8651dc9490…
commit fb348eeff25e8e66a4a8651dc94901c7a004343a
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Mar 30 21:14:53 2016 +0200
Export names for gsm_chan_t and gsm48_chan_mode
This can be used with get_value_string() to improve debugging output.
http://cgit.osmocom.org/osmocom-bb/commit/?id=92c4ec293d0b73e5c6306d26e6083…
commit 92c4ec293d0b73e5c6306d26e608340edc40b04c
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Mar 21 11:28:59 2016 +0100
sim: Fix compiler warning and by this fixing the test result
http://cgit.osmocom.org/osmocom-bb/commit/?id=932d2d4ce31b9d2dfb028df2ca683…
commit 932d2d4ce31b9d2dfb028df2ca683b42fee7ee54
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Mar 19 21:18:40 2016 +0100
sim: make osim_reader_ops public
http://cgit.osmocom.org/osmocom-bb/commit/?id=6c33ae2605b038391a80dd5defb76…
commit 6c33ae2605b038391a80dd5defb76a5fabb5dd2b
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Mar 19 21:17:58 2016 +0100
Add new osmo_fd_get_by_fd() function
This function can be used to obtain the osmo_fd corresponding to a given
fd. The latter can be useful when integrating libosmocore main loop
with other libraries.
http://cgit.osmocom.org/osmocom-bb/commit/?id=676e53446285d1b8f514580fd9485…
commit 676e53446285d1b8f514580fd9485d1f27493c0b
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 14 21:04:50 2016 +0100
sim: Add simplistic unit test for APDU class tables
http://cgit.osmocom.org/osmocom-bb/commit/?id=4acaa13433cc15e4f1d9ee850d78a…
commit 4acaa13433cc15e4f1d9ee850d78af47419768ab
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 14 15:35:50 2016 +0100
sim: add class_tables / card profiles
The tables permit code to determine the APDU class of an APDU
based on it APDU/TPDU header (CLA/INS/P1/P2/P3).
http://cgit.osmocom.org/osmocom-bb/commit/?id=2c34ab4a80c227be4bb685f75fc24…
commit 2c34ab4a80c227be4bb685f75fc24fde86a0704e
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Mar 17 15:42:26 2016 +0100
Improve BSSGP debug output
Print string representation of Cause IE and PDU type instead of
numerical value.
http://cgit.osmocom.org/osmocom-bb/commit/?id=5bed23c6d2722a174aeb1534ecccf…
commit 5bed23c6d2722a174aeb1534ecccf80a657deae3
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Mar 17 16:50:27 2016 +0100
add missing #include <stdbool.h>
http://cgit.osmocom.org/osmocom-bb/commit/?id=ea345cdaaa23f3e0472deccac9982…
commit ea345cdaaa23f3e0472deccac9982014e632aba9
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Mar 17 14:46:19 2016 +0100
Rename struct to better match libosmocore conventions
http://cgit.osmocom.org/osmocom-bb/commit/?id=c79b3972faf900e3d843ddc13601e…
commit c79b3972faf900e3d843ddc13601e6178e3131ff
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Mar 17 14:42:45 2016 +0100
Revert "gsm48: move to hex TMSI representation"
This reverts commit f451ce66eb8206bad1078849723edcb209632834.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f451ce66eb8206bad1078849723ed…
commit f451ce66eb8206bad1078849723edcb209632834
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Wed Mar 16 21:12:22 2016 +0600
gsm48: move to hex TMSI representation
Signed-off-by: Vadim Yanitskiy <axilirator(a)gmail.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=03309b57e8ba0163032a1d3db6b44…
commit 03309b57e8ba0163032a1d3db6b44fc8a7e6147c
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Mar 17 11:51:09 2016 +0100
Add basic EARFCN support
Add structure representing group of EARFCNs with common priority,
threshold etc.
Add functions to populate this structure.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d4793212b5026fed01d132fa7397c…
commit d4793212b5026fed01d132fa7397cc0ff2f543fe
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Mar 17 11:51:08 2016 +0100
Add function to add bits from array to bitvec
Add function which adds specified number of bits from each element of
array to the bit vector prefixing each addition with one and finishing
entire sequence with adding 0. This is very common patter for various
repetitive data structures described with CSN.1 in 3GPP standards.
Corresponding test vectors and doxygen headers are added too.
http://cgit.osmocom.org/osmocom-bb/commit/?id=bdccc1b1444a8692697bd8a293cc8…
commit bdccc1b1444a8692697bd8a293cc89c90ef2d832
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Mar 15 13:28:10 2016 +0100
gsm48: factor out MCC+MNC BCD parsing for re-use in UMTS
For 3G, I need a BCD composer/parser similar to gsm48_generate_lai()/
gsm48_decode_lai(). Those functions also handle a trivial extra
member (lac) which I don't need in this way for 3G.
So create new functions to take on the MCC+MNC BCD handling and call those
from gsm48_generate_lai() and gsm48_decode_lai(). In this way, the 3G code
in openbsc can use only the BCD functionality without code duplication.
http://cgit.osmocom.org/osmocom-bb/commit/?id=da7bf4d55a896034320aa4466b964…
commit da7bf4d55a896034320aa4466b9644083093acd1
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Mar 14 16:06:48 2016 +0100
04.08: add inline funcs for transaction id bits
Various users of gsm48_hdr apply the same hardcoded shifts/bitmasks to obtain
the transaction ID encoded in the upper nibble of the protocol discriminator.
Centralize. Patch for openbsc.git will follow.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c656faed122b8d858e937d3262acb…
commit c656faed122b8d858e937d3262acb1925ed6e3d1
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Mar 14 16:06:47 2016 +0100
04.08: switch to r99 msg type bitmasks by default
[hfreyther: Separated from the previous patch to allow an easy
revert]
http://cgit.osmocom.org/osmocom-bb/commit/?id=282e90843476989629f8ae7e36e4a…
commit 282e90843476989629f8ae7e36e4a59b69da40eb
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Mar 14 16:06:46 2016 +0100
04.08: add inline funcs for pdisc + msg type bitmasks
Add inline functions for both release <= 98 and release >= 99 as well as a
default define. Use the release 98 by default since the current code base uses
the r98 bitmasks.
These inline functions relieve callers of the decision on masking bits of the
protocol discriminator and message type octets.
Also add a define for the protocol discriminator extension to one octet length
(GSM48_PDISC_EXTEND).
Apply new pdisc function in gsm0480.c.
[hfreyther: Make the hdr param const]
http://cgit.osmocom.org/osmocom-bb/commit/?id=c0d9a6c083aa7e35174093c7a7265…
commit c0d9a6c083aa7e35174093c7a7265319bf993a9d
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Mar 9 12:29:23 2016 +0100
Add helper function to convert numerical BSSGP PDU type to string
http://cgit.osmocom.org/osmocom-bb/commit/?id=e859aec95264f0cda85073b03def6…
commit e859aec95264f0cda85073b03def63d8596b07a3
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Mar 11 12:24:04 2016 +0100
Add support for SI2quater messages
Add basic data structure for System information Type 2quater.
http://cgit.osmocom.org/osmocom-bb/commit/?id=5ffb50371eb4795917ea0ce68b374…
commit 5ffb50371eb4795917ea0ce68b3748b0adc74ec9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Mar 11 09:40:56 2016 +0700
rename osim_file_find_* to osim_file_desc_find_*
they return an osim_file_desc, and not an osim_file, so fix the naming
http://cgit.osmocom.org/osmocom-bb/commit/?id=c28f4cdd6d4d9155e431775baf5e8…
commit c28f4cdd6d4d9155e431775baf5e897f0a388ad3
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Mar 11 09:35:07 2016 +0700
sim: Add osim_file_find_{fid,sfid}() functions
We don't always want to look-up by name, but the latter is the only
implemented 'find' function so far. Let's change that.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1cc66f093f2ecd85b3dfb9ba411c4…
commit 1cc66f093f2ecd85b3dfb9ba411c45102cc1ac65
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Feb 13 14:41:02 2016 +0100
merge_doc.xsl: Don't copy the 'descripiton' element of commands
If a vty_additions.xml file contained a <description> element inside a
command> element, then the description was copied twice (once during the
<node> copy, and once during the <command> copy). Let's avoid one of
the two copies.
http://cgit.osmocom.org/osmocom-bb/commit/?id=57f253a792d07e6f3f921c9cb28e4…
commit 57f253a792d07e6f3f921c9cb28e4081393054d4
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Mar 5 08:36:26 2016 +0100
debian: Make sure that libtalloc-dev is installed
This way libosmo-abis, libosmo-sccp, openggsn, openbsc does not
need to install it.
http://cgit.osmocom.org/osmocom-bb/commit/?id=ed0ce47fa9ca78e240d635f3781ad…
commit ed0ce47fa9ca78e240d635f3781ad9820b18b97e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Feb 29 14:41:12 2016 +0100
logging: Remove unused variable after recent changes
The variable is not used anymore as the decision is done in the
newly added check_log_to_target method.
http://cgit.osmocom.org/osmocom-bb/commit/?id=5dd3f1dd67a41fb46f2fcb6b58068…
commit 5dd3f1dd67a41fb46f2fcb6b58068525cda0a8a0
Merge: f20f5fd5 79599acd
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Feb 29 14:34:34 2016 +0100
Merge branch 'sysmocom/shared/log-speed'
http://cgit.osmocom.org/osmocom-bb/commit/?id=79599acd663f7c488560d72d63f4e…
commit 79599acd663f7c488560d72d63f4e29587fc63a2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Jan 15 16:49:06 2016 +0100
logging: Move the filter check up as well
There doesn't seem to be a reason not to check the filter. Update
and extend the test. Currently the filter function will be called
once for the log check and once for the output of it.
http://cgit.osmocom.org/osmocom-bb/commit/?id=e0dc6a1c7cd49433bdf592624ff48…
commit e0dc6a1c7cd49433bdf592624ff484576a7ce4e4
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Dec 21 14:45:16 2015 +0100
logging: Remove some code duplication
Extract the mapping of the subsystem number and the checking for
the loglevel to a inline method that is shared between the new
and old.
http://cgit.osmocom.org/osmocom-bb/commit/?id=64e0eb56fde45d891da122c968589…
commit 64e0eb56fde45d891da122c9685891d29634d03b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 11:52:26 2015 +0100
log/test: Extend test case for log_check_level
This commit adds OSMO_ASSERTs for mandatory conditions related to
log_check_level, and fprintfs for optional conditions, since it is
always safe for log_check_level to return != 0.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=a89d22c0f08edda927ce62b071f17…
commit a89d22c0f08edda927ce62b071f17bd7e5edc5c6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 11:52:25 2015 +0100
log: Add conditional logging based on log_check_level
Currently the LOGP/DEBUGP arguments are always evaluated even if
no logging will happen at all. This can be expensive, for instance
if hexdumps or pretty printed object names are generated. This causes
high base load especially on embedded devices and is a major part of
CPU usage e.g. of the osmo-pcu.
This commit uses the log_check_level function to avoid the evaluation
of the parameters if it is known in advance, that no logging entry
will be generated.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=de6dd72dbbbcc7facf25c4a2521c7…
commit de6dd72dbbbcc7facf25c4a2521c71f653c7b1b2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 11:52:24 2015 +0100
log: Add log_check_level function
This commit adds this predicate function which can be used to
avoid the execution of code if a certain log level is not enabled.
The function will only return 0 (false), if it is sure that a logging
call for the same facility and level will not produce any output.
This safety criterion shall ensure, that no logging output is lost
due to the use of this predicate as a guard. On the other hand, even
if the predicate returns != 0 (true), no logging output might get
generated by a similar logging command.
Note that the current implementation is not focussed on performance,
which could be improved by using a lookup table instead of iterating
through every target.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=f20f5fd5085879624fb6de1e5b9b5…
commit f20f5fd5085879624fb6de1e5b9b5ad435ea0500
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Feb 29 09:56:39 2016 +0100
comment typo
http://cgit.osmocom.org/osmocom-bb/commit/?id=cda988527f0e54be2e5756a0780a9…
commit cda988527f0e54be2e5756a0780a97bbee42c6ba
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Feb 29 09:56:26 2016 +0100
fix gsm_7bit_decode API comment: septets, not octets
http://cgit.osmocom.org/osmocom-bb/commit/?id=6a5ef46dd018c8e66e341a531403e…
commit 6a5ef46dd018c8e66e341a531403e40de24893f2
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Feb 24 16:05:48 2016 +0100
Add byte printing macros
It's sometimes handy for debugging to be able to immediately see which
bits are set in a given byte. Generalize macro used for that in bitvec
tests and make it available for the rest of the library.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f81eb328b61f65a09b7233aaa70b2…
commit f81eb328b61f65a09b7233aaa70b2f655c0300bc
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Feb 24 00:10:41 2016 +0100
vty: add ctrl section for Control interface bind address
This may seem like overkill for a mere const char * config item, but it makes
the Control interface VTY commands reusable in any main() scope (inspired by
libosmo-abis' VTY config).
Add API functions ctrl_vty_init() and ctrl_vty_get_bind_addr(), in new files
src/ctrl/control_vty.c and include/osmocom/ctrl/control_vty.h, compiled and/or
installed dependent on ENABLE_VTY.
Using these functions allows configuring a static const char* with the VTY
commands
ctrl
bind A.B.C.D
which callers shall subsequently use to bind the Control interface to a
specific local interface address, by passing the return value of
ctrl_vty_get_bind_addr() to control_interface_setup().
Add CTRL_NODE to enum node_type, "eating" RESERVED4_NODE to heed that comment
on avoiding ABI changes.
http://cgit.osmocom.org/osmocom-bb/commit/?id=4934309dab3dcd785e75f3ba227e5…
commit 4934309dab3dcd785e75f3ba227e51b19fe714fb
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Feb 24 00:09:40 2016 +0100
add ctrl_interface_setup_dynip() for bind address
Make the ctrl interface bind address configurable, so that it may be made
available on other addresses than 127.0.0.1. The specific aim is to allow
running multiple osmo-nitbs alongside each other (commits in openbsc follow).
http://cgit.osmocom.org/osmocom-bb/commit/?id=96172f01002a64359bbe643c4a0d3…
commit 96172f01002a64359bbe643c4a0d3cfa9a929b56
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Feb 23 14:01:41 2016 +0100
vty: add bind command for telnet vty line
Add VTY command
line vty
bind A.B.C.D
The command merely stores the configured IP-address, which can then be used by
the calling main program to set the telnet port of the VTY line. (Commits in
openbsc and osmo-iuh will follow up on this.)
Add function vty_get_bind_addr() to publish the address in the vty.h API.
Add static vty_bind_addr to store.
For allocation/freeing reasons, a NULL address defaults to 127.0.0.1.
BTW, I decided against allowing keywords 'any' and 'localhost' in place of an
actual IP address to make sure a written config is always identical to the
parsed config.
http://cgit.osmocom.org/osmocom-bb/commit/?id=cc00bf8779f48fd1e592fc7d0a60f…
commit cc00bf8779f48fd1e592fc7d0a60fc00b04826cd
Author: Max <msuraev(a)sysmocom.de>
Date: Mon Feb 22 11:03:26 2016 +0100
Extend L1SAP PH-DATA with presence information
Previously the presence of header and data blocks were communicated
in-band which decreases code readability and makes it unnecessary hard
to add support for new hardware.
Note: OsmoBTS have to be modified to take advantage of extended
ph_data_param structure.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f78ec5ce0d0f6038147d9b9e14d81…
commit f78ec5ce0d0f6038147d9b9e14d81094309ba5d5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 09:53:23 2015 +0100
gb: Add bssgp_msgb_copy function
This function originates from openbsc/src/gprs but is just specific
to BSSGP/Gb on the same level like bssgp_msgb_alloc.
This commit puts the former gprs_msgb_copy function beside
bssgp_msgb_alloc.
Renamed function:
gprs_msgb_copy -> bssgp_msgb_copy
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ab0eb96dd9f49aecf6722c0ec01b0…
commit ab0eb96dd9f49aecf6722c0ec01b03d6061cd40e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Feb 18 20:28:25 2016 +0100
bitvec: Untested speculative UBAN fix for the new routine
int << 31 does not seem to be defined, let's try to make it an
unsigned variable and see if that is pleasing the system.
Fixes:
bitvec.c:219:15: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
http://cgit.osmocom.org/osmocom-bb/commit/?id=5c18e26bc291766b0de22223abcf3…
commit 5c18e26bc291766b0de22223abcf340bc48e3157
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Feb 5 13:55:38 2016 +0100
Add T4 bit map compression routines
Add bit map encoder and decoder functions: decoder is fully functional
while encoder is good enough for testing - no backtracking to find
the best possible compression is implemented. If somebody is willing to
implement MS side of EDGE than this has to be expanded.
Add corresponding tests.
N. B: the encoding is implemented according to ETSI TS 44.060 which is
slightly different from T4 used for fax according to CCITT G31D (RFC 804).
Ticket: OW#2407
Sponsored-by: On-Waves ehf
Signed-off-by: Max <msuraev(a)sysmocom.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=0a59e9899f4dd4213dc72d535f0b9…
commit 0a59e9899f4dd4213dc72d535f0b9d5382dc7eb7
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Feb 5 13:55:37 2016 +0100
Expand bitvec interface
Add bit filling, shifting and other functions necessary for bit
compression implementation. Add corresponding tests.
http://cgit.osmocom.org/osmocom-bb/commit/?id=868471496698657b34e7105458f76…
commit 868471496698657b34e7105458f76306a76b6614
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Feb 15 12:02:02 2016 +0100
Add CSCN ctrl port defs
http://cgit.osmocom.org/osmocom-bb/commit/?id=620dfa6be2b061652aabef02a68dc…
commit 620dfa6be2b061652aabef02a68dce9375805235
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Feb 10 13:28:00 2016 +0100
add vty port nr for osmo-cscn
http://cgit.osmocom.org/osmocom-bb/commit/?id=5710804a42b72504c012b75222b66…
commit 5710804a42b72504c012b75222b663cdf46de4f5
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Jan 30 16:16:28 2016 +0100
bivec: Fix the output of the testcase
osmo_hexdump_nospc/osmo_hexdump is an old school C routine with a
static internal array. This means that printf will most likely one
of the two strings twice. For Linux/glibc this is the first string
(for whatever reason?) and for FreeBSD it is the last call of the
osmo_hexdump_nospc. We could have noticed by both strings being
of the same length besides the different length input. The second
issue is that we cast a hexstring to uint8_t and dump the string
as hex. So the two strings should not match at all.
Fix it by printing the hex string as plain hex and separating the
two printf calls. Update the test output.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a9301a1a1f2ac0c73aff2075c2361…
commit a9301a1a1f2ac0c73aff2075c2361d54a6fc8675
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Jan 30 10:54:43 2016 +0100
bitvec: Test and fix regression for C++->C conversion
bitvec_read_field/bitvec_write_field in the PCU used a C++ reference
and when porting to C it was decided to pass the parameter by value
and this lost the "back propagation" of the new index. Change the
parameter to be an in/out parameter and this way do not have a silent
semantic break in the osmo-pcu (where we copy the reference in csn.1
by value) and have a true compile failure.
Add Max's simple test for bitvec_unhex function leaving the checking
of bitvec_read_field and the side effect in the datastructure about
the number of bits still open.
http://cgit.osmocom.org/osmocom-bb/commit/?id=912bc6ff5047f08bb55c1d08be5fe…
commit 912bc6ff5047f08bb55c1d08be5fe4485e37e5d6
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jan 28 12:07:12 2016 +0100
Add doxygen comments to clarify function use
http://cgit.osmocom.org/osmocom-bb/commit/?id=2745b489406ffe1e326c45b3ac213…
commit 2745b489406ffe1e326c45b3ac2134457efd4d80
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Jan 27 17:08:02 2016 +0100
bitvec: Fix build on older gcc
bitvec.c: In function 'bitvec_unhex':
bitvec.c:389: error: 'for' loop initial declarations are only allowed in C99 mode
bitvec.c:389: note: use option -std=c99 or -std=gnu99 to compile your code
http://cgit.osmocom.org/osmocom-bb/commit/?id=a15f05f1b43d8e85d9a3f72a0a804…
commit a15f05f1b43d8e85d9a3f72a0a804dcbeca5068c
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Jan 26 10:43:15 2016 +0100
Add bitvec-related functions from Osmo-PCU
Allocation, pack/unpack, field access and helper routines used
extensively by Osmo-PCU. Whenever memory allocation happens, alocator
context is passed explicitly by caller.
http://cgit.osmocom.org/osmocom-bb/commit/?id=fdb46676094c50f1d2dcebfcb5e05…
commit fdb46676094c50f1d2dcebfcb5e051c2baf984ac
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 9 16:32:43 2015 +0000
test: Fix compiler warnings on 64bit systems
Use %td to print ptrdiff_t use %zu to print size_t,
include time.h on FreeBSD. Some more compiler warnings are
left but they require more thinking.
http://cgit.osmocom.org/osmocom-bb/commit/?id=ee6652b4bcc1bffc0b7c181666c4c…
commit ee6652b4bcc1bffc0b7c181666c4c1b30f5abad2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 9 16:21:19 2015 +0000
ipa: recv is declared in different headers on BSD
Include the headers mentioned by the manpage
ipa.c:346:9: warning: implicit declaration of function 'recv' is invalid in C99
[-Wimplicit-function-declaration]
ret = recv(fd, msg->tail, needed, 0);
http://cgit.osmocom.org/osmocom-bb/commit/?id=d56c3cbb2cbdd9b0114e325556cb5…
commit d56c3cbb2cbdd9b0114e325556cb5efc434b2894
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 9 16:16:00 2015 +0000
vty: Use NULL to have a null pointer instead of '\0'
'\0' gets translated to zero but the argument to vector_set is
a pointer and it gets converted to a pointer.
vty.c:985:21: warning: expression which evaluates to zero treated as a null pointer constant of type
'void *' [-Wnon-literal-null-conversion]
vector_set(vline, '\0');
^~~~
vty.c:1095:21: warning: expression which evaluates to zero treated as a null pointer constant of type
'void *' [-Wnon-literal-null-conversion]
vector_set(vline, '\0');
^~~~
vty.c:1097:21: warning: expression which evaluates to zero treated as a null pointer constant of type
'void *' [-Wnon-literal-null-conversion]
vector_set(vline, '\0');
^~~~
http://cgit.osmocom.org/osmocom-bb/commit/?id=61816048ce245c92b0e9e1f1fa8e6…
commit 61816048ce245c92b0e9e1f1fa8e68f9c8444f8f
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Jan 22 16:46:55 2016 +0100
Ignore test binaries
http://cgit.osmocom.org/osmocom-bb/commit/?id=e49af08f5b89b3f922948570eab16…
commit e49af08f5b89b3f922948570eab161763f339185
Author: Max <msuraev(a)sysmocom.de>
Date: Fri Jan 22 16:46:56 2016 +0100
bitvec: Fix interface to consistently use unsigned int
Use unsigned int for the length throughout the interface. We will
never have a a negative length.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=08621a8ebb163aed6ba96e52ad283…
commit 08621a8ebb163aed6ba96e52ad283b91c04501a0
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jan 21 17:16:56 2016 +0100
bitvec: Fix unaligned memory access in osmo_revbytebits_buf
The undefined behavior sanitizer found the 32bit load from an
unaligned memory address. This will cause an exception on ARMv5te
and a manual fix-up.
[hfreyther: On armv6, x86 the usage of memcpy leads to shorter
amount of instructions but on armv5te the memcpy is not expanded
leading to a branch. Use the version of max until we have the time
to benchmark it]
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=cf37c4cd293def64ca87a82def0be…
commit cf37c4cd293def64ca87a82def0be2c8aab12cf0
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Jan 21 16:52:40 2016 +0100
Fix sporadic out-of-bounds error
This code dealing with bit shifting sometimes gets 1 byte beyond array
boundary while calculating index. This is now explicitly checked and prevented.
Ticket: OW#1198
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=fb7e6835758d378be9e09a60a98c3…
commit fb7e6835758d378be9e09a60a98c3fce405f61d2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Jan 21 15:50:04 2016 +0100
kasumi: Fix build with gcc5 that changed behavior of inline
GCC 5 has changed inline semantics (https://gcc.gnu.org/gcc-5/porting_to.html)
and apparently that now fails to link.
http://cgit.osmocom.org/osmocom-bb/commit/?id=e7c18dd59f4f91409e8d8854eee2d…
commit e7c18dd59f4f91409e8d8854eee2d213165e0746
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jan 18 13:30:28 2016 +0100
debian: Avoid linking with -Bsymbolic-functions
Our tests want to be able to change symbols from the library and
even by using --wrap=XYZ it is not possible right now. One option
would be to use static linking but that is not always enabled, the
other is to skip tests on Ubuntu and the third one is to disable
that linking mode. This means that the dynamic linker needs to
spend some more time but we do spend this time on all other distros
and this looks acceptable.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f6d9f3759cf764d74c22dc1908513…
commit f6d9f3759cf764d74c22dc190851371379b221de
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Jan 18 10:44:15 2016 +0100
comment typo
http://cgit.osmocom.org/osmocom-bb/commit/?id=17b3c3aca1290a3f2c20a0858d4d4…
commit 17b3c3aca1290a3f2c20a0858d4d499a17752ced
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:20 2015 +0100
msgb/test: Add test case for error cases
Include a test for msgb_trim.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ff42b26520a7421a6c6c9c9cd4b88…
commit ff42b26520a7421a6c6c9c9cd4b88aed00453b01
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:19 2015 +0100
msgb: Assert len >= 0 in msgb_trim
Currently msgb_trim only checks for len > data_len and returns -1
in that case, allowing the caller to fix it somehow. Using a negative
length will always lead to a corrupt msgb, but this is not being
checked.
This commit adds a check for len < 0 and a conditional call to MSGB_ABORT.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=0a053ec50657ea2060a1c4b8a8e81…
commit 0a053ec50657ea2060a1c4b8a8e811c5027ada7d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:18 2015 +0100
msgb/test: Add tests for msgb_resize_area and msgb_copy
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=cbefa085593128c5f5e6da255edea…
commit cbefa085593128c5f5e6da255edeae6b4f952032
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:17 2015 +0100
msgb/test: Add functions to catch and check exceptions
Currently the msgb error handling cannot be fully tested, since in
many cases osmo_panic will be called. This will in turn call abort().
Using an osmo_panic_handler that just returns will not help, since
many msgb functions rely on MSGB_ABORT to not return at all.
This commit uses an alternative osmo_panic_raise handler that just
calls longjmp to return to the test function.
Since some of this activity is logged to stderr where the strings may
contain variable parts like pointer addresses, stderr checking is
disabled in testsuite.at.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=7cd8a1b06387427c6db4fd9f6dee1…
commit 7cd8a1b06387427c6db4fd9f6dee116212ec304a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:16 2015 +0100
msgb/test: Add test for msgb message buffers
This tests several API functions of the msgb by checking the
invariant and by dumping resulting message buffers as hex.
Sponsored-by: On-Waves ehf
Conflicts:
tests/Makefile.am
http://cgit.osmocom.org/osmocom-bb/commit/?id=5f349be820b32a5bb312566a4a35e…
commit 5f349be820b32a5bb312566a4a35ef679fe7e478
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Dec 21 16:04:03 2015 +0100
bitvec: Add get/set byte sequences
The new functions bitvec_get_bytes and bitvec_set_bytes copy
byte sequences from bitvecs to uint8_t arrays and vice versa.
While the bytes in the bitvecs do not need to be aligned, the uint8_t
arrays always are. In case the bytes in the bitvec are aligned, the
implementation uses memcpy.
Note that the implementation like the other existing functions assume
MSB first encoding.
[hfreyther: Squash the comment fix into this commit as well]
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=8114294bf29ac6e44822c0ae43d4b…
commit 8114294bf29ac6e44822c0ae43d4b0819f11b022
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 08:42:05 2015 +0100
gsm: Add APN conversion functions
These functions are currently part of openbsc but also needed by
other projects.
The function have been renamed as follows:
gprs_apn_to_str -> osmo_apn_to_str
gprs_str_to_apn -> osmo_apn_from_str
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=51660a6adefd59081f7f2883d76a8…
commit 51660a6adefd59081f7f2883d76a875e8b2e89c9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Dec 5 23:38:18 2015 +0100
update TODO-RELEASE regarding the talloc change.
Shipping our own private copy of talloc was a good idea in 2008,
when it was not readily available on most target platforms. Today,
the situation is quite different, as it is a standard library on
major Linux distributions.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c959afdcd9d8f227f4a72a915ac2e…
commit c959afdcd9d8f227f4a72a915ac2e3f79d1d1d3b
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 25 17:14:07 2015 +0100
osmo_prim_op_names should be extern
http://cgit.osmocom.org/osmocom-bb/commit/?id=42fff58a45288337110fb2e91d304…
commit 42fff58a45288337110fb2e91d304b07744c7597
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Dec 23 15:12:40 2015 +0100
Fix some recently added formats on 64bit
86ec311896dd5d4 adds compiler warnings on 64bit. The build is clean otherwise,
so let's keep it that way.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a2db75f28cfbf096b076058ff89d1…
commit a2db75f28cfbf096b076058ff89d1ef2cac3e6b1
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 22 22:11:27 2015 +0100
Add osmo_prim_op_names[] symbol and _SAP_SS7_BASE define
http://cgit.osmocom.org/osmocom-bb/commit/?id=8db1134c72d629d16368eb493a231…
commit 8db1134c72d629d16368eb493a231d9ec742cf17
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:15 2015 +0100
msgb: Add msgb_test_invariant function
This adds a function that verifies whether a mgsb is consistent.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=86ec311896dd5d481eba7f361ab8d…
commit 86ec311896dd5d481eba7f361ab8dd2f0b043578
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:14 2015 +0100
msgb: Let msgb_hexdump be more tolerant
This patch makes msgb_hexdump accept out of range lXh pointers and
shows info about them instead of aborting the dump entirely.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=cdd05f0ed439787d79ff7a0e04c3f…
commit cdd05f0ed439787d79ff7a0e04c3fc6e2516a64c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 13:26:13 2015 +0100
msgb: Add msgb_resize_area and msgb_copy
These functions originate from openbsc/src/gprs but are generic
msgb helper functions.
msgb_copy: This function allocates a new msgb, copies the data
buffer of msg, and adjusts the pointers (incl. l1h-l4h)
accordingly.
msgb_resize_area:
This resizes a sub area of the msgb data and adjusts the
pointers (incl. l1h-l4h) accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=9e57a5a6974e92a2df73f9009f793…
commit 9e57a5a6974e92a2df73f9009f793c1a1f6206d9
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Dec 21 11:20:14 2015 +0100
some comments / fixed typos
http://cgit.osmocom.org/osmocom-bb/commit/?id=1a87c1b1891262e063d3bc862a8a1…
commit 1a87c1b1891262e063d3bc862a8a1babef943f74
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Dec 14 15:26:07 2015 +0100
LaPDm: Refuse SUSPEND/RESUME/RECONNECT in BTS mode
The primitives for SUSPEND, RESUME and RECONNECT are only permitted on
the MS side of the LAPDm link, not on the BTS side. So we should check
for this and reject, accordingly.
http://cgit.osmocom.org/osmocom-bb/commit/?id=cc6ac4cdc4103cb68a3e161deb49d…
commit cc6ac4cdc4103cb68a3e161deb49dfb64c931adf
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 17 13:22:36 2015 +0100
ns: Force a defined state when sending NS RESET
Currently the state is assumed to remain the same while the reset
procedure is active. While this works correctly in general, a single
unexpected BLOCK_ACK or UNBLOCK_ACK can change the state but will not
stop the reset procedure. The leads to repeated RESET messages, where
the corresponding RESET_ACK is ignored. This is a stable state which
can only be left by manual intervention or by reception of a RESET
message from the peer.
This commit changes the RESET timeout handler to set the state to
BLOCKED/RESET when sending the new NS RESET message.
Note that this should ensure a clean restart even if the state has been
screwed up. It does not fix the handling of BLOCK_ACK or UNBLOCK_ACK
in abnormal cases.
Addresses:
gprs_ns.c:349 NSEI=8895 Tx NS RESET (NSVCI=8895, cause=O&M intervention)
gprs_ns.c:878 NSVCI=8895 Rx NS RESET ACK (NSEI=8895, NSVCI=8895)
gprs_ns.c:887 NS RESET ACK Discarding unexpected message for NS-VCI 8895 from SGSN NSEI=8895
Ticket: OW#1551
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=5ab8e2cdfcdfb932b918405061798…
commit 5ab8e2cdfcdfb932b918405061798e0079223273
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Dec 17 14:13:22 2015 +0100
stats: Fix compiler warning about losing const
stats_statsd.c: In function ‘osmo_stats_reporter_statsd_send_item’:
stats_statsd.c:154:15: warning: initialization discards ‘const’ qualifier from pointer target type
char *unit = desc->unit;
^
http://cgit.osmocom.org/osmocom-bb/commit/?id=0975a7f36c41afcb4e477609b97fe…
commit 0975a7f36c41afcb4e477609b97fe890990782ab
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 17 09:51:53 2015 +0100
ns/stats: Add missing osmo_stat_item_group_free to gprs_nsvc_delete
The stat item group is not removed by gprs_nsvc_delete which will
corrupt the group list.
Addresses:
valgrind tests/gbproxy/gbproxy_test
[...]
==4541== Invalid write of size 4
==4541== at 0x4071ACA: __llist_add (linuxlist.h:65)
==4541== by 0x4071ACA: llist_add (linuxlist.h:81)
==4541== by 0x4071ACA: osmo_stat_item_group_alloc
(stat_item.c:112)
==4541== by 0x407EDFD: gprs_nsvc_create (gprs_ns.c:244)
==4541== by 0x408109D: gprs_ns_instantiate (gprs_ns.c:1388)
==4541== by 0x804CFD3: test_gbproxy_ident_changes
(gbproxy_test.c:1501)
==4541== by 0x805FBD3: main (gbproxy_test.c:5803)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=62f80fccb8a222bd81f0b15b09915…
commit 62f80fccb8a222bd81f0b15b099150dab6206bfc
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Dec 14 20:31:20 2015 +0100
talloc: Depend on libtalloc-dev being present as well
http://cgit.osmocom.org/osmocom-bb/commit/?id=fad5752ab5b91e615dd82365c0663…
commit fad5752ab5b91e615dd82365c0663e38b4540dcd
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Dec 13 11:56:36 2015 +0100
RSL: Add enum + TLV definitions for ip.access style embedded IEs
http://cgit.osmocom.org/osmocom-bb/commit/?id=f4b173cb0c8c5179081a4b82928b3…
commit f4b173cb0c8c5179081a4b82928b375fdf0caf17
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Dec 10 19:50:29 2015 +0100
talloc: Untested change to unbreak build
In case talloc is not installed in the default search path we need
to place @TALLOC_CFLAGS@ into the include directory as well.
http://cgit.osmocom.org/osmocom-bb/commit/?id=771a58feeec15c1e36373f0fe165d…
commit 771a58feeec15c1e36373f0fe165ddf3ba83cbf6
Author: Ruben Undheim <ruben.undheim(a)gmail.com>
Date: Wed Dec 9 20:22:42 2015 +0100
gsm_03_41: Fix structure definitions for big-endian machines
this was detected by debian packaging, as the associated gsm_03_41 test
case fails on big endian machines like ppc.
http://cgit.osmocom.org/osmocom-bb/commit/?id=84c19a9b36c5e416e3df6b42afb5b…
commit 84c19a9b36c5e416e3df6b42afb5b0e8aa8095cc
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 8 14:16:43 2015 +0100
update debian packaging from libosmocore6 to libosmocore7
http://cgit.osmocom.org/osmocom-bb/commit/?id=49a8f88565385107cf008d1f2c013…
commit 49a8f88565385107cf008d1f2c01344a3f165c4d
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 8 14:14:00 2015 +0100
utils: add TALLOC_CFLAGS to build
this is an attempt to fix the FreeBSD build
http://cgit.osmocom.org/osmocom-bb/commit/?id=ac4ed17dbd15ed703583584626d82…
commit ac4ed17dbd15ed703583584626d820f66ea5a17d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Dec 8 10:29:16 2015 +0100
stats: Add OSMO prefix to STAT_ITEM_NOVALUE_ID
This symbol is globally visible and therefore should have an OSMO
prefix like the other identifiers exported by stat_item.h.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=af5bad5ed00f0d21617c34f0e4e96…
commit af5bad5ed00f0d21617c34f0e4e96eb2fd977a02
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 27 18:54:58 2015 +0100
stat: Explicitly support stat_items without unit
Add OSMO_STAT_ITEM_NO_UNIT for stat items without an unit. The
statsd reporter uses gauges ("g") to report them.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=90e614f7ccb0902e6ddb510bb10f7…
commit 90e614f7ccb0902e6ddb510bb10f78eb14a13d94
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Dec 5 23:38:18 2015 +0100
remove our internal copy of talloc, use system libtalloc
Shipping our own private copy of talloc was a good idea in 2008,
when it was not readily available on most target platforms. Today,
the situation is quite different, as it is a standard library on
major Linux distributions.
http://cgit.osmocom.org/osmocom-bb/commit/?id=ee702cd590688c1e65296319c5bc4…
commit ee702cd590688c1e65296319c5bc4c9cf160ba65
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 10 11:38:25 2015 +0100
stats: Add TODO comment to rate_ctr
Currently the counters are scanned twice, once for interval
computation and once for reporting.
This adds a reminder to move the interval computation code to a
special stats reporter which just shall update the fields.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=f13de868be052f96325c337f25453…
commit f13de868be052f96325c337f25453f1d97777005
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 10 11:36:58 2015 +0100
stats/test: Add memory leak check
Adds a rudimentary leak check for the counters and stat items.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=46b703d083a57d7718340f8f71da2…
commit 46b703d083a57d7718340f8f71da29d96ce15170
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 17:25:27 2015 +0100
stats/test: Add test for reporting
This tests uses a dedicated test reported to check several aspects of
the value reporting.
- addition/removal of stats reporter
- addition/removal of counters/items
- setting of max_class
- initial value flush
- updating single counters/items
- reporter retrieval
- enable/disable
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=2e8f9ed5560ac6286b1fe70ade868…
commit 2e8f9ed5560ac6286b1fe70ade868569d30cb392
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 15:48:25 2015 +0100
stats: Reorder functions in stats.c
Due to prior refactoring, the functions do not have an sensible order
in the file. This commit tries to improve that a little bit.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=b6e6bea4ecea4b0769fc56136321f…
commit b6e6bea4ecea4b0769fc56136321f01f553459ba
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 15:33:44 2015 +0100
stats: Move statsd related code into a separate file
This commit moves the stats specific code parts into stats_statsd.c
while keeping the generic parts in stats.c. The code in stats.c no
longer contains references to statsd symbols.
Note that the VTY code still needs to know about every stats reporter
backend.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=5fa0dcc2750a79920d4a6404e960c…
commit 5fa0dcc2750a79920d4a6404e960c50667840058
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 21 11:57:06 2015 +0100
configure: It should be --with-system-talloc, not --enable-system-talloc
As we are making a decision whether we should use an existing system
library, we call it --with-system-talloc, rather than
--enable-system-talloc.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d086f2119509af2e26a0d7a587b9e…
commit d086f2119509af2e26a0d7a587b9e176df814998
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 21 11:38:09 2015 +0100
configure.ac: Use AS_IF() instead of shell-if for PKG_CONFIG
https://autotools.io/pkgconfig/pkg_check_modules.html
> If you have the first call to PKG_CHECK_MODULES inside a bash
> conditional block, the expansion of PKG_PROG_PKG_CONFIG will also be
> conditional
> You can solve this problem in two ways; you can either explicitly call
> PKG_PROG_PKG_CONFIG outside of any conditional, forcing checking for
> pkg-config as soon as possible; or you can rewrite your conditionals
> to use the proper syntax
http://cgit.osmocom.org/osmocom-bb/commit/?id=a10ef29b47123a60755b59befca9b…
commit a10ef29b47123a60755b59befca9b2d45f3e29fa
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 21 00:41:43 2015 +0100
use system-wide libtalloc with --enable-system-talloc
This introduces a new configure flag by which the libosmocore-internal
talloc code is not compiled, but rather a system-wide libtalloc is used.
When we started openbsc/libosmocore in 2008, libtalloc was not widely
present on systems yet. This has changed meanwhile, and we should
simply use the system-wide library
http://cgit.osmocom.org/osmocom-bb/commit/?id=b32a19467ffde540b059bf166a378…
commit b32a19467ffde540b059bf166a378decf07701b8
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Nov 20 10:22:14 2015 +0100
stat_item.c: Fix compiler warnings
CC stat_item.lo
stat_item.c: In function 'osmo_stat_item_group_alloc': stat_item.c:84:28: warning: cast to pointer from integer of different
size [-Wint-to-pointer-cast]
group->items[item_idx] = (void *)items_size;
^
stat_item.c:98:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
((uint8_t *)items + (int)group->items[item_idx]);
^
http://cgit.osmocom.org/osmocom-bb/commit/?id=a99d45ac5960c25818b980683cb59…
commit a99d45ac5960c25818b980683cb5920ffd25588c
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Nov 12 13:48:23 2015 +0100
vty: Don't call exit() but rather use OSMO_ASSERT()
This was pointed out by Jaroslav Skarvada during fedora packaging,
and he has a valid point...
http://cgit.osmocom.org/osmocom-bb/commit/?id=2b82c1c6c887656e2fc8c2ee4456a…
commit 2b82c1c6c887656e2fc8c2ee4456ac93d5834e03
Author: Jaroslav Škarvada <jskarvad(a)redhat.com>
Date: Wed Nov 11 16:02:54 2015 +0100
fix FSF address in sources/headers
Signed-off-by: Jaroslav Škarvada <jskarvad(a)redhat.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=abc46af90fde9e9435dee5f4f472a…
commit abc46af90fde9e9435dee5f4f472aec3f68d3353
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 9 21:34:43 2015 +0100
debian: Make a new minor release
http://cgit.osmocom.org/osmocom-bb/commit/?id=01e8c91df517fbf27d769a07630ac…
commit 01e8c91df517fbf27d769a07630ac8177cf0328d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 14:13:23 2015 +0100
stats: Fix not reported stat item values
Currently the global stat item index is being advanced in
osmo_stat_item_group_handler, so that the second and further groups
in the list will skip new item values.
This commit moves the call to osmo_stat_item_discard_all into
osmo_stats_report to a place where all groups have been processed
already.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=8a97cb911122f112a1a829f6f5d2b…
commit 8a97cb911122f112a1a829f6f5d2be3922153a74
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 11:39:42 2015 +0100
stats: Fix handling of multiple resporters
Currently the reporter loop is aborted, if the event would be ignored
due to an insufficient max_level. Thus the reporters that happen to
be stored afterwards would be skipped even if their level were
sufficient.
This commit replaces the conditional 'return' statement by a
considtional 'continue' statement to ensure the processing of the
list tail.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=aed7c125fdfe743a78cb3fd8123af…
commit aed7c125fdfe743a78cb3fd8123af5257a900df9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 11:25:12 2015 +0100
stats: Send all values on reporter update
Currently only counter changes and new item values are being
reported. This makes it cumbersome to configure reporting clients,
since there is nothing like a list of all parameters.
This commit changes this behaviour such that all currently existing
counters and items that would be reported eventually, are passed to
the reporter when it has been reconfigured or enabled. If a counter
has not been incremented, 0 is sent. If a stat item value has not
been added, the last item value (or the default value if there is
none) is resent again.
Note that this will not catch transient counters/items that will be
created later on, e.g. triggered by new peers or subscribers.
To just force this kind of dump on a running reporter, it is
sufficient to invoke the 'enable' command in its configuration node.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=916423ef9585c7042730fdb17f55a…
commit 916423ef9585c7042730fdb17f55afc376565d32
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 10:52:19 2015 +0100
stats: Fix name prefix handling
Currently the having an unset prefix leads to an abort() in the
statsd reporter due to an fprintf format string error. In addition
the prefix cannot be reset to its initial state (NULL) by using 'no
prefix', which just sets the prefix to the empty string, causing a
single leading dot to appear in front of the name.
This commit changes the implemenation to consistly use NULL for
the unset name prefix ('no prefix') and to handle this case correctly
in the statsd reporter.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=834819471a024a98cf6062f1e20c7…
commit 834819471a024a98cf6062f1e20c75a9b9e26f88
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Nov 7 21:10:01 2015 +0100
stats: Document the level in show stats level options
Potentially Fixes:
<command id='show stats level (global|peer|subscriber)'>
<param name='subscriber' doc='(null)' />
http://cgit.osmocom.org/osmocom-bb/commit/?id=aab4a2497c59d83c396881aaa661a…
commit aab4a2497c59d83c396881aaa661a054978f8f7c
Author: Alexander Huemer <alexander.huemer(a)xx.vu>
Date: Fri Nov 6 20:55:24 2015 +0100
osmo-sim-test: add missing include
http://cgit.osmocom.org/osmocom-bb/commit/?id=eed4695d062a64c78340d24d53ae7…
commit eed4695d062a64c78340d24d53ae7066e6c7c1fd
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Nov 4 14:48:13 2015 +0100
debian: Roll a new release with the GPRS NS counter fix
http://cgit.osmocom.org/osmocom-bb/commit/?id=495b0dbd24627a9289e9bdb8ef2f8…
commit 495b0dbd24627a9289e9bdb8ef2f80af6af3445f
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Nov 4 14:39:37 2015 +0100
gprs-ns/stats: When the NSVCI is updated, update the stats counter
The NS object is created with an unknown identity and only after
the reset procedure has progressed (completed?) we know the real
ID for this peer. Before nobody has looked at the idx values (this
could have been seen with the CTRL interface) but with statsd the
wrong NSVCI becomes obvious.
Add routines to update the idx and I don't know if the change of
idx is causing any issues but we will find that out soon.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6e149b1f1aceb86e694e090b5ba4c…
commit 6e149b1f1aceb86e694e090b5ba4ccb349edcbf2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Nov 4 10:23:57 2015 +0100
debian: Make new minor release with the NS bugfix
http://cgit.osmocom.org/osmocom-bb/commit/?id=59b90bc44401dc0e4c5004b0fec67…
commit 59b90bc44401dc0e4c5004b0fec677106bce8871
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 3 16:21:40 2015 +0100
stats/vty: Add selective show stats command
Currently there is only the 'show stats' command which shows all
counter and stat_item values. This can lead to many lines of output
if there are per-subscriber rate counters.
The new command added by this commit allows it to only show groups of
a certain level (class_id), similar to the 'level' configuration
command for stats reporter.
The new command is
show stats level (global|peer|subscriber)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=fed2a488b94fc24df4f5548f98a71…
commit fed2a488b94fc24df4f5548f98a71bb98920a66a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 3 16:18:56 2015 +0100
ns/stats: Fix class_id of "NSVC Peer Statistics" rate_ctr group
Currently the class_id is not set which effectively puts these groups
into the 'subscriber' class.
This commit adds the missing initialisation value.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=be37fb7db4651f245994fa73008b4…
commit be37fb7db4651f245994fa73008b4aa92c21c14f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 3 15:21:34 2015 +0100
stats/test: Add tests to check VTY configuration
This commit adds tests to verify the stats related VTY configuration
commands.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ca6602f476775e1b55c5a1d41bc32…
commit ca6602f476775e1b55c5a1d41bc323c49b9e4290
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 3 13:47:11 2015 +0100
vty/test: Refactor vty creation/deletion into separate functions
Currently this is part of the only test function that uses the
vty directly.
In preperation for more such test cases, this commit moves this code
into separate functions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ee2657f6af4b81f98cfdfd900a82d…
commit ee2657f6af4b81f98cfdfd900a82d9a350ff3642
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 3 11:49:31 2015 +0100
test: Remove unneeded linking to libosmovty.la
The addition of libosmovty.la to several test cases as done in
commit 738d9e22108a8e47245 (stats: Add vty_out_stat_item_group)
is not needed.
This commit removes them.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=bb4ae64fbbc30bf626792df2f2e68…
commit bb4ae64fbbc30bf626792df2f2e68afb5cda6e21
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Nov 3 11:36:18 2015 +0100
debian: Install libosmoctrl0 too when installing the dev package
http://cgit.osmocom.org/osmocom-bb/commit/?id=8649d57f507d359c99a89654aac7e…
commit 8649d57f507d359c99a89654aac7e19ce22db282
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Nov 3 09:30:52 2015 +0100
misc: Prepare the release of libosmocore 0.9.0
Bump the ABI version of libosmovty and we need to do this
recursively to force rebuilds of our software.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c337693c4ca164833e120624af3c0…
commit c337693c4ca164833e120624af3c0960180725ee
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Aug 21 19:56:54 2015 +0000
stats: Fix build on FreeBSD
include stdint.h for int64_t and use netinet/in.h and not
netinet/ip.h for getting sockaddr_in and such.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3f838b717e831b99966fc4277f963…
commit 3f838b717e831b99966fc4277f963b6c57340f6d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Aug 20 18:17:15 2015 +0000
timer: Fix compiler warning about timeval
timer.c:27:23: warning: tentative definition of variable with internal linkage has incomplete
non-array type 'struct timeval' [-Wtentative-definition-incomplete-type]
static struct timeval nearest;
^
timer.c:27:15: note: forward declaration of 'struct timeval'
static struct timeval nearest;
http://cgit.osmocom.org/osmocom-bb/commit/?id=07cf861e25d2f2359e55ec803256c…
commit 07cf861e25d2f2359e55ec803256c2211eda0a12
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Nov 2 20:18:33 2015 +0100
gtphub: add OSMO_VTY_PORT_GTPHUB.
This is for gtphub, being developed in openbsc.git.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/osmocom-bb/commit/?id=667e83d71eebba70817ab035ef207…
commit 667e83d71eebba70817ab035ef207a52785bc129
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Nov 2 20:18:11 2015 +0100
fix some typos
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/osmocom-bb/commit/?id=d7b0577d7d30139491b5cfeffb467…
commit d7b0577d7d30139491b5cfeffb467440f9e88818
Merge: c84851bc 8f0374f7
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 2 15:57:34 2015 +0100
Merge branch 'jerlbeck/wip/stats'
* This adds a new counter type (to measure time or delay)
* A statsd reporting backend. This can be fed into graphite
or similar tools.
* A periodic log backend for performance values
http://cgit.osmocom.org/osmocom-bb/commit/?id=8f0374f7521376bdb721e821047e8…
commit 8f0374f7521376bdb721e821047e8a6a4a727283
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 2 15:53:09 2015 +0100
stats: Fix handling of the no mtu command
For the atoi we need to pass the val as a string. This means
we need to write "0" which then gets parsed to 0.
[src/vty/stats_vty.c:90]: (error) Possible null pointer dereference: val
http://cgit.osmocom.org/osmocom-bb/commit/?id=7921975989a1844546669a77ecdc9…
commit 7921975989a1844546669a77ecdc9160fdef2282
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 2 15:50:32 2015 +0100
stats: Do not assign the wrong addresss
we need to put the default value into inaddr and not put a
32bit value into the addr pointer.
Spotted by cppcheck:
[src/stats.c:231]: (error) Uninitialized variable: inaddr
http://cgit.osmocom.org/osmocom-bb/commit/?id=837e940627cd8dc469e65980b3b48…
commit 837e940627cd8dc469e65980b3b48c9539a55440
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 2 15:44:26 2015 +0100
stats: Remove warnings about never read variables
Nothing is being done with these return values. Remove them
for now and update the TODO entry that is present at two of
the three places.
stats.c: In function ‘rate_ctr_handler’:
stats.c:570:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
int rc;
^
stats.c: In function ‘osmo_stat_item_handler’:
stats.c:617:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
int rc;
^
stats.c: In function ‘handle_counter’:
stats.c:651:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
int rc;
http://cgit.osmocom.org/osmocom-bb/commit/?id=79125ecf7d54b04cc56818b6dd998…
commit 79125ecf7d54b04cc56818b6dd99813d0a4daf89
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 2 15:17:50 2015 +0100
log: Add new DLSTATS log level
This log level is used by the stats subsystem log reporter to report
statistics to level INFO. Note that the default level of DLSTATS is
NOTICE.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=bc9d9aced8c174bbb5fc265ec7466…
commit bc9d9aced8c174bbb5fc265ec746621d31344be0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 2 14:49:35 2015 +0100
stats: Limit reporting by class id
This commit adds class_id fields to the rate_ctr and stat_item group
descriptions. The stats reporter code is extended to only process
groups whose class_id does not exceed a per reporter max_class level.
If the class_id is not set, the code assumes 'global' for groups with
idx == 0 and 'subscriber' otherwise.
The following vty command is added to config-stats:
level (global|peer|subscriber) Set the maximum group level
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=16fe8dab7c1fede87f6bdbfbbcbf1…
commit 16fe8dab7c1fede87f6bdbfbbcbf19f64d60648a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 2 11:30:01 2015 +0100
stats: Report group indices as unsigned int
Currently the unsigned group index value is silently being cast to
(signed) int in the log and statsd reporter code. If the resulting
value is negative (which can happen for instance with MMCTX
counters), the index is assumed to be unset.
This commit changes the affected types to unsigned. The index value 0
is then the only value indicating an unset group.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=34eec7da8dd91c2e812863601ca5f…
commit 34eec7da8dd91c2e812863601ca5f787d6589ecb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 2 10:50:50 2015 +0100
vty: Add reserved nodes to enum node_type
Currently every time a node is added to enum node_type, this
constitutes an ABI change, since _LAST_OSMOVTY_NODE will get
incremented accordingly. In this case, every project that adds new
node type based on that value will have to be recompiled.
This commit adds 4 spare node type values, which can be replaced
one-by-one by new real types until they are exhausted to avoid
this kind of ABI change.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=fc9533d6c4bde795dc0e18f02f91f…
commit fc9533d6c4bde795dc0e18f02f91f54ab92888a2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 29 00:55:58 2015 +0100
stats: Add osmo_ name prefix to identifiers
Since the the stat_item and stats functions and data types are meant
to be exported, they get an osmo_ prefix.
Sponsored-by: On-Waves ehf
[hfreyther: Prepended the enum values too. This was requested by
Jacob]
http://cgit.osmocom.org/osmocom-bb/commit/?id=bc4f7ae512b32fa4b569dfc5242d0…
commit bc4f7ae512b32fa4b569dfc5242d0b7a5da3f81b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 28 21:47:45 2015 +0100
stats: Add log reporter
This reporter passes the measurement values to the logging subsystem
as DSTATS (which is currently DLGLOBAL) level INFO messages.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=490b38f57a24726f3e3493fc3500c…
commit 490b38f57a24726f3e3493fc3500cda526c5d0aa
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 27 15:10:28 2015 +0100
stats: Use function pointers in reporter objects
Currently case statements are used to select the right reporter
functions. This makes it difficult to add new reporter types,
especially if they are not going to reside in the same file.
This commit introduces per reporter function pointer for
open, close, send_count, and send_item. They are checked for
non-NULL before being called or skipped.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ed197fd4f923512fca5b93b90c213…
commit ed197fd4f923512fca5b93b90c2132845896fa59
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 27 14:43:24 2015 +0100
stats: Make net config optional
To support reporters without network configuration, this commit
introduces the have_net_config flag to provide corresponding error
messages.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=4aa11770622ae9009074d68cc8c34…
commit 4aa11770622ae9009074d68cc8c340821b19adf3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 27 11:55:20 2015 +0100
stats: Add missing mtu command to 'write' output
Currently the config_write_stats_reporter function does not output
the mtu value, which is fixed by this commit.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=d01acfcc75a6c5798a95a8ccca9be…
commit d01acfcc75a6c5798a95a8ccca9be18eba65a0bf
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 26 16:22:45 2015 +0100
stats: Support statsd Multi-Metric Packets
If the MTU is given, combine several messages into a single UDP
packet until the limit is reached. Flush all reporters after the
values have been scanned.
New vty commands (node config-stats):
mtu <100-65535> Enable multi-metric packets and set the maximum
packet size (in byte)
no mtu Disable multi-metric packets
Note that single messages that are longer than the given MTU (minus
28 octets protocol overhead) will be dropped.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=c8f47b600f8e2ad21266d4c27e960…
commit c8f47b600f8e2ad21266d4c27e960e477e5fe35c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 26 14:42:05 2015 +0100
stats: Add support for osmo_counters
This commit changes the reporting code to also show all modified
osmo_counter values. Since there is no grouping of these values, the
name string just consists of the optional prefix and the counter
name.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=80db4ec3875b0de7f06de769881d6…
commit 80db4ec3875b0de7f06de769881d6c5d4b713f2d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 26 14:39:08 2015 +0100
core: Add difference function to osmo_counter
The osmo_counter_difference returns the counter value difference
since the last call of this function with the given counter object.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=c27671c10935ee384d03a87170c3f…
commit c27671c10935ee384d03a87170c3f31ab435da07
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 26 12:32:07 2015 +0100
stats: Report stat item values
Currently only rate counter are being supported.
This commit adds support for stat items. All groups are polled for
changed values.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=b1dbfb4c4179a62cd4b761ebdc7a3…
commit b1dbfb4c4179a62cd4b761ebdc7a3c2de5bdc0d9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 26 11:58:38 2015 +0100
stats: Implement timer based reporting
This calls stats_flush in regular intervals which polls the
statistical values and calls the active reporters when values have
changed.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=adc900e0e38373193c8451c0310fe…
commit adc900e0e38373193c8451c0310fe742d62c2c8e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 20 19:05:52 2015 +0200
stats/vty: Add stats configuration
This commit provides stats configuration similar to the log
configuration.
The following vty commands are added to the config node:
stats reporter statsd Create/Modify a statsd reporter
no stats reporter statsd Remove a statsd reporter
To actually configure a reporter, the config-stats node is entered
when the "stats reporter" command has succeeded. The following new
vty commands are available there:
local-ip ADDR Set the IP address to which we bind locally
no local-ip Do not bind to a certain IP address
remote-ip ADDR Set the remote IP address to which we connect
remote-port <1-65535> Set the remote port to which we connect
prefix PREFIX Set the item/counter name prefix
no prefix Do not use a prefix
enable Enable the reporter
disable Disable the reporter
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=95bf828003b065f00a78144296072…
commit 95bf828003b065f00a78144296072a9730cbf7bc
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 20 19:05:52 2015 +0200
stats: Add the reporting framework
This commit provides the stats reporting framework that can manage
several types of measurement reporters. Initially support for
rate_ctr and the statsd protocol is included.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=45513e6040195f5494d40a2750de4…
commit 45513e6040195f5494d40a2750de4dac7037593f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 19 15:14:13 2015 +0200
stats/vty: Add stats_vty.c
This file will contain the VTY code related to statistics.
This commit adds a minimal file with just as single VTY command:
- show stats This command shows all statistical values
To enable this and future commands, the main program needs to call
stats_vty_add_cmds().
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=7211fe157e1107d4a9c04a0ecf494…
commit 7211fe157e1107d4a9c04a0ecf494a7b9633c400
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 19 15:11:50 2015 +0200
stat/vty: Add vty_out_statistics_full to show all statistics
This functions shows the state of all osmo_counters, stat_item
groups, and counter groups.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=aec583f68786f91c3f0d76a8f8706…
commit aec583f68786f91c3f0d76a8f8706c85aaca07a8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 19 15:06:01 2015 +0200
stat/vty: Use the iterator algorithms to show ctrg and statg
Currently the groups for stat_items and counter are iterated
manually.
This commit makes use of the new iterator functions to access the
single elements via handlers.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=e5b0fe2e3c84dd0de7021d65d4163…
commit e5b0fe2e3c84dd0de7021d65d416356612db4260
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 19 15:00:59 2015 +0200
core: Update osmo_counters_for_each doc
Fix type and add a note about the semantics of the handler's return
code.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=c6a7108828bf98ebcaf31d24bd8d7…
commit c6a7108828bf98ebcaf31d24bd8d789afdd4da94
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 19 14:04:38 2015 +0200
stats: Add stat_item_for_each functions
This commit adds the following functions:
stat_item_for_each_group Call a handler for each group
stat_item_for_each_item Call a handler for each item of a
group
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=423c1e5a4fc7ad2cd5e95e852b778…
commit 423c1e5a4fc7ad2cd5e95e852b778c7e2c892bc1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 19 13:45:42 2015 +0200
core: Extend rate_ctr by helper functions
For global value reporting, some additional helper functions are
needed. The statsd protocol expects differential counter values,
which are currently not provided by rate_ctr (except for s/m/h/d
intervals).
This commit adds several helper functions to rate_ctr:
- rate_ctr_difference returns the counter delta since the last
call to this function for a given counter
- rate_ctr_for_each_counter
iterates through each counter of a group
- rate_ctr_for_each_group
iterates through all globally registered
counter groups
Note that the rate_ctr_difference function can only be used by a
single backend, since it modifies the 'previous' field in the
rate_ctr obj.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=b27b352e937dd0760da1e7fb05f92…
commit b27b352e937dd0760da1e7fb05f9207be05702b8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 12 18:47:09 2015 +0200
stats: Use a global index for stat item values
Currently each stat item has a separate index value which basically
counts each single value added to the item and which can be used by
a reporter to get all new values that have not been reported yet.
The drawback is, that such an index must be stored for each stat
item.
This commit introduces a global index which is incremented for each
new stat item value. This index is then stored together with the item
value. So a single stored index per reporter is sufficient to make
sure that only new values are reported.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=0a1400fc8311268d0a66bb20e0620…
commit 0a1400fc8311268d0a66bb20e0620e546e8d11c8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 6 15:23:25 2015 +0200
ns: Add statistics for some events
The following counters are added to the ns.nsvc counter group:
lost.alive The number of missing ALIVE ACK messages
lost.reset The number of missing RESET ACK messages
The following items are added to the ns.nsvc stat item group:
alive.delay The time in ms between sending ALIVE and
receiving the next ALIVE ACK
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=738d9e22108a8e472458fad42509f…
commit 738d9e22108a8e472458fad42509fd8d96994d6c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 6 15:21:56 2015 +0200
stats: Add vty_out_stat_item_group
This functions dumps a whole stat item group to the VTY.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=9732cb4a92a883c7e9f7dcd928b6e…
commit 9732cb4a92a883c7e9f7dcd928b6e22976a797ca
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 1 20:43:53 2015 +0200
stats: Add stat_item for value monitoring
This commit adds instrumentation function to gather measurement
and statistical values similar to counter groups.
Multiple values can be stored per item, which can be retrieved in
FIFO order. Getting values from the item does not modify its state to
allow for multiple independant backends (e.g. VTY and statd).
When a new value is set, the oldest value gets silently overwritten.
Lost values are skipped when getting values from the item.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=c84851bccc2e5e60536afa474a5f1…
commit c84851bccc2e5e60536afa474a5f13134a3b79c9
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Oct 9 00:01:06 2015 +0200
comments
http://cgit.osmocom.org/osmocom-bb/commit/?id=5eeb17a0178a72d291cb99f2391d8…
commit 5eeb17a0178a72d291cb99f2391d8ea7e9b65dd4
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Sep 23 23:18:15 2015 +0200
ipaccess: add OAP proto_ext (in design).
http://cgit.osmocom.org/osmocom-bb/commit/?id=3de7b05d8557a60eaa5a4dd857aa3…
commit 3de7b05d8557a60eaa5a4dd857aa3467cecd105c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Sep 23 23:16:53 2015 +0200
utils: add 'returns' doc to osmo_hexparse().
http://cgit.osmocom.org/osmocom-bb/commit/?id=c2ddc4f5550e4081575fbcbaf37f6…
commit c2ddc4f5550e4081575fbcbaf37f6b3dafe7c05e
Author: Jan Engelhardt <jengelh(a)inai.de>
Date: Wed Sep 16 14:32:31 2015 +0200
build: have a disable-static build succeed
When using configure --disable-static, no libosmogsm.a will be
created, and the tests fail to link because symbols like _a5_3 and
_a5_4 are not exported through the only remaining libosmogsm.so.
A method to overcome this is an intermediate private non-distributed
library, examples of which are present in e.g. libabc, kmod and
systemd.
With this, disable-static can now be the default and practical compile
time be halved.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d452a48ac66d8e99a562c91660f37…
commit d452a48ac66d8e99a562c91660f371270d9c6b21
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Aug 23 17:38:26 2015 +0200
Prepare new upstream release
http://cgit.osmocom.org/osmocom-bb/commit/?id=69b1b8bea6cabb34f9a107fa549cd…
commit 69b1b8bea6cabb34f9a107fa549cd91956122c24
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Wed Aug 19 11:15:14 2015 +0200
build: Enable subdir-objects
This fixes warning (and even build on some newer automake).
This should now work in the CI as well thanks to the fix for tests.
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=0d727855686c9e857b608d7b8b22b…
commit 0d727855686c9e857b608d7b8b22bfdf7c618b07
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Wed Aug 19 11:14:23 2015 +0200
tests: Don't reference file in src/ to test hidden func. Use static link.
Taken from:
https://qiaomuf.wordpress.com/2011/03/27/handling-unit-test-with-c-visibili…
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=1a8c4e05fbf51662e3ffe47ed64c2…
commit 1a8c4e05fbf51662e3ffe47ed64c20f4752e2563
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Aug 16 17:56:25 2015 +0200
Introduce gsm48_mi_type_name() function
http://cgit.osmocom.org/osmocom-bb/commit/?id=1f6aad1c042f3040ac62696fc38c6…
commit 1f6aad1c042f3040ac62696fc38c65a875862b6a
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Aug 15 19:51:45 2015 +0200
Add G-RNTI derived TLLI types defined in 23.003
http://cgit.osmocom.org/osmocom-bb/commit/?id=538ff49837c95e2ba6514356c8631…
commit 538ff49837c95e2ba6514356c863112569128532
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Aug 18 13:17:53 2015 +0200
Revert "configure.ac: Add subdir-objects"
This reverts commit 7c942ba1475a366cc7c8a129fbdd335166ce21c6.
With automake 1.14 and using the above option the distclean
will fail with:
Making distclean in tests
gmake[2]: Entering directory '/home/builder/source/workspace/libosmocore/label/FreeBSD_amd64/libosmocore-0.8.0.47-7c94/_build/tests'
Makefile:848: ../src/gsm/.deps/a5.Po: No such file or directory
Makefile:849: ../src/gsm/.deps/kasumi.Po: No such file or directory
gmake[2]: *** No rule to make target '../src/gsm/.deps/kasumi.Po'. Stop.
gmake[2]: Leaving directory '/home/builder/source/workspace/libosmocore/label/FreeBSD_amd64/libosmocore-0.8.0.47-7c94/_build/tests'
Makefile:506: recipe for target 'distclean-recursive' failed
gmake[1]: *** [distclean-recursive] Error 1
gmake[1]: Leaving directory '/home/builder/source/workspace/libosmocore/label/FreeBSD_amd64/libosmocore-0.8.0.47-7c94/_build'
Makefile:714: recipe for target 'distcheck' failed
As we are not required to use the option, let's fix the build
http://cgit.osmocom.org/osmocom-bb/commit/?id=7c942ba1475a366cc7c8a129fbdd3…
commit 7c942ba1475a366cc7c8a129fbdd335166ce21c6
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Aug 15 10:49:46 2015 +0200
configure.ac: Add subdir-objects
Apparently this is required under latest autotools versions.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a9e5252128d1d871739f067fe9b0c…
commit a9e5252128d1d871739f067fe9b0ca9b9a75a6f7
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Aug 2 02:14:07 2015 +0000
vty: Change API to have node installation be done by int
We are mixing enums and hope that no short-enums are used. This
is leading to a lot compiler warnings generated by clang. Change
the API to work with integers.
Porting:
The go_parent_cb implementations in the applications need to be
fixed. The API change leads to a compile time warning.
Fixes:
abis_om2000_vty.c:46:2: warning: implicit conversion from enumeration type 'enum bsc_vty_node' to
different enumeration type 'enum node_type' [-Wenum-conversion]
OM2K_NODE,
^~~~~~~~~
http://cgit.osmocom.org/osmocom-bb/commit/?id=c136da587fc2fafff1f649828eae5…
commit c136da587fc2fafff1f649828eae5c996c345017
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Aug 1 20:19:13 2015 +0200
release: Prepare the 0.8.2 release
I have kind of used 0.8.1 by accident already so let us move
to 0.8.2 now.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c1cb75eff5b060da9e6d43521e491…
commit c1cb75eff5b060da9e6d43521e4913a8bf4e74fc
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jun 18 13:21:30 2015 +0200
bssgp: Fix IMSI buffer size (Coverity)
Currently the size of the IMSI pointer is used instead of the size of
the talloc'ed buffer.
This commit changes the call to gsm48_mi_to_string to use the same
value that has been used with talloc_zero_size(). The length is
changed to 17 since that value is used for GSM_IMSI_LENGTH in
openbsc.
Fixes: Coverity CID 1040663
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=2c58197e5d717c5eb24e2b8cecac4…
commit 2c58197e5d717c5eb24e2b8cecac43c2afdff22a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jun 18 11:51:34 2015 +0200
bssgp/test: Add missing START/END printfs
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=7f31c90b80c08fbfe2d84d70d3974…
commit 7f31c90b80c08fbfe2d84d70d397402fdb38b94c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jun 4 08:39:34 2015 +0200
ipa: Add libosmogsm.map entry for ipa_ccm_idtag_parse_off
Addresses:
CCLD utils/utils_test
utils_test.o: In function `test_idtag_parsing':
git/libosmocore/tests/utils/utils_test.c:64: undefined reference to `ipa_ccm_idtag_parse_off'
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=f558ed4bb9c0f00997b8f97c2b251…
commit f558ed4bb9c0f00997b8f97c2b251a574c1a64c4
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Jun 2 15:52:06 2015 +0200
ipa: Properly parse LV stream of a ID_GET request
For some reason the structure is closer to be a LV (length
and value). The value is actually a tag but it is counted
inside the length. Introduce an overload of the parse function
to provide an offset for the length. This will be taken from
the returned length.
http://cgit.osmocom.org/osmocom-bb/commit/?id=91ff17c9ef7dd4a29bb13d6b99951…
commit 91ff17c9ef7dd4a29bb13d6b9995100ffc65b72a
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue May 26 00:11:37 2015 +0800
osmo-auc-gen: '-a' is already the algorithm. Fix the help
http://cgit.osmocom.org/osmocom-bb/commit/?id=a6ea50c4ff58d8389b40ca6169c3c…
commit a6ea50c4ff58d8389b40ca6169c3ca826500abf2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon May 25 14:17:29 2015 +0200
debian: New development release with APN changes for the SGSN
http://cgit.osmocom.org/osmocom-bb/commit/?id=908085ccbc6383e95f2c80134bcaf…
commit 908085ccbc6383e95f2c80134bcaf2e9816b7187
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Oct 1 16:18:11 2014 +0800
Add APN utility function to libosmogsm
The current functions are used to 'qualify' an APN from the
user-supplied APN name (name identifier) towards the fully-qualified
APN name which is used in the .grps DNS zone.
http://cgit.osmocom.org/osmocom-bb/commit/?id=0d86c21f6af7452291f4148c166e1…
commit 0d86c21f6af7452291f4148c166e145fb65dc0b9
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun May 17 19:55:53 2015 +0200
build: Fix the building of tests as well
In file included from ../../include/osmocom/core/msgb.h:25:0,
from ../../tests/sms/sms_test.c:31:
../../include/osmocom/core/bits.h:6:35: fatal error: osmocom/core/bit16gen.h: No such file or directory
#include <osmocom/core/bit16gen.h>
http://cgit.osmocom.org/osmocom-bb/commit/?id=9eb1c800205b921c8e471c90e9fe8…
commit 9eb1c800205b921c8e471c90e9fe8c5c4108aef0
Author: Andreas Rottmann <a.rottmann(a)gmx.at>
Date: Sun May 17 16:31:54 2015 +0200
build: Fix out-of-tree builds
Fixes:
In file included from ../../../include/osmocom/core/msgb.h:25:0,
from ../../../include/osmocom/sim/sim.h:4,
from ../../../src/sim/reader_pcsc.c:30:
../../../include/osmocom/core/bits.h:6:35: fatal error: osmocom/core/bit16gen.h: No such file or directory
#include <osmocom/core/bit16gen.h>
In file included from ../../include/osmocom/core/msgb.h:25:0,
from ../../utils/osmo-sim-test.c:26:
../../include/osmocom/core/bits.h:6:35: fatal error: osmocom/core/bit16gen.h: No such file or directory
#include <osmocom/core/bit16gen.h>
http://cgit.osmocom.org/osmocom-bb/commit/?id=16082fd3cda0ced8f22736e923943…
commit 16082fd3cda0ced8f22736e92394348ee2ecfda3
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed May 6 17:58:07 2015 +0200
debian: Bump version for new local packages
http://cgit.osmocom.org/osmocom-bb/commit/?id=9385d1e01bd05c7099e3e441248ce…
commit 9385d1e01bd05c7099e3e441248ce0b10a6d02e2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed May 6 09:29:32 2015 +0200
bssgp: Fix bssgp_tx_fc_bvc parameter type
Currently large values for Bmax default MS get sliced since a uint16_t is
used as the type of the corresponding parameter of bssgp_tx_fc_bvc.
GSM 48.018, 11.3.2 which in turn refers to 11.3.5 specifies a maximum
of 6MB (0xffff * 100).
This commit changes the type to uint32_t to cover the full value
range.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=455d34f4767df3bcd0eccdd4ac42a…
commit 455d34f4767df3bcd0eccdd4ac42a755c016e0ed
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon May 4 07:44:43 2015 +0200
bssgp/test: Fix bssgp-fc test
The fix in the commit "bssgp: Fix call to llist_entry in
fc_queue_timer_cfg" prevents the flow control code from generating
certain logging messages ("-BSSGP-FC: fc_timer_cb() but still not
able to send PDU of 10 bytes") during the tests. This breaks the test
suite, since the update of the correseponding stderr output file
misses.
This commit updates the bssgp_fc_tests.err file accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=780bba625d2d09478527ec6038f0f…
commit 780bba625d2d09478527ec6038f0f6e15eb6e651
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat May 2 07:59:00 2015 +0200
linuxlist: Remove casting of ptr from container_of macro
The cast is not present in the original macro and was added
in OpenBSC with commit (be68f6fc6cde1367a4481d2e774a64e2cd657267)
to help using the header with C++. Due the recent issue in
the bssgp flow control code, let's remove the cast to see
wrong pointer usage. In case C++ code doesn't compile anymore
we can see how to add a cast back to it.
Change was proposed by Michael McTernan
http://cgit.osmocom.org/osmocom-bb/commit/?id=97319359849cb21342a3243c6202d…
commit 97319359849cb21342a3243c6202def1cd18bc94
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Apr 30 19:28:03 2015 +0200
bssgp: Fix call to llist_entry in fc_queue_timer_cfg
Currently the DL sometimes hangs and sometimes a lot of messages
(still not able to send PDU) are logged. This is caused by an invalid
timer delay computation, setting msecs either to 0 or to some big value.
This is due to an '&' operator at the wrong place, accessing some
parts in fc instead of the first element of the list.
This commit fixes that issue.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=580af4be0023a669d1b756f0f6180…
commit 580af4be0023a669d1b756f0f6180eed5ea98144
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Apr 29 15:00:30 2015 +0200
bssgp: Fix encoding of BVC_FLOW_CONTROL
Currently all 2 byte IE of the message are transmitted in the little
endian byte ordering.
This commit adds htons to the encoding expressions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=1bda44213ed90ffd00f9791d8eeea…
commit 1bda44213ed90ffd00f9791d8eeea8179fe02594
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Apr 29 15:00:29 2015 +0200
bssgp: Fix output of the VTY 'show bssgp stats' command
The output is terminated by a '\n' instead of VTY_NEWLINE.
This is fixed by the commit.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ad69f89b529e0cdc235406802448c…
commit ad69f89b529e0cdc235406802448c37fcb61efda
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Apr 16 21:23:49 2015 +0200
debian: Build new version
http://cgit.osmocom.org/osmocom-bb/commit/?id=0f40ae12c87c3ddf4f93aa5c16e3b…
commit 0f40ae12c87c3ddf4f93aa5c16e3be84b288f220
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Apr 13 09:21:05 2015 +0200
osmo_static_assert: Put back the typedef in the code
In OSX the int declares linkage and for libosmo-abis we have
two static asserts with the same name in two different compilation
units. When adding the "unused" attribute I removed the typedef.
I verified with a gcc 4.9.2 that no new warnings will be shown
when compiling libosmo-abis.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6b1faf73628f3a8cc94a360600f1c…
commit 6b1faf73628f3a8cc94a360600f1c4e6c76ca461
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Apr 11 19:33:10 2015 +0200
logginrb: Fix compiler warning about fprintf
loggingrb/loggingrb_test.c:76:18: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
fprintf(stderr, log_target_rb_get(ringbuf_target, 0));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
loggingrb/loggingrb_test.c:77:18: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
fprintf(stderr, log_target_rb_get(ringbuf_target, 1));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
http://cgit.osmocom.org/osmocom-bb/commit/?id=c2b4458e0789dcf42bd0fb7498d97…
commit c2b4458e0789dcf42bd0fb7498d97c041aca87be
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Apr 11 19:31:03 2015 +0200
sim: Use extern for these structs to generate a linkage
Fixes:
duplicate symbol _ts102221_fcp_vals in:
.libs/core.o
.libs/card_fs_usim.o
duplicate symbol _pcsc_reader_ops in:
.libs/reader.o
.libs/card_fs_usim.o
http://cgit.osmocom.org/osmocom-bb/commit/?id=1885395551fb9a34145e9e242754b…
commit 1885395551fb9a34145e9e242754ba3b2a9aa09e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Apr 11 19:29:52 2015 +0200
macaddr: Use the BSD code for Darwin as well
It simply compiles, no other testing has been done.
http://cgit.osmocom.org/osmocom-bb/commit/?id=9a1a5a1c0ad0e42ad2cb897e72486…
commit 9a1a5a1c0ad0e42ad2cb897e7248638634aaef5a
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Apr 11 19:26:55 2015 +0200
utils: Disable the weak symbol for darwin
We should consider simply removing the alias as we have
had several ABI changes since introducint the alias
utils.c:223:23: error: only weak aliases are supported on darwin
__attribute__((weak, alias("osmo_hexdump_nospc")));
http://cgit.osmocom.org/osmocom-bb/commit/?id=a84db616737cda5dfc6e8590a2952…
commit a84db616737cda5dfc6e8590a29523dc08090f60
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Apr 9 14:22:22 2015 +0200
gprs: Add assertion for msg != NULL to bssgp_msgb_alloc (Coverity)
Currently out-of-memory is not handled by bssgp_msgb_alloc, leading
to SEGV failures if msgb_alloc_headroom returns NULL.
This commit adds an OSMO_ASSERT to catch this case, which improves
the situation only slightly. But bssgp_msgb_alloc is used in many
places without checking the return value, so just adding a
conditional early NULL return would not fix the issue either.
Fixes: Coverity CID 1293377
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=d154f8bda2e379a8a0e1c3712a9af…
commit d154f8bda2e379a8a0e1c3712a9af6a9d97b7b97
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Apr 9 14:22:21 2015 +0200
msgb: Check the return value of msgb_alloc (Coverity)
In some places, the return value of msgb_alloc/msgb_alloc_headroom
is not checked before it is dereferenced.
This commit adds NULL checks to return with -ENOMEM from the calling
functions if the alloc function has failed.
Fixes: Coverity CID 1249692, 1293376
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=8d192d7153498498ff6232209c900…
commit 8d192d7153498498ff6232209c900e67256b8036
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Apr 7 17:52:45 2015 +0200
ns: Log when sending fails (Coverity)
Currently the return value of the gprs_ns_tx family of functions is
often ignored. This is not a serious issue, since the successful
delivery of the messages is neither guaranteed nor acknowledged by
the network layer anyway.
Nevertheless this commit adds logging (level INFO) to gprs_ns_tx and
gprs_ns_msgb_alloc. The definition of the latter has been moved from
the header file to gprs_ns.c.
Fixes: Coverity CID 1040678, 1040679, 1040680, 1040681, 1040682,
1040683, 1040684, 1040686, 1040687, 1040688, 1111545,
1240203, 1240204
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=b535e391b0f1d030373159ddbf544…
commit b535e391b0f1d030373159ddbf54483d7fa54763
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Apr 7 17:52:44 2015 +0200
bssgp: Ensure non-NULL bctx before calling bssgp_rx_ptp (Coverity)
Currently bssgp_rx_ptp might be called with bctx being NULL, when the
NS BVCI is neither BVCI_SIGNALLING nor BVCI_PTM, but the message is
a BVC_RESET or it contains an BVCI IE != BVCI_SIGNALLING where the
BVCI is not known.
This patch ensures that bssgp_rx_ptp will only be called with a
non-NULL bctx. A log message will be issued, if the bctx is NULL when
this was not expected.
Fixes: Coverity CID 1040674
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=c641591ae9298894178dae78c37e5…
commit c641591ae9298894178dae78c37e5f96687be576
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Apr 7 17:52:43 2015 +0200
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity)
Currently the implementation of bssgp_tx_dl_ud conditionally adds
some optional IE if dup != NULL. Later on is dereferences dup to
access qos_profile and fc, but this without checking dup in advance.
This may lead to an segmentation violation fault.
This commit changes the value range of the function to only accept
dup != NULL. An assertion will fail otherwise. All other explicit
checks for non-NULL are removed.
Fixes: Coverity CID 1040673
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=a11994ddff1edbdb85ee9dc1ffd36…
commit a11994ddff1edbdb85ee9dc1ffd36f9b9834edf3
Author: Max <max.suraev(a)fairwaves.co>
Date: Mon Apr 6 16:17:49 2015 +0200
fix compiler warnings for a5 tests
Signed-off-by: Max <max.suraev(a)fairwaves.co>
http://cgit.osmocom.org/osmocom-bb/commit/?id=5fb265eaa725928b59b44aa9bfe89…
commit 5fb265eaa725928b59b44aa9bfe8959256014ba1
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Apr 5 14:36:31 2015 +0200
ctrl: Avoid accessing cmd_desc->command out of bounds
We check that the amount of commands is not more than
we have but we don't check it the other way. It appears
that the vector is allowed to be bigger than the amount
of commands. So we match a prefix of a longer command
depending on the installation order.
http://cgit.osmocom.org/osmocom-bb/commit/?id=4e0543f730b255849305787ecce89…
commit 4e0543f730b255849305787ecce89867e89f40f8
Author: Michael McTernan <Michael.McTernan(a)wavemobile.com>
Date: Mon Mar 30 13:22:14 2015 +0100
Tests: Fix broken loggingrb testcase.
The loggingrb (ringbuffer) test case was not actually being built or ran, instead still using the normal logging test.
This patch fixes the makefile, then the loggingrb testcase is changed to use the current loggingrb API so that it builds and passes.
Signed-off-by: Michael McTernan <mike.mcternan(a)wavemobile.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=f8699ca51eeb4f3d34336501abcaf…
commit f8699ca51eeb4f3d34336501abcaf071b4a95a47
Author: Max <max.suraev(a)fairwaves.co>
Date: Wed Mar 25 17:20:31 2015 +0100
gsm: Add A5/3-4 cipher support
Signed-off-by: Max <max.suraev(a)fairwaves.co>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=249a81b7ff57d39af843cd267b60c…
commit 249a81b7ff57d39af843cd267b60c0ce0400ce8d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Mar 22 09:03:42 2015 +0100
endian: Be able to detect endian on GNU and BSD
On GNU __BYTE_ORDER and __LITTLE_ENDIAN is defined and
the include is "endian.h" on FreeBSD it is "sys/endian.h"
and LITTLE_ENDIAN/_LITTLE_ENDIAN and BYTE_ORDER/_BYTE_ORDER
is defined.
Create a header file that defines OSMO_IS_LITTLE_ENDIAN
and OSMO_IS_BIG_ENDIAN and can be used as
#if OSMO_IS_LITTLE_ENDIAN
do_little_endian
#elif OSMO_IS_BIG_ENDIAN
do_big_endian
#else
#error "Unknown endian"
#endif
http://cgit.osmocom.org/osmocom-bb/commit/?id=789334640f2c34e58b9f3a8c19c57…
commit 789334640f2c34e58b9f3a8c19c57ac15bd2ed38
Author: Michael McTernan <Michael.McTernan.2001(a)cs.bris.ac.uk>
Date: Fri Mar 20 15:29:25 2015 +0100
vty: Fix writing the logging of category
Fix copy and paste issue introduced by Holger in
2d6ad13d8daf860595e6d4025861e122ce574871.
http://cgit.osmocom.org/osmocom-bb/commit/?id=267fd86e7da57719577c500391296…
commit 267fd86e7da57719577c50039129654bd396c651
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Mar 18 21:52:38 2015 +0100
libctrl: Include config.h so we can include netinet/tcp.h
In e15ac060e7ae78d4c3569d7fc9071bcf49807e05 we tried to fix
the nuttx build but we never included "netinet/tcp.h" after
it and the compiler warned about the unused "on" parameter
which we didn't notice because of the other warnings...
Include config.h so we can see if there is a tcp.h and then
include it.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6cce3d71537cd9dc077c407d865b8…
commit 6cce3d71537cd9dc077c407d865b8b8ffe1ee77f
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Mar 18 21:35:56 2015 +0100
msgfile: Fix warning on BSDs stdio
msgfile.c:116:16: warning: implicit declaration of function 'getline' is invalid in C99
[-Wimplicit-function-declaration]
while (getline(&line, &n, file) != -1) {
http://cgit.osmocom.org/osmocom-bb/commit/?id=ca8dcb7bff9f9ed4cc52875a77224…
commit ca8dcb7bff9f9ed4cc52875a772246011e93cf31
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Mar 18 21:26:57 2015 +0100
gsm0808: Remove duplicate initialization
These types were compatible so simply remove one.
Fixes:
gsm0808.c:323:37: warning: initializer overrides prior initialization CC gsm0480.lo
of this subobject
CC abis_nm.lo
[-Winitializer-overrides]
[GSM0808_IE_LSA_INFORMATION] = { TLV_TYPE_TLV },
^~~~~~~~~~~~
gsm0808.c:316:36: note: previous initialization is here
[GSM0808_IE_LSA_INFORMATION] = { TLV_TYPE_TLV },
^~~~~~~~~~~~
http://cgit.osmocom.org/osmocom-bb/commit/?id=36153dc61aa15f9c3084c2824c513…
commit 36153dc61aa15f9c3084c2824c51356fc4babadb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Mar 17 10:21:17 2015 +0100
bssgp: Handle BSSGP STATUS messages
Currently incoming BSSGP STATUS messages are just logged and no other
action is taken. This makes it impossible for higher layers to react
to failures which are indicated by corresponding STATUS messages
unless a timeout is triggered as a result of that failure later on.
This commit adds a bssgp_rx_status() function and calls it on
incoming STATUS messages. That function logs a message, increments the
new BSSGP_CTR_STATUS counter if the bctx context exists and invokes
an NM_STATUS status indication. The latter will allow the application
to handle failures immediately. Since all STATUS messages should be
handled, the function is already called in bssgp_rcvmsg and the
message is no longer handled in (and will not reach) bssgp_rx_sign
and bssgp_rx_ptp.
Ticket: OW#1414
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=49ed9beed1a1f6df197defb295cf4…
commit 49ed9beed1a1f6df197defb295cf436b5eeb8933
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Mar 17 10:21:16 2015 +0100
bssgp: Don't reply with STATUS when receiving a PtP STATUS message
Currently each incoming PtP BSSGP STATUS message is handled as 'not
yet implemented' and a BSSGP STATUS message (cause
BSSGP_CAUSE_PROTO_ERR_UNSPEC) is sent back to the peer. This will
cause endless messages loops if both peers use this BSSGP stack
implementation. This does not apply to signalling messages.
This commit changes the implementation of bssgp_rx_ptp() to just do
logging in this case.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=b61b2ca1a0c63d99c642fe46b0bfe…
commit b61b2ca1a0c63d99c642fe46b0bfef83eb092ba1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Mar 17 10:21:15 2015 +0100
logging: Implement subsecond resolution of extended timestamps
Currently when using 'logging print extended-timestamp 1', the
subsecond part (milliseconds) of the printed timestamp is always 0.
This makes it difficult to correlate log entries with PCAP file
entries if there are many of them per second.
This patch changes _output in logging.c to use gettimeofday() instead
of time() when extended timestamps are enabled and replaces the '000'
by the milliseconds computed from tv_usec.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=4dafdefa7adaea9ca10b357ed966f…
commit 4dafdefa7adaea9ca10b357ed966fdcd183347df
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Mar 14 19:30:19 2015 +0100
debian: Aim for a higher standards version
http://cgit.osmocom.org/osmocom-bb/commit/?id=4d45d40c782c3c536d917c51c0054…
commit 4d45d40c782c3c536d917c51c0054e9ee01a676a
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Mar 14 19:21:25 2015 +0100
debian: Move to multi-arch support in libosmocore
Enable multi-arch support in libosmocore. This means the package
can not be built on squeeze anymore.
The concept of "foreign" is not really well documented but I
think I use it correctly here.
http://cgit.osmocom.org/osmocom-bb/commit/?id=879acef39465bb978f9a3bcb34959…
commit 879acef39465bb978f9a3bcb349594b818aec442
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Jan 27 11:06:51 2015 +0100
vty: Fix typo in the state creation
This got introduced in 2d6ad13d8daf860595e6d4025861e122ce574871
and I thought that our vty tests would have caught such mistakes.
http://cgit.osmocom.org/osmocom-bb/commit/?id=19d00517af53261523b35e14b14de…
commit 19d00517af53261523b35e14b14de7b87ea8d669
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jan 18 21:23:16 2015 +0100
debian: Add pcsc build depends and pkg-config for the m4 macro
http://cgit.osmocom.org/osmocom-bb/commit/?id=f6a0ceb92fcdb9c8f496f6efeb385…
commit f6a0ceb92fcdb9c8f496f6efeb385850dbc33d0b
Author: altaf <altaf329(a)gmail.com>
Date: Mon Jan 12 12:51:44 2015 +0100
core/gsmtap: LTE RRC message types and LTE MAC define
Submitted-by: altaf <altaf329(a)gmail.com>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=25aeab7a8235141a72c7cbb37155d…
commit 25aeab7a8235141a72c7cbb37155d8949071ec3f
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jan 18 19:05:19 2015 +0100
Prepare a new libosmocore release
http://cgit.osmocom.org/osmocom-bb/commit/?id=4deb2dfa2547adb5ee71ff03c2ffd…
commit 4deb2dfa2547adb5ee71ff03c2ffdd0be088fa36
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jan 18 19:20:19 2015 +0100
ctrl: Link to libraries we use symbols from
Fixes:
dpkg-shlibdeps: warning: symbol vector_free used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol vector_set used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol vector_set_index used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol tall_vty_vec_ctx used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol ipa_msg_recv_buffered used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol cmd_free_strvec used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol vector_lookup used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol vector_lookup_ensure used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol cmd_make_strvec used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol vector_init used by debian/libosmoctrl0/usr/lib/libosmoctrl.so.0.0.0 found in none of the libraries
http://cgit.osmocom.org/osmocom-bb/commit/?id=c869069950515add4155dfb37d94b…
commit c869069950515add4155dfb37d94bd29d833d3fe
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jan 18 19:16:25 2015 +0100
sim: Link to libosmocore and libosmogsm
The big LIBOSMOCORE_CFLAGS and LIBOSMOCORE_LIBS macros are not
defined when building linosmocore. Use the .la files directly
Fixes:
dpkg-shlibdeps: warning: symbol osmo_hexdump used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol gsm48_parse_ra used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol _talloc_zero used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol _talloc_memdup used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol talloc_strndup used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol msgb_length used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol msgb_alloc used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol msgb_free used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol talloc_strdup used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol talloc_free used by debian/libosmosim0/usr/lib/libosmosim.so.0.0.0 found in none of the libraries
http://cgit.osmocom.org/osmocom-bb/commit/?id=78ffdb8ab2cc16251974bc2a93aa1…
commit 78ffdb8ab2cc16251974bc2a93aa1d9ae35b7874
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jan 18 19:06:01 2015 +0100
misc: Ignore a file generated by doxygen
http://cgit.osmocom.org/osmocom-bb/commit/?id=419684e30c2fe12d3e3441cfa9fea…
commit 419684e30c2fe12d3e3441cfa9fea21f1c4de959
Author: Tobias Engel <tobias(a)ccc.de>
Date: Thu Mar 8 13:31:52 2012 +0100
Supplementary Services (de)activation, interrogation added
These patches enhance the Supplementary Service (SS) processing from
only being able to handle USSD to other SS, specifically activation,
deactivation and interrogation of those SS. Registration is not yet
implemented.
include/osmocom/gsm/protocol/gsm_09_02.h has been added with needed
values for SS.
Modified by Harald Welte to keep the old ussd-only functiosn for API/ABI
stability.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c13cf8bbd3a0650993b43e1cea071…
commit c13cf8bbd3a0650993b43e1cea071c02d0f00d8f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 30 13:25:44 2014 +0100
SMS-CB: introduce and use GSM341_7BIT_PADDING
http://cgit.osmocom.org/osmocom-bb/commit/?id=c993a07ceb8cff0226885d39c6af1…
commit c993a07ceb8cff0226885d39c6af17f0f903e01a
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 30 13:22:56 2014 +0100
use the new GSM341 / GSM412 size constants
http://cgit.osmocom.org/osmocom-bb/commit/?id=61ced83a700aa4426390c2c12326f…
commit 61ced83a700aa4426390c2c12326f00d72ec193e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 30 13:18:26 2014 +0100
SMS-CB: Add #defines for maximum block/msg size and payload chars
http://cgit.osmocom.org/osmocom-bb/commit/?id=f626123f83675af8ea1ffd5d578dc…
commit f626123f83675af8ea1ffd5d578dc40f71270bef
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Tue Dec 30 12:07:17 2014 +0100
smscb/gsm0341_test: Add \r padding to the message
http://cgit.osmocom.org/osmocom-bb/commit/?id=be4bbeb01b85cbe38c70e0f272e59…
commit be4bbeb01b85cbe38c70e0f272e59e4c57f13aa2
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 30 01:22:26 2014 +0100
add missing gsm0341.h
http://cgit.osmocom.org/osmocom-bb/commit/?id=65f676dac581d5ff6240aa76104d3…
commit 65f676dac581d5ff6240aa76104d38df2cbf93ab
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 30 00:43:39 2014 +0100
test
http://cgit.osmocom.org/osmocom-bb/commit/?id=63b156a9e04546dae0970e658cfd2…
commit 63b156a9e04546dae0970e658cfd2d4d1230ced4
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 30 00:43:32 2014 +0100
fixup
http://cgit.osmocom.org/osmocom-bb/commit/?id=783d073a370191cdb9cba0f205ded…
commit 783d073a370191cdb9cba0f205ded50459663500
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Dec 29 17:09:11 2014 +0100
add gsm0341_test to generate SMSCB hex strings
Those hex strings can then be copy+pasted into the OSmoNITB VTY
http://cgit.osmocom.org/osmocom-bb/commit/?id=a19717a7c50dededf0c8ec8ccb347…
commit a19717a7c50dededf0c8ec8ccb347c1c5d019382
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Dec 29 13:14:01 2014 +0100
Add Cell Broadcast MSGIDs from TS 23.041 v12.6.0 Release 12
http://cgit.osmocom.org/osmocom-bb/commit/?id=6ec6bd9d887e02b868c1492fe24c0…
commit 6ec6bd9d887e02b868c1492fe24c0c8f1cc20f7c
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Dec 28 18:27:38 2014 +0100
log: "logging level everything" is a badly named option.
We tried to fix it but it isn't that easy. The original fix was
cd6ed82d1ff48f47ad9e33e6322df62896a76ed5 but we had to revert it
as "everything" is present/used in existing config files.
If we ever change the ABI we can make everything be something
that is > 0. For now use a wording that makes it obvious that
people should not use "everything".
http://cgit.osmocom.org/osmocom-bb/commit/?id=c8c33094afe13b78a5c75ecfd62ef…
commit c8c33094afe13b78a5c75ecfd62eff06e68d197d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Dec 28 18:22:48 2014 +0100
bitvec: Fix typo in the csn1 encoding code
We can curse about CSN.1 and 3GPP but I think we want to call
it cursor here.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1b12d16c4c6a2914e4d3def56b304…
commit 1b12d16c4c6a2914e4d3def56b304cb0da9246b0
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Dec 28 13:37:01 2014 +0100
libosmo-gsm: Add PCHAN/LCHAN types for CBCH
http://cgit.osmocom.org/osmocom-bb/commit/?id=a6be224b889baa8aecc4e7247e596…
commit a6be224b889baa8aecc4e7247e596583bbcfc8cb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Dec 22 10:58:46 2014 +0100
ipa: Return -errno instead of -1 in ipa_send
Currently, the ipa_send function returns -1 in one execution branch
to indicate an error and -EIO in another. This is not consistent and
can lead to a misinterpretation of the error code, since -1 is -EPERM
and in general, EPERM is not returned by write(2).
This patch changes the return code to -errno instead of -1 for the
case that write(2) fails for same reason. So -rc is always a sensible
error value if there is a failure.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=3cd6753a1135b89e4665c78d18650…
commit 3cd6753a1135b89e4665c78d18650f9addc1e874
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Dec 22 10:58:45 2014 +0100
ipa: Add forward declaration of struct osmo_fd
A pointer to struct osmo_fd is used in a few prototypes declared in
gsm/ipa.h, but is neither declared explicitly nor is such a
declaration reachable via the given include directives.
This patch adds a forward declaration of this type to ensure proper
compilation.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=4448048828db597aa99729b2b4379…
commit 4448048828db597aa99729b2b437986f59722c0e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Dec 14 19:01:14 2014 +0100
ipa: Make a reservation for the GSUP protocol
GSUP is a protocol to have the OpenBSC SGSN talk
to an exterbal system for 3GPP MAP connectivity.
http://cgit.osmocom.org/osmocom-bb/commit/?id=5f91a400685c0762df5f0f3bbb0b9…
commit 5f91a400685c0762df5f0f3bbb0b97daaf0d2371
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Dec 5 10:29:45 2014 +0100
logging: Call color only once and use the result
First we check if a color is defined and then we call it again
and use the result. Avoid the second call and use the result of
the previous call.
http://cgit.osmocom.org/osmocom-bb/commit/?id=2d6ad13d8daf860595e6d4025861e…
commit 2d6ad13d8daf860595e6d4025861e122ce574871
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Dec 5 09:35:30 2014 +0100
logging: Make it possible to print category/subsys and timestamps
We want to see from which category/subsystem a certain log message
is coming from and use a different timestamp format as well. Add
two new bitfields. This doesn't change the size of the structure
and on 32bit we still have 27bits left.
The extended timestamp will take preference over the current and
default timestamp format.
Fixes: SYS#602
http://cgit.osmocom.org/osmocom-bb/commit/?id=a5dc19dc4053e45a4a9ae8facfbdb…
commit a5dc19dc4053e45a4a9ae8facfbdb7393ad5fe69
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Dec 4 14:35:21 2014 +0100
gtp: Add a global region for the gtp library of OpenGGSN
We want to use libosmocore/libosmovty in the GGSN sourcecode
and reserve a global region here.
http://cgit.osmocom.org/osmocom-bb/commit/?id=9f0f978c8daa764d01f0892ef7b5e…
commit 9f0f978c8daa764d01f0892ef7b5e443f7c551a8
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 21 10:40:07 2014 +0100
vty: Check with the application before writing the config
For the BSC/NITB application we see that people modify the band
without modifying the ARFCN. This creates an unbootable config.
Using the new hook the BSC/NITB can check if the config is
consistent and prevent the config file being written.
Related: SYS#739
http://cgit.osmocom.org/osmocom-bb/commit/?id=e15ac060e7ae78d4c3569d7fc9071…
commit e15ac060e7ae78d4c3569d7fc9071bcf49807e05
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Dec 4 14:15:36 2014 +0100
fix libosmocore build for NuttX target
this fixes some compilation issues with libosmocore under NuttX,
particularly as some #defines are missing or some header files are
slightly different.
http://cgit.osmocom.org/osmocom-bb/commit/?id=20144f7bc5c04e57da36cd7d7883f…
commit 20144f7bc5c04e57da36cd7d7883f576510f0298
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 11 10:47:08 2014 +0100
vty/vector.c: Use string.h, not memory.h
http://cgit.osmocom.org/osmocom-bb/commit/?id=78a870ed0fc7ec03d0eb24241d977…
commit 78a870ed0fc7ec03d0eb24241d9772470e4a78ae
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 11 10:45:38 2014 +0100
remove references to u_long type, use 'unsigned long' instead
.. Nuttx doesn't know u_long
http://cgit.osmocom.org/osmocom-bb/commit/?id=7b74dda31bc05a7210bbbcb382b78…
commit 7b74dda31bc05a7210bbbcb382b78d6f9cde5b15
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 11 10:31:19 2014 +0100
remove references to u_char type, use 'unsigned char' instead
... u_char not being defined on Nuttx.
http://cgit.osmocom.org/osmocom-bb/commit/?id=b592ab71a7e3d49d62ea986401f09…
commit b592ab71a7e3d49d62ea986401f0902953375057
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 10 18:12:17 2014 +0100
strrb.c: Use string.h, not strings.h
Not all systems have strings.h
http://cgit.osmocom.org/osmocom-bb/commit/?id=9e166e8e0815a5b429738614025fc…
commit 9e166e8e0815a5b429738614025fc2beb96473d4
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 10 17:28:33 2014 +0100
select.c: Add missing #include lines for string.h and sys/select.h
This is needed on Nuttx.
http://cgit.osmocom.org/osmocom-bb/commit/?id=18bcc8ab6214e92539370eb3c5b60…
commit 18bcc8ab6214e92539370eb3c5b601f18def4dde
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 14 15:06:09 2014 +0100
pcsc: Allow to disable the PCSC dependency
* PCSC is enabled by default
* --enable-pcsc is enabling it
* --disable-pcscis disabling it
* Fix the makefile of the utilities to not build pcsc and
use the right header files/libraries.
http://cgit.osmocom.org/osmocom-bb/commit/?id=8497b0a78671e09015ec2cb40f0a2…
commit 8497b0a78671e09015ec2cb40f0a21cae7baf5ad
Author: Ciaby <ciaby(a)autistici.org>
Date: Mon Nov 10 12:33:35 2014 -0600
Fix debian packaging
- Added debian/libosmosim0.install
- Added libosmosim definition in debian/control
http://cgit.osmocom.org/osmocom-bb/commit/?id=0673b70f7d6c608566da84410c58f…
commit 0673b70f7d6c608566da84410c58f2ad5f290027
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 10 08:27:15 2014 +0100
bssgp: Fix VTY command 'show bssgp nsei N'
Currently this command segfaults (at least when ASAN is enabled),
because when getting the NSEI the index to argv is wrong and out of
bounds.
This patch fixes the offset.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=d6ec984c51ffa8c3185b1a0472b4a…
commit d6ec984c51ffa8c3185b1a0472b4aa0b522364fa
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Oct 27 20:43:06 2014 +0100
osmo-sim-test: Fix read_binary() return check
if we expect rmsg to be set, we should check for it...
http://cgit.osmocom.org/osmocom-bb/commit/?id=881b5169e5210e7bbfe1b93ea81b3…
commit 881b5169e5210e7bbfe1b93ea81b345dfef08e51
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Oct 27 20:41:40 2014 +0100
sim: reader_pcsc:Remove dead code
PCSC_ERROR() macro is already performing error checking.
Found by coverity.
http://cgit.osmocom.org/osmocom-bb/commit/?id=b0310dd376aa4a5058e2601800b81…
commit b0310dd376aa4a5058e2601800b81ac2ff4cf421
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Oct 27 12:00:37 2014 +0100
pcsc: Fix the include path
The pkg-config file already points into the PCSC directory. This
is needed for FreeBSD where /usr/local/include is not in the
default compiler search path.
On Debian
$ pkg-config --cflags libpcsclite
-pthread -I/usr/include/PCSC
On FreeBSD
$ pkg-config --cflags libpcsclite
-I/usr/local/include/PCSC -D_THREAD_SAFE -pthread
http://cgit.osmocom.org/osmocom-bb/commit/?id=33e940b862197cdbdc9f4e5781aa2…
commit 33e940b862197cdbdc9f4e5781aa2d3df3a0ea52
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 20:52:25 2014 +0100
sttrb / loggingrb: Use GPLv2+ as license, not AGPLv3+
according to Holger, using AGPLv3+ at the time was a mistake and the
license should always have indicated GPLv2+.
http://cgit.osmocom.org/osmocom-bb/commit/?id=fd5ad17c5cfd6cf9d57072c161a64…
commit fd5ad17c5cfd6cf9d57072c161a6443487a878ae
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 20:47:42 2014 +0100
Change copyright notice of ipa.c to GPLv2+
... which it should have been all along.
http://cgit.osmocom.org/osmocom-bb/commit/?id=388fb034062427b196ffa25caae2c…
commit 388fb034062427b196ffa25caae2c58cd305e5ac
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 20:42:49 2014 +0100
Change license of gsm0411_smc/smr to GPLv2+
libosmocore.{so,a} should always have been GPLv2+. However, when
migrating some code from OpenBSC or OsmocomBB, we sometimes introduced
it with a wrong license header.
http://cgit.osmocom.org/osmocom-bb/commit/?id=7fa89c2e886ea61ae3362d990915a…
commit 7fa89c2e886ea61ae3362d990915ac0c086d8d42
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 20:33:09 2014 +0100
Change license of libosmogb from AGPLv3+ to GPLv2+
The copyright holders Harald Welte, Holger Freyther, Andreas Eversberg
and sysmocom - s.f.m.c. GmbH (represented by Holger and Harald) agree
that the license of libosmogb should be GPLv2+ and not AGPLv3+.
The reason the source files stated AGPLv3+ is due to the history, as
they were moved from OpenBSC to libosmocore at the time we needed to use
them from osmo-pcu. It was an oversight back then to not re-license
them accordingly.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a97ebc9599d4b3210d7127a2cc75d…
commit a97ebc9599d4b3210d7127a2cc75d552e69eeb9a
Merge: 42645d7d 534163ba
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 20:14:04 2014 +0100
Merge branch 'laforge/sim'
This contains some work from 2012 about creating a general library about
the data structure of data contained on SIM cards. This 'libosmosim' is
supposed to be used by (among others)
* tools to review/modify/personalize SIM card filesystem data
* virtual SIM card implementation
http://cgit.osmocom.org/osmocom-bb/commit/?id=534163badec879a644af985c9f5d0…
commit 534163badec879a644af985c9f5d04b7c957a355
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 20:09:17 2014 +0100
remove doxygen_sqlite3.db during 'make clean'
http://cgit.osmocom.org/osmocom-bb/commit/?id=6729a9776aeffde08b11342dfc53e…
commit 6729a9776aeffde08b11342dfc53e33873a33594
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 19:04:56 2014 +0100
make sure to register DF.TELECOM and DF.GSM for SIM, USIM + TSIM
before we only did it partially, and by exporting data from sim,
rather than the new osim_int_cprof_add_{gsm,telecom}() functions.
http://cgit.osmocom.org/osmocom-bb/commit/?id=db2b52ee8477a0223114aeadc15c3…
commit db2b52ee8477a0223114aeadc15c3bfe8c2ee1fd
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 19:04:41 2014 +0100
sim: More talloc return NULL checking
http://cgit.osmocom.org/osmocom-bb/commit/?id=67354b1b4ee412a8e878a53607fcd…
commit 67354b1b4ee412a8e878a53607fcd65f2b344948
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 18:47:30 2014 +0100
sim: add missing const to reader_ops member of reader_handle
http://cgit.osmocom.org/osmocom-bb/commit/?id=55790aa09a8f92d437ea06b3ef2c7…
commit 55790aa09a8f92d437ea06b3ef2c74465612fa8b
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Oct 26 18:46:50 2014 +0100
sim: Prepare infrastructure for protocols != T=0 and other drivers
http://cgit.osmocom.org/osmocom-bb/commit/?id=586d710e0586a51ba19b71bf20f2b…
commit 586d710e0586a51ba19b71bf20f2bb12aa8c0aeb
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 17:01:16 2014 +0200
sim: More comments in sim.h
http://cgit.osmocom.org/osmocom-bb/commit/?id=aad7e0664b310ccc463538a18ac52…
commit aad7e0664b310ccc463538a18ac5238cb7c0ac3c
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 16:31:24 2014 +0200
sim: Make TETRA SIM (TSIM) support compile
http://cgit.osmocom.org/osmocom-bb/commit/?id=30115dbd72e121b6b5c29a8224419…
commit 30115dbd72e121b6b5c29a8224419cc554024b95
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 16:30:46 2014 +0200
sim: Only one default_decode() function for all card types
http://cgit.osmocom.org/osmocom-bb/commit/?id=171c5b1ec7fef03ded86a44ba8a19…
commit 171c5b1ec7fef03ded86a44ba8a19fdf974abc6f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 14:09:35 2014 +0200
sim: Add 3GPP TS 31.103 ISIM definitions
http://cgit.osmocom.org/osmocom-bb/commit/?id=bb5f3c7e04e356caa315618f41008…
commit bb5f3c7e04e356caa315618f41008280a64929d8
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 13:59:41 2014 +0200
sim: Update to latest SIM/USIM specs and include size information
http://cgit.osmocom.org/osmocom-bb/commit/?id=3fc3f068b3f981ff531bb606ebae9…
commit 3fc3f068b3f981ff531bb606ebae9247b8f2b578
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 13:59:17 2014 +0200
sim: Make osmo-sim-test compile again
http://cgit.osmocom.org/osmocom-bb/commit/?id=0d24644f5243b3420c18e7afdee9a…
commit 0d24644f5243b3420c18e7afdee9ae641f179a56
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 13:58:54 2014 +0200
sim: reader_pcsc.c: Avoid compiler warnings by using pcsc-lite LONG
http://cgit.osmocom.org/osmocom-bb/commit/?id=e8dd2bd4b52f4ee6c3ecb4a5b4b43…
commit e8dd2bd4b52f4ee6c3ecb4a5b4b4386d281b35a7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun May 4 13:42:38 2014 +0200
sim: mark osim_msgb_cb as __may_alias__ to avoid gcc warnings
http://cgit.osmocom.org/osmocom-bb/commit/?id=2656e65bed12680d288c55dbe53e1…
commit 2656e65bed12680d288c55dbe53e1d6c92bdfdc5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat May 3 14:23:44 2014 +0200
sim: Add sfi to EF_*() macros
http://cgit.osmocom.org/osmocom-bb/commit/?id=1e0dfdad69fcb48d8bc134be4ddab…
commit 1e0dfdad69fcb48d8bc134be4ddabc72d5dfc9e3
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat May 3 14:22:12 2014 +0200
sim: Add minimal/recommended size of file / record
http://cgit.osmocom.org/osmocom-bb/commit/?id=d83d29610a7c63a387fee77dbc2b1…
commit d83d29610a7c63a387fee77dbc2b18b19dc83b14
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 4 17:52:33 2013 +0000
sim: further updates/fixes
http://cgit.osmocom.org/osmocom-bb/commit/?id=7674960ffadd5d7cb1a58ecee7725…
commit 7674960ffadd5d7cb1a58ecee77252fe19e1e86f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Sep 19 20:55:54 2012 +0200
sim: add decoding of status words
http://cgit.osmocom.org/osmocom-bb/commit/?id=43eabeeeaa993b6628e0490fbf6b7…
commit 43eabeeeaa993b6628e0490fbf6b78f24cee4788
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Sun Sep 16 18:40:02 2012 +0200
sim: replaced function/structure comments with doxygen comments
affected files: sim.h, sim/core.c
affected funtions/strucutres: osim_new_apdumsg, osim_apdu_case,osim_apdu_cmd_hdr, osim_msgb_cb
http://cgit.osmocom.org/osmocom-bb/commit/?id=dede831fcd5ccc67ad4d0e05aaa96…
commit dede831fcd5ccc67ad4d0e05aaa9688c119a5b93
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Tue Sep 11 11:59:21 2012 +0200
sim: add comment/explaination for structure osim_msgb_cb
http://cgit.osmocom.org/osmocom-bb/commit/?id=1707306da59a53c8ce72952fc5e41…
commit 1707306da59a53c8ce72952fc5e41b999e36b73c
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Tue Sep 11 11:54:52 2012 +0200
sim: add comment/explaination for structure osim_apdu_cmd_hdr
http://cgit.osmocom.org/osmocom-bb/commit/?id=5985760a61591af16c2bd424881e9…
commit 5985760a61591af16c2bd424881e9f15cd67e820
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Tue Sep 11 11:47:04 2012 +0200
sim: added utils/osmo-sim-test to .gitignore
http://cgit.osmocom.org/osmocom-bb/commit/?id=e07967f689c56473a8492ec422ee3…
commit e07967f689c56473a8492ec422ee38964d00c9c3
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Tue Sep 11 11:44:18 2012 +0200
sim: renamed case to the one defined in ISO7816-3
APDU_CASE_2 becomes APDU_CASE_2S
APDU_CASE_2_EXT becmoes APDU_CASE_2E
APDU_CASE_3 becomes APDU_CASE_3S
APDU_CASE_3_EXT becmoes APDU_CASE_3E
APDU_CASE_4 becomes APDU_CASE_4S
APDU_CASE_4_EXT becmoes APDU_CASE_4E
http://cgit.osmocom.org/osmocom-bb/commit/?id=6956ee1ba11aa2b7321e0d4fd4187…
commit 6956ee1ba11aa2b7321e0d4fd41877184d9a3650
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Tue Sep 11 11:42:29 2012 +0200
sim: add comment/explaination for structure osim_apdu_case
http://cgit.osmocom.org/osmocom-bb/commit/?id=0f0ee32d8115cc29d89e41539ed0a…
commit 0f0ee32d8115cc29d89e41539ed0aac01852cf94
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Tue Sep 11 11:40:41 2012 +0200
sim: comment/explain signature of osim_new_apdumsg
http://cgit.osmocom.org/osmocom-bb/commit/?id=a5c9255baa0dd97b564ea8d44444a…
commit a5c9255baa0dd97b564ea8d44444ac80c38153b9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Sep 10 21:05:42 2012 +0200
sim: strip the SW from the returned data, as SW is passed in msgb->cb
http://cgit.osmocom.org/osmocom-bb/commit/?id=495fe2682c37d7e2ba9d969fa0675…
commit 495fe2682c37d7e2ba9d969fa0675e59db461790
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Sep 10 16:28:17 2012 +0200
sim: Use autotools for libpcsc-lite linkage
http://cgit.osmocom.org/osmocom-bb/commit/?id=ad41863b8d3f3ac7df0c34b2c7d34…
commit ad41863b8d3f3ac7df0c34b2c7d342b864d944cc
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Sep 10 10:49:59 2012 +0200
sim: add copyright notices and merge file_codec.c into core.c
http://cgit.osmocom.org/osmocom-bb/commit/?id=a0ba4d943816a10e78984d8bbca56…
commit a0ba4d943816a10e78984d8bbca56fbdbdfe82bb
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Sep 10 10:43:15 2012 +0200
sim: osmo-sim-test: Also dump binary files
http://cgit.osmocom.org/osmocom-bb/commit/?id=d54c2ee8c51b41b7f7a5a469efd6b…
commit d54c2ee8c51b41b7f7a5a469efd6bb391a0c2b75
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Jan 17 18:25:50 2012 +0100
initial checkin of 'libosmosim'
http://cgit.osmocom.org/osmocom-bb/commit/?id=cac3cd6fcd941ae0906e5a95a1cb3…
commit cac3cd6fcd941ae0906e5a95a1cb3b5ebec8a72a
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Sep 10 20:58:20 2012 +0200
msgb: make msgb_get() finally work as expected
http://cgit.osmocom.org/osmocom-bb/commit/?id=42645d7d78a22db7b76039407b7b4…
commit 42645d7d78a22db7b76039407b7b43bc0cc79c54
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Oct 25 12:20:24 2014 +0200
misc: Ignore the new test file as well
http://cgit.osmocom.org/osmocom-bb/commit/?id=e0a1a8021f04f58efa03a42c25ac6…
commit e0a1a8021f04f58efa03a42c25ac63af7f6ab4e8
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Oct 25 12:19:56 2014 +0200
bssgp: Include sys/socket.h for AF_INET on FreeBSD
http://cgit.osmocom.org/osmocom-bb/commit/?id=b43baf20c571925cca16266482c4b…
commit b43baf20c571925cca16266482c4b5c325f41700
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Sep 10 12:43:28 2014 +0200
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg
Currently sending SUSPEND/RESUME messages to this function (like it
is done in the osmo-sgsn) results in STATUS messages complaining
about an unknown BVCI. The reason is, that these messages rely on a
TLLI/RAI pair to identify the context and do not contain an explicit
BVCI.
This patch modifies bssgp_rcvmsg() to only complain about and unknown
BVCI if one is given but a matching context is not found (except for
RESET messages). The ctx argument is removed from the functions
handling SUSPEND and RESUME since it will always be NULL then.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=cdebf7484a72c6a8221d68d7f360a…
commit cdebf7484a72c6a8221d68d7f360aee58d21ea83
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 14 14:49:37 2014 +0200
gprs/test: Add BSSGP tests
This patch adds a test suite for the BSSGP protocol.
The first (and only) test checks the handling of BSSGP
SUSPEND/RESUME.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=862ba65bd64202b5e860a05adf6fd…
commit 862ba65bd64202b5e860a05adf6fdd51c8790591
Author: Max <max.suraev(a)fairwaves.co>
Date: Mon Oct 13 14:54:25 2014 +0200
Move common socket routine into separate function
Signed-off-by: Max <max.suraev(a)fairwaves.co>
http://cgit.osmocom.org/osmocom-bb/commit/?id=10dd73cf6afdc0ba237022510ec70…
commit 10dd73cf6afdc0ba237022510ec702a56237d7d7
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Oct 10 17:24:34 2014 +0200
bssgp: Free msgb in case of error when calling into gprs_ns_sendmsg
In the OsmoSGSN we have a crash with a DEAD/BLOCKED GPRS-NS and
segmented SN-UNITDATA. For the caller it is not easy to know if
the passed msg buffer has been freed or not. The most easy solution
is to always take the ownership and either pass it on or free it
in case of an error.
Adjust indirect and direct callers of gprs_ns_sendmsg. I found
the following call-chains with an external msgb parameter.
gprs_ns_sendmsg
<- _bssgp_tx_dl_ud
<- bssgp_fc_in
<- bssgp_tx_dl_ud
Update the test to allocate a real msgb because for the test with
'1000' we will msgb_free it right away.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=dade018f2fa577de2020c4bfaa9bf…
commit dade018f2fa577de2020c4bfaa9bfde770ae3b30
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 9 11:07:56 2014 +0200
gprs-ns/test: Check the nsvc state explicitely
This patch extends test_sgsn_reset_invalid_state by assertions to check
that nscv->state and nsvc->remote_state have been set as expected.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=84bcce6b4f8cbfa16d634d3e77cdd…
commit 84bcce6b4f8cbfa16d634d3e77cdd489216d1d2f
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Oct 9 16:07:37 2014 +0200
gprs-ns/test: Re-add return value check for gprs_nsvc_reset
The return value check has been removed in the commit 'Use
gprs_nsvc_reset instead of gprs_ns_tx_reset', because gprs_nsvc_reset
had no return value then. Since a compatible return value has been
added by 'Let gprs_nsvc_reset return a value', the former patch is
partly reverted by this commit.
The printf is now an OSMO_ASSERT. The commit message was taken
from Jacob.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=6ac70a41ee4cc9f3f286fb6b8f397…
commit 6ac70a41ee4cc9f3f286fb6b8f397215590fc2ac
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 7 14:12:30 2014 +0200
gprs-ns: Fix reset state handling
Currently the NS-VC's state is updated from within gprs_ns_tx_reset,
which can lead to an inconsistent state when the RESET_ACK is lost.
In this state, the NSE_S_RESET bit is set but the Tns-reset timer is
not started.
This patch moves the state update into gprs_nsvc_reset. This way, the
state flags are consistent with the timer.
Addresses:
SGSN -> BSS NS_ALIVE
BSS -> SGSN NS_ALIVE_ACK
BSS -> SGSN BVC_RESET
SGSN -> BSS NS_STATUS, Cause: NS-VC blocked, NS VCI: 0x65
and there is no BSS->SGSN NS_ALIVE
Ticket: OW#1213
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=0540d839ace7811257793c383275b…
commit 0540d839ace7811257793c383275b929768175a5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 8 11:47:36 2014 +0200
gprs-ns: Let gprs_nsvc_reset return a value
Currently gprs_nsvc_reset does not return any value.
This patch changes the function to return an integer, where a value
less than zero indicates an error. The value is taken from the
gprs_ns_tx_reset function. In case of failure, an error message is logged.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=cdb85f58c5f10b5b340d4cf064a09…
commit cdb85f58c5f10b5b340d4cf064a096bd6fc6409f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 7 14:07:39 2014 +0200
gprs-ns/test: Add test_sgsn_reset_invalid_state
This tests the behaviour for a certain combination of messages and
packet losses that can put the NS-VC object into an undefined state.
In that state, the peer's ALIVE messages are properly answered, but
the local test procedure has stopped, incoming unitdata PDUs are
answered by STATUS(NS-VC blocked) and the unblocking procedure is not
initiated.
Ticket: OW#1312
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=f1bcbb0f8a92429ae086bef0064ce…
commit f1bcbb0f8a92429ae086bef0064ce5a5cebd75d0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 7 14:03:44 2014 +0200
gprs-ns/test: Add expire_nsvc_timer
This function forces the expiration of the timer within struct
gprs_nsvc. It is meant to be used for controlled (and faster) timer
expiration in unit tests. The timer_mode of the expired timer is
returned (or -1 if the timer wasn't active).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=2381fded689d5e2d19f4ed2e8ab7d…
commit 2381fded689d5e2d19f4ed2e8ab7d7b83788b8b5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 7 13:59:30 2014 +0200
gprs-ns/test: Save the last PDU type sent
This records the PDU type of the last message sent to the remote peer
in the global variable sent_pdu_type, which can then be used in
assertions.
Note that sent_pdu_type will remain unchanged if no message has been
sent via sendto.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=f357c877242cbb3618ad4a2ed499e…
commit f357c877242cbb3618ad4a2ed499e3038ee5d5dd
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 7 13:52:07 2014 +0200
gprs-ns/test: Use gprs_nsvc_reset instead of gprs_ns_tx_reset
Currently gprs_ns_tx_reset is used to let the NS stack generate
NS_RESET message. This is not adjusting the nsvc state properly.
This patch uses gprs_nsvc_reset instead which starts the full reset
procedure.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=1a632552e0f9297b8f2ec8e08b659…
commit 1a632552e0f9297b8f2ec8e08b659c1e25394747
Author: Jan Engelhardt <jengelh(a)inai.de>
Date: Sat Oct 4 11:06:13 2014 +0200
build: resolve compiler warning about implicit delcaration
CC msgfile_test.o
msgfile/msgfile_test.c: In function "main":
msgfile/msgfile_test.c:48:2: warning: implicit declaration of
function "talloc_free" [-Wimplicit-function-declaration]
talloc_free(entries);
^
http://cgit.osmocom.org/osmocom-bb/commit/?id=c60de4f35f3f73f3d79b4ff61d0a2…
commit c60de4f35f3f73f3d79b4ff61d0a20b92f818702
Author: Jan Engelhardt <jengelh(a)inai.de>
Date: Thu Oct 2 22:22:28 2014 +0200
build: fix linker error with kasumi_test
When the osmocore package is configured with --disable-static,
building of kasumi_test fails. This seems quite legit, given
the function _kasumi_kgcore is not exported.
Don't try to workaround the build system. Include the code.
CCLD kasumi/kasumi_test
kasumi_test.o: In function `test_expansion':
~tests/kasumi/kasumi_test.c:25: undefined reference to `_kasumi_key_expand'
kasumi_test.o: In function `main':
~tests/kasumi/kasumi_test.c:56: undefined reference to `_kasumi'
~tests/kasumi/kasumi_test.c:100: undefined reference to `_kasumi_key_expand'
~tests/kasumi/kasumi_test.c:112: undefined reference to `_kasumi_kgcore'
[...]
http://cgit.osmocom.org/osmocom-bb/commit/?id=9ffeb9756a5077dce1e9fffa70523…
commit 9ffeb9756a5077dce1e9fffa705239dc290e0d98
Author: Jan Engelhardt <jengelh(a)inai.de>
Date: Mon Jun 3 01:59:25 2013 +0200
build: remove unused all_includes and use AM_CPPFLAGS
Preprocessor flags are best placed in AM_CPPFLAGS. Remove use of the
unused all_includes variable, which is never set.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a6d83932ba3aee8f0570d86f0f237…
commit a6d83932ba3aee8f0570d86f0f23773bd44909cc
Author: Jan Engelhardt <jengelh(a)inai.de>
Date: Mon Jun 3 01:38:57 2013 +0200
utils: resolve compiler warnings on implicit declarations
CC osmo-auc-gen.o
osmo-auc-gen.c: In function 'main':
osmo-auc-gen.c:216:3: warning: implicit declaration of function
'time' [-Wimplicit-function-declaration]
http://cgit.osmocom.org/osmocom-bb/commit/?id=96af78650d1de134ebb37ddb82950…
commit 96af78650d1de134ebb37ddb829508cf0bd30c51
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Sep 25 18:18:49 2014 +0200
misc: Look into the build directory for generated files
the bits/crc files are not inside the sourcedirectory but will end
in the build directory. Go and look there as well. This somehow
doesn't fail with make distcheck but when building for Yocto Dizzy.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a39e2deff8f12f164f8a88fb061c6…
commit a39e2deff8f12f164f8a88fb061c66626bfe22a5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 23 13:28:24 2014 +0200
gprs: Set bssgph field in bssgp_msgb_alloc()
Currently the bssgph field is not set when using the bssgp_tx_*
functions. This hinders unit testing of generated messages.
This patch initializes the bssgph field directly after allocation a
new bssgp msgb in bssgp_msgb_alloc() so that it is set by default.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=b83b838bd1d0d4f3fe9d699e88663…
commit b83b838bd1d0d4f3fe9d699e886634fe7d90f420
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 23 13:28:22 2014 +0200
gprs: Fix bssgp_rcvmsg to handle signalling msgs with BVCI IE
Currently BSSGP messages with an NS BVCI of 0 (signalling) are
discarded if they aren't RESET messages. Thus valid signalling
messages (e.g. BLOCK) are not handled properly, because the BVCI IE
is ignored if it present. Instead a STATUS message referring to BVCI
0 (instead of the BVCI used in the BLOCK message) is returned.
This patch changes the implementation to use the BVCI contained in
the BVCI IE if that is present in a signalling message.
It fixes BSSGP BLOCK/UNBLOCK for the osmo-sgsn.
Note that signalling messages without an BVCI IE (e.g.
SUSPEND/RESUME) are still rejected.
Ticket: OW#1205
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=a7165778c6696a8853bc7696ffed2…
commit a7165778c6696a8853bc7696ffed29dd757b4b0f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 23 13:28:21 2014 +0200
gprs: Fix and check BVCI in BSSGP STATUS messages
Currently the BVCI is not set in all invocations to bssgp_tx_status()
when the cause is UNKNOWN_BVCI.
This patch adds the argument where it is missing.
It also adds a check for compliance (GSM 08.18, 10.4.14.1) to
bssgp_tx_status() to emit errors when the following requirement is
not fulfilled: The BVCI must be included if (and only if) the cause
is either "BVCI blocked" or "BVCI unknown".
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=de883e7f6cfb71f46921d6ef7564b…
commit de883e7f6cfb71f46921d6ef7564b24aeecd6f2c
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Sep 11 13:20:07 2014 +0800
Fix copyright header in gan.c
When I wrote the gan.c, I used the wrong copyright/license header
(AGPLv3+ intead of GPLv2+). This was a mistake and is fixed hereby.
http://cgit.osmocom.org/osmocom-bb/commit/?id=468b64331a6c7065e05800f760a87…
commit 468b64331a6c7065e05800f760a87de729b51ca7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Sep 11 13:05:51 2014 +0800
add missing copyright statements to source code files
Some source code files didn't have the usual copyright and licence
statement at their top. I'm adding them baesed on information in the
commitlog.
http://cgit.osmocom.org/osmocom-bb/commit/?id=804590e6d297fb63714eeda44e65e…
commit 804590e6d297fb63714eeda44e65e285a5d69c15
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Sep 8 07:44:20 2014 +0200
debian: Depend on the right version of libosmogsm as well
http://cgit.osmocom.org/osmocom-bb/commit/?id=575a5395a677501d87227a0f0d06f…
commit 575a5395a677501d87227a0f0d06f7711d5c74b1
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Sep 8 07:27:52 2014 +0200
debian: Depend on libosmocore5 for the legacy package
http://cgit.osmocom.org/osmocom-bb/commit/?id=2cbfb5967c440ddc8684ddb4679ea…
commit 2cbfb5967c440ddc8684ddb4679ea60299f0c6d0
Author: Ciaby <ciaby(a)rhizomatica.org>
Date: Sun Aug 31 15:35:29 2014 -0500
debian: fix build errors with libosmogsm and libosmoctrl
libosmogsm: the transition from 5 to 6 wasn't done properly. Fixed version number.
libosmoctrl: missing definition in debian/control and also missing libosmoctrl0.install.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3ec8de0072a4fdbddcd4c7e528144…
commit 3ec8de0072a4fdbddcd4c7e528144035dded7929
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Sep 2 18:17:34 2014 +0200
logging: Document the ABI breakage in the release todo
In commit fb84f325b8e672ba7ca1a961f4ef01f4d011e33d the ABI
was broken, let's add the required entry.
http://cgit.osmocom.org/osmocom-bb/commit/?id=8d950eac9e29819c3e2e334d258cf…
commit 8d950eac9e29819c3e2e334d258cfa3824e8f376
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Aug 29 14:19:20 2014 +0200
msgfile: Fix memleak in the test and release the list
http://cgit.osmocom.org/osmocom-bb/commit/?id=fb84f325b8e672ba7ca1a961f4ef0…
commit fb84f325b8e672ba7ca1a961f4ef01f4d011e33d
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Jun 6 07:33:54 2013 +0200
logging: Add ability to save/print current log filters
This enables the persistent configuration of let's say
'log filter imsi 012345678' for a given log file in the config
file.
http://cgit.osmocom.org/osmocom-bb/commit/?id=276ca4b1722df573f9af773582071…
commit 276ca4b1722df573f9af7735820712bcaf32b800
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Aug 24 17:35:19 2014 +0200
gsm48.h: define the reserved TMSI in libosmocore, not openbsc
http://cgit.osmocom.org/osmocom-bb/commit/?id=f39aed69424b8116f577d497a0235…
commit f39aed69424b8116f577d497a0235ba2d735a0cd
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Aug 24 16:52:12 2014 +0200
add port number 4238 for BTS control interface
http://cgit.osmocom.org/osmocom-bb/commit/?id=39c9e7b471f29ec1df8b4fc407bb3…
commit 39c9e7b471f29ec1df8b4fc407bb3fe2ac96cb9e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Aug 22 00:28:51 2014 +0200
libctrl: Add support for 'deferred control commands'
Sometimes a control interface command cannot be processed
and responded immediately, but we need to process it asynchronously.
In order to support this, we introduce the 'ctrl_cmd_def', which
represents such a deferred command. It is created by the service
implementing the command using ctrl_cmd_def_make(), and a response is
later sent using ctrl_cmd_def_send().
ctrl_cmd_def_is_zombie() must be called to handle the case where
the control connection has disconnected/died between receiving the
command and sending the response.
http://cgit.osmocom.org/osmocom-bb/commit/?id=5e21131c8dd37a536ec7df968d602…
commit 5e21131c8dd37a536ec7df968d602c2c85580c39
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Aug 21 16:31:52 2014 +0200
ctrl: Attempt fix the build on FreeBSD and add include file
IPPROTO_TCP is defined in netinet/in.h. Include it and hope the
build is fixed for FreeBSD.
http://cgit.osmocom.org/osmocom-bb/commit/?id=336915aa0a86316ba26cdfecbf160…
commit 336915aa0a86316ba26cdfecbf160ed643ccf301
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 15:51:07 2014 +0200
prepare for 0.7.0 release
http://cgit.osmocom.org/osmocom-bb/commit/?id=5ddd435919073d71f788858b2334f…
commit 5ddd435919073d71f788858b2334ff249142271f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 15:42:44 2014 +0200
Convert recently-introduced header files to #pragma once
http://cgit.osmocom.org/osmocom-bb/commit/?id=c7947ed1f6fe8a9113451fbd1e580…
commit c7947ed1f6fe8a9113451fbd1e58078a98ee4912
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 12:17:11 2014 +0200
New <osmocom/ctrl/ports.h> file listing tcp ports for CTRL interface
http://cgit.osmocom.org/osmocom-bb/commit/?id=ae2fcb22cfa81fe3934d4adaac688…
commit ae2fcb22cfa81fe3934d4adaac68887001ab3a91
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 15:20:00 2014 +0200
rename controlif_setup() to ctrl_interface_setup()
which means that all control interface related functions now have
the common ctrl_ prefix.
http://cgit.osmocom.org/osmocom-bb/commit/?id=bfdc259824e23160ecb5035defd52…
commit bfdc259824e23160ecb5035defd52eb1bcf55dbf
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 15:18:04 2014 +0200
libctrl: Make two internal helper functions static
http://cgit.osmocom.org/osmocom-bb/commit/?id=528134b01cd731d861b8e3c00554f…
commit 528134b01cd731d861b8e3c00554fdedf1e0b58f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 15:13:08 2014 +0200
libctrl: Move bulk of control node lookup inti libosmoctrl
The control interface user now only has to register a very short
node lookup function callback. This function is optional, and only
required if hierarchical command lookup should be supported.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c78e74e3d022400c66da05015e716…
commit c78e74e3d022400c66da05015e716ccb7fa18a63
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 14:34:32 2014 +0200
libctrl: remove 'struct gsm_network' references
libctrl doesn't need any knowledge about the type of the user-private
data that it gets passed upon setup time and includes on callbacks.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d8db92c578d7fcd81148ef5b977f5…
commit d8db92c578d7fcd81148ef5b977f5d2480a56cde
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 14:32:26 2014 +0200
libctrl: remove bsc-specific declaration
this was moved by accident when importing the code from openbsc.
http://cgit.osmocom.org/osmocom-bb/commit/?id=acbb4c91b63ed3cb68c20c4564db5…
commit acbb4c91b63ed3cb68c20c4564db5439654e6de5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 22:51:25 2014 +0200
libctrl: adopt to recent ipaccess/ipa naming change
http://cgit.osmocom.org/osmocom-bb/commit/?id=3ff81b1a6b830d16803f3fc7356e9…
commit 3ff81b1a6b830d16803f3fc7356e9fd71162b6c6
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 19:58:40 2014 +0200
libctrl: autotools build system integration
Now we actually build the recently-imported libctrl
http://cgit.osmocom.org/osmocom-bb/commit/?id=7fd0c830d968e67be555bd1aeabce…
commit 7fd0c830d968e67be555bd1aeabced4cc5e08061
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 19:58:13 2014 +0200
libctrl: Add DLCTRL as logging context for the control interface
... and make libctrl code use it
http://cgit.osmocom.org/osmocom-bb/commit/?id=f3c7e85d05f7b2b7bf093162b776f…
commit f3c7e85d05f7b2b7bf093162b776f71b2bc6420d
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 22:50:47 2014 +0200
libctrl: remove reference to bsc_replace_string()
... and rather introduce a general osmo_talloc_replace_string() to
libosmocore.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c9df37d84a7a9bace75cc0549a21f…
commit c9df37d84a7a9bace75cc0549a21fdcd9b178182
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 19:55:17 2014 +0200
libctrl: Avoid using external tall_bsc_ctx
Instead of using one flat talloc context (and one that is specific to
openbsc), we should attach the objects to whatever parent context they
are being used in.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1238cc64d79308c3db46baa7f755f…
commit 1238cc64d79308c3db46baa7f755f17ac3db9e49
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 19:50:04 2014 +0200
libctrl: remove openbsc headers, convert from make_sock to libosmocore
http://cgit.osmocom.org/osmocom-bb/commit/?id=e1a502b0df4a2e8ca90db42549fc2…
commit e1a502b0df4a2e8ca90db42549fc22f00c2b72f6
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 19:28:05 2014 +0200
libctrl: Remove reference to 'DNAT' in favor of 'DCTRL'
http://cgit.osmocom.org/osmocom-bb/commit/?id=dda42251532c347af66ccd6f51574…
commit dda42251532c347af66ccd6f515745ab83eb8bd5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 19:18:15 2014 +0200
libctr: rename/move control interface to libosmocore naming scheme
http://cgit.osmocom.org/osmocom-bb/commit/?id=5ad742d56e9f0d7d3e442ddde17bb…
commit 5ad742d56e9f0d7d3e442ddde17bba94d6b1e6c4
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Aug 8 19:41:28 2014 +0200
ctrl: Allow the value to contain spaces. No need to split the string
http://cgit.osmocom.org/osmocom-bb/commit/?id=0e7b67c3d971dceb662fbd161a345…
commit 0e7b67c3d971dceb662fbd161a34501c9929f874
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu May 15 17:27:12 2014 +0200
ctrl: Use CTRL_CMD_DEFINE_STRUCT in CTRL_CMD_DEFINE_RANGE
Jacob pointed out that I didn't convert CTRL_CMD_DEFINE_RANGE.
This patch is doing it now.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6217930688a95ab236e80ba49b247…
commit 6217930688a95ab236e80ba49b247cec3786407f
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu May 15 15:33:46 2014 +0200
ctrl: Reduce code duplication and add a define to create the struct
This has been pointed out by Jacob and removes two more duplicates
of the struct. For the unused CTRL_CMD_DEFINE_STRING macro there
will be no verify command.
http://cgit.osmocom.org/osmocom-bb/commit/?id=50059bb64f64f3d7842d9edd45443…
commit 50059bb64f64f3d7842d9edd454433d9e5fd8b36
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu May 15 15:45:55 2014 +0200
ctrl: Remove the param parameter as it was never used/implemented
http://cgit.osmocom.org/osmocom-bb/commit/?id=c08c55186fb03deb8d9439fe7c5b7…
commit c08c55186fb03deb8d9439fe7c5b7bfc12a201bd
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed May 14 09:50:27 2014 +0200
ctrl: Introduce a macro for read-only attributes and use it
Certain attributes are read-only. Add a macro to make it more
easy to define those.
http://cgit.osmocom.org/osmocom-bb/commit/?id=141de62b06000fcbe582713a9f44a…
commit 141de62b06000fcbe582713a9f44a809ea2fbd62
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Mar 31 13:42:11 2014 +0200
ipa: Use enhanced ipa_msg_recv_buffered() to cope with partioned IPA messages
The old ipa_msg_recv() implementation didn't support partial receive,
so IPA connections got disconnected when this happened.
This patch adds the handling of the temporary message buffers and uses
ipa_msg_recv_buffered().
It has been successfully tested by jerlbeck with osmo-nitb and
osmo-bsc.
Ticket: OW#768
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ea62a38b5d770f31e3d3cc635c52d…
commit ea62a38b5d770f31e3d3cc635c52d4854f585fb3
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Mar 23 16:25:16 2014 +0100
ctrl: Move the lookup into a separate file in preparation for GPRS
For GPRS the look-up via bts/trx does not make any sense and would
introduce bad depdencies for the SGSN. Move the look-up code to a
new file and introduce new setup methods.
http://cgit.osmocom.org/osmocom-bb/commit/?id=416e316564ef7cba2b76f1cf5fc81…
commit 416e316564ef7cba2b76f1cf5fc81bc76fba8ecf
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Fri Feb 22 11:04:35 2013 +0100
ctrl: Make it possible to re-use the string get and set routine
This can be used for the description field that requires some
special handling for newlines.
http://cgit.osmocom.org/osmocom-bb/commit/?id=05f655e2b058459c9df5cf9381b5b…
commit 05f655e2b058459c9df5cf9381b5b8ccb9781fe1
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Fri Feb 22 10:09:45 2013 +0100
ctrl: Make the int range set, get and verify methods available
For the max power reduction we will need to have a different range
method. It will need to check if the value is even. Make the set,
get and verify methods available through a macro.
http://cgit.osmocom.org/osmocom-bb/commit/?id=e6d56159a6ee76b1bd9fd7ade1f64…
commit e6d56159a6ee76b1bd9fd7ade1f64801818861b3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Sep 16 11:20:29 2013 +0200
ctrl: Set a generic reply when it hasn'n been set
When verification failed and the reply string was not updated, the
message "Someone forgot to fill in the reply." was shown instead
of the default "Value failed verification." message.
This patch changes the default reply handling in ctrl_cmd_handle()
by setting the reply to NULL initially and then checking it at the
end. If it hasn't been set, a generic message is assigned and an
error is logged.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6d96dd7477d974b571bd5326b02e1…
commit 6d96dd7477d974b571bd5326b02e1564b0248e44
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Mar 16 10:13:04 2013 +0100
ctrlif: Flush/Clear write_queue when closing the control socket
http://cgit.osmocom.org/osmocom-bb/commit/?id=35f5653a182805d8945a5e8ec2ed4…
commit 35f5653a182805d8945a5e8ec2ed4d3419571ca3
Author: Alexander Huemer <alexander.huemer(a)xx.vu>
Date: Tue Jun 11 14:31:27 2013 +0200
Makefile.am: Use AM_CPPFLAGS
Since automake 1.13 INCLUDES is depricates and causes a warning
http://cgit.osmocom.org/osmocom-bb/commit/?id=e9f7be16acb78b28ab18fcb61f228…
commit e9f7be16acb78b28ab18fcb61f228569cbea652d
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Fri Feb 22 10:53:29 2013 +0100
ctrl: Provide a reply in case the range check failed
http://cgit.osmocom.org/osmocom-bb/commit/?id=da5eded5ad3f530ec7e03de8e1c06…
commit da5eded5ad3f530ec7e03de8e1c065711299d7d4
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Fri Feb 22 10:03:56 2013 +0100
ctrl: Make the commands static to not pollute the namespace
We do not need to access these commands from another compilation
unit and can just make it static.
http://cgit.osmocom.org/osmocom-bb/commit/?id=17e7e5a8690ac9a33f7f3d3cd3df3…
commit 17e7e5a8690ac9a33f7f3d3cd3df3cabfcbe3805
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Jan 9 17:11:50 2013 +0100
ctrl: Work on the cmd->node instead of the data pointer passed
Make the macros use the cmd->node instead of the data pointer. The
naming of the variable inside the macro already indicates that it
should use the nodes data structure.
http://cgit.osmocom.org/osmocom-bb/commit/?id=43a11db87998add9132f1bfbe41e3…
commit 43a11db87998add9132f1bfbe41e3369bb0a7e5f
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Jan 9 16:54:49 2013 +0100
ctrl: Fix the signature of the string control commands
Like with all type unsafe callbacks we will need to cast from
void to the dtype. This addresses some compiler warnings.
Make it possible to only include the control_cmd.h to use the
macros defined in this file.
http://cgit.osmocom.org/osmocom-bb/commit/?id=9c97493c5c90d7c81a11cf28965fd…
commit 9c97493c5c90d7c81a11cf28965fd513f665d1cd
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Aug 25 16:37:45 2011 +0200
libctrl, osmo-bsc: Get rid of net prefix
net is now implicit in the root node
http://cgit.osmocom.org/osmocom-bb/commit/?id=3463941c724966c30a827c39b7036…
commit 3463941c724966c30a827c39b70360fa4bbe0bd9
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Aug 18 15:22:01 2011 +0200
ctrl: Use strtol instead of atoi to detect conversion errors
http://cgit.osmocom.org/osmocom-bb/commit/?id=5d9b203db61b1840562b040411ca6…
commit 5d9b203db61b1840562b040411ca69a0fed9d80f
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Aug 18 13:48:26 2011 +0200
ctrl: Improve error messages in ctrl_cmd_handle
http://cgit.osmocom.org/osmocom-bb/commit/?id=bed515f5d6b049eccc2b135be1787…
commit bed515f5d6b049eccc2b135be17874156f598705
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Aug 18 13:44:49 2011 +0200
ctrl: Change the paths to bts.%i. instead of bts%i
http://cgit.osmocom.org/osmocom-bb/commit/?id=9f97316fcf99aab2420504c318843…
commit 9f97316fcf99aab2420504c31884343613d6798c
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri Aug 5 12:22:35 2011 +0200
ctrl: Improve error handling if controlif setup fails
http://cgit.osmocom.org/osmocom-bb/commit/?id=35a1b3b493b1b11e4f6ac893b64bb…
commit 35a1b3b493b1b11e4f6ac893b64bb43f673a371d
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri May 6 16:38:11 2011 +0200
libctrl: Add function ctrl_cmd_send_to_all
Sends a command to all ctrl connections except the one it originated
from.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f2e75d437160b23f852a9144117f4…
commit f2e75d437160b23f852a9144117f4f340a396618
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri Jul 22 18:08:31 2011 +0200
libctrl: Add trap helper function
http://cgit.osmocom.org/osmocom-bb/commit/?id=782974b6c9f562be223023b25547b…
commit 782974b6c9f562be223023b25547bb0d5e258864
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri Jul 22 17:55:42 2011 +0200
libctrl: Change controlif_setup so it returns the ctrl handle
nat: Catch up with controlif_setup API change
We now save a control handle reference in the nat
osmo-bsc: Catch up with controlif_setup API change
We now save a control handle reference in the gsm network
http://cgit.osmocom.org/osmocom-bb/commit/?id=0e0cf37c44d70feb23123d7bff0ab…
commit 0e0cf37c44d70feb23123d7bff0ab89f97fc1c28
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri May 6 16:37:25 2011 +0200
libctrl: Keep track of connections in struct ctrl_handle
http://cgit.osmocom.org/osmocom-bb/commit/?id=ad6451fc982defb05c7d9cbb45163…
commit ad6451fc982defb05c7d9cbb4516342169d7334a
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Fri Mar 16 12:18:39 2012 +0100
misc: Use other size modifiers to fix compiler warnings
control_if.c:521:2: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ [-Wformat]
osmo_bsc_bssap.c:473:3: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Wformat]
mgcp_main.c:162:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformatt]
http://cgit.osmocom.org/osmocom-bb/commit/?id=1d3634e0cb6f226aa9474b0818028…
commit 1d3634e0cb6f226aa9474b08180281ce178cf461
Author: Alexander Huemer <alexander.huemer(a)xx.vu>
Date: Wed Oct 12 00:29:30 2011 +0200
libctrl: only free() msgb if it was alloc()ed
Before this patch a SIGABRT was caused when doing e.g.:
$ ncat 127.0.0.1 4249
^C
http://cgit.osmocom.org/osmocom-bb/commit/?id=4376bcc1b089920ea454fd773fb35…
commit 4376bcc1b089920ea454fd773fb35d79dd8a5f14
Author: Alexander Huemer <alexander.huemer(a)xx.vu>
Date: Tue Sep 6 00:09:48 2011 +0200
fix some "implicit declaration" warnings in osmo-nitb
http://cgit.osmocom.org/osmocom-bb/commit/?id=a6b34015af942e4eabb0d4f8b0a9a…
commit a6b34015af942e4eabb0d4f8b0a9a53daa34c3e1
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Mon Aug 22 23:44:32 2011 +0200
libctrl: Add a function to create the cmd
http://cgit.osmocom.org/osmocom-bb/commit/?id=9225ab1ecc55992a05c4be4af44a3…
commit 9225ab1ecc55992a05c4be4af44a3d6193a6507c
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Jul 28 21:38:51 2011 +0200
libctrl: Don't overwrite error reply if the verify function sets one
http://cgit.osmocom.org/osmocom-bb/commit/?id=f7c74e58799850661b34b81137b99…
commit f7c74e58799850661b34b81137b994993a40ddd2
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri Aug 5 11:48:18 2011 +0200
libctrl: Mark the cmd set/get/verify functions static
http://cgit.osmocom.org/osmocom-bb/commit/?id=b06dd3010fa6740c996f0cbffe5b6…
commit b06dd3010fa6740c996f0cbffe5b64e801b78ef0
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Fri Jul 29 10:41:24 2011 +0200
libctrl: Bind control interface to localhost
http://cgit.osmocom.org/osmocom-bb/commit/?id=19abc959702a6e019de4dc49f2c9e…
commit 19abc959702a6e019de4dc49f2c9eb462850f107
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Mon Aug 22 23:37:02 2011 +0200
libctrl: Use DCTRL as logging destination in libctrl
http://cgit.osmocom.org/osmocom-bb/commit/?id=10dfc26e8f03306ca8f96688c9a25…
commit 10dfc26e8f03306ca8f96688c9a2553a2af907e8
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Wed Aug 17 22:44:07 2011 +0200
src: port openBSC over libosmo-abis
This is a big patch that ports openBSC over libosmo-abis.
Sorry, the changes that are included here are all dependent
of libosmo-abis, splitting them into smaller pieces would
leave the repository in some intermediate state, which is
not desired.
The main changes are:
- The directory libabis/ has been removed as it now lives in
libosmo-abis.
- new configuration file format for nanoBTS and HSL femto, we
need to define the virtual e1_line and attach it to the OML
link.
- all the existing BTS drivers (nanoBTS, hsl femto, Nokia site,
BS11 and rbs2000) now use the new libosmo-abis framework.
- use r232 input driver available in libosmo-abis for bs11_config.
- use ipa_msg_recv instead of old ipaccess_read_msg function.
- delete definition of gsm_e1_subslot and input_signal_data.
These structures now lives in libosmo-abis.
Most of this patch are deletions of libabis/ which has been
moved to libosmo-abis.
This patch also modifies openBSC to use all the new definitions
available in libosmocore and libosmo-abis. In order to do that,
we have replaced the following:
- DINP, DMI, DMIB and DMUX by their respective DL* correspondences.
- SS_GLOBAL by SS_L_GLOBAL
- SS_INPUT by SS_L_INPUT
- S_GLOBAL_SHUTDOWN by S_L_GLOBAL_SHUTDOWN
- SS_INPUT by SS_L_INPUT
- S_INP_* by S_L_INP_* sub-signals
- E1INP_NODE by L_E1INP_NODE vty node
This patch has been tested with:
- one nanoBTS
- the HSL femto with the examples available under libosmo-abis
- BS11 with both dahdi and misdn drivers.
http://cgit.osmocom.org/osmocom-bb/commit/?id=0834a34063811f4501f1a1358bc9d…
commit 0834a34063811f4501f1a1358bc9df9c922ee26e
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Tue Jul 19 12:12:10 2011 +0200
libctrl: Use inttypes.h macros to make uint64_t printfs portable.
http://cgit.osmocom.org/osmocom-bb/commit/?id=18b70b5b8194233d5d34fef504b69…
commit 18b70b5b8194233d5d34fef504b69eea66374826
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Jul 13 14:14:03 2011 +0200
controlif: declare controlif_setup() in control_cmd.h
this avoids us to copy+paste external declarations over all 'main'
files.
http://cgit.osmocom.org/osmocom-bb/commit/?id=8b7a9626a20ee7de20d1e09cfa1e8…
commit 8b7a9626a20ee7de20d1e09cfa1e8491a2325d52
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Mar 17 15:37:54 2011 +0100
libctrl: Add ctrl_cmd_cpy() to copy a command
http://cgit.osmocom.org/osmocom-bb/commit/?id=e9f5894e2c72c39e55bb9173470df…
commit e9f5894e2c72c39e55bb9173470dff40de61a326
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Apr 21 11:43:55 2011 +0200
libctrl: Add commands to query counters and rate_cntr
These commands are installed in controlif_setup. Query them like this:
"rate_ctr.<interval>.<counter group>.<index>.<counter name>" for rate
counters and "counter.<counter name>" for regular counters. <interval>
may be either "abs" for absolute values or one or
"per_{sec,min,hour,day}".
It is possible to query all rate counters in a group (regardless of
index) or all counters in a group and with a certain index if you omit
<counter name> and <index> or just <counter name>.
http://cgit.osmocom.org/osmocom-bb/commit/?id=fcf010f7215cbd33b68132023ab75…
commit fcf010f7215cbd33b68132023ab756a309265a55
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu May 5 17:01:09 2011 +0200
libctrl: Add macros to help define commands
http://cgit.osmocom.org/osmocom-bb/commit/?id=1264cb404f460576690f52fdc8032…
commit 1264cb404f460576690f52fdc8032b74de0bc04e
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Thu Oct 21 15:00:36 2010 +0200
Add libctrl, an SNMP-like control interface
In contrast to the VTY interface the control interface is meant to be
used by programs.
This patch adds basic support, no commands are defined.
http://cgit.osmocom.org/osmocom-bb/commit/?id=28570a4e6208e704e8d4feed0081e…
commit 28570a4e6208e704e8d4feed0081e576d449e4ac
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 12:15:59 2014 +0200
new <osmocom/vty/ports.h> file listing VTY tcp ports
imported from http://openbsc.osmocom.org/trac/wiki/PortNumbers
http://cgit.osmocom.org/osmocom-bb/commit/?id=715e94505560236ddba8bfced8d3f…
commit 715e94505560236ddba8bfced8d3f775c6363a3b
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Aug 21 14:17:45 2014 +0200
gsm0808: Fix copy and paste pointed out by clang
The element following the identifier list was the
GSM0808_IE_LSA_INFORMATION. It is a TLV type as well
and the issue got introduced in
92107dfd3b99ab0dbb0f4770286454ad94a36de2.
Fixes:
gsm0808.c:316:40: warning: initializer overrides prior initialization of this subobject
[-Winitializer-overrides]
[GSM0808_IE_LSA_IDENTIFIER_LIST] = { TLV_TYPE_TLV },
^~~~~~~~~~~~
gsm0808.c:315:40: note: previous initialization is here
[GSM0808_IE_LSA_IDENTIFIER_LIST] = { TLV_TYPE_TLV },
http://cgit.osmocom.org/osmocom-bb/commit/?id=efe0100189a85fabddeb1e0c61dc8…
commit efe0100189a85fabddeb1e0c61dc845d983b7893
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Aug 21 14:14:38 2014 +0200
macaddr: Add some code for FreeBSD (it should work on the others too)
There doesn't seem to be a way to share this code with Linux as
it doesn't have the sockaddr_dl concept inside the getifaddrs.
I manually verified this on a FreeBSD10 box and hex decoding gave
me the correct mac address and rc was 0.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f196a02a65a71dc8687d571c94af7…
commit f196a02a65a71dc8687d571c94af75047684348f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 09:42:03 2014 +0200
ipa: use %z as format string whne printing sizeof() result
thanks to Holger for reminding me
http://cgit.osmocom.org/osmocom-bb/commit/?id=11bca8b8aae8b72c82b952b1944a7…
commit 11bca8b8aae8b72c82b952b1944a7b4e55c7c2a2
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 02:39:48 2014 +0200
ipa: fix compiler warning regarding printf (%d -> %lu)
http://cgit.osmocom.org/osmocom-bb/commit/?id=78b0868302aafc2c7a6752ab72e7b…
commit 78b0868302aafc2c7a6752ab72e7b888bdc77d12
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Aug 21 02:37:57 2014 +0200
macaddr: add #include unistd.h for close() function
this fixes a compile warning
http://cgit.osmocom.org/osmocom-bb/commit/?id=e391996947f9aa2b42377c4b797ed…
commit e391996947f9aa2b42377c4b797eda7db4f78c5c
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 22:28:23 2014 +0200
ipa: rename functions for consistency
As we are breaking builds by moving functions from libosmo-abis to
libosmocore anyway, we might as well give functions more appropriate
names. ipaccess is a company, while IPA is the multiplex protocol, and
CCM is the protocol used for establishing identities on the IPA
multiplex.
http://cgit.osmocom.org/osmocom-bb/commit/?id=28aa991c2fa8c27a3100530bf9d7a…
commit 28aa991c2fa8c27a3100530bf9d7ab5d592f4792
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Aug 20 22:06:04 2014 +0200
import various generic IPA related functions from libosmo-abis
libosmo-abis is about forming A-bis interfaces/lines by means
of E1 or the IPA multiplex (or possibly other link layers).
The IPA multiplex is used in other contexts, such as the Control
interface, or the A interface. In that context, it makes sense to
have generic IPA related functions in libosmocore.
http://cgit.osmocom.org/osmocom-bb/commit/?id=fe3e42bdcbaa3bcb336227b8d2a7a…
commit fe3e42bdcbaa3bcb336227b8d2a7aad73c636047
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Aug 18 19:19:45 2014 +0200
Add osmo_get_macaddr() function to obtain etherent mac address
This used to be private in osmo-bts/common/abis.c, where it really
didn't belong.
http://cgit.osmocom.org/osmocom-bb/commit/?id=40d56f96b907f8afb717a5d33fd72…
commit 40d56f96b907f8afb717a5d33fd72bee0f6ad1fb
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Aug 18 19:03:40 2014 +0200
osmocore: Add function osmo_macaddr_parse() to parse ETH MAC address
http://cgit.osmocom.org/osmocom-bb/commit/?id=cc27fa6479efd446065d691d888d1…
commit cc27fa6479efd446065d691d888d1729bc1be2c8
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Aug 18 15:31:04 2014 +0200
TLV: add TLVP_PRES_LEN() definition to check for existance + minimum length
This is an import from osmo-bts where it was introduced in
6b561bb7ba5f10c5fd96542a7e42de2822352a67
http://cgit.osmocom.org/osmocom-bb/commit/?id=900e180f919d788adf55202a9d56e…
commit 900e180f919d788adf55202a9d56e6ef7458de82
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Aug 18 11:34:17 2014 +0200
ipaccess.h: Add IPAC_PROTO_EXT_ORC for OML Router Control
http://cgit.osmocom.org/osmocom-bb/commit/?id=8d5180e003919326e35104d5c32c2…
commit 8d5180e003919326e35104d5c32c2c32b0714cb7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Aug 17 19:36:26 2014 +0200
abis_nm: add abis_nm_msg_disc_names[] value_string
http://cgit.osmocom.org/osmocom-bb/commit/?id=604d552e49530c6c98886da4f069f…
commit 604d552e49530c6c98886da4f069f13e1eb438b5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Aug 17 18:42:58 2014 +0200
abis_nm: introduce abis_nm_{osmo,ipa}_magic[]
... used to be oml_{osmo,ipa}_magic in osmo-bts
http://cgit.osmocom.org/osmocom-bb/commit/?id=777b056fb4eef1bde8ae670a360c7…
commit 777b056fb4eef1bde8ae670a360c766d26f093bf
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jul 7 20:00:35 2014 +0200
gprs-ns: Re-initialize the list head and free the unknown_nsvc
Fix re-initialize issue of the GPRS NS. This was found while
working on the GB Proxy tests.
==27800== Invalid write of size 4
==27800== at 0x403C263: rate_ctr_group_alloc (linuxlist.h:65)
==27800== by 0x4050974: gprs_nsvc_create (gprs_ns.c:209)
==27800== by 0x405320D: gprs_ns_instantiate (gprs_ns.c:1330)
==27800== by 0x804B212: main (gbproxy_test.c:797)
==27800== Address 0x434173c is 52 bytes inside a block of size 784 free'd
==27800== at 0x4029DA8: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==27800== by 0x4041BBD: _talloc_free (talloc.c:609)
==27800== by 0x40432B2: talloc_free (talloc.c:578)
==27800== by 0x40532D3: gprs_ns_destroy (gprs_ns.c:1363)
==27800== by 0x804B1FE: main (gbproxy_test.c:791)
http://cgit.osmocom.org/osmocom-bb/commit/?id=eb55e6aa88f5dfef10c86fae5377e…
commit eb55e6aa88f5dfef10c86fae5377e1280cf91bf7
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Jul 1 19:39:26 2014 +0200
write_queue: Use EBADF instead of EBABDFD for portability
EBADFD is linux specific while EBADF is POSIX. Fix the build on
FreeBSD and use EBADF throughout the file.
http://cgit.osmocom.org/osmocom-bb/commit/?id=77ab2f723ee221e0a12f9664383c5…
commit 77ab2f723ee221e0a12f9664383c578e62b7cd13
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Wed May 21 15:08:19 2014 +0200
vty: Avoid use-after-free in VTY telnet interface
If the read callback closes the connection conn is already freed so we
can't derefernce it. Instead return -EBADFD in the read function if it
closed the connection and check for that.
http://cgit.osmocom.org/osmocom-bb/commit/?id=17aa6b25cb0b720279f5d8221de17…
commit 17aa6b25cb0b720279f5d8221de17b01398d0143
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jun 22 16:53:55 2014 +0200
osmo-auc-gen: Fix compiler warnings about aliasing
I ran "./utils/osmo-auc-gen -2 -a COMP128v1" and verified that
the RAND doen't look empty
Fixes:
osmo-auc-gen.c: In function ‘main’:
osmo-auc-gen.c:219:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
*(uint32_t *)&_rand[0] = rand();
^
osmo-auc-gen.c:220:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
*(uint32_t *)(&_rand[4]) = rand();
^
osmo-auc-gen.c:221:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
*(uint32_t *)(&_rand[8]) = rand();
^
osmo-auc-gen.c:222:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
*(uint32_t *)(&_rand[12]) = rand();
http://cgit.osmocom.org/osmocom-bb/commit/?id=bd8a89debc48bb6696c58a346b463…
commit bd8a89debc48bb6696c58a346b463d8df18febb2
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Tue Jun 10 10:02:24 2014 +0200
write_queue: Avoid possible use-after-free if fd is read-/writable
If the FD is both readable and writable and the read callback closes the
connection (and frees the surrounding structure) we shouldn't call the
write callback (or check anything else in the read fd).
With this patch callback functions can return -EBADFD if they don't want
the FD to be handled any more.
http://cgit.osmocom.org/osmocom-bb/commit/?id=92107dfd3b99ab0dbb0f477028645…
commit 92107dfd3b99ab0dbb0f4770286454ad94a36de2
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jun 21 23:16:20 2014 +0200
update TS 08.08 header + TLV definitions to TS 48.008 / 11.7.0
This adds support for A-over-IP and LCLS related message/IEI
definitions.
Old definitions are in decimal, which is very hard (at least for me)
to compare with the binary tables in the spec. Hex is much easier
to manually compare for completeness/correctness. I didn't touch
the existing definitions, but think they should move to hex, too.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c8585cf4081207a777db43dee2be6…
commit c8585cf4081207a777db43dee2be684323fc777e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jun 21 22:28:12 2014 +0200
update gsm_08_08.h to Release 11
http://cgit.osmocom.org/osmocom-bb/commit/?id=5469ef837a9902d594d008257d627…
commit 5469ef837a9902d594d008257d627b6c09b0d970
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Mon Jun 16 16:39:08 2014 +0200
core/bitXXgen: Don't do 'return' in functions returning void
ISO C forbids 'return' with expression, in function returning void
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=3baa0d6ab5b56b80725b69e03701a…
commit 3baa0d6ab5b56b80725b69e03701af3af1680b2c
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Mon Jun 16 16:38:31 2014 +0200
core/bitXXgen: Use explicit cast of void* to uint8_t
Turns out we use this header in C++ code ...
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=26ea7068e70bbfee9fb2117431ce8…
commit 26ea7068e70bbfee9fb2117431ce8593e9df4e2a
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Mon Jun 16 15:57:36 2014 +0200
tests/bits: Make sure all 'inline' are also static
Not doing so seems to break the BSD build
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=579a7103a1738df11009d75b7bf02…
commit 579a7103a1738df11009d75b7bf02559e711a1cb
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Mon Jun 16 14:59:30 2014 +0200
gsm: Add Kasumi cipher implementation
Submitted-by: Max <max.suraev(a)fairwaves.co>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=e2c1390d1badbce07945d19ead647…
commit e2c1390d1badbce07945d19ead64704ad4056309
Author: Max <max.suraev(a)fairwaves.co>
Date: Wed Jun 4 19:07:42 2014 +0200
bits: Add left circular shift function
Submitted-by: Max <max.suraev(a)fairwaves.co>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=ece46d2a43193505ca586c3a6d73c…
commit ece46d2a43193505ca586c3a6d73c2c8aba87006
Author: Max <max.suraev(a)fairwaves.co>
Date: Wed Jun 4 19:07:41 2014 +0200
Add missing entry in .gitignore for utils_test
Submitted-by: Max <max.suraev(a)fairwaves.co>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=537770174625cd3ce5c165ab0289a…
commit 537770174625cd3ce5c165ab0289aef5d974dac3
Author: Max <max.suraev(a)fairwaves.co>
Date: Wed Jun 4 19:07:41 2014 +0200
core: Add generic LE/BE load/store uint type convertors and use them in msgb
Submitted-by: Max <max.suraev(a)fairwaves.co>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=12ba778afdb797575e05284decd34…
commit 12ba778afdb797575e05284decd34cf2c27e3647
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Mon Jun 16 10:13:40 2014 +0200
include: Switch to #pragma once pattern
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=b0a3c2f1de73cb3acd70f7c93be8f…
commit b0a3c2f1de73cb3acd70f7c93be8fc7e8925f31e
Author: Max <max.suraev(a)fairwaves.co>
Date: Tue Jun 10 19:04:59 2014 +0200
gsmtap: add LTE defines to GSMTAP v2
Submitted-by: Max <max.suraev(a)fairwaves.co>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=e28bc6876d127e1165dc7ad2ea96b…
commit e28bc6876d127e1165dc7ad2ea96b585a1161ec6
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Sun Jun 15 18:47:03 2014 +0200
build: Add .version to EXTRA_DIST
This is required to make distcheck work and apparently that's
the "good way" to do it.
See http://comments.gmane.org/gmane.comp.lib.gnulib.bugs/27780
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=da73aa640e8dc22a199d651b44d45…
commit da73aa640e8dc22a199d651b44d45e2569a6f9b1
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri May 23 08:51:22 2014 +0200
gsm0411_smr: Fix the size of the array
The code is lacking a "," at the end of a string and we ended up
doing string concatination instead of having an invalid state.
Fixes Coverity CID 1206564
http://cgit.osmocom.org/osmocom-bb/commit/?id=61d33925a02b187bcab88d391bd5b…
commit 61d33925a02b187bcab88d391bd5b037c9cc1059
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri May 23 08:49:34 2014 +0200
gsm0411_smr: Make the look-up table static
http://cgit.osmocom.org/osmocom-bb/commit/?id=8e5435a864da30ec0210f36fdff46…
commit 8e5435a864da30ec0210f36fdff464a72cc5b31a
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri May 23 08:37:02 2014 +0200
timer: Use the now parameter when it is not NULL
The code would have used an uninitialized current_time in case
"now" was not NULL. As now is const and timersub expects a non
const parameter I decided to copy now into current_time.
Fixes: CID #1040661
http://cgit.osmocom.org/osmocom-bb/commit/?id=550b06c04c5c1b1afafc53ee12744…
commit 550b06c04c5c1b1afafc53ee1274444a09ca4122
Author: Álvaro Neira Ayuso <anayuso(a)sysmocom.de>
Date: Mon May 19 19:22:55 2014 +0200
abis_nm: Add the abis_nm_osmo_att_tlvdef to the abis header
Avoid compiler warnings and declare the presence of the new
tlv_description.
Signed-off-by: Alvaro Neira Ayuso <anayuso(a)sysmocom.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=5b5650f3de0213a459b4184bab3ab…
commit 5b5650f3de0213a459b4184bab3ab2d0d833c4a4
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon May 19 11:25:46 2014 +0200
Fix introducing osmocom speficic OML attributes
Rename NM_ATT_O_REDUCEPOWER to NM_ATT_OSMO_REDUCEPOWER, which
makes it more clear that this is an osmcoom specific attribute.
Also, we cannot simply overload 0x01 as an already defined OML
attribute. The problem is quite simple: When we use abis_nm_att_tlvdef
during the TLV parse, 0x01 will match to NM_ATT_ABIS_CHANNEL,
which is defined as { TLV_TYPE_FIXED, 3 }.
So instead, we need to introduce a new abis_nm_osmo_att_tlvdef[],
which has to be patched into abis_nm_att_tlvdef[] by the means of
tlv_def_patch(), exactly how we do it for bs-11 and nanobts specific
attributes.
I'm using 0xfe for the attribute, as 0xfe doesn't overlap with the IPA
specific attribues (and we might want to combine/merge the 12.21 plus
IPA plus osmocom spefici attributes)
http://cgit.osmocom.org/osmocom-bb/commit/?id=c22d72cdedcea9dfd2f6286fb89d3…
commit c22d72cdedcea9dfd2f6286fb89d352c80808327
Author: Álvaro Neira Ayuso <anayuso(a)sysmocom.de>
Date: Mon May 5 16:04:02 2014 +0200
protocol/gsm_12_21.h: Add the Manufacturer Attribute ID O_REDUCEPOWER.
Signed-off-by: Alvaro Neira Ayuso <anayuso(a)sysmocom.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=92e1e70dbae0b36f0b090c2709658…
commit 92e1e70dbae0b36f0b090c270965881b18b9b950
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Apr 9 17:24:00 2014 +0200
select: Fix english in comment
http://cgit.osmocom.org/osmocom-bb/commit/?id=c2c042dfd796dae243d84b32e56e0…
commit c2c042dfd796dae243d84b32e56e01ea5484ad21
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Apr 17 23:19:10 2014 +0200
backtrace: Speculative fix for FreeBSD10.0 and execinfo.h
FreeBSD 10.0 ships an execinfo.h but one needs to link to an
additional library for the backtrace functions. Check if there
is a backtrace symbol in libexecinfo and if so link to that
library.
http://cgit.osmocom.org/osmocom-bb/commit/?id=0c50b17a2636a4a9d471ebbaf2cdb…
commit 0c50b17a2636a4a9d471ebbaf2cdb9396390e4cd
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Mar 31 15:36:57 2014 +0200
Release: Prepare the release of 0.6.6
http://cgit.osmocom.org/osmocom-bb/commit/?id=5ade61a4f49bbc5bdff271b3eaff0…
commit 5ade61a4f49bbc5bdff271b3eaff0fc4ffd2fb60
Author: Álvaro Neira Ayuso <anayuso(a)sysmocom.de>
Date: Mon Mar 24 13:02:00 2014 +0100
src/socket: Adding unix domain socket support
Added some function for adding the unix domain socket support.
Signed-off-by: Alvaro Neira Ayuso <anayuso(a)sysmocom.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=cc0645b26df92b007e7f4f397607e…
commit cc0645b26df92b007e7f4f397607ee235c58172e
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Fri Mar 7 21:00:19 2014 +0100
sms: Add missing brackets in the relative validity time calculation.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d0ed9218bc79a25b46023a6cc57ae…
commit d0ed9218bc79a25b46023a6cc57aedcda3fc9152
Merge: e4c50d5a 3dc4e167
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Mar 26 18:15:06 2014 +0100
Merge remote-tracking branch 'daniel/lapdm-desync'
This should fix long delays when sending a long SMS on an encrypted
channel. It is the most minimal change to the polling mode. One
option we discussed internally is to queue a higher level representation
and generate the actual LAPDm frames later.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3dc4e16786d1e5723e76ad7c70ad5…
commit 3dc4e16786d1e5723e76ad7c70ad54134957f9e5
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Thu Mar 20 19:24:48 2014 +0100
gsm/lapdm: Prevent LAPD tx_queue from filling up in polling mode
If LAPDm receives an I-Frame while there already is an I-Frame in the
tx_queue the code generates an additional RR (to acknowledge the
received I-Frame). Instead, N(R) of the I-Frame in the tx_queue should
be updated to ACK the data.
http://cgit.osmocom.org/osmocom-bb/commit/?id=09129352f99a90a784912ae3c8ff4…
commit 09129352f99a90a784912ae3c8ff442268a35480
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Thu Mar 20 18:54:57 2014 +0100
tests/lapd: Add a testcase to check for LAPDm sync issues
Regression test for LAPDm recording the current state
http://cgit.osmocom.org/osmocom-bb/commit/?id=55405fb40b080b303dcbb380ecb2d…
commit 55405fb40b080b303dcbb380ecb2d738dc8f6206
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Wed Mar 26 13:45:17 2014 +0100
lapdm: Make lapdm_datalink_for_sapi public
This API allows you to get the lapdm_datalink for a SAPI. It's needed in
the lapdm_test, so make it public.
http://cgit.osmocom.org/osmocom-bb/commit/?id=e4c50d5a43f129aa4bdfaf62a7238…
commit e4c50d5a43f129aa4bdfaf62a7238c4db671974b
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Fri Mar 7 20:42:03 2014 +0100
sms_test: Do not crash on logging.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1512ea6452c123fbf7da325422b43…
commit 1512ea6452c123fbf7da325422b4378d64b90087
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Mar 16 23:59:58 2014 +0100
lapd: Improve log message and mention the SAPI the dl is on
When debugging an issue that involves SAPI=0 and SAPI=3 the
log file does not have enough context. Add the SAPI to this
message so we at least understand which SAPI we are talking
about.
http://cgit.osmocom.org/osmocom-bb/commit/?id=e47523874da2e79e79f149f433d6a…
commit e47523874da2e79e79f149f433d6a53f230dc30c
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Sun Mar 9 11:48:16 2014 +0100
sms: Fix typo in a macros name: GSM340_SMS_RESSERVED -> GSM340_SMS_RESERVED.
http://cgit.osmocom.org/osmocom-bb/commit/?id=4b3de6840ef08b0630bafb9d4d19f…
commit 4b3de6840ef08b0630bafb9d4d19fc2d10aacdd1
Merge: 10f0bdec 8dac4159
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Mar 10 15:00:20 2014 +0100
Merge branch 'jerlbeck/fixes/ladp-sms'
http://cgit.osmocom.org/osmocom-bb/commit/?id=8dac4159adb7377f016317808e3a6…
commit 8dac4159adb7377f016317808e3a6b0c79df7fa1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jan 28 11:03:11 2014 +0100
ladpm: Fix msgb handling and SAPI=3 establishment delay
Currently it takes 3s to establish a SAPI 3 SACCH connection with
osmo-bts. This is due to the fact, that a broken SABME request is
sent first and and is ignored by the MS. Then, after a T200 timeout
(2s) the SABME command is sent again (this time correctly) and
answered by the MS.
The first SABME message is broken (it has a length field of 3 and
ends with 3 bytes from the tail of the original RSL message),
because of it is expected throughout lapdm.c that msg buffers
containing RSL have msg->l2h == msg->data. Some abis input drivers
fulfill this but IPA doesn't, thus the 3 bytes of the IPA header
are still part of the msg and confuse length computation.
Since internal fields of the msg are modified directly, this is
difficult to see.
This patch adds a new function msgb_pull_to_l3() that explicitely
skips over all headers prepending L3 and therefore resets l1h and
l2h. This function is then used instead of msgb_pull_l2h() which
only worked correctly when msg->l2h == msg->data. In addition,
code manipulating msg->tail and msg->len directly has been replaced
by calls to msgb_trim().
Note that this patch does not fix all issues of this case in the LADP
related code.
Ticket: SYS#192
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=7d5f17aa2149d67fb709ea44007c2…
commit 7d5f17aa2149d67fb709ea44007c207431aeedc7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Feb 28 15:54:03 2014 +0100
lapd/test: Check for empty ACCH queue, too
This just adds a single test to verify that the ACCH queue is
actually empty.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=c893c2233ad167585b4aa7e4246c2…
commit c893c2233ad167585b4aa7e4246c2255e32c9734
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jan 28 10:53:59 2014 +0100
lapd/test: Extend test case to test msgs having data before l2h
Since e.g. the IPA input driver leaves it's specific header in front
of msg->l2h, so that msg->l2h != msg->data. The lapdm code does not expect this at least in
rslms_rx_rll_est_req().
This patch modifies the test program to add a dummy L1 header to
generated messages (unless the test would abort when doing so).
Note that the ok file reflects the current state which is not
correct.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=2462cf6ee12452362f24510d26a4c…
commit 2462cf6ee12452362f24510d26a4c0ff19599342
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Feb 25 10:49:00 2014 +0100
lapd/test: Show dequeued messages
This adds and uses a wrapper for lapdm_phsap_dequeue_prim() that
prints information about the message that has been taken from the
queue.
http://cgit.osmocom.org/osmocom-bb/commit/?id=baa225ed867fa7357ad05b35b90c9…
commit baa225ed867fa7357ad05b35b90c9ecb7192f189
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Feb 28 15:14:40 2014 +0100
msgb: Add msgb_hexdump() function
This function works like osmo_hexdump() and returns a static buffer
containing hex bytes along with markers for the layers.
Note that it uses osmo_hexdump() internally, thus a call to
msgb_hexdump() invalidates the buffer that has been returned by an
earlier call to osmo_hexdump(). In short: don't mix them in a single
call printf().
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=10f0bdecad8d711ccc5fcc04bb0be…
commit 10f0bdecad8d711ccc5fcc04bb0be0adf11a7902
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Feb 9 20:03:38 2014 +0100
lapd: Use the right struct for the talloc_zero_array call
I saw this while playing with talloc pools and wondered why
lapd_core is creating a log_info. Use the right struct for
the array.
http://cgit.osmocom.org/osmocom-bb/commit/?id=f4f5a8489c427432b12b09ebba456…
commit f4f5a8489c427432b12b09ebba456c3ca25106a3
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Feb 8 15:14:53 2014 +0100
sms: The msg_ref is passed from the outside so remove the wrong fixme
http://cgit.osmocom.org/osmocom-bb/commit/?id=90937fe2c5505c655ed974699e43a…
commit 90937fe2c5505c655ed974699e43a5e1fc86c8cb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jan 24 13:48:19 2014 +0100
lapd/test: Add test case for RSL EST REQ -> LAPD
This test case processes RSL establish requests for SMS (SAPI 3)
on the SDCCH and the SACCH channels. The TX queues are checked
after processing each message.
Ticket: SYS#192
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=c620604dfc942e972de0ef7a7c264…
commit c620604dfc942e972de0ef7a7c264cd6033d602e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Jan 23 15:00:55 2014 +0100
lapdm: Fix typo in the comment
http://cgit.osmocom.org/osmocom-bb/commit/?id=050e9c4a1c785ca87043b606b80ad…
commit 050e9c4a1c785ca87043b606b80ad9b253a9eb12
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jan 20 10:37:42 2014 +0100
debian: Build the new upstream version of libosmocore
http://cgit.osmocom.org/osmocom-bb/commit/?id=85bc549ea5e279c08a4080a277894…
commit 85bc549ea5e279c08a4080a277894fe80f0e967e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 13 14:21:23 2014 +0100
gsm/gsm48ie: Fix range 256 W[i] decoding
Currently w[14]/w[15] and w[18]/w[19] are swapped in range 256 format
decoding in gsm48_decode_freq_list().
This patch fixes this.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=26cbd459fcc7cd7bed8256a5ad078…
commit 26cbd459fcc7cd7bed8256a5ad078c177a7a7fe2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jan 7 13:39:24 2014 +0100
sms: Fix gsm_7bit legacy functions return value
The legacy 7bit conversion functions (those without the '_n_' in the
name) gave wrong return values on 64 bit platforms due to unproper
signed/unsigned conversions and the usage of SIZE_MAX.
This patch fixes this by using a smaller max size (see
GSM_7BIT_LEGACY_MAX_BUFFER_SIZE, currently set to 64k) for the legacy
wrappers and by using unsigned int for max_septets.
In addition, there are tests now that check the return values of
legacy encoding and decoding.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=d4d87c5427bdf838cbfc3948bcf03…
commit d4d87c5427bdf838cbfc3948bcf035e1e4036fd9
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Jan 2 14:10:25 2014 +0100
abis: Use the right return value for abis_nm_pchan4chcomb
abis_nm_pchan4chcomb will return a pchan for a given channel
combination but returned a value of the channel combination.
Fix it to return the physical channel combination.
Fixes: Coverity CID 1040767
http://cgit.osmocom.org/osmocom-bb/commit/?id=324470205860303edb6ea213fc867…
commit 324470205860303edb6ea213fc8670b2b69a7f11
Author: Nils O. Selåsdal <noselasd(a)fiane.dyndns.org>
Date: Thu Jan 2 14:04:43 2014 +0100
utils: Greatly improve performance of osmo_hexdump routines
In the osmo-bts and libosmo-abis code the hexdump routine is used
for every incoming/outgoing packet (including voice frames) and the
usage of snprintf showed up inside profiles.
There is a semantic change when more than 4096 characters are used.
The code will now truncate at byte boundaries (and not nibbles).
Code:
static const int lengths[] = { 23, 1000, 52 };
char buf[4096];
int i;
for (i = 0; i < 30000; ++i)
char *res = osmo_hexdump(buf, lengths[i & 3]);
Results:
before: after:
real 0m3.233s real 0m0.085s
user 0m3.212s user 0m0.084s
sys 0m0.000s sys 0m0.000s
http://cgit.osmocom.org/osmocom-bb/commit/?id=b79a148eca01ff8f101662f389b80…
commit b79a148eca01ff8f101662f389b8032ea2d9a535
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Jan 2 13:55:00 2014 +0100
utils: Add a simple testcase for osmo_hexdump
This code makes a simple dump and tests for the corner case
http://cgit.osmocom.org/osmocom-bb/commit/?id=b7d0f4686b4aa55fd9b69884e6cc0…
commit b7d0f4686b4aa55fd9b69884e6cc0c4c79ea1cd5
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Dec 29 19:38:01 2013 +0100
logging: Copy the filter_fn and fix the IMSI filter in OpenBSC
The filter_fn has not been copied into the new structure breaking
the imsi and other filters in OpenBSC. Looking at the code we should
also introduce a callback for the reset of the context so we could
use subscr_get/subscr_put on the subscriber structure.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6308c2971149c1f4f2f13846ca1a3…
commit 6308c2971149c1f4f2f13846ca1a334a82b6519c
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Dec 12 12:31:18 2013 +0100
debian: Enable hardening options for debian
http://cgit.osmocom.org/osmocom-bb/commit/?id=4f0abc0e3eb553c94e8e409ea14a1…
commit 4f0abc0e3eb553c94e8e409ea14a1b047efe3028
Author: Max <max.suraev(a)fairwaves.ru>
Date: Mon Dec 2 11:30:32 2013 +0100
Refactor COMP128v23 implementation and add test suit
http://cgit.osmocom.org/osmocom-bb/commit/?id=56cc60dc2079a63e983d746689fd0…
commit 56cc60dc2079a63e983d746689fd03d9a48ea8f5
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 22 16:05:26 2013 +0100
gb: Remove comment about ABI changes from the Makefile
Okay. this comment thing has not worked (I totally forgot about it).
I think either we try to find ABI breakages with tools or we use
#error macros and check for a version...
http://cgit.osmocom.org/osmocom-bb/commit/?id=1fa166462317c6e5de3f5cf0dbf49…
commit 1fa166462317c6e5de3f5cf0dbf493954c65bef3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 11 09:43:06 2013 +0100
debian: Update the changelog
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=9b591b7da8e3de13b87002af66843…
commit 9b591b7da8e3de13b87002af668431dc0dea6806
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 11 09:43:05 2013 +0100
gprs: Fix VTY NSVC initialisation bug by changing gprs_nsvc_create()
Currently the field nsvci_is_valid is set to 0 in the NSVC object
returned by gprs_nsvc_create(). This was a semantic change probably
introduced by commit 5e6d679d. As a result, NSVC created via the VTY
have this flag set to 0 causing RESET_ACK messages to be rejected.
This patch changes the default behaviour of gprs_nsvc_create() to
always set this flag. So it must be set to 0 explicitely if needed
which is more intuitive and thus less error prone.
It fixes breaking connections from the Gbproxy to the SGSN.
Ticket: OW#874
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=be355cd78a5aac7d11c1b92342545…
commit be355cd78a5aac7d11c1b9234254537b3c55f2d5
Author: Kevin Redon <kevredon(a)mail.tsaitgaist.info>
Date: Sat Nov 2 18:11:01 2013 +0100
implement COMP128 version 2 and 3 A3/A8 algorithm
simple copy into C from reversed code from www.hackingprojects.net
http://cgit.osmocom.org/osmocom-bb/commit/?id=3d557b18d099249b0d60ea91c7269…
commit 3d557b18d099249b0d60ea91c72695a678c9465f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 28 13:29:11 2013 +0100
gprs: Ignore NS RESET_ACK and ALIVE_ACK without RESET
Currently those messages are answered by a NS_STATUS message when
received on an uninitialised (no NS_RESET hat been seen yet) NS_VC
which violates GPP TS 08.16 7.3.1 and 7.4.1.
This patch adds checks to gprs_ns_vc_create() and eventually returns
before the error NS_STATUS message is generated.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=e7c427165f696d844be6761a27b3d…
commit e7c427165f696d844be6761a27b3d7a66f5aa49c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 28 13:29:10 2013 +0100
grps: Add test for NS messages that shall be ignored
Several messages shall not be answered when a RESET hasn't been
received on a NS-VC:
- NS_RESET_ACK (see 3GPP TS 08.16, 7.3.1)
- NS_ALIVE_ACK (see 3GPP TS 08.16, 7.4.1)
- NS_STATUS (see 3GPP TS 08.16, 7.5.1)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ce397dee70eb03358da6eb1c1ca19…
commit ce397dee70eb03358da6eb1c1ca19ed7cf155a62
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sat Oct 26 13:35:15 2013 +0200
lapd: Extend the test to check if lapdm_channel_exit is idempotent
I have a crash with an older libosmocore and the sysmobts. I
am not sure how we can have a release for a channel where the
lapdm_channel has not gone through lapdm_channel_init. But to
prevent the crash we can promise lapdm_channel_exit to be idempotent.
It has been idempotent since f5a079f739c57d8be7c59149fd45475c402a45fc
http://cgit.osmocom.org/osmocom-bb/commit/?id=9e1cd5a5a5a431f30d4b418ef8f68…
commit 9e1cd5a5a5a431f30d4b418ef8f688d992814141
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Oct 25 11:09:26 2013 +0200
gprs: Address coverity warning for gprs_ns_tx_status result
Add a #define for the check and use this in this path as well.
Fixes: Coverity CID 1103092
http://cgit.osmocom.org/osmocom-bb/commit/?id=726e2729fa264fa3221e567b42c49…
commit 726e2729fa264fa3221e567b42c49f2007a369fb
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Oct 25 11:05:10 2013 +0200
gprs: Address coverity warning on unchecked return of gprs_ns_tx_reset_ack
Fixes: Coverity CID 1111545
http://cgit.osmocom.org/osmocom-bb/commit/?id=7c91bfdd4e8a91d4888e772a6adbe…
commit 7c91bfdd4e8a91d4888e772a6adbe8d406c2e599
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Oct 25 11:02:05 2013 +0200
gprs: Address coverity warning on unchecked return of gprs_ns_tx_status
We could consider creating a CHECK MACRO that will print a message
in case of a tx failure.
Fixes: Coverity CID 1111544
http://cgit.osmocom.org/osmocom-bb/commit/?id=0cccf408602f509943c6556676327…
commit 0cccf408602f509943c6556676327f3cb18b5f59
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Oct 25 11:00:23 2013 +0200
gprs: Make sure that the buf is NULL terminated at the end
Fixes: Coverity CID 1107253
http://cgit.osmocom.org/osmocom-bb/commit/?id=7fcb3ce2dfb60d8114f7a0533a78c…
commit 7fcb3ce2dfb60d8114f7a0533a78c2b5d94be87b
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Oct 25 09:51:17 2013 +0200
debian: Update the changelog
http://cgit.osmocom.org/osmocom-bb/commit/?id=54b8b2dfefae7d495aa17c3e187b3…
commit 54b8b2dfefae7d495aa17c3e187b317a0a6243cd
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 24 01:33:25 2013 +0200
gb: Create new NSVC object instead of patching the NSVCI
When a RESET is received on the same link with a different NSVCI from
a BSS on a dynamically created NS connection do not patch the nsvc
object but create a new one instead. Thus the NSVCI is never modified
at a nsvc object after the NS-VC has been established.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=ab852ee23439725360f28c63d20ab…
commit ab852ee23439725360f28c63d20ab61b0d774b2b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 24 01:33:24 2013 +0200
gb: Fix RESET handling with changing NSEI
This modifies the NS stack's behavior to accept RESET and RESET_ACK
NSEI changes for NS-VC dynamically created by RESET messages from
BSSes. This feature is not used for NS-VC configured via VTY or NS-VC
to a SGSN.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=5405a104bbe7d3711fe6f19ea7d0f…
commit 5405a104bbe7d3711fe6f19ea7d0fce50ef91147
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 24 01:33:23 2013 +0200
gb: Fix NS RESET/RESET_ACK abnormal cases
This changes the implementations for the reception of RESET and
RESET_ACK to be compatible with 3GPP TS 08.16, 7.3.1:
- Just send a RESET_ACK with correct values back to the SGSN when a
RESET with an invalid NSVCI or NSEI has been received.
- Check RESET_ACK for matching NSEI and NSVCI.
- Ignore unexpected RESET_ACKs.
In addition, use RESET_ACK from a BSS to update the BSS source
address based on the NSVCI to be tolerant with changing UDP source
addresses/ports.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=81d7c14756ee17c2748c3d34a198c…
commit 81d7c14756ee17c2748c3d34a198c640655fd0c6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 24 01:33:22 2013 +0200
gb: Add test cases for NS RESET procedures
Add a test handling proper and mismatching RESETs. The latter may
occur, when ports change within a NS-VC without the SGSN getting
notice.
This tests for the behavior of the NS protocol stack for RESET and
RESET_ACK messages which changing/invalid NSEI and NSVCI like it is
being described in 3GPP TS 08.16, 7.3.1.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=a52ba0175f0e84c06faeb582414e4…
commit a52ba0175f0e84c06faeb582414e4dc2dfe458c3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 24 01:33:21 2013 +0200
gb: Fix gprs_nsvc_delete() to free ctr group
This fixes a SEGV error that happens the next time the statistics
are updated.
Addresses:
Program terminated with signal 11, Segmentation fault.
#0 0xb7711fa5 in rate_ctr_group_intv (grp=<optimized out>) at
rate_ctr.c:107
107 for (i = 0; i < grp->desc->num_ctr; i++) {
#0 0xb7711fa5 in rate_ctr_group_intv (grp=<optimized out>) at
rate_ctr.c:107
#1 rate_ctr_timer_cb (data=0x0) at rate_ctr.c:129
#2 0xb770ec59 in osmo_timers_update () at timer.c:243
#3 0xb770ef7a in osmo_select_main (polling=0) at select.c:133
#4 0x08049987 in main (argc=3, argv=0xbfba8084) at
gb_proxy_main.c:306
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=35fe87c68622e4472f752ec82b0df…
commit 35fe87c68622e4472f752ec82b0df58ae72e79a1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 24 01:33:20 2013 +0200
gb/vty: Fix the VTY node string for L_NS_NODE
Use 'config-ns' instead of plain 'ns' and append a blank after the
'#' to make the vty python test script work.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=687b69087661237eb7b2ca34bd769…
commit 687b69087661237eb7b2ca34bd769ed715381cb6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 24 01:33:19 2013 +0200
gb/vty: Perform NS-VC operations based on NS-VCI
This adds a 'nsvc nsvci <0-65535> (block|unblock|reset)' vty
command. It selects the NS-VC based on the nsvci instead of using the
first with a matching NSEI, like it is done when the 'nsei' keyword
is used instead.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=317de52dfc6d9b66d21d01e283c96…
commit 317de52dfc6d9b66d21d01e283c9620e8ce3bd7d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Oct 17 14:50:15 2013 +0200
misc: Ignore generated files
* compile is generated by newer automake
* ignore the test binary
http://cgit.osmocom.org/osmocom-bb/commit/?id=81286a7f43a97b3ea37f9ad640fc0…
commit 81286a7f43a97b3ea37f9ad640fc04928286b486
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Oct 17 14:49:02 2013 +0200
debian: Bump the changelog for some new packages
http://cgit.osmocom.org/osmocom-bb/commit/?id=bf0219654b09b6d8f3bc2c9f4d48c…
commit bf0219654b09b6d8f3bc2c9f4d48c065b47f2983
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 17 13:58:35 2013 +0200
gb: Fix gprs_active_nsvc_by_nsei()
The state matching condition is inverted. This is corrected by this
fix.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=0d4e949e229a649ffd0503d8e930d…
commit 0d4e949e229a649ffd0503d8e930dba8be7dd34d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 17 13:58:34 2013 +0200
gb: Test sending messages to the SGSN
This adds tests for the gprs_ns_sendmsg() function. For this it
merges back functions from the gbproxy test.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=f41e5e6c5d964896b62746be70e39…
commit f41e5e6c5d964896b62746be70e39d34c1a83a53
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Oct 10 14:17:51 2013 +0200
release: Prepare the 0.6.4 release of libosmocore
New interfaces and ABI incompatible changes in the GB library
http://cgit.osmocom.org/osmocom-bb/commit/?id=16ae51eb19eedf5a1a636bdcb9314…
commit 16ae51eb19eedf5a1a636bdcb93142c4ad12be38
Author: Alexander Huemer <alexander.huemer(a)xx.vu>
Date: Sun Oct 6 21:55:09 2013 +0200
ussd: Fix text of RELEASE COMPLETE
Before the assigned value (0xFF) was truncated, reg->text[0] is of
type char. A corresponding test for the same value in openbsc could
only fail.
http://cgit.osmocom.org/osmocom-bb/commit/?id=5e6d679df39e5e20b55ef24754a4e…
commit 5e6d679df39e5e20b55ef24754a4e6310c9bcad2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 14 22:06:48 2013 +0200
gb: Fix gprs_ns_rx_reset to not create NS-VC duplicates
Under special circumstances (see below) receiving a NS-RESET leads to
duplicated NS-VC entries.
This happens when the source port of a NS-VC changes to a new one
that has already been used by another NS-VC.
This patch changes gprs_ns_rx_reset() to check for this case and to
use the existing NS-VC object. The NS-VC object that was associated
with the source address before is detached from this source but kept
in the NS-VC list so that it can be reattached when a correspondent
NS-RESET is received later on. Meanwhile it will have a cleared link
layer address which will not match a real link info.
A new counter NS_CTR_REPLACED is incremented each time when the NS-VC
object is replacing another one. A new signal S_NS_REPLACED is added
which gets dispatched in this case, too.
Another new counter NS_CTR_NSEI_CHG is incremented each time when the
NSEI of a NS-VC object (with fixed NSVCI) changes.
Ticket: OW#874
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=96550e03214697be2d1b303a690ef…
commit 96550e03214697be2d1b303a690ef10ea3bb12b7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 14 22:06:47 2013 +0200
gb: Add functions to access the LL part of the NS-VC objects
Adds the functions gprs_ns_ll_copy() and gprs_ns_ll_clear(). Renames
gprs_ns_format_peer() to gprs_ns_ll_str(). All of these functions
uniformly access the link layer part within the NS-VC objects.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=6901715124d53574dc607d5401051…
commit 6901715124d53574dc607d540105128573808b24
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Oct 14 12:03:54 2013 +0200
gb: When sending on a NS-VC group use the first active NS-VC
Currently this first NS-VC with a matching NSEI is always used to
send a UNITDATA message via gprs_ns_sendmsg(). If the NS-VC found is
either dead or blocked, an error is returned.
This patch changes to code to skip blocked or dead NS-VCs while
searching and return the error if no usable NS-VC is found. This
makes it possible to have several NS-VCs per connection group.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=34fc4701c7681a4855534c20a6f59…
commit 34fc4701c7681a4855534c20a6f59d12c4c81521
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 9 11:27:04 2013 +0200
tests/gb: Show invoked signals in test output
Register an osmo signal handler to print a short notice about every
SS_L_NS signal that is generated while processing the tests.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=2c9168cf34d370b4ea2b21177402d…
commit 2c9168cf34d370b4ea2b21177402d01a7cfffea8
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Oct 10 20:21:33 2013 +0200
vty: Make vty_event dispatch signals and use it in the testcase
The testcase didn't work on Ubuntu 12.04 because vty_create will
directly call vty_event (e.g. not through the plt). This means
that the approach to override vty_event in the testcase failed.
Use the signal interface of libosmocore and make the testcase
use it. The signals can be generally useful as well.
http://cgit.osmocom.org/osmocom-bb/commit/?id=4cb8b94db8180e84a55c3ef880445…
commit 4cb8b94db8180e84a55c3ef88044507111077783
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Oct 10 15:20:23 2013 +0200
debian: Print test results in case of a failure
http://cgit.osmocom.org/osmocom-bb/commit/?id=b6390f9bd899370317ae2cd96271b…
commit b6390f9bd899370317ae2cd96271b21f07fdf637
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 8 12:04:46 2013 +0200
gb: Use the NS-VCI to find an existing NS-VC
Currently when a NS-RESET is recevied over a link that has not yet
been associated with a NS-VC, the NSEI is used to find an existing
NS-VC. If one is found, the reset procedure is initiated.
This behaviour is not conformant with 3GPP TS 08.16 (see chapter
4.2.3) which allows to use several NS-VC between two endpoints in
parallel.
The patch changes the implementation to use the NSVCI instead
of the NSEI to search for an existing NS-VC object.
Ticket: OW#874
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=05395a63b77e97217fc5ffa84ab37…
commit 05395a63b77e97217fc5ffa84ab375adfcaca244
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 8 12:04:45 2013 +0200
gb: Fix NS-RESET response message order
According to 3GPP TS 08.16, 7.3 "Reset procedure" the entity
receiving a NS-RESET PDU responds with a NS-RESET-ACK and 'then'
starts the test procedure which essentially means, that a NS-ALIVE
gets sent and a timer is started.
Currently the NS-ALIVE is sent before the NS-RESET-ACK.
This patch fixes the implementation by reversing the order in which
these messages are sent.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=84cdc70e0bbeddf33404df472f3c9…
commit 84cdc70e0bbeddf33404df472f3c992f5446ff12
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 8 12:04:44 2013 +0200
gb: Separate nsvc creation from NS message processing
This patch refactors gprs_ns_rcvmsg() by moving the parts relevant to
the NS messages into the new functions gprs_ns_vc_create() (nsvc
object creation) and gprs_ns_process_msg() (main NS automaton). These
do not contain code that directly depends on the link layer (they
call other functions that still do). This reduces the gprs_ns_rcvmsg()
function to calling these two functions and optionally setting up the
link layer specific fields of the nsvc.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmocom-bb/commit/?id=dcce196be96c842bde791f8838a07…
commit dcce196be96c842bde791f8838a07206fd9fdd24
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 8 12:04:43 2013 +0200
tests/gb: Add test for GPRS NS protocol
This tests the connection establishment by directly calling
gprs_ns_rcvmsg() and printing the resulting messages and the
NS-VC list.
http://cgit.osmocom.org/osmocom-bb/commit/?id=73ae7a9ca0b9f2bbf4a6800ed8e9a…
commit 73ae7a9ca0b9f2bbf4a6800ed8e9aa9bbd99d597
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 8 12:04:42 2013 +0200
tests: Fix warnings
This fixes warnings that are raised by missing includes, missing casts,
missing return statements, using printf %lu with uint64_t, and unused
symbols.
http://cgit.osmocom.org/osmocom-bb/commit/?id=42e0dc0cc3d20b4c222151dc7a9b5…
commit 42e0dc0cc3d20b4c222151dc7a9b5e63dabac734
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 8 12:04:41 2013 +0200
msgb: Add may_alias attribute to struct libgb_msgb_cb
This explicitely allows aliasing of this struct to avoid the warning
shown below. Note, that this warning isn't show when
'-fno-strict-aliasing' is used.
Addresses:
gb/gprs_ns_test.c:85:54: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
http://cgit.osmocom.org/osmocom-bb/commit/?id=bb9f89745a96dc2b1452a05d4b0e2…
commit bb9f89745a96dc2b1452a05d4b0e260c276a5779
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Oct 8 13:57:51 2013 +0200
tests: Fix the sms_test and use the right array
It started to behave weird on Debian Testing (GCC 4.8), I compiled it
with address sanitizer support and set a breakpoint in
__asan_report_error to get a backtrace.
http://cgit.osmocom.org/osmocom-bb/commit/?id=5b6416a729b46aab8ac7ea25a7ec9…
commit 5b6416a729b46aab8ac7ea25a7ec91f3afeaf4fc
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Sep 16 14:13:25 2013 +0200
bssgp: Address various compiler warnings in the bssgp code
gb/bssgp_fc_test.c: In function ‘fc_out_cb’:
gb/bssgp_fc_test.c:46:1: warning: no return statement in function returning non-void [-Wreturn-type]
gb/bssgp_fc_test.c: In function ‘fc_in’:
gb/bssgp_fc_test.c:56:1: warning: no return statement in function returning non-void [-Wreturn-type]
gb/bssgp_fc_test.c: In function ‘test_fc’:
gb/bssgp_fc_test.c:79:3: warning: implicit declaration of function ‘usleep’ [-Wimplicit-function-declaration]
http://cgit.osmocom.org/osmocom-bb/commit/?id=1c3f088c1fee825946c4e9607d7f3…
commit 1c3f088c1fee825946c4e9607d7f39a18775164c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Sep 16 10:29:57 2013 +0200
gsm48: Added 'Network Daylight Saving Time' info element
This information element has been added to the MM Information
message in GSM24.008. This patch adds it to the tlv_definition
to keep the TLV parser from breaking.
Ticket: OW#978
http://cgit.osmocom.org/osmocom-bb/commit/?id=b3657e121645977a494c489508381…
commit b3657e121645977a494c48950838129cb5fd0cd5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 10 14:04:54 2013 +0200
vty: Allow vty_go_parent() in all nodes.
This patch removes an assertion of node > CONFIG_NODE and changes
the function to handle all nodes properly.
For the sake of completeness, the generic 'exit' command
implementation is extended to work properly with all nodes, too.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6ef71b062b9e8ddfcc1cf43aaf4a6…
commit 6ef71b062b9e8ddfcc1cf43aaf4a640a8b21c38e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Sep 10 11:17:46 2013 +0200
vty: Fix compiler warning in the test
http://cgit.osmocom.org/osmocom-bb/commit/?id=2349721d801d63f450e585b0938f7…
commit 2349721d801d63f450e585b0938f76abd5150e79
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 10 09:07:31 2013 +0200
vty: Replace 'enum node_type' by 'int' for last_node
In this case the last_node variable may hold values that are not
in enum node_type, so int is used instead.
http://cgit.osmocom.org/osmocom-bb/commit/?id=0c987bd83b2b23f3f125c74f4a653…
commit 0c987bd83b2b23f3f125c74f4a653c2fd2ae8c92
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Sep 6 16:52:00 2013 +0200
vty: Add vty_install_default() and use for the vty nodes
This adds the vty_install_default() function that is basically the
install_default() function plus the registration of the commands
'exit' and 'end'. The latter is only provided in subnodes of
ENABLED_NODE and CONFIG_NONE.
The VTY test program is extended to check these commands.
Ticket: OW#952
http://cgit.osmocom.org/osmocom-bb/commit/?id=7eed0538ae79394a10ac9667a7982…
commit 7eed0538ae79394a10ac9667a798237457ac2373
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Sep 6 16:51:59 2013 +0200
vty: Refactored vty_go_parent(), 'end' and 'exit'
Put all 'exit' logic into vty_go_parent() and replace the
implementations of 'exit' and 'end' by generic ones that use
vty_go_parent().
http://cgit.osmocom.org/osmocom-bb/commit/?id=2442e096585302dee6287495d1b3d…
commit 2442e096585302dee6287495d1b3d03cb712dcda
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Sep 6 16:51:58 2013 +0200
vty: Rename is_config() to is_config_child()
The function is_config() returns 0 for CONFIG_NODE. Since that node
is a config node, the function is renamed to resolve this.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6145a2569fced13f18c4da200b9ba…
commit 6145a2569fced13f18c4da200b9ba2070e643079
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Sep 4 12:12:58 2013 +0200
misc: Include time.h for time_t on FreeBSD
Fix the build after I changed the order of header files in the
SMS test.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d71a006cf6c51eb0bc1300ccdd379…
commit d71a006cf6c51eb0bc1300ccdd3793572e132edd
Merge: c4cc9240 4d7e49bc
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Sep 4 10:41:21 2013 +0200
Merge branch 'zecke/features/alpha-numeric'
http://cgit.osmocom.org/osmocom-bb/commit/?id=4d7e49bc0a094c27352f43cad0a85…
commit 4d7e49bc0a094c27352f43cad0a8556a9bd3befa
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Thu May 2 22:37:16 2013 +0200
sms: Implement encoding the address as alphanumeric type
The number of digits is the number of used octets times two (two
digits per octet). The result has been successfully dissected by
wireshark. It has not been tested with real phones.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c4cc924074bff7e560380851d9278…
commit c4cc924074bff7e560380851d92782b255083075
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Aug 15 10:38:05 2013 +0200
core: Remove defined() check for OSMO_DEPRECATE
This reverts commit bf991bc0f3006eddf45d494ee7e476a75dbaf36e and
fixes the bug instead. It's just sufficient to remove the defined()
test, since identifiers that aren't macros are just considered as
0 when used with #if. (see cpp info page, section 4.2.2 'If'
in cpp-4.6.info)
http://cgit.osmocom.org/osmocom-bb/commit/?id=bf991bc0f3006eddf45d494ee7e47…
commit bf991bc0f3006eddf45d494ee7e476a75dbaf36e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Aug 14 20:40:31 2013 +0200
core: Fix-up the OSMO_DEPRECATED for older compilers
The code started to use #if defined(...) but the value was always
for GCC/Clang. The only difference was that for older compilers
the value of the definition was 0. Conditionally define these
macros.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3f74d9e76795ef20ee401bbe712dd…
commit 3f74d9e76795ef20ee401bbe712dd72733bfa77f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Aug 14 18:13:45 2013 +0200
core: Support clang with OSME_DEPRECATED
Separate feature checking from implementation. Supported are clang and
gcc.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3c761c8d8a3c7c2ebad6b088e3a8d…
commit 3c761c8d8a3c7c2ebad6b088e3a8ddeec9d690e0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Aug 14 18:13:46 2013 +0200
conv: Fix main() of conv_test to compile with clang.
Fix type of argument 'argv'.
Addresses:
conv/conv_test.c:358:5: error: second parameter of 'main' (argument
array) must
be of type 'char **'
int main(int argc, char argv[])
http://cgit.osmocom.org/osmocom-bb/commit/?id=6b2621883f4c0ce446bae52198c61…
commit 6b2621883f4c0ce446bae52198c6169c02efda6b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Aug 14 12:26:27 2013 +0200
core: Move OSMO_DEPRECATED to new core/defs.h file
Add a new core/defs.h file for definitions that can be used from
within header files without including prototypes and extern
declarations. It's primarily meant for macro definitions and basic
typedefs.
Move the definition of OSMO_DEPRECATED there and use compiler version
info to avoid compiler errors.
http://cgit.osmocom.org/osmocom-bb/commit/?id=30fbcf5a4134945cb24d50e7fa215…
commit 30fbcf5a4134945cb24d50e7fa2151d05241a1f6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Aug 12 17:13:19 2013 +0200
tests: Move expensive tests to the end of the list
This lets make check fail earlier (in average) to shorten the
debugging cycle time.
http://cgit.osmocom.org/osmocom-bb/commit/?id=3f69ceb3a466750c0029fb25688c3…
commit 3f69ceb3a466750c0029fb25688c3daa34adf307
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Aug 12 18:31:59 2013 +0200
sms: Disable deprecated message
This is a workaround to make the FreeBSD8.4 and Debian6.0 target
build again. The deprecated attribute doesn't have arguments.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1810925dfb6115f50d6b82eede833…
commit 1810925dfb6115f50d6b82eede833468145349c0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Aug 12 17:07:54 2013 +0200
sms: Added comment about the gsm_7bit_alphabet table
The table structure is not intuitive, so this comment shall aid to
understand this.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1d7f3b5eb27154b5d1ef698b40edf…
commit 1d7f3b5eb27154b5d1ef698b40edfb9f74a9d4d2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Aug 12 17:07:53 2013 +0200
sms: Added result buffer size parameter to 7bit conv funs
The 7bit<->8bit encoding/decoding functions didn't check whether
there is still enough space in the destination buffer. Therefore a
buffer size parameter has been added to each of the functions which
is used to truncate the output if the buffer is too small.
In addition, the return value of the decoding functions has been
changed to number of characters written (excluding \0), so this
value is always equal to strlen(decoded).
The old functions are still available as wrapper functions.
http://cgit.osmocom.org/osmocom-bb/commit/?id=9a935e27b59b5b51713d0030970c8…
commit 9a935e27b59b5b51713d0030970c8c758e2ba385
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Aug 12 11:47:12 2013 +0200
debian: Split libosmocore into various libs and address lintian warnings
Package the various libraries separately. This will allow to install
libosmogsm3 and libosmogsm4 in parallel.
E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmocore.la
E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmogb.la
E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmogsm.la
E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmovty.la
W: libosmocore-dbg: wrong-bug-number-in-closes l54:#nnnn
W: libosmocore: wrong-bug-number-in-closes l54:#nnnn
W: libosmocore: package-name-doesnt-match-sonames libosmocodec0 libosmocore4 libosmogb2 libosmogsm4 libosmovty0
http://cgit.osmocom.org/osmocom-bb/commit/?id=9b037a6a7a16bf580906e3197a54a…
commit 9b037a6a7a16bf580906e3197a54a366ac26060c
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Jul 11 08:17:02 2013 +0200
lapd: Remove the double NULL check idiom with msgb_free
if (ptr)
msgb_free(ptr)
extends to:
if (ptr)
talloc_free(ptr)
And according to the talloc documentation a talloc_free(NULL)
will not crash: "... Likewise, if "ptr" is NULL, then the function
will make no modifications and returns -1."
http://cgit.osmocom.org/osmocom-bb/commit/?id=73fa6427aa5df95728eab41ec1b24…
commit 73fa6427aa5df95728eab41ec1b24f04a0dcf51e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Aug 9 17:48:06 2013 +0200
debian: Create a new upstream changelog entry
http://cgit.osmocom.org/osmocom-bb/commit/?id=f136013f0d2c2b3156ff3ba26c625…
commit f136013f0d2c2b3156ff3ba26c6257d83e66187b
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Aug 9 17:40:08 2013 +0200
gsm: The LAPDm prim/structs changed, increment current version
http://cgit.osmocom.org/osmocom-bb/commit/?id=8a1666b1bf630f62f635028edcf49…
commit 8a1666b1bf630f62f635028edcf49b0f069b9e7a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Aug 8 12:38:54 2013 +0200
ussd: Changed 7bit test to check spec conformance directly
Renamed gsm_7bit_ussd() to test_7bit_ussd() and extended the function
to take the expected binary encoding and eventually added trailing
bytes in the re-decoded text as arguments. These are used to check
assertions of the right behaviour instead of solely relying on
regression data, because the value are determined by the spec and
fixed and it is more obvious this way. Especially concerning the case
with the duplicated \r which can easily be overlooked when it's only
present in the ok file.
http://cgit.osmocom.org/osmocom-bb/commit/?id=9597555a362cd28c02e9bbfe4f55c…
commit 9597555a362cd28c02e9bbfe4f55c4b90ecdfa34
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Thu Aug 8 12:38:53 2013 +0200
Add special 7-bit encoding and decoding functions for USSD coding
Handling 7-bit coding is a little different for USSD, as TS 03.38
states:
To avoid the situation where the receiving entity confuses 7 binary
zero pad bits as the @ character, the carriage return or <CR>
character shall be used for padding in this situation [...].
If <CR> is intended to be the last character and the message
(including the wanted <CR>) ends on an octet boundary, then another
<CR> must be added together with a padding bit 0. The receiving entity
will perform the carriage return function twice, but this will not
result in misoperation as the definition of <CR> [...] is identical to
the definition of <CR><CR>.
The receiving entity shall remove the final <CR> character where the
message ends on an octet boundary with <CR> as the last character.
Jacob has verified the fix with fakeBTS and the wireshark dissector.
Fixes: OW#947
Reviewed-by: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=6bfa7445fca074fdf94707681d93e…
commit 6bfa7445fca074fdf94707681d93e92ec0993bbd
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Thu Aug 8 12:38:52 2013 +0200
encoding: Provide an overload for the gsm_7bit_encode and a simple test
This is required for encoding the SMS header using the alpha numeric
rules.
Reviewed-by: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
http://cgit.osmocom.org/osmocom-bb/commit/?id=94b2f64ae735b85e7b7c42a76b545…
commit 94b2f64ae735b85e7b7c42a76b5456dd09e00b2b
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Aug 7 11:09:43 2013 +0200
gsm: Try to clarify why we have gsm_septet_encode in the header file
These functions are not meant to be used by applications and are
only here for the unit tests. Try to document that.
http://cgit.osmocom.org/osmocom-bb/commit/?id=cd195fa267b1869156e6d675032fd…
commit cd195fa267b1869156e6d675032fdafe3035bf5e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Aug 6 14:29:15 2013 +0200
vty: Support multi-char separators and end strings
In vty_cmd_string_from_valstr() include the real string lengths of
the sep and end arguments into the buffer size calculation.
http://cgit.osmocom.org/osmocom-bb/commit/?id=ae15a2cac1a01e98e34b4ccd8932a…
commit ae15a2cac1a01e98e34b4ccd8932ae8f1b99186c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Aug 6 14:29:14 2013 +0200
vty: Fix misusage of snprintf in vty/utils.c
Compiled with ubuntu 1204 (precise), where -Wformat-security is enabled by
-Wall.
Test yields ok, but the current implementation doesn't properly support
multi-character separators and end strings. So the test output is truncated.
Addresses:
utils.c: In function 'vty_cmd_string_from_valstr':
utils.c:84:2: warning: format not a string literal and no format arguments [-Wformat-security]
utils.c:84:2: warning: format not a string literal and no format arguments [-Wformat-security]
utils.c:108:2: warning: format not a string literal and no format arguments [-Wformat-security]
utils.c:108:2: warning: format not a string literal and no format arguments [-Wformat-security]
http://cgit.osmocom.org/osmocom-bb/commit/?id=a652abc5bf75435ba7f1c96ed914c…
commit a652abc5bf75435ba7f1c96ed914cf5805fc326f
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jul 14 09:11:47 2013 +0200
utils: Fix compiler warnings n the osmo-auc-gen utility
osmo-auc-gen.c:217:3: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
osmo-auc-gen.c:249:3: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t’ [-Wformat]
Fixes: Coverity CID 1040668
http://cgit.osmocom.org/osmocom-bb/commit/?id=6a75d16c6d8f9718c925d20853808…
commit 6a75d16c6d8f9718c925d208538088404c6942aa
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jul 14 09:07:11 2013 +0200
vty: Fix logically dead code in the description handling
The code most likely wanted to check the result of argv_concat.
To do this we need to dereference the dptr.
Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement "return 1;
Fixes: Coverity CID 1040675
http://cgit.osmocom.org/osmocom-bb/commit/?id=2909942a9fe54a8c1f98588dcfece…
commit 2909942a9fe54a8c1f98588dcfece6f4fe35d100
Author: Dmitri Soloviev <dmi3sol(a)gmail.com>
Date: Thu Jul 11 09:25:37 2013 +0200
gsm0808.c: Add TLV definition for LAYER3_HEADER_INFORMATION
This is required for osmo-bsc to parse Alcatel S-12 CIPHER MODE COMMAND
in osmo-bsc.
http://cgit.osmocom.org/osmocom-bb/commit/?id=cad54b8fb7b0eaec12ee13a5b5cc9…
commit cad54b8fb7b0eaec12ee13a5b5cc9ef920152fd2
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Tue Jul 9 20:25:24 2013 +0200
LAPD: Free resume/re-establishment msgb if it carries no content
lapdm.c takes the re-establishment message and forwards it to lapd_core.c,
so we can assume that msgb is set at primitive. In case there is data in
the re-establishment msg, it is moved into send_buffer. In case of no
data (0 length), it must be freed.
Fixes an issue spotted by Coverity Scan.
http://cgit.osmocom.org/osmocom-bb/commit/?id=47aa482bb0094edfc21bbb45dc0f0…
commit 47aa482bb0094edfc21bbb45dc0f0e8c9c42c521
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Sun Jul 7 13:54:53 2013 +0200
gsm: Revert the gsm_7bit_encode changes as they are wrong
This reverts commit f996b05dbddccb8e8788dd69777a4fedfa2373eb
and 2b0cac4ef83137ee0bdd583aee877eac467abeab. A detailed
explanation can be found here:
http://lists.osmocom.org/pipermail/openbsc/2013-July/004737.html
The short description is that:
1.) The API should return (as out parameter) the number of
octets used.
2.) The handling for the <CR> encoding only applies to USSD
and it is incomplete. On top of that it broke the SMS test.
http://cgit.osmocom.org/osmocom-bb/commit/?id=98de27a18740ea147ffee634ed3d2…
commit 98de27a18740ea147ffee634ed3d2006329b254f
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jul 6 23:54:09 2013 +0200
make lapd_test compile again.
For whatever reason two functions were present twice in the code,
probably some git merge/rebase artefact?
http://cgit.osmocom.org/osmocom-bb/commit/?id=b8add369e38b18f2bb25e7582a6c7…
commit b8add369e38b18f2bb25e7582a6c7e703c0b6407
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jul 6 23:49:41 2013 +0200
utils.h: we need to include utils.h for osmo_generate_backtrace()
this causes compiler warnings in user code ever since commit
55cf02221f0654a3f48888f3b13766b671a120f0
http://cgit.osmocom.org/osmocom-bb/commit/?id=1342bed6f961ad6dafb5db7cfb045…
commit 1342bed6f961ad6dafb5db7cfb0459278506b08a
Merge: 8d50600d 2b0cac4e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jul 6 23:36:57 2013 +0200
Merge branch 'jolly/trx'
http://cgit.osmocom.org/osmocom-bb/commit/?id=2b0cac4ef83137ee0bdd583aee877…
commit 2b0cac4ef83137ee0bdd583aee877eac467abeab
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Thu Jul 4 09:51:33 2013 +0200
Fix: Handle returned length by gsm_7bit_encode correctly
http://cgit.osmocom.org/osmocom-bb/commit/?id=f996b05dbddccb8e8788dd69777a4…
commit f996b05dbddccb8e8788dd69777a4fedfa2373eb
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Thu Jul 4 09:44:47 2013 +0200
Fix encoding of last character at 7bit encoding function
To avoid the situation where the receiving entity confuses 7 binary zero pad
bits as the @ character, the carriage return or <CR> character shall be used
for padding in this situation.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c62a1bf4d53edec94b0db05da717d…
commit c62a1bf4d53edec94b0db05da717d24438824357
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Tue Jul 2 09:10:11 2013 +0200
libosmogb: Add function to close NS instance without destroying it
http://cgit.osmocom.org/osmocom-bb/commit/?id=c8cac64abbf91b1a515010b43347a…
commit c8cac64abbf91b1a515010b43347ab408caf2549
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Wed Jun 19 20:58:59 2013 +0200
Fix RR cause values
http://cgit.osmocom.org/osmocom-bb/commit/?id=5977db0faf88dc75b56d0ddf37aef…
commit 5977db0faf88dc75b56d0ddf37aefb5019a114dd
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Wed Jun 12 09:34:51 2013 +0200
LAPDm: Allow sending unit data on DCCH
It is used to transfer PHYSICAL INFORMATION message to the MS.
http://cgit.osmocom.org/osmocom-bb/commit/?id=ccc463355d752034db9d380d590d3…
commit ccc463355d752034db9d380d590d3acc220cf79e
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Wed Jun 12 09:25:27 2013 +0200
LAPDm: Fix re-establishment of datalink
If the datalink fails or if handover or assignment to a new channel fails,
it is re-establised by sending SABM again. The length of establish message
is 0 in this case. The length is used to differentiate between
re-establishment and contention resolution, which has to be handled
differently.
See TS 04.06 Chapter 5.4.2.1
http://cgit.osmocom.org/osmocom-bb/commit/?id=610517c8bd5f9e87729acdb4529c0…
commit 610517c8bd5f9e87729acdb4529c0870b0b5dced
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Wed Jun 12 09:21:18 2013 +0200
Add chan_nr to RACH info at L1SAP interface
The chan_nr is required to locate timeslot and subslot of access bursts
during handover procedure.
http://cgit.osmocom.org/osmocom-bb/commit/?id=15b8057085a52daddc01b82c244b0…
commit 15b8057085a52daddc01b82c244b051a28309dfd
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Sat Mar 16 16:34:55 2013 +0100
Add RSSI to l1sap
http://cgit.osmocom.org/osmocom-bb/commit/?id=227a9de51e2797757f09bab86ee41…
commit 227a9de51e2797757f09bab86ee418ff039742fb
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Thu Feb 7 12:21:33 2013 +0100
Add MPH and TCH primitives to layer 1 SAP
In order to control layer 1 via primitives, MPH primitives are required.
There is only one (MPH-INFO) primitive defined in TS 04.04 for all control
and measurement functions. A type identifier inside this primitive is used
to differentiate between different functions.
The TCH primitives are used to carry traffic. TCH primitives carry voice
or data traffic, whereas PH-DATA primitives carry FACCH data.
PH_RTS and TCH_RTS (ready-to-send) primitives are used to poll requests
from upper layers.
http://cgit.osmocom.org/osmocom-bb/commit/?id=aa85a2d4b4988f5fe8271a076866c…
commit aa85a2d4b4988f5fe8271a076866c0669bb793f2
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Thu Feb 7 12:18:37 2013 +0100
Remove osmo_phsap_prim from lapdm.h and move to a seperate header file
http://cgit.osmocom.org/osmocom-bb/commit/?id=a3de4dfb5c24007c4b0c462df93e2…
commit a3de4dfb5c24007c4b0c462df93e2015b245a6b7
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Wed Feb 6 14:13:21 2013 +0100
Add LAPDm collision test (contention resolution on network side)
http://cgit.osmocom.org/osmocom-bb/commit/?id=8d50600d7d927a5c9f08c2a9573b6…
commit 8d50600d7d927a5c9f08c2a9573b6a45866dc602
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Jul 4 20:14:10 2013 +0200
get_value_string: Null terminate after the call to snprintf
It is impossible that the snprintf will fill the entire namebuf
but just follow the idiom to make sure it is null terminated.
Related: Coverity CID 1040676
http://cgit.osmocom.org/osmocom-bb/commit/?id=047213b01e786c9765460fccd5f39…
commit 047213b01e786c9765460fccd5f394e93fc777f1
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Jul 3 09:32:37 2013 +0200
vty: Attempt to fix various meam leaks in the VTY lookup code
These routines were not freeing vectors used for the lookup. On
review it is fixing another path not detected by coverity.
The danger is a double free in tab completion now. It is difficult
to test this.
Fixes: Coverity CID 23037, CID 23038
http://cgit.osmocom.org/osmocom-bb/commit/?id=cd252e356556e28cfc72d66f82fa8…
commit cd252e356556e28cfc72d66f82fa87d12f3e5a2a
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Jul 3 09:56:53 2013 +0200
gsm0408: Avoid unaligned memory access in gsm48_generate_mid_from_tmsi
The &buf[3] is unlikely to be aligned properly. Use memcpy instead
of an assignment. Add a small testcase that verifies that I didn't
mess up the conversion.
Alignment trap: osmo-nitb (3293) PC=0x492b7094 Instr=0xe5803003 Address=0xbeb259db FSR 0x801
http://cgit.osmocom.org/osmocom-bb/commit/?id=476cf3337d79e5ed279aab33abb86…
commit 476cf3337d79e5ed279aab33abb866ad48a39664
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Jul 3 09:30:02 2013 +0200
strrb: Remove a tautology from the code
This already came up during review but now that Coverity complains
about it as well, let us just remove it. The variable is unsigned
so it can never be < 0.
Fixes: Coverity CID 1040669.
http://cgit.osmocom.org/osmocom-bb/commit/?id=b3b955bef2b7f95afa033c97e4c3d…
commit b3b955bef2b7f95afa033c97e4c3df4b7e4b5568
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jul 1 09:30:52 2013 +0200
misc: Fix compiler warnings about the static_assert macro with gcc 4.8
The modified macro is still working on a gcc 4.7 and gcc 4.8 after the
removal of the typedef and addition of the unused attribute.
include/osmocom/core/msgb.h: In function ‘msgb_alloc_headroom’:
include/osmocom/core/utils.h:40:51: warning: typedef ‘dummyheadroom_bigger’ locally defined but not used [-Wunused-local-typedefs]
#define osmo_static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1];
^
include/osmocom/core/msgb.h:386:2: note: in expansion of macro ‘osmo_static_assert’
osmo_static_assert(size > headroom, headroom_bigger);
^
http://cgit.osmocom.org/osmocom-bb/commit/?id=d24467579dba8a49dceb82d033316…
commit d24467579dba8a49dceb82d033316b62401ebfbc
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Jun 26 08:03:14 2013 +0200
debian: Prepare the 0.6.2 release with a new changelog
http://cgit.osmocom.org/osmocom-bb/commit/?id=27b2bb7e924161ac087240cfbdf96…
commit 27b2bb7e924161ac087240cfbdf96acf035cba2a
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jun 22 09:44:00 2013 +0200
BSSGP: prevent divide-by-zero in flow control
If the BTS tells us to not send any data at all anymore (bucket leak
rate of 0 bits per second), then we should respect this and not run into
a divide-by-zero. However, as this indicates complete overload, we
print a log message to that regard.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a62fe31d69a5205cea9d7f4c744c5…
commit a62fe31d69a5205cea9d7f4c744c50aa07b0a332
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Jun 19 15:14:37 2013 +0200
introduce gsm0808_create_reset_ack()
http://cgit.osmocom.org/osmocom-bb/commit/?id=14df1c07ec6f1525902fa31037fdf…
commit 14df1c07ec6f1525902fa31037fdfd60c24b3bb9
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Jun 26 07:56:45 2013 +0200
fr: Fix the linking of the test and use $(LIBRARY_DL) for linking
On Ubuntu 13.04 the build was failing on the OBS with:
/usr/bin/ld: fr_test.o: undefined reference to symbol 'dlsym@@GLIBC_2.2.5'
/usr/bin/ld: note: 'dlsym@@GLIBC_2.2.5' is defined in DSO /lib/x86_64-linux-gnu/libdl.so.2 so try adding it to the linker command line
/lib/x86_64-linux-gnu/libdl.so.2: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
http://cgit.osmocom.org/osmocom-bb/commit/?id=3cc268c8dafda560c026c8144ae47…
commit 3cc268c8dafda560c026c8144ae47b36e71fe5b5
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Jun 19 08:30:59 2013 +0200
lapd: Upate the assert to OSMO_ASSERT and describe what we would like to have
Update the OSMO_ASSERT to what it should be like but can't due a
known issue in the LAPDm code.
http://cgit.osmocom.org/osmocom-bb/commit/?id=dd34ed5b904a715a6ed742b635ed4…
commit dd34ed5b904a715a6ed742b635ed44c2b9b0b564
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Jun 19 08:16:56 2013 +0200
lapd: The two known LAPDm issues have been addressed, update the test
The issue about the wrong padding has been found when creating the
testcase in commit 15f740caa3a1ef681b3a5564daf6dfccb7b1e489 but the
patch to fix that was never proposed by inclusion by its author.
The issue about about the establish confirm carrying data with
a wrong size is still present.
http://cgit.osmocom.org/osmocom-bb/commit/?id=087116aca771ae3cd2dcbcbd8cb63…
commit 087116aca771ae3cd2dcbcbd8cb63a91dfc75f20
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Jun 18 21:41:34 2013 +0200
lapd_core: msgb_trim() the L2 padding from ESTABLISH.ind
When a SABM(E) frame arrives, we have to trim the L2 padding (0x2b for
gsm) before handing the data off to L3, just like we do with I frames.
Also, we should use mggb_trim() or even msgb_l3trim() instead of
manually fiddling with msgb->length and ->tail pointers.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1e4400d26a7e3a947a1d6235e7d06…
commit 1e4400d26a7e3a947a1d6235e7d0615506311860
Author: Alexander Huemer <alexander.huemer(a)xx.vu>
Date: Tue Jun 11 14:19:48 2013 +0200
Makefile.am: Use AM_CPPFLAGS
Since automake 1.13 INCLUDES is depricates and causes a warning
http://cgit.osmocom.org/osmocom-bb/commit/?id=9ac453759cb9480244aa00ae4a166…
commit 9ac453759cb9480244aa00ae4a1665c352a547f2
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Tue Jun 11 17:54:56 2013 +0200
misc: Fix the spelling of frame in the RLM cause strings
http://cgit.osmocom.org/osmocom-bb/commit/?id=e6b45d81648feb89bbada6d141400…
commit e6b45d81648feb89bbada6d141400d61037a7e31
Author: Bhaskar <niceguy108(a)gmail.com>
Date: Thu May 16 17:11:51 2013 +0530
gsm_04_08.h: GSM48_MT_RR_VGCS_UPL_GRANT value corrected
http://cgit.osmocom.org/osmocom-bb/commit/?id=31e844bfe2756e36dd50f8bed9fa8…
commit 31e844bfe2756e36dd50f8bed9fa8b087ee6a1d9
Author: Bhaskar <niceguy108(a)gmail.com>
Date: Thu May 16 17:06:35 2013 +0530
gsm_04_08.h: Fix GSM48_CMODE_DATA_3k6 as per 3GPP TS 04.08 / 10.5.2.6.
http://cgit.osmocom.org/osmocom-bb/commit/?id=6b30f925e2d92d4b3cff8595ad7e0…
commit 6b30f925e2d92d4b3cff8595ad7e02e9b5704461
Author: Bhaskar <niceguy108(a)gmail.com>
Date: Thu May 16 17:35:49 2013 +0530
gsm_utils: refer to ETSI TS 05.08 instead of TS 08.05
http://cgit.osmocom.org/osmocom-bb/commit/?id=f5a079f739c57d8be7c59149fd454…
commit f5a079f739c57d8be7c59149fd45475c402a45fc
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed May 8 18:42:39 2013 +0200
lapd: Set the tx_hist to NULL after freeing it
Make detecting use after free of the tx_hist easy and set the
variable to NULL after talloc_free has been freed.
http://cgit.osmocom.org/osmocom-bb/commit/?id=d0ce550251f8d1809f768428c11da…
commit d0ce550251f8d1809f768428c11da0f80f940f10
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Sun Apr 21 21:04:19 2013 +0200
osmo-arfcn: Return something from the method
This is a fatal error when building RPMs for OpenSUSE.
http://cgit.osmocom.org/osmocom-bb/commit/?id=e1f164dd2f1e67f34cf92e43c3e88…
commit e1f164dd2f1e67f34cf92e43c3e8888eb5646016
Merge: b64b2b03 b36ad2de
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Sun Apr 7 20:17:30 2013 +0200
Merge branch 'zecke/jolly-lapdm-fixes'
* Squashed fix and testcase into one.
http://cgit.osmocom.org/osmocom-bb/commit/?id=b36ad2debed2906674b0dc9206243…
commit b36ad2debed2906674b0dc92062437d38994901e
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Tue Feb 5 12:01:32 2013 +0100
Fix of potential memory leaks at lapdm.c
http://cgit.osmocom.org/osmocom-bb/commit/?id=6e182087f4ef6cc73f245e0fbc5db…
commit 6e182087f4ef6cc73f245e0fbc5db11916651ba0
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Wed Feb 6 14:13:21 2013 +0100
Fix: LAPDm contention resoltion must acknowledge subsequent SABM
After reception of SABM, the network responds with UA and enters the
establised multiframe state. If UA is not received by mobile, the SABM
is transmitted again, and the network must respond with UA again, unless
it is from a different mobile.
Add LAPDm collision test (contention resolution on network side).
http://cgit.osmocom.org/osmocom-bb/commit/?id=b64b2b031344b354b7a59f1eb4c1f…
commit b64b2b031344b354b7a59f1eb4c1f97d457613f3
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Mon Mar 25 17:41:15 2013 +0100
debian: Start a new release cycle with libosmocore 0.6.0
http://cgit.osmocom.org/osmocom-bb/commit/?id=2c3393d9e3fc1999641d8dab3b594…
commit 2c3393d9e3fc1999641d8dab3b59418393c4b616
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Mon Mar 25 11:59:58 2013 +0100
gprs_ns: Allow to set the DSCP for the UDP socket.
Allow to tag the NS service with a custom DSCP.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1c83e36cc930f5efc17fd66ccb9a6…
commit 1c83e36cc930f5efc17fd66ccb9a6c541e44c5de
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Tue Mar 12 10:35:26 2013 +0100
tests: Verify that all tests exit with status=0.
http://cgit.osmocom.org/osmocom-bb/commit/?id=55cf02221f0654a3f48888f3b1376…
commit 55cf02221f0654a3f48888f3b13766b671a120f0
Author: Katerina Barone-Adesi <kat.obsc(a)gmail.com>
Date: Tue Mar 12 10:23:52 2013 +0100
utils: Use fprintf to print the assertion and generate a backtrace
This is changing the semantic of the assert. The regression tests
now either need to check the stderr result, the exit status or print
a message when all tests are completed.
This is not that bad as the osmo_generate_backtrace is printing to
the stdout right now.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1a02cfc24d2c812ba13e5aa936588…
commit 1a02cfc24d2c812ba13e5aa936588be447bb24af
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 19 10:37:39 2013 +0100
logging_vty: Fix segfault un unused entries in log_info_cat array of app
http://cgit.osmocom.org/osmocom-bb/commit/?id=54c5ed1518b5856e282fd3f7bba02…
commit 54c5ed1518b5856e282fd3f7bba02c27ea9d879d
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 19 09:55:42 2013 +0100
Revert "Follow up fix for the log level "everything""
This reverts commit a6428d2376034d619f342897d3ce415b3f9a3584.
http://cgit.osmocom.org/osmocom-bb/commit/?id=9b1867093f7ddc4f1bc4cdd56813a…
commit 9b1867093f7ddc4f1bc4cdd56813a8195bd574e4
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 19 09:55:28 2013 +0100
Revert "Fix log level "everything" and make it equal to "debug""
This reverts commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5.
http://cgit.osmocom.org/osmocom-bb/commit/?id=8e878738d16ad4f8776dc0130ebff…
commit 8e878738d16ad4f8776dc0130ebff78dea422ee7
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 18 19:06:13 2013 +0100
application: don't ignore SIGHUP but do config file reopen.
http://cgit.osmocom.org/osmocom-bb/commit/?id=4de854dcf00124b82c12421c3ea1f…
commit 4de854dcf00124b82c12421c3ea1f06a9edeff76
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 18 19:01:40 2013 +0100
logging: add new log_targets_reopen() function
This function will re-open all existing log files in the application,
praticularly useful for SIGHUP handlers in case of logrotate
http://cgit.osmocom.org/osmocom-bb/commit/?id=e128f4663104ed64e33e362cff256…
commit e128f4663104ed64e33e362cff2566f36d65e658
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Mar 7 18:36:32 2013 +0000
add new gsm/meas_rep.h file for shared/common measurement report stuff
http://cgit.osmocom.org/osmocom-bb/commit/?id=533f63f15aa584eec73044802e0a8…
commit 533f63f15aa584eec73044802e0a8bc798a313fe
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Mar 13 15:15:50 2013 +0100
Add smpp34_osmocom.h for Osmocom SMPP vendor additions
http://cgit.osmocom.org/osmocom-bb/commit/?id=ca69388be813c614ff706b6b6d91b…
commit ca69388be813c614ff706b6b6d91b25a14a5a973
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Mar 13 15:10:55 2013 +0100
gsm_septets2octets(): Input parameter should be const
http://cgit.osmocom.org/osmocom-bb/commit/?id=6d2d4d688ef7e32550f4dbe7813c9…
commit 6d2d4d688ef7e32550f4dbe7813c9055c4395aaf
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Mar 10 09:53:24 2013 +0000
logging_vty: Print 'log filter all' info in 'show logging vty'
When we print information about the current logging configuration,
it makes sense to also print information about the log filters.
http://cgit.osmocom.org/osmocom-bb/commit/?id=008e53baaeba1aaf126b11b5c211a…
commit 008e53baaeba1aaf126b11b5c211a1110e9dc087
Author: Katerina Barone-Adesi <kat.obsc(a)gmail.com>
Date: Sun Mar 3 10:36:52 2013 +0000
utils: Introduce OSMO_ASSERT in the utils and use it in the unit tests
The tests should unconditionally assert, regardless of debug settings.
This uses the OSMO_ prefix as it's in the global namespace.
http://cgit.osmocom.org/osmocom-bb/commit/?id=45cdaa095a0e2fe9558de682e1c12…
commit 45cdaa095a0e2fe9558de682e1c12229dfab9adc
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Sun Mar 3 10:07:16 2013 +0100
cygwin: Link many libraries with -no-undefined to create a dll
Only the Gb library relies on having undefined references to a
symbol that needs to be provided by the host application. For
all other libraries we can link with -no-undefined.
http://cgit.osmocom.org/osmocom-bb/commit/?id=ed8170ac676a0a59df39f9c73ec84…
commit ed8170ac676a0a59df39f9c73ec84996fc222145
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Fri Mar 1 16:35:46 2013 +0100
codec: Fix the GSM 06.20 ordering tables
Seems the script I used to parse those had a bug where range of
bits in the 'decreasing' direction ( like 6..0 ) were not processed
properly.
Thanks to Andreas for noticing this !
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=a6428d2376034d619f342897d3ce4…
commit a6428d2376034d619f342897d3ce415b3f9a3584
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Feb 27 15:32:51 2013 +0100
Follow up fix for the log level "everything"
Commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5 made "EVERYTHING"
map to LOGL_DEBUG but when writing out the configuration the following
would be written:
logging level all unknown 0x0
This happend because no string was found for the value 0. Address it
by adding a legacy check for 0 and write out the str from the index
0. Currently this is "EVERYTHING".
http://cgit.osmocom.org/osmocom-bb/commit/?id=3309a43ef56366926589fdb3f7e4e…
commit 3309a43ef56366926589fdb3f7e4ee8af41fe1c5
Author: Katerina Barone-Adesi <kat.obsc(a)gmail.com>
Date: Thu Feb 21 05:16:29 2013 +0000
Added a ring buffer log target to store the last N log messages.
The log target can be used via log alarms and show alarms.
Why? This feature was proposed/requested at
http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget
All messages use the same amount of space, prioritizing simplicity.
http://cgit.osmocom.org/osmocom-bb/commit/?id=efd2bd691fd948df00c1eebcd8599…
commit efd2bd691fd948df00c1eebcd8599b871f5c34f5
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Feb 27 14:51:23 2013 +0100
Revert "Added a ring buffer log target to store the last N log messages."
I noticed some more issues and it is the easiest to revert and include
the fixed version.
This reverts commit 73377229bb33ab79682ce4b126a63602d13304ad.
http://cgit.osmocom.org/osmocom-bb/commit/?id=73377229bb33ab79682ce4b126a63…
commit 73377229bb33ab79682ce4b126a63602d13304ad
Author: Katerina Barone-Adesi <kat.obsc(a)gmail.com>
Date: Thu Feb 21 05:16:29 2013 +0000
Added a ring buffer log target to store the last N log messages.
The log target can be used via log alarms and show alarms.
Why? This feature was proposed/requested at
http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget
All messages use the same amount of space, prioritizing simplicity.
http://cgit.osmocom.org/osmocom-bb/commit/?id=24e5e05b6f5ee841e4533facb4346…
commit 24e5e05b6f5ee841e4533facb434617a33423e22
Author: Tobias Engel <t-openbsc(a)tobias.org>
Date: Wed Feb 20 22:00:06 2013 +0100
Add UMTS RRC message types
http://cgit.osmocom.org/osmocom-bb/commit/?id=cd6ed82d1ff48f47ad9e33e6322df…
commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Feb 19 11:57:14 2013 +0100
Fix log level "everything" and make it equal to "debug"
As Holger points out "logging level XXX everything" wasn't working, as
it sets category->loglevel to 0, which is checked in osmo_vlogp() and
will never get logged.
http://cgit.osmocom.org/osmocom-bb/commit/?id=c28c6a02d224ed74878fe4899870d…
commit c28c6a02d224ed74878fe4899870d693de15f54d
Author: Katerina Barone-Adesi <kat.obsc(a)gmail.com>
Date: Fri Feb 15 13:27:59 2013 +0100
misc: Doxygen tweaks: fixed some typos and minor errors
Doxygen generates quite a lot of warnings on libosmocore. Some of them
are obvious typos - this patch aims to fix such low-hanging fruit.
http://cgit.osmocom.org/osmocom-bb/commit/?id=a5007dbdc59e46c09a2ac6c52fc53…
commit a5007dbdc59e46c09a2ac6c52fc53a7712812cd9
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Feb 13 19:27:42 2013 +0100
debian: Re-enable the debug packages
Remove the .dirs/.install as things will go wrong then. debhelper
will try to install the debug symbols before they were created. Thanks
to Jan for pointing that out.
http://cgit.osmocom.org/osmocom-bb/commit/?id=b3f304bc26b8333adb957d37be4c3…
commit b3f304bc26b8333adb957d37be4c3b3e2998581b
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Feb 13 18:11:43 2013 +0100
debian: Update the change log for a new package
http://cgit.osmocom.org/osmocom-bb/commit/?id=d17aa59c3e7646667f70601eb7fc4…
commit d17aa59c3e7646667f70601eb7fc4ff11ada7604
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Feb 12 11:11:34 2013 +0100
VTY: don't show HIDDEN or DEPRECATED vty commands in ? completion
This hides HIDDEN or DEPRECATED commands from showing up when the
full list of commands is inquired with '?' at any given point in the
command tree. Only if the hidden/deprecated command is already typed
in partially, then it will still tab-complete.
http://cgit.osmocom.org/osmocom-bb/commit/?id=80d30fe8036b4e79e16e766846a17…
commit 80d30fe8036b4e79e16e766846a173e822d95512
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Feb 12 11:08:57 2013 +0100
vty/command.c: Cosmetic cleanup
this is just changing some of the code to reduce the way too high level
of indentation and thus improve readability.
http://cgit.osmocom.org/osmocom-bb/commit/?id=647e39f172b6beaa07e60c2ed6ceb…
commit 647e39f172b6beaa07e60c2ed6ceb49017bf9d18
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Feb 10 17:02:18 2013 +0100
abis_nm: add parenthesis for new abis_nm_debugp_foh() macro
without this, we break e.g. the openbsc build...
http://cgit.osmocom.org/osmocom-bb/commit/?id=868a5c4782eeca54bff38f4c74704…
commit 868a5c4782eeca54bff38f4c74704a12e3a7f8d4
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Feb 10 09:29:27 2013 +0100
turn abis_nm_debugp_foh() into a macro
this will avoid printing 'abis_nm.c' as the filename in the log, which
is pretty useless during debugging. We want to know where
abis_nm_debugp_foh() is being used from, not where it is implemented.
http://cgit.osmocom.org/osmocom-bb/commit/?id=25bcb6cecef0af52599c6d220e226…
commit 25bcb6cecef0af52599c6d220e226f937ab78b12
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Fri Feb 8 13:50:13 2013 +0100
doc: Fix typo in Doxyfile.core.in causing sources to be ignored
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=9adfda2ca30f19858ca272e0ee99b…
commit 9adfda2ca30f19858ca272e0ee99b3ff3ff62a93
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Fri Feb 1 20:37:03 2013 +0100
core/crc: Fix the 64 bits implementation
We used 1ULL at one place and not the other ... at the same time,
we now use (uintXX_t) so that the proper type is used each time.
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=49f4e5be9fba5c27cce228c198e13…
commit 49f4e5be9fba5c27cce228c198e13ab55b740782
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Tue Jan 15 21:18:02 2013 +0100
fr_test: Speculative build fix for FreeBSD
http://cgit.osmocom.org/osmocom-bb/commit/?id=97602d973457a5248ada6ca9e5c29…
commit 97602d973457a5248ada6ca9e5c29c1a5811240d
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Sun Nov 11 14:21:26 2012 +0100
fr: Begin with a GRE/FrameRelay test due the recent regression
The framerelay code is seldomly used and the socket clean ups introduced
a regression. Create a testcase that will work as a user not having the
right capabilities to create raw sockets.
We have to make sure that this test is working even when not ran as root.
The easiest way to do this is to provide our own socket implementation.
This is done with dlopen/dlsym to convert the raw socket request to an UDP
one.
http://cgit.osmocom.org/osmocom-bb/commit/?id=e04a14d9a23ed42178c405cb0c0af…
commit e04a14d9a23ed42178c405cb0c0afb9a2d2b93ab
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Jan 14 00:12:28 2013 +0100
socket: fix osmo_sock_init with SOCK_RAW and IPPROTO_RAW
getaddrinfo returns EAI_SERVICE (-8) if that combination is used.
More information available in here:
http://sourceware.org/bugzilla/show_bug.cgi?id=15015
Reported by Holger Hans Peter Freyther.
While at it, this patch also removes hints.ai_flags = 0 as memset
to zero already happened just a bit before that.
http://cgit.osmocom.org/osmocom-bb/commit/?id=06ddf8bd24ae1104f77498d4cd0c7…
commit 06ddf8bd24ae1104f77498d4cd0c766c164d4525
Author: Evgeny Zverev <evgeny.zverev(a)gmail.com>
Date: Sat Jan 12 00:02:40 2013 +0400
Fix build on Cygwin
http://cgit.osmocom.org/osmocom-bb/commit/?id=de6e4983e7f83794e45af5a70b036…
commit de6e4983e7f83794e45af5a70b036ed9f4437ab5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Dec 6 21:25:27 2012 +0100
add some missing doxygen annotation for libosmocore functions
http://cgit.osmocom.org/osmocom-bb/commit/?id=9043fe57e8852ac4693fe25b88724…
commit 9043fe57e8852ac4693fe25b887246f2c23aa688
Author: Alex Badea <vamposdecampos(a)gmail.com>
Date: Sat Jan 5 20:59:12 2013 +0200
doxyfiles: refer paths to @srcdir@
When building out-of-srcdir, paths such as "src/gsm" will not find any
source files. Since the Doxyfiles are preprocessed, we can prepend
@srcdir@ to fix that.
Signed-off-by: Alex Badea <vamposdecampos(a)gmail.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=695e5fb049822490a1695277d35e3…
commit 695e5fb049822490a1695277d35e3006f6fd3e27
Author: Alex Badea <vamposdecampos(a)gmail.com>
Date: Sat Jan 5 20:59:00 2013 +0200
tests/timer: tweak path to config.h
When building out-of-srcdir, "../../config.h" fails to reach config.h
because the compiler is invoked in $builddir/tests/, not
$builddir/tests/timer/. Use "../config.h" instead; this also works
for in-srcdir builds.
Signed-off-by: Alex Badea <vamposdecampos(a)gmail.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=854debc32cb858ca8f29274181e3a…
commit 854debc32cb858ca8f29274181e3aa837c401a01
Author: Christian Vogel <vogelchr(a)vogel.cx>
Date: Sat Jan 5 20:30:41 2013 +0100
Replace obsolete automake AM_CONFIG_HEADER.
This fixes the following complaint by autoconf 2.69-1, automake 1.13.1-1.
: configure.ac:80: error: 'AM_CONFIG_HEADER': this macro is obsolete.
: You should use the 'AC_CONFIG_HEADERS' macro instead.
: /usr/share/aclocal-1.13/obsolete-err.m4:12: AM_CONFIG_HEADER is expan
: configure.ac:80: the top level
Automake 1:1.11.3-1ubuntu2, autoconf 2.68-1ubuntu2 don't even emit a warning
without, and work just fine with this patch.
Signed-off-by: Christian Vogel <vogelchr(a)vogel.cx>
http://cgit.osmocom.org/osmocom-bb/commit/?id=b73d191c0b625552b2792e26c72a6…
commit b73d191c0b625552b2792e26c72a6e83d8595167
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Fri Jan 4 09:55:29 2013 +0100
debian: Bump the changelog and package osmo-arfcn
http://cgit.osmocom.org/osmocom-bb/commit/?id=4d8eea48f2357fb4de5795824165d…
commit 4d8eea48f2357fb4de5795824165d32d1de3ae64
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Fri Dec 28 11:58:23 2012 +0100
vty: Do better filtering of arguments, optional args particularly
This is essentially http://patchwork.diac24.net/patch/271/ forward
ported to libosmovty
Original-by: Paul Jakma <paul(a)quagga.net>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=01e06046379350aa9090ef785a9b0…
commit 01e06046379350aa9090ef785a9b0fe2ca03ce23
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Thu Jan 3 09:36:16 2013 +0100
core/bits: Prevent osmo_revbytebits_buf stack trashing
The second loop in osmo_revbytebits_buf() in src/bits.c grabs
4 bytes each iteration, which can easily go past the supplied
input in some cases.
Compiled with -fstack-protector , I get a "stack smashing detected"
in the bits test.
From: Nils O. Selåsdal <noselasd(a)fiane.dyndns.org>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=13bb169d71a7eff694b8a2ba24497…
commit 13bb169d71a7eff694b8a2ba24497ee08c73a090
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Wed Dec 26 00:12:21 2012 +0100
tests: Don't delete atconfig in clean
This file is created in ./configure so we shouldn't remove it with make.
Otherwise ./configure && make clean && make check fails with:
make[3]: *** No rule to make target `atconfig', needed by `check-local'.
Stop.
http://cgit.osmocom.org/osmocom-bb/commit/?id=af723a4ed4c0232047590896935fb…
commit af723a4ed4c0232047590896935fb0b8da7c78a8
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Dec 26 10:51:00 2012 +0100
lapd: Fix compiler warnings in the lapd code
lapd_test.c: In function ‘ms_to_bts_l1_cb’:
lapd_test.c:192:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
lapd_test.c:199:1: warning: no return statement in function returning non-void [-Wreturn-type]
lapd_test.c: In function ‘main’:
lapd_test.c:355:2: warning: implicit declaration of function ‘osmo_init_logging’ [-Wimplicit-function-declaration]
http://cgit.osmocom.org/osmocom-bb/commit/?id=e523392c2c091f53c18edf2086d69…
commit e523392c2c091f53c18edf2086d6966eec38561f
Author: Daniel Willmann <daniel(a)totalueberwachung.de>
Date: Tue Dec 25 23:15:50 2012 +0100
lapd: Check in rslms_rx_rll() if lapdm context was initialized earlier
This was found while implementing handover on a sysmobts. When we
receive a channel release request for a channel that was never really
activated (set_lapdm_context() was not called) we segfault in
lapd_recv_dlsap().
We now return early with -EINVAL in rslms_rx_rll() if we receive a
message that assumes set_lapdm_context() was already called.
These are:
* RSL_MT_UNIT_DATA_REQ
* RSL_MT_DATA_REQ
* RSL_MT_SUSP_REQ
* RSL_MT_REL_REQ
A test case was added to trigger the issue.
http://cgit.osmocom.org/osmocom-bb/commit/?id=0167596c2bf19102eac8a69f5066e…
commit 0167596c2bf19102eac8a69f5066eedbae72a167
Author: Andreas Eversberg <jolly(a)eversberg.eu>
Date: Tue Nov 6 12:02:59 2012 +0100
Add tlvp_val16_unal() / tlvp_val32_unal() to align 16 and 32 bit values
This is required for CPUs < armv6, to access 16 and 32 values at right
memory locations.
http://cgit.osmocom.org/osmocom-bb/commit/?id=31659f72cba5f354b79448991bb7d…
commit 31659f72cba5f354b79448991bb7d4ca1d608f83
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Wed Dec 12 00:00:43 2012 +0100
core: Fix missing include in msgfile.c for getline
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=5689a3b7449bde69ce6276b3b348f…
commit 5689a3b7449bde69ce6276b3b348f98d07c856cf
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Tue Dec 11 23:59:31 2012 +0100
build: Don't use the deprecated INCLUDES in the various Makefile.am
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=c44310e351bd7740b377dda83cae1…
commit c44310e351bd7740b377dda83cae1d29a3dc8b76
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Tue Dec 11 23:45:03 2012 +0100
utils/osmo-arfcn: Implement option to get ARFCN from frequency
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=5572031749ffa4cdfa15e9c73b889…
commit 5572031749ffa4cdfa15e9c73b8897e39c3ddb0b
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Tue Dec 11 23:44:41 2012 +0100
gsm: Add method to find ARFCN based on frequency
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=6e264ae3cdd5962182b66a07151d4…
commit 6e264ae3cdd5962182b66a07151d4bcf2f104e40
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Nov 24 13:14:09 2012 +0100
osmo-arfcn: add support for PCS band
http://cgit.osmocom.org/osmocom-bb/commit/?id=0357e9b37528911397ba019319065…
commit 0357e9b37528911397ba019319065d206f067af0
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Thu Dec 6 11:57:31 2012 +0100
rsl: Add the 9.3.20 release mode enum to be used in OpenBSC
http://cgit.osmocom.org/osmocom-bb/commit/?id=68f9447744609177669444aae40ea…
commit 68f9447744609177669444aae40eafc613fd18e1
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Sat Dec 1 12:51:34 2012 +0100
sms: Print 'network' or 'mobile' when creating the SMC/SMR
http://cgit.osmocom.org/osmocom-bb/commit/?id=c1e9be95c20fb0517efcd5746e38f…
commit c1e9be95c20fb0517efcd5746e38fc95b4d9da14
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Thu Dec 6 08:23:02 2012 +0100
gsm/a5: Return -ENOTSUP if the selected cipher is not supported
Extracted from a patch by Max Suraev Max.Suraev(a)fairwaves.ru>
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
http://cgit.osmocom.org/osmocom-bb/commit/?id=8c01231681fca386b3e7b71eeba99…
commit 8c01231681fca386b3e7b71eeba999d545edbbdf
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Mon Nov 26 16:52:23 2012 +0100
lapd: Use LOGL_ERROR for messgaes that are wrong in the given context
Log message that are either too big or have the C/R bit set as error.
http://cgit.osmocom.org/osmocom-bb/commit/?id=579fb09eacf0412b9980af381c558…
commit 579fb09eacf0412b9980af381c558eafb220f0d5
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Thu Nov 22 10:54:23 2012 +0100
misc: Use static const struct for LAPD and Abis
http://cgit.osmocom.org/osmocom-bb/commit/?id=9473c5d75d54129135472ce93b1cf…
commit 9473c5d75d54129135472ce93b1cff78d246a9c9
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Thu Nov 22 10:50:52 2012 +0100
sms: Mark the state dispatch table as static const
GCC 4.7.2 was already smart enough to see that the table is const
so there is no change in the generated assembly code. For some reason
the dispatch is still going through one relocation.
http://cgit.osmocom.org/osmocom-bb/commit/?id=1c4c373b9f38227470b1e9b3e36a6…
commit 1c4c373b9f38227470b1e9b3e36a6696a0fa9716
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Thu Nov 22 00:33:52 2012 +0100
sms: Fix typos in the comments and log messages.
http://cgit.osmocom.org/osmocom-bb/commit/?id=bcf125c524482a442fd27938036a1…
commit bcf125c524482a442fd27938036a18f9bcc6e265
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Nov 14 06:07:47 2012 +0100
smr: Introduce an id and prefix all log messages with SMR(ID)
When OpenBSC is handling more than one message at a time it is difficult
to see which log message belongs to which SMR instance. Introduce a
uint64_t id that can be set to the row_id/message_id and prefix all
log messages with SMR(ID).
This change is ABI and API incompatible with previous versions of
libosmogsm.
http://cgit.osmocom.org/osmocom-bb/commit/?id=33e8a87cd7306fa365d6de0549ed2…
commit 33e8a87cd7306fa365d6de0549ed2397edbf4df9
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Nov 14 06:07:47 2012 +0100
smc: Introduce an id and prefix all log messages with SMC(ID)
When OpenBSC is handling more than one message at a time it is difficult
to see which log message belongs to which SMC. Introduce a uint64_t id
that can be set to the row_id/message_id and prefix all log messages
with SMC(ID).
This change is ABI and API incompatible with previous versions of
libosmogsm.
Example:
SMC(100) instance created
SMC(100) message MNSMS-EST-REQ received in state IDLE
http://cgit.osmocom.org/osmocom-bb/commit/?id=6643386f3fadea66a3a92207d1af0…
commit 6643386f3fadea66a3a92207d1af07113269710a
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Nov 15 12:41:15 2012 +0100
actually install osmo-arfcn and osmo-auc-gen as part of 'make install'
-----------------------------------------------------------------------
hooks/post-receive
--
The Open Source GSM Base Band stack
1
0
osmo-gsm-manuals.git branch master updated. 56f77a3b6436eab71c42fd0ad3233a15148eafed
by gitosis＠osmocom.org 07 Sep '17
by gitosis＠osmocom.org 07 Sep '17
07 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Manuals for Osmocom GSM components".
The branch, master has been updated
via 56f77a3b6436eab71c42fd0ad3233a15148eafed (commit)
from 6fc8db48eb88855c5432f60cd79c529de09312cc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=56f77a3b6436eab71c42fd0…
commit 56f77a3b6436eab71c42fd0ad3233a15148eafed
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Sep 7 01:02:04 2017 +0200
OsmoGGSN: Add VTY reference manual
Change-Id: Iddf6fe26689172d7db001198943c816eaaed7931
-----------------------------------------------------------------------
Summary of changes:
OsmoGGSN/Makefile | 28 +-
.../osmoggsn-vty-reference.xml | 8 +-
OsmoGGSN/vty/ggsn_vty_additions.xml | 30 +
.../vty/ggsn_vty_reference.xml | 847 +++++++++++----------
4 files changed, 526 insertions(+), 387 deletions(-)
copy OsmoBTS/osmobts-vty-reference.xml => OsmoGGSN/osmoggsn-vty-reference.xml (81%)
create mode 100644 OsmoGGSN/vty/ggsn_vty_additions.xml
copy OsmoMGCP/vty/mgcp_vty_reference.xml => OsmoGGSN/vty/ggsn_vty_reference.xml (61%)
hooks/post-receive
--
Manuals for Osmocom GSM components
1
0
osmocom-bb.git branch master updated. osmocon_v0.0.0-1840-g281d9ac3
by gitosis＠osmocom.org 07 Sep '17
by gitosis＠osmocom.org 07 Sep '17
07 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Open Source GSM Base Band stack".
The branch, master has been updated
via 281d9ac3818401ec0abe5268528e01c0a6e1a9d8 (commit)
from b2c19fc5d35f25a63b2ee523761c3d9714b146e9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmocom-bb/commit/?id=281d9ac3818401ec0abe5268528e0…
commit 281d9ac3818401ec0abe5268528e01c0a6e1a9d8
Author: Max <msuraev(a)sysmocom.de>
Date: Thu Sep 7 12:20:59 2017 +0200
Add 'git review' config file
Change-Id: Ibc891a88811817a4f5a56fe22b1967a464e6d242
-----------------------------------------------------------------------
Summary of changes:
.gitreview | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 .gitreview
hooks/post-receive
--
The Open Source GSM Base Band stack
1
0
op25.git branch max updated. a3f4963deac56125953a4efbc4b26e510f4e0520
by gitosis＠osmocom.org 06 Sep '17
by gitosis＠osmocom.org 06 Sep '17
06 Sep '17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Software-defined analyzer for APCO P25".
The branch, max has been updated
via a3f4963deac56125953a4efbc4b26e510f4e0520 (commit)
from 04b16056dffbe2871e4d0b870d118029acb757da (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/op25/commit/?id=a3f4963deac56125953a4efbc4b26e510f4…
commit a3f4963deac56125953a4efbc4b26e510f4e0520
Author: Max <ikj1234i(a)yahoo.com>
Date: Wed Sep 6 08:20:15 2017 -0400
forgot to add this
-----------------------------------------------------------------------
Summary of changes:
op25/gr-op25_repeater/apps/sockaudio.py | 309 ++++++++++++++++++++++++++++++++
1 file changed, 309 insertions(+)
create mode 100755 op25/gr-op25_repeater/apps/sockaudio.py
hooks/post-receive
--
Software-defined analyzer for APCO P25
1
0
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenGGSN project".
The branch, master has been updated
via 98146776dddb986fda78b5f028e79f041460ee4c (commit)
from b5b02c2a513b46143179494d2ba156f27c7adcd1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-ggsn/commit/?id=98146776dddb986fda78b5f028e79f…
commit 98146776dddb986fda78b5f028e79f041460ee4c
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Sep 5 17:41:20 2017 +0200
ggsn: Add ability to specify local IP addresses for GTP-C and GTP-U
In case the GGSN is behind some kind of DNAT, the public GTP-C and
GTP-U IP addresses as exposed inside the GTP payload information
elements are different from the (internal, behind-nat) IP address
to which it listens/binds.
Change-Id: I548c9011c9abd66d46f963b1def61575f3dabb89
-----------------------------------------------------------------------
Summary of changes:
ggsn/ggsn.c | 8 ++++++++
ggsn/ggsn.h | 4 ++++
ggsn/ggsn_vty.c | 42 ++++++++++++++++++++++++++++++++++++++----
3 files changed, 50 insertions(+), 4 deletions(-)
hooks/post-receive
--
The OpenGGSN project
1
0