This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, master has been updated
via 8f0ccf618d553b2731caa24a2575a48065917959 (commit)
from 06676ead634d85d2acdd84dfdd79d55dd618187b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-trx/commit/?id=8f0ccf618d553b2731caa24a2575a48…
commit 8f0ccf618d553b2731caa24a2575a48065917959
Author: Tom Tsou <tom.tsou(a)ettus.com>
Date: Wed Jul 20 16:35:03 2016 -0700
uhd: Update USRP2/N200/N210 for 4 SPS Rx
Requires changing the radioInterface API to pass in Rx side SPS
value. Update the (deprecated) diversity configuration to match
as well.
Signed-off-by: Tom Tsou <tom.tsou(a)ettus.com>
-----------------------------------------------------------------------
Summary of changes:
Transceiver52M/UHDDevice.cpp | 4 +--
Transceiver52M/osmo-trx.cpp | 58 ++++++++++++++++++------------
Transceiver52M/radioInterface.h | 8 ++---
Transceiver52M/radioInterfaceDiversity.cpp | 4 +--
Transceiver52M/radioInterfaceResamp.cpp | 21 +++--------
5 files changed, 47 insertions(+), 48 deletions(-)
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, dexter/draft has been updated
via 6e047ba35f0dbd0f311ed4916e14077d4cf37522 (commit)
from 7ae75f4bceae4310a12d5ef1afb2560793ff132e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=6e047ba35f0dbd0f311ed4916e14077d…
commit 6e047ba35f0dbd0f311ed4916e14077d4cf37522
Author: Philipp <pmaier(a)sysmocom.de>
Date: Wed Jul 20 18:16:11 2016 +0200
Fixed wongly packed TLV structure
Change-Id: Ifc47c63dfaab9ca8ef8bd5fdb05eeb541bb8ca57
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gprs_sndcp_xid.c | 61 +++++++++++++++++++++++++++++++++++++++
1 file changed, 61 insertions(+)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, dexter/draft has been updated
via 7ae75f4bceae4310a12d5ef1afb2560793ff132e (commit)
from 24b1a5e530f7b807301c8d58ae262297162481b4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=7ae75f4bceae4310a12d5ef1afb25607…
commit 7ae75f4bceae4310a12d5ef1afb2560793ff132e
Author: Philipp <pmaier(a)sysmocom.de>
Date: Wed Jul 20 17:40:28 2016 +0200
Improvements to XID and SNDCP-XID, now rejects compression
Change-Id: I8fc12ee7351ed2a69eb45b30966c5d67f61e729d
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_llc.h | 3 +-
openbsc/include/openbsc/gprs_sndcp_xid.h | 2 +-
openbsc/src/gprs/gprs_llc.c | 81 +++++++++++++++++---------------
openbsc/src/gprs/gprs_sndcp.c | 58 ++++++++++++++++-------
openbsc/src/gprs/gprs_sndcp_xid.c | 35 ++++++--------
5 files changed, 100 insertions(+), 79 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, dexter/draft has been updated
via 24b1a5e530f7b807301c8d58ae262297162481b4 (commit)
from c29b0748cfc95b52d9e2da90cd7621c82ba1dce0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=24b1a5e530f7b807301c8d58ae262297…
commit 24b1a5e530f7b807301c8d58ae262297162481b4
Author: Philipp <pmaier(a)sysmocom.de>
Date: Wed Jul 20 13:23:42 2016 +0200
Looks like compression turned on the first time - I better push this
Change-Id: Ic7639b637dd9bb6e1c87347b78eb783c23440d58
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gprs_llc.c | 25 +++++++++++++++++++----
openbsc/src/gprs/gprs_llc_xid.c | 10 ++++++++-
openbsc/src/gprs/gprs_sndcp.c | 45 +++++++++++++++++++++++++++++++++++++++++
openbsc/src/gprs/sgsn_libgtp.c | 8 ++++----
4 files changed, 79 insertions(+), 9 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, master has been updated
via 06676ead634d85d2acdd84dfdd79d55dd618187b (commit)
from 4609f3285ca047c9cf0a44f93a8653ad730b9d0e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-trx/commit/?id=06676ead634d85d2acdd84dfdd79d55…
commit 06676ead634d85d2acdd84dfdd79d55dd618187b
Author: Tom Tsou <tom.tsou(a)ettus.com>
Date: Tue Jul 19 12:50:21 2016 -0700
sigproc: Fix missing 8-PSK tail symbols
Agilent E4406A measurement of TSC synchronized RF envelope measurement.
showed failing power levels at the tail end of EDGE bursts. Regression
traced back to following commit.
Commit d2b070369dd5341ac42ec091370d8bcd5a8ac5ee
"uhd: Correct timing alignment in 8-PSK and GMSK downlink bursts"
In the patch, the EDGE burst was delayed one symbol, but erroneously
truncated at the tail end causing the failing RF envelope measurement.
The missing tail symbol did not appear to affect end-to-end EGPRS tests.
This patch corrects the truncation.
Signed-off-by: Tom Tsou <tom.tsou(a)ettus.com>
-----------------------------------------------------------------------
Summary of changes:
Transceiver52M/sigProcLib.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, master has been updated
via 4609f3285ca047c9cf0a44f93a8653ad730b9d0e (commit)
via 7c741ec6a67d6008698d0a3efb770fb1533106e8 (commit)
from 2f3e60bc1f7da051183fe00f961d14da6d2c5981 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-trx/commit/?id=4609f3285ca047c9cf0a44f93a8653a…
commit 4609f3285ca047c9cf0a44f93a8653ad730b9d0e
Author: Tom Tsou <tom.tsou(a)ettus.com>
Date: Tue Jul 19 11:28:51 2016 -0700
transceiver: Fix 4 SPS receive TOA value
The time-of-arrival (TOA) value out of sigProc is specified
in symbols or, equivalently, 1 sample per symbol and does
not need to be normalized.
Signed-off-by: Tom Tsou <tom.tsou(a)ettus.com>
http://cgit.osmocom.org/osmo-trx/commit/?id=7c741ec6a67d6008698d0a3efb770fb…
commit 7c741ec6a67d6008698d0a3efb770fb1533106e8
Author: Tom Tsou <tom.tsou(a)ettus.com>
Date: Tue Jul 19 11:20:59 2016 -0700
transceiver: Fix mixed GSMK / 8-PSK transmission
Input burst construction was declared static causing the first
downlink burst from upstream to determine subsequent burst size
and modulation. Consequently, fixed sequence EGPRS tests would
pass, however, switching between 8-PSK and GMSK bursts would
fail with only one modulation type being transmitted.
Internally generated test sequences '-r' option were not affected
because the bursts are not received through the socket interface.
Signed-off-by: Tom Tsou <tom.tsou(a)ettus.com>
-----------------------------------------------------------------------
Summary of changes:
Transceiver52M/Transceiver.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, dexter/draft has been updated
via c29b0748cfc95b52d9e2da90cd7621c82ba1dce0 (commit)
from 4e2ed48cca7870bd3ea5bdbe9763782edea64062 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=c29b0748cfc95b52d9e2da90cd7621c8…
commit c29b0748cfc95b52d9e2da90cd7621c82ba1dce0
Author: Philipp <pmaier(a)sysmocom.de>
Date: Tue Jul 19 18:53:18 2016 +0200
SNDCP-XID decoder
Change-Id: I26409a586d5264b65f568a4b43c85a18e1e4b3a2
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_llc_xid.h | 5 +
openbsc/include/openbsc/gprs_sndcp_xid.h | 46 ++-
openbsc/src/gprs/gprs_llc.c | 60 +++-
openbsc/src/gprs/gprs_llc_xid.c | 40 ++-
openbsc/src/gprs/gprs_sndcp.c | 32 +-
openbsc/src/gprs/gprs_sndcp_xid.c | 572 ++++++++++++++++++++++++++++++-
6 files changed, 706 insertions(+), 49 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/dyn_ts has been updated
discards d871e27423ecb6d4186d29fb2fc2edda7412535f (commit)
via 4e029e237b3121b0249e347e0d50273b3ccf0afd (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (d871e27423ecb6d4186d29fb2fc2edda7412535f)
\
N -- N -- N (4e029e237b3121b0249e347e0d50273b3ccf0afd)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=4e029e237b3121b0249e347e0d50273…
commit 4e029e237b3121b0249e347e0d50273b3ccf0afd
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 15 01:07:30 2016 +0200
dyn ts wip
Change-Id: I53ad8b2a4be9051f53ff719d1927830eb7ea6621
-----------------------------------------------------------------------
Summary of changes:
src/common/l1sap.c | 4 ++--
src/common/rsl.c | 22 ++++++++++++++++------
src/osmo-bts-sysmo/l1_if.c | 13 +++++++++----
3 files changed, 27 insertions(+), 12 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/dyn_ts has been updated
discards 0e55abe6f1af0b5fb5af23f5ed02d7bab65760b0 (commit)
discards 73f6936947296d6ce6a149b63b31539ccf3f8a83 (commit)
discards 391c413ce42291cfc440c76b06e5b6832626c0ce (commit)
discards e29014116a820b56500f8dc9cce01223cb9d1d25 (commit)
discards abf6781026d8ce9090719ce79181292c438d556a (commit)
discards a3a99b509573822be5eca856e269abace360a889 (commit)
via b5ad4405b4005947332cc9e4ecf5938fb27e764f (commit)
via 03d01d18bc744ba89b5acc1db891005b3a4a4733 (commit)
via 1efa67a6afd1f19a4f62e9e42db8700521d48ec2 (commit)
via a6c8ab27246cc2b7cdf7104b321727bff2b6e3a9 (commit)
via ee4f05c056ab67c963cc02d7c4be2de8f14d3683 (commit)
via 721205f0707759299b841608e356ee9249254c39 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (0e55abe6f1af0b5fb5af23f5ed02d7bab65760b0)
\
N -- N -- N (b5ad4405b4005947332cc9e4ecf5938fb27e764f)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=b5ad4405b4005947332cc9e4ecf5938f…
commit b5ad4405b4005947332cc9e4ecf5938fb27e764f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Jun 14 01:32:46 2016 +0200
debug log: log all lchan_alloc steps
Change-Id: Ib2d11744d92dc06205fb1573815e11efd84842b0
http://cgit.osmocom.org/openbsc/commit/?id=03d01d18bc744ba89b5acc1db891005b…
commit 03d01d18bc744ba89b5acc1db891005b3a4a4733
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 15 01:18:57 2016 +0200
dyn TS: switchover wip
Change-Id: Iea4dfa6166520f9036a5d6bbb7962580746f4c5b
http://cgit.osmocom.org/openbsc/commit/?id=1efa67a6afd1f19a4f62e9e42db87005…
commit 1efa67a6afd1f19a4f62e9e42db8700521d48ec2
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Thu Jul 14 03:10:40 2016 +0200
dyn TS: Abis RSL: on chan rel, switch dyn TS back to PDCH
Add function ts_subslots(), for the check whether all TCH/H are released in
abis_rsl.c; subslots_per_pchan[] is static in chan_alloc.c, and the function
adds some dyn TS logic.
Change-Id: I3974f5cc3ac8a3e2ad53db11b9e4180aa4c16c0a
http://cgit.osmocom.org/openbsc/commit/?id=a6c8ab27246cc2b7cdf7104b321727bf…
commit a6c8ab27246cc2b7cdf7104b321727bff2b6e3a9
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Thu Jul 14 03:09:56 2016 +0200
dyn TS: verify_chan_comb(): handle new dyn TS NM_CHANC_*
Change-Id: I7ce754a48c7f492e921a4450745383bb8dd7225c
http://cgit.osmocom.org/openbsc/commit/?id=ee4f05c056ab67c963cc02d7c4be2de8…
commit ee4f05c056ab67c963cc02d7c4be2de8f14d3683
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Sat Jul 16 23:59:32 2016 +0200
common: add gsm_ts_and_pchan_name() for dyn ts logging convenience
Change-Id: I9b6be77c9e5fb9dffa2021a2da72293af15a03a0
http://cgit.osmocom.org/openbsc/commit/?id=721205f0707759299b841608e356ee92…
commit 721205f0707759299b841608e356ee9249254c39
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Jul 18 23:43:44 2016 +0200
gsm_data_shared.h/c: decouple gsm_lchan2chan_nr() from ts->pchan
For dynamic TS, the pchan to RSL De-/Activate with is not trivial. So in
order to pass the desired pchan, introduce gsm_lchan_as_pchan2chan_nr().
To avoid code dup, this requires decoupling the gsm_ts2chan_nr() pchan from the
actual ts struct, so also refactor gsm_ts2chan_nr() to gsm_pchan2chan_nr() with
explicit pchan, ts_nr and lchan_nr arguments.
Change-Id: I1a40e8452fe8120d350a27973e56be0b8c8c517f
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libbsc/abis_rsl.c | 23 +++++++++++++++--------
openbsc/src/libcommon/gsm_data_shared.c | 6 ++++++
2 files changed, 21 insertions(+), 8 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/dyn_pdch_trx has been updated
discards 980fd1f8cdec5a3c6dee28a51fdd53165d30c080 (commit)
discards af7b7feb11fc13e0e81cf7619d8d2c061c9b63b8 (commit)
discards 1eda517edd81cd464d0b658a7f8b2ae9dd6e8fff (commit)
discards 4b0355256bdacb0cfb2a57d89595d3887aee7b42 (commit)
discards eeab9e75a69378ab936a8cc1dbac583f9eb51367 (commit)
discards cb854fd531b09f25f94a9bf987dfd777164d7352 (commit)
via 28d5e939e9412ede73e3c4a758ff84c020e504c3 (commit)
via 72a93b21ab2984937fd9353cdcd4965b67e041f7 (commit)
via 9577b2e1db9476f6e30a6cfe51ca3e7b8f934fda (commit)
via 0739406e5dadfd0c58d968284e2df83231f16689 (commit)
via 8501d8f7f788db97aebd7500f59efc6c913f965d (commit)
via 939dce4ce4bfb975c053a8de04d418afa0ac3d14 (commit)
via c890c8abe7b93693ac6d20cc0c1076b4549ae3ba (commit)
via cff0d44e53bce69a9c8831925d1489c4024ccb1c (commit)
via b8f5f4e176c5402ec529225864313f0787502049 (commit)
via b151301c6c91f8ecc02aa18ee746b02cf61f6fee (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (980fd1f8cdec5a3c6dee28a51fdd53165d30c080)
\
N -- N -- N (28d5e939e9412ede73e3c4a758ff84c020e504c3)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=28d5e939e9412ede73e3c4a758ff84c…
commit 28d5e939e9412ede73e3c4a758ff84c020e504c3
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Jul 19 11:32:26 2016 +0200
wip
Change-Id: I3724b5fc2e1d9ae06444873dc6b05d61104e4025
http://cgit.osmocom.org/osmo-bts/commit/?id=72a93b21ab2984937fd9353cdcd4965…
commit 72a93b21ab2984937fd9353cdcd4965b67e041f7
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 8 03:06:20 2016 +0200
cosmetic: osmo-bts-trx: remove obsolete commented code
Change-Id: I1a5b6a9d9592952877c6640e5117dc269d67925a
http://cgit.osmocom.org/osmo-bts/commit/?id=9577b2e1db9476f6e30a6cfe51ca3e7…
commit 9577b2e1db9476f6e30a6cfe51ca3e7b8f934fda
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 8 03:05:46 2016 +0200
osmo-bts-trx: clear TS flags on CHANNEL OPSTART
Change-Id: Ia6de5960f910a9db32c55dc1d38527e871c76e99
http://cgit.osmocom.org/osmo-bts/commit/?id=0739406e5dadfd0c58d968284e2df83…
commit 0739406e5dadfd0c58d968284e2df83231f16689
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 8 03:04:37 2016 +0200
fix debug log: pick proper l1ts
Change-Id: Ic3d1c1c61c2ca1adc043ec02d7249e2b0798ae12
http://cgit.osmocom.org/osmo-bts/commit/?id=8501d8f7f788db97aebd7500f59efc6…
commit 8501d8f7f788db97aebd7500f59efc6c913f965d
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 8 03:03:30 2016 +0200
scores of temporary debug logs
Change-Id: I4cf69f301295a70a10b920039c8b874db18de672
http://cgit.osmocom.org/osmo-bts/commit/?id=939dce4ce4bfb975c053a8de04d418a…
commit 939dce4ce4bfb975c053a8de04d418afa0ac3d14
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Jul 5 15:32:30 2016 +0200
WIP
Change-Id: Ib2a9c7e126fe4a5c91a0ef6c3973071970292d65
http://cgit.osmocom.org/osmo-bts/commit/?id=c890c8abe7b93693ac6d20cc0c1076b…
commit c890c8abe7b93693ac6d20cc0c1076b4549ae3ba
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 8 02:21:54 2016 +0200
osmo-bts-trx: init OML only once by sending AVSTATE_OK with OPSTATE_ENABLED
When receiving an OPSTART for the BTS object, also set the availability state
to OK.
Before, the availability would remain at NM_AVSTATE_DEPENDENCY, which caused an
unfortunate chain reaction resulting in osmo-bts-trx going through the
initialization sequence twice:
BTS BSC
|<-----| SITE_MANAGER OPSTART
n |----->| BTS state change: OPSTATE_DISABLED, AVSTATE_DEPENDENCY
o | | This signals to nm_statechg_event() in bts_ipaccess_nanobts.c
r | | to (a) Set BTS Attributes and (b) send BTS OPSTART
m |<-----| Set BTS Attributes (a)
a | | When osmo-bts-trx receives a Set BTS Attributes, it sends
l |----->| CHANNEL state change: OPSTATE_DISABLED x8
| | This signals the BSC to Set CHANNEL Attributes and OPSTART
i |<-----| Set CHANNEL Attributes x8
n |<-----| CHANNEL OPSTART x8
i |----->| CHANNEL state change: OPSTATE_ENABLED, AVSTATE_OK x8
t | |
|<-----| BTS OPSTART (b)
| | osmo-bts-trx immediately replies with:
|----->| BTS state change: OPSTATE_ENABLED, AVSTATE_DEPENDENCY
| | Unfortunately, availability is left at DEPENDENCY,
| | and the NM_OC_BTS case in nm_statechg_event() only
| | checks for availability, not for the opstate.
| | Hence nm_statechg_event() again feels inclined to
| | to (a) Set BTS Attributes and (b) send BTS OPSTART,
| |
--+------+----- This is where the second round starts
| |
s |<-----| Set BTS Attributes (a)
e | | When osmo-bts-trx receives a Set BTS Attributes, it sends
c |----->| CHANNEL state change: OPSTATE_DISABLED x8
o | | All channels are disabled again, and then re-launched:
n |<-----| Set CHANNEL Attributes x8
d |<-----| CHANNEL OPSTART x8
|----->| CHANNEL state change: OPSTATE_ENABLED, AVSTATE_OK x8
| |
i |<-----| BTS OPSTART (b)
n | | osmo-bts-trx again sets the OPSTATE_ENABLED, but since
i | | this time it was already enabled, no further state change
t | | is sent back to the BSC.
This nightmare pivots on two hinges:
1. osmo-bts-trx fails to set BTS availability to AVSTATE_OK.
2. nm_statechg_event() fails to heed the OPSTATE_ENABLED of the BTS state
change.
Note, the configured channels from the first round were not actually taken
down, only the OML OPSTATE_DISABLED were sent.
In this commit, fix the osmo-bts-trx side: send AVSTATE_OK for the BTS object
upon sending OPSTATE_ENABLED, so that only the part marked "normal init" above
is run.
This change applies the same fix to other OML objects, which should make sense
in the same manner, within the current hackish OML implementation:
* NM_OC_BTS
* NM_OC_SITE_MANAGER
* NM_OC_BASEB_TRANSC
* NM_OC_GPRS_NSE
* NM_OC_GPRS_CELL
* NM_OC_GPRS_NSVC
See OS#1770 for BTS and NITB logs.
Fixes: OS#1770
Change-Id: I08aa861f6100568c79750f4fbc9a32e1557b9304
-----------------------------------------------------------------------
Summary of changes:
include/osmo-bts/scheduler.h | 4 ++--
src/common/oml.c | 3 +++
src/osmo-bts-trx/l1_if.c | 7 ++++---
src/osmo-bts-trx/scheduler_trx.c | 8 ++++----
4 files changed, 13 insertions(+), 9 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)