April 2016 - osmocom-commitlog

osmo-trx.git branch master updated. 5efe05021a97606ee5f98235424eddb85628e25a
by gitosis＠osmocom.org 26 Apr '16

26 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, master has been updated via 5efe05021a97606ee5f98235424eddb85628e25a (commit) via 78d1fc9a13f84b273facb2f22a291c3d2e6ebd33 (commit) via a8cf2086165480597251c2af240e0f44c47097f8 (commit) via f84232d30a247584366b87c91baf9a9f70a5cc49 (commit) from 9bd649ec7316457cffe93b9c02d1de1ce2294a21 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-trx/commit/?id=5efe05021a97606ee5f98235424eddb… commit 5efe05021a97606ee5f98235424eddb85628e25a Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> Date: Wed Mar 23 17:06:32 2016 +0300 transceiver: Add an option to generate random Access Bursts. http://cgit.osmocom.org/osmo-trx/commit/?id=78d1fc9a13f84b273facb2f22a291c3… commit 78d1fc9a13f84b273facb2f22a291c3d2e6ebd33 Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> Date: Sat Mar 19 21:16:22 2016 +0300 transceiver: Properly handle MAXDLY. Previously MAXDLY value was applied to Normal Bursts, which was nice when working with sloppy test equipment like CMD57, but useless for real world usage. At the same time documentation and de facto usage of MAXDLY in OsmoBTS and OpenBTS assumed that it actually applies to Access Bursts (RACH). So this patch changes osmo-rx behavior to apply MAXDLY to RACH bursts and introduces a new command MAXDLYNB for the old behavior. http://cgit.osmocom.org/osmo-trx/commit/?id=a8cf2086165480597251c2af240e0f4… commit a8cf2086165480597251c2af240e0f44c47097f8 Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> Date: Thu Jul 30 20:04:18 2015 -0400 Common: Make sure gLogEarly() log to the same facilities as the normal log. http://cgit.osmocom.org/osmo-trx/commit/?id=f84232d30a247584366b87c91baf9a9… commit f84232d30a247584366b87c91baf9a9f70a5cc49 Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> Date: Thu Jul 30 19:59:56 2015 -0400 Common: Get rid of a compilation warning. debugLogEarly was replaced to an empty space and arguments of the function became operators, grouped together by (): Configuration.cpp: In member function 'bool ConfigurationTable::defines(const string&)': Configuration.cpp:272:28: warning: left operand of comma operator has no effect [-Wunused-value] debugLogEarly(LOG_ALERT, "configuration parameter %s not found", key.c_str()); ^ This fix removes debugLogEarly together with its arguments. ----------------------------------------------------------------------- Summary of changes: CommonLibs/Configuration.cpp | 2 +- CommonLibs/Logger.cpp | 39 +++++++++++++++++++++++++++++++++------ GSM/GSMCommon.cpp | 3 +++ GSM/GSMCommon.h | 2 ++ Transceiver52M/Transceiver.cpp | 22 +++++++++++++++++----- Transceiver52M/Transceiver.h | 4 +++- Transceiver52M/osmo-trx.cpp | 9 ++++++++- Transceiver52M/sigProcLib.cpp | 42 ++++++++++++++++++++++++++++++++++++++---- Transceiver52M/sigProcLib.h | 7 ++++++- 9 files changed, 111 insertions(+), 19 deletions(-) hooks/post-receive -- OpenBTS' transceiver retro-fit

1 0

libosmo-abis.git branch max/ortp updated. 0.3.2-9-gd7063c9
by gitosis＠osmocom.org 26 Apr '16

26 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, max/ortp has been updated discards 0968b4f8c4449c92c7b768f2c19622e4b466fd1d (commit) discards 5b200ca9ab5145d0ef796ec810e0934784e195bb (commit) discards 76d128f171830c186e077e3c199cae94e9354574 (commit) via d7063c98853e4a412d0a8fd44dc2c4dc7a22ad25 (commit) via 4e3d451c4a301a7fc8c84813dd8c238f4728998b (commit) via 86c9e4597c1c4a9be160bd44b8a8dc7d13c0b59c (commit) via f75ec350bd3358e13cb56fd4e9cac22f9075465b (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (0968b4f8c4449c92c7b768f2c19622e4b466fd1d) \ N -- N -- N (d7063c98853e4a412d0a8fd44dc2c4dc7a22ad25) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=d7063c98853e4a412d0a8fd44dc… commit d7063c98853e4a412d0a8fd44dc2c4dc7a22ad25 Author: Max <msuraev(a)sysmocom.de> Date: Tue Apr 26 17:22:22 2016 +0200 Set non-blocking mode explicitly ortp: do not rely on library default - set non-blocking mode explicitly. http://cgit.osmocom.org/libosmo-abis/commit/?id=4e3d451c4a301a7fc8c84813dd8… commit 4e3d451c4a301a7fc8c84813dd8c238f4728998b Author: Max <msuraev(a)sysmocom.de> Date: Tue Apr 26 15:25:21 2016 +0200 simplify frame send routine ortp: use higher-level function for sending RTP frames. http://cgit.osmocom.org/libosmo-abis/commit/?id=86c9e4597c1c4a9be160bd44b8a… commit 86c9e4597c1c4a9be160bd44b8a8dc7d13c0b59c Author: Max <msuraev(a)sysmocom.de> Date: Tue Apr 26 14:26:59 2016 +0200 Remove use of private oRTP function ortp: the rtp_session_rtcp_recv() function is not part of public oRTP API so we shouldn't use it. Besides it is called internally by oRTP in rtp_session_recvm_with_ts() which we call anyway. http://cgit.osmocom.org/libosmo-abis/commit/?id=f75ec350bd3358e13cb56fd4e9c… commit f75ec350bd3358e13cb56fd4e9cac22f9075465b Author: Max <msuraev(a)sysmocom.de> Date: Tue Apr 26 14:04:04 2016 +0200 Support newer oRTP API ortp: rtp_session_signal_connect() API has changed in 0.24 - add version check and change code accordingly. See http://upstream.rosalinux.ru/diffs/ortp/0.23.0_to_0.24.0/diff.html for details. ----------------------------------------------------------------------- Summary of changes: src/trau/osmo_ortp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom A-bis protcol interface library

1 0

libosmo-abis.git branch max/ortp created. 0.3.2-8-g0968b4f
by gitosis＠osmocom.org 26 Apr '16

26 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, max/ortp has been created at 0968b4f8c4449c92c7b768f2c19622e4b466fd1d (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=0968b4f8c4449c92c7b768f2c19… commit 0968b4f8c4449c92c7b768f2c19622e4b466fd1d Author: Max <msuraev(a)sysmocom.de> Date: Tue Apr 26 15:25:21 2016 +0200 simplify frame send routine ortp: use higher-level function for sending RTP frames. http://cgit.osmocom.org/libosmo-abis/commit/?id=5b200ca9ab5145d0ef796ec810e… commit 5b200ca9ab5145d0ef796ec810e0934784e195bb Author: Max <msuraev(a)sysmocom.de> Date: Tue Apr 26 14:26:59 2016 +0200 Remove use of private oRTP function ortp: the rtp_session_rtcp_recv() function is not part of public oRTP API so we shouldn't use it. Besides it is called internally by oRTP in rtp_session_recvm_with_ts() which we call anyway. http://cgit.osmocom.org/libosmo-abis/commit/?id=76d128f171830c186e077e3c199… commit 76d128f171830c186e077e3c199cae94e9354574 Author: Max <msuraev(a)sysmocom.de> Date: Tue Apr 26 14:04:04 2016 +0200 Support newer oRTP API ortp: rtp_session_signal_connect() API has changed in 0.24 - add version check and adopt code accordingly. See http://upstream.rosalinux.ru/diffs/ortp/0.23.0_to_0.24.0/diff.html for details. http://cgit.osmocom.org/libosmo-abis/commit/?id=7ee0704261778a0d7cd711c5d88… commit 7ee0704261778a0d7cd711c5d885c4fdae5ceea7 Author: Max <msuraev(a)sysmocom.de> Date: Mon Apr 25 16:54:16 2016 +0200 Fix RTCP port allocation Force use of random RTCP port if random RTP port is used. Before port 0 could be selected for RTCP. ----------------------------------------------------------------------- hooks/post-receive -- Osmocom A-bis protcol interface library

1 0

openbsc.git branch neels/wip_20160426_1526 created. 0.15.0-411-g3acbcaf
by gitosis＠osmocom.org 26 Apr '16

26 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/wip_20160426_1526 has been created at 3acbcaf18b31e7ead2c3e67d9a5861f05d57678c (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3acbcaf18b31e7ead2c3e67d9a5861f0… commit 3acbcaf18b31e7ead2c3e67d9a5861f05d57678c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Apr 26 15:26:48 2016 +0200 wip ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

osmo-iuh.git branch sysmocom/ipa_nano3G updated. 30188bb5a81e2ba5e02e9c0a522d5848d2212550
by gitosis＠osmocom.org 26 Apr '16

26 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, sysmocom/ipa_nano3G has been updated discards ee62f4ee8595382b7db8dcecafdf8b6d353d7e3c (commit) discards 3e648c14fef4e50840ccfc8e238ffeb87d782772 (commit) discards 0c35d83fbd19f841d84c3218635c5ac9fdbf54d1 (commit) discards 2860445326f4a23e382cb349d4e7b52f44d8a7a1 (commit) discards 3b8e4d9675c9e36c19e64256da3658ed4347287f (commit) discards 819fbb5213c98a98bc82ae89e033f6eef333746d (commit) discards adbda2688e83043b72bd8f1e03b220c242fbec14 (commit) via 30188bb5a81e2ba5e02e9c0a522d5848d2212550 (commit) via 6bdba59239e4353da96bcae05ce2f8f9a6a3b680 (commit) via dd072a90d77eafd2252d31834ad1cc18afed031d (commit) via fd7ce5f9b48839013617aef8c7f410ced2672754 (commit) via cbb8db325c2bdfbd5495d4b8d0edbbbfb360d3d1 (commit) via 5b6fb9c301f4906f2fceac33bb74485d298711e3 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (ee62f4ee8595382b7db8dcecafdf8b6d353d7e3c) \ N -- N -- N (30188bb5a81e2ba5e02e9c0a522d5848d2212550) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=30188bb5a81e2ba5e02e9c0a522d584… commit 30188bb5a81e2ba5e02e9c0a522d5848d2212550 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Apr 23 13:53:28 2016 +0200 hnbgw: dumb fix of context map hnb_list double delete http://cgit.osmocom.org/osmo-iuh/commit/?id=6bdba59239e4353da96bcae05ce2f8f… commit 6bdba59239e4353da96bcae05ce2f8f9a6a3b680 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Apr 25 15:05:32 2016 +0200 hack: simply accept UE Register Requests with TMSI HNBGW would usually keep track of UEs that have registered, with their IMSI. When a UE registers with only a TMSI, we obviously can't store an IMSI. However, since we're so far never *using* the list of UEs in osmo-hnbgw, we might as well just accept the TMSI registration and carry on as usual. This is particularly helpful with an ip.access nano3G femto cell, as it tends to send UE registrations with a TMSI+LAI identification instead of an IMSI when the subscriber is known. This causes timeouts of several minutes until a UE registration switches back to IMSI. When simply accepting the TMSI in osmo-hngw, no problems are apparent in our current code state. We could use the subscriber list during paging, but on the other hand, it doesn't hurt to anyway always page to all HNBs connected to osmo-hnbgw. The paging procedure does include a page-to-all-HNBs in case the first HNB paging fails. However, since we're now failing to record UEs that register by TMSI, we must be aware that trying to page such UE on only its last seen HNB will fail; it is plainly missing in the list. http://cgit.osmocom.org/osmo-iuh/commit/?id=dd072a90d77eafd2252d31834ad1cc1… commit dd072a90d77eafd2252d31834ad1cc18afed031d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Apr 25 14:55:35 2016 +0200 UE Register with TMSI: reply with a Register Reject When receiving a UE Register Request with TMSI and no IMSI, compose a Register Reject with the same UE Identity and send. The accepting function expects a ue_context argument and composes the message from the IMSI found there. This new rejection message cannot rely on a ue_context struct and hence uses the asn1 uE_Identity directly. http://cgit.osmocom.org/osmo-iuh/commit/?id=fd7ce5f9b48839013617aef8c7f410c… commit fd7ce5f9b48839013617aef8c7f410ced2672754 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Apr 25 15:21:09 2016 +0200 RAB parameters: add Extended Max Bitrate This IE is seen in a "real life" pcap of hNodeB operation. We did not need it so far, but add it to test the ip.access nano3G. Comment from the future: the ip.access nano3G rebooted upon RAB Assignment Request, and after adding/tweaking some IEs it stopped rebooting. This is one of the changes that fixed the reboot issue. The changes have been tested incrementally until reboots vanished, but it's not clear/hasn't been tested whether omitting this change alone will cause reboots to re-appear. http://cgit.osmocom.org/osmo-iuh/commit/?id=cbb8db325c2bdfbd5495d4b8d0edbbb… commit cbb8db325c2bdfbd5495d4b8d0edbbbfb360d3d1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Apr 25 15:17:25 2016 +0200 RAB parameters: tweak the Allocation Or Retention Priority These values are seen in a "real life" pcap from hNodeB operation. Comment from the future: the ip.access nano3G rebooted upon RAB Assignment Request, and after adding/tweaking some IEs it stopped rebooting. This is one of the changes that fixed the reboot issue. The changes have been tested incrementally until reboots vanished, but it's not clear/hasn't been tested whether omitting this change alone will cause reboots to re-appear. http://cgit.osmocom.org/osmo-iuh/commit/?id=5b6fb9c301f4906f2fceac33bb74485… commit 5b6fb9c301f4906f2fceac33bb74485d298711e3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Apr 25 15:14:08 2016 +0200 RAB parameters: add Traffic Handling Priority Add this 'missing' IE from the RAB Assignment Request (while hacking on the ip.access nano3G). Comment from the future: the ip.access nano3G rebooted upon RAB Assignment Request, and after adding/tweaking some IEs it stopped rebooting. This is one of the changes that fixed the reboot issue. The changes have been tested incrementally until reboots vanished, but it's not clear/hasn't been tested whether omitting this change alone will cause reboots to re-appear. ----------------------------------------------------------------------- Summary of changes: src/ranap_msg_factory.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface

1 0

osmo-bts.git branch fairwaves/jitter-stats-print created. 98dab07feb92cd4f6585b28fec358f75d7feb77e
by gitosis＠osmocom.org 25 Apr '16

25 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, fairwaves/jitter-stats-print has been created at 98dab07feb92cd4f6585b28fec358f75d7feb77e (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=98dab07feb92cd4f6585b28fec358f7… commit 98dab07feb92cd4f6585b28fec358f75d7feb77e Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> Date: Mon Apr 25 20:11:53 2016 +0200 ortp: Print jitter stats along with sent/received RTP stats. Jitter statistics is important for debugging voice quality issues. A number of dropped packets is sometimes not enough to really understand what's going on and jitter buffer statistics offer a deper view into the network quality. http://cgit.osmocom.org/osmo-bts/commit/?id=d8026ec1b7be7922fd1c3122d2407a7… commit d8026ec1b7be7922fd1c3122d2407a783cdab163 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sun Apr 24 10:32:37 2016 +0200 distcheck: Include the .version file in the package Fixes on Ubuntu make[1]: Entering directory '/home/builder/jenkins/workspace/libosmo-abis/label/linux_amd64_ubuntu_1504/libosmo-abis-0.3.2.5-7c93/_build/sub' echo 0.3.2.5-7c93 > ../../.version-t && mv ../../.version-t ../../.version /bin/bash: ../../.version-t: Permission denied Makefile:891: recipe for target '../../.version' failed make[1]: *** [../../.version] Error 1 http://cgit.osmocom.org/osmo-bts/commit/?id=7c9337b7755bfa51bdcba5cc7668221… commit 7c9337b7755bfa51bdcba5cc76682217202fd635 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Wed Apr 13 18:52:43 2016 -0400 jenkins: Add the build script from jenkins here This can be used to replicate a build issue more easily. http://cgit.osmocom.org/osmo-bts/commit/?id=0db1d43c0d6bdf4c2e67a07ebf77923… commit 0db1d43c0d6bdf4c2e67a07ebf77923e9e191aff Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Feb 22 13:29:09 2016 +0100 ipa driver: make bind address vty configurable Add VTY function to set the ipa bind address: e1_input ipa bind A.B.C.D Add a priv pointer to struct e1inp_driver in order to communicate the bind address parameter to ipaccess_line_update(). Add two "internal.h" functions to get/set it in the ipa driver struct. Add static ip_bind_addr() to use the IP address set from the VTY or, if NULL, use "0.0.0.0". Apply in ipaccess_line_update(). http://cgit.osmocom.org/osmo-bts/commit/?id=86fc3c8787a9c29f566a44969d528a6… commit 86fc3c8787a9c29f566a44969d528a604ee7e11f Author: Alexander Huemer <alexander.huemer(a)xx.vu> Date: Fri Nov 6 20:56:29 2015 +0100 export lapd_tei_alloc(), used in libosmo-netif http://cgit.osmocom.org/osmo-bts/commit/?id=3cef39b03cb46de4a7aba65137d724a… commit 3cef39b03cb46de4a7aba65137d724a000b184cb Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Nov 3 09:40:00 2015 +0100 debian: Bump so version to link against new libosmovty2 Debian doesn't have reverse dependencies so we need to bump the SO version to have libosmoabis and libosmotrau link against our new version. http://cgit.osmocom.org/osmo-bts/commit/?id=71bc9e2ac815aa07480110361651fdb… commit 71bc9e2ac815aa07480110361651fdb5dbaf9003 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Sep 21 12:18:37 2015 +0200 ortp: Guard the jitter stats with a version check ortp 0.18 has introduced the jitter_stats but we only check for 0.21 an later. It is okay that at some point the jitter stats will be reported. For previous versions it is 0. http://cgit.osmocom.org/osmo-bts/commit/?id=fe01908428d9745e7d111a0902d3d09… commit fe01908428d9745e7d111a0902d3d090d0090f91 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Sep 21 10:52:52 2015 +0200 ortp: Export statistics for the bts or similar We might want to know how many things arrived at the BTS and ortp is already counting for us. We don't intend to use RTCP so I am not sure what the last "sender report" is and how accurate the jitter is. http://cgit.osmocom.org/osmo-bts/commit/?id=b37c5d48f0e5ceed98da7523ddab787… commit b37c5d48f0e5ceed98da7523ddab7878ab1b1cd9 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Aug 15 10:50:53 2015 +0200 configure.ac: Add subdir-objects http://cgit.osmocom.org/osmo-bts/commit/?id=3a580f263a24e0ce7d3ed544af0373c… commit 3a580f263a24e0ce7d3ed544af0373c22ae9eeac Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sun Mar 22 09:25:19 2015 +0100 subchan: Remove unused const variable nullbytes has never been used, I assume the code ended up using memset instead of copying from nullbytes. Fixes: subchan_demux.c:47:22: warning: unused variable 'nullbytes' [-Wunused-const-variable] static const uint8_t nullbytes[SYNC_HDR_BITS]; http://cgit.osmocom.org/osmo-bts/commit/?id=050d60a9a1210d456e5db247cef0e86… commit 050d60a9a1210d456e5db247cef0e860ed38ebbb Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Mar 14 20:01:48 2015 +0100 debian: Switch to multi-arch support http://cgit.osmocom.org/osmo-bts/commit/?id=2f0dd0c01930fbc0dbf0c86946dd0a4… commit 2f0dd0c01930fbc0dbf0c86946dd0a429f3cd6e2 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sun Jan 18 19:27:07 2015 +0100 New upstream release http://cgit.osmocom.org/osmo-bts/commit/?id=90878590575cdcedbaf7b8f431e0fa1… commit 90878590575cdcedbaf7b8f431e0fa102d0d2e50 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sun Jan 18 17:50:05 2015 +0100 ipa: Add API to clear the tx queue Jacob noticed that after a re-connect old messages would be sent. This can be the wanted behavior but add a method that allows a caller to clear the tx queue. The implementation has not been verified and there is no existing unit test where I could easily add this code to. http://cgit.osmocom.org/osmo-bts/commit/?id=adfa01f041e3b9a515b65a732c92eab… commit adfa01f041e3b9a515b65a732c92eabf74e2ba08 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Dec 26 18:13:55 2014 +0100 misdn: Close the file descriptor if the ioctl is failing Fixes: Coverity CID#1040691 http://cgit.osmocom.org/osmo-bts/commit/?id=1acf4cbd75e1d50d2605c75759235e7… commit 1acf4cbd75e1d50d2605c75759235e7cdea5fbdc Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 22 11:14:34 2014 +0100 ipa: Declare all structs used A few declarations are missing. This patch adds forward declarations for struct used for pointers only and an include directive (osmocom/core/select.h) to get a full definition of struct osmo_fd. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-bts/commit/?id=687046ba2f0527456ae47365a9709fc… commit 687046ba2f0527456ae47365a9709fc939fdaf48 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Dec 12 17:39:58 2014 +0100 ipa: Set the BSC_FD_WRITE in ipa_client_conn_open When the link is being created BSC_FD_WRITE and BSC_FD_READ are being ored into the flag. When the socket connects the first time the ipa_client_fd_cb function is called and the link->state is moved from connecting to connect. In case the connection drops and ipa_client_conn_open is called again the BSC_FD_WRITE flag might not be set. This means that after the socket is connected, ipa_client_fd_cb will not be called. This means that the updown_cb will not be called until after the first write or read on the socket. It might even lead to missing some data. When re-connecting set the write flag again. http://cgit.osmocom.org/osmo-bts/commit/?id=37fcd93a508b52f6f33bf47191bba41… commit 37fcd93a508b52f6f33bf47191bba41cb7367b0d Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sun Oct 26 08:13:52 2014 +0100 ipa: Partially revert the e1inp_ipa_bts_rsl_connect_n commit The check was always hit by osmo-bts master leading to the RSL connection never being made. This is because the type of the line will be set _after_ the RSL connection has been made. E.g. inside osmo-bts/src/common/abis.c: static struct e1inp_sign_link *sign_link_up(void *unit, struct e1inp_line *line, enum e1inp_sign_type type) { struct e1inp_sign_link *sign_link = NULL; switch (type) { ... case E1INP_SIGN_RSL: LOGP(DABIS, LOGL_INFO, "RSL Signalling link up\n"); e1inp_ts_config_sign(&line->ts[E1INP_SIGN_RSL-1], line); ... Only the call to e1inp_ts_config_sign will set the type to be E1INP_TS_TYPE_SIGN. Before the call the type is still _NONE and the connect was rejected. http://cgit.osmocom.org/osmo-bts/commit/?id=d9d1b5c19f40515cb7c660acda7265b… commit d9d1b5c19f40515cb7c660acda7265bbddbb73d6 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Sep 25 18:47:12 2014 +0200 misc: Work with src != builddir libosmo-abis/0.3.0+gitrAUTOINC+b6d2834eef-r2.14.0/git/src/input/dahdi.c:25:26: fatal error: ../../config.h: No such file or directory #include "../../config.h" http://cgit.osmocom.org/osmo-bts/commit/?id=b6d2834eefc79ee2536796768716ebd… commit b6d2834eefc79ee2536796768716ebdb0073678e Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Sep 8 07:29:50 2014 +0200 Prepare a new release of libosmo-abis http://cgit.osmocom.org/osmo-bts/commit/?id=e6ad794cadd6210315bdce4a6e5c50e… commit e6ad794cadd6210315bdce4a6e5c50e56511932a Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Aug 29 09:07:05 2014 +0200 test: Fix the compilation of the test This test didn't compile as it called the wrong method. It is a manual test anyway and tend to bitrot. I didn't execute the resulting test binary. Hmm, now I did and it segfaults on something that appears to have been introduced a long time ago. Manual tests are as good as no tests (besides they take more time than writing no test). ;) http://cgit.osmocom.org/osmo-bts/commit/?id=c97b9e64e355545aae5e418047f5d0d… commit c97b9e64e355545aae5e418047f5d0d643abb74a Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Aug 29 09:05:48 2014 +0200 Add missing TODO-RELEASE entry to remind us of the ABI bump on release http://cgit.osmocom.org/osmo-bts/commit/?id=f422a753a7c2b6a81a370240470f48c… commit f422a753a7c2b6a81a370240470f48ca09819cc6 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Tue Jan 21 14:54:41 2014 +0100 Support for multiple RSL connections with ABIS/ipaccess (BTS side) In order to support multiple TRX, multiple RSL connections can be establised. e1inp_ipa_bts_rsl_connect() requires an additional parameter to set the TRX number. The ts[] array (member of struct e1inp_line) refers to OML and RSL. ts[0] refers to OML link, ts[1] to RSL link of first TRX, ts[2] to RSL link of second TRX (if exists) and so on. The code was successfully tested with osmobts-trx and UmTRX with two transceivers. The user of e1inp_ipa_bts_rsl_connect() (which is osmo-bts) can use the new function like this (backwards compatibility function provided): src/common/oml.c - rc = e1inp_ipa_bts_rsl_connect(oml_link->ts->line, inet_ntoa(in), port); + rc = e1inp_ipa_bts_rsl_connect_n(oml_link->ts->line, inet_ntoa(in), port, + trx->nr); http://cgit.osmocom.org/osmo-bts/commit/?id=c9295ea2dd1f52931f8670e706a7b0d… commit c9295ea2dd1f52931f8670e706a7b0d4b3ac536b Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Aug 21 02:41:41 2014 +0200 fix compiler warning in write_pcap_packet() if we don't evaluate the result of write(), there's no point in storing the result in a variable. http://cgit.osmocom.org/osmo-bts/commit/?id=b65f58f6f9e504a017e83634e1cceeb… commit b65f58f6f9e504a017e83634e1cceebdd7525fdb Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Aug 20 22:04:11 2014 +0200 move various generic IPA related functions to libosmocore libosmo-abis is about forming A-bis interfaces/lines by means of E1 or the IPA multiplex (or possibly other link layers). The IPA multiplex is used in other contexts, such as the Control interface, or the A interface. In that context, it makes sense to have generic IPA related functions in libosmocore. http://cgit.osmocom.org/osmo-bts/commit/?id=46fc7e2df78d489bfd9de2fa4084ea8… commit 46fc7e2df78d489bfd9de2fa4084ea8d369f1401 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Aug 18 19:04:26 2014 +0200 ipa: Add E1INP_SIGN_OSMO to use IPAC_PROTO_OSMO via e1_input In order to make use of the IPAC_PROTO_OSMO stream_id of the IPA multiplex via the e1_input abstraction layer, we need to define E1INP_SIGN_OSMO and treat it like other signalling (OML/RSL). This is required for the upcoming code that uses IPAC_PROTO_OSMO to remotely insert routing table entries into the OML router (e.g. from osmo-bts). http://cgit.osmocom.org/osmo-bts/commit/?id=f5efba40e7068595db788463e8b94ba… commit f5efba40e7068595db788463e8b94ba56642218a Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Aug 18 17:30:36 2014 +0200 ipa: add ipaccess_tlv_to_unitdata() this function takes the parsed TLVs of an IPA ID RESP message and fills a 'struct ipaccess_unit'. http://cgit.osmocom.org/osmo-bts/commit/?id=c1edf604aed9bafb2ca5b188f9c6d0d… commit c1edf604aed9bafb2ca5b188f9c6d0d5d2973808 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Aug 18 17:28:54 2014 +0200 ipa: declare more already public functions ipaccess_idtag_parse(), int ipaccess_send_id_req() and paccess_parse_unitid(). In the mid to long term, the entire IPA/CCM handling should be moved out of the processes and into a proper state machine inside libosmocore or libosmoabis. http://cgit.osmocom.org/osmo-bts/commit/?id=783715b204922cae70b6915f5962685… commit 783715b204922cae70b6915f596268538c1c67e2 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 17 18:24:51 2014 +0200 Split generic CCM handling out of ipaccess_bts_read_cb() The generic functionality of responding to IPA CCM messages doesn't need to be intertwined with our e1input abstraction. We split this out as new exported function ipaccess_bts_handle_ccm() and modify ipaccess_bts_read_cb() to make use of that function. http://cgit.osmocom.org/osmo-bts/commit/?id=46c40b8e584d98b621aa3195e3fc841… commit 46c40b8e584d98b621aa3195e3fc841f23b7140d Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Aug 18 20:25:07 2014 +0200 ipa: Move the second null check into the first one Move the second null check before we actually dereference the msg. Fixes: Coverity CID 1231854 http://cgit.osmocom.org/osmo-bts/commit/?id=3091e17571d839579ebb8dd83fd245e… commit 3091e17571d839579ebb8dd83fd245ef878f2504 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Aug 18 14:53:05 2014 +0200 declare ipa_msg_push_header() as public function http://cgit.osmocom.org/osmo-bts/commit/?id=e7e1b7556492b0c33ea68bdb73ee20b… commit e7e1b7556492b0c33ea68bdb73ee20b94d2405f8 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 17 21:41:34 2014 +0200 ipa: ensure updown_cb() gets called on reconnect If the ipa_client_conn is lost and ther user issues a new ipa_client_conn_open(), then we need to re-set our internal state to IPA_CLIENT_LINK_STATE_CONNECTING, as otherwise we wouldn't call the updown_cb() once the link is up again. http://cgit.osmocom.org/osmo-bts/commit/?id=f0d4a2213a27c049df0c579aff0f699… commit f0d4a2213a27c049df0c579aff0f699273fc7686 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 17 18:42:13 2014 +0200 ipa: Set msgb->l1h to the beginning of the IPA header l2h points to the OML/RSL header, so it is only logical that l1h points to the IPA header. Also, this is what osmo-bts/msg_utils.c expects. http://cgit.osmocom.org/osmo-bts/commit/?id=205e90314d28120ec6da4d82fc9e893… commit 205e90314d28120ec6da4d82fc9e893130006d3f Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 17 11:48:44 2014 +0200 ipa.h: Wrap function declarations to make them more readable purely cosmetic change. http://cgit.osmocom.org/osmo-bts/commit/?id=fb6e1e993e66899839bc86cfe0bf754… commit fb6e1e993e66899839bc86cfe0bf7542239c8851 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jun 24 11:02:01 2014 +0200 rtp: Randomize the initial timestamp for RFC compliance Pick a random timestamp when creating the session. RFC 3550: The initial value of the timestamp SHOULD be random, as for the sequence number. Fixes: SYS#403 http://cgit.osmocom.org/osmo-bts/commit/?id=bf6f1f4a37c254f5046de555092b8c0… commit bf6f1f4a37c254f5046de555092b8c0b8c0940a6 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jun 24 10:57:35 2014 +0200 rtp: Randomize the initial sequence number for RFC compliance The usage of random() is not that unpredictable but the closest we can get right now. RFC 3550: The initial value of the sequence number SHOULD be random (unpredictable) to make known-plaintext attacks on encryption more difficult, even if the source itself does not encrypt according to the method in Section 9.1, because the packets may flow through a translator that does. Techniques for choosing unpredictable numbers are discussed in [17]. Fixes: SYS#403 http://cgit.osmocom.org/osmo-bts/commit/?id=d67f3f04ab59e766521b234bff6b40b… commit d67f3f04ab59e766521b234bff6b40be21f279ff Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue May 6 06:59:52 2014 +0200 ipa: Add function declaration for IPA header creation These functions are called from OpenBSC and are supposed to be public API of libosmo-abis. http://cgit.osmocom.org/osmo-bts/commit/?id=754d5d4b6c96629c6cf6eb84614212c… commit 754d5d4b6c96629c6cf6eb84614212c2eb53bab1 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Apr 26 12:44:18 2014 +0200 ipa_proxy: make sure ipa instance name is nul-terminated Reported by coverity. CID 1206565. http://cgit.osmocom.org/osmo-bts/commit/?id=ecd0a36ce8d468985ec296214e3ecce… commit ecd0a36ce8d468985ec296214e3ecced8da487cc Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Mar 31 15:49:13 2014 +0200 release: Prepare the 0.2.0 release of libosmo-abis http://cgit.osmocom.org/osmo-bts/commit/?id=98af3c3a6df8fc6e8ef765b30aff2a0… commit 98af3c3a6df8fc6e8ef765b30aff2a013b9904fa Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Mar 31 10:53:32 2014 +0200 ipa: Change ipa_msg_recv() to support partial receive Currently ipa_msg_recv() fails, when messages are received partially. This patch provides a new function ipa_msg_recv_buffered() that uses an additional ** to a message buffer to store partial data. When this happens, -EAGAIN is returned. If NULL is used, the function behaves similar to ipa_msg_recv() and fails on partial read. In addition in case of errors the return value is now always -EXXX and the contents of errno is undefined. Note that this feature needs support by the calling code insofar that *tmp_msg must be set to NULL initially and it must be freed and set to NULL manually when the socket is closed. Note also that ipa_msg_recv() is then a wrapper around ipa_msg_recv_buffered() which mimics the old error behaviour by setting errno explicitely to -rc and returning -1 when an error has happened. Ticket: OW#728 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-bts/commit/?id=36106ae24475f5742dd3335c1bbe4d5… commit 36106ae24475f5742dd3335c1bbe4d5e5321912e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Mar 20 19:14:33 2014 +0100 ipa/test: Add test program for IPA message reception This patch adds tests for ipa_msg_recv(), where messages are sent either complete or partitioned. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-bts/commit/?id=f465a4c16f131c235cb3014035e5f9b… commit f465a4c16f131c235cb3014035e5f9bc149b83e0 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Feb 3 09:34:02 2014 +0100 ipaccess: Move the #endif before the curly brace Fix the compilation on FreeBSD that does not use these names but they are prefixed with TCPTV_KEEP... instead. http://cgit.osmocom.org/osmo-bts/commit/?id=f6415ea5a6bfd796c854dc0bace326d… commit f6415ea5a6bfd796c854dc0bace326de26bf26f1 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Jan 20 10:33:52 2014 +0100 debian: Build the new upstream release http://cgit.osmocom.org/osmo-bts/commit/?id=ba9aa8941bd3d67f8b8280fceb5763c… commit ba9aa8941bd3d67f8b8280fceb5763cb4c24973f Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Jan 20 10:22:45 2014 +0100 Prepare the v0.1.6 release of libosmo-abis http://cgit.osmocom.org/osmo-bts/commit/?id=901ef1cbbb49ccb959065307ddc18b6… commit 901ef1cbbb49ccb959065307ddc18b63e3d53108 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Jan 16 15:35:53 2014 +0100 ipaccess: Change the visibility of the ipa messages http://cgit.osmocom.org/osmo-bts/commit/?id=8fe1571ea9bbd52140304206e340f30… commit 8fe1571ea9bbd52140304206e340f30ead66d6ab Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 9 14:30:58 2014 +0100 ipaccess: Make TCP keep-alive configurable This patch changes the implementation to use the keep-alive configuration fields instead of constants. Ticket: OW#1060 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-bts/commit/?id=86dae84bed909ce075a70bfdba7000a… commit 86dae84bed909ce075a70bfdba7000a1bf9b9bac Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 16 18:10:37 2014 +0100 input: Make keep alive configurable (generic) This patch adds a generic keep alive configuration layer that mainly consists of additional fields in e1_input structs and VTY commands and extensions. Ticket: OW#1060 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-bts/commit/?id=a4ec51e108998e5152eeefb454451d5… commit a4ec51e108998e5152eeefb454451d5e7c2a4592 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 9 14:30:56 2014 +0100 ipaccess: Use keep alive for all connections Keep alive has only been used for OML so far. This patch refactors the socket configuration into an own function and uses it for RSL, too. Ticket: OW#1060 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-bts/commit/?id=859807261e021eafe07792af901e548… commit 859807261e021eafe07792af901e5485b6fbe794 Author: Daniel Willmann <daniel(a)totalueberwachung.de> Date: Thu Jan 9 14:30:55 2014 +0100 ipaccess: Enable TCP keepalive by default on all BTS connections This way we can find out fast if the connection is broken. Ticket: OW#1060 http://cgit.osmocom.org/osmo-bts/commit/?id=63ddf4645c1af041001060e91f982eb… commit 63ddf4645c1af041001060e91f982eb59b3deb5c Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Dec 28 21:19:19 2013 +0100 ipaccess: Fix crash when no IPA message is sent first on the RSL port The issue was that the link has not been configured yet and the list has not been initialized yet (it is NULL for next/prev). Check if the ts is not configured before searching a link. Reproduce with: (Sockets.StreamSocket remote: 'localhost' port: 3003) nextPutAll: #[0 1 0 0]; flush. Backtrace: #0 e1inp_lookup_sign_link (e1i=0x27af8c0, tei=0 '\000', sapi=0 '\000') at e1_input.c:437 437 if (link->sapi == sapi && link->tei == tei) (gdb) bt #0 e1inp_lookup_sign_link (e1i=0x27af8c0, tei=0 '\000', sapi=0 '\000') at e1_input.c:437 #1 0x00007f338ee87d49 in handle_ts1_read (bfd=0x27afe60) at input/ipaccess.c:436 #2 ipaccess_fd_cb (bfd=0x27afe60, what=1) at input/ipaccess.c:586 #3 0x00007f338f0976ce in osmo_select_main (polling=0) at select.c:158 #4 0x0000000000407394 in main (argc=<optimized out>, argv=0x7fff1aa4fed8) at bsc_hack.c:346 (gdb) p *e1i $1 = {type = E1INP_TS_TYPE_NONE, num = 2, line = 0x222e860, lapd = 0x0, {sign = { sign_links = {next = 0x0, prev = 0x0}, delay = 0, tx_timer = {node = { rb_parent_color = 0, rb_right = 0x0, rb_left = 0x0}, list = {next = 0x0, prev = 0x0}, timeout = {tv_sec = 0, tv_usec = 0}, active = 0, cb = 0, data = 0x0}}, trau = {demux = {chan_activ = 0 '\000', subch = {{ out_bitbuf = '\000' <repeats 319 times>, out_idx = 0, consecutive_zeros = 0, in_sync = 0}, {out_bitbuf = '\000' <repeats 319 times>, out_idx = 0, consecutive_zeros = 0, in_sync = 0}, {out_bitbuf = '\000' <repeats 319 times>, out_idx = 0, consecutive_zeros = 0, in_sync = 0}, { out_bitbuf = '\000' <repeats 319 times>, out_idx = 0, consecutive_zeros = 0, in_sync = 0}}, out_cb = 0, data = 0x0}, mux = {subch = {{tx_queue = {next = 0x0, prev = 0x0}}, {tx_queue = {next = 0x0, prev = 0x0}}, {tx_queue = {next = 0x0, prev = 0x0}}, {tx_queue = {next = 0x0, prev = 0x0}}}}}}, driver = {misdn = { fd = {list = {next = 0x7f338f2a7950, prev = 0x250f890}, fd = 19, when = 1, cb = 0x7f338ee87c40 <ipaccess_fd_cb>, data = 0x27af2c0, priv_nr = 2}}, ipaccess = { fd = {list = {next = 0x7f338f2a7950, prev = 0x250f890}, fd = 19, when = 1, cb = 0x7f338ee87c40 <ipaccess_fd_cb>, data = 0x27af2c0, priv_nr = 2}}, dahdi = {fd = { list = {next = 0x7f338f2a7950, prev = 0x250f890}, fd = 19, when = 1, cb = 0x7f338ee87c40 <ipaccess_fd_cb>, data = 0x27af2c0, priv_nr = 2}}, rs232 = {fd = { list = {next = 0x7f338f2a7950, prev = 0x250f890}, fd = 19, when = 1, cb = 0x7f338ee87c40 <ipaccess_fd_cb>, data = 0x27af2c0, priv_nr = 2}}}} http://cgit.osmocom.org/osmo-bts/commit/?id=7ae850337058168afc62cb4cac9cfc9… commit 7ae850337058168afc62cb4cac9cfc97b21d520b Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Dec 12 12:43:15 2013 +0100 debian: Depend directly on the two libraries needed for libosmo-abis Do not pull in libosmocore but let the abis/trau library pull in the DSO that is actually linked to. http://cgit.osmocom.org/osmo-bts/commit/?id=d65ccd50fa9ef585e81b13445b4595e… commit d65ccd50fa9ef585e81b13445b4595ecf982e093 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Dec 12 12:30:29 2013 +0100 debian: Enable the hardening options for this library http://cgit.osmocom.org/osmo-bts/commit/?id=05a337c8b40e3195bcb21ccaeddb970… commit 05a337c8b40e3195bcb21ccaeddb97017dbb384c Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Dec 12 12:23:10 2013 +0100 debian: Address warnings and increase standards version http://cgit.osmocom.org/osmo-bts/commit/?id=ece5323fd32bd3b406fab2f14f93235… commit ece5323fd32bd3b406fab2f14f93235f0f039fdf Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Dec 12 12:05:14 2013 +0100 debian: Split the libraries into separate packages This way one can install two ABI incompatible versions of the library at the same time. This will ease future transition. Create a dummy/compatible package. http://cgit.osmocom.org/osmo-bts/commit/?id=91de2d0065ac597723f195c9a788741… commit 91de2d0065ac597723f195c9a78874121c3ff325 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Dec 12 11:47:39 2013 +0100 debian: Add depedency to newer libosmocore and update the changelog http://cgit.osmocom.org/osmo-bts/commit/?id=e0bd2f6d4e293d118e728dddda1a0b9… commit e0bd2f6d4e293d118e728dddda1a0b95f9853e4e Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Dec 12 11:48:01 2013 +0100 build: Ignore newer automake generated file http://cgit.osmocom.org/osmo-bts/commit/?id=3ea52e4f4c463b56ad59db5f041b279… commit 3ea52e4f4c463b56ad59db5f041b27940140fbad Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 11 14:13:14 2013 +0100 ipa-proxy/vty: Removed enable/ipa node This was basically a link to configure/ipa which is not cleanly supported by the current VTY framework. The test program uses the default implementation for go_parent_cb/vty_go_parent() and is_config_node, since config-ipa is a top level config node which is assumed by default. http://cgit.osmocom.org/osmo-bts/commit/?id=1c9dcc1236457b5efe4660d902eb334… commit 1c9dcc1236457b5efe4660d902eb3342adebd16a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 11 14:13:13 2013 +0100 vty: Use same prompt string format like in libosmocore Ensures a single blank after the '#'. Use (config-foo) instead (foo) for config nodes. http://cgit.osmocom.org/osmo-bts/commit/?id=37f0695626ff57e518edc071b6db10f… commit 37f0695626ff57e518edc071b6db10f084ea9536 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 11 14:13:12 2013 +0100 vty: Use new vty_install_default() function This patch removes the local 'end' and 'exit' implementations and uses the generic ones provided by libosmocore instead, which are enabled automatically when vty_install_default() is used. http://cgit.osmocom.org/osmo-bts/commit/?id=e58d33153dd2bed3629b9a09fd6add5… commit e58d33153dd2bed3629b9a09fd6add58f296bd6a Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sun Oct 6 13:34:43 2013 +0200 ortp: Fix the version check for ORTP by not using the cached result The second check used the cached result for ORTP. Store the result in ORTP_VERSION and my system properly detects that it is running on < 0.21. The HAVE_ORTP_021 will always be defined so just use #if and not the #ifdef to fix the build. http://cgit.osmocom.org/osmo-bts/commit/?id=2bfc01dfd8830cf36bb8f7564604f7f… commit 2bfc01dfd8830cf36bb8f7564604f7f357c0a0fb Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Oct 6 12:23:35 2013 +0200 enable support of libortp >= 0.21, which has an API breakage in libortp >= 0.21, rtp_session_set_local_addr() has one extra argument for the RTCP port. http://cgit.osmocom.org/osmo-bts/commit/?id=51b796122ccb3f7952d8826c75bd803… commit 51b796122ccb3f7952d8826c75bd803c0df65992 Merge: ef13269 a98a625 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Oct 6 11:56:41 2013 +0200 Merge branch 'laforge/ipa-client-fixes' http://cgit.osmocom.org/osmo-bts/commit/?id=a98a6254bf636756bb5e9e6d00b06d3… commit a98a6254bf636756bb5e9e6d00b06d39555909d2 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 20:21:41 2013 +0200 it's called 'truncated' message, not 'trunked' http://cgit.osmocom.org/osmo-bts/commit/?id=6eddd478e2bd8f10dbb5e8fc0f5058c… commit 6eddd478e2bd8f10dbb5e8fc0f5058c07ce12138 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 20:18:53 2013 +0200 ipaccess.c: call sign_link_up() only _after_ tx ID_ACK/ID_RESP in order to keep the message ordering right, we first send the ID_ACK/ID_RESP messages, before handing sign_link_up() into the application. This ensures that no OML messages get transmitted before the ID_ACK/ID_RESP has been completed http://cgit.osmocom.org/osmo-bts/commit/?id=51de9ca3a64ccb652acdfa72f4f4bd2… commit 51de9ca3a64ccb652acdfa72f4f4bd27a60f474b Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 20:13:16 2013 +0200 IPA: remove automatic reconnect logic When an IPA link is in client (BTS) mode, we should not automatically re-connect in the lowest (ipa) layer. Instead, we properly close the socket if the link is dead, and we call link->updown_cb() to notify the user that the link is down. The e1inp/ipaccess layer translates this into a line->sign_link_down() callback that propagates up to the user. http://cgit.osmocom.org/osmo-bts/commit/?id=a3e9dd57570630d020fdf308d38e065… commit a3e9dd57570630d020fdf308d38e0650801da0a5 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 14:25:07 2013 +0200 ipaccess: rename ipaccess_bts_cb() to ipaccess_bts_read_cb() this is consistent with ipaccess_bts_write_cb(). http://cgit.osmocom.org/osmo-bts/commit/?id=e68055bf112c62a5134c6f88f838496… commit e68055bf112c62a5134c6f88f8384967515fb884 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 14:21:54 2013 +0200 ipa: protect against multiple subsequent calls to ipa_client_conn_close() This would create linked list coruption in osmo_fd_unregister(). The fact that multiple calls of osmo_fd_unrgeister() on the same fd happen is due to the fact that ipaccess_drop() and others already close the file descriptor. http://cgit.osmocom.org/osmo-bts/commit/?id=10b41306dbddd6e2cdb182e33f1f1be… commit 10b41306dbddd6e2cdb182e33f1f1be03152375d Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 14:05:49 2013 +0200 ipaccess: Properly resolve 'line' in error case If a write on an IPA file descriptor fails, then we call ipaccess_drop(). However, only in the BSC side the assumption that bfd->data == e1inp_line holds true. On the BTS side, ofd->data references to the ipa_client_conn structure. In order to avoid the problem, call ipaccess_drop() with an explicit reference to the line in which the link was dropped. http://cgit.osmocom.org/osmo-bts/commit/?id=84f67b2832f984fd28e78596bc3d7fb… commit 84f67b2832f984fd28e78596bc3d7fbbc661e04f Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 13:13:59 2013 +0200 Don't establish RSL at same time as OML link on IPA type lines If we have a BTS-side e1inp_line, we can only establish OML at the time of line_update. We have to wait with RSL until the BTS explicitly tells us the RSL destination IP and port (received via OML from BSC). This is now handled in a new function called e1inp_ipa_bts_rsl_connect(). http://cgit.osmocom.org/osmo-bts/commit/?id=d331f862dc5d0217a836c8826790c45… commit d331f862dc5d0217a836c8826790c45e86b77ec3 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 30 13:12:24 2013 +0200 Remove duplication between libosmocore ipaccess.h and libosmoabis ipaccess.h http://cgit.osmocom.org/osmo-bts/commit/?id=ef13269e071ebfb0eb301c0b1d12072… commit ef13269e071ebfb0eb301c0b1d12072218f25cb0 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Mon Jul 8 01:17:27 2013 +0200 input: fix compilation warning due to missing include osmocom/core/backtrace.h input/ipa.c: In function 'ipa_server_link_create': input/ipa.c:344:2: warning: implicit declaration of function 'osmo_generate_backtrace' [-Wimplicit-function-declaration] input/ipaccess.c: In function 'ipaccess_bts_cb': input/ipaccess.c:873:2: warning: implicit declaration of function 'osmo_generate_backtrace' [-Wimplicit-function-declaration] http://cgit.osmocom.org/osmo-bts/commit/?id=cdda0a87e4a65ff07fb1de85f226c87… commit cdda0a87e4a65ff07fb1de85f226c875f619f9a6 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Mon Jul 8 01:13:19 2013 +0200 ipa: stricter accept callback handling in ipa_server_link_create Add assertion as suggested by Holger. This function does not make much sense with the accept callback set. While at it, check return value of the accept callback and release the peer socket in case such callback returns an error. Reported by Holger. Reference: CID 1040692 http://cgit.osmocom.org/osmo-bts/commit/?id=33f7175764af20d2f71c243945090f1… commit 33f7175764af20d2f71c243945090f166ea5c454 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 5 15:44:12 2013 +0200 e1_input: fix compilation warning in e1inp_tx_ts e1_input.c: In function 'e1inp_tx_ts': e1_input.c:620:6: warning: variable 'len' set but not used [-Wunused-but-set-variable] Fix it by performing a stricter checking on the muxed bits before transmission. Let's see if this spots some hidden bug in this code. http://cgit.osmocom.org/osmo-bts/commit/?id=f69b8123f9507d1c854d265c4950894… commit f69b8123f9507d1c854d265c4950894843fd9b85 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jul 6 18:54:58 2013 +0200 dahdi: Fix potential but unlikely out of bounds access The line->port_nr is compared to the array size of the span config and then the array can be potentially accessed one element outside of the array. Fixes: Coverity 1042368 http://cgit.osmocom.org/osmo-bts/commit/?id=219a6a4add60d41ad08730cdf506a2f… commit 219a6a4add60d41ad08730cdf506a2f63b0015a0 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jul 6 18:49:59 2013 +0200 misdn: Fix a file descriptor leak in _mi_e1_line_update The socket is created to get information about the ISDN system and can be released once we have found the information. Fixes: Coverity CID 1040691 http://cgit.osmocom.org/osmo-bts/commit/?id=2e11f5c7dc3e1cda51853d31ffe5856… commit 2e11f5c7dc3e1cda51853d31ffe585658ac39640 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 5 15:08:18 2013 +0200 e1_input: fix compilation warning in e1_set_pcap_fd CC e1_input.lo e1_input.c: In function 'e1_set_pcap_fd': e1_input.c:143:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] e1_set_pcap_fd returns now the result of write. OpenBSC is still assuming that this function returns nothing, so it simply ignores this return value by now. http://cgit.osmocom.org/osmo-bts/commit/?id=4bab3bf415985f778e826aaf68e4e1c… commit 4bab3bf415985f778e826aaf68e4e1c0815edf2d Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 5 15:00:13 2013 +0200 input: ipaccess: stricter string handling in ipa_bts_id_resp These strings are locally set via the BTS configuration, not the network, but make sure we don't overrun the buffer. Reference: CID 1040690 http://cgit.osmocom.org/osmo-bts/commit/?id=a8c4871a2a4ebeeba9f0a612d838330… commit a8c4871a2a4ebeeba9f0a612d838330f77a53769 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 5 14:47:41 2013 +0200 input: ipa: close descriptor if no accept callback is set Reported by Holger. Reference: CID 1040692 http://cgit.osmocom.org/osmo-bts/commit/?id=b948701f8c68be21e0205eaf9e1a86d… commit b948701f8c68be21e0205eaf9e1a86d4fe798300 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 5 14:38:43 2013 +0200 input: ipaccess: fix possible NULL dereference Unlikely to happen, but add assertion for correctness. Reported by Holger. Reference: CID 1042352 http://cgit.osmocom.org/osmo-bts/commit/?id=3a5b4364e84042acb1ca2836739d7c1… commit 3a5b4364e84042acb1ca2836739d7c1716ee3aaf Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Jul 4 20:05:50 2013 +0200 ipa_proxy: The ret variable was not initialized/assigned Remove the unused variable and return -ENOMEM in case of an error and return 0 at the normal exit. Fixes: Coverity CID 1040689 http://cgit.osmocom.org/osmo-bts/commit/?id=8cbd9f4d09fc906f744f09899acb097… commit 8cbd9f4d09fc906f744f09899acb097ebb75fb83 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Jul 4 20:00:33 2013 +0200 e1_input_vty: Help coverity in understanding this code In theory argc could be negative and this code would crash with a null pointer dereference on the line pointer. Check for <= to avoid this warning. Fixes: Coverity CID 1040699 http://cgit.osmocom.org/osmo-bts/commit/?id=a677cbc0cbeaf6c4f7b29943793ab8d… commit a677cbc0cbeaf6c4f7b29943793ab8dd76227a7c Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Jul 4 19:52:41 2013 +0200 ipa: Fix the size of the streamid array used in the proxy code We want to store stream ids 0 to 0xff. This means we need to have 256 entries in this array. Fixes: Coverity CID 1040697, CID 1040696, CID 1040695, CID 1040694 http://cgit.osmocom.org/osmo-bts/commit/?id=9d4fe51424eb424b7edab3b297cc105… commit 9d4fe51424eb424b7edab3b297cc105b5d3aaf59 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Jul 4 19:45:34 2013 +0200 hsl: Remove the input handling for the HSL BTS I have removed HSL support from OpenBSC, the E1/Abis code is now unused and can be removed. Fixes: Coverity CID 1040693 http://cgit.osmocom.org/osmo-bts/commit/?id=3eed8a115adf5319ccaccbfe8f2325f… commit 3eed8a115adf5319ccaccbfe8f2325f764d72d15 Author: Alexander Huemer <alexander.huemer(a)xx.vu> Date: Tue Jun 11 14:13:50 2013 +0200 Makefile.am: Use AM_CPPFLAGS Since automake 1.13 INCLUDES is depricates and causes a warning http://cgit.osmocom.org/osmo-bts/commit/?id=5731dd74f76e7b9c6778ee57937fc92… commit 5731dd74f76e7b9c6778ee57937fc92bb8be34d3 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Sat Mar 9 17:35:17 2013 +0100 misdn: Set ret to 0 when using the LAPD from userspace Warning: input/misdn.c:252:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (mline->use_userspace_lapd) { ^~~~~~~~~~~~~~~~~~~~~~~~~ input/misdn.c:289:9: note: uninitialized use occurs here return ret; ^~~ input/misdn.c:252:2: note: remove the 'if' if its condition is always false if (mline->use_userspace_lapd) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ input/misdn.c:241:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 1 warning generated. http://cgit.osmocom.org/osmo-bts/commit/?id=4b6860db447ffb3997acd7394ea822f… commit 4b6860db447ffb3997acd7394ea822f29303e797 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Sat Mar 9 17:32:33 2013 +0100 lapd: Do not override t203_sec initialization. This was spotted by clang3.3 and got broken in git revision f42280b6a235163ab935abc9fd36b60716d7a460 when moving to the C99 initializer. Warning: input/lapd.c:106:30: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] .t203_sec = 20, .t203_sec = 0, ^ input/lapd.c:106:14: note: previous initialization is here .t203_sec = 20, .t203_sec = 0, ^~ 1 warning generated. http://cgit.osmocom.org/osmo-bts/commit/?id=e7a3f43d86fe42cfd1b7786d45063fb… commit e7a3f43d86fe42cfd1b7786d45063fb6b2573cba Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Feb 19 13:35:22 2013 +0100 ortp: Don't write error callbacks to stderr, but use osmocom logging http://cgit.osmocom.org/osmo-bts/commit/?id=41bc615c3f3e92975176b3f4053734c… commit 41bc615c3f3e92975176b3f4053734c0e3e193bc Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Thu Feb 14 11:03:26 2013 +0100 RTP: Allow disabling jitter buffer by setting a buffer size of 0 http://cgit.osmocom.org/osmo-bts/commit/?id=cf5b08bcd28e833b5e20bd28cef9afb… commit cf5b08bcd28e833b5e20bd28cef9afbb2f56fa59 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Wed Feb 13 20:12:36 2013 +0100 debian: Create a debug package for the libosmo-abis code http://cgit.osmocom.org/osmo-bts/commit/?id=d426d458ca96ba29793e35b1b2a73fb… commit d426d458ca96ba29793e35b1b2a73fbcb3b2c888 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Feb 9 11:01:19 2013 +0100 Permit libortp to use the connect() syscall, enabling later getsockname() If we bind a local socket to INADDR_ANY, then getsockname() will always return 0.0.0.0 for the local IP address _unless_ the socket was previously connected to a specific remote IP/port using connect(). This will have the side effect that we only accept RTP packets from the one IP/port that we have connect()ed to, but that is actually intentional and useful in our applications. http://cgit.osmocom.org/osmo-bts/commit/?id=bd3f854f3c2d468722b26289fa52e38… commit bd3f854f3c2d468722b26289fa52e381da41a455 Author: Daniel Willmann <daniel(a)totalueberwachung.de> Date: Wed Dec 26 11:16:13 2012 +0100 tests: Don't delete atconfig in clean This file is created in ./configure so we shouldn't remove it with make. Otherwise ./configure && make clean && make check fails with: make[3]: *** No rule to make target `atconfig', needed by `check-local'. Stop. http://cgit.osmocom.org/osmo-bts/commit/?id=2dfcd9ecc13b39f552e5c1aed80a10f… commit 2dfcd9ecc13b39f552e5c1aed80a10f5f9144422 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Tue Nov 6 13:34:34 2012 +0100 debian: Update the changelog for the release of the new version http://cgit.osmocom.org/osmo-bts/commit/?id=cbb78ab9985d83563841df098837e97… commit cbb78ab9985d83563841df098837e97623db0b19 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Tue Nov 6 13:29:44 2012 +0100 debian: Do not override the CFLAGS as this can cause miscompilation We have witnessed how the bits test got miscompiled. Do not introduce our own version of the CFLAGS but use the defaults of the debian project http://cgit.osmocom.org/osmo-bts/commit/?id=a49c24d9657471deb90a9425cabdb8d… commit a49c24d9657471deb90a9425cabdb8d3d56f36df Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Oct 16 11:24:08 2012 +0200 ipaccess: relax default behaviour on errors coming from signalling layer This patch relaxes the behaviour on error coming from the signalling layer. This is probably too strict for recoverable errors. Don't release msgb in this case, as this is controled by the signaling link layer. Thanks to Lennart Müller <mueller.lennart(a)googlemail.com> for the report. http://cgit.osmocom.org/osmo-bts/commit/?id=bcb9531366fcd1400b079316e452441… commit bcb9531366fcd1400b079316e452441f64d22af2 Author: Tobias Engel <tobias(a)tobi.as> Date: Fri Oct 12 12:12:07 2012 +0200 Test parsing of GSM 08.60 frame sync header Tests if the frame synchronization header is correctly recognized. The problem tested for is the following: The sync header consists of 16 zero-bits followed by 1 one-bit. Before, subchan_demux only tested for the 16 zero-bits. But if the previous frame ended in one or more zero-bits these were then already counted as belonging to the sync header, leading to a frame that was shifted by one or more bits. http://cgit.osmocom.org/osmo-bts/commit/?id=bc5dcb11a714c3e73982299f421790b… commit bc5dcb11a714c3e73982299f421790b3da93e584 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Thu Oct 11 08:25:36 2012 +0200 tests: Add a test stub for the subchan_demux tests Tobias has worked on CSD support and Dieter has helped with a CSD trau fix. This is a stub that should allow to easily write a test case for the syncing issue observed by Tobias. Run the tests: $ make check In case of failure: $ vi tests/testsuite.dir/1/testsuite.log Add the actual content: $ edit tests/subchan_demux/subchan_demux_test.c Update the test result: $ ./tests/subchan_demux/subchan_demux_test > tests/subchan_demux/subchan_demux_test.ok http://cgit.osmocom.org/osmo-bts/commit/?id=f684976724b04324f2634755bc0f290… commit f684976724b04324f2634755bc0f2904c67d91c9 Author: Tobias Engel <t-openbsc(a)tobias.org> Date: Mon Oct 8 23:06:44 2012 +0200 Adds support for GSM 08.60 data frame en-/decoding There is no interworking function (IWF) here. The contents of an uplink frame simply gets copied into a downlink frame. For this to work both sides of the call need to connect with the same speed and parameters. http://cgit.osmocom.org/osmo-bts/commit/?id=08c103251c6dee2b3276ea7d5b15195… commit 08c103251c6dee2b3276ea7d5b1519560c910cfe Author: Dieter Spaar <spaar(a)mirider.augusta.de> Date: Mon Oct 8 21:36:03 2012 +0200 Make sure sync header was fully received The sync header consists of 16 zero-bits followed by 1 one-bit. Before, subchan_demux only tested for the 16 zero-bits. But if the previous frame ended in one or more zero-bits these were then already counted as belonging to the sync header, leading to a frame that was shifted by one or more bits. http://cgit.osmocom.org/osmo-bts/commit/?id=d72c478b06a4a418046ee203aeba6b5… commit d72c478b06a4a418046ee203aeba6b5d6f0bc69e Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Thu Oct 11 08:19:10 2012 +0200 misc: Ignore files generated by vim http://cgit.osmocom.org/osmo-bts/commit/?id=5c65e79edcbf220b0422151e08547ca… commit 5c65e79edcbf220b0422151e08547ca796a44221 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Thu Oct 11 08:05:14 2012 +0200 tests: Add boilerplate to be able to have tests in libosmo-abis http://cgit.osmocom.org/osmo-bts/commit/?id=84e5cb9b3496527d43af974f2f89396… commit 84e5cb9b3496527d43af974f2f89396d8145d743 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Aug 23 23:41:54 2012 +0200 ipaccess: fix leak of IPA control messages in the BTS side http://cgit.osmocom.org/osmo-bts/commit/?id=7251604cce2643fa74c73c1fa037185… commit 7251604cce2643fa74c73c1fa0371851a36ef46b Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Aug 23 23:34:05 2012 +0200 tests: e1inp_ipa_*_test: fix leak of msgb in ->sign_link path Fix a leak in the tests: The ->sign_link callback is reponsible for releasing the msgb. http://cgit.osmocom.org/osmo-bts/commit/?id=1fd93bbc6edbf1c297d71739242e8f3… commit 1fd93bbc6edbf1c297d71739242e8f35aa499787 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Aug 23 23:26:19 2012 +0200 tests: e1inp_ipa_*_test: add signal handling for process termination This patch adds signal handling to release memory in the exit path of the tests. This is good to check what memory we are leaking in the exist path of the tests. http://cgit.osmocom.org/osmo-bts/commit/?id=7723b4e9a3fd51cec28fb4842347247… commit 7723b4e9a3fd51cec28fb48423472479cd41d95e Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Aug 23 13:51:27 2012 +0200 tests: fix CPU suckup e1inp_ipa_bts_test after test finish We have to read from the eventfd, otherwise select keeps returning the file descriptor as ready to read. http://cgit.osmocom.org/osmo-bts/commit/?id=953060001d2cb6ef86f432a79599da2… commit 953060001d2cb6ef86f432a79599da2951780ef7 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 22 16:43:59 2012 +0200 input: add generic PCAP interface for LAPD This patch allows you to create PCAP traces between the BSC and BTS including the LAPD frames. Useful for debugging communication issues. So far, it was only possible to create layer 3 traces containing OML/RSL. LAPD traces can be also interesting to debug communication issues between the BSC and the BTS. To enable PCAP of LAPD, you only have to invoke: li->pcap_fd = osmo_pcap_lapd_open("/tmp/file.pcap", 0600); By default, li->pcap_fd is set to -1 which means disabled. openBSC needs a patch to replace all usage of e1_set_pcap_fd by osmo_pcap_lapd_open. http://cgit.osmocom.org/osmo-bts/commit/?id=7ed92581ee20b77911171355cf1d40c… commit 7ed92581ee20b77911171355cf1d40c617a0b44b Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Mon Mar 12 18:38:45 2012 +0100 input: dahdi: replace exit by return This is a library, we leave up to the client code to decide when to finish the code execution. http://cgit.osmocom.org/osmo-bts/commit/?id=5c67fb5610e1b707d58fb305d92b819… commit 5c67fb5610e1b707d58fb305d92b81966de452c6 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Mon Mar 12 18:34:12 2012 +0100 input: dahdi: use logging facilities instead of fprintf and stderr http://cgit.osmocom.org/osmo-bts/commit/?id=f42280b6a235163ab935abc9fd36b60… commit f42280b6a235163ab935abc9fd36b60716d7a460 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Mon Mar 12 18:17:31 2012 +0100 lapd: use C99 structure initialization for profile templates http://cgit.osmocom.org/osmo-bts/commit/?id=18d6294efe51b4c39eefca52a5af571… commit 18d6294efe51b4c39eefca52a5af5710ac947b04 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 22 16:12:47 2012 +0200 tests: e1inp_ipa_bts_test: fix compilation warnings CC e1inp_ipa_bts_test.o e1inp_ipa_bts_test.c: In function ‘sign_link_up’: e1inp_ipa_bts_test.c:47:8: warning: variable ‘dst’ set but not used [-Wunused-but-set-variable] e1inp_ipa_bts_test.c: In function ‘test_bts_gsm_12_21_cb’: e1inp_ipa_bts_test.c:211:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] CCLD e1inp_ipa_bts_test http://cgit.osmocom.org/osmo-bts/commit/?id=1e4019483fd4914c0cd13af81404a8d… commit 1e4019483fd4914c0cd13af81404a8db24e976d3 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 22 14:16:24 2012 +0200 ipaccess: improve error handling If we hit any error, spot an error message containing the reason and close the links to start over. This patch has been tested by injecting errors in: * ipaccess_send, by randomly returning -1. * returning error from the ->sign_link_up callback, both from the OML and RSL links. * returning error from the ->sign_link callback, both for the OML and RSL links. With this patch, Valgrind shows no "definitely lost" memory blocks anymore (including the error path that has been tested) and the ipaccess driver behaves more robustly in case of errors. Acked-by: Holger Freyther <holger(a)freyther.de> http://cgit.osmocom.org/osmo-bts/commit/?id=5a8cca3a1c25947b5f7a4ede92b7ae2… commit 5a8cca3a1c25947b5f7a4ede92b7ae237c708e02 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 22 14:01:49 2012 +0200 tests: e1inp_ipa_bsc_test: fix crash The sequence to trigger the crash was: 1) establish a full A-bis IPA link (both OML and RSL correctly established and ID_RESP received from BTS). 2) nc 127.0.0.1 3002 # establish OML link only I forgot to set to NULL the oml and rsl links we're using. Otherwise, the test calls e1inp_sign_link_destroy(rsl) which does not exists. http://cgit.osmocom.org/osmo-bts/commit/?id=6cc3f92ea415736ed2461d5ae15eef8… commit 6cc3f92ea415736ed2461d5ae15eef82e72c2200 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 22 13:57:58 2012 +0200 ipaccess: fix leak of e1inp_line Holger reported a leak in the ipaccess_drop path and a patch to fix this. This is a new version of the patch posted that also handle the case in which only one of the link (OML / RSL) is established and no ID_RESP was received. Based on patch of Holger Freyther. http://cgit.osmocom.org/osmo-bts/commit/?id=81ed7599931b662c04c5a65bf108810… commit 81ed7599931b662c04c5a65bf1088102c4aa11cf Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 22 16:35:17 2012 +0200 ipa: fix missing set of write_cb for IPA client connection Now the BTS and BSC tests work again. http://cgit.osmocom.org/osmo-bts/commit/?id=d11a5c110355f86c7673777632cb797… commit d11a5c110355f86c7673777632cb797bf20722eb Author: Eric Butler <eric(a)codebutler.com> Date: Tue Aug 14 20:56:26 2012 -0700 Use package version since git info won't be available. http://cgit.osmocom.org/osmo-bts/commit/?id=91ffa2b5c1acf319b1c0e8f4a7f28aa… commit 91ffa2b5c1acf319b1c0e8f4a7f28aad63de7710 Author: Eric Butler <eric(a)codebutler.com> Date: Tue Aug 14 18:07:48 2012 -0700 Add debian/ubuntu packaging files. http://cgit.osmocom.org/osmo-bts/commit/?id=9e8f1c0362214760f6c56ca3f28654f… commit 9e8f1c0362214760f6c56ca3f28654f8a88973ea Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Sat Jul 21 00:09:52 2012 +0200 doc: Describe the optional 'stats' parameter http://cgit.osmocom.org/osmo-bts/commit/?id=36bac9a8b14c976f747335e6feefb49… commit 36bac9a8b14c976f747335e6feefb49f3d631848 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Fri Jul 20 23:49:52 2012 +0200 doc: Add a newline to fix the documentation of the HSL option http://cgit.osmocom.org/osmo-bts/commit/?id=e5ae7f52175411a498ed30560624d0a… commit e5ae7f52175411a498ed30560624d0abed0feed7 Author: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> Date: Sat Jun 30 15:23:02 2012 -0700 build: remove checks introduced by autoscan. Therre is no current use of HAVE_* variables for these checks in the code, so there is no reason to keep the checks around. Signed-off-by: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> http://cgit.osmocom.org/osmo-bts/commit/?id=6e389a3b2bb9d9610f7ae24d8e47518… commit 6e389a3b2bb9d9610f7ae24d8e4751815bb61ab5 Author: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> Date: Sat Jun 30 15:23:01 2012 -0700 build: consolidate automake options to configure.ac Also disable building the gzip distribution since we're building the bzip2-compressed tarball already. Signed-off-by: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> http://cgit.osmocom.org/osmo-bts/commit/?id=56855350e9469f1af02a4cbfbde0385… commit 56855350e9469f1af02a4cbfbde038584719c787 Author: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> Date: Sat Jun 30 15:23:00 2012 -0700 build: build libosmotrau.la in the src directory. This spares us another recursion, and allows a much higher parallelisation, since trau is only one source unit and one standalone library. Incidentally, also make sure that the version specification for libosmoabis is applied. Signed-off-by: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> http://cgit.osmocom.org/osmo-bts/commit/?id=05819cebc43bf65813aa4997eedc64c… commit 05819cebc43bf65813aa4997eedc64c94b25ff97 Author: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> Date: Sat Jun 30 15:22:59 2012 -0700 build: avoid using a convenience library for the input subdirectory. automake is well capable of building sources present in sub-directory without requiring a recursion, so there is no reason to use a non-installed library just for the extra files. Signed-off-by: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> http://cgit.osmocom.org/osmo-bts/commit/?id=3dfe8bf80cee819e98618c03eb503a7… commit 3dfe8bf80cee819e98618c03eb503a79830c2f61 Author: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> Date: Sat Jun 30 15:22:58 2012 -0700 build: only build tests during make check Signed-off-by: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> http://cgit.osmocom.org/osmo-bts/commit/?id=51f7940d1f4ebefef34dc5d7ad70e61… commit 51f7940d1f4ebefef34dc5d7ad70e61eec62c3cd Author: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> Date: Sat Jun 30 15:22:57 2012 -0700 build: use nobase_include_HEADERS instead of using recursive Makefiles This simplifies installation of include files, as make no longer have to recurse into subdirectories and install each subset of files in different directories. Signed-off-by: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> http://cgit.osmocom.org/osmo-bts/commit/?id=62f0e0612a0b63092b91a3c1e6588ab… commit 62f0e0612a0b63092b91a3c1e6588abcf8a7ff0a Author: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> Date: Sat Jun 30 15:22:56 2012 -0700 build: use LT_INIT([pic-only]) instead of forcing -fPIC in AM_CFLAGS. Also contextually remove the AC_PROG_LIBTOOL call (which is an obsolete name for what is now LT_INIT). Signed-off-by: Diego Elio Pettenò <flameeyes(a)flameeyes.eu> http://cgit.osmocom.org/osmo-bts/commit/?id=584672e8f4f009b7050e7617835cdcf… commit 584672e8f4f009b7050e7617835cdcfcf525daf5 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Mon Mar 26 16:36:21 2012 +0200 misc: Fix the email address in the configure.ac http://cgit.osmocom.org/osmo-bts/commit/?id=36a85a41b01d80fc52ecd5793a4366d… commit 36a85a41b01d80fc52ecd5793a4366d087d43b77 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Mar 18 18:45:52 2012 +0100 ipaccess: hex-dump message in case ops->sign_link() returns an error http://cgit.osmocom.org/osmo-bts/commit/?id=180ce7eaadc6147d5a178b436fc9396… commit 180ce7eaadc6147d5a178b436fc939662234beff Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Fri Feb 3 20:06:15 2012 +0100 e1_input.h: Declare abis_rsl_sendmsg(struct msgb *msg) The E1 abstraction provides the above method, declare it in our header file. GCC warning (of OpenBSC): abis_rsl.c: In function ‘rsl_bcch_info’: abis_rsl.c:221:2: warning: implicit declaration of function ‘abis_rsl_sendmsg’ [-Wimplicit-function-declaration] http://cgit.osmocom.org/osmo-bts/commit/?id=df78e925962a419a318c1f0279a9724… commit df78e925962a419a318c1f0279a9724b986beed3 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Fri Jan 27 09:58:56 2012 +0100 osmo-ortp: Prefix oRTP messages with osmo-ortp When many applications write to the stdout it is not clear that 'network_error' comes from osmo-bts due the usage of oRTP. At least provide a hint that oRTP is involved. http://cgit.osmocom.org/osmo-bts/commit/?id=a659f4827eb3f78815c56ea1ca8b311… commit a659f4827eb3f78815c56ea1ca8b311d4e764b00 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Wed Jan 18 19:07:30 2012 +0100 Fixed TRAU frame handling of packet lengths that are not a multiple of 4 http://cgit.osmocom.org/osmo-bts/commit/?id=4308667a25f67469924050114ab3d4b… commit 4308667a25f67469924050114ab3d4b53960a72b Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Wed Jan 18 19:06:12 2012 +0100 Fixed wrong reference while opening mISDN socket http://cgit.osmocom.org/osmo-bts/commit/?id=55467f0478e37b35cceec3051c645b8… commit 55467f0478e37b35cceec3051c645b8a407110bc Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Wed Dec 28 19:47:07 2011 +0100 abis/close: Deliver S_L_INP_TEI_DN when closing the socket * HSL/IPA had different socket closing code for the same thing, create one method for it. * Both methods tried to send an event but as we are on the close path the sign_link was already removed from the list and the input event sending method couldn't find the sign_link using the sapi/tei provided. http://cgit.osmocom.org/osmo-bts/commit/?id=d73c84670b0f74f502d28acbcbbeb67… commit d73c84670b0f74f502d28acbcbbeb672cf8ee4f9 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Tue Dec 20 18:56:42 2011 +0100 mISDN input: avoid some strange distortion caused by buffer mgmt We used to write as many messages as we received from mISDN for b-channels. Now we write as many _bytes_ as we have received, which seems to be the more logical thing to do. http://cgit.osmocom.org/osmo-bts/commit/?id=e194cd92a809b0b6ab3513e6742dba3… commit e194cd92a809b0b6ab3513e6742dba3871179c2e Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Mon Nov 7 13:37:56 2011 +0100 ipa: The message claims to close the socket but it remains open. Correct the 'closing socket' statement. It would be nice to know why this message has been discarded but I can't answer that right now. http://cgit.osmocom.org/osmo-bts/commit/?id=0b5ffc1788fe065b8e4aff15f702333… commit 0b5ffc1788fe065b8e4aff15f7023338914257d6 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Oct 22 15:58:02 2011 +0200 osmo_ortp: include ortp/port.h for the memory management functions http://cgit.osmocom.org/osmo-bts/commit/?id=833aa79ffaa2d6bb62c5aef0c9b980c… commit 833aa79ffaa2d6bb62c5aef0c9b980c5b486d8ff Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Oct 22 15:57:42 2011 +0200 version 0.13.1 of libortp seems sufficient http://cgit.osmocom.org/osmo-bts/commit/?id=25c83611be697f53925184658cdbff7… commit 25c83611be697f53925184658cdbff72de58c8c6 Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Sun Oct 16 17:19:13 2011 +0200 misc: Linker fix for Ubuntu 11.10 --as-needed was default in Natty and somehow got more strict in this version of Ubuntu. Link to osmo vty. http://cgit.osmocom.org/osmo-bts/commit/?id=43f4e088414636bad83176b891ba25c… commit 43f4e088414636bad83176b891ba25cf65fed859 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Oct 10 08:49:01 2011 +0200 depend on new libosmocore 0.3.10 (lapd) and increment LIBVERSION http://cgit.osmocom.org/osmo-bts/commit/?id=8aaed05e216daefe2602136c4b49428… commit 8aaed05e216daefe2602136c4b49428a619d3e45 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sat Oct 1 04:10:57 2011 +0200 Length check of LAPD messages to prevent overflows on corrupt frames http://cgit.osmocom.org/osmo-bts/commit/?id=d88c5bf63772bef53e9864d1ad2aa0e… commit d88c5bf63772bef53e9864d1ad2aa0e0e2ea15a3 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Fri Sep 30 03:41:44 2011 +0200 Fixed missing T203 in profiles http://cgit.osmocom.org/osmo-bts/commit/?id=3c46044cf1d2b352587266784eb064c… commit 3c46044cf1d2b352587266784eb064cb5d08260a Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Wed Sep 28 02:46:16 2011 +0200 Addition to last commit 2f5a3714075882ac946536709ac581453b6ad52a http://cgit.osmocom.org/osmo-bts/commit/?id=3744b873e58008eaba359b52c7a07a9… commit 3744b873e58008eaba359b52c7a07a9741c89cae Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Tue Sep 27 12:12:36 2011 +0200 LAPD profiles are globally defined structures The pre-defined structures can be used as a profile, as well as own defined or modified versions of them. http://cgit.osmocom.org/osmo-bts/commit/?id=a7ff0019b36407cff4691f8e327bb92… commit a7ff0019b36407cff4691f8e327bb925a176ef72 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Mon Sep 26 11:29:30 2011 +0200 Replaced LAPD implementation with new LAPD core of libosmogsm The core functionality of input/lapd.c is removed. Now it uses lapd_core.c of libosmogsm. The stucture of lapd_instance and SAP (SAPI/TEI handling) is kept, as well as interfaceing and header transcoding. The former implementation of datalink is completely replaced, except for the minimal TEI manager.. Currently it supports 3 modes: - ABIS (BS11/Ericsson/Nokia) - ISDN (Not used yet) - ASAT (A interface for satellite) all these modes can run as NETWORK or USER. http://cgit.osmocom.org/osmo-bts/commit/?id=fe05cf5b3980bf4778a21b3d311a835… commit fe05cf5b3980bf4778a21b3d311a835b7e19a704 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Sep 26 23:18:41 2011 +0200 DAHDI: add information on span number, timeslot count to VTY http://cgit.osmocom.org/osmo-bts/commit/?id=494f290f6bca9ed85bf448ed9a12608… commit 494f290f6bca9ed85bf448ed9a126080920f0c5f Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Sep 26 23:06:49 2011 +0200 DAHDI: remove unused variable http://cgit.osmocom.org/osmo-bts/commit/?id=0cf5514616b57fe6d4dea7ab646d6f6… commit 0cf5514616b57fe6d4dea7ab646d6f6cf1488f09 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Sep 26 23:06:18 2011 +0200 DAHDI: Print error message in case config uses non-existing span http://cgit.osmocom.org/osmo-bts/commit/?id=e2bd68575fafe6db73c347140ba1c5f… commit e2bd68575fafe6db73c347140ba1c5f73ba0aaa9 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Sep 26 23:03:12 2011 +0200 DAHDI: make sure the first e1_line N port start with number 0 http://cgit.osmocom.org/osmo-bts/commit/?id=356918fed417a851557b70a262c15b8… commit 356918fed417a851557b70a262c15b8aeef7b784 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Sep 26 22:54:51 2011 +0200 fix parsing error during "e1_line N port M" A misplaced comma in the DEFUN macro argument list resulted in part of the help message becoming part of the command syntax ;) http://cgit.osmocom.org/osmo-bts/commit/?id=70e04c7ccc6e75cd13ea71f2a0a8b3c… commit 70e04c7ccc6e75cd13ea71f2a0a8b3c9e66d4b38 Author: Alexander Huemer <alexander.huemer(a)xx.vu> Date: Wed Sep 7 11:17:14 2011 +0200 request ortp >=0.15.0 build fails with ortp <0.15.0 because of incompatible API. http://cgit.osmocom.org/osmo-bts/commit/?id=c2889512c4fb4585fc5ef2980937dde… commit c2889512c4fb4585fc5ef2980937dde64f687f0a Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Sep 13 23:49:04 2011 +0100 e1_input: add 'port_nr' field and support DAHDI T1 cards the "e1_line <0-255> port <0-255>" vty command allows the user to set which physical port/card number should be represented by the given virtual e1_line. Furthermore, we now actually query the DAHDI hardware to determine the number of ports of a given span (e.g. only 24 in case of T1) instead of blindly assuming there are 31 timeslots on each port. This specifically will fix T1 timeslot (/dev/dahdi/%u) calculation in setups with multiple DAHDI spans/ports and a T1 span != span 1. http://cgit.osmocom.org/osmo-bts/commit/?id=a0d9331cb13be85fb89fdf6973c50f0… commit a0d9331cb13be85fb89fdf6973c50f0514a66bb3 Author: Daniel Willmann <daniel(a)totalueberwachung.de> Date: Thu Sep 15 12:56:58 2011 +0200 ipa: Add a callback to detect if the server_conn was closed http://cgit.osmocom.org/osmo-bts/commit/?id=dc4479f27d14f1ed5e17ccac401f816… commit dc4479f27d14f1ed5e17ccac401f8169813843d7 Author: Daniel Willmann <daniel(a)totalueberwachung.de> Date: Thu Sep 15 12:56:57 2011 +0200 ipa: Fix resource leak if we encounter an error in ipa_server_conn_read In case of a connection reset or protocol error we should destroy the connection as well. http://cgit.osmocom.org/osmo-bts/commit/?id=883cfe5be8d8f8ef6ecc4c67cb25748… commit 883cfe5be8d8f8ef6ecc4c67cb2574865729dac8 Merge: 65a5089 218bb8f Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Sep 9 10:32:06 2011 +0200 Merge remote-tracking branch 'origin/pablo/ipa-updates' http://cgit.osmocom.org/osmo-bts/commit/?id=218bb8f31eb924fca427a3c1f0d1e2d… commit 218bb8f31eb924fca427a3c1f0d1e2dda24dd325 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Sep 9 01:04:46 2011 +0200 ipa: use DEBUG level instead of NOTICE for debugging log messages Use DEBUG instead of NOTICE for several messages that are actually used for debugging purposes. http://cgit.osmocom.org/osmo-bts/commit/?id=32c883a96ff90a5d7f1fd7f8a28cd3f… commit 32c883a96ff90a5d7f1fd7f8a28cd3fa6b138fff Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Sep 9 01:01:36 2011 +0200 ipa: better log error messages for ipa_msg_recv() More descriptive errors help to debug problems. http://cgit.osmocom.org/osmo-bts/commit/?id=2220a0542cf17ffc550247bfc46efe2… commit 2220a0542cf17ffc550247bfc46efe27987df9b4 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Sep 8 18:43:31 2011 +0200 ipa: fix segfault in ipa_client_conn_create if no E1 timeslot is specified Fix segfault if IPA client is not used as signalling link (in that case E1 timeslot is NULL). http://cgit.osmocom.org/osmo-bts/commit/?id=8ad30c96d4690af1e539b3e391d4f8f… commit 8ad30c96d4690af1e539b3e391d4f8ff23f85d80 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Sep 8 13:29:06 2011 +0200 ipa: use default write callback in ipa_client_conn_create if not specified If no write callback is specified, use the default write callback. Thus, we don't need to export ipa_client_write_default_cb. No clients of this function outside libosmo-abis, so no breakages should be expected. http://cgit.osmocom.org/osmo-bts/commit/?id=8fc277b77765d8cdff0c08e5581bc86… commit 8fc277b77765d8cdff0c08e5581bc8621a192d33 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Sep 8 13:22:26 2011 +0200 tests: remove reference to internal headers in ipa_proxy_test This example has to compile out of the tree, including internal.h is not required and using PACKAGE_VERSION here, which is internal to the library, does not seem to me like a good idea. http://cgit.osmocom.org/osmo-bts/commit/?id=f099567ae3328166f45c5a9e60a74b0… commit f099567ae3328166f45c5a9e60a74b04093a0a0d Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Sep 8 12:58:38 2011 +0200 ipa: rename all reference to ipa_*_peer to ipa_*_conn This patch is a cleanup. It renames several function from _peer to _conn which seems to me like a more logical name. There are no clients of this code out of the libosmo-abis tree so far, so this shouldn't break anything. http://cgit.osmocom.org/osmo-bts/commit/?id=00af7723394abf4f03f7d209f5a1282… commit 00af7723394abf4f03f7d209f5a128263fd7a32f Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Sep 8 12:47:06 2011 +0200 ipa: remove bogus driver_name parameter from ipa_client_create This parameter is not required since the line that we pass as parameter already has one driver attached. http://cgit.osmocom.org/osmo-bts/commit/?id=65a50893d5f9577c17dc4485d585c12… commit 65a50893d5f9577c17dc4485d585c12d349c8e30 Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Sep 8 14:42:58 2011 +0200 add osmo_rtp_socket_set_param() and osmo_rtp_socket_log_stats() http://cgit.osmocom.org/osmo-bts/commit/?id=ddfaca45feda2f07481fb4a7d70c303… commit ddfaca45feda2f07481fb4a7d70c303fe7b70e29 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Sep 7 11:52:43 2011 +0200 add GSM_RTP_DURATION http://cgit.osmocom.org/osmo-bts/commit/?id=fcb1fe8c62e05e6023eb90e14353ecd… commit fcb1fe8c62e05e6023eb90e14353ecd1e67777fd Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Sep 7 11:51:52 2011 +0200 libosmo-trau: doxygen documentation http://cgit.osmocom.org/osmo-bts/commit/?id=9b737df611da0c3efa2cecd4201b4cc… commit 9b737df611da0c3efa2cecd4201b4ccaec05f3d5 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Sep 7 00:59:11 2011 +0200 osmo_ortp: introduce POLL mode for rtp sockets This bypasses the osmo_fd integration and will allow a RTP socket to be in pure polling mode, triggered by the consumer of the payload data. http://cgit.osmocom.org/osmo-bts/commit/?id=346374a001ba42e8d3612fefd76a061… commit 346374a001ba42e8d3612fefd76a061f4d494a34 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Sep 3 15:37:47 2011 +0200 add libosmotrau.pc to Makefile.am http://cgit.osmocom.org/osmo-bts/commit/?id=6730187bd8c43b2612d5180a1bff6ae… commit 6730187bd8c43b2612d5180a1bff6ae21fdc3fde Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Sep 3 15:34:21 2011 +0200 update .gitignore http://cgit.osmocom.org/osmo-bts/commit/?id=41d0d84fd61a178f524eca001932807… commit 41d0d84fd61a178f524eca001932807702bcafb7 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Sep 3 15:33:24 2011 +0200 add 'libosmotrau' for TRAU/RTP related code This new library is intended to include everything related to interfacing actual voice channels either via E1 or via RTP. The first module in the library is osmo_rtp, based on the ortp library. http://cgit.osmocom.org/osmo-bts/commit/?id=d6216405b7363c94174a6d301b96f5e… commit d6216405b7363c94174a6d301b96f5ed4a8730ce Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 31 16:47:44 2011 +0200 input: fix multiple BTS attached to single line scenario With multiple BTS attached to a single line, we have to call ->line_update() multiple times. I broke this myself while avoiding that A-bis over IP drivers bind to the socket several times. To fix this situation, Harald prefers that this case is internally handled by the ipaccess and hsl drivers by means of the driver_data field in the e1inp_line structure. Reported-by: Gus Bourg <gus(a)bourg.net> http://cgit.osmocom.org/osmo-bts/commit/?id=f350e253948527290e78748a270dcf1… commit f350e253948527290e78748a270dcf1613b1271c Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 26 07:55:26 2011 +0200 lapd: stop timers in lapd_instance_free() http://cgit.osmocom.org/osmo-bts/commit/?id=cfc9f1f7cc199d2d61e27f0a0b76c4e… commit cfc9f1f7cc199d2d61e27f0a0b76c4e170435ec6 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Aug 24 09:45:36 2011 +0200 DAHDI: Make sure dahdi_e1_setup() can be called multiple times In case we have multiple BTS attached to the same E1 line, the e1inp_driver::line_update() function will be called multiple times, and we need to make sure this is handled gracefully. http://cgit.osmocom.org/osmo-bts/commit/?id=14078eaffe37689061ea92963bb0a1d… commit 14078eaffe37689061ea92963bb0a1da67fb9638 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Aug 24 09:45:11 2011 +0200 LAPD: Add function to release/free a LAPD instance http://cgit.osmocom.org/osmo-bts/commit/?id=3bc78855390d1fde57615572a7ca05c… commit 3bc78855390d1fde57615572a7ca05c7dcb5e226 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Aug 24 08:32:38 2011 +0200 re-introduce optional build of DAHDI input plugin We should only build it when the dahdi/user.h file is actually present. http://cgit.osmocom.org/osmo-bts/commit/?id=ce307b4420e27b4a2c20aae25336ee5… commit ce307b4420e27b4a2c20aae25336ee5568a61c30 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 21 01:18:05 2011 +0200 mISDN: optionally bypass kernel LAPD code and use userspace LAPD The problem with kernel LAPD mainly is that you can only have one signalling timeslot in each E1 line/interface. However, with many BTS attached to the same line, we need multiple signalling slots per line. This allows the user to have a per-line selection between kernel-LAPD (misdn) and userspace-LAPD (misdn_lapd) drivers in the config file. http://cgit.osmocom.org/osmo-bts/commit/?id=6341aa0595879137ad0eec3e906db18… commit 6341aa0595879137ad0eec3e906db18698247234 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 21 00:55:23 2011 +0200 mISDN: use 'struct value_string' instead of local copy Apparently value_string was not part of libosmocore when the code was written originally... http://cgit.osmocom.org/osmo-bts/commit/?id=fd44a5f2fed648b3d182136d15d89bd… commit fd44a5f2fed648b3d182136d15d89bd6a5fdecf3 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 21 00:48:54 2011 +0200 e1_input: move the lapd_instance pointer out of dahdi specifics ... and create a new e1inp_rx_ts_lapd() from dahdi as well http://cgit.osmocom.org/osmo-bts/commit/?id=2f69b890bcc3f810be2e018f1f42224… commit 2f69b890bcc3f810be2e018f1f422246641ed5c0 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 21 11:13:50 2011 +0200 trau_frame: Add doxygen documentation http://cgit.osmocom.org/osmo-bts/commit/?id=e4ec40a365d5791392f8f68eaff1af4… commit e4ec40a365d5791392f8f68eaff1af4aab9db3b4 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Aug 21 11:07:20 2011 +0200 subchan_demux: add doxygen documentation http://cgit.osmocom.org/osmo-bts/commit/?id=aa4942440a47c4bc63fb6df5b696c99… commit aa4942440a47c4bc63fb6df5b696c994abb54a7d Author: Dieter Spaar <spaar(a)mirider.augusta.de> Date: Wed Jul 27 23:52:36 2011 +0200 TRAU: Properly initialize idle frames This is particularly important in case of the Nokia BTS, as they seem to drop the RF/signalling channel if they don't get proper TRAU frames. http://cgit.osmocom.org/osmo-bts/commit/?id=bc25bcaea18728c86c5c4086e3ebd44… commit bc25bcaea18728c86c5c4086e3ebd44faa6c16e9 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 19 22:32:38 2011 +0200 ipa: export ipaccess_rcvmsg_base() and return int http://cgit.osmocom.org/osmo-bts/commit/?id=7b6fc2e4802b84047bc47864c42ba2a… commit 7b6fc2e4802b84047bc47864c42ba2ab1b3c362d Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 19 21:58:48 2011 +0200 ipaccess: make some functions static that shouldn't be exported http://cgit.osmocom.org/osmo-bts/commit/?id=4e862cbf4b3b438a07ea89438f4384b… commit 4e862cbf4b3b438a07ea89438f4384bd10468ea9 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Aug 19 18:43:38 2011 +0200 e1_input: rework configuration of virtual E1 line operations struct e1inp_line_ops { - enum e1inp_line_role role; - char *addr; - void *data; + union { + struct { + enum e1inp_line_role role; /* BSC or BTS mode. */ + const char *addr; /* IP address .*/ + void *dev; /* device parameters. */ + } ipa; + struct { + const char *port; /* e.g. /dev/ttyUSB0 */ + unsigned int delay; + } rs232; + } cfg; Now this structure contains the configuration details for the virtual E1 line, instead of using a pointer. This also get the line_update callback to its original layout: + int (*line_update)(struct e1inp_line *line); http://cgit.osmocom.org/osmo-bts/commit/?id=7e0d006e3c7f163cf1e3621d77a7366… commit 7e0d006e3c7f163cf1e3621d77a7366a5a7e828a Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Aug 19 11:36:15 2011 +0200 input: add rs232 driver for virtual E1 lines This patch adds the rs232 driver which is used by then bs11_config utility available in openBSC. http://cgit.osmocom.org/osmo-bts/commit/?id=94aebf983f376983d3dc1c15319c139… commit 94aebf983f376983d3dc1c15319c13915698e002 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 19 13:34:12 2011 +0200 ipa: remove unused 'proto' variable http://cgit.osmocom.org/osmo-bts/commit/?id=4301c370c00edb400d50e8e4224cb2b… commit 4301c370c00edb400d50e8e4224cb2b19b722400 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 19 13:33:16 2011 +0200 ipa: fix compiler warning about ssize_t / socklen_t http://cgit.osmocom.org/osmo-bts/commit/?id=3e1d84b3e01b8c78b416b620935462e… commit 3e1d84b3e01b8c78b416b620935462ede2c37209 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 19 13:32:18 2011 +0200 hsl: use PRIx64 / inttypes.h for uint64_t format string http://cgit.osmocom.org/osmo-bts/commit/?id=b3f06dac2bc408bb6d170e7c4ad3c94… commit b3f06dac2bc408bb6d170e7c4ad3c94ad28c56cd Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 19 13:28:59 2011 +0200 hsl: remove unsued 'proto' variable http://cgit.osmocom.org/osmo-bts/commit/?id=d4f8f68e16424a6d7bd5cc993bb23ac… commit d4f8f68e16424a6d7bd5cc993bb23ac9800eb4be Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Aug 19 13:28:48 2011 +0200 add string.h include to fix compiler warning http://cgit.osmocom.org/osmo-bts/commit/?id=6f35d108e5b018ac40bad4e24208813… commit 6f35d108e5b018ac40bad4e242088134bab53e81 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 17 23:33:54 2011 +0200 ipaccess: don't close the signalling link if we receive bad OML/RSL message Instead, propagate the error to upper layers. This fixes a segfault in the BSC if bad OML/RSL message is received. http://cgit.osmocom.org/osmo-bts/commit/?id=62684168518356fd78bf07dc719dc19… commit 62684168518356fd78bf07dc719dc19c5b1562b4 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 17 23:25:23 2011 +0200 test: use site_id 1801 in ipa BTS example Thus we can use it with the example file for openBSC under doc/examples/nanobts/openbsc.cfg. http://cgit.osmocom.org/osmo-bts/commit/?id=a54269c81eda71611c05fae036f4eee… commit a54269c81eda71611c05fae036f4eee78fb254f8 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 17 23:23:08 2011 +0200 ipaccess: fix segfault if bsc port already in used This patch fixes a segfault if we try to bind to an already busy port, it can be easily reproduced with: $ test/./e1inp_ipa_bsc_test & <0003> ipaccess.c:830 enabling ipaccess BSC mode <0000> e1inp_ipa_bsc_test.c:241 entering main loop $ test/./e1inp_ipa_bsc_test segfault http://cgit.osmocom.org/osmo-bts/commit/?id=2bbaddfe81195641fa683a9375d4107… commit 2bbaddfe81195641fa683a9375d41072ceb22b52 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Wed Aug 17 10:23:09 2011 +0200 e1_input: fix missing registration of dahdi driver This patch fixes the registration of the dahdi driver. We were using conditional compilation (HAVE_DAHDI_USER_H) which we don't use anymore. http://cgit.osmocom.org/osmo-bts/commit/?id=332a3577dc4165e1b5937103ad8be1e… commit 332a3577dc4165e1b5937103ad8be1ece3b16bba Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Aug 16 17:31:20 2011 +0200 E1 input: rename signal_input by e1inp_signal_input Comestical change required by patches that port openBSC upon libosmo-abis. http://cgit.osmocom.org/osmo-bts/commit/?id=de668910d63be49661bea974c3bee61… commit de668910d63be49661bea974c3bee61128b7f1a0 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Aug 16 17:26:23 2011 +0200 src: replace S_INP_* signals by S_L_INP_* according to naming policy http://cgit.osmocom.org/osmo-bts/commit/?id=95e5decb7991d8934272ae9d941d575… commit 95e5decb7991d8934272ae9d941d575515362291 Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Aug 16 14:41:32 2011 +0200 DAHDI: Actually increment e1_input related rate counters http://cgit.osmocom.org/osmo-bts/commit/?id=dd0c2ef7f345ed0390f42c5bd1c12ad… commit dd0c2ef7f345ed0390f42c5bd1c12ad315b67a19 Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Aug 11 12:54:07 2011 +0200 E1 Input: better names for rate counters http://cgit.osmocom.org/osmo-bts/commit/?id=f2737fcd64b4d5441c8ee3296ac7a70… commit f2737fcd64b4d5441c8ee3296ac7a706d87c587a Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Aug 16 14:30:10 2011 +0200 E1 Input: Add rate counters for events related to E1 lines http://cgit.osmocom.org/osmo-bts/commit/?id=6e37c591f980b41eac2468a1e3e0690… commit 6e37c591f980b41eac2468a1e3e0690e71dbc536 Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Aug 11 12:43:31 2011 +0200 E1 Input: Move 'show e1_*' command to e1_input_vty.c http://cgit.osmocom.org/osmo-bts/commit/?id=601a9c7d3266770c4637e909a8578c3… commit 601a9c7d3266770c4637e909a8578c32c923f21d Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Aug 16 14:17:49 2011 +0200 E1 Input: Add VTY command to specify the name of a Line So far, there was no way to set the line->name field at all. http://cgit.osmocom.org/osmo-bts/commit/?id=31fe5f2ef8391b7f61b7dd1cb2632f2… commit 31fe5f2ef8391b7f61b7dd1cb2632f27c7843534 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Aug 9 23:15:38 2011 +0200 LAPD: Propagate lapd_receive() errors to the E1 driver Scenario: BTS are configured and working, then the BSC stops working for some reason (crash or administrative stop). If the BSC comes back to life, LAPD among other things does not know about the previous existing TEIs. Instead of ignoring these frames, we notify the driver that we are seeing frames with unknown TEIs, so it can try to recover, e.g. by resending the SABM message. http://cgit.osmocom.org/osmo-bts/commit/?id=4ca16c779e9d708f8902b8fa5984eaf… commit 4ca16c779e9d708f8902b8fa5984eaf5fb66b184 Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Aug 16 14:01:49 2011 +0200 LAPD: Use proper log levels and prefix all messages with LAPD http://cgit.osmocom.org/osmo-bts/commit/?id=1ef2457fba62d717ff2aadf8e7171e3… commit 1ef2457fba62d717ff2aadf8e7171e3bdb88948e Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Aug 16 13:51:07 2011 +0200 LAPD: Remove all calls to 'assert' from the code For a system-level daemon, no protocol parser error should ever call assert, which would take down the entire process. http://cgit.osmocom.org/osmo-bts/commit/?id=f3ca61c5cd49603d04eea167cca9fbc… commit f3ca61c5cd49603d04eea167cca9fbcdc82154e4 Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Aug 9 11:21:23 2011 +0200 DAHDI: Fix case where we have multiple E1 ports/cards (spans) DAHDI creates one device node for every E1 timeslot, starting from '1', and keeps incrementing that number even for additional ports/cards. Thus, we have to use the e1inp_line number multiplied by 31 as a base. http://cgit.osmocom.org/osmo-bts/commit/?id=0b29eac3131ef124c7c79d6293254df… commit 0b29eac3131ef124c7c79d6293254df63e5e4103 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Aug 16 12:23:42 2011 +0200 include: add missing ipa.h to Makefile.am so make distcheck works again http://cgit.osmocom.org/osmo-bts/commit/?id=40b0e8cd0ef97575e701732b60d5578… commit 40b0e8cd0ef97575e701732b60d5578b1907753d Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Jul 21 16:57:34 2011 +0200 don't use DLRSL, as it will be removed http://cgit.osmocom.org/osmo-bts/commit/?id=cc2241bf1cbf9bd17600eea195191e4… commit cc2241bf1cbf9bd17600eea195191e4936d8ad9e Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Jul 19 16:06:06 2011 +0200 update to comply with libosmocore namespace fixes This updates the code and brings it in sync to libosmocore git commit 892e621fec571c7cba3573caa0d328ed1b25d8ee http://cgit.osmocom.org/osmo-bts/commit/?id=71d87b2597bdbb6e555af43831b4ef7… commit 71d87b2597bdbb6e555af43831b4ef7788f858e1 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Jul 18 14:49:56 2011 +0200 talloc: revert to use talloc inside libosmocore It's not a good idea to confuse the two changes with each other. Moving the Abis part into a separate library is independent from the question whether we have talloc inside libosmocore or use a stand-alone talloc library. http://cgit.osmocom.org/osmo-bts/commit/?id=f054b51ac960f957f80dafad29a3a82… commit f054b51ac960f957f80dafad29a3a827b8b2a2f9 Author: Pablo Neira Ayuso <pablo(a)netfilter.org> Date: Fri Jul 8 21:46:29 2011 +0200 ipaccess: ipaccess_fd_cb needs to be extern http://cgit.osmocom.org/osmo-bts/commit/?id=495ddb66d842990f6803119eccce021… commit 495ddb66d842990f6803119eccce021b5882be8f Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 21:04:11 2011 +0200 ipaccess: hack to get openBSC's ipaccess-config tool working Export one function that we shouldn't, it's a quick way to fix the ipaccess-config in openBSC. http://cgit.osmocom.org/osmo-bts/commit/?id=34073fbc97de2db185f746b25fa79b2… commit 34073fbc97de2db185f746b25fa79b2013d9aa6a Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 20:36:05 2011 +0200 hsl: close socket if we destroy the signalling link As we do in ipaccess driver, the socket is not useful anymore if the BSC/BTS decides to close the signalling link. http://cgit.osmocom.org/osmo-bts/commit/?id=ad1ca98ff830508a381904e591644c3… commit ad1ca98ff830508a381904e591644c36c98be730 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 20:31:43 2011 +0200 tests: add missing hsl examples Hm, it seems I forgot to git add them :-(. http://cgit.osmocom.org/osmo-bts/commit/?id=2ad22b86990634c8eccb84b001f26c8… commit 2ad22b86990634c8eccb84b001f26c8d82c49da5 Author: Pablo Neira Ayuso <pablo(a)netfilter.org> Date: Fri Jul 8 18:35:45 2011 +0200 tests: convert IPA BTS example to use event-oriented approach Like the HSL BTS example. We use an event file descriptor which is used to call the GSM 12.21 based function for handling. http://cgit.osmocom.org/osmo-bts/commit/?id=88136fc6dd4c432e13193c9e29c4bea… commit 88136fc6dd4c432e13193c9e29c4bea927141812 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 16:21:55 2011 +0200 hsl: BTS support This patch adds the BTS support for the hsl driver. It includes two examples under the tests/ directory. http://cgit.osmocom.org/osmo-bts/commit/?id=49bc872b48c7d57509dbc568f31deae… commit 49bc872b48c7d57509dbc568f31deaede97c853c Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 15:23:36 2011 +0200 tests: close OML and RSL if set for the BSC example We only close the OML and RSL links if they are indeed up. http://cgit.osmocom.org/osmo-bts/commit/?id=db1c8a718b66f1a8f50221675b1fb53… commit db1c8a718b66f1a8f50221675b1fb537cf695021 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 15:12:03 2011 +0200 ipaccess: add bugtrag for the RSL link becomes up case The RSL signal link becomes up for the ipaccess driver is tricky. If the BSC forgets to use the E1 line used by OML for the RSL link, we run into trouble. This patch adds a bugtrap so people don't forget to appropriately handle this case. http://cgit.osmocom.org/osmo-bts/commit/?id=009573aa5b699f9758ed096ab03c5a5… commit 009573aa5b699f9758ed096ab03c5a509355d074 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 14:17:15 2011 +0200 tests: example BTS now sends an OML SW ACT REQ This allows to test that the write path works and it allows you to get an idea on how to implement the BTS side by means of libosmo-abis. http://cgit.osmocom.org/osmo-bts/commit/?id=1ca98b9e9d9861928a735cdbcfdde59… commit 1ca98b9e9d9861928a735cdbcfdde5916befccd1 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Fri Jul 8 15:05:42 2011 +0200 tests: use the virtual E1 line used by OML for RSL link The ipaccess driver is tricky. Since it uses two ports for OML and RSL links, the link for RSL needs to be done in the same line that the OML link. Now the BSC examples uses the virtual E1 line where the OML link is for the RSL one. This patch also verifies that the OML link is up before the someone tries to get the RSL link up. http://cgit.osmocom.org/osmo-bts/commit/?id=cdd7c783631a71d23912ed1e59b209a… commit cdd7c783631a71d23912ed1e59b209a2b6e7872a Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jul 7 20:21:27 2011 +0200 hsl: remove unused hsl_setup function This function lives in openBSC not here. http://cgit.osmocom.org/osmo-bts/commit/?id=3832c4f908e6d9d821b18bbccab017b… commit 3832c4f908e6d9d821b18bbccab017b2d3d6c79c Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jul 7 17:47:26 2011 +0200 e1_input: add new refcounting scheme to avoid leaking E1 lines This patch 's/e1inp_line_get/e1inp_line_find/g' since we need this function name for the new refcounting scheme. Basically, I have added a new function to clone lines that is used by the ipaccess driver: struct e1inp_line *e1inp_line_clone(void *ctx, struct e1inp_line *line); And two functions to bump and decrement the refcount: void e1inp_line_get(struct e1inp_line *line); void e1inp_line_put(struct e1inp_line *line); This is useful to avoid leaking virtual E1 lines in the ipaccess case, since we have two sockets for OML and RSL respectively, we have to release the line *once* both sockets have been closed. Without this patch, there are cases in which we don't know if it's time to release the virtual E1 line. This patch also includes a fix to avoid crashing if we open a connection with OML/RSL port without sending any ID_RESP message (in that case, we have no chance to set the signal link). I tested these situations with netcat. http://cgit.osmocom.org/osmo-bts/commit/?id=466c5467e2e95c04260cb6b933181a3… commit 466c5467e2e95c04260cb6b933181a38d1d97bd5 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jul 7 19:17:20 2011 +0200 ipaccess: close connection if we receive bad messages from BTS If we receive bad messages from the BTS, we close the connection. I think this is a more robust behaviour. http://cgit.osmocom.org/osmo-bts/commit/?id=eb43413013d75c21db121e5ad40c587… commit eb43413013d75c21db121e5ad40c587ca6c1f453 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jul 7 19:19:46 2011 +0200 ipaccess: skip further processing for ping, pong and id_req messages http://cgit.osmocom.org/osmo-bts/commit/?id=d2fba90c1320a178bed0f4da752d4db… commit d2fba90c1320a178bed0f4da752d4db95a522b89 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jul 7 17:42:07 2011 +0200 ipaccess: release virtual E1 line for closed connection We fix a leak in the ipaccess_drop(...) path where we were missing the release of the cloned E1 line for this OML/RSL links http://cgit.osmocom.org/osmo-bts/commit/?id=9621b41cf6ee710885215d8e317e377… commit 9621b41cf6ee710885215d8e317e37705a5d6b9f Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jul 7 16:19:21 2011 +0200 ipaccess: don't forget to release temporary RSL socket We have to release the temporary RSL in case that the socket is closed and we have no chance to attach it to the OML link. http://cgit.osmocom.org/osmo-bts/commit/?id=b0908b8e7910243007fee5dfc0b877d… commit b0908b8e7910243007fee5dfc0b877d6aa2cc208 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 20:23:17 2011 +0200 include: remove IPA_NODE and E1INP_NODE definition from internal.h They should be defined in osmocom/vty/command.h in libosmocore. http://cgit.osmocom.org/osmo-bts/commit/?id=262aee80aca96e3f86d4e831485c9e8… commit 262aee80aca96e3f86d4e831485c9e85948b0ede Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 19:17:08 2011 +0200 src: add e1_input_vty.c to libosmo-abis This file provides the VTY interface for E1 lines, I have moved it to libosmo-abis since it belongs here. http://cgit.osmocom.org/osmo-bts/commit/?id=904d8f2d38b5e01c460098b97c812ca… commit 904d8f2d38b5e01c460098b97c812ca3c61b18d9 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 18:32:12 2011 +0200 tests: support OML software activate request ack message This patch steals some code from openBSC to implement the OML software activate request ack message which is delivered to the BTS. This allows to test the ->sign_link(...) path. http://cgit.osmocom.org/osmo-bts/commit/?id=b9ed7e3145f01c7867e8ad1a9fb3de4… commit b9ed7e3145f01c7867e8ad1a9fb3de44e24c953f Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 18:31:59 2011 +0200 ipaccess: fix write path for OML/RSL message from BSC -> BTS This patch fixes the write path for OML/RSL messages. I broke this while trying to support the delivery of IPA CCM messages using this path, which is not useful since they are directly delivered by means of the file descriptor. This patch fixes the corruption of messages leaving the BSC. http://cgit.osmocom.org/osmo-bts/commit/?id=a20762ab7241cdafb0f568f8832d6ef… commit a20762ab7241cdafb0f568f8832d6ef34988ec1c Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 19:01:58 2011 +0200 src: use signal infrastructure that will be available in libosmocore This is still not in mainline yet, it's in a separate patch that I expect to send to Harald soon. http://cgit.osmocom.org/osmo-bts/commit/?id=fe8ab0af7a3a0a8dce32907efda7a86… commit fe8ab0af7a3a0a8dce32907efda7a86ea39bc884 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 18:48:45 2011 +0200 logging: use new harald's logging infrastructure in libosmocore I can send patches to improve it later, better not to waste much time at it by now so port libosmo-abis upon it. http://cgit.osmocom.org/osmo-bts/commit/?id=62d345a6ef199d5c3011acd3b0904d4… commit 62d345a6ef199d5c3011acd3b0904d4d316215a0 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 16:37:37 2011 +0200 ipaccess: fix ID_RESP parsing in BSC mode http://cgit.osmocom.org/osmo-bts/commit/?id=3e86c6be0ef653f738ceb0d8c384b44… commit 3e86c6be0ef653f738ceb0d8c384b447a13ae48e Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 16:03:37 2011 +0200 ipaccess: remove any reference to deprecated msg->trx We plan to use msg->dst instead. http://cgit.osmocom.org/osmo-bts/commit/?id=dbd82fb5b1e0fc180a680094b80d679… commit dbd82fb5b1e0fc180a680094b80d6799bd28725a Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 15:29:23 2011 +0200 e1_input: change prototype of ->sign_link(...) This patch removes the struct e1inp_sign_link parameter since this is already available in the msgb->dst field of the message. http://cgit.osmocom.org/osmo-bts/commit/?id=add3ec84779ca1f9c7dd64aa8bb8641… commit add3ec84779ca1f9c7dd64aa8bb8641e8f15637a Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 14:45:46 2011 +0200 e1_input: change prototype of close hook in e1inp_driver This patch changes `close' so we can make the e1inp_event inside this hook. http://cgit.osmocom.org/osmo-bts/commit/?id=355ce696611b6484f6368035bf84c10… commit 355ce696611b6484f6368035bf84c1051acead75 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jul 5 14:53:37 2011 +0200 include: export lapd.h since openBSC needs it More specifically, the unfinished ericsson rbs2000 BTS. http://cgit.osmocom.org/osmo-bts/commit/?id=4647cadadf980c45a2645f3b2c56df3… commit 4647cadadf980c45a2645f3b2c56df33e580bf20 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 17:57:58 2011 +0200 include: remove unused ipaccess_read_msg definition from internal.h This was used by hsl driver but not anymore. http://cgit.osmocom.org/osmo-bts/commit/?id=2b3520139a813cc8cb9c290ff8bd8a1… commit 2b3520139a813cc8cb9c290ff8bd8a1aa3772bc8 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 17:45:42 2011 +0200 tests: use logging infrastructure to display messages instead of using printf http://cgit.osmocom.org/osmo-bts/commit/?id=cda8c43537650e33128aeb47ba1871b… commit cda8c43537650e33128aeb47ba1871b0a6310a55 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 17:42:31 2011 +0200 add AUTHORS and COPYING files The AUTHORS file contain the people that appear in the copyright headers plus myself. The COPYING file contains the AGPLv3 which is the selected license according to discussion with Harald. http://cgit.osmocom.org/osmo-bts/commit/?id=0b9ed9a38936768f4575309eee9ab1d… commit 0b9ed9a38936768f4575309eee9ab1da4c2a2ef7 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 17:25:19 2011 +0200 dahdi: fix driver compilation Now dahdi driver compiles file. We force the compilation of this driver, I prefer to avoid condition compilation options that tend add problems IMO. http://cgit.osmocom.org/osmo-bts/commit/?id=cd8d2e5f30afb3f7643f7983b9fb0a6… commit cd8d2e5f30afb3f7643f7983b9fb0a67da8f1acb Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 17:05:21 2011 +0200 input: close socket if no signal link was created If the ->sign_link_up callback does not returns (or if it's NULL) a valid new signal link, we inmediately close the socket. If no signal link is set, there is nothing we can do with this socket, so keeping it open is useless otherwise. http://cgit.osmocom.org/osmo-bts/commit/?id=dfafe68a05069f0e0a21dfb5a200c38… commit dfafe68a05069f0e0a21dfb5a200c38462031963 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jul 2 14:32:32 2011 +0200 ipaccess: put the ID_GET logic for the BTS mode into the driver This patch moves the ID_GET logic from the example file to the ipaccess driver in BTS mode. http://cgit.osmocom.org/osmo-bts/commit/?id=c9c4fd39055ab02c0af59d5519e62ed… commit c9c4fd39055ab02c0af59d5519e62edc456e3d0b Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jun 30 12:19:42 2011 +0200 major updates in e1_input callback ops and IPA infrastructures This patch is a major update of the callback infrastructure, now the e1input_ops looks like the following: struct e1inp_sign_link * (*sign_link_up)(void *unit_info, struct e1inp_line *line, enum e1inp_sign_type type); void (*sign_link_down)(struct e1inp_line *line); int (*sign_link)(struct msgb *msg, struct e1inp_sign_link *link); The sign_link_up and sign_link_down will be used by the A-bis over IP input drivers. The sign_link_up callback is used if we receive a ID_RESP message, in that case, we have to set up the sign link for the corresponding new OML/RSL signal link. The pointer to unit_info provides a data structure that contains the BTS device details if we run as BSC, and the requested device information from the BSC if we run as BTS. The sign_link_up callback must return the new sign_link created. The sign_link_down callback is invoked if the line does down, which means that the counterpart has closed the socket. The sign_link callback is used to handle all RSL/OML messages. I have also added the following callback to the e1inp_driver: + void (*close)(struct e1inp_ts *ts); Which is invoked if you call e1inp_sign_link_destroy(). This callback is used to close the socket that is linked to that timeslot. This is useful for A-bis over IP drivers since sockets are closed if the OML/RSL signalling link is destroyed. As you can notice, I have also added all the ID_RESP parsing into libosmo-abis for both ipaccess and hsl drivers. This patch also contains a rework of the ipa_client_link whose integration with the e1_input infrastructure was broken (the transmission path was broken). This patch also contains more develop examples that act as BSC and BTS for the ipaccess driver. Sorry, I know it would be better to split all these changes into logical pieces but many of them are tightly related. This is under heavy development stage, it's anyway hard to track changes until this becomes more stable. http://cgit.osmocom.org/osmo-bts/commit/?id=59301856f6cf7e9c36b1494aa98b6b9… commit 59301856f6cf7e9c36b1494aa98b6b984b4b52d1 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Mon Jun 27 15:44:23 2011 +0200 ipaccess: use E1INP_SIGN_OML instead of hardcoded 1 This patch is a minor cleanup. http://cgit.osmocom.org/osmo-bts/commit/?id=8e479aece2df0720a6d2bbda0fe8972… commit 8e479aece2df0720a6d2bbda0fe8972a22390b2a Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Mon Jun 27 15:19:11 2011 +0200 ipaccess: fix RSL link establishment This patch fixes the RSL link establishment which made openBSC port over libosmo-abis crash. http://cgit.osmocom.org/osmo-bts/commit/?id=93c620107e2edca4ac3306a995d512c… commit 93c620107e2edca4ac3306a995d512c7924453a2 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sun Jun 26 19:12:47 2011 +0200 ipaccess: fix write path for OML socket We have to use e1i_ts->driver.ipaccess.fd file descriptor to fix the write path. Otherwise, openBSC never delivers replies to OML messages. http://cgit.osmocom.org/osmo-bts/commit/?id=ff66363716e5776fa7b9e8a4f3d1a1e… commit ff66363716e5776fa7b9e8a4f3d1a1e6d171ee23 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sun Jun 26 19:10:56 2011 +0200 ipaccess: add msg->trx to reduce the size of the openbsc-port patch This is a temporary change to keep the openbsc port over libosmo-abis smaller. We'll remove it at some point once we fully transition to the new msg->dst routing attribute. http://cgit.osmocom.org/osmo-bts/commit/?id=96e7263c85f526f790b4688dfad9024… commit 96e7263c85f526f790b4688dfad90247de5a8fac Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sun Jun 26 19:08:05 2011 +0200 e1_input: add abis_sendmsg(...) This patch adds generic abis_sendmsg to send NM messages (both OML and RSL). abis_rsl_sendmsg(...) is basically the same, we'll remove it from libosmo-abis once we can propagate changes to openbsc. http://cgit.osmocom.org/osmo-bts/commit/?id=79378d6ea0f5a28e291ab0f9a1bc16e… commit 79378d6ea0f5a28e291ab0f9a1bc16e2392f5738 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jun 25 18:52:22 2011 +0200 include: remove unused prototype _abis_nm_sendmsg(...) definition This function does not live in this tree. http://cgit.osmocom.org/osmo-bts/commit/?id=70ef10c72450ec0da9cc8616b7c5a90… commit 70ef10c72450ec0da9cc8616b7c5a906ecdd8855 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jun 25 18:50:54 2011 +0200 e1_input: remove unused function ipaccess_connect() This function should live in openbsc instead. http://cgit.osmocom.org/osmo-bts/commit/?id=70d25730c3daa4121270b5235c1cd33… commit 70d25730c3daa4121270b5235c1cd330d213121c Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jun 25 18:49:52 2011 +0200 include: fix include installation path and missing logging.h file The installation path was wrong. The logging.h file was not being installed. http://cgit.osmocom.org/osmo-bts/commit/?id=f163d23bf66b76037645f5a1bdc3333… commit f163d23bf66b76037645f5a1bdc3333cc88f1ad1 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sat Jun 25 18:42:55 2011 +0200 e1_input: minor API changes to adapt it to openbsc While working on the openbsc over libosmo-abis port, I noticed several API changes that we need to perform for better adaptation. http://cgit.osmocom.org/osmo-bts/commit/?id=130c4fbe2e815d94bcf4b6d13849beb… commit 130c4fbe2e815d94bcf4b6d13849bebbfbf0198d Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jun 23 21:15:53 2011 +0200 ipa-proxy: add A-bis over IP generic proxy commands for VTY This patch adds VTY commands to route IPA flows. The following example allows to add a new route: $ tests/./ipa_proxy_test & <0000> ipa_proxy_test.c:74 entering main loop $ telnet localhost 4260 ipa-proxy-test> enable ipa-proxy-test# ipa instance input-oml bind 127.0.0.1 tcp port 8888 ipa-proxy-test# ipa instance output-oml connect 127.0.0.1 tcp port 3002 ipa-proxy-test# ipa route instance input-oml streamid 0xfe instance output-oml streamid 0xfe ipa-proxy-test# ipa instance input-rsl bind 127.0.0.1 tcp port 8889 ipa-proxy-test# ipa instance output-rsl connect 127.0.0.1 tcp port 3003 ipa-proxy-test# ipa route instance input-rsl streamid 0xfe instance output-rsl streamid 0xfe I'm using this to initially test this code [*]. [*] note that this requires a minor hackish patch for the src/input/ipaccess.c driver which changes the default OML and RSL ports to listen in 8888 and 8889 instead of the default ports, thus, I can initially test everything from the localhost. http://cgit.osmocom.org/osmo-bts/commit/?id=af3fed9213666c8fa68ba3a153aa175… commit af3fed9213666c8fa68ba3a153aa17577df97649 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jun 23 20:42:19 2011 +0200 ipa: add ipa_*_send() to transmit messages This patch adds ipa_*_send() functions to transmit messages using the new A-bis over IP infrastructure. This patch completes the transmission path support for the A-bis over IP infrastructure. http://cgit.osmocom.org/osmo-bts/commit/?id=6af9b61a48f39de7181c0c902e6351f… commit 6af9b61a48f39de7181c0c902e6351fc4929dab2 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jun 23 14:07:47 2011 +0200 ipa: add ipa_server_peer infrastructure This patch adds the ipa_server_peer abstraction which provide helpers for the accept path of ipa_server_link. http://cgit.osmocom.org/osmo-bts/commit/?id=e009f4a009e028fbd041e8731e75c4c… commit e009f4a009e028fbd041e8731e75c4c39d52cdd1 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jun 23 13:36:34 2011 +0200 ipa: extend ipa_*link_create() to take one generic data pointer With this patch we can attach generic data to some IPA link. This will be useful for the IPA proxy support. http://cgit.osmocom.org/osmo-bts/commit/?id=af8ed983ffa1f750e3972e0fb850c16… commit af8ed983ffa1f750e3972e0fb850c16249943543 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 20:35:27 2011 +0200 ipaccess: remove dead code from ipaccess adriver This patch removes some dead code in the ipaccess driver http://cgit.osmocom.org/osmo-bts/commit/?id=986191fadf6a79bdaf99de240baef21… commit 986191fadf6a79bdaf99de240baef21d8675ab0b Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 19:56:26 2011 +0200 ipa: add ipa_server_link abstraction This patch adds the ipa_server_link which allows to create IPA servers. I have also changed the ipaccess driver to use it. Still missing the port of HSL driver. http://cgit.osmocom.org/osmo-bts/commit/?id=c07a8e7cf73e6218f12a0612fd05e52… commit c07a8e7cf73e6218f12a0612fd05e529e6a4f9b4 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 19:50:04 2011 +0200 ipa: rename `struct ipa_link' by `struct ipa_client_link' And IPA_LINK_STATE_* by IPA_CLIENT_LINK_STATE_* to prepare the addition of the ipa_server_link abstraction. http://cgit.osmocom.org/osmo-bts/commit/?id=591ddadbe8bc056dd0f619f10fd2330… commit 591ddadbe8bc056dd0f619f10fd23306cecad4a8 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 18:16:42 2011 +0200 ipaccess: initial works to get BTS mode working This patch adds the initial support to get BTS mode working with the ipaccess driver. Now, the driver handles IPA ping, pong and id_ack messages internally in BTS modes, and it passes the signalling messages to the client application by invoking the callback line operations. Moreover, with this patch, each IPA link object always has one E1 line object associated. Still HSL BTS-mode remains unimplemented. http://cgit.osmocom.org/osmo-bts/commit/?id=29465d35fc16f72d78f854cf49b1314… commit 29465d35fc16f72d78f854cf49b131429591e1f4 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 14:21:33 2011 +0200 ipaccess: create RSL socket in BTS mode With this patch, we create the RSL socket in BTS mode. This patch also fixes a crash if the RSL socket goes down before we have set the RSL line via OML with the existing code. http://cgit.osmocom.org/osmo-bts/commit/?id=7a249408056c5375030cd0cf171caa1… commit 7a249408056c5375030cd0cf171caa17a6715cb8 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 14:15:46 2011 +0200 input: use generic ipa_msg_recv() instead of ipaccess_read_msg() We use the new generic function to receive messages, instead of ipaccess_read_msg. It's a mere renaming, but it's the first step before the rework that will happen soon to avoid calling read() twice. http://cgit.osmocom.org/osmo-bts/commit/?id=9b3a33cba9c7a72d53b5c1634666758… commit 9b3a33cba9c7a72d53b5c1634666758a485f060c Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 13:52:41 2011 +0200 hsl: add support for BTS-mode This patch adds support for BTS-mode for the hsl input driver. http://cgit.osmocom.org/osmo-bts/commit/?id=c00ee7399d06ecaee66795e56e546ce… commit c00ee7399d06ecaee66795e56e546cef89768cb2 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 21 12:22:49 2011 +0200 e1input: add address as parameter to e1inp_line_update(...) This patch adds a new parameter to e1inp_line_update that allows to specific the address for A-bis over IP BSC/BTS. http://cgit.osmocom.org/osmo-bts/commit/?id=96e81280617112d5f683b5c78c010fd… commit 96e81280617112d5f683b5c78c010fd4843e2af0 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jun 9 15:06:11 2011 +0200 input: ipaccess: add preliminary BTS-side for A-bis over IP This patch adds the BTS-side for the ip.access driver for A-bis over IP communications. This patch adds one example under test/ so you can test the existing BSC and BTS sides over ip.access. Still incomplete, it requires to allow to register some callback in the BTS side to perform some action once we receive some message. This will come in next updates. http://cgit.osmocom.org/osmo-bts/commit/?id=e19c70a9ed605d13abb25bc4c875d47… commit e19c70a9ed605d13abb25bc4c875d4741e19530e Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sun Jun 12 15:15:30 2011 +0200 src: add support for logging infrastructure in libosmo-abis This patch uses the new libosmocore logging infrastructure that allows to invoke log_init(&my_log_info) multiple times so we can register categories from libraries and applications. http://cgit.osmocom.org/osmo-bts/commit/?id=0b099b27df4325f48749e2cec10dc6f… commit 0b099b27df4325f48749e2cec10dc6f52a21c513 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Thu Jun 9 13:14:11 2011 +0200 include: remove internal definition that are now in libosmocore Still in one separate patch for libosmocore, but they may become part of mainline soon. http://cgit.osmocom.org/osmo-bts/commit/?id=35809d6f5eb0114605ba6448ddc5fa9… commit 35809d6f5eb0114605ba6448ddc5fa905ac29a8d Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 7 18:12:01 2011 +0200 include: document functions required by hsl driver This patch is a minor cleanup for internal.h, it confirms that a couple of functions in the ipaccess driver are used by hsl, but not exported further. http://cgit.osmocom.org/osmo-bts/commit/?id=e47a9789423a07702093b8d6df19cf4… commit e47a9789423a07702093b8d6df19cf4c1f676e4d Author: Pablo Neira Ayuso <pablo(a)netfilter.org> Date: Tue Jun 7 18:03:48 2011 +0200 hsl: use include/abis/ipaccess.h instead of deprecated include/gsm/protocol/ipaccess.h http://cgit.osmocom.org/osmo-bts/commit/?id=392d1dcb34cf73044bf58501c16a52a… commit 392d1dcb34cf73044bf58501c16a52a8f593c4e8 Author: Pablo Neira Ayuso <pablo(a)netfilter.org> Date: Tue Jun 7 17:56:19 2011 +0200 include: remove superfluous definition from internal.h Get rid of definitions that we no longer need. And move trau_frame_idle() definition where it really belongs to. Signed-off-by: Pablo Neira Ayuso <pablo(a)netfilter.org> http://cgit.osmocom.org/osmo-bts/commit/?id=5a4b7c54c699889b3255e578ef75c09… commit 5a4b7c54c699889b3255e578ef75c0989622b541 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 7 14:07:48 2011 +0200 e1input: rework generic (virtual and real) E1 line operations struct e1inp_line_ops { int (*sign_link_up)(struct msgb *msg, struct e1inp_line *line); int (*sign_link)(struct msgb *msg, struct e1inp_sign_link *link); int (*error)(struct msgb *msg, int error); }; The description of the operations is the following: * sign_link_up is invoked if the signalling link becomes up. In A-bis over IP, we have to wait until the other peer identifies itself as a BTS/BSC device, then this function is invoked. This function is not used by ISDN drivers, the signalling link can be set up just after the line is created. * sign_link is called if we receive OML/RSL message. This function is used both by ISDN and A-bis over IP drivers. * error is called if we receive a malformed message. It is used both by ISDN and A-bis over IP drivers. http://cgit.osmocom.org/osmo-bts/commit/?id=f0cb2b4a1a529c05c5cc63a620b0c2a… commit f0cb2b4a1a529c05c5cc63a620b0c2a34383f4c8 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 7 17:27:46 2011 +0200 e1input: log_set_context(...) should be called from the application Remove this line, it should be called from the application. http://cgit.osmocom.org/osmo-bts/commit/?id=211d2ca7a1c5ff4b9626215dd5ce611… commit 211d2ca7a1c5ff4b9626215dd5ce611efc01ccbc Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 7 17:15:10 2011 +0200 e1input: fix TRAU frame handling With this patch, we pass TRAU frames to the callback that e1inp_ts_config_trau(...) takes as parameter. Instead of passing it to the line->rx(...) callback. The function e1inp_ts_config_trau(...) should only be used by ISDN drivers. http://cgit.osmocom.org/osmo-bts/commit/?id=54b4979de6ee0340694dc7cef85ddce… commit 54b4979de6ee0340694dc7cef85ddce9cf2e6aa6 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 7 12:15:26 2011 +0200 src: add libosmo_abis_init(void *ctx) to set the talloc context This function is called during initialization, so we can set what's the talloc context for the application and the library. http://cgit.osmocom.org/osmo-bts/commit/?id=177094b4c988f126ead93a5d3f25b4b… commit 177094b4c988f126ead93a5d3f25b4bedefa2d97 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 7 12:21:51 2011 +0200 src: use include/osmocom/abis instead of include/osmocom/gsm/abis Harald prefers short paths. This patch also remove commented includes in several files. http://cgit.osmocom.org/osmo-bts/commit/?id=f67471fb7f691cfe19622693c2bd59a… commit f67471fb7f691cfe19622693c2bd59a6b9837cd4 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Tue Jun 7 11:25:49 2011 +0200 src: use new socket API in libosmocore get rid of internal copy of openbsc/libcommon/socket.c, we now use the new socket API available in libosmocore. http://cgit.osmocom.org/osmo-bts/commit/?id=7b2d18bc4fae9f91c2e046f3641a4cb… commit 7b2d18bc4fae9f91c2e046f3641a4cbcb6da2801 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sun Jun 5 18:38:43 2011 +0200 missing logging header in trau_frame.c http://cgit.osmocom.org/osmo-bts/commit/?id=b9242cf3accbe108a68a86659d566ef… commit b9242cf3accbe108a68a86659d566ef1da5f2e24 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sun Jun 5 18:36:27 2011 +0200 add missing m4 directory http://cgit.osmocom.org/osmo-bts/commit/?id=0ba77d53a97906ee70a262083fb30f6… commit 0ba77d53a97906ee70a262083fb30f67fe8801c5 Author: Pablo Neira Ayuso <pablo(a)gnumonks.org> Date: Sun Jun 5 18:32:44 2011 +0200 initial commit of libosmo-abis still many things to get fixed ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

osmo-bts.git branch fairwaves/static-fix created. 0.4.0-140-gc7b3c7e
by gitosis＠osmocom.org 25 Apr '16

25 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, fairwaves/static-fix has been created at c7b3c7e86be4e819a9d29e1ce64edcbd4789f1a7 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=c7b3c7e86be4e819a9d29e1ce64edcb… commit c7b3c7e86be4e819a9d29e1ce64edcbd4789f1a7 Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> Date: Mon Apr 25 12:29:32 2016 +0200 configure: Add LT_INIT macro to enable libtool configuration. Now we can use --enable-shared, --disable-shared, --enable-static, --disable-static, --with-pic, and --without-pic configure flags to choose whether we want dynamic or static library linking, etc. See the link for details: https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

osmo-bts.git branch fairwaves/rtp-stats created. 0.4.0-140-gba216b8
by gitosis＠osmocom.org 25 Apr '16

25 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, fairwaves/rtp-stats has been created at ba216b82f604bf0f8bfdc6f6f2e5427b062416bd (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=ba216b82f604bf0f8bfdc6f6f2e5427… commit ba216b82f604bf0f8bfdc6f6f2e5427b062416bd Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com> Date: Mon Apr 25 20:04:14 2016 +0200 rsl: Output RTP stats before closing the socket. It's useful to know RTP statistics (number of packets lost, jitter, etc) when looking at voice call quality issues. Right now this information is not avialable anywhere and this looks like the best place to start. ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

libosmocore.git branch laforge/pending updated. 0.9.0-145-ge8de461
by gitosis＠osmocom.org 25 Apr '16

25 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/pending has been updated discards 3525ff85d6e42bd854e2dadb07e7e58b1d5c5395 (commit) discards 527ba1cf3201b4d801781946da6ba7b47f1f8e43 (commit) discards 31d53d6fb9d25167e645efd9b62982d2e2d906a4 (commit) discards fd98dac9fae6d19460a7658149b8fa6782dc5918 (commit) via e8de4610400e299dedd4d143bb4fa9dc12d4e9b8 (commit) via 5d57360f7a3973dcc49c5d8f7e8f3086ee910441 (commit) via 01b4115a3dcc806297e6593ac0a01962209e32e2 (commit) via 85a1009e9f3c2bff8e3625129357e85a5c481cad (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (3525ff85d6e42bd854e2dadb07e7e58b1d5c5395) \ N -- N -- N (e8de4610400e299dedd4d143bb4fa9dc12d4e9b8) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=e8de4610400e299dedd4d143bb4f… commit e8de4610400e299dedd4d143bb4fa9dc12d4e9b8 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Apr 25 19:09:24 2016 +0200 add doc/*.tag to .gitignore http://cgit.osmocom.org/libosmocore/commit/?id=5d57360f7a3973dcc49c5d8f7e8f… commit 5d57360f7a3973dcc49c5d8f7e8f3086ee910441 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Apr 25 18:46:22 2016 +0200 import gprs_gsup_message.[ch] from openbsc as gsup.[ch] Move those routines from OpenBSC to libosmogsm, so they can be re-used from other programs. I think it was a mistake to add them only inside the openbsc repository in the first place. We need to pay more attention to this in the future. http://cgit.osmocom.org/libosmocore/commit/?id=01b4115a3dcc806297e6593ac0a0… commit 01b4115a3dcc806297e6593ac0a01962209e32e2 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Apr 25 18:47:53 2016 +0200 Import osmo_{encode,decode}_big_endian() from openbsc http://cgit.osmocom.org/libosmocore/commit/?id=85a1009e9f3c2bff8e3625129357… commit 85a1009e9f3c2bff8e3625129357e85a5c481cad Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Apr 25 15:19:35 2016 +0200 tlv: Import osmo_shift_* and osmo_match_shift_* from openbsc These routines have nothing to do with specifically the BSC, so import them to the TLV parser we keep in libosmogsm. ----------------------------------------------------------------------- Summary of changes: tests/Makefile.am | 10 +- tests/gsup/gsup_test.c | 264 ++++++++++++++++++++++++++++++++++++++++++++++++ tests/gsup/gsup_test.ok | 14 +++ tests/testsuite.at | 12 +++ tests/tlv/tlv_test.c | 250 +++++++++++++++++++++++++++++++++++++++++++++ tests/tlv/tlv_test.ok | 2 + 6 files changed, 550 insertions(+), 2 deletions(-) create mode 100644 tests/gsup/gsup_test.c create mode 100644 tests/gsup/gsup_test.ok create mode 100644 tests/tlv/tlv_test.c create mode 100644 tests/tlv/tlv_test.ok hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch laforge/pending updated. 0.15.0-249-gf6552c5
by gitosis＠osmocom.org 25 Apr '16

25 Apr '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, laforge/pending has been updated discards fd10f4bc364f95bed05015e040efb2026b89b6f4 (commit) discards ac3d74ad124f700a3012de025e96d12bd73b5b16 (commit) via f6552c5b7fea97287645c265f9692d0d2cbae324 (commit) via e263955bb145a391787eeda78e59e9118c96c9d4 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (fd10f4bc364f95bed05015e040efb2026b89b6f4) \ N -- N -- N (f6552c5b7fea97287645c265f9692d0d2cbae324) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=f6552c5b7fea97287645c265f9692d0d… commit f6552c5b7fea97287645c265f9692d0d2cbae324 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Apr 25 19:07:34 2016 +0200 Move osmo_gsup_messages.[ch] to libosmocore This requires the corresponding commit in libosmocore. http://cgit.osmocom.org/openbsc/commit/?id=e263955bb145a391787eeda78e59e911… commit e263955bb145a391787eeda78e59e9118c96c9d4 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Apr 25 19:01:26 2016 +0200 move utils.h functions to libosmocore This needs the corresponding commit in libosmocore which imports the related functions ----------------------------------------------------------------------- Summary of changes: openbsc/tests/gprs/Makefile.am | 3 +- openbsc/tests/gprs/gprs_test.c | 477 ---------------------------------------- openbsc/tests/gprs/gprs_test.ok | 14 -- 3 files changed, 1 insertion(+), 493 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0