This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/ms-struct has been updated
discards 63302f67182e7a6b7c1b2e3bd3f8711a5be22f6a (commit)
via 67728acc7a90dbf076eb179d6e3e119a4197896a (commit)
via 967e4dd2c357b3b3ff716fa6c77e7b7350f81711 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (63302f67182e7a6b7c1b2e3bd3f8711a5be22f6a)
\
N -- N -- N (67728acc7a90dbf076eb179d6e3e119a4197896a)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=67728acc7a90dbf076eb179d6e3e119…
commit 67728acc7a90dbf076eb179d6e3e119a4197896a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 15 14:32:33 2015 +0200
llc: Move storage of timestamps into gprs_llc_queue
Currently the receive and expiry timestamps are prepended to the LLC
msgb before it is passed to gprs_llc_queue::enqueue(). Since this meta
information should not be counted as LLC octets, the gprs_llc_queue
needs to known about this (unless the correction was done in the LLC
layer).
This commit moves the meta information storage code into
gprs_llc_queue. The meta data is now stored in the control block
(cb) area of the msgb.
Note that the info pointer that is returned from the dequeue method
is only valid if that method returns a (non-NULL) msgb. It must not
be used after that msgb has been modified or freed.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=967e4dd2c357b3b3ff716fa6c77e7b7…
commit 967e4dd2c357b3b3ff716fa6c77e7b7350f81711
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 16 10:18:42 2015 +0200
llc: Make timeval arguments const
Some struct timeval pointer arguments do not have the const qualifier,
albeit the methods do not write to the structures. The next commit
will change related pointers to const, so this commit provides the
required constness.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/llc.cpp | 7 +++++--
src/tbf_dl.cpp | 7 +------
tests/llc/LlcTest.cpp | 58 ++++++++++++++++++++++++++++++++++++++++++++-------
tests/llc/LlcTest.err | 8 +++----
tests/llc/LlcTest.ok | 2 ++
5 files changed, 62 insertions(+), 20 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/ms-struct has been updated
via 63302f67182e7a6b7c1b2e3bd3f8711a5be22f6a (commit)
from 0a9639012204a79bf5ae4c103a6de083e7e488d6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=63302f67182e7a6b7c1b2e3bd3f8711…
commit 63302f67182e7a6b7c1b2e3bd3f8711a5be22f6a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 15 14:32:33 2015 +0200
llc: Move storage of timestamps into gprs_llc_queue (TODO)
Currently the receive and expiry timestamps are prepended to the LLC
msgb before it is passed to gprs_llc_queue::enqueue(). Since this meta
information should not be counted as LLC octets, the gprs_llc_queue
needs to known about this (unless the correction was done in the LLC
layer).
This commit moves the meta information storage into gprs_llc_queue.
It is now stored to (and removed from) the end of the msgb data to
avoid problems with unsufficient head room.
Note that the info pointer that is returned from the dequeue method
is only valid if that method returns a (non-NULL) msgb. It must not
be used after that msgb has been modified or freed.
TODO:
- use a separate commit for the constness changes??
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/gprs_bssgp_pcu.cpp | 4 ++--
src/gprs_bssgp_pcu.h | 4 ++--
src/llc.cpp | 26 +++++++++++++++++++-------
src/llc.h | 16 ++++++++++++----
src/tbf_dl.cpp | 20 +++++++++-----------
tests/llc/LlcTest.cpp | 15 ++-------------
6 files changed, 46 insertions(+), 39 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, zecke/features/auth has been created
at 393b605c1a0d747a4c36eca91aa48e9475c171ee (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=393b605c1a0d747a4c36eca91aa48e94…
commit 393b605c1a0d747a4c36eca91aa48e9475c171ee
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 8 18:33:28 2015 +0200
nat: After we identified the bsc check the key
We are using the token to find the right bsc_config and
then we can use the last_rand of the bsc_connection to
calculate the expected result and try to compare it with
a time constant(???) memcmp.
http://cgit.osmocom.org/openbsc/commit/?id=f6ff44c023c93778f68bed67cc93253e…
commit f6ff44c023c93778f68bed67cc93253e31106d0d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 8 18:02:10 2015 +0200
bsc: Check for the rand and then generate a res
Check if the NAT has sent 16 bytes of RAND and if a key
has been configured in the system and then generate a
result using milenage. The milenage res will be sent and
noth the four byte GSM SRES derivation.
http://cgit.osmocom.org/openbsc/commit/?id=8885ce001fbf3bfe659f361c901014b4…
commit 8885ce001fbf3bfe659f361c901014b41e4428db
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 8 16:28:15 2015 +0200
nat: Send 16 bytes of rand to the BSC and remember it
Generate 16 byte of random data to be used for A3A8 by
the BSC in the response. We can't know which BSC it is
at this point and I don't want to send another message
once the token has been received so always send the data
with an undefined code. The old BSCs don't parse the
message and will happily ignore the RAND.
/dev/urandom can give short reads on Linux so loop
around it until the bytes have been read from the kernel.
http://cgit.osmocom.org/openbsc/commit/?id=7b608771dd1d4ded5ebf576b1462a0c1…
commit 7b608771dd1d4ded5ebf576b1462a0c12452f0fe
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 8 11:56:59 2015 +0200
nat: Provide access to /dev/urandom for the code
Instead of doing open/read/close all the time, open the
FD in the beginning and keep it open. To scare me even
more I have seen /dev/urandom actually providing a short
read and then blocking but it seems to be the best way
to get the random byes we need for authentication.
So one should/could run the cheap random generator on
the system (e.g. haveged) or deal with the NAT process
to block.
http://cgit.osmocom.org/openbsc/commit/?id=ad46558c54c3de17af2df2ccae46361c…
commit ad46558c54c3de17af2df2ccae46361cb7743332
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Jun 10 11:51:16 2015 +0200
bsc/nat: Fix the structure of the identity request message
Unfortunately the basic structure of the response is broken.
There is a two byte length followed by data. The concept of
a 'tag' happens to be the first byte of the data.
This means we want to write strlen of the token, then we
want to write the NUL and then we need to account for the
tag in front.
Introduce a flag if the new or old format should be used.
This will allow to have new BSCs talk to old NATs without
an additional change. In the long run we can clean that up.
http://cgit.osmocom.org/openbsc/commit/?id=fc9a3ff9dc3801c4ec6927cc80ec2625…
commit fc9a3ff9dc3801c4ec6927cc80ec2625d1332d65
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 8 11:55:02 2015 +0200
nat: Close the connection after we couldn't find the user
In case the token was not correct, just close the connection.
It is not clear that forcing a new TCP connection is going to
give us any extra security here. But with the upcoming auth
handling it does make sense to have both case look similar.
http://cgit.osmocom.org/openbsc/commit/?id=08ff087c9989822d2b0fe344264b95d0…
commit 08ff087c9989822d2b0fe344264b95d0343b6676
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 8 09:54:45 2015 +0200
nat: Factor out the config by token search
In the upcoming authentication improvements it is nice to
separate the finding of the config from the post-allow
handling of it.
http://cgit.osmocom.org/openbsc/commit/?id=3d07ca5e2f23bc86b9f938efd93ef333…
commit 3d07ca5e2f23bc86b9f938efd93ef3331ddc41cd
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 8 18:31:02 2015 +0200
nat: Add size check for the payload
The msgb will always have these bytes but it is better practice
to verify that the message really has space for the two bytes.
-----------------------------------------------------------------------
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/ms-struct has been updated
discards 9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d (commit)
via 0a9639012204a79bf5ae4c103a6de083e7e488d6 (commit)
via 155cf8442a796d7263e5fb480e029cad353afcf0 (commit)
via bd8c689ed42c5260719b3ca172ad3052d73467e0 (commit)
via 618babae128ddc2cd1bdca8d65ea1156ad78ee75 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d)
\
N -- N -- N (0a9639012204a79bf5ae4c103a6de083e7e488d6)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=0a9639012204a79bf5ae4c103a6de08…
commit 0a9639012204a79bf5ae4c103a6de083e7e488d6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 10:52:34 2015 +0200
ms: Reduce DL CS level if only a few LLC bytes are left
If just a few bytes are left to send to the MS, it makes sense to
reduce the coding scheme level to increase the throughput. This
has been shown by Chen and Goodman in their paper "Theoretical
Analysis of GPRS Throughput and Delay". See their throughput over C/I
measurement graphs (figures 4 and 5 in the paper) for details.
This commit implements a simplified CS downgrade feature for the
downlink. The coding scheme will be downgraded if there are only a
few octets are left to be send over the TBF (see the
downgrade-threshold command below) and the NACK rate is not low (the
CS will not get degraded on a high quality RF link). As an exception,
CS-3 will be degraded to CS-1, since CS-2 does not improve the
throughput in general when a few small packets are sent and the
signal fades slowly (see Chen/Goodman).
The following VTY command is added to the config-pcu node:
- cs downgrade-threshold <1-10000>
- cs no downgrade-threshold
to set the threshold of the number of remaining bytes to be RLC/MAC
encoded. The CS will only be reduced, if the number is below the
threshold. The 'no' command disables this feature completely. The
default value is 200 octets.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=155cf8442a796d7263e5fb480e029ca…
commit 155cf8442a796d7263e5fb480e029cad353afcf0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 15 11:05:44 2015 +0200
llc: Keep track of the number of stored LLC octets
To get the number of LLC octets that are stored in the queue, this
commit adds a m_queue_octets member along with a octets() method.
This value is updated similarly to m_queue_size on each modifying
method call.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=bd8c689ed42c5260719b3ca172ad305…
commit bd8c689ed42c5260719b3ca172ad3052d73467e0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 15 11:19:13 2015 +0200
llc: Add missing include directive to llc.h
Currently struct llist_head is used without declaration which
accidently did not produce an error so far.
This commit adds the missing include directive.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=618babae128ddc2cd1bdca8d65ea115…
commit 618babae128ddc2cd1bdca8d65ea1156ad78ee75
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 15 11:04:25 2015 +0200
llc/test: Add test program for LLC related tests
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/bts.h | 1 +
src/gprs_ms.cpp | 18 ++---
src/llc.cpp | 4 ++
src/llc.h | 11 +++
src/pcu_main.cpp | 1 +
src/pcu_vty.c | 34 ++++++++++
tests/Makefile.am | 14 +++-
tests/llc/LlcTest.cpp | 180 ++++++++++++++++++++++++++++++++++++++++++++++++++
tests/llc/LlcTest.err | 4 ++
tests/llc/LlcTest.ok | 2 +
tests/ms/MsTest.cpp | 38 +++++++++++
tests/ms/MsTest.err | 2 +
tests/ms/MsTest.ok | 2 +
tests/testsuite.at | 7 ++
14 files changed, 309 insertions(+), 9 deletions(-)
create mode 100644 tests/llc/LlcTest.cpp
create mode 100644 tests/llc/LlcTest.err
create mode 100644 tests/llc/LlcTest.ok
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via ce97a06fa385c97715bb52b34cc571789e9c79e5 (commit)
from 0958938d4ea32b4eff288b4b1369384f8eaddb93 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=ce97a06fa385c97715bb52b34cc57178…
commit ce97a06fa385c97715bb52b34cc571789e9c79e5
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 15 09:44:39 2015 +0200
bsc: Attempt to fix crash when sending a SCCP CREF message
There was no context for the SCCP CREF message and this means
that the msc_con was a plain NULL pointer that was dereferenced
and the application would crash.
Use the new API to pass the incoming MSC Connection which sould
be used for the SCCP CREF message as context. The code has not
been fed with an actual SCCP CR message.
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/osmo-bsc/osmo_bsc_msc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SCCP Library".
The branch, master has been updated
via a9c411ec8cb594775bbfc9faefcf8c8d21080402 (commit)
via b89e03de226aa2fcfb331cd8ad6de828a718bb58 (commit)
from e0cd6c4d3b7388ec20f8cec9d997429941d4d1b0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmo-sccp/commit/?id=a9c411ec8cb594775bbfc9faefc…
commit a9c411ec8cb594775bbfc9faefcf8c8d21080402
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jun 15 09:40:43 2015 +0200
sccp: Allow to specify the context of the incoming message
At the time a SCCP CREF is sent there is no context anymore
and the user of the API might not know where to return the
message to. Allow to specify the incoming context and use it
on the way out.
There are no more callers of _send_msg which passes a NULL
connection and a NULL context.
http://cgit.osmocom.org/libosmo-sccp/commit/?id=b89e03de226aa2fcfb331cd8ad6…
commit b89e03de226aa2fcfb331cd8ad6de828a718bb58
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Apr 16 21:17:13 2015 +0200
debian: Build new version of the package
-----------------------------------------------------------------------
Summary of changes:
debian/changelog | 8 +++++++-
include/sccp/sccp.h | 1 +
src/sccp.c | 19 ++++++++++++-------
3 files changed, 20 insertions(+), 8 deletions(-)
hooks/post-receive
--
SCCP Library
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/ms-struct has been updated
discards 60d611adcea23fd28a32913aba4ac3e6774fd630 (commit)
discards c0cd2ffc2b07340ffe4e788a61d31800b4866980 (commit)
discards 939043b385ce0c0cbc2fc7c459e3f8f660a8260c (commit)
discards 1e96f228d4ffd10a8b19f0c85b84d3fd5f5b7dd5 (commit)
via 9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d (commit)
via 2f7228b15fd8b55c6bc0c3e203aa19cb41497bf6 (commit)
via e61b652e1b9f184d8cf9584b068600e907df2347 (commit)
via 53a32b8e95bed5cca800c98861458cbfed753104 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (60d611adcea23fd28a32913aba4ac3e6774fd630)
\
N -- N -- N (9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=9c2bc1f28480b3487bbc34d6ba2779a…
commit 9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 10:52:34 2015 +0200
tbf: Reduce CS level if only a few LLC bytes are left (TODO)
This is an experimental commit to reduce the coding scheme level if
just a few bytes are left to send to the MS. This makes the
transmission more robust and can improve throughput and latency if
only a few small packages like TCP ACKs or ICMP PINGs are sent.
TODO:
- commit message
- make threshold configurable (at least by a macro)
- test case
http://cgit.osmocom.org/osmo-pcu/commit/?id=2f7228b15fd8b55c6bc0c3e203aa19c…
commit 2f7228b15fd8b55c6bc0c3e203aa19cb41497bf6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 14:06:09 2015 +0200
tbf: Fix downlink packet loss
When the MS is pinged with a longer interval, many packets get lost
even if the GprsMs object is kept. If the interval is above the time
where the DL TBF is in state FLOW (mainly influenced be the
dl-tbf-idle-time command), an new TBF must be requested via AGCH for
each ICMP PING message.
Currently the LLC frame containing the PING is immediately stored
in the TBF and gets lost, if TBF establishment fails for some reason.
This commit moves all calls to put_frame() to schedule_next_frame(),
where the data is moved from the LLC queue to the frame storage
within the TBF object. This method is only called from within
create_new_bsn() when the TBF is in the FLOW state and the frame is
going to be encoded immediately.
At all other places, where put_frame() has been called before, the
LLC message is just appended to the LLC queue in the GprsMs object.
This change effectively simplifies the related code parts, since
date/len information and discard notifications is no longer needed
there.
Ticket: #1759
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=e61b652e1b9f184d8cf9584b068600e…
commit e61b652e1b9f184d8cf9584b068600e907df2347
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 13:41:00 2015 +0200
tbf/test: Add test for DL LLC packet loss
Currently LLC frames are lost or even reordered when the TBF has be
established via the AGCH and the procedure fails for some reason.
This test tries to reproduce this behaviour by throwing away the
first TBF while calling the handle() method several times. The
results of create_dl_acked_block() are checked against expected
values (this is currently party disabled because the bug still
persists).
Ticket: #1759
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=53a32b8e95bed5cca800c98861458cb…
commit 53a32b8e95bed5cca800c98861458cbfed753104
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 16:01:56 2015 +0200
ms: Store the NACK rate in the MS object
Currently the NACK/unconfirmed ratio is already passed to the
corresponding MS object, but the value is not being stored there.
This commit adds a member and a getter method and include the values
into the output of the 'show ms' command.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/pcu_vty_functions.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/ms-struct has been updated
discards 5522d4a5ef71157c7429d687cbc96a3f29f74ea0 (commit)
discards 4507a1f2aad235aff7cb56925a498d0175710f7d (commit)
discards 058c0274f87a0cc0ade2e4b22ad3e2820031cff6 (commit)
via 60d611adcea23fd28a32913aba4ac3e6774fd630 (commit)
via c0cd2ffc2b07340ffe4e788a61d31800b4866980 (commit)
via 939043b385ce0c0cbc2fc7c459e3f8f660a8260c (commit)
via 1e96f228d4ffd10a8b19f0c85b84d3fd5f5b7dd5 (commit)
via 6634635cf57c551538c43892de3e7eb2e10b1631 (commit)
via 5823b20f2f81bff984461436e8e2512b5daa8793 (commit)
via 6659c516fa32ab64642b5822bf4b880f3cc27bbb (commit)
via 54fff3b3e4cef0bf182ec7779793a252b73c48b0 (commit)
via 3bea905e0d013de9a0b9d77fdc5318a133a6af9b (commit)
via 4ff709c3aca86f9974c99b99aea3da9bfde714a3 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (5522d4a5ef71157c7429d687cbc96a3f29f74ea0)
\
N -- N -- N (60d611adcea23fd28a32913aba4ac3e6774fd630)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=60d611adcea23fd28a32913aba4ac3e…
commit 60d611adcea23fd28a32913aba4ac3e6774fd630
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 10:52:34 2015 +0200
tbf: Reduce CS level if only a few LLC bytes are left (TODO)
This is an experimental commit to reduce the coding scheme level if
just a few bytes are left to send to the MS. This makes the
transmission more robust and can improve throughput and latency if
only a few small packages like TCP ACKs or ICMP PINGs are sent.
TODO:
- commit message
- make threshold configurable (at least by a macro)
- test case
http://cgit.osmocom.org/osmo-pcu/commit/?id=c0cd2ffc2b07340ffe4e788a61d3180…
commit c0cd2ffc2b07340ffe4e788a61d31800b4866980
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 14:06:09 2015 +0200
tbf: Fix downlink packet loss
When the MS is pinged with a longer interval, many packets get lost
even if the GprsMs object is kept. If the interval is above the time
where the DL TBF is in state FLOW (mainly influenced be the
dl-tbf-idle-time command), an new TBF must be requested via AGCH for
each ICMP PING message.
Currently the LLC frame containing the PING is immediately stored
in the TBF and gets lost, if TBF establishment fails for some reason.
This commit moves all calls to put_frame() to schedule_next_frame(),
where the data is moved from the LLC queue to the frame storage
within the TBF object. This method is only called from within
create_new_bsn() when the TBF is in the FLOW state and the frame is
going to be encoded immediately.
At all other places, where put_frame() has been called before, the
LLC message is just appended to the LLC queue in the GprsMs object.
This change effectively simplifies the related code parts, since
date/len information and discard notifications is no longer needed
there.
Ticket: #1759
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=939043b385ce0c0cbc2fc7c459e3f8f…
commit 939043b385ce0c0cbc2fc7c459e3f8f660a8260c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 13:41:00 2015 +0200
tbf/test: Add test for DL LLC packet loss
Currently LLC frames are lost or even reordered when the TBF has be
established via the AGCH and the procedure fails for some reason.
This test tries to reproduce this behaviour by throwing away the
first TBF while calling the handle() method several times. The
results of create_dl_acked_block() are checked against expected
values (this is currently party disabled because the bug still
persists).
Ticket: #1759
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=1e96f228d4ffd10a8b19f0c85b84d3f…
commit 1e96f228d4ffd10a8b19f0c85b84d3fd5f5b7dd5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 16:01:56 2015 +0200
ms: Store the NACK rate in the MS object
Currently the NACK/unconfirmed ratio is already passed to the
corresponding MS object, but the value is not being stored there.
This commit adds a member and a getter method and include the values
into the output of the 'show ms' command.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=6634635cf57c551538c43892de3e7eb…
commit 6634635cf57c551538c43892de3e7eb2e10b1631
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 12 10:48:05 2015 +0200
tbf: Include CS into create_new_bsn log message
This change lets the test suite fail, so it get its own commit.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=5823b20f2f81bff984461436e8e2512…
commit 5823b20f2f81bff984461436e8e2512b5daa8793
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jun 11 18:09:00 2015 +0200
l1: Add debug log messages for I_LEVEL
The I_LEVEL values that are obtained now look suspicious. They do not
seem to be contained in messages recorded via gsmtab.
To help debugging this issue, this commit adds related debug messages
that are generated while the encoded values are taken from the
RLC/MAC messages.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=6659c516fa32ab64642b5822bf4b880…
commit 6659c516fa32ab64642b5822bf4b880f3cc27bbb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jun 11 16:54:50 2015 +0200
l1: Store measurement values sent by the MS
This commit extends the pcu_l1_meas structure by MS side measurement
values which are transmitted by PACKET DOWNLINK ACK/NACK and
PACKET RESOURCE REQUEST messages. The encoded values are remapped to
dB respectively % values. The values are stored in the corresponding
MS object (if there is one).
Note that the values are store as (rounded) integers, so some
different encodings are mapped to the same decoded value.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=54fff3b3e4cef0bf182ec7779793a25…
commit 54fff3b3e4cef0bf182ec7779793a252b73c48b0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 9 09:44:36 2015 +0200
ms: Add UL CS selection based on L1 link quality
Currently the UL CS values are set to the corresponding DL CS value,
eventually limited by a maximum value. This approach does not reflect
the general situation of the RF link between ME and BTS, which is
rather asymmetric e.g. due to a lower degree of TX efficiency of the
built-in antenna. This means, that UL and DL CS control should be
decoupled for better results.
This commit adds automatic UL CS selection based on the link quality
measurement parameter. Each coding scheme is mapped to a link quality
range. If the link quality value leaves that range, the current UL CS
value is increased/decreased accordingly. This value will be copied
when the next PACKET_UPLINK_ACK_NACK or PACKET_UPLINK_ASSIGMENT is
sent to the MS.
The following VTY command will be added to the config-pcu node:
- cs link-quality-ranges cs1 <0-35> cs2 <0-35> <0-35>
cs3 <0-35> <0-35> cs4 <0-35>
which sets the ranges for the four coding schemes. For instance the
example below reflects the current default values:
cs link-quality-ranges cs1 6 cs2 5 8 cs3 7 13 cs4 12
set the following ranges, where the overlapping is used to configure
a hysteresis:
CS1: -inf .. 6
CS2: 5 .. 8
CS3: 7 .. 13
CS4: 12 .. inf
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=3bea905e0d013de9a0b9d77fdc5318a…
commit 3bea905e0d013de9a0b9d77fdc5318a133a6af9b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 8 11:26:38 2015 +0200
ms: Store the L1 measurement values in the MS objects
This commits adds the GprsMs::update_l1_meas() and GprsMs::l1_meas()
methods to store and access the measurement values. The internal
state is updated depending on which values are actually set.
In addition, these values are shown in the output of the 'show ms
imsi|tlli' command.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=4ff709c3aca86f9974c99b99aea3da9…
commit 4ff709c3aca86f9974c99b99aea3da9bfde714a3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 8 11:05:45 2015 +0200
l1: Pass all L1 measurements upwards
Currently only the RSSI value is passed to the upper layers. Other
values like TA and BER which are needed for TA update respectively CS
selection are not propagated.
This commit introduces and passes a struct that contains a set of
measurement values.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/bts.cpp | 72 ++++++++++++++++++++-
src/gprs_ms.cpp | 53 ++++++++++++++-
src/gprs_ms.h | 12 ++--
src/pcu_l1_if.h | 46 ++++++++++++-
src/pcu_main.cpp | 8 +--
src/pcu_vty.c | 2 +-
src/pcu_vty_functions.cpp | 19 ++++++
src/tbf.h | 3 +-
src/tbf_dl.cpp | 137 ++++++++++++++++++++-------------------
tests/tbf/TbfTest.cpp | 70 ++++++++++++++++++++
tests/tbf/TbfTest.err | 161 ++++++++++++++++++++++++++++++++++++++--------
tests/tbf/TbfTest.ok | 2 +
12 files changed, 475 insertions(+), 110 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, achemeris/burst_to_disk has been deleted
was f2bdd1a24ca4f512b0d90f7cac55f5246238b5ce
-----------------------------------------------------------------------
f2bdd1a24ca4f512b0d90f7cac55f5246238b5ce transceiver: Add a debug option to dump selected timeslots to disk.
-----------------------------------------------------------------------
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, fairwaves/pending has been updated
via f2bdd1a24ca4f512b0d90f7cac55f5246238b5ce (commit)
from 34e5a3807f4d77f098c786b99aa6bea5c0160918 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
Transceiver52M/Transceiver.cpp | 27 ++++++++++++++++++++++++++-
Transceiver52M/Transceiver.h | 1 +
2 files changed, 27 insertions(+), 1 deletion(-)
hooks/post-receive
--
OpenBTS' transceiver retro-fit