Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36457?usp=email )
Change subject: msc: allow f_verify_vty_lac_ci() to pass for CompL3 by TMSI MI
......................................................................
Patch Set 1:
(1 comment)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36457/comment/716243b3_a6dd…
PS1, Line 832: setverdict(pass);
it does actually make sense to setverdict(pass) on
everything that the test verifies. […]
I find it annoying because it pollutes the
log (and I usually CTRL+F for "setverdict" to find the failure. But not really a
problem, it's fine if you like it that way.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36457?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4d719928f04e5a47d415c38f835451b1f10c713d
Gerrit-Change-Number: 36457
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Mar 2024 14:11:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment