[L] Change in onomondo-ipa[master]: V1.2: Add function ES10b.GetConnectivityParameters - gerrit-log

26 Aug 2026


      Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )
Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................
Patch Set 8:
(1 comment)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/ec80cf55_8124b33b?... :
PS8, Line 376: 		rc = 0;
I Would return -EINVAL here. In ASN.1 one must not chose nothing. I think those asn1c PR_NOTHING values are more an indication for a parse error.
(everything else looks fine now)
-- 
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 8
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Comment-Date: Wed, 26 Aug 2026 09:35:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No