[M] Change in pysim[master]: osmo-smdpp: derive the Profile Metadata from the Profile - gerrit-log

14 Aug 2026


      Attention is currently required from: dexter, jolly, laforge.
jwaigel has posted comments on this change by jwaigel. ( https://gerrit.osmocom.org/c/pysim/+/43205?usp=email )
Change subject: osmo-smdpp: derive the Profile Metadata from the Profile
......................................................................
Patch Set 3:
(1 comment)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/43205/comment/dbce66ab_0d7ee0eb?usp=ema... :
PS2, Line 638:             # look up profile based on matchingID.  We simply check if a given file exists for now..
...
I don't like that the 'if matchingId' (or alternatively an 'else' clause) has been removed here. […]
Restored the second branch, thanks.
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/43205?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie24dd5ac0ef541c1899dd923a9db568209bbfa62
Gerrit-Change-Number: 43205
Gerrit-PatchSet: 3
Gerrit-Owner: jwaigel johannes@waigel.me
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: jolly andreas@eversberg.eu
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 13 Aug 2026 14:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org