Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email )
Change subject: stp: tcap: Avoid need of N_NOTICE.req
......................................................................
Patch Set 1:
(1 comment)
File stp/STP_Tests_TCAP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152/comment/6fd5f0f1_b9e45... :
PS1, Line 212: private function f_asp_disconnect_mtp3_port(integer asp_idx := 0) runs on TCAP_CT
do you need to call this somewhere?
Not really needed for the existing test, but since most of the complexity with all this is actually figureing out where/how to hook stuff in the big set of layers, I think it's a good idea to leave it here in case one needs to write more tests needing to send UDTS and then disconnecting to let the SCCP layer continue without the hook.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia1b7f487124584ab1720cb89bca5999cbb12392d
Gerrit-Change-Number: 43152
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 03 Aug 2026 11:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de