Attention is currently required from: pespin.

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email )

Change subject: sgs_iface: clean up code in function decode_mme_name ......................................................................

Patch Set 1:

(1 comment)

File src/libmsc/sgs_iface.c:

https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/91ddb4a5_d889af8f?usp=... : PS1, Line 165: const uint8_t *mme_name_enc = TLVP_VAL_MINLEN(tp, SGSAP_IE_MME_NAME, SGS_MME_NAME_LEN); @espin: so is the TLV value actually expected to be at least SGS_MME_NAME_LEN? Is that correct?

@dexter: In recent versions 3GPP TS 29.118, section 9.4.13 only says that it is an FQDN with no further info. So the length could be the maximum length of an FQDN. However in the V13.5.0 version of that spec they explicitly state that the FQDN has an exact length of 55 bytes. Then the line would be correct, but some doubt on my side remains.