pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43411?usp=email )

Change subject: m3ua: Remove unnecessary check in m3ua_decode_notify() ......................................................................

m3ua: Remove unnecessary check in m3ua_decode_notify()

M3UA_IEI_STATUS is mandatory in M3UA NOTIFY Req, and its presence and fixed length is hence being validated in struct xua_msg_part_class m3ua_ntfy_req_ies.

Change-Id: I9fe6417ccc560e13603fbd2d5823afbeba8c9064 --- M src/m3ua.c 1 file changed, 1 insertion(+), 4 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/43411/1

diff --git a/src/m3ua.c b/src/m3ua.c index 52bf12e..ae3077a 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -684,10 +684,7 @@

/* cannot use xua_msg_get_u32() as it does endian conversion */ status_ie = xua_msg_find_tag(xua, M3UA_IEI_STATUS); - if (!status_ie) { - LOGP(DLM3UA, LOGL_ERROR, "M3UA NOTIFY without Status IE\n"); - return M3UA_ERR_MISSING_PARAM; - } + OSMO_ASSERT(status_ie); status = *(uint32_t *) status_ie->dat;

aspid_ie = xua_msg_find_tag(xua, M3UA_IEI_ASP_ID);