Attention is currently required from: daniel, fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email )
Change subject: asp: Support setting timer xua beat 0 through VTY
......................................................................
Patch Set 1:
(1 comment)
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156/comment/2c7ed4c3_0c4e15... :
PS1, Line 835: if (!t)
maybe print a message here as well, so the user knows what went wrong?
tbh that should not happen, since the timer should exist, it's just a safety check in case something is terribly wrong, eg. during development.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iadd7c6751ab09640fd2df214afa2ec87274a3210
Gerrit-Change-Number: 43156
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 04 Aug 2026 08:00:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de