Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email )
Change subject: mobile: add support for Circuit Switched Data calls
......................................................................
Patch Set 6:
(2 comments)
File src/host/layer23/include/osmocom/bb/common/settings.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34762/comment/9e06fb6e_ac01a9bd
PS6, Line 101: enum data_call_ce {
what is 'ce' mean in this context? I'd
appreciate at least a comment above the enum to explain that. […]
Done
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34762/comment/23ee3228_6b999a79
PS6, Line 379: LOGP(DRR, LOGL_ERROR,
at first sigt it looks like trhose lines don't
need to be wrapped within 120chars?
I was aiming for consistence with the existing
code in this function, but at least the format strings can be on the same line with
`LOGP`. Marking as resolved.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1995fa0a7a68d9b980852b664d472d4633777ac6
Gerrit-Change-Number: 34762
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 03 Nov 2023 06:44:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment