Attention is currently required from: dexter.
Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42996?usp=email )
Change subject: Remote Card Procedure Framework ......................................................................
Patch Set 2:
(20 comments)
File contrib/rcp/rcp_utils.py:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/9358ece7_47b113e0?usp=ema... : PS2, Line 167: """Set crash_report_flag. Thie method shall be called if an unrecoverable error has occured.""" 'occured' may be misspelled - perhaps 'occurred'?
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/1384bb4b_1ae976a5?usp=ema... : PS2, Line 173: inculde communications (records_comm) and debug information (records_debug). Otherwise only the metadata 'inculde' may be misspelled - perhaps 'include'?
File contrib/rcp/usage_example/certs/example_ssl_rcpc_rcps_cert.pem:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/727897bf_b38613d7?usp=ema... : PS2, Line 36: X509v3 Basic Constraints: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/b3e54cb1_66d872fa?usp=ema... : PS2, Line 38: X509v3 Subject Key Identifier: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/b656e290_048bf215?usp=ema... : PS2, Line 40: X509v3 Authority Key Identifier: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/b4bc3c90_3b822eca?usp=ema... : PS2, Line 44: X509v3 Extended Key Usage: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/b2a6188a_d86161d5?usp=ema... : PS2, Line 46: X509v3 Key Usage: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/7071e94b_bfb2e71a?usp=ema... : PS2, Line 48: X509v3 Subject Alternative Name: trailing whitespace
File contrib/rcp/usage_example/certs/example_ssl_rcpm_rcps_cert.pem:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/2940c865_202bc903?usp=ema... : PS2, Line 36: X509v3 Basic Constraints: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/a287866e_15ea9a16?usp=ema... : PS2, Line 38: X509v3 Subject Key Identifier: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/2aac62a6_dc0659ea?usp=ema... : PS2, Line 40: X509v3 Authority Key Identifier: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/d9b8e792_4b6e138f?usp=ema... : PS2, Line 44: X509v3 Extended Key Usage: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/031e54e1_dae7bc2b?usp=ema... : PS2, Line 46: X509v3 Key Usage: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/8a8a7234_9fc68bf8?usp=ema... : PS2, Line 48: X509v3 Subject Alternative Name: trailing whitespace
File contrib/rcp/usage_example/certs/example_ssl_rcps_rcpm_cert.pem:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/5ac1f66b_99e71c73?usp=ema... : PS2, Line 36: X509v3 Basic Constraints: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/b880a6c8_f646dc25?usp=ema... : PS2, Line 38: X509v3 Subject Key Identifier: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/613da67c_821d0b23?usp=ema... : PS2, Line 40: X509v3 Authority Key Identifier: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/2ecd4929_acb4704c?usp=ema... : PS2, Line 44: X509v3 Extended Key Usage: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/c26de4ea_3ec01030?usp=ema... : PS2, Line 46: X509v3 Key Usage: trailing whitespace
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/42996/comment/a3803439_76cf0a6d?usp=ema... : PS2, Line 48: X509v3 Subject Alternative Name: trailing whitespace