Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43044?usp=email )
Change subject: V1.2: Add function ES10b.DisableEmergencyProfile ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
File include/onomondo/ipa/ipad.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/1973b96b_18437526?... : PS3, Line 100: int ipa_disable_emergency_profile(struct ipa_context *ctx);
maybe shorten "profile" to "prfle" and "emergency" to "emerg"?
Done
File src/ipa/libipa/es10b_dis_emerg_prfle.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/9c6b2462_c48ddd9b?... : PS3, Line 14: struct DisableEmergencyProfileResponse *res;
Also here, maybe just return the integer result?
Done
-
dexter