Attention is currently required from: dexter, laforge.

pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email )

Change subject: sgs_iface: clean up code in function decode_mme_name ......................................................................

Patch Set 6:

(1 comment)

File src/libmsc/sgs_iface.c:

https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/fce6d46d_ac1ce802?usp=... : PS6, Line 192: osmo_apn_to_str(mme_name, mme_name_enc, mme_name_enc_len); if we end up here, does it makes sense to previously have checked "if (mme_name_enc_len >= mme_name_len)" in line 176? I mean, there's some decoding happening here, not just a memcpy, so it could still be valid in that case...