Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43410?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Code-Review+1 by osmith
Change subject: mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4 ......................................................................
mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4
If an incoming message which contains an unbounded Routing Context IE, it may be that it comes malformed and hence len is < 4. In that case, xua_msg_part_get_u32() would have hit an ASSERT.
Fix the problem by simply passing by the whole Routing Context (removing non-multiple of 4 potential churn at the end), since anyway we should be sending the same whole set of Routing Contexts we received.
Related: OS#7074 Reported-By: Tristan Madani tristan@talencesecurity.com Change-Id: Ia0a8dd4907d6ad786e9cc257d299a1521dd45dee --- M src/mtp3_rtpc.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/43410/3