Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email )
Change subject: V1.2: Add function to set Device Capabilities ......................................................................
Patch Set 8:
(3 comments)
File src/ipa/libipa/euicc.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/0f8b46a7_b45b2e56?... : PS7, Line 535: /* Capabilities according to 3GPP TS 102.221, section 11.1.19.2.4 and GSMA SGP.32, section 3.8.2 */
Maybe we should also add GSMA SGP.22, section 3.4.2. In ipad.h you refer to this spec.
Done
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/0ca2ade6_cd72445a?... : PS7, Line 72: printf(" -D 0xXX ..................... set SGP.22 device capabilities other than the 3 that are required by this IPAd\n");
maybe point directly to the table like: set optional device capabilities (SGP. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/67e891cc_7d30ffa2?... : PS7, Line 288: printf(" device_capabilities = %u\n", cfg.device_capabilities);
Maybe use %02x because it is a bitmask?
Done