Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email )
Change subject: sgs_iface: clean up code in function decode_mme_name ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/libmsc/sgs_iface.c:
https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/90941969_6b55ee34?usp=... : PS1, Line 165: const uint8_t *mme_name_enc = TLVP_VAL_MINLEN(tp, SGSAP_IE_MME_NAME, SGS_MME_NAME_LEN);
@espin: so is the TLV value actually expected to be at least SGS_MME_NAME_LEN? Is that correct? […]
MME name is not some random DNS domain name, but a "fully qualified domain name (FQDN) as specified in subclause 19.4.2.1 of 3GPP TS 23.003" - that's the *.mccXXX.mncYYY.3gppnetwork.org domain, and in that scheme the length is known.