osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43243?usp=email )
Change subject: jenkins-gerrit/comment_generate: fix 0 jobs msg ......................................................................
jenkins-gerrit/comment_generate: fix 0 jobs msg
Check if there are no failed jobs as well before printing the "zero jobs, internal script error?" message.
Fixes: f30fab1c ("jenkins-gerrit/comment_generate: fail on 0 passed") Change-Id: I7289ce30492a84dedeac12bfc967d7c578f13790 --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve
diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index 1b3bfcd..e3c1c50 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -212,8 +212,8 @@
summary += f"{len(jobs['passed'])} passed:\n" summary += get_jobs_list_str(jobs["passed"]) - if not jobs['passed']: - summary += "Zero jobs passed, internal script error?\n" + if not jobs["passed"] and not jobs["failed"]: + summary += "Zero jobs passed or failed, internal script error?\n"
if "build" in pipeline and "deb" in pipeline and "rpm" in pipeline and \ not pipeline["build"]["passed"] and pipeline["deb"]["passed"] \