Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email )
Change subject: libosmo-trx/ep: add TRX endpoint module ......................................................................
Patch Set 3:
(4 comments)
File libosmo-trx/include/osmocom/trx/ep.h:
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/dbf0aae1_0e92cc2d?usp=... : PS1, Line 27: struct osmo_trx_ep_cfg {
Let's please have separate setter functions for all these, like osmo_stream, so we don't need to bre […]
Done
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/d28c9f25_658f98ca?usp=... : PS1, Line 60: uint8_t pdu_ver; /* TRXD PDU version in use */
iirc PDU VER stuff is defined/envisioned only for TRX0, so this can be moved to struct osmo_trx_ep.
No. The TRXD PDU version is actually negotiated for each endpoint separately. At least osmo-bts does negotiate the version for each transceiver connection individually, and osmo-trx handles this properly.
Only the power on/off command propagates to other connections.
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/40c30008_795a1db0?usp=... : PS1, Line 70: struct osmo_trx_ep_chan *chans; /* array of cfg.num_chans channels */
If the chans array is allocated at the end of the struct, it probably makes sense to use "struct osm […]
See my comment below.
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/838ddccf_47a6a862?usp=... : PS1, Line 302: ep->chans = talloc_zero_array(ep, struct osmo_trx_ep_chan, cfg->num_chans);
Ah I see you are allocating the array here as a pointer to a seaprate memory region. […]
I don't see the need for such a premature optimization, sorry. A `struct osmo_trx_ep` is normally allocated once and remains in the memory until the PHY connection is closed. It's not like we're allocating/freeing tons of endpoints per second.