23 Aug
2026
23 Aug
'26
12:41 p.m.
Attention is currently required from: biocape, fixeria.
laforge has posted comments on this change by biocape. ( https://gerrit.osmocom.org/c/pysim/+/41913?usp=email )
Change subject: Decode GSM 7-bit packed EF.PNN data ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File pySim/ts_51_011.py:
https://gerrit.osmocom.org/c/pysim/+/41913/comment/c2532c4e_ebced9ce?usp=ema... : PS1, Line 889: # TODO: 430a82d432bbbc7eb75de432450a82d432bbbc7eb75de432ffffffff :
Why removing these TODOs? They could be included in `_test_de_encode[]` too.
Done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41913?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4558fd011592aeeae2389fe8a1f62f3d7e21d219
Gerrit-Change-Number: 41913
Gerrit-PatchSet: 3
Gerrit-Owner: biocape biofel@cape.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: biocape biofel@cape.co
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sun, 23 Aug 2026 10:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de