Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email )
Change subject: V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa ......................................................................
Patch Set 2:
(3 comments)
File src/ipa/libipa/esipa_init_auth.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/ea82620c_b0d53b22?... : PS1, Line 19: TransactionId_t *eim_transaction_id;
As it seems there is a tab instead of a space between type and member name. […]
Done
File src/ipa/libipa/proc_cmn_mtl_auth.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/909927e0_aa2d3f6c?... : PS1, Line 19: TransactionId_t *eim_transaction_id;
maybe declare this as struct OCTET_STRING *eim_transaction_id? […]
Done
File src/ipa/libipa/proc_indirect_prfle_dwnld.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/c3c230de_871ed7f3?... : PS1, Line 18: TransactionId_t *eim_transaction_id;
(see the other comments)
Done