Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email )
Change subject: V1.2: Change fields in ProvideEimPackage(Result)
......................................................................
Patch Set 7:
(1 comment)
File src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/comment/9ca2e1fc_651177fe?... :
PS6, Line 86: res->eim_acknowledgements = &msg_to_ipa->choice.provideEimPackageResultResponse.choice.eimAcknowledgements;
I wonder if we should be more explcit in the case of an emptyResponse. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34
Gerrit-Change-Number: 43055
Gerrit-PatchSet: 7
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:15:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter
pmaier@sysmocom.de