Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email )
Change subject: V1.2: Add function ES10b.EnableEmergencyProfile ......................................................................
Patch Set 6:
(3 comments)
File include/onomondo/ipa/ipad.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/961d9a4a_99827a87?... : PS3, Line 99: int ipa_enable_emergency_profile(struct ipa_context *ctx);
you can shorten "profile" to "prfle", we used this abbreviation in lots of other places too.
Done
File src/ipa/libipa/es10b_en_emerg_prfle.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/bab07ad6_b024cea4?... : PS3, Line 14: struct EnableEmergencyProfileResponse *res;
Also here, it is just an integer that is returned, maybe return it directly to get an API that is si […]
I leave it this way, in case it get expanded.
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/2f087276_845656a5?... : PS3, Line 179: { "enable-emergency-profile", no_argument, NULL, OPT_ENABLEEMGERGENCY},
See comment from @laforge@gnumonks.org in the previous patch. I think we should clean this up.
Done