Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email )
Change subject: OM2K: Check bounds of OM2K Negotiation Request
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/43293/comment/99d56c47_1891a05d?usp=... :
PS1, Line 2777: uint8_t *cur = o2h->data+3;
You are accessing msg already here before the first check you added in 2785, are you sure this is correct?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed
Gerrit-Change-Number: 43293
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Comment-Date: Thu, 20 Aug 2026 16:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No