Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email )
Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ......................................................................
Patch Set 1:
(3 comments)
File include/osmocom/ranap/ranap_msg_factory.h:
https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/174d22e8_6748b511?usp=... : PS1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr,
the indention of the args looks weird, but fine.
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/c1370eed_0e7f576d?usp=... : PS1, Line 56: uint32_t gtp_tei,
the indention of the args looks weird, but fine.
Done
File src/ranap_msg_factory.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/af9ca08c_0e732f72?usp=... : PS1, Line 975: .sin_port = htons(2152),
You set a port here, which the old code doesn't. […]
I know it's not necessary, it doesn't harm either though. I can leave it as a 0.