Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email )
Change subject: esim/http_json_api.py: support text/plain response Content-Type ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
no feedback regarding those comments?
When the content-type is not JSON, but exactly plain UTF-8 text, the caller will receive a result dict of the form
{ 'data': 'foobar' }
which will not match the signature that a JSON API function expects, so there should be errors thrown in the calling code.
i can add an explicit flag but don't agree that it is necessary, i believe problems are being imagined that don't exist. What's your final verdict?
While inventing problems, we could make it { 'utf-8': 'foobar' } instead of 'data' in case more content types show up, like binary...? Still don't think that it is necessary.
(curious, i thought i had first submitted this patch only a few days ago -- it must have been part of an earlier submission before fixeria started...)