Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email )
Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies() ......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/xua_msg.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389/comment/54c527f8_4b59e1... : PS2, Line 549: return 0; This is unexpected to me. I would expect: * Ensure beforehand that msg_class is in the proper range to be used with dialect->class and log an error + reject the message if not. * OSMO_ASSERT(xmc) here.
Otherwise I guess a message could be crafted to bypass xua_dialect_check_all_ies by setting msg_class to a value that results in !xmc being true.