Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email )
Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies() ......................................................................
Patch Set 2:
(1 comment)
File src/xua_msg.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389/comment/12f73da1_29d0b2... : PS2, Line 549: return 0;
This is unexpected to me. I would expect: […]
I'm simply keeping the old logic here. Your porposal may make sense, but it for sure requires a seaprate commit to introduce that change. BTW, if we return here anyway the code flow will reject the message a few lines afterwards at the caller when it checks the msg_class/msg_type and finds an unknown one.