- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: split lchan specific defines and code to its own file
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28979 ) Change subject: split lchan specific defines and code to its own file ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I'm not sure I buy the argument "it's difficult to find" (juts one git grep away), but I certainly won't oppose the change either. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idd855d126c43ac6576c5f3ba7e0b8014127a65e1 Gerrit-Change-Number: 28979 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:05:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Use libosmocore available API to get value_list
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28978 ) Change subject: Use libosmocore available API to get value_list ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I95c59b31cf1b08e1d513b589ef386d2dd55f09a2 Gerrit-Change-Number: 28978 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:04:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add comment about fd cleanup
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28985 ) Change subject: add comment about fd cleanup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909 Gerrit-Change-Number: 28985 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:03:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: main: show just a brief talloc report for vty
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28984 ) Change subject: main: show just a brief talloc report for vty ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-upf/osmo_upf_main.c: https://gerrit.osmocom.org/c/osmo-upf/+/28984/comment/7ae8223e_af083e92 PS1, Line 380: talloc_report > What's the point of printing a report for the VTY context? I can understand doing this for tall_upf_ […] well, libosmovty could also have talloc memory leaks. But, surprisingly, I don't recall us ever having any. So maybe indeed it's an idea to omit printing it from [every] application. I think in the early days we had SIGUSR1/SIGUSR2 to differentiate which talloc contexts to dump. Either way, none of the options is perfect. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1 Gerrit-Change-Number: 28984 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:02:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: Ignore osmo-ns-dummy
by fixeria 08 Aug '22

08 Aug '22

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28991 ) Change subject: Ignore osmo-ns-dummy ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File .gitignore: https://gerrit.osmocom.org/c/libosmocore/+/28991/comment/5d0d725a_5c6e9c1e PS1, Line 73: utils/osmo-aka-verify I would expect 'osmo-ns-dummy' to be added here for consistency, but fine either way. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id562988942be13b83c552bdaa1ad93e275b3d0ae Gerrit-Change-Number: 28991 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:02:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: log: fix/tweak log msg about nft/mockup
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28983 ) Change subject: log: fix/tweak log msg about nft/mockup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8 Gerrit-Change-Number: 28983 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:00:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: update various expected-results.xml
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28989 ) Change subject: update various expected-results.xml ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I850b79526145307246bca40c70ed8e4d586d8c68 Gerrit-Change-Number: 28989 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:00:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: hnbgw: test PS RAB GTP mapping
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28818 ) Change subject: hnbgw: test PS RAB GTP mapping ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93c4689ddc016eb4eb25f8cbdd0142936c6f972b Gerrit-Change-Number: 28818 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 20:00:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 4: (5 comments) File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/42166368_8c29… PS1, Line 460: function tr_PFCP_Session_Est_Resp(template OCT8 hdr_seid := ?) return template PDU_PFCP { > Can it be "omit"? then "template (omit)", otherwise "template (present)". […] unresolved. both for the argument and for the return type File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/e123c505_a0dc… PS4, Line 187: function ts_PFCP_Assoc_Release_Req(template (value) Node_ID node_id) return template PDU_PFCP { return template (value) ? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/c88f0463_767a… PS4, Line 188: var template PDU_PFCP t := ts_PDU_PFCP(); template (value) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/37f09e41_bf5e… PS4, Line 198: function tr_PFCP_Assoc_Release_Resp(template Node_ID node_id := ?, template Cause cause := ?) return template PDU_PFCP { return template (present) ? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/0853a02f_0abd… PS4, Line 440: function tr_PFCP_Session_Est_Req() return template PDU_PFCP { template (present) here for the tr_ case? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 19:59:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: f_tc_mt_t310: detect MNCC failure explicitly
by laforge 08 Aug '22

08 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 ) Change subject: f_tc_mt_t310: detect MNCC failure explicitly ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971/comment/1f7b9d8c_57be… PS1, Line 1801: va > nice, I didn't know about "TYPE:?" Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1 Gerrit-Change-Number: 28971 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 19:55:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log