- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}
by pespin 27 Apr '22

27 Apr '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:57:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: bts_trx_vty: adjust TSC warning message
by pespin 27 Apr '22

27 Apr '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27953 ) Change subject: bts_trx_vty: adjust TSC warning message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I041150c9ce27caca6029ed54444562bb6cdcc57a Gerrit-Change-Number: 27953 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: bts_model_*_start: move set_feature calls to _init
by pespin 27 Apr '22

27 Apr '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27952 ) Change subject: bts_model_*_start: move set_feature calls to _init ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I43389ae48d5e0f01381602751f6bad902011b158 Gerrit-Change-Number: 27952 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:52:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS
by fixeria 27 Apr '22

27 Apr '22

Attention is currently required from: osmith, neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 4: (4 comments) File src/osmo-bsc/bts_trx.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/9b614c3c_433c3e8e PS4, Line 343: struct bitvec *ft const https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/c3a72264_5b484990 PS4, Line 355: if (!osmo_bts_has_feature(ft, BTS_FEAT_VAMOS)) { Not sure this check makes sense here. I would expect that all lchans to have 'vamos.enabled == false' at start up. Neels can definitely say more here. File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/408917e9_1d766d4c PS4, Line 319: struct gsm_bts *bts const https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/1ebe2d03_0afb89a9 PS4, Line 342: struct gsm_bts *bts const -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: abis_nm_ipaccess_rsl_connect: initialize ia
by pespin 27 Apr '22

27 Apr '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 ) Change subject: abis_nm_ipaccess_rsl_connect: initialize ia ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27951/comment/611a32e8_4c8c73de PS1, Line 3050: /* if ip == 0, we use the default IP */ what is the "default IP" here? It make make sense to fill ia with it in order to have meaningul logging. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc Gerrit-Change-Number: 27951 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}
by fixeria 27 Apr '22

27 Apr '22

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27938 to look at the new patch set (#3). Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... coding: fix comments for detect_afs_sid_{first,update,onset} Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Related: SYS#5853 --- M src/coding/gsm0503_amr_dtx.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/27938/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: coding: simplify detect_ahs_id_marker()
by fixeria 27 Apr '22

27 Apr '22

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27939 to look at the new patch set (#4). Change subject: coding: simplify detect_ahs_id_marker() ...................................................................... coding: simplify detect_ahs_id_marker() This function is used to detect SID_{UPDATE,FIRST} frames by their identification marker, which is basically a fixed 9-bit sequence repeated 24 times, minus 4 tailing bits (212 bits total). Current code employs three for-loops in order to match the marker, but the same can be efficiently achieved with just one for-loop. Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Related: SYS#5853 --- M src/coding/gsm0503_amr_dtx.c 1 file changed, 5 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/27939/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Gerrit-Change-Number: 27939 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS
by osmith 27 Apr '22

27 Apr '22

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/fd89c2ae_a6b7faa5 PS2, Line 347: * connected yet (thus not sent the feature vector), so we cannot know for > agreed. Patch updated. Now in vty commands the checks against bts features are skipped if the bts didn't report its features yet, and once the bts reports its features the relevant config options get validated again. If features are missing for the given config, the connection to the BTS gets dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: abis_nm_ipaccess_rsl_connect: initialize ia
by osmith 27 Apr '22

27 Apr '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 ) Change subject: abis_nm_ipaccess_rsl_connect: initialize ia ...................................................................... abis_nm_ipaccess_rsl_connect: initialize ia Fix access to uninitialized value from inet_ntoa(ia) inside the log message, found with valgrind. Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc --- M src/osmo-bsc/abis_nm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/27951/1 diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index a4976c0..6bced27 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -3038,7 +3038,7 @@ uint32_t ip, uint16_t port, uint8_t stream) { struct msgb *attr; - struct in_addr ia; + struct in_addr ia = {}; int error; osmo_timer_setup(&trx->rsl_connect_timeout, rsl_connect_timeout, trx); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc Gerrit-Change-Number: 27951 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: bts_model_*_start: move set_feature calls to _init
by osmith 27 Apr '22

27 Apr '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27952 ) Change subject: bts_model_*_start: move set_feature calls to _init ...................................................................... bts_model_*_start: move set_feature calls to _init With previous patch Idf2d933aa8b03b1f708e56a08707fe6c620a97aa, the features get copied from the BTS model to the BTS. For rbs2000, bs11 and nokia_site, an empty feature set was copied because the features weren't set at this point. Fix this by moving the set_feature calls to _init(). Notably the set_feature calls had been moved for osmo-bts and nanobts from _start to _init already in 2013 in the patch e84dd98d ("sysmobts: Avoid a crash when trying to look-up a BTS"). Fixes: 2d818b9f ("Always use reported features if available") Related: SYS#5922, OS#5538 Change-Id: I43389ae48d5e0f01381602751f6bad902011b158 --- M src/osmo-bsc/bts_ericsson_rbs2000.c M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_siemens_bs11.c 3 files changed, 22 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/27952/1 diff --git a/src/osmo-bsc/bts_ericsson_rbs2000.c b/src/osmo-bsc/bts_ericsson_rbs2000.c index b3d79b4..36b3783 100644 --- a/src/osmo-bsc/bts_ericsson_rbs2000.c +++ b/src/osmo-bsc/bts_ericsson_rbs2000.c @@ -213,6 +213,14 @@ static int bts_model_rbs2k_start(struct gsm_network *net) { + osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); + osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); + + return 0; +} + +int bts_model_rbs2k_init(void) +{ model_rbs2k.features.data = &model_rbs2k._features_data[0]; model_rbs2k.features.data_len = sizeof(model_rbs2k._features_data); @@ -222,13 +230,5 @@ osmo_bts_set_feature(&model_rbs2k.features, BTS_FEAT_HSCSD); osmo_bts_set_feature(&model_rbs2k.features, BTS_FEAT_MULTI_TSC); - osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); - osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); - - return 0; -} - -int bts_model_rbs2k_init(void) -{ return gsm_bts_model_register(&model_rbs2k); } diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 75ffa95..e20519a 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1759,14 +1759,6 @@ static int bts_model_nokia_site_start(struct gsm_network *net) { - model_nokia_site.features.data = &model_nokia_site._features_data[0]; - model_nokia_site.features.data_len = - sizeof(model_nokia_site._features_data); - - osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HOPPING); - osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HSCSD); - osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_MULTI_TSC); - osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); osmo_signal_register_handler(SS_NM, nm_sig_cb, NULL); @@ -1778,5 +1770,12 @@ int bts_model_nokia_site_init(void) { + model_nokia_site.features.data = &model_nokia_site._features_data[0]; + model_nokia_site.features.data_len = sizeof(model_nokia_site._features_data); + + osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HOPPING); + osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_HSCSD); + osmo_bts_set_feature(&model_nokia_site.features, BTS_FEAT_MULTI_TSC); + return gsm_bts_model_register(&model_nokia_site); } diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c index 818d84a..ed2c4c3 100644 --- a/src/osmo-bsc/bts_siemens_bs11.c +++ b/src/osmo-bsc/bts_siemens_bs11.c @@ -604,13 +604,6 @@ static int bts_model_bs11_start(struct gsm_network *net) { - model_bs11.features.data = &model_bs11._features_data[0]; - model_bs11.features.data_len = sizeof(model_bs11._features_data); - - osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HOPPING); - osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HSCSD); - osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_MULTI_TSC); - osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); osmo_signal_register_handler(SS_L_GLOBAL, gbl_sig_cb, NULL); @@ -619,5 +612,12 @@ int bts_model_bs11_init(void) { + model_bs11.features.data = &model_bs11._features_data[0]; + model_bs11.features.data_len = sizeof(model_bs11._features_data); + + osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HOPPING); + osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_HSCSD); + osmo_bts_set_feature(&model_bs11.features, BTS_FEAT_MULTI_TSC); + return gsm_bts_model_register(&model_bs11); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I43389ae48d5e0f01381602751f6bad902011b158 Gerrit-Change-Number: 27952 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

gerrit-log