- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: abis_nm_ipaccess_rsl_connect: initialize ia
by osmith 27 Apr '22

27 Apr '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 ) Change subject: abis_nm_ipaccess_rsl_connect: initialize ia ...................................................................... abis_nm_ipaccess_rsl_connect: initialize ia Fix access to uninitialized value from inet_ntoa(ia) inside the log message, found with valgrind. Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc --- M src/osmo-bsc/abis_nm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/27951/1 diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index a4976c0..6bced27 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -3038,7 +3038,7 @@ uint32_t ip, uint16_t port, uint8_t stream) { struct msgb *attr; - struct in_addr ia; + struct in_addr ia = {}; int error; osmo_timer_setup(&trx->rsl_connect_timeout, rsl_connect_timeout, trx); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc Gerrit-Change-Number: 27951 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS
by osmith 27 Apr '22

27 Apr '22

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 to look at the new patch set (#4). Change subject: Check VTY config against features reported by BTS ...................................................................... Check VTY config against features reported by BTS * Drop hardcoded features for osmo-bts and nanobts * Checks for BTS features in VTY cmds: pass if features are not set yet (not yet reported by the BTS), fail if the feature is missing * Once BTS reports its features, check relevant VTY config parts again Related: SYS#5922, OS#5538 Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa --- A doc/bts-features.txt M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/bts_osmobts.c M src/osmo-bsc/bts_trx.c M src/osmo-bsc/bts_trx_vty.c M src/osmo-bsc/bts_vty.c M tests/Makefile.am A tests/bts_features.vty 12 files changed, 131 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/23/27923/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: Use internal <osmocom/core/talloc.h> everywhere
by fixeria 27 Apr '22

27 Apr '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27937 ) Change subject: Use internal <osmocom/core/talloc.h> everywhere ...................................................................... Use internal <osmocom/core/talloc.h> everywhere Change-Id: If40e1eefcfa88a2b376becfe057836acdd3a1cc2 --- M src/gsm/apn.c M src/vty/talloc_ctx_vty.c M utils/osmo-ns-dummy-vty.c 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsm/apn.c b/src/gsm/apn.c index a7074ea..4800702 100644 --- a/src/gsm/apn.c +++ b/src/gsm/apn.c @@ -24,8 +24,8 @@ #include <stdint.h> #include <stdlib.h> #include <string.h> -#include <talloc.h> +#include <osmocom/core/talloc.h> #include <osmocom/gsm/apn.h> #define APN_OI_GPRS_FMT "mnc%03u.mcc%03u.gprs" diff --git a/src/vty/talloc_ctx_vty.c b/src/vty/talloc_ctx_vty.c index dcb1c9b..ea8ebe7 100644 --- a/src/vty/talloc_ctx_vty.c +++ b/src/vty/talloc_ctx_vty.c @@ -22,8 +22,8 @@ #include <stdio.h> #include <regex.h> #include <string.h> -#include <talloc.h> +#include <osmocom/core/talloc.h> #include <osmocom/vty/command.h> #include <osmocom/vty/vty.h> diff --git a/utils/osmo-ns-dummy-vty.c b/utils/osmo-ns-dummy-vty.c index f4a270c..2e59b11 100644 --- a/utils/osmo-ns-dummy-vty.c +++ b/utils/osmo-ns-dummy-vty.c @@ -21,7 +21,6 @@ * */ -#include <talloc.h> #include <errno.h> #include <string.h> #include <stdio.h> @@ -30,6 +29,7 @@ #include <inttypes.h> +#include <osmocom/core/talloc.h> #include <osmocom/core/select.h> #include <osmocom/core/application.h> #include <osmocom/core/stats.h> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If40e1eefcfa88a2b376becfe057836acdd3a1cc2 Gerrit-Change-Number: 27937 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb()
by fixeria 27 Apr '22

27 Apr '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27863 ) Change subject: utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb() ...................................................................... utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb() When building with CFLAGS="-flto -Wall", I get the following: meas_pcap2db.c: In function ‘pcap_cb’: meas_pcap2db.c:64:27: warning: pointer targets in initialization of ‘const char *’ from ‘const u_char *’ {aka ‘const unsigned char *’} differ in signedness [-Wpointer-sign] 64 | const char *cur = bytes; Change-Id: I84d8e6f290bda0f03476f182f292ecc7a9e520f2 --- M src/utils/meas_pcap2db.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/utils/meas_pcap2db.c b/src/utils/meas_pcap2db.c index db00fae..d784ca7 100644 --- a/src/utils/meas_pcap2db.c +++ b/src/utils/meas_pcap2db.c @@ -61,7 +61,7 @@ static void pcap_cb(u_char *user, const struct pcap_pkthdr *h, const u_char *bytes) { - const char *cur = bytes; + const u_char *cur = bytes; const struct iphdr *ip; const struct udphdr *udp; const struct meas_feed_meas *mfm; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I84d8e6f290bda0f03476f182f292ecc7a9e520f2 Gerrit-Change-Number: 27863 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: utils/meas_db: fix -Wunused-variable warnings
by fixeria 27 Apr '22

27 Apr '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27862 ) Change subject: utils/meas_db: fix -Wunused-variable warnings ...................................................................... utils/meas_db: fix -Wunused-variable warnings When building with CFLAGS="-flto -Wall", I get the following: meas_db.c: In function ‘_insert_ud’: meas_db.c:62:23: warning: unused variable ‘rowid’ [-Wunused-variable] 62 | unsigned long rowid; meas_db.c: In function ‘meas_db_insert’: meas_db.c:89:13: warning: unused variable ‘rc’ [-Wunused-variable] 89 | int rc; meas_db.c: In function ‘check_create_tbl’: meas_db.c:260:16: warning: unused variable ‘rc’ [-Wunused-variable] 260 | int i, rc; Change-Id: Id12958f67a47b6b3ebece7252e4f7c0835d4bb96 --- M src/utils/meas_db.c 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/utils/meas_db.c b/src/utils/meas_db.c index 4fc2916..bf3a093 100644 --- a/src/utils/meas_db.c +++ b/src/utils/meas_db.c @@ -59,8 +59,6 @@ static int _insert_ud(struct meas_db_state *st, unsigned long meas_id, int dtx, int uplink, const struct gsm_meas_rep_unidir *ud) { - unsigned long rowid; - SCK_OK(st->db, sqlite3_bind_int(st->stmt_ins_ud, 1, meas_id)); SCK_OK(st->db, sqlite3_bind_int(st->stmt_ins_ud, 2, rxlev2dbm(ud->full.rx_lev))); @@ -86,7 +84,6 @@ const char *scenario, const struct gsm_meas_rep *mr) { - int rc; sqlite3_int64 rowid, ul_rowid, dl_rowid; SCK_OK(st->db, sqlite3_bind_int(st->stmt_ins_mr, 1, timestamp)); @@ -257,7 +254,7 @@ static int check_create_tbl(struct meas_db_state *st) { - int i, rc; + int i; for (i = 0; i < ARRAY_SIZE(create_stmts); i++) { SCK_OK(st->db, sqlite3_exec(st->db, create_stmts[i], 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id12958f67a47b6b3ebece7252e4f7c0835d4bb96 Gerrit-Change-Number: 27862 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb()
by pespin 27 Apr '22

27 Apr '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27863 ) Change subject: utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I84d8e6f290bda0f03476f182f292ecc7a9e520f2 Gerrit-Change-Number: 27863 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 12:40:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb()
by pespin 27 Apr '22

27 Apr '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27863 ) Change subject: utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I84d8e6f290bda0f03476f182f292ecc7a9e520f2 Gerrit-Change-Number: 27863 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 12:38:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}
by laforge 27 Apr '22

27 Apr '22

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 10:24:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: paging: Rework timer lifecycle logic
by pespin 27 Apr '22

27 Apr '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27936 ) Change subject: paging: Rework timer lifecycle logic ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: credit_timer is scheduled during paging_init(), when the BTS is started. It is also re-scheduled every time paging_update_buffer_space() is called, that is, every time a CCCH Load indication. When credit_timer triggers (paging_give_credit()), paging_handle_pending_requests() is called. However, after that, the timer is not rescheduled, so indeed in here we'd fail to continue giving credit if no CCCH Load Ind is received anymore. Thanks for raising the topic, I'll fix it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6a0da03c408270044079e81d431f6641527c00cd Gerrit-Change-Number: 27936 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 10:23:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: Use internal <osmocom/core/talloc.h> everywhere
by laforge 27 Apr '22

27 Apr '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27937 ) Change subject: Use internal <osmocom/core/talloc.h> everywhere ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If40e1eefcfa88a2b376becfe057836acdd3a1cc2 Gerrit-Change-Number: 27937 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 10:23:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log