pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27957 )
Change subject: bsc: Avoid sending CCCH Load Ind (paging) when RSL C0 becomes up
......................................................................
bsc: Avoid sending CCCH Load Ind (paging) when RSL C0 becomes up
The paging CCCH Load Ind should only be sent when the BTS is over the
threshold, which is not the case when it starts up.
The BSC should underststand that the BTS under threshold and be able to
send paging requests.
Change-Id: I19a97e97ec96ba8ea2e28b1be8ac3b706b43e1b7
---
M bsc/BSC_Tests.ttcn
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/27957/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 2858cdf..26d47b6 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -961,7 +961,6 @@
alt {
[] IPA_RSL[i].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_ID_ACK)) {
T.stop;
- IPA_RSL[i].send(ts_ASP_RSL_UD(ts_RSL_PAGING_LOAD_IND(23)));
}
[] IPA_RSL[i].receive(ASP_IPA_Event:?) { repeat }
[] IPA_RSL[i].receive { repeat }
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27957
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I19a97e97ec96ba8ea2e28b1be8ac3b706b43e1b7
Gerrit-Change-Number: 27957
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27935 )
Change subject: paging: Estimate available_slots based on BTS config when no CCCH Load Ind received
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27935/comment/a8916bfc_6f42a0bc
PS1, Line 556: LOG_BTS(bts, DPAG, LOGL_DEBUG, "Estimated %u paging available_slots over %u seconds\n",
> FYI, that's what I get when running ttcn3-bsc-test: […]
This comment above is actually not accurate. 76 is momentarily printed during bts setup, but after the config is applied, "16" is actually the number of available slots over 2 seconds. That's because the tests are using combined C0 so apparently that means a lot less PCH. Is hence around 8 PCH slots per second a good calculation in this scenario?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2df68e10eb549d62765ad3b25429f7fe2d5bb0b9
Gerrit-Change-Number: 27935
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Apr 2022 16:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 )
Change subject: abis_nm_ipaccess_rsl_connect: initialize ia
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27951/comment/4d3e7308_32a163a3
PS1, Line 3050: /* if ip == 0, we use the default IP */
> As I understand it, this function generates a the ipaccess RSL connect message and sends it, and thi […]
Ok fine, but perhaps you can then initialize it in the else path:
if (ip != 0) {
...
} else {
ia = (struct in_addr){};
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27951
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc
Gerrit-Change-Number: 27951
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Apr 2022 14:48:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 )
Change subject: abis_nm_ipaccess_rsl_connect: initialize ia
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27951/comment/663921d2_660fe6d6
PS1, Line 3050: /* if ip == 0, we use the default IP */
> what is the "default IP" here? It make make sense to fill ia with it in order to have meaningul logg […]
As I understand it, this function generates a the ipaccess RSL connect message and sends it, and this "if ip == 0, we use the default IP" comment seems to refer to:
https://gitea.osmocom.org/cellular-infrastructure/osmo-bts/src/commit/d99e2…
If ip is 0, it does not get added to the msgb. With this patch, it gets printed as 0.0.0.0:
GSMTAP libosmocore logging OsmoBSC(82839): NM/3: abis_nm.c:3057 (bts=1,trx=0) IPA RSL CONNECT IP=0.0.0.0 PORT=3003 STREAM=0x00
So I'd leave this as is. Or would you change the log message?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27951
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc
Gerrit-Change-Number: 27951
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Apr 2022 14:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, tnt, pespin, fixeria.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27939 )
Change subject: coding: simplify detect_ahs_id_marker()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> while I agree the function is now easier to read, the truth is you are adding 212 modulus operations […]
You're doing a bit-wise comparison of 212 conescutive bits, instead of just memcmping a few bytes, the % isn't the issue here...
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8
Gerrit-Change-Number: 27939
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Apr 2022 14:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, laforge, tnt, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27939 )
Change subject: coding: simplify detect_ahs_id_marker()
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
while I agree the function is now easier to read, the truth is you are adding 212 modulus operations (hence 212 division operations) every time this function is called.
Not sure if this is really worth it, specially since this may be called lots of times. I'd like others to comment on this.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8
Gerrit-Change-Number: 27939
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Apr 2022 14:10:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 )
Change subject: Check VTY config against features reported by BTS
......................................................................
Patch Set 4:
(8 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/b76cff2b_0f44ed7c
PS4, Line 9: * Drop hardcoded features for osmo-bts and nanobts
Be careful here, nanobts may support some features it doesn't report, since there may be feature enums which we added ourselves? So it's possibel that for nanobts we may need some? Or we can simply check bts_is_nanobts() or alike?
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/c891f570_fae480ca
PS4, Line 302: /* BTS reports features on start up. When false, BTS model features get
"on start up" -> "during OML bring up".
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/55713f26_8387244c
PS4, Line 303: * copied to BTS features. */
"features during object initialization".
Actually, for the case of nanobts we may use both things: set up some during _init(), and some during OML bring up.
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/e8a424e5_b6c5044a
PS4, Line 347: bool features_set;
I'd rather call it "features_present" or "feature_available" or "features_known", features_set may drive to cofusion, like it's a set of features.
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/10ce9564_82187e7c
PS4, Line 507: if (bts->features_set) {
Let's move bts global checks before the trx/ts specific checks in the llist_for_each_entry above.
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/6bcb5925_94fb34b8
PS4, Line 630: memset(bts->_features_data, 0, sizeof(bts->_features_data));
You still may want to copy them in case of nanobts.
File src/osmo-bsc/bts_ipaccess_nanobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/c02d8b63_8871d2be
PS4, Line 498: bts_model_nanobts.features_get_reported = true;
I'm pretty sure this can be set when defining bts_model_nanobts directly in global scope, not here.
File src/osmo-bsc/bts_osmobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/f743f1f0_2e05ece1
PS4, Line 204: model_osmobts.features_get_reported = true;
same, can be set in bts_model_nanobts directly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa
Gerrit-Change-Number: 27923
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 27 Apr 2022 14:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment