Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 4: (5 comments) File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/42166368_8c294... PS1, Line 460: function tr_PFCP_Session_Est_Resp(template OCT8 hdr_seid := ?) return template PDU_PFCP {

Can it be "omit"? then "template (omit)", otherwise "template (present)". […] unresolved. both for the argument and for the return type

File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/e123c505_a0dc4... PS4, Line 187: function ts_PFCP_Assoc_Release_Req(template (value) Node_ID node_id) return template PDU_PFCP { return template (value) ? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/c88f0463_767a4... PS4, Line 188: var template PDU_PFCP t := ts_PDU_PFCP(); template (value) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/37f09e41_bf5eb... PS4, Line 198: function tr_PFCP_Assoc_Release_Resp(template Node_ID node_id := ?, template Cause cause := ?) return template PDU_PFCP { return template (present) ? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/0853a02f_0abd6... PS4, Line 440: function tr_PFCP_Session_Est_Req() return template PDU_PFCP { template (present) here for the tr_ case? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 19:59:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment