- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: iuup: do not use illegal characters in state/event names.

by pespin

Attention is currently required from: osmith, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26947 ) Change subject: iuup: do not use illegal characters in state/event names. ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ebc9ab5b1456fee29aa4e254fae862dc053f0aa Gerrit-Change-Number: 26947 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jan 2022 11:46:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: osmo_fsm: Ensure all state and event names are valid identifiers

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 ) Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ...................................................................... Patch Set 7: (2 comments) Patchset: PS7: I think this is a good idea, but there are indeed a lot of applications that have problems. Especially event names like XXXX.ind or XXXX.req are used quite often. I would suggest to replace the dot with a '-'. File src/fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/61fc3595_0879039d PS7, Line 296: "state name '%s'\n", states[i].name); I think this is problematic. osmo_fsm_register() may be called before the log is set up. Maybe we should consider using printf here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7 Gerrit-Change-Number: 16355 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jan 2022 11:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: iuup: do not use illegal characters in state/event names.

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26947 ) Change subject: iuup: do not use illegal characters in state/event names. ...................................................................... iuup: do not use illegal characters in state/event names. The event names contain '.', and there are spaces ' ' in the state names. This is a problem since states and events can also be monitored via the CTRL interface. Unfortunately the CTRL interface does not allow certain reserved characters. So lets rename the states and event names to make them compatible with the CTRL interface. Change-Id: Id19973b56f9d7b1e3d0b0d7c7d0be7beba5428fc Related OS#4149 Change-Id: I5ebc9ab5b1456fee29aa4e254fae862dc053f0aa --- M src/gsm/iuup.c 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/26947/1 diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index dbca344..eb595ce 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -160,15 +160,15 @@ }; static const struct value_string iuup_fsm_event_names[] = { - { IUUP_FSM_EVT_IUUP_CONFIG_REQ, "IuUP-CONFIG.req" }, - { IUUP_FSM_EVT_IUUP_DATA_REQ, "IuUP-DATA.req" }, - { IUUP_FSM_EVT_IUUP_DATA_IND, "IuUP-DATA.ind" }, - { IUUP_FSM_EVT_IUUP_STATUS_REQ, "IuUP-STATUS.req" }, - { IUUP_FSM_EVT_IUUP_STATUS_IND, "IuUP-STATUS.ind" }, - { IUUP_FSM_EVT_SSASAR_UNITDATA_REQ, "SSSAR-UNITDATA.req" }, - { IUUP_FSM_EVT_SSASAR_UNITDATA_IND, "SSSAR-UNITDATA.ind" }, - { IUUP_FSM_EVT_IUUP_UNITDATA_REQ, "IuUP-UNITDATA.req" }, - { IUUP_FSM_EVT_IUUP_UNITDATA_IND, "IuUP-UNITDATA.ind" }, + { IUUP_FSM_EVT_IUUP_CONFIG_REQ, "IuUP-CONFIG-req" }, + { IUUP_FSM_EVT_IUUP_DATA_REQ, "IuUP-DATA-req" }, + { IUUP_FSM_EVT_IUUP_DATA_IND, "IuUP-DATA-ind" }, + { IUUP_FSM_EVT_IUUP_STATUS_REQ, "IuUP-STATUS-req" }, + { IUUP_FSM_EVT_IUUP_STATUS_IND, "IuUP-STATUS-ind" }, + { IUUP_FSM_EVT_SSASAR_UNITDATA_REQ, "SSSAR-UNITDATA-req" }, + { IUUP_FSM_EVT_SSASAR_UNITDATA_IND, "SSSAR-UNITDATA-ind" }, + { IUUP_FSM_EVT_IUUP_UNITDATA_REQ, "IuUP-UNITDATA-req" }, + { IUUP_FSM_EVT_IUUP_UNITDATA_IND, "IuUP-UNITDATA-ind" }, { IUUP_FSM_EVT_INIT, "INIT" }, { IUUP_FSM_EVT_LAST_INIT_ACK, "LAST_INIT_ACK" }, { IUUP_FSM_EVT_INIT_NACK, "INIT_NACK" }, @@ -789,7 +789,7 @@ S(IUUP_FSM_EVT_SSASAR_UNITDATA_REQ) | S(IUUP_FSM_EVT_SSASAR_UNITDATA_IND), .out_state_mask = S(IUUP_FSM_ST_NULL), - .name = "TrM Data Transfer Ready", + .name = "TrM_Data_Transfer_Ready", .action = iuup_fsm_trm_data, }, [IUUP_FSM_ST_INIT] = { @@ -808,7 +808,7 @@ S(IUUP_FSM_EVT_IUUP_DATA_IND), .out_state_mask = S(IUUP_FSM_ST_NULL) | S(IUUP_FSM_ST_INIT), - .name = "SMpSDU Data Transfer Ready", + .name = "SMpSDU_Data_Transfer_Ready", .action = iuup_fsm_smpsdu_data, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ebc9ab5b1456fee29aa4e254fae862dc053f0aa Gerrit-Change-Number: 26947 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-e1-recorder[master]: checkpatch.conf: new file

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26946 ) Change subject: checkpatch.conf: new file ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I8b6f5f0b1dd980003a4ae2feaee78fc62debbc9c Gerrit-Change-Number: 26946 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: gsm23003: fix docstring for osmo_plmn_from_bcd()

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26919 ) Change subject: gsm23003: fix docstring for osmo_plmn_from_bcd() ...................................................................... gsm23003: fix docstring for osmo_plmn_from_bcd() The parameters described in the docstrings for osmo_plmn_from_bcd() do not match the actual parameter list. Change-Id: Ic0999dbe096a98418db7482bd110e20497d8e4a5 --- M src/gsm/gsm23003.c 1 file changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/19/26919/1 diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c index 71d44fb..b893873 100644 --- a/src/gsm/gsm23003.c +++ b/src/gsm/gsm23003.c @@ -445,14 +445,12 @@ } } -/* Convert given 3-byte BCD buffer to integers and write results to *mcc and - * *mnc. The first three BCD digits result in the MCC and the remaining ones in - * the MNC. Return mnc_3_digits as false if the MNC's most significant digit is encoded as 0xF, true - * otherwise; i.e. true if MNC > 99 or if it is represented with leading zeros instead of 0xF. +/* Convert given 3-byte BCD buffer to integers and write results to plmn->mcc and plmn->mnc. The first three BCD digits + * result in the MCC and the remaining ones in the MNC. Set plmn->mnc_3_digits as false if the MNC's most significant + * digit is encoded as 0xF, true otherwise; i.e. true if MNC > 99 or if it is represented with leading zeros instead of + * 0xF. * \param[in] bcd_src 3-byte BCD buffer containing MCC+MNC representations. - * \param[out] mcc MCC result buffer, or NULL. - * \param[out] mnc MNC result buffer, or NULL. - * \param[out] mnc_3_digits Result buffer for 3-digit flag, or NULL. + * \param[out] plmn user provided memory to store the result. */ void osmo_plmn_from_bcd(const uint8_t *bcd_src, struct osmo_plmn_id *plmn) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic0999dbe096a98418db7482bd110e20497d8e4a5 Gerrit-Change-Number: 26919 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

4
4
0 0

Change in osmo-ci[master]: Revert "remove linter jobs for osmo-e1d and osmo-e1-firmware"

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26944 ) Change subject: Revert "remove linter jobs for osmo-e1d and osmo-e1-firmware" ...................................................................... Revert "remove linter jobs for osmo-e1d and osmo-e1-firmware" Enable the linter again, as we decided to use a repo-specific checkpatch config in these. This reverts commit 2c6aa82c9a8a81addd805fe211b048076e01f8c5. Related: OS#5399 Change-Id: Ib79a20658bfae64d9b718e53e6a9393708a4e694 --- M jobs/gerrit-lint.yml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index b98a041..45db681 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -73,7 +73,9 @@ - simtrace2 - osmo-asf4-dfu - osmo-ccid-firmware + - osmo-e1d - osmo-cbc + - osmo-e1-recorder - gapk - osmo-uecups - osmo-el2tpd -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib79a20658bfae64d9b718e53e6a9393708a4e694 Gerrit-Change-Number: 26944 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in osmo-ci[master]: Revert "remove linter jobs for osmo-e1d and osmo-e1-firmware"

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26944 ) Change subject: Revert "remove linter jobs for osmo-e1d and osmo-e1-firmware" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib79a20658bfae64d9b718e53e6a9393708a4e694 Gerrit-Change-Number: 26944 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jan 2022 09:07:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-e1d[master]: checkpatch.conf: new file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26945 ) Change subject: checkpatch.conf: new file ...................................................................... checkpatch.conf: new file Related: OS#5399 Change-Id: I4bd109009cbe16f313e19ab78bd5fbcb13b0f656 --- A .checkpatch.conf 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/.checkpatch.conf b/.checkpatch.conf new file mode 100644 index 0000000..20c0832 --- /dev/null +++ b/.checkpatch.conf @@ -0,0 +1,2 @@ +--ignore OPEN_BRACE +--ignore SPACING -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4bd109009cbe16f313e19ab78bd5fbcb13b0f656 Gerrit-Change-Number: 26945 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in osmo-e1d[master]: checkpatch.conf: new file

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26945 ) Change subject: checkpatch.conf: new file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4bd109009cbe16f313e19ab78bd5fbcb13b0f656 Gerrit-Change-Number: 26945 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jan 2022 09:07:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-e1-recorder[master]: checkpatch.conf: new file

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26946 ) Change subject: checkpatch.conf: new file ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: this was actually an error on my side. osmo-e1-recorder is a normal osmocom project with no exceptions. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I8b6f5f0b1dd980003a4ae2feaee78fc62debbc9c Gerrit-Change-Number: 26946 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jan 2022 09:06:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log