- gerrit-log - lists.osmocom.org

Change in osmo-e1-hardware[master]: icE1usb doc: Link to wiki page about iso USB issues

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 ) Change subject: icE1usb doc: Link to wiki page about iso USB issues ...................................................................... icE1usb doc: Link to wiki page about iso USB issues Change-Id: Id5f555519d5e320570017178613c752591db4a2f --- M doc/manuals/chapters/firmware.adoc 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc index 1b440bd..5ae5fb1 100644 --- a/doc/manuals/chapters/firmware.adoc +++ b/doc/manuals/chapters/firmware.adoc @@ -185,7 +185,8 @@ activation of both icE1usb ports simultaneously. The XHCI controller firmware erroneously claims that there is insufficient bus bandwidth. However, the same icE1usb hardware/firmware works perfectly fine with -OHCI, UHCI and EHCI host controllers. +OHCI, UHCI and EHCI host controllers. See +https://osmocom.org/projects/e1-t1-adapter/wiki/Isochronous_USB_Issues for a user-maintained list of USB hosts / controllers and whether or not they work with two E1 ports. As most modern [PC] hardware has XHCI host controllers, you need to choose your hardware carefully if concurrent operation of both icE1usb -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id5f555519d5e320570017178613c752591db4a2f Gerrit-Change-Number: 26948 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb doc: Add pictures of front and back side

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 ) Change subject: icE1usb doc: Add pictures of front and back side ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 Gerrit-Change-Number: 26949 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jan 2022 20:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb doc: Link to wiki page about iso USB issues

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 ) Change subject: icE1usb doc: Link to wiki page about iso USB issues ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id5f555519d5e320570017178613c752591db4a2f Gerrit-Change-Number: 26948 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jan 2022 19:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb doc: Add pictures of front and back side

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 ) Change subject: icE1usb doc: Add pictures of front and back side ...................................................................... icE1usb doc: Add pictures of front and back side Closes: OS#5406 Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 --- M doc/manuals/chapters/hardware.adoc A doc/manuals/images/icE1usb-e1_side.jpg A doc/manuals/images/icE1usb-usb_side.jpg 3 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/49/26949/1 diff --git a/doc/manuals/chapters/hardware.adoc b/doc/manuals/chapters/hardware.adoc index 8055e64..0e129c2 100644 --- a/doc/manuals/chapters/hardware.adoc +++ b/doc/manuals/chapters/hardware.adoc @@ -19,7 +19,14 @@ PDF rendered schematics are available at https://git.osmocom.org/osmo-e1-hardware/plain/hardware/icE1usb/r1.0/icE1us… -=== Connectors +=== Connectors on E1 side + +image::images/icE1usb-e1_side.jpg[width=400,title="E1 side of icE1usb"] + +From left to right, there are the following connectors: + +* X5A: Primary E1 Port +* X5B: Secondary E1 Port ==== X5A and X5B: E1 Interface Connectors @@ -57,6 +64,17 @@ different pin-out. Particularly, you cannot use an Ethernet cross-over cable as an E1 cross-over! +=== Connectors on USB side + +image::images/icE1usb-usb_side.jpg[width=400,title="USB side of icE1usb"] + +From left to right, there are the following connectors: + +* X1: GPS Antenna Connector +* X2: Serial Console Connector +* X4: USB Connector +* X3: GPIO / Extension Connector + ==== X4: USB Connector The USB connector is a USB Type C connector. However, it only carries diff --git a/doc/manuals/images/icE1usb-e1_side.jpg b/doc/manuals/images/icE1usb-e1_side.jpg new file mode 100644 index 0000000..5bd274d --- /dev/null +++ b/doc/manuals/images/icE1usb-e1_side.jpg Binary files differ diff --git a/doc/manuals/images/icE1usb-usb_side.jpg b/doc/manuals/images/icE1usb-usb_side.jpg new file mode 100644 index 0000000..5d833d6 --- /dev/null +++ b/doc/manuals/images/icE1usb-usb_side.jpg Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ifc382c762119b397dd9a6b484ebc9a237897fba9 Gerrit-Change-Number: 26949 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb doc: Link to wiki page about iso USB issues

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 ) Change subject: icE1usb doc: Link to wiki page about iso USB issues ...................................................................... icE1usb doc: Link to wiki page about iso USB issues Change-Id: Id5f555519d5e320570017178613c752591db4a2f --- M doc/manuals/chapters/firmware.adoc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/48/26948/1 diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc index 1b440bd..5ae5fb1 100644 --- a/doc/manuals/chapters/firmware.adoc +++ b/doc/manuals/chapters/firmware.adoc @@ -185,7 +185,8 @@ activation of both icE1usb ports simultaneously. The XHCI controller firmware erroneously claims that there is insufficient bus bandwidth. However, the same icE1usb hardware/firmware works perfectly fine with -OHCI, UHCI and EHCI host controllers. +OHCI, UHCI and EHCI host controllers. See +https://osmocom.org/projects/e1-t1-adapter/wiki/Isochronous_USB_Issues for a user-maintained list of USB hosts / controllers and whether or not they work with two E1 ports. As most modern [PC] hardware has XHCI host controllers, you need to choose your hardware carefully if concurrent operation of both icE1usb -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id5f555519d5e320570017178613c752591db4a2f Gerrit-Change-Number: 26948 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-ci[master]: jenkins-jobs: add master build for opencm3 projects

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26693 ) Change subject: jenkins-jobs: add master build for opencm3 projects ...................................................................... jenkins-jobs: add master build for opencm3 projects Change-Id: I95f84079478ce57d8d5c0cffd71bc67e1605e68e --- M jobs/master-builds.yml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 3b341ec..0c2be30 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -350,6 +350,9 @@ - simtrace2: cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' email: gerrit-log(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de + - osmo-opencm3-projects: + cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + email: gerrit-log(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de - osmo-e1d - osmo-cbc -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95f84079478ce57d8d5c0cffd71bc67e1605e68e Gerrit-Change-Number: 26693 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in osmo-mgw[master]: Make function amr_is_octet_aligned publicly available

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26822 ) Change subject: Make function amr_is_octet_aligned publicly available ...................................................................... Make function amr_is_octet_aligned publicly available it will be used by mgcp_iuup.c in follow-up patch. Change-Id: Iffaf90c1f713feef0c609a7581a346f5f28141d9 --- M include/osmocom/mgcp/mgcp_codec.h M src/libosmo-mgcp/mgcp_codec.c 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/22/26822/1 diff --git a/include/osmocom/mgcp/mgcp_codec.h b/include/osmocom/mgcp/mgcp_codec.h index 97650e4..97e6b8d 100644 --- a/include/osmocom/mgcp/mgcp_codec.h +++ b/include/osmocom/mgcp/mgcp_codec.h @@ -17,3 +17,4 @@ int mgcp_codec_pt_translate(struct mgcp_conn_rtp *conn_src, struct mgcp_conn_rtp *conn_dst, int payload_type); const struct mgcp_rtp_codec *mgcp_codec_pt_find_by_subtype_name(struct mgcp_conn_rtp *conn, const char *subtype_name, unsigned int match_nr); +bool mgcp_codec_amr_is_octet_aligned(const struct mgcp_rtp_codec *codec); diff --git a/src/libosmo-mgcp/mgcp_codec.c b/src/libosmo-mgcp/mgcp_codec.c index 70a6638..6b8d14a 100644 --- a/src/libosmo-mgcp/mgcp_codec.c +++ b/src/libosmo-mgcp/mgcp_codec.c @@ -355,7 +355,7 @@ * * https://tools.ietf.org/html/rfc4867 */ -static bool amr_is_octet_aligned(const struct mgcp_rtp_codec *codec) +bool mgcp_codec_amr_is_octet_aligned(const struct mgcp_rtp_codec *codec) { if (!codec->param_present) return false; @@ -379,7 +379,7 @@ if (strcmp(codec_a->subtype_name, codec_b->subtype_name)) return false; if (!strcmp(codec_a->subtype_name, "AMR")) { - if (amr_is_octet_aligned(codec_a) != amr_is_octet_aligned(codec_b)) + if (mgcp_codec_amr_is_octet_aligned(codec_a) != mgcp_codec_amr_is_octet_aligned(codec_b)) return false; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iffaf90c1f713feef0c609a7581a346f5f28141d9 Gerrit-Change-Number: 26822 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

3
3
0 0

Change in libosmocore[master]: osmo_fsm: Ensure all state and event names are valid identifiers

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 ) Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ...................................................................... Patch Set 7: (1 comment) File src/fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/1f3d90b6_861c25bb PS7, Line 296: "state name '%s'\n", states[i].name); > I think this is problematic. osmo_fsm_register() may be called before the log is set up. […] I think we should rather make sure that our logging subsystem does something useful (and not assert) if log output is generated before the log subsystem configuration is initialized. This has been hurting us over and over again. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7 Gerrit-Change-Number: 16355 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jan 2022 14:55:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: iuup: do not use illegal characters in state/event names.

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26947 ) Change subject: iuup: do not use illegal characters in state/event names. ...................................................................... iuup: do not use illegal characters in state/event names. The event names contain '.', and there are spaces ' ' in the state names. This is a problem since states and events can also be monitored via the CTRL interface. Unfortunately the CTRL interface does not allow certain reserved characters. So lets rename the states and event names to make them compatible with the CTRL interface. Change-Id: Id19973b56f9d7b1e3d0b0d7c7d0be7beba5428fc Related OS#4149 Change-Id: I5ebc9ab5b1456fee29aa4e254fae862dc053f0aa --- M src/gsm/iuup.c 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index dbca344..eb595ce 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -160,15 +160,15 @@ }; static const struct value_string iuup_fsm_event_names[] = { - { IUUP_FSM_EVT_IUUP_CONFIG_REQ, "IuUP-CONFIG.req" }, - { IUUP_FSM_EVT_IUUP_DATA_REQ, "IuUP-DATA.req" }, - { IUUP_FSM_EVT_IUUP_DATA_IND, "IuUP-DATA.ind" }, - { IUUP_FSM_EVT_IUUP_STATUS_REQ, "IuUP-STATUS.req" }, - { IUUP_FSM_EVT_IUUP_STATUS_IND, "IuUP-STATUS.ind" }, - { IUUP_FSM_EVT_SSASAR_UNITDATA_REQ, "SSSAR-UNITDATA.req" }, - { IUUP_FSM_EVT_SSASAR_UNITDATA_IND, "SSSAR-UNITDATA.ind" }, - { IUUP_FSM_EVT_IUUP_UNITDATA_REQ, "IuUP-UNITDATA.req" }, - { IUUP_FSM_EVT_IUUP_UNITDATA_IND, "IuUP-UNITDATA.ind" }, + { IUUP_FSM_EVT_IUUP_CONFIG_REQ, "IuUP-CONFIG-req" }, + { IUUP_FSM_EVT_IUUP_DATA_REQ, "IuUP-DATA-req" }, + { IUUP_FSM_EVT_IUUP_DATA_IND, "IuUP-DATA-ind" }, + { IUUP_FSM_EVT_IUUP_STATUS_REQ, "IuUP-STATUS-req" }, + { IUUP_FSM_EVT_IUUP_STATUS_IND, "IuUP-STATUS-ind" }, + { IUUP_FSM_EVT_SSASAR_UNITDATA_REQ, "SSSAR-UNITDATA-req" }, + { IUUP_FSM_EVT_SSASAR_UNITDATA_IND, "SSSAR-UNITDATA-ind" }, + { IUUP_FSM_EVT_IUUP_UNITDATA_REQ, "IuUP-UNITDATA-req" }, + { IUUP_FSM_EVT_IUUP_UNITDATA_IND, "IuUP-UNITDATA-ind" }, { IUUP_FSM_EVT_INIT, "INIT" }, { IUUP_FSM_EVT_LAST_INIT_ACK, "LAST_INIT_ACK" }, { IUUP_FSM_EVT_INIT_NACK, "INIT_NACK" }, @@ -789,7 +789,7 @@ S(IUUP_FSM_EVT_SSASAR_UNITDATA_REQ) | S(IUUP_FSM_EVT_SSASAR_UNITDATA_IND), .out_state_mask = S(IUUP_FSM_ST_NULL), - .name = "TrM Data Transfer Ready", + .name = "TrM_Data_Transfer_Ready", .action = iuup_fsm_trm_data, }, [IUUP_FSM_ST_INIT] = { @@ -808,7 +808,7 @@ S(IUUP_FSM_EVT_IUUP_DATA_IND), .out_state_mask = S(IUUP_FSM_ST_NULL) | S(IUUP_FSM_ST_INIT), - .name = "SMpSDU Data Transfer Ready", + .name = "SMpSDU_Data_Transfer_Ready", .action = iuup_fsm_smpsdu_data, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ebc9ab5b1456fee29aa4e254fae862dc053f0aa Gerrit-Change-Number: 26947 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: iuup: do not use illegal characters in state/event names.

by laforge

Attention is currently required from: osmith, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26947 ) Change subject: iuup: do not use illegal characters in state/event names. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ebc9ab5b1456fee29aa4e254fae862dc053f0aa Gerrit-Change-Number: 26947 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jan 2022 14:54:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log