- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 ) Change subject: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip ...................................................................... PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip The old values are not valid anymore when running against open5gs version 2.4.2. Most likely, the default addresses got changed during the PGW split-up (now it's open5gs-smfd and open5gs-upfd). Change-Id: I3dd7d1f0d4aebb94b8859e8d12e952917de35071 Related: SYS#5602 --- M pgw/PGW_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/26954/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index f026e58..c526fa2 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -19,14 +19,14 @@ modulepar { - charstring mp_pgw_hostname := "127.0.0.3"; + charstring mp_pgw_hostname := "127.0.0.4"; charstring mp_local_hostname_c := "127.0.0.1"; charstring mp_local_hostname_u := "127.0.0.1"; charstring mp_run_prog_as_user := "laforge"; charstring mp_ping_hostname := "10.45.0.1"; - charstring mp_pcrf_local_ip := "127.0.0.5"; + charstring mp_pcrf_local_ip := "127.0.0.9"; integer mp_pcrf_local_port := 3868; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3dd7d1f0d4aebb94b8859e8d12e952917de35071 Gerrit-Change-Number: 26954 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in dahdi-linux[master]: How did this ever work... stdbool.h is not in the kernel.

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26951 ) Change subject: How did this ever work... stdbool.h is not in the kernel. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a Gerrit-Change-Number: 26951 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Jan 2022 12:57:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in dahdi-linux[master]: How did this ever work... stdbool.h is not in the kernel.

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26951 ) Change subject: How did this ever work... stdbool.h is not in the kernel. ...................................................................... How did this ever work... stdbool.h is not in the kernel. Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/voicebus/vpmoct.h M drivers/dahdi/wcaxx-base.c M drivers/dahdi/wct4xxp/base.c M drivers/dahdi/wct4xxp/vpm450m.c M drivers/dahdi/wctc4xxp/base.c M drivers/dahdi/wctdm24xxp/base.c M drivers/dahdi/wcte12xp/base.c M drivers/dahdi/wcte13xp-base.c M drivers/dahdi/wcte43x-base.c M drivers/dahdi/wcxb.c M drivers/dahdi/wcxb_spi.h 12 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/51/26951/1 diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index cde56c1..96e4afd 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -86,7 +86,6 @@ #include "hpec/hpec_user.h" -#include <stdbool.h> #if defined(EMPULSE) && defined(EMFLASH) #error "You cannot define both EMPULSE and EMFLASH" diff --git a/drivers/dahdi/voicebus/vpmoct.h b/drivers/dahdi/voicebus/vpmoct.h index cb55826..5c90946 100644 --- a/drivers/dahdi/voicebus/vpmoct.h +++ b/drivers/dahdi/voicebus/vpmoct.h @@ -30,7 +30,6 @@ #include <linux/timer.h> #include "dahdi/kernel.h" -#include <stdbool.h> #define VPMOCT_FIRM_HEADER_LEN 32 #define VPMOCT_BOOT_RAM_LEN 128 diff --git a/drivers/dahdi/wcaxx-base.c b/drivers/dahdi/wcaxx-base.c index b934960..8467767 100644 --- a/drivers/dahdi/wcaxx-base.c +++ b/drivers/dahdi/wcaxx-base.c @@ -34,7 +34,6 @@ #include <linux/firmware.h> #include <linux/crc32.h> -#include <stdbool.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30) diff --git a/drivers/dahdi/wct4xxp/base.c b/drivers/dahdi/wct4xxp/base.c index 3412402..9d5b9a9 100644 --- a/drivers/dahdi/wct4xxp/base.c +++ b/drivers/dahdi/wct4xxp/base.c @@ -42,7 +42,6 @@ #include <linux/crc32.h> #include <linux/slab.h> -#include <stdbool.h> #include <dahdi/kernel.h> #include "wct4xxp.h" diff --git a/drivers/dahdi/wct4xxp/vpm450m.c b/drivers/dahdi/wct4xxp/vpm450m.c index 82a0463..38c68ab 100644 --- a/drivers/dahdi/wct4xxp/vpm450m.c +++ b/drivers/dahdi/wct4xxp/vpm450m.c @@ -28,7 +28,6 @@ #include <linux/version.h> #include <dahdi/kernel.h> -#include <stdbool.h> #include "vpm450m.h" #include <oct612x.h> diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index 3bd56d1..7ff3456 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -39,7 +39,6 @@ #include <linux/etherdevice.h> #include <linux/timer.h> -#include <stdbool.h> #include <dahdi/kernel.h> diff --git a/drivers/dahdi/wctdm24xxp/base.c b/drivers/dahdi/wctdm24xxp/base.c index 16bf384..6571f17 100644 --- a/drivers/dahdi/wctdm24xxp/base.c +++ b/drivers/dahdi/wctdm24xxp/base.c @@ -54,7 +54,6 @@ #include <linux/crc32.h> #include <linux/slab.h> -#include <stdbool.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30) /* Define this if you would like to load the modules in parallel. While this diff --git a/drivers/dahdi/wcte12xp/base.c b/drivers/dahdi/wcte12xp/base.c index e8a5861..c73acdd 100644 --- a/drivers/dahdi/wcte12xp/base.c +++ b/drivers/dahdi/wcte12xp/base.c @@ -43,7 +43,6 @@ #include <linux/slab.h> -#include <stdbool.h> #include <dahdi/kernel.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0) diff --git a/drivers/dahdi/wcte13xp-base.c b/drivers/dahdi/wcte13xp-base.c index b5f8043..69f7099 100644 --- a/drivers/dahdi/wcte13xp-base.c +++ b/drivers/dahdi/wcte13xp-base.c @@ -35,7 +35,6 @@ #include <linux/sched.h> #include <linux/crc32.h> -#include <stdbool.h> #include <dahdi/kernel.h> #include "wct4xxp/wct4xxp.h" /* For certain definitions */ diff --git a/drivers/dahdi/wcte43x-base.c b/drivers/dahdi/wcte43x-base.c index 45b0f6c..d164a69 100644 --- a/drivers/dahdi/wcte43x-base.c +++ b/drivers/dahdi/wcte43x-base.c @@ -43,7 +43,6 @@ #include <linux/firmware.h> #include <oct612x.h> -#include <stdbool.h> #include <dahdi/kernel.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0) diff --git a/drivers/dahdi/wcxb.c b/drivers/dahdi/wcxb.c index 122f9d3..3db22ee 100644 --- a/drivers/dahdi/wcxb.c +++ b/drivers/dahdi/wcxb.c @@ -36,7 +36,6 @@ #include <dahdi/kernel.h> -#include <stdbool.h> #include "wcxb.h" #include "wcxb_spi.h" diff --git a/drivers/dahdi/wcxb_spi.h b/drivers/dahdi/wcxb_spi.h index 418cd77..4575f14 100644 --- a/drivers/dahdi/wcxb_spi.h +++ b/drivers/dahdi/wcxb_spi.h @@ -24,7 +24,6 @@ #define __WCXB_SPI_H #include <linux/spi/spi.h> -#include <stdbool.h> struct wcxb_spi_transfer { const void *tx_buf; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a Gerrit-Change-Number: 26951 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: osmo_fsm: Ensure all state and event names are valid identifiers

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 ) Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ...................................................................... Patch Set 7: (1 comment) File src/fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/7b3eb13e_158754cd PS7, Line 296: "state name '%s'\n", states[i].name); > I think we should rather make sure that our logging subsystem does something useful (and not assert) […] Yes, lets do that before we eliminate the problematic state and event names. I have seen that my patch for the IuUP FSM has been merged, so XXXX.ind -> XXXX-req will become the norm. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7 Gerrit-Change-Number: 16355 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Jan 2022 12:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 10:32:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/21f67758_40a8cc31 PS1, Line 59: log_initialized > Unfortunately that is not possible because log_check_level() is called before logp2() by the macro. […] Ah, right, understood. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:53:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: (2 comments) File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/b1648fea_e8cadc6b PS1, Line 59: log_initialized > Can we have this check in logp2() to avoid duplication, BTW? Unfortunately that is not possible because log_check_level() is called before logp2() by the macro. What we could do though is modify log_check_level() so that it always returns 1 when the log is not initialized and then check in logp2 buts that is also not very attractive, so I think accepting a bit of duplication is the better option. File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/d2ac706f_991a93a2 PS1, Line 765: printf > I agree with Harald here, why not fprintf(stderr, ... […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:31:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by dexter

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26950 to look at the new patch set (#2). Change subject: logging: log to stdout when logging is not initialized ...................................................................... logging: log to stdout when logging is not initialized When the logging framework is not initialized we get an error: "ERROR: osmo_log_info == NULL! You must call log_init() before using logging in ..." There are sometimes situations where some code tries to log before logging was initialied. This is a problem because the actual log line with the debug info we need is covered up by the error message from the logging framework. Lets introduce a fallback logging function that is called when the the logging framework is not available. This function can just use printf. Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 --- M include/osmocom/core/logging.h M src/logging.c 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26950/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > logging before explicit logging initialization: what about some low-level initialization code in __a […] makes sense, thanks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by fixeria

Attention is currently required from: osmith, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/6ff11f68_b7ecf0bd PS1, Line 59: log_initialized Can we have this check in logp2() to avoid duplication, BTW? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log