Change in libosmocore[master]: logging: log to stdout when logging is not initialized
Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: (2 comments) File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/b1648fea_e8cadc6b PS1, Line 59: log_initialized
Can we have this check in logp2() to avoid duplication, BTW? Unfortunately that is not possible because log_check_level() is called before logp2() by the macro.
What we could do though is modify log_check_level() so that it always returns 1 when the log is not initialized and then check in logp2 buts that is also not very attractive, so I think accepting a bit of duplication is the better option. File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/d2ac706f_991a93a2 PS1, Line 765: printf
I agree with Harald here, why not fprintf(stderr, ... […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:31:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
dexter