Attention is currently required from: fixeria.

View Change

2 comments:

• File include/osmocom/core/logging.h:

  • Patch Set #1, Line 59: log_initialized

    Can we have this check in logp2() to avoid duplication, BTW?

    Unfortunately that is not possible because log_check_level() is called before logp2() by the macro.

    What we could do though is modify log_check_level() so that it always returns 1 when the log is not initialized and then check in logp2 buts that is also not very attractive, so I think accepting a bit of duplication is the better option.

• File src/logging.c:

  • Patch Set #1, Line 765: printf

    I agree with Harald here, why not fprintf(stderr, ... […]

    Done

To view, visit change 26950. To unsubscribe, or for help writing mail filters, visit settings.