- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: PFCP: add DLPFCP and osmo-upf port numbers

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26606 ) Change subject: PFCP: add DLPFCP and osmo-upf port numbers ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea Gerrit-Change-Number: 26606 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 00:00:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: PFCP: add DLPFCP and osmo-upf port numbers

by neels

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26606 to look at the new patch set (#3). Change subject: PFCP: add DLPFCP and osmo-upf port numbers ...................................................................... PFCP: add DLPFCP and osmo-upf port numbers Related: SYS#5599 Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea --- M include/osmocom/core/logging.h M include/osmocom/ctrl/ports.h M include/osmocom/vty/ports.h M src/logging.c M tests/logging/logging_vty_test.vty 5 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/26606/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea Gerrit-Change-Number: 26606 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in pysim[master]: implement shell command to update PLMN in IMSI

by Bjoern Riemer

Bjoern Riemer has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26959 ) Change subject: implement shell command to update PLMN in IMSI ...................................................................... implement shell command to update PLMN in IMSI Add file specific command `update_imsi_plmn` to EF_IMSI to replace the mcc and mnc part of the imsi for use in bulk_script(s) Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc --- M pySim/ts_51_011.py 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/59/26959/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 847ed98..96941b2 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -470,10 +470,34 @@ class EF_IMSI(TransparentEF): def __init__(self, fid='6f07', sfid=None, name='EF.IMSI', desc='IMSI', size={9,9}): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size) + # add those commands to the general commands of a TransparentEF + self.shell_commands += [self.AddlShellCommands(self)] def _decode_hex(self, raw_hex): return {'imsi': dec_imsi(raw_hex)} def _encode_hex(self, abstract): return enc_imsi(abstract['imsi']) + @with_default_category('File-Specific Commands') + class AddlShellCommands(CommandSet): + def __init__(self,ef:TransparentEF): + super().__init__() + self._ef=ef + + def do_update_imsi_plmn(self, arg: string): + """Change the plmn part of the IMSI""" + plmn = arg.strip() + if len(plmn) == 5: + (data, sw) = self._cmd.rs.read_binary_dec() + if sw == '9000' and len(data['imsi']) == 15: + imsi = data['imsi'] + msin = imsi[5:] + (data, sw) = self._cmd.rs.update_binary_dec({'imsi': plmn+msin}) + if sw == '9000' and data: + self._cmd.poutput_json(self._cmd.rs.selected_file.decode_hex(data)) + else: + raise ValueError("invalid imsi") + else: + raise ValueError("PLMN has wrong length (xxxyy)") + # TS 51.011 Section 10.3.4 class EF_PLMNsel(TransRecEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in pysim[master]: catch and ignore SwMatchError on probing for AID's

by Bjoern Riemer

Bjoern Riemer has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26958 ) Change subject: catch and ignore SwMatchError on probing for AID's ...................................................................... catch and ignore SwMatchError on probing for AID's When probing applications on a card by running select_adf_by_aid() SwMatchError exceptions indicating the non exsistance of that application on the card should be ignored. Change-Id: I3aa7deaf46bdf352a201c3089b3714405a06f281 --- M pySim/filesystem.py 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/58/26958/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index dfe1677..32688db 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1113,11 +1113,13 @@ # Some card applications may not be registered in EF.DIR, we will actively # probe for those applications for f in set(apps_profile) - set(apps_taken): - data, sw = self.card.select_adf_by_aid(f.aid) - if sw == "9000": - print(" %s: %s" % (f.name, f.aid)) - apps_taken.append(f) - + try: + data, sw = self.card.select_adf_by_aid(f.aid) + if sw == "9000": + print(" %s: %s" % (f.name, f.aid)) + apps_taken.append(f) + except SwMatchError: + pass return apps_taken def reset(self, cmd_app=None) -> Hexstr: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3aa7deaf46bdf352a201c3089b3714405a06f281 Gerrit-Change-Number: 26958 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in pysim[master]: add missing bit definition for NG-RAN in xAcT

by Bjoern Riemer

Bjoern Riemer has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26956 ) Change subject: add missing bit definition for NG-RAN in xAcT ...................................................................... add missing bit definition for NG-RAN in xAcT when encoding the AcT value bit 11 is correctly set when NG-RAN is present in the string representation, however the decoding of bit 11 was missing. Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 --- M pySim/utils.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/56/26956/1 diff --git a/pySim/utils.py b/pySim/utils.py index e30c970..1806d0d 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -464,6 +464,7 @@ act_list = [ {'bit': 15, 'name': "UTRAN"}, {'bit': 14, 'name': "E-UTRAN"}, + {'bit': 11, 'name': "NG-RAN"}, {'bit': 7, 'name': "GSM"}, {'bit': 6, 'name': "GSM COMPACT"}, {'bit': 5, 'name': "cdma2000 HRPD"}, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 Gerrit-Change-Number: 26956 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in pysim[master]: update testdata with the new NG-RAN AcT values

by Bjoern Riemer

Bjoern Riemer has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26957 ) Change subject: update testdata with the new NG-RAN AcT values ...................................................................... update testdata with the new NG-RAN AcT values Change-Id: I881eadc7ae4b2c4aaaa0a37898f32be9e127f11a --- M pysim-testdata/Fairwaves-SIM.ok M pysim-testdata/Wavemobile-SIM.ok M pysim-testdata/sysmoISIM-SJA2.ok M pysim-testdata/sysmoUSIM-SJS1.ok 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/57/26957/1 diff --git a/pysim-testdata/Fairwaves-SIM.ok b/pysim-testdata/Fairwaves-SIM.ok index 2a912e2..f07c033 100644 --- a/pysim-testdata/Fairwaves-SIM.ok +++ b/pysim-testdata/Fairwaves-SIM.ok @@ -31,7 +31,7 @@ ffffff0000 # unused HPLMNAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused diff --git a/pysim-testdata/Wavemobile-SIM.ok b/pysim-testdata/Wavemobile-SIM.ok index 0eb8cc8..d8f1a6f 100644 --- a/pysim-testdata/Wavemobile-SIM.ok +++ b/pysim-testdata/Wavemobile-SIM.ok @@ -11,7 +11,7 @@ Hide in OPLMN: False PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff PLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -29,7 +29,7 @@ ffffff0000 # unused OPLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok index 87cb857..a8c98d9 100644 --- a/pysim-testdata/sysmoISIM-SJA2.ok +++ b/pysim-testdata/sysmoISIM-SJA2.ok @@ -11,7 +11,7 @@ Hide in OPLMN: True PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff PLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -25,7 +25,7 @@ ffffff0000 # unused OPLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -39,7 +39,7 @@ ffffff0000 # unused HPLMNAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused diff --git a/pysim-testdata/sysmoUSIM-SJS1.ok b/pysim-testdata/sysmoUSIM-SJS1.ok index e65f276..14d7110 100644 --- a/pysim-testdata/sysmoUSIM-SJS1.ok +++ b/pysim-testdata/sysmoUSIM-SJS1.ok @@ -11,7 +11,7 @@ Hide in OPLMN: True PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff PLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -25,7 +25,7 @@ ffffff0000 # unused OPLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -39,7 +39,7 @@ ffffff0000 # unused HPLMNAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I881eadc7ae4b2c4aaaa0a37898f32be9e127f11a Gerrit-Change-Number: 26957 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in dahdi-linux[master]: How did this ever work... stdbool.h is not in the kernel.

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26951 ) Change subject: How did this ever work... stdbool.h is not in the kernel. ...................................................................... How did this ever work... stdbool.h is not in the kernel. Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/voicebus/vpmoct.h M drivers/dahdi/wcaxx-base.c M drivers/dahdi/wct4xxp/base.c M drivers/dahdi/wct4xxp/vpm450m.c M drivers/dahdi/wctc4xxp/base.c M drivers/dahdi/wctdm24xxp/base.c M drivers/dahdi/wcte12xp/base.c M drivers/dahdi/wcte13xp-base.c M drivers/dahdi/wcte43x-base.c M drivers/dahdi/wcxb.c M drivers/dahdi/wcxb_spi.h 12 files changed, 0 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index cde56c1..96e4afd 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -86,7 +86,6 @@ #include "hpec/hpec_user.h" -#include <stdbool.h> #if defined(EMPULSE) && defined(EMFLASH) #error "You cannot define both EMPULSE and EMFLASH" diff --git a/drivers/dahdi/voicebus/vpmoct.h b/drivers/dahdi/voicebus/vpmoct.h index cb55826..5c90946 100644 --- a/drivers/dahdi/voicebus/vpmoct.h +++ b/drivers/dahdi/voicebus/vpmoct.h @@ -30,7 +30,6 @@ #include <linux/timer.h> #include "dahdi/kernel.h" -#include <stdbool.h> #define VPMOCT_FIRM_HEADER_LEN 32 #define VPMOCT_BOOT_RAM_LEN 128 diff --git a/drivers/dahdi/wcaxx-base.c b/drivers/dahdi/wcaxx-base.c index b934960..8467767 100644 --- a/drivers/dahdi/wcaxx-base.c +++ b/drivers/dahdi/wcaxx-base.c @@ -34,7 +34,6 @@ #include <linux/firmware.h> #include <linux/crc32.h> -#include <stdbool.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30) diff --git a/drivers/dahdi/wct4xxp/base.c b/drivers/dahdi/wct4xxp/base.c index 3412402..9d5b9a9 100644 --- a/drivers/dahdi/wct4xxp/base.c +++ b/drivers/dahdi/wct4xxp/base.c @@ -42,7 +42,6 @@ #include <linux/crc32.h> #include <linux/slab.h> -#include <stdbool.h> #include <dahdi/kernel.h> #include "wct4xxp.h" diff --git a/drivers/dahdi/wct4xxp/vpm450m.c b/drivers/dahdi/wct4xxp/vpm450m.c index 82a0463..38c68ab 100644 --- a/drivers/dahdi/wct4xxp/vpm450m.c +++ b/drivers/dahdi/wct4xxp/vpm450m.c @@ -28,7 +28,6 @@ #include <linux/version.h> #include <dahdi/kernel.h> -#include <stdbool.h> #include "vpm450m.h" #include <oct612x.h> diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index 3bd56d1..7ff3456 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -39,7 +39,6 @@ #include <linux/etherdevice.h> #include <linux/timer.h> -#include <stdbool.h> #include <dahdi/kernel.h> diff --git a/drivers/dahdi/wctdm24xxp/base.c b/drivers/dahdi/wctdm24xxp/base.c index 16bf384..6571f17 100644 --- a/drivers/dahdi/wctdm24xxp/base.c +++ b/drivers/dahdi/wctdm24xxp/base.c @@ -54,7 +54,6 @@ #include <linux/crc32.h> #include <linux/slab.h> -#include <stdbool.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30) /* Define this if you would like to load the modules in parallel. While this diff --git a/drivers/dahdi/wcte12xp/base.c b/drivers/dahdi/wcte12xp/base.c index e8a5861..c73acdd 100644 --- a/drivers/dahdi/wcte12xp/base.c +++ b/drivers/dahdi/wcte12xp/base.c @@ -43,7 +43,6 @@ #include <linux/slab.h> -#include <stdbool.h> #include <dahdi/kernel.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0) diff --git a/drivers/dahdi/wcte13xp-base.c b/drivers/dahdi/wcte13xp-base.c index b5f8043..69f7099 100644 --- a/drivers/dahdi/wcte13xp-base.c +++ b/drivers/dahdi/wcte13xp-base.c @@ -35,7 +35,6 @@ #include <linux/sched.h> #include <linux/crc32.h> -#include <stdbool.h> #include <dahdi/kernel.h> #include "wct4xxp/wct4xxp.h" /* For certain definitions */ diff --git a/drivers/dahdi/wcte43x-base.c b/drivers/dahdi/wcte43x-base.c index 45b0f6c..d164a69 100644 --- a/drivers/dahdi/wcte43x-base.c +++ b/drivers/dahdi/wcte43x-base.c @@ -43,7 +43,6 @@ #include <linux/firmware.h> #include <oct612x.h> -#include <stdbool.h> #include <dahdi/kernel.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0) diff --git a/drivers/dahdi/wcxb.c b/drivers/dahdi/wcxb.c index 122f9d3..3db22ee 100644 --- a/drivers/dahdi/wcxb.c +++ b/drivers/dahdi/wcxb.c @@ -36,7 +36,6 @@ #include <dahdi/kernel.h> -#include <stdbool.h> #include "wcxb.h" #include "wcxb_spi.h" diff --git a/drivers/dahdi/wcxb_spi.h b/drivers/dahdi/wcxb_spi.h index 418cd77..4575f14 100644 --- a/drivers/dahdi/wcxb_spi.h +++ b/drivers/dahdi/wcxb_spi.h @@ -24,7 +24,6 @@ #define __WCXB_SPI_H #include <linux/spi/spi.h> -#include <stdbool.h> struct wcxb_spi_transfer { const void *tx_buf; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a Gerrit-Change-Number: 26951 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in dahdi-linux[master]: How did this ever work... stdbool.h is not in the kernel.

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26951 ) Change subject: How did this ever work... stdbool.h is not in the kernel. ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a Gerrit-Change-Number: 26951 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Jan 2022 17:20:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 ) Change subject: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip ...................................................................... PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip The old values are not valid anymore when running against open5gs version 2.4.2. Most likely, the default addresses got changed during the PGW split-up (now it's open5gs-smfd and open5gs-upfd). Change-Id: I3dd7d1f0d4aebb94b8859e8d12e952917de35071 Related: SYS#5602 --- M pgw/PGW_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index f026e58..c526fa2 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -19,14 +19,14 @@ modulepar { - charstring mp_pgw_hostname := "127.0.0.3"; + charstring mp_pgw_hostname := "127.0.0.4"; charstring mp_local_hostname_c := "127.0.0.1"; charstring mp_local_hostname_u := "127.0.0.1"; charstring mp_run_prog_as_user := "laforge"; charstring mp_ping_hostname := "10.45.0.1"; - charstring mp_pcrf_local_ip := "127.0.0.5"; + charstring mp_pcrf_local_ip := "127.0.0.9"; integer mp_pcrf_local_port := 3868; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3dd7d1f0d4aebb94b8859e8d12e952917de35071 Gerrit-Change-Number: 26954 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/GTPv2_Emulation: fix timer not being started in f_uecups_xcei...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26952 ) Change subject: library/GTPv2_Emulation: fix timer not being started in f_uecups_xceive() ...................................................................... library/GTPv2_Emulation: fix timer not being started in f_uecups_xceive() This change fixes the following error: Dynamic test case error: None of the branches can be chosen in the alt statement in file GTPv2_Emulation.ttcn between lines 362 and 370. which may happen when osmo-uecups-daemon fails to create a tunnel due to insufficient permissions. Change-Id: Icb229aed7fa9dedcf999837ec6ad249ab4fdebb7 Related: SYS#5602 --- M library/GTPv2_Emulation.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/GTPv2_Emulation.ttcn b/library/GTPv2_Emulation.ttcn index 8074269..f07afcb 100644 --- a/library/GTPv2_Emulation.ttcn +++ b/library/GTPv2_Emulation.ttcn @@ -359,6 +359,7 @@ var UECUPS_RecvFrom mrf; UECUPS.send(t_UECUPS_Send(g_uecups_conn_id, tx)); + T.start; alt { [] UECUPS.receive(tr_UECUPS_RecvFrom_R(rx_t)) -> value mrf { } [] UECUPS.receive(tr_SctpAssocChange) { repeat; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb229aed7fa9dedcf999837ec6ad249ab4fdebb7 Gerrit-Change-Number: 26952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log