Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 )
Change subject: trxcon: Initial support for forwarding AMR
......................................................................
Patch Set 3:
(3 comments)
File src/host/trxcon/src/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/69326fb0_b3b366c2
PS3, Line 47: sched_tchf_dl_amr_cmi_map
Cool! Would you submit a patch to osmo-bts.git adding this table there?
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/b2f119a8_5972d30c
PS3, Line 48: [11] = 1, /* TCH/F: a=4 / h=11 */
Please fix the alignment, I find the old variant a bit easier to read.
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/15131430_ca972957
PS3, Line 56: ul_amr_fn_is_cmi
This function can be replaced with sched_tchf_ul_amr_cmi_map[] from patchset 2.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331
Gerrit-Change-Number: 29264
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 17:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29256 )
Change subject: osmux: Drop long time deprecated APIs
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I plan to merge this tomorrow if nobody is against it & providing a good reason to avoid it.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853
Gerrit-Change-Number: 29256
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 17:52:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 )
Change subject: trxcon: Initial support for forwarding AMR
......................................................................
Patch Set 3: -Code-Review
(1 comment)
Patchset:
PS3:
With this new version of the patch I fixed several stuff which allows also passing BTS_Tests.TC_speech_rtp_tchf with AMR enabled. I submitted a patch to enable it.
tch/h support is still missing, I'll write & submit a follow up patch adding support for it soon.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331
Gerrit-Change-Number: 29264
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 17:46:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter.
Hello Jenkins Builder, laforge, fixeria, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/29264
to look at the new patch set (#3).
Change subject: trxcon: Initial support for forwarding AMR
......................................................................
trxcon: Initial support for forwarding AMR
This allows TTCN3 L1CTL module (used in BTS_Tests) to transmit and
receive AMR payloads towards osmo-bts-trx.
Related: SYS#5987
Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331
---
M include/l1ctl_proto.h
M src/host/layer23/src/common/l1ctl.c
M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h
M src/host/trxcon/include/osmocom/bb/l1sched/logging.h
M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
M src/host/trxcon/src/l1ctl.c
M src/host/trxcon/src/sched_lchan_tchf.c
M src/host/trxcon/src/trxcon_fsm.c
M src/host/virt_phy/src/l1ctl_sap.c
M src/target/firmware/layer1/l23_api.c
10 files changed, 219 insertions(+), 56 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/29264/3
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331
Gerrit-Change-Number: 29264
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29268
to look at the new patch set (#3).
Change subject: BSC: Implement RSL_IE_MultirateCfg and use it in BSC_Tests
......................................................................
BSC: Implement RSL_IE_MultirateCfg and use it in BSC_Tests
Change-Id: I0a5ddce570c0fd70f096d897b0b609d20b552ff7
---
M bsc/BSC_Tests.ttcn
M library/RSL_Types.ttcn
2 files changed, 35 insertions(+), 25 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/29268/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a5ddce570c0fd70f096d897b0b609d20b552ff7
Gerrit-Change-Number: 29268
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266
to look at the new patch set (#5).
Change subject: bts: Pass AMR codec info over L1CTL and RSL
......................................................................
bts: Pass AMR codec info over L1CTL and RSL
Related: SYS#5987
Depends: osmocom-bb.git Change-Id Ia20bc96e39726a919a556c83c8be48cb31af7331
Change-Id: I3db7f6a4b7819b16ada83862f2a5409db4fa21f9
---
M bts/BTS_Tests.ttcn
M library/L1CTL_PortType.ttcn
M library/L1CTL_Types.ttcn
3 files changed, 33 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/29266/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3db7f6a4b7819b16ada83862f2a5409db4fa21f9
Gerrit-Change-Number: 29266
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29234 )
Change subject: README.md: update git URLs (git -> https; gitea)
......................................................................
README.md: update git URLs (git -> https; gitea)
Change-Id: Ia86979f656557e442b0f432b0646aa7661c293e9
---
M README.md
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/README.md b/README.md
index 9eab71c..e268d23 100644
--- a/README.md
+++ b/README.md
@@ -23,10 +23,10 @@
You can clone from the official Osmocom git repository using
```
-git clone git://git.osmocom.org/pysim.git
+git clone https://gitea.osmocom.org/sim-card/pysim.git
```
-There is a cgit interface at <https://git.osmocom.org/pysim>
+There is a web interface at <https://gitea.osmocom.org/sim-card/pysim>.
Installation
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/29234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia86979f656557e442b0f432b0646aa7661c293e9
Gerrit-Change-Number: 29234
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged