- gerrit-log - lists.osmocom.org

Change in pysim[master]: README.md: fix module name: s/serial/pyserial/
by fixeria 05 Sep '22

05 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29229 ) Change subject: README.md: fix module name: s/serial/pyserial/ ...................................................................... README.md: fix module name: s/serial/pyserial/ Change-Id: I5fd308fb161cd5bd5f702845691296877e523248 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/README.md b/README.md index 75885fd..66bc0ce 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ Please install the following dependencies: - pyscard - - serial + - pyserial - pytlv - cmd2 >= 1.3.0 but < 2.0.0 - jsonpath-ng 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5fd308fb161cd5bd5f702845691296877e523248 Gerrit-Change-Number: 29229 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: Bump minimum required construct version to v2.9.51
by fixeria 05 Sep '22

05 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29227 ) Change subject: Bump minimum required construct version to v2.9.51 ...................................................................... Bump minimum required construct version to v2.9.51 With this version I can get all unittests passing: python -m unittest discover tests/ We're passing argument 'path' to stream_read_entire(), which was added in [1] and become available since v2.9.51. Change-Id: I4223c83570d333ad8d79bc2aa2d8bcc580156cff Related: [1] bfe71315b027e18e62f00ec4de75043992fd2316 construct.git Related: OS#5666 --- M setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/setup.py b/setup.py index ec1a76a..b9ad1bf 100644 --- a/setup.py +++ b/setup.py @@ -14,7 +14,7 @@ "pytlv", "cmd2 >= 1.3.0, < 2.0.0", "jsonpath-ng", - "construct >= 2.9", + "construct >= 2.9.51", "bidict", "gsm0338", "termcolor", 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4223c83570d333ad8d79bc2aa2d8bcc580156cff Gerrit-Change-Number: 29227 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: README.md,requirements.txt: add missing construct version info
by fixeria 05 Sep '22

05 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29228 ) Change subject: README.md,requirements.txt: add missing construct version info ...................................................................... README.md,requirements.txt: add missing construct version info Change-Id: I90da0df431f0d7dbfa4aa428366fbf0e35db388f Related: OS#5666 --- M README.md M requirements.txt 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/README.md b/README.md index e10820f..75885fd 100644 --- a/README.md +++ b/README.md @@ -39,7 +39,7 @@ - pytlv - cmd2 >= 1.3.0 but < 2.0.0 - jsonpath-ng - - construct + - construct >= 2.9.51 - bidict - gsm0338 diff --git a/requirements.txt b/requirements.txt index 320cc7a..4f037da 100644 --- a/requirements.txt +++ b/requirements.txt @@ -3,7 +3,7 @@ pytlv cmd2==1.5 jsonpath-ng -construct +construct>=2.9.51 bidict gsm0338 pyyaml>=5.1 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I90da0df431f0d7dbfa4aa428366fbf0e35db388f Gerrit-Change-Number: 29228 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: construct: use Python's API for int<->bytes conversion
by fixeria 05 Sep '22

05 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29226 ) Change subject: construct: use Python's API for int<->bytes conversion ...................................................................... construct: use Python's API for int<->bytes conversion Argument 'signed' was added in [1] and become available since v2.10.63. Therefore using bytes2integer() and integer2bytes() from construct.core bumps the minimum required version of construct to v2.10.63. For instance, debian:bullseye currently ships v2.10.58. There is no strict requirement to use construct's API, so let's use Python's API instead. This allows using older construct versions from the v2.9.xx family. Change-Id: I613dbfebe993f9c19003635371941710fc1b1236 Related: [1] 660ddbe2d9a351731ad7976351adbf413809a715 construct.git Related: OS#5666 --- M pySim/construct.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/construct.py b/pySim/construct.py index 4910a7f..97af235 100644 --- a/pySim/construct.py +++ b/pySim/construct.py @@ -2,7 +2,7 @@ from construct.core import EnumIntegerString import typing from construct import * -from construct.core import evaluate, bytes2integer, integer2bytes, BitwisableString +from construct.core import evaluate, BitwisableString from construct.lib import integertypes from pySim.utils import b2h, h2b, swap_nibbles import gsm0338 @@ -219,7 +219,7 @@ if evaluate(self.swapped, context): data = swapbytes(data) try: - return bytes2integer(data, self.signed) + return int.from_bytes(data, byteorder='big', signed=self.signed) except ValueError as e: raise IntegerError(str(e), path=path) @@ -248,7 +248,7 @@ raise IntegerError(f"value {obj} is not an integer", path=path) length = self.__bytes_required(obj, self.minlen) try: - data = integer2bytes(obj, length, self.signed) + data = obj.to_bytes(length, byteorder='big', signed=self.signed) except ValueError as e: raise IntegerError(str(e), path=path) if evaluate(self.swapped, context): 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I613dbfebe993f9c19003635371941710fc1b1236 Gerrit-Change-Number: 29226 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: contrib/jenkins.sh: execute this script with -x and -e
by fixeria 05 Sep '22

05 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29236 ) Change subject: contrib/jenkins.sh: execute this script with -x and -e ...................................................................... contrib/jenkins.sh: execute this script with -x and -e -x Print commands and their arguments as they are executed -e Exit immediately if a command exits with a non-zero status Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f5cf8a2..1100acf 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/sh -xe # jenkins build helper script for pysim. This is how we build on jenkins.osmocom.org # # environment variables: @@ -6,8 +6,6 @@ # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") # -set -e - if [ ! -d "./pysim-testdata/" ] ; then echo "###############################################" echo "Please call from pySim-prog top directory" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 Gerrit-Change-Number: 29236 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: contrib/jenkins.sh: install dependencies from requirements.txt
by fixeria 05 Sep '22

05 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29237 ) Change subject: contrib/jenkins.sh: install dependencies from requirements.txt ...................................................................... contrib/jenkins.sh: install dependencies from requirements.txt Change-Id: I99af496e9a3758ea624ca484f4fbc51b262ffaf4 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1100acf..a061c7e 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -15,15 +15,7 @@ virtualenv -p python3 venv --system-site-packages . venv/bin/activate -pip install pytlv -pip install 'pyyaml>=5.1' -pip install cmd2==1.5 -pip install jsonpath-ng -pip install construct -pip install bidict -pip install gsm0338 -pip install termcolor -pip install colorlog +pip install -r requirements.txt # Execute automatically discovered unit tests first python -m unittest discover -v -s tests/ 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I99af496e9a3758ea624ca484f4fbc51b262ffaf4 Gerrit-Change-Number: 29237 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in pysim[master]: contrib/jenkins.sh: execute this script with -x and -e
by fixeria 05 Sep '22

05 Sep '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29236 ) Change subject: contrib/jenkins.sh: execute this script with -x and -e ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/29236/comment/95fec3b8_10509131 PS2, Line 9: set -e > is now redundant, can be removed Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 Gerrit-Change-Number: 29236 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 16:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in pysim[master]: contrib/jenkins.sh: execute this script with -x and -e
by fixeria 05 Sep '22

05 Sep '22

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/29236 to look at the new patch set (#3). Change subject: contrib/jenkins.sh: execute this script with -x and -e ...................................................................... contrib/jenkins.sh: execute this script with -x and -e -x Print commands and their arguments as they are executed -e Exit immediately if a command exits with a non-zero status Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/29236/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 Gerrit-Change-Number: 29236 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmocom-bb[master]: trxcon: Initial support for forwarding AMR
by pespin 05 Sep '22

05 Sep '22

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29264 ) Change subject: trxcon: Initial support for forwarding AMR ...................................................................... Patch Set 2: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331 Gerrit-Change-Number: 29264 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 16:12:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: Pass AMR codec info over L1CTL
by fixeria 05 Sep '22

05 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266 ) Change subject: Pass AMR codec info over L1CTL ...................................................................... Patch Set 4: Code-Review+1 (4 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/9dfab72c_1f1d… PS2, Line 2513: 0 > Can also be made configurable via g_pars.amr_start_codec. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/e18900c4_a821… PS2, Line 2521: 00000100 > I suggest to make this value configurable via g_pars.amr_codecs. Done File library/L1CTL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/e09f345c_3178… PS2, Line 184: start_codec > Either prefix both fields with 'amr_', or wrap into a record: […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/211f0de4_ab7d… PS2, Line 288: start_codec > Same here. You may also define it as a separate record to avoid code dup. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3db7f6a4b7819b16ada83862f2a5409db4fa21f9 Gerrit-Change-Number: 29266 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 15:32:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log