- gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: proto_trxd: add helpers to prepare burst indication packets
by Timur Davydov 14 Mar '26

14 Mar '26

Attention is currently required from: fixeria. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email ) Change subject: proto_trxd: add helpers to prepare burst indication packets ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/proto_trxd.h: https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/2f7050b7_80b44481?usp… : PS2, Line 39: trxd_prepare_burst_ind_v0 > This will be used in the following commits. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd Gerrit-Change-Number: 42357 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Mar 2026 06:34:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XL] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by Timur Davydov 14 Mar '26

14 Mar '26

Attention is currently required from: Hoernchen, fixeria, laforge, osmith. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email ) Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... Patch Set 10: (1 comment) File Transceiver52M/device/usdr/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/c35a89a8_49299d39?usp… : PS8, Line 5: AM_CXXFLAGS > No specific reason — I removed it. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 10 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Mar 2026 06:33:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: proto_trxd: add helpers to prepare burst indication packets
by Timur Davydov 14 Mar '26

14 Mar '26

Attention is currently required from: fixeria. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email ) Change subject: proto_trxd: add helpers to prepare burst indication packets ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/proto_trxd.h: https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/8529860b_b38f5a1c?usp… : PS2, Line 39: trxd_prepare_burst_ind_v0 > Why exposing this API? Is it used anywhere else outside of proto_trxd. […] This will be used in the following commits. In the WebUSB-based setup the bursts will not be sent via a socket. Instead, the TRXD packet is prepared and passed through a callback to the web frontend, which then forwards it to the SDR device via WebUSB for transmission over RF. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd Gerrit-Change-Number: 42357 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 22:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: proto_trxd: add helpers to prepare burst indication packets
by fixeria 14 Mar '26

14 Mar '26

Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email ) Change subject: proto_trxd: add helpers to prepare burst indication packets ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/proto_trxd.h: https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/a400e269_240d3843?usp… : PS2, Line 39: trxd_prepare_burst_ind_v0 Why exposing this API? Is it used anywhere else outside of proto_trxd.c? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd Gerrit-Change-Number: 42357 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 13 Mar 2026 21:16:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in ...osmo-s1gw[master]: enb_proxy: add initial MME pooling support
by fixeria 14 Mar '26

14 Mar '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624?usp=email ) Change subject: enb_proxy: add initial MME pooling support ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I83dc4a78c78a7b87e87f5ca9a941a168d6c1dc36 Gerrit-Change-Number: 41624 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 21:15:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: proto_trxd: add helpers to prepare burst indication packets
by Timur Davydov 14 Mar '26

14 Mar '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: proto_trxd: add helpers to prepare burst indication packets ...................................................................... proto_trxd: add helpers to prepare burst indication packets - introduce trxd_prepare_burst_ind_v0() and trxd_prepare_burst_ind_v1() - reuse prepared packet size in send helpers - handle idle frames during packet preparation - use ssize_t consistently for prepared/write sizes Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd --- M Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 2 files changed, 62 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/42357/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd Gerrit-Change-Number: 42357 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: proto_trxd: add helpers to prepare burst indication packets
by Jenkins Builder 14 Mar '26

14 Mar '26

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email ) Change subject: proto_trxd: add helpers to prepare burst indication packets ...................................................................... Patch Set 1: (8 comments) File Transceiver52M/proto_trxd.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/2d4c3133_daa54266?usp… : PS1, Line 39: ssize_t trxd_prepare_burst_ind_v0(const struct trx_ul_burst_ind *bi, char* buf, size_t maxLen); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/7168f61b_3862689a?usp… : PS1, Line 42: ssize_t trxd_prepare_burst_ind_v1(const struct trx_ul_burst_ind *bi, char* buffer, size_t maxLen); "foo* bar" should be "foo *bar" File Transceiver52M/proto_trxd.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/5cc79935_e9484e3f?usp… : PS1, Line 68: ssize_t trxd_prepare_burst_ind_v0(const struct trx_ul_burst_ind *bi, char* buf, size_t maxLen) "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/d1a18647_f1623f81?usp… : PS1, Line 92: bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/b208edf2_adb9eb4f?usp… : PS1, Line 114: ssize_t trxd_prepare_burst_ind_v1(const struct trx_ul_burst_ind *bi, char* buffer, size_t maxLen) "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/37f76ac5_245adf76?usp… : PS1, Line 123: struct trxd_hdr_v1* pkt = (struct trxd_hdr_v1*)buffer; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/f4a3d7cc_c332189e?usp… : PS1, Line 123: struct trxd_hdr_v1* pkt = (struct trxd_hdr_v1*)buffer; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/9b1118a1_ed8c37c7?usp… : PS1, Line 134: bool trxd_send_burst_ind_v1(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd Gerrit-Change-Number: 42357 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 13 Mar 2026 20:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: proto_trxd: add helpers to prepare burst indication packets
by Timur Davydov 14 Mar '26

14 Mar '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email ) Change subject: proto_trxd: add helpers to prepare burst indication packets ...................................................................... proto_trxd: add helpers to prepare burst indication packets - introduce trxd_prepare_burst_ind_v0() and trxd_prepare_burst_ind_v1() - reuse prepared packet size in send helpers - handle idle frames during packet preparation - use ssize_t consistently for prepared/write sizes Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd --- M Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 2 files changed, 59 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/42357/1 diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c index e5a889d..7cfd0a3 100644 --- a/Transceiver52M/proto_trxd.c +++ b/Transceiver52M/proto_trxd.c @@ -65,15 +65,18 @@ soft_bits[i] = (uint8_t) round(bi->rx_burst[i] * 255.0); } -bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { - int rc; - - /* v0 doesn't support idle frames, they are simply dropped, not sent */ - if (bi->idle) - return true; - +ssize_t trxd_prepare_burst_ind_v0(const struct trx_ul_burst_ind *bi, char* buf, size_t maxLen) +{ /* +2: Historically (OpenBTS times), two extra non-used bytes are sent appended to each burst */ - char buf[sizeof(struct trxd_hdr_v0) + bi->nbits + 2]; + const size_t buf_len = sizeof(struct trxd_hdr_v0) + bi->nbits + 2; + + if (maxLen < buf_len) + return -1; + + /* v0 doesn't support idle frames, they are not filled */ + if (bi->idle) + return 0; + struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)buf; trxd_fill_common(&pkt->common, bi, 0); @@ -83,24 +86,41 @@ /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi->nbits] */ pkt->soft_bits[bi->nbits + 1] = '\0'; - rc = write(fd, buf, sizeof(struct trxd_hdr_v0) + bi->nbits + 2); + return buf_len; +} + +bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { + /* +2: Historically (OpenBTS times), two extra non-used bytes are sent appended to each burst */ + char buf[sizeof(struct trxd_hdr_v0) + bi->nbits + 2]; + + const ssize_t pktsz = trxd_prepare_burst_ind_v0(bi, buf, sizeof(buf)); + if (pktsz < 0) { + CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "trxd_prepare_burst_ind_v0 failed: %zd\n", pktsz); + return false; + } + + /* packet size 0 indicates idle frames, they are simply dropped, not sent */ + if (pktsz == 0) + return true; + + const ssize_t rc = write(fd, buf, pktsz); if (rc <= 0) { - CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %d\n", fd, rc); + CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %zd\n", fd, rc); return false; } return true; } -bool trxd_send_burst_ind_v1(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { - int rc; - size_t buf_len; - - buf_len = sizeof(struct trxd_hdr_v1); +ssize_t trxd_prepare_burst_ind_v1(const struct trx_ul_burst_ind *bi, char* buffer, size_t maxLen) +{ + size_t buf_len = sizeof(struct trxd_hdr_v1); if (!bi->idle) buf_len += bi->nbits; - char buf[buf_len]; - struct trxd_hdr_v1* pkt = (struct trxd_hdr_v1*)buf; + if (maxLen < buf_len) + return -1; + + struct trxd_hdr_v1* pkt = (struct trxd_hdr_v1*)buffer; trxd_fill_common(&pkt->common, bi, 1); trxd_fill_v0_specific(&pkt->v0, bi); trxd_fill_v1_specific(&pkt->v1, bi); @@ -108,9 +128,26 @@ if (!bi->idle) trxd_fill_burst_normalized255(&pkt->soft_bits[0], bi); - rc = write(fd, buf, buf_len); + return buf_len; +} + +bool trxd_send_burst_ind_v1(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { + size_t buf_len; + + buf_len = sizeof(struct trxd_hdr_v1); + if (!bi->idle) + buf_len += bi->nbits; + char buf[buf_len]; + + const ssize_t pktsize = trxd_prepare_burst_ind_v1(bi, buf, buf_len); + if (pktsize <= 0) { + CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "trxd_prepare_burst_ind_v1 failed: %zd\n", pktsize); + return false; + } + + const ssize_t rc = write(fd, buf, pktsize); if (rc <= 0) { - CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %d\n", fd, rc); + CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %zd\n", fd, rc); return false; } return true; diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h index c250a74..e7e2e68 100644 --- a/Transceiver52M/proto_trxd.h +++ b/Transceiver52M/proto_trxd.h @@ -36,7 +36,10 @@ float ci; // Carrier-to-Interference ratio, in dB }; +ssize_t trxd_prepare_burst_ind_v0(const struct trx_ul_burst_ind *bi, char* buf, size_t maxLen); bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi); + +ssize_t trxd_prepare_burst_ind_v1(const struct trx_ul_burst_ind *bi, char* buffer, size_t maxLen); bool trxd_send_burst_ind_v1(size_t chan, int fd, const struct trx_ul_burst_ind *bi); /* The latest supported TRXD header format version */ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd Gerrit-Change-Number: 42357 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in ...osmo-s1gw[master]: enb_proxy: fix stale SCTP events misprocessed during MME pool selection
by fixeria 14 Mar '26

14 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42356?usp=email ) Change subject: enb_proxy: fix stale SCTP events misprocessed during MME pool selection ...................................................................... enb_proxy: fix stale SCTP events misprocessed during MME pool selection When closing a connection to one MME and opening a new one to the next, a SHUTDOWN_COMP event from the old (now-closed) socket can still be pending in the process mailbox. The sctp_assoc_change handlers in the 'connecting' and 'wait_s1setup_rsp' states were matching '_Socket', ignoring the socket identity. A stale SHUTDOWN_COMP would therefore fall into the '_ -> repeat_state_and_data' branch, triggering a spurious re-entry of 'connecting', which immediately closed the newly established connection to the next MME and skipped to yet another pool entry. Fix this by matching the Socket against the current S#state.sock in both handlers. Events arriving on a previously closed socket no longer match these clauses and are silently dropped by the catch-all handle_event/4. This was found thanks to the MME pooling TCs in ttcn3-s1gw-test. Change-Id: I4211dd343607f045cf4dd33fa568ed580c79dd9f Related: SYS#7052 --- M src/enb_proxy.erl 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/56/42356/1 diff --git a/src/enb_proxy.erl b/src/enb_proxy.erl index 5ab79d1..3ce205f 100644 --- a/src/enb_proxy.erl +++ b/src/enb_proxy.erl @@ -235,9 +235,11 @@ keep_state_and_data; %% Handle an #sctp_assoc_change event (connection state) -connecting(info, {sctp, _Socket, MmeAddr, MmePort, +%% Match on Socket to avoid processing stale events from a previously closed socket +connecting(info, {sctp, Socket, MmeAddr, MmePort, {[], #sctp_assoc_change{state = ConnState, - assoc_id = Aid}}}, S) -> + assoc_id = Aid}}}, + #state{sock = Socket} = S) -> MmeName = hd(S#state.tried_mmes), case ConnState of comm_up -> @@ -315,9 +317,11 @@ %% Handle an #sctp_assoc_change event (MME connection state) %% We may loose connection while waiting for the S1 SETUP RESPONSE -wait_s1setup_rsp(info, {sctp, _Socket, MmeAddr, MmePort, +%% Match on Socket to avoid processing stale events from a previously closed socket +wait_s1setup_rsp(info, {sctp, Socket, MmeAddr, MmePort, {[], #sctp_assoc_change{state = ConnState, - assoc_id = Aid}}}, S) -> + assoc_id = Aid}}}, + #state{sock = Socket} = S) -> case ConnState of comm_up -> ?LOG_NOTICE("MME connection (id=~p, ~p:~p) is already established?!?", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4211dd343607f045cf4dd33fa568ed580c79dd9f Gerrit-Change-Number: 42356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-ccid-firmware[master]: fw source: force reformat once and for all
by Hoernchen 14 Mar '26

14 Mar '26

Attention is currently required from: laforge, osmith. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email ) Change subject: fw source: force reformat once and for all ...................................................................... Patch Set 2: (8 comments) Patchset: PS1: > The approach I've taken with checkpatch (from linux. […] clang-format formats and that is the end of it, no discussions, NOTHING EVER AGAIN. That is the advantage and the reason why everyone uses a clang format file and why even the kernel has one, for the style we allegedly use, but clearly, we don't do that, and therefore we can didscuss formatting again and again and again... File ccid_common/ccid_device.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/39b5d33c_b9… : PS1, Line 547: // break; > not useful IMHO. this is also in other places in this patch. yeah but consistent and enforcable and easy to unindent after uncommenting the block. File ccid_common/ccid_proto.h: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/c171a0bb_89… : PS1, Line 366: #define CCID_CMD_STATUS_TIME_EXT 0x80 > here and in enum ccid_error_code below, it is more readable to keep the values directly below each o […] looks more aligned now File ccid_common/ccid_proto.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/23f69532_6e… : PS1, Line 70: { CCID_ERR_CMD_ABORTED, "CMD_ABORTED" }, > +1 this is the alignment of arrays of structs. its either left, right, or one long line that breaks at 120 chars. neither left nor right is more or less readable than the randomly indented version and an random long line is obviously even worse, but at least this is consistent and can be applied and checked. File ccid_common/iso7816_3.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/0781494e_2d… : PS1, Line 50: 0, > doesn't seem useful to reformat it like this? it is definitely more readable than a sneaky semicolon at the end, and it's the kernel style we allegedly use... File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/f73fce2c_be… : PS1, Line 168: static const uint8_t convention_convert_lut[256] = { > yeah, that looks like it's not intended. fixed by telling clang-format to keep it like that https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/0546c4f8_84… : PS1, Line 818: .in_event_mask = S(ISO7816_E_RX_SINGLE) | S(ISO7816_E_RX_COMPL) | S(ISO7816_E_TX_COMPL) | S(ISO7816_E_RX_ERR_IND) | S(ISO7816_E_TX_ERR_IND) | S(ISO7816_E_TPDU_DONE_IND), > https://gerrit.osmocom. […] fixed by telling clang-format to keep it like this File sysmoOCTSIM/usb_descriptors.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/eb879bb2_28… : PS1, Line 227: 4, > this also clearly is not an improvement of readability at all. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 13 Mar 2026 19:37:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log