Attention is currently required from: laforge, neels.
neels has uploaded a new patch set (#11) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214?usp=email )
The following approvals got outdated and were removed:
Code-Review-1 by neels, Verified+1 by Jenkins Builder
Change subject: invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318
......................................................................
invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318
There are two different RTP HR GSM formats defined:
- 3GPP TS 101.318
- RFC5993
They differ by one zero padding byte at the start of the RTP payload.
Conversion code already exists prior to this patch.
To allow configuring the conversion from MGCP clients,
invent a new osmocom-specific fmtp parameter for GSM-HR:
gsm-hr-format=3gpp-ts-101.318
gsm-hr-format=rfc5993
If an MGCP client indicates this parameter in the GSM-HR's fmtp and an
incoming RTP GSM HR packet mismatches that format, convert to the
indicated format.
An SDP example:
m=audio 1234 RTP/AVP 111
a=rtpmap:111 GSM-HR-08/8000/1
a=fmtp:111 gsm-hr-format=3gpp-ts-101.318
Patch-by: pmaier nhofmeyr
Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4
Related: OS#5688
---
M include/osmocom/mgcp/fmtp.h
M include/osmocom/mgcp/mgcp_common.h
M src/libosmo-mgcp/fmtp.c
M src/libosmo-mgcp/mgcp_network.c
4 files changed, 131 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/14/31214/11
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4
Gerrit-Change-Number: 31214
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34898?usp=email )
Change subject: mgcp_parse_audio_port_pt(): fix buffer overflow
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34898/comment/e7c40dda_92252c49
PS1, Line 321: /* Do not allow excessive payload types */
> why is this r->ptmap now? I see you are acessing r->codecs[count] below...
oh, artifact from a future patch! good catch, thanks!
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34898?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I18c78d15eb1593f404b4741248225b68878b463f
Gerrit-Change-Number: 34898
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Oct 2023 21:02:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34902?usp=email )
Change subject: filesystem: add flag to tell whether an ADF supports an FS or not
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
strictly speaking, in terms of terminology an application with AID and no filesystem probably doesn't even have an "ADF" to begin with? Do you agree with that? Do you know any spec reference explaining this?
If this is true maybe we can find a way in pySim to express this also in the class model... i.e. have something that is *not* a derived class from CardFile which one can select? Probably not easy, but at least worth thinking about, IMHO
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34902?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ifd0f7c34164685ea18d8a746394e55416fa0aa66
Gerrit-Change-Number: 34902
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Oct 2023 15:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34897?usp=email )
Change subject: runtime: fix tracking of selected_adf
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I now see that self.selected_adf refers to RuntimeState. But shouldn't that be per-lchan state to begin with?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34897?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4cc0c58ff887422b4f3954d35c8380ddc00baa1d
Gerrit-Change-Number: 34897
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Oct 2023 15:20:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34897?usp=email )
Change subject: runtime: fix tracking of selected_adf
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
this fix works. Hoever, it might be less error-prone in the future, if the RuntimeLchan would have a method for selecting ADF by AID which automatically updated that member variable? This way any future callers might not run into the same trap of just calling the method without updating state.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34897?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4cc0c58ff887422b4f3954d35c8380ddc00baa1d
Gerrit-Change-Number: 34897
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Oct 2023 15:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34903?usp=email )
Change subject: transport: print reader device/number on init
......................................................................
transport: print reader device/number on init
When we initialize the reader, we currently tell only which type of
interface we are using, but we do not print the reader number or the
device path.
Let's extend the messages so that the path is printed. To prevent
problems with integration-tests, let's also add an environment variable
that we can use to detect when pySim runs inside a integration-test.
Related: OS#6210
Change-Id: Ibe296d51885b1ef5f9c9ecaf1d28da52014dcc4b
---
M pySim/transport/calypso.py
M pySim/transport/modem_atcmd.py
M pySim/transport/pcsc.py
M pySim/transport/serial.py
M tests/pySim-prog_test.sh
M tests/pySim-trace_test.sh
6 files changed, 40 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/transport/calypso.py b/pySim/transport/calypso.py
index ea97b69..98330a9 100644
--- a/pySim/transport/calypso.py
+++ b/pySim/transport/calypso.py
@@ -79,8 +79,10 @@
def __init__(self, sock_path: str = "/tmp/osmocom_l2", **kwargs):
super().__init__(**kwargs)
- print("Using Calypso-based (OsmocomBB) reader interface")
-
+ if os.environ.get('PYSIM_INTEGRATION_TEST') == "1":
+ print("Using Calypso-based (OsmocomBB) reader interface")
+ else:
+ print("Using Calypso-based (OsmocomBB) reader at socket %s" % sock_path)
# Make sure that a given socket path exists
if not os.path.exists(sock_path):
raise ReaderError(
diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py
index fee09c8..71f76e2 100644
--- a/pySim/transport/modem_atcmd.py
+++ b/pySim/transport/modem_atcmd.py
@@ -21,6 +21,7 @@
import time
import re
import argparse
+import os
from typing import Optional
from pySim.utils import Hexstr, ResTuple
@@ -36,7 +37,10 @@
def __init__(self, device: str = '/dev/ttyUSB0', baudrate: int = 115200, **kwargs):
super().__init__(**kwargs)
- print("Using modem for Generic SIM Access (3GPP TS 27.007)")
+ if os.environ.get('PYSIM_INTEGRATION_TEST') == "1":
+ print("Using modem for Generic SIM Access (3GPP TS 27.007)")
+ else:
+ print("Using modem for Generic SIM Access (3GPP TS 27.007) at port %s" % device)
self._sl = serial.Serial(device, baudrate, timeout=5)
self._echo = False # this will be auto-detected by _check_echo()
self._device = device
diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py
index fbe7c0f..762908c 100644
--- a/pySim/transport/pcsc.py
+++ b/pySim/transport/pcsc.py
@@ -18,6 +18,7 @@
#
import argparse
+import os
from typing import Optional
from smartcard.CardConnection import CardConnection
@@ -35,7 +36,10 @@
def __init__(self, reader_number: int = 0, **kwargs):
super().__init__(**kwargs)
- print("Using PC/SC reader interface")
+ if os.environ.get('PYSIM_INTEGRATION_TEST') == "1":
+ print("Using PC/SC reader interface")
+ else:
+ print("Using PC/SC reader number %u" % reader_number)
r = readers()
if reader_number >= len(r):
raise ReaderError('No reader found for number %d' % reader_number)
diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py
index 867317c..ad800ed 100644
--- a/pySim/transport/serial.py
+++ b/pySim/transport/serial.py
@@ -18,7 +18,7 @@
import serial
import time
-import os.path
+import os
import argparse
from typing import Optional
@@ -33,7 +33,10 @@
def __init__(self, device: str = '/dev/ttyUSB0', baudrate: int = 9600, rst: str = '-rts',
debug: bool = False, **kwargs):
super().__init__(**kwargs)
- print("Using serial reader interface")
+ if os.environ.get('PYSIM_INTEGRATION_TEST') == "1":
+ print("Using serial reader interface")
+ else:
+ print("Using serial reader interface at port %s" % device)
if not os.path.exists(device):
raise ValueError("device file %s does not exist -- abort" % device)
self._sl = serial.Serial(
diff --git a/tests/pySim-prog_test.sh b/tests/pySim-prog_test.sh
index f518618..28d9777 100755
--- a/tests/pySim-prog_test.sh
+++ b/tests/pySim-prog_test.sh
@@ -25,6 +25,7 @@
TEMPFILE=temp.tmp
PYTHON=python3
+export PYSIM_INTEGRATION_TEST=1
set -e
echo "pySim-prog_test - a test program to test pySim-prog.py"
diff --git a/tests/pySim-trace_test.sh b/tests/pySim-trace_test.sh
index 4ccb2aa..f7b97e8 100755
--- a/tests/pySim-trace_test.sh
+++ b/tests/pySim-trace_test.sh
@@ -24,6 +24,8 @@
GSMTAP_TRACE=pySim-trace_test_gsmtap.pcapng
TEMPFILE=temp.tmp
+export PYSIM_INTEGRATION_TEST=1
+
echo "pySim-trace_test - a test program to test pySim-trace.py"
echo "========================================================"
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34903?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibe296d51885b1ef5f9c9ecaf1d28da52014dcc4b
Gerrit-Change-Number: 34903
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: merged