Attention is currently required from: laforge, neels. neels has uploaded a new patch set (#11) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214?usp=email ) The following approvals got outdated and were removed: Code-Review-1 by neels, Verified+1 by Jenkins Builder Change subject: invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318 ...................................................................... invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318 There are two different RTP HR GSM formats defined: - 3GPP TS 101.318 - RFC5993 They differ by one zero padding byte at the start of the RTP payload. Conversion code already exists prior to this patch. To allow configuring the conversion from MGCP clients, invent a new osmocom-specific fmtp parameter for GSM-HR: gsm-hr-format=3gpp-ts-101.318 gsm-hr-format=rfc5993 If an MGCP client indicates this parameter in the GSM-HR's fmtp and an incoming RTP GSM HR packet mismatches that format, convert to the indicated format. An SDP example: m=audio 1234 RTP/AVP 111 a=rtpmap:111 GSM-HR-08/8000/1 a=fmtp:111 gsm-hr-format=3gpp-ts-101.318 Patch-by: pmaier nhofmeyr Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Related: OS#5688 --- M include/osmocom/mgcp/fmtp.h M include/osmocom/mgcp/mgcp_common.h M src/libosmo-mgcp/fmtp.c M src/libosmo-mgcp/mgcp_network.c 4 files changed, 131 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/14/31214/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-MessageType: newpatchset